fix: isolate review-mutation ledger from host session-state (Closes #590) #592

Merged

sysadmin merged 2 commits from fix/issue-590-ledger-isolation into master

2026-07-09 16:32:03 -05:00

Author	SHA1	Message	Date
sysadmin	008cd3fd74	fix: keep tests free of host MCP stale-runtime probes (#590 ) patch.dict(os.environ, clear=True) also drops PYTEST_CURRENT_TEST, which re-enables live MCP process health checks against operator daemons and makes merge-gate unit tests environment-dependent. Stub the diagnostic in conftest so unit tests stay isolated.	2026-07-09 17:20:09 -04:00
sysadmin	11ffe0f9dd	fix: isolate review-mutation ledger from host session-state (#590 ) Tests that call patch.dict(os.environ, clear=True) dropped GITEA_MCP_SESSION_STATE_DIR and re-adopted the operator host cache under ~/.cache/gitea-tools/session-state. A residual terminal request_changes mutation then tripped the #332 hard-stop before test_unknown_profile_blocks could assert the empty-profile gate. - Pin mcp_session_state.default_state_dir / DEFAULT_STATE_DIR to a per-test temp dir in conftest (still honors an explicit env override) - Clear the decision lock at the start of each TestMergePR test - Add regression coverage for env-clear isolation Closes #590	2026-07-09 17:19:29 -04:00

Author

SHA1

Message

Date

sysadmin

008cd3fd74

fix: keep tests free of host MCP stale-runtime probes (#590 )

patch.dict(os.environ, clear=True) also drops PYTEST_CURRENT_TEST, which
re-enables live MCP process health checks against operator daemons and
makes merge-gate unit tests environment-dependent. Stub the diagnostic
in conftest so unit tests stay isolated.

2026-07-09 17:20:09 -04:00

sysadmin

11ffe0f9dd

fix: isolate review-mutation ledger from host session-state (#590 )

Tests that call patch.dict(os.environ, clear=True) dropped
GITEA_MCP_SESSION_STATE_DIR and re-adopted the operator host cache
under ~/.cache/gitea-tools/session-state. A residual terminal
request_changes mutation then tripped the #332 hard-stop before
test_unknown_profile_blocks could assert the empty-profile gate.

- Pin mcp_session_state.default_state_dir / DEFAULT_STATE_DIR to a
  per-test temp dir in conftest (still honors an explicit env override)
- Clear the decision lock at the start of each TestMergePR test
- Add regression coverage for env-clear isolation

Closes #590

2026-07-09 17:19:29 -04:00