Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

feat: terminal launcher diagnostics and mutation preflight (Closes #556) #580

Closed
jcwalker3 wants to merge 0 commits from feat/issue-556-terminal-launcher-diagnose into master
pull from: feat/issue-556-terminal-launcher-diagnose
merge into: :master
Conversation 20 Commits - Files Changed -
jcwalker3 commented 2026-07-09 09:29:26 -05:00
Owner
Copy Link
Copy Source

Summary

Addresses #556: when terminal spawn fails (e.g. os error 2), workflows need categorized diagnostics and a fail-closed preflight instead of opaque retries or unsafe fallbacks.

Changes

  • native_mcp_preference.py — diagnose_terminal_failure / probe_terminal_spawn classify missing cwd, non-dir cwd, missing executable, missing runtime wrapper (venv/pytest), missing shell, probe timeout, or session launcher failure.
  • gitea_mcp_server.py — read-only gitea_diagnose_terminal tool; mutation-task gitea_resolve_task_capability probes the launcher and returns BLOCKED + DIAGNOSE with terminal_launcher_unhealthy when unhealthy.
  • Tests for diagnostics, probe, capability block path (GITEA_FORCE_TERMINAL_PROBE=1 under pytest).
  • Runbook section for the operator path.

Validation

python -m pytest tests/test_native_mcp_preference.py tests/test_resolve_task_capability.py -q
# 42 passed

Notes

  • Host agent run_terminal_command failures remain a platform concern; this PR makes Gitea-Tools detect and stop safely before git/pytest finalization.
  • Probe is skipped under pytest by default; set GITEA_FORCE_TERMINAL_PROBE=1 to exercise it in tests.

Closes #556

Worktree

branches/feat-issue-556-terminal-launcher-diagnose
Branch: feat/issue-556-terminal-launcher-diagnose

## Summary Addresses #556: when terminal spawn fails (e.g. `os error 2`), workflows need categorized diagnostics and a fail-closed preflight instead of opaque retries or unsafe fallbacks. ## Changes - `native_mcp_preference.py` — `diagnose_terminal_failure` / `probe_terminal_spawn` classify missing cwd, non-dir cwd, missing executable, missing runtime wrapper (venv/pytest), missing shell, probe timeout, or session launcher failure. - `gitea_mcp_server.py` — read-only `gitea_diagnose_terminal` tool; mutation-task `gitea_resolve_task_capability` probes the launcher and returns `BLOCKED + DIAGNOSE` with `terminal_launcher_unhealthy` when unhealthy. - Tests for diagnostics, probe, capability block path (`GITEA_FORCE_TERMINAL_PROBE=1` under pytest). - Runbook section for the operator path. ## Validation ```text python -m pytest tests/test_native_mcp_preference.py tests/test_resolve_task_capability.py -q # 42 passed ``` ## Notes - Host agent `run_terminal_command` failures remain a platform concern; this PR makes Gitea-Tools detect and stop safely before git/pytest finalization. - Probe is skipped under pytest by default; set `GITEA_FORCE_TERMINAL_PROBE=1` to exercise it in tests. Closes #556 ## Worktree `branches/feat-issue-556-terminal-launcher-diagnose` Branch: `feat/issue-556-terminal-launcher-diagnose`
jcwalker3 added 1 commit 2026-07-09 09:29:27 -05:00
feat: terminal launcher diagnostics and mutation preflight (Closes #556) 223cde1b94 
Add categorize-and-probe helpers for shell spawn failures, expose
gitea_diagnose_terminal, and fail closed on mutation capability resolve
when the terminal launcher is unhealthy (BLOCKED + DIAGNOSE). Document
the operator path in the workflow runbooks.
sysadmin commented 2026-07-09 09:34:23 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: 223cde1b94
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:34:22Z
expires_at: 2026-07-09T16:34:22Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: 223cde1b941a6ead9d6435e11235010ee6222c05 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:34:22Z expires_at: 2026-07-09T16:34:22Z blocker: none
sysadmin commented 2026-07-09 09:39:12 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: 223cde1b94
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:39:10Z
expires_at: 2026-07-09T16:39:10Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: 223cde1b941a6ead9d6435e11235010ee6222c05 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:39:10Z expires_at: 2026-07-09T16:39:10Z blocker: none
sysadmin commented 2026-07-09 09:40:24 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: 223cde1b94
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:40:21Z
expires_at: 2026-07-09T16:40:21Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: 223cde1b941a6ead9d6435e11235010ee6222c05 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:40:21Z expires_at: 2026-07-09T16:40:21Z blocker: none
jcwalker3 added 1 commit 2026-07-09 09:43:55 -05:00
test: cover explicit git -C terminal probe f558b80cc8
sysadmin commented 2026-07-09 09:44:44 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: 223cde1b94
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:44:44Z
expires_at: 2026-07-09T16:44:44Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: 223cde1b941a6ead9d6435e11235010ee6222c05 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:44:44Z expires_at: 2026-07-09T16:44:44Z blocker: none
sysadmin commented 2026-07-09 09:46:29 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:46:28Z
expires_at: 2026-07-09T16:46:28Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:46:28Z expires_at: 2026-07-09T16:46:28Z blocker: none
sysadmin commented 2026-07-09 09:46:37 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:46:35Z
expires_at: 2026-07-09T16:46:35Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:46:35Z expires_at: 2026-07-09T16:46:35Z blocker: none
sysadmin commented 2026-07-09 09:47:18 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:47:16Z
expires_at: 2026-07-09T16:47:16Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:47:16Z expires_at: 2026-07-09T16:47:16Z blocker: none
sysadmin commented 2026-07-09 09:47:25 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:47:23Z
expires_at: 2026-07-09T16:47:23Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:47:23Z expires_at: 2026-07-09T16:47:23Z blocker: none
sysadmin commented 2026-07-09 09:49:28 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:49:27Z
expires_at: 2026-07-09T16:49:27Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:49:27Z expires_at: 2026-07-09T16:49:27Z blocker: none
sysadmin commented 2026-07-09 09:49:40 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:49:38Z
expires_at: 2026-07-09T16:49:38Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:49:38Z expires_at: 2026-07-09T16:49:38Z blocker: none
sysadmin commented 2026-07-09 09:50:15 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:50:14Z
expires_at: 2026-07-09T16:50:14Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:50:14Z expires_at: 2026-07-09T16:50:14Z blocker: none
sysadmin commented 2026-07-09 09:51:02 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:51:01Z
expires_at: 2026-07-09T16:51:01Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:51:01Z expires_at: 2026-07-09T16:51:01Z blocker: none
sysadmin approved these changes 2026-07-09 09:51:16 -05:00
sysadmin left a comment
Owner
Copy Link
Copy Source

Canonical PR State

STATE: review-approved
WHO_IS_NEXT: merger
NEXT_ACTION: merge PR #580 after explicit operator authorization
NEXT_PROMPT:

Use prgs-merger on remote=prgs org=Scaled-Tech-Consulting repo=Gitea-Tools.
Merge PR #580 at expected_head_sha=f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 only if still approved and mergeable.
Do not re-approve. Do not merge other PRs in this run without separate authorization.

WHAT_HAPPENED: Reviewed PR #580 for issue #556; approved head f558b80cc8.
WHY: Scope is limited to terminal diagnostics + preflight + tests + runbook; validation passed.
ISSUE: #556
HEAD_SHA: f558b80cc8
REVIEW_STATUS: APPROVED
MERGE_READY: yes (awaiting explicit merge authorization)
BLOCKERS: none
VALIDATION: git diff --check clean; pytest tests/test_native_mcp_preference.py tests/test_resolve_task_capability.py → 43 passed
LAST_UPDATED_BY: sysadmin (prgs-reviewer)

Review notes

  • Not self-review (author jcwalker3).
  • Includes follow-up commit for explicit git -C worktree probe coverage.
  • Preflight on all GITEA_MUTATION_TASKS is conservative fail-closed (non-blocking note).
## Canonical PR State STATE: review-approved WHO_IS_NEXT: merger NEXT_ACTION: merge PR #580 after explicit operator authorization NEXT_PROMPT: ```text Use prgs-merger on remote=prgs org=Scaled-Tech-Consulting repo=Gitea-Tools. Merge PR #580 at expected_head_sha=f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 only if still approved and mergeable. Do not re-approve. Do not merge other PRs in this run without separate authorization. ``` WHAT_HAPPENED: Reviewed PR #580 for issue #556; approved head f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72. WHY: Scope is limited to terminal diagnostics + preflight + tests + runbook; validation passed. ISSUE: #556 HEAD_SHA: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 REVIEW_STATUS: APPROVED MERGE_READY: yes (awaiting explicit merge authorization) BLOCKERS: none VALIDATION: git diff --check clean; pytest tests/test_native_mcp_preference.py tests/test_resolve_task_capability.py → 43 passed LAST_UPDATED_BY: sysadmin (prgs-reviewer) ## Review notes - Not self-review (author jcwalker3). - Includes follow-up commit for explicit git -C worktree probe coverage. - Preflight on all GITEA_MUTATION_TASKS is conservative fail-closed (non-blocking note).
sysadmin commented 2026-07-09 09:56:00 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66242-d5706668e24f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556
phase: claimed
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T14:55:58Z
expires_at: 2026-07-09T16:55:58Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 66242-d5706668e24f worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-580-issue-556 phase: claimed candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T14:55:58Z expires_at: 2026-07-09T16:55:58Z blocker: none
sysadmin commented 2026-07-09 10:37:00 -05:00
Owner
Copy Link
Copy Source

adopted_at: 2026-07-09T15:36:57Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 66242-d5706668e24f
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 8156
adoption_reason: merger-handoff-approved-head

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 1956-aa22dbda40f7
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merger-queue
phase: adopted
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T15:36:57Z
expires_at: 2026-07-09T17:36:57Z
blocker: none

<!-- mcp-review-lease-adoption:v1 --> adopted_at: 2026-07-09T15:36:57Z adopted_by_identity: sysadmin adopted_by_profile: prgs-merger adopted_from_session_id: 66242-d5706668e24f adopted_from_profile: prgs-reviewer adopted_from_reviewer_identity: sysadmin adopted_from_comment_id: 8156 adoption_reason: merger-handoff-approved-head <!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-merger session_id: 1956-aa22dbda40f7 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merger-queue phase: adopted candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T15:36:57Z expires_at: 2026-07-09T17:36:57Z blocker: none
sysadmin commented 2026-07-09 10:43:00 -05:00
Owner
Copy Link
Copy Source

adopted_at: 2026-07-09T15:42:57Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 1956-aa22dbda40f7
adopted_from_profile: prgs-merger
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 8199
adoption_reason: merger-handoff-approved-head

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 31616-fe56940d16c2
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merger-queue
phase: adopted
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T15:42:57Z
expires_at: 2026-07-09T17:42:57Z
blocker: none

<!-- mcp-review-lease-adoption:v1 --> adopted_at: 2026-07-09T15:42:57Z adopted_by_identity: sysadmin adopted_by_profile: prgs-merger adopted_from_session_id: 1956-aa22dbda40f7 adopted_from_profile: prgs-merger adopted_from_reviewer_identity: sysadmin adopted_from_comment_id: 8199 adoption_reason: merger-handoff-approved-head <!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-merger session_id: 31616-fe56940d16c2 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merger-queue phase: adopted candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T15:42:57Z expires_at: 2026-07-09T17:42:57Z blocker: none
sysadmin commented 2026-07-09 10:45:02 -05:00
Owner
Copy Link
Copy Source

adopted_at: 2026-07-09T15:45:01Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 31616-fe56940d16c2
adopted_from_profile: prgs-merger
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 8215
adoption_reason: merger-handoff-approved-head

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 37725-5a80923abd79
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merger-queue
phase: adopted
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T15:45:01Z
expires_at: 2026-07-09T17:45:01Z
blocker: none

<!-- mcp-review-lease-adoption:v1 --> adopted_at: 2026-07-09T15:45:01Z adopted_by_identity: sysadmin adopted_by_profile: prgs-merger adopted_from_session_id: 31616-fe56940d16c2 adopted_from_profile: prgs-merger adopted_from_reviewer_identity: sysadmin adopted_from_comment_id: 8215 adoption_reason: merger-handoff-approved-head <!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-merger session_id: 37725-5a80923abd79 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merger-queue phase: adopted candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T15:45:01Z expires_at: 2026-07-09T17:45:01Z blocker: none
sysadmin commented 2026-07-09 10:45:49 -05:00
Owner
Copy Link
Copy Source

adopted_at: 2026-07-09T15:45:49Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 37725-5a80923abd79
adopted_from_profile: prgs-merger
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 8221
adoption_reason: merger-handoff-approved-head

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 37725-84781e38a2fc
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merger-queue
phase: adopted
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T15:45:49Z
expires_at: 2026-07-09T17:45:49Z
blocker: none

<!-- mcp-review-lease-adoption:v1 --> adopted_at: 2026-07-09T15:45:49Z adopted_by_identity: sysadmin adopted_by_profile: prgs-merger adopted_from_session_id: 37725-5a80923abd79 adopted_from_profile: prgs-merger adopted_from_reviewer_identity: sysadmin adopted_from_comment_id: 8221 adoption_reason: merger-handoff-approved-head <!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-merger session_id: 37725-84781e38a2fc worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merger-queue phase: adopted candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T15:45:49Z expires_at: 2026-07-09T17:45:49Z blocker: none
sysadmin commented 2026-07-09 10:47:34 -05:00
Owner
Copy Link
Copy Source

adopted_at: 2026-07-09T15:47:33Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 37725-84781e38a2fc
adopted_from_profile: prgs-merger
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 8225
adoption_reason: merger-handoff-approved-head

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #580
issue: #556
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 46120-bc5073e7ae62
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merger-queue
phase: adopted
candidate_head: f558b80cc8
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T15:47:33Z
expires_at: 2026-07-09T17:47:33Z
blocker: none

<!-- mcp-review-lease-adoption:v1 --> adopted_at: 2026-07-09T15:47:33Z adopted_by_identity: sysadmin adopted_by_profile: prgs-merger adopted_from_session_id: 37725-84781e38a2fc adopted_from_profile: prgs-merger adopted_from_reviewer_identity: sysadmin adopted_from_comment_id: 8225 adoption_reason: merger-handoff-approved-head <!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #580 issue: #556 reviewer_identity: sysadmin profile: prgs-merger session_id: 46120-bc5073e7ae62 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merger-queue phase: adopted candidate_head: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T15:47:33Z expires_at: 2026-07-09T17:47:33Z blocker: none
sysadmin commented 2026-07-09 10:48:31 -05:00
Owner
Copy Link
Copy Source

Canonical PR State

STATE:
merged

WHO_IS_NEXT:
controller

NEXT_ACTION:
No further PR action; head already on master. Close linked issue #556 if still open (issue.close not available on reconciler profile).

NEXT_PROMPT:

Confirm issue #556 is closed after already-landed reconcile of PR #580 (head f558b80 is ancestor of master).

WHAT_HAPPENED:
Already-landed reconciliation closed PR #580. Head f558b80 is an ancestor of master; content already present without a second merge.

WHY:
ALREADY_LANDED_RECONCILE_REQUIRED — open PR after head already on target.

ISSUE:
#556

BASE:
master

HEAD:
feat/issue-556-terminal-launcher-diagnose

HEAD_SHA:
f558b80cc8

REVIEW_STATUS:
none

VALIDATION:
ancestor_proof=true; eligibility_class=ALREADY_LANDED_RECONCILE_REQUIRED

BLOCKERS:
none

MERGE_READY:
n/a — already landed

LAST_UPDATED_BY:
sysadmin / prgs-reconciler / 2026-07-09

## Canonical PR State STATE: merged WHO_IS_NEXT: controller NEXT_ACTION: No further PR action; head already on master. Close linked issue #556 if still open (issue.close not available on reconciler profile). NEXT_PROMPT: ```text Confirm issue #556 is closed after already-landed reconcile of PR #580 (head f558b80 is ancestor of master). ``` WHAT_HAPPENED: Already-landed reconciliation closed PR #580. Head f558b80 is an ancestor of master; content already present without a second merge. WHY: ALREADY_LANDED_RECONCILE_REQUIRED — open PR after head already on target. ISSUE: #556 BASE: master HEAD: feat/issue-556-terminal-launcher-diagnose HEAD_SHA: f558b80cc8641fd60c8cb1f4ea9f9beee5f32f72 REVIEW_STATUS: none VALIDATION: ancestor_proof=true; eligibility_class=ALREADY_LANDED_RECONCILE_REQUIRED BLOCKERS: none MERGE_READY: n/a — already landed LAST_UPDATED_BY: sysadmin / prgs-reconciler / 2026-07-09
sysadmin closed this pull request 2026-07-09 10:48:32 -05:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
sysadmin
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#580