feat: allow reconciler profile to run merged cleanup directly (Closes #523) #567
Labels
Clear labels
allocator
anti-stomp
architecture
bug
chore
codex
concurrency
contamination
control-plane
dashboard
database
design
documentation
enhancement
gitea
glitchtip
important
incident
incident-bridge
integration
jenkins
labels
leases
mcp
mcp-health
mcp-menu
multi-project
mutating
nice-to-have
observability
portability
preflight
protected-branch
queue
read-only
reconnect
recovery
refactor
release
reliability
resumable-review
reviewer
roadmap
safety
security
self-hosted
sentry
stale-runtime
status:blocked
status:in-progress
status:pr-open
status:ready
terminal-lock
testing
tracker
type:bug
type:feature
type:feature
type:guardrail
visibility
workflow
workflow-hardening
workflow-hardening
Controller-owned work allocator
Prevent concurrent LLM session stomping
Architecture / structural design
OpenAI Codex client / workflow session surface
Concurrent session safety
Workflow or session contamination incident
MCP control-plane coordination and allocation authority
MCP operational dashboard/queue view
Internal coordination storage (SQLite/Postgres)
Design / investigation, no implementation
Docs / runbooks
New feature or improvement
Gitea MCP workflow
GlitchTip integration
Operational or process incident requiring durable audit trail
Sentry-to-Gitea incident bridging
Integration testing
Jenkins integration
Label taxonomy management
Lease adopt/release/expire lifecycle
MCP server / tooling
MCP namespace and runtime health
MCP menu surface
Work spanning multiple monitoring projects or Gitea repos
Mutating action; requires gating
Observability, metrics, traces, error reporting
Cross-platform / portability
Shared preflight gates before mutation
Protected branch / stable-branch policy concern
Work queue visibility and allocation
Read-only, no mutation
MCP client reconnect/reload recovery path
Recovery paths for stale/foreign leases
Code refactor / restructure
Release / versioning
Reliability / failure handling
Persist and resume prepared review verdicts across sessions
Reviewer workflow tooling
Roadmap / umbrella issue
Safety rails and fail-closed mutation guards
Security / trust boundary
Self-hosted infrastructure integration
Sentry error monitoring integration
Stale backend daemon / runtime-vs-master parity failures
Issue is blocked
Issue is being worked on
Issue has an open pull request
Issue is ready for work
Terminal review lock (#332) path
Tests / test coverage
Issue tracker hygiene / meta
Bug or defect
Feature or enhancement
Feature or enhancement
Safety gate or guardrail
Workflow state visibility for LLMs/operators
Cross-tool workflow
LLM workflow coordination hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Scaled-Tech-Consulting/Gitea-Tools#567
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Allows the reconciler profile namespace to execute gitea_reconcile_merged_cleanups directly from the stable control repository checkout without requiring an author profile switch or triggering the branches-only author mutation guard.
Closes #523
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #567
issue: #523
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 35511-84d433a76ac0
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-queue-mergeable
phase: claimed
candidate_head:
32fc1719aatarget_branch: master
target_branch_sha: none
last_activity: 2026-07-09T02:53:58Z
expires_at: 2026-07-09T04:53:58Z
blocker: none
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #567
issue: #523
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 35511-84d433a76ac0
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-queue-mergeable
phase: released
candidate_head:
32fc1719aatarget_branch: master
target_branch_sha: none
last_activity: 2026-07-09T02:55:34Z
expires_at: 2026-07-09T04:55:34Z
blocker: manual-release
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #567
issue: #523
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 35511-84d433a76ac0
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-queue-mergeable
phase: claimed
candidate_head:
32fc1719aatarget_branch: master
target_branch_sha:
066eec8477last_activity: 2026-07-09T03:29:57Z
expires_at: 2026-07-09T05:29:57Z
blocker: none
Review findings (formal REQUEST_CHANGES blocked this runtime)
Head:
32fc1719aa0a63a41c03deddc5583875e9623e93Reviewer: sysadmin / prgs-reviewer
Worktree:
branches/review-queue-mergeable@ headNote: This MCP reviewer process already consumed its terminal review mutation on merged PR #574, so a live
REQUEST_CHANGESverdict could not be posted. Treating this comment as the review handoff until a fresh reviewer session can stamp the formal verdict.What looks good
task_capability_maprole flip forreconcile_merged_cleanupsandreconciliation_cleanupfromauthor→reconcilermatches #523 (reconciler owns post-merge cleanup without an author profile switch).gitea.read/gitea.branch.delete; no author-mutation expansion.Blocking findings
New integration test fails / is environment-coupled
tests/test_reconciler_cleanup_integration.py::test_author_role_remains_blocked_on_root_checkoutObserved:
verify_preflight_purityruns_enforce_root_checkout_guardbefore_enforce_branches_only_author_mutation, and the test hardcodesPROJECT_ROOTwithout isolating root-guard inputs. The expected author-mutation message only appears when the control checkout already happens to be clean master.Fix: mock root-checkout assessment so the author branches-only path is under test; assert the real
author_mutation_worktreeerror surface hermetically.Acceptance coverage gaps vs #523
AC 2/5 ask for fail-closed proof on non-merged / active author work. New tests cover reconciler success + (broken) author root block only. Add an explicit unmerged/open fail-closed case or lock existing coverage as a regression assertion.
Non-blocking
webui/lease_loader.pyimport fix is already on currentprgs/master(no-op after merge).role_session_router.TASK_REQUIRED_ROLEstill omits these task names; optional follow-up so router and capability map agree.Validation performed
Intended verdict: REQUEST_CHANGES — land the role map after the author-block test is hermetic and AC fail-closed coverage is explicit.
[THREAD STATE LEDGER]32fc171; dry-run REQUEST_CHANGES would_perform=truerepo: Scaled-Tech-Consulting/Gitea-Tools
pr: #567
issue: #523
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 35511-84d433a76ac0
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-queue-mergeable
phase: released
candidate_head:
32fc1719aatarget_branch: master
target_branch_sha:
066eec8477last_activity: 2026-07-09T03:31:07Z
expires_at: 2026-07-09T05:31:07Z
blocker: manual-release
Author follow-up (issue #523)
Pushed
e5bf8c9onfeat/issue-523-reconciler-cleanupto close residual acceptance gaps found during review:Changes
tests/test_reconciler_cleanup_integration.pynow:reconcile_merged_cleanups/reconciliation_cleanupto reconcilerGITEA_TEST_PORCELAIN="") so the reconciler root-checkout bypass is real, not a test short-circuitsafe_to_delete_remote(AC5)docs/llm-workflow-runbooks.md— new Post-merge merged cleanup ownership (#523) under reconciliation (AC6)Validation (worktree only)
Worktree
branches/feat-issue-523-reconciler-cleanup@e5bf8c9Next
Fresh re-review/approve at head
e5bf8c9(prior lease on this PR may be stale). Self-review: no.repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #567
issue: #523
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 35511-84d433a76ac0
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr567-issue-523
phase: claimed
candidate_head:
e5bf8c9647target_branch: master
target_branch_sha:
b68805e88alast_activity: 2026-07-09T04:10:16Z
expires_at: 2026-07-09T06:10:16Z
blocker: none
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #567
issue: #523
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 22022-9ca35950d462
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/feat-issue-523-reconciler-cleanup
phase: claimed
candidate_head:
e7811cb5bbtarget_branch: master
target_branch_sha: none
last_activity: 2026-07-09T12:13:17Z
expires_at: 2026-07-09T14:13:17Z
blocker: none
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #567
issue: #523
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 22022-9ca35950d462
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/feat-issue-523-reconciler-cleanup
phase: released
candidate_head:
e7811cb5bbtarget_branch: master
target_branch_sha: none
last_activity: 2026-07-09T12:15:14Z
expires_at: 2026-07-09T14:15:14Z
blocker: dead-process-reclaim
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #567
issue: #523
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 22022-9ca35950d462
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/feat-issue-523-reconciler-cleanup
phase: claimed
candidate_head:
e7811cb5bbtarget_branch: master
target_branch_sha: none
last_activity: 2026-07-09T12:16:15Z
expires_at: 2026-07-09T14:16:15Z
blocker: none
APPROVE PR #567 (Closes #523)
Head:
e7811cb5bbdca164e1c1e3e509da7f8fe5e1fa08Reviewer: sysadmin / prgs-reviewer
Author: jcwalker3 (not self-review)
Scope (4 files)
Prior REQUEST_CHANGES at
32fc171addressed in e5bf8c9; revalidated one7811cb(6 passed).APPROVE — mergeable; ready for prgs-merger.
adopted_at: 2026-07-09T12:19:24Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 22022-9ca35950d462
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 7828
adoption_reason: merger-handoff-approved-head
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #567
issue: #523
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 33824-8d264b23c850
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/feat-issue-523-reconciler-cleanup
phase: adopted
candidate_head:
e7811cb5bbtarget_branch: master
target_branch_sha: none
last_activity: 2026-07-09T12:19:24Z
expires_at: 2026-07-09T14:19:24Z
blocker: none