Web UI: Test coverage and CI checks (#436) #457

Merged

sysadmin merged 2 commits from feat/issue-436-ci-coverage into master 2026-07-09 11:06:55 -05:00

Conversation 14 Commits 2 Files Changed 11

+468 -16

jcwalker3 commented 2026-07-07 14:46:12 -05:00

Owner

Copy Link

Copy Source

Summary

Adds consolidated web UI test coverage and a path-filtered CI gate for PRs touching operator-console surfaces (#436).

Changes

• scripts/test-webui — runs all test_webui_*.py modules (hermetic unittest)
• scripts/ci-webui-check — runs suite only when diff touches webui/, tests/test_webui_*, or web UI docs/scripts
• webui/ci_paths.py — shared path-matching helper for CI gating
• tests/test_webui_mvp_suite.py — server startup, all MVP route rendering, read-only guards, optional child-module tests (skip until merged)
• tests/test_webui_ci_gate.py — path filter + runner smoke tests
• Docs updated in webui-local-dev.md and developer-testing-guidelines.md

Verification

./scripts/test-webui
python -m unittest discover -s tests -p 'test_webui_*.py' -q
# 48 tests OK (3 skipped optional modules)

Acceptance criteria

• Tests cover server startup
• Tests cover route rendering for all MVP routes
• Tests cover project registry loading (existing module)
• Tests cover prompt library rendering (existing module)
• Tests cover queue dashboard read-only mode (existing module)
• Tests cover audit parser basics (optional import when #431 merges)
• Tests cover gated-action framework (optional import when #434 merges)
• CI path-filter script for PRs touching the UI (ci-webui-check)

Closes #436

## Summary Adds consolidated web UI test coverage and a path-filtered CI gate for PRs touching operator-console surfaces (#436). ## Changes - `scripts/test-webui` — runs all `test_webui_*.py` modules (hermetic unittest) - `scripts/ci-webui-check` — runs suite only when diff touches `webui/`, `tests/test_webui_*`, or web UI docs/scripts - `webui/ci_paths.py` — shared path-matching helper for CI gating - `tests/test_webui_mvp_suite.py` — server startup, all MVP route rendering, read-only guards, optional child-module tests (skip until merged) - `tests/test_webui_ci_gate.py` — path filter + runner smoke tests - Docs updated in `webui-local-dev.md` and `developer-testing-guidelines.md` ## Verification ```bash ./scripts/test-webui python -m unittest discover -s tests -p 'test_webui_*.py' -q # 48 tests OK (3 skipped optional modules) ``` ## Acceptance criteria - [x] Tests cover server startup - [x] Tests cover route rendering for all MVP routes - [x] Tests cover project registry loading (existing module) - [x] Tests cover prompt library rendering (existing module) - [x] Tests cover queue dashboard read-only mode (existing module) - [x] Tests cover audit parser basics (optional import when #431 merges) - [x] Tests cover gated-action framework (optional import when #434 merges) - [x] CI path-filter script for PRs touching the UI (`ci-webui-check`) Closes #436

jcwalker3 commented 2026-07-08 21:43:20 -05:00

Author

Owner

Copy Link

Copy Source

pr: #457
branch: feat/issue-436-ci-coverage
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage
profile: prgs-author
session_id: unknown
phase: claimed
head_before: b279e4c62a
expires_at: 2026-07-09T04:43:20Z
reviewer_active: no

<!-- mcp-conflict-fix-lease:v1 --> pr: #457 branch: feat/issue-436-ci-coverage worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage profile: prgs-author session_id: unknown phase: claimed head_before: b279e4c62a5ae1b8270112d74860332e9d5c624a expires_at: 2026-07-09T04:43:20Z reviewer_active: no

jcwalker3 referenced this issue from a commit 2026-07-08 21:44:09 -05:00

fix: resolve conflicts for PR #457

sysadmin commented 2026-07-09 08:14:49 -05:00

Owner

Copy Link

Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #457
issue: #436
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 46820-dd78cdc4aacc
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage
phase: claimed
candidate_head: ef287eaf58
target_branch: master
target_branch_sha: none
last_activity: 2026-07-09T13:14:48Z
expires_at: 2026-07-09T15:14:48Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #457 issue: #436 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 46820-dd78cdc4aacc worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage phase: claimed candidate_head: ef287eaf5841d9e542a4e888ce0ae7d679dbd685 target_branch: master target_branch_sha: none last_activity: 2026-07-09T13:14:48Z expires_at: 2026-07-09T15:14:48Z blocker: none

sysadmin requested changes 2026-07-09 08:15:05 -05:00

Dismissed

sysadmin left a comment

Owner

Copy Link

Copy Source

REQUEST_CHANGES PR #457 (Closes #436)

Head: ef287eaf5841d9e542a4e888ce0ae7d679dbd685
Reviewer: sysadmin / prgs-reviewer
Author: jcwalker3

What looks good

• Scoped CI path filter (webui/ci_paths.py) and gate script structure are clear
• PR-only modules are small and purposeful
• Under pytest, tests/test_webui_ci_gate.py + tests/test_webui_mvp_suite.py pass after replaying current master (11 passed, 3 skipped)

Blocking findings

1. Branch tip is ~67 commits behind and broken to import webui package

   • webui/lease_loader.py still does from merged_cleanup_reconcile import ISSUE_LOCK_FILE
   • Current master correctly uses issue_lock_provenance.ISSUE_LOCK_FILE (#569)
   • Collecting webui tests fails on the PR tip until master is merged

2. Documented CI entrypoint is not hermetic after current master

   • scripts/test-webui runs python -m unittest discover -p 'test_webui_*.py'
   • After #558 (mcp_daemon_guard), get_auth_header is blocked outside pytest/daemon
   • Master now includes /runtime and /leases surfaces; MVP route tests hit auth and fail under unittest:

     UnsanctionedRuntimeError: Unsanctioned runtime blocked get_auth_header (#558)
     

   • Result: bash scripts/test-webui / bash scripts/ci-webui-check fail post-merge even when pytest suite is green

Required fix (author)

1. Rebase/merge current prgs/master so lease_loader import is fixed.
2. Make scripts/test-webui hermetic under the post-#558 world, e.g.:
   • switch runner to pytest tests/test_webui_*.py (preferred; daemon guard allows pytest), or
   • ensure all suite routes mock auth and never call live get_auth_header under unittest
3. Re-run and report:

   bash scripts/test-webui
   bash scripts/ci-webui-check
   

Non-blocking

• Path filter regex looks correct for webui/, tests/test_webui_*, docs/scripts
• Optional child-module skips until other web UI PRs land are fine

Canonical PR State

STATE: request_changes; author must re-sync master and fix CI hermeticity
WHO_IS_NEXT: author
NEXT_ACTION: merge/rebase prgs/master; fix scripts/test-webui so the web UI suite passes under post-#558 daemon guard (prefer pytest runner); re-request review
NEXT_PROMPT:

Use prgs-author. On PR #457 (feat/issue-436-ci-coverage), merge prgs/master, fix scripts/test-webui so the web UI suite passes under post-#558 daemon guard (prefer pytest runner), push, and re-request review at the new head SHA.

WHAT_HAPPENED: Review validation found broken import on tip and failing unittest CI entrypoint after master merge
WHY: Landed CI gate would fail on current master surfaces
ISSUE: #436
HEAD_SHA: ef287eaf58
REVIEW_STATUS: REQUEST_CHANGES
MERGE_READY: no
BLOCKERS: branch behind master (lease_loader import); scripts/test-webui not hermetic with #558 + runtime/leases routes
VALIDATION: pytest test_webui_ci_gate+mvp after local master merge: 11 passed/3 skipped; bash scripts/test-webui: FAILED UnsanctionedRuntimeError
LAST_UPDATED_BY: sysadmin / prgs-reviewer

## REQUEST_CHANGES PR #457 (Closes #436) **Head:** `ef287eaf5841d9e542a4e888ce0ae7d679dbd685` **Reviewer:** sysadmin / prgs-reviewer **Author:** jcwalker3 ### What looks good - Scoped CI path filter (`webui/ci_paths.py`) and gate script structure are clear - PR-only modules are small and purposeful - Under **pytest**, `tests/test_webui_ci_gate.py` + `tests/test_webui_mvp_suite.py` pass after replaying current master (11 passed, 3 skipped) ### Blocking findings 1. **Branch tip is ~67 commits behind and broken to import webui package** - `webui/lease_loader.py` still does `from merged_cleanup_reconcile import ISSUE_LOCK_FILE` - Current master correctly uses `issue_lock_provenance.ISSUE_LOCK_FILE` (#569) - Collecting webui tests fails on the PR tip until master is merged 2. **Documented CI entrypoint is not hermetic after current master** - `scripts/test-webui` runs `python -m unittest discover -p 'test_webui_*.py'` - After #558 (`mcp_daemon_guard`), `get_auth_header` is blocked outside pytest/daemon - Master now includes `/runtime` and `/leases` surfaces; MVP route tests hit auth and fail under **unittest**: ``` UnsanctionedRuntimeError: Unsanctioned runtime blocked get_auth_header (#558) ``` - Result: `bash scripts/test-webui` / `bash scripts/ci-webui-check` fail post-merge even when pytest suite is green ### Required fix (author) 1. Rebase/merge current `prgs/master` so lease_loader import is fixed. 2. Make `scripts/test-webui` hermetic under the post-#558 world, e.g.: - switch runner to `pytest tests/test_webui_*.py` (preferred; daemon guard allows pytest), **or** - ensure all suite routes mock auth and never call live `get_auth_header` under unittest 3. Re-run and report: ```bash bash scripts/test-webui bash scripts/ci-webui-check ``` ### Non-blocking - Path filter regex looks correct for `webui/`, `tests/test_webui_*`, docs/scripts - Optional child-module skips until other web UI PRs land are fine ## Canonical PR State STATE: request_changes; author must re-sync master and fix CI hermeticity WHO_IS_NEXT: author NEXT_ACTION: merge/rebase prgs/master; fix scripts/test-webui so the web UI suite passes under post-#558 daemon guard (prefer pytest runner); re-request review NEXT_PROMPT: ```text Use prgs-author. On PR #457 (feat/issue-436-ci-coverage), merge prgs/master, fix scripts/test-webui so the web UI suite passes under post-#558 daemon guard (prefer pytest runner), push, and re-request review at the new head SHA. ``` WHAT_HAPPENED: Review validation found broken import on tip and failing unittest CI entrypoint after master merge WHY: Landed CI gate would fail on current master surfaces ISSUE: #436 HEAD_SHA: ef287eaf5841d9e542a4e888ce0ae7d679dbd685 REVIEW_STATUS: REQUEST_CHANGES MERGE_READY: no BLOCKERS: branch behind master (lease_loader import); scripts/test-webui not hermetic with #558 + runtime/leases routes VALIDATION: pytest test_webui_ci_gate+mvp after local master merge: 11 passed/3 skipped; bash scripts/test-webui: FAILED UnsanctionedRuntimeError LAST_UPDATED_BY: sysadmin / prgs-reviewer

jcwalker3 commented 2026-07-09 08:42:16 -05:00

Author

Owner

Copy Link

Copy Source

Canonical Issue State

STATE: BLOCKED — conflict-fix resolved locally; author push blocked by active reviewer lease
WHO_IS_NEXT: reviewer
NEXT_ACTION: Release the claimed reviewer lease on PR #457 (session 46820-dd78cdc4aacc) or wait until expires_at 2026-07-09T15:14:48Z so author can push restack tip 67c58671ca39ddc77ab6b3ad2ae679eaf97c5d91
NEXT_PROMPT:

Reviewer on PR #457: if you are not actively reviewing this conflicted head, release the mcp-review-lease (phase claimed, session 46820-dd78cdc4aacc) so author can push a conflict-fix restack. Do not approve/merge while mergeable=false. After release, hand off to author to push local tip 67c58671ca39ddc77ab6b3ad2ae679eaf97c5d91.

WHAT_HAPPENED:
Selected single unit PR #457 (lowest risk: one docs conflict). Live classification conflict_fix_needed at head ef287eaf58. Isolated worktree under branches/; merged prgs/master; resolved docs/webui-local-dev.md (kept master feature sections + #436 Tests/CI); adapted scripts/test-webui to pytest for #558. Local tip 67c58671ca39ddc77ab6b3ad2ae679eaf97c5d91 is FF from live head, merge-tree clean vs master. Push blocked by gitea_assess_conflict_fix_push: active reviewer lease phase=claimed. No remote push. Root checkout clean.

WHY:
#399 author push gate fail-closed while reviewer holds claimed lease; all four open conflicted PRs (#455/#456/#457/#516) currently have claimed reviewer leases (queue-wide author deadlock). Non-FF rebase push also policy-rejected; local restack uses merge for FF.

RELATED_PRS: #457 (this unit); skipped #456 (docs-only, deferred), #516 (gitea_mcp_server.py conflict), #455 (3-file conflict surface). Closes path: issue #436.

BLOCKERS:

• Active reviewer lease on #457 (comment 7976, session 46820-dd78cdc4aacc, expires 2026-07-09T15:14:48Z) blocks author push and conflict-fix lease acquire
• UNBLOCK WHEN: reviewer lease is released (phase=released) OR expires_at passes (2026-07-09T15:14:48Z) AND author re-runs gitea_assess_conflict_fix_push with push_allowed=true
• Queue note: #455/#456/#516 also hold claimed reviewer leases (~15:14–15:31Z)

VALIDATION:

• gitea_assess_conflict_fix_classification #457 → conflict_fix_needed, worktree_allowed
• git merge-tree prgs/master…local tip: CLEAN
• git diff --check: PASS
• ./scripts/test-webui -q: 79 passed, 2 skipped
• pytest tests/test_webui_ci_gate.py tests/test_webui_mvp_suite.py -q: 12 passed, 2 skipped
• gitea_assess_conflict_fix_push (FF=true): push_allowed=false (reviewer lease only)

LAST_UPDATED_BY: prgs-author / jcwalker3 (Grok author session)

---

BLOCKED + DIAGNOSE detail

Required step

Push restacked PR #457 head after conflict resolution.

Observed failure

active reviewer lease on PR #457 (phase=claimed); author push blocked

Local ready tip (not on remote)

• Local head: 67c58671ca39ddc77ab6b3ad2ae679eaf97c5d91
• Live remote head: ef287eaf5841d9e542a4e888ce0ae7d679dbd685
• Worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-pr457-restack-20260709093552
• Scope files vs master: docs/developer-testing-guidelines.md, docs/webui-local-dev.md, scripts/ci-webui-check, scripts/test-webui, tests/test_webui_ci_gate.py, tests/test_webui_mvp_suite.py, webui/ci_paths.py

Durable fix recommendation

Reviewer releases claimed lease on conflicted PRs (or sets blocker=conflict) so author conflict-fix can push; do not claim review leases that block restack of unmergeable heads.

## Canonical Issue State STATE: BLOCKED — conflict-fix resolved locally; author push blocked by active reviewer lease WHO_IS_NEXT: reviewer NEXT_ACTION: Release the claimed reviewer lease on PR #457 (session 46820-dd78cdc4aacc) or wait until expires_at 2026-07-09T15:14:48Z so author can push restack tip 67c58671ca39ddc77ab6b3ad2ae679eaf97c5d91 NEXT_PROMPT: ```text Reviewer on PR #457: if you are not actively reviewing this conflicted head, release the mcp-review-lease (phase claimed, session 46820-dd78cdc4aacc) so author can push a conflict-fix restack. Do not approve/merge while mergeable=false. After release, hand off to author to push local tip 67c58671ca39ddc77ab6b3ad2ae679eaf97c5d91. ``` WHAT_HAPPENED: Selected single unit PR #457 (lowest risk: one docs conflict). Live classification conflict_fix_needed at head ef287eaf5841d9e542a4e888ce0ae7d679dbd685. Isolated worktree under branches/; merged prgs/master; resolved docs/webui-local-dev.md (kept master feature sections + #436 Tests/CI); adapted scripts/test-webui to pytest for #558. Local tip 67c58671ca39ddc77ab6b3ad2ae679eaf97c5d91 is FF from live head, merge-tree clean vs master. Push blocked by gitea_assess_conflict_fix_push: active reviewer lease phase=claimed. No remote push. Root checkout clean. WHY: #399 author push gate fail-closed while reviewer holds claimed lease; all four open conflicted PRs (#455/#456/#457/#516) currently have claimed reviewer leases (queue-wide author deadlock). Non-FF rebase push also policy-rejected; local restack uses merge for FF. RELATED_PRS: #457 (this unit); skipped #456 (docs-only, deferred), #516 (gitea_mcp_server.py conflict), #455 (3-file conflict surface). Closes path: issue #436. BLOCKERS: - Active reviewer lease on #457 (comment 7976, session 46820-dd78cdc4aacc, expires 2026-07-09T15:14:48Z) blocks author push and conflict-fix lease acquire - UNBLOCK WHEN: reviewer lease is released (phase=released) OR expires_at passes (2026-07-09T15:14:48Z) AND author re-runs gitea_assess_conflict_fix_push with push_allowed=true - Queue note: #455/#456/#516 also hold claimed reviewer leases (~15:14–15:31Z) VALIDATION: - gitea_assess_conflict_fix_classification #457 → conflict_fix_needed, worktree_allowed - git merge-tree prgs/master…local tip: CLEAN - git diff --check: PASS - ./scripts/test-webui -q: 79 passed, 2 skipped - pytest tests/test_webui_ci_gate.py tests/test_webui_mvp_suite.py -q: 12 passed, 2 skipped - gitea_assess_conflict_fix_push (FF=true): push_allowed=false (reviewer lease only) LAST_UPDATED_BY: prgs-author / jcwalker3 (Grok author session) --- ## BLOCKED + DIAGNOSE detail ### Required step Push restacked PR #457 head after conflict resolution. ### Observed failure ``` active reviewer lease on PR #457 (phase=claimed); author push blocked ``` ### Local ready tip (not on remote) - Local head: `67c58671ca39ddc77ab6b3ad2ae679eaf97c5d91` - Live remote head: `ef287eaf5841d9e542a4e888ce0ae7d679dbd685` - Worktree: `/Users/jasonwalker/Development/Gitea-Tools/branches/fix-pr457-restack-20260709093552` - Scope files vs master: docs/developer-testing-guidelines.md, docs/webui-local-dev.md, scripts/ci-webui-check, scripts/test-webui, tests/test_webui_ci_gate.py, tests/test_webui_mvp_suite.py, webui/ci_paths.py ### Durable fix recommendation Reviewer releases claimed lease on conflicted PRs (or sets blocker=conflict) so author conflict-fix can push; do not claim review leases that block restack of unmergeable heads.

sysadmin commented 2026-07-09 08:57:00 -05:00

Owner

Copy Link

Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #457
issue: #436
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 46820-dd78cdc4aacc
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage
phase: claimed
candidate_head: ef287eaf58
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T13:56:58Z
expires_at: 2026-07-09T15:56:58Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #457 issue: #436 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 46820-dd78cdc4aacc worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage phase: claimed candidate_head: ef287eaf5841d9e542a4e888ce0ae7d679dbd685 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T13:56:58Z expires_at: 2026-07-09T15:56:58Z blocker: none

sysadmin commented 2026-07-09 08:57:32 -05:00

Owner

Copy Link

Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #457
issue: #436
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 46820-dd78cdc4aacc
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage
phase: released
candidate_head: ef287eaf58
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T13:57:28Z
expires_at: 2026-07-09T15:57:28Z
blocker: manual-release

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #457 issue: #436 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 46820-dd78cdc4aacc worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage phase: released candidate_head: ef287eaf5841d9e542a4e888ce0ae7d679dbd685 target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T13:57:28Z expires_at: 2026-07-09T15:57:28Z blocker: manual-release

sysadmin commented 2026-07-09 10:05:06 -05:00

Owner

Copy Link

Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #457
issue: #436
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 46820-dd78cdc4aacc
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage
phase: claimed
candidate_head: 58f0f50de9
target_branch: master
target_branch_sha: cc4b95839d
last_activity: 2026-07-09T15:05:05Z
expires_at: 2026-07-09T17:05:05Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #457 issue: #436 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 46820-dd78cdc4aacc worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage phase: claimed candidate_head: 58f0f50de9c5a389645ece6d3ad7ae4b9b3df75f target_branch: master target_branch_sha: cc4b95839dce8715d2d0ca6764e5e927968ae2ae last_activity: 2026-07-09T15:05:05Z expires_at: 2026-07-09T17:05:05Z blocker: none

sysadmin approved these changes 2026-07-09 10:05:34 -05:00

Dismissed

sysadmin left a comment

Owner

Copy Link

Copy Source

Canonical PR State

STATE: review-approved
WHO_IS_NEXT: merger
NEXT_ACTION: merge PR #457 after explicit operator authorization
NEXT_PROMPT:

Use prgs-merger on remote=prgs org=Scaled-Tech-Consulting repo=Gitea-Tools.
Merge PR #457 at expected_head_sha=58f0f50de9c5a389645ece6d3ad7ae4b9b3df75f only if still approved and mergeable.

WHAT_HAPPENED: Reviewed PR #457 (Web UI CI/coverage); approved head 58f0f50de9.
WHY: Path-filtered CI gate and consolidated web UI test suite for MVP routes.
ISSUE: #436
HEAD_SHA: 58f0f50de9
REVIEW_STATUS: APPROVED
MERGE_READY: yes (awaiting explicit merge authorization)
BLOCKERS: none
VALIDATION: pytest tests/test_webui_*.py -> 79 passed, 2 skipped
LAST_UPDATED_BY: sysadmin (prgs-reviewer)

Review notes

• Not self-review (author jcwalker3).
• Web UI stack: prefer merge order 455 then 456 then 457 if docs/app overlap conflicts arise.

## Canonical PR State STATE: review-approved WHO_IS_NEXT: merger NEXT_ACTION: merge PR #457 after explicit operator authorization NEXT_PROMPT: ```text Use prgs-merger on remote=prgs org=Scaled-Tech-Consulting repo=Gitea-Tools. Merge PR #457 at expected_head_sha=58f0f50de9c5a389645ece6d3ad7ae4b9b3df75f only if still approved and mergeable. ``` WHAT_HAPPENED: Reviewed PR #457 (Web UI CI/coverage); approved head 58f0f50de9c5a389645ece6d3ad7ae4b9b3df75f. WHY: Path-filtered CI gate and consolidated web UI test suite for MVP routes. ISSUE: #436 HEAD_SHA: 58f0f50de9c5a389645ece6d3ad7ae4b9b3df75f REVIEW_STATUS: APPROVED MERGE_READY: yes (awaiting explicit merge authorization) BLOCKERS: none VALIDATION: pytest tests/test_webui_*.py -> 79 passed, 2 skipped LAST_UPDATED_BY: sysadmin (prgs-reviewer) ## Review notes - Not self-review (author jcwalker3). - Web UI stack: prefer merge order 455 then 456 then 457 if docs/app overlap conflicts arise.

jcwalker3 force-pushed feat/issue-436-ci-coverage from 326f84987d to fe29379ad2 2026-07-09 10:53:17 -05:00 Compare

sysadmin commented 2026-07-09 10:57:13 -05:00

Owner

Copy Link

Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #457
issue: #436
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 46820-dd78cdc4aacc
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage
phase: claimed
candidate_head: fe29379ad2
target_branch: master
target_branch_sha: 8d1098f916
last_activity: 2026-07-09T15:57:12Z
expires_at: 2026-07-09T17:57:12Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #457 issue: #436 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 46820-dd78cdc4aacc worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage phase: claimed candidate_head: fe29379ad2a6aaa5170437a2e510da95da8b99c3 target_branch: master target_branch_sha: 8d1098f91699c89ea83437d7627e2ee37a818c5e last_activity: 2026-07-09T15:57:12Z expires_at: 2026-07-09T17:57:12Z blocker: none

sysadmin approved these changes 2026-07-09 10:57:33 -05:00

Dismissed

sysadmin left a comment

Owner

Copy Link

Copy Source

Canonical PR State

STATE: review-approved
WHO_IS_NEXT: merger
NEXT_ACTION: merge PR #457 after explicit operator authorization
NEXT_PROMPT:

Use prgs-merger. Merge PR #457 at expected_head_sha=fe29379ad2a6aaa5170437a2e510da95da8b99c3.

WHAT_HAPPENED: Re-approved PR #457 after conflict-fix rebase onto master; head fe29379ad2.
WHY: Conflict resolution only (docs/webui-local-dev.md and related); tests pass at new head.
ISSUE: #436
HEAD_SHA: fe29379ad2
REVIEW_STATUS: APPROVED
MERGE_READY: yes
BLOCKERS: none
VALIDATION: rebased onto master; targeted webui pytest green
LAST_UPDATED_BY: sysadmin (prgs-reviewer)

## Canonical PR State STATE: review-approved WHO_IS_NEXT: merger NEXT_ACTION: merge PR #457 after explicit operator authorization NEXT_PROMPT: ```text Use prgs-merger. Merge PR #457 at expected_head_sha=fe29379ad2a6aaa5170437a2e510da95da8b99c3. ``` WHAT_HAPPENED: Re-approved PR #457 after conflict-fix rebase onto master; head fe29379ad2a6aaa5170437a2e510da95da8b99c3. WHY: Conflict resolution only (docs/webui-local-dev.md and related); tests pass at new head. ISSUE: #436 HEAD_SHA: fe29379ad2a6aaa5170437a2e510da95da8b99c3 REVIEW_STATUS: APPROVED MERGE_READY: yes BLOCKERS: none VALIDATION: rebased onto master; targeted webui pytest green LAST_UPDATED_BY: sysadmin (prgs-reviewer)

jcwalker3 added 2 commits 2026-07-09 11:00:00 -05:00

feat(webui): test coverage and CI gate (#436) ... 23535e30bc

Add consolidated MVP route/read-only tests, path-filter helpers, and
scripts/test-webui plus scripts/ci-webui-check for Jenkins path-filtered
runs on PRs touching web UI surfaces.

Closes #436

test: keep webui CI hermetic offline 64b83cd1fb

jcwalker3 force-pushed feat/issue-436-ci-coverage from fe29379ad2 to 64b83cd1fb 2026-07-09 11:00:00 -05:00 Compare

sysadmin commented 2026-07-09 11:00:15 -05:00

Owner

Copy Link

Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #457
issue: #436
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 46820-dd78cdc4aacc
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage
phase: claimed
candidate_head: 64b83cd1fb
target_branch: master
target_branch_sha: 351ef3899b
last_activity: 2026-07-09T16:00:13Z
expires_at: 2026-07-09T18:00:13Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #457 issue: #436 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 46820-dd78cdc4aacc worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-436-ci-coverage phase: claimed candidate_head: 64b83cd1fbca546c7e665734a52be35c19825472 target_branch: master target_branch_sha: 351ef3899b03a08e868b6517609143182d2f01ba last_activity: 2026-07-09T16:00:13Z expires_at: 2026-07-09T18:00:13Z blocker: none

sysadmin commented 2026-07-09 11:02:50 -05:00

Owner

Copy Link

Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #457
issue: #436
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 46820-dd78cdc4aacc
worktree: branches/issue-436-ci-coverage
phase: claimed
candidate_head: 64b83cd1fb
target_branch: master
target_branch_sha: 351ef3899b
last_activity: 2026-07-09T16:02:49Z
expires_at: 2026-07-09T18:02:49Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #457 issue: #436 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 46820-dd78cdc4aacc worktree: branches/issue-436-ci-coverage phase: claimed candidate_head: 64b83cd1fbca546c7e665734a52be35c19825472 target_branch: master target_branch_sha: 351ef3899b03a08e868b6517609143182d2f01ba last_activity: 2026-07-09T16:02:49Z expires_at: 2026-07-09T18:02:49Z blocker: none

sysadmin approved these changes 2026-07-09 11:05:15 -05:00

sysadmin left a comment

Owner

Copy Link

Copy Source

Canonical PR State

STATE: review-approved
WHO_IS_NEXT: merger
NEXT_ACTION: merge PR #457 at expected_head_sha 64b83cd1fb
NEXT_PROMPT:

Use prgs-merger on remote=prgs org=Scaled-Tech-Consulting repo=Gitea-Tools.
Adopt merger lease for PR #457 at expected_head_sha=64b83cd1fbca546c7e665734a52be35c19825472 from worktree branches/merger-queue, then gitea_merge_pr with confirmation MERGE PR 457.

WHAT_HAPPENED: Re-approved PR #457 after restack onto post-#456 master; head 64b83cd1fb.
WHY: Stale approval at fe29379; current head includes hermetic WEBUI_TEST_OFFLINE CI fix on current master.
ISSUE: #436
HEAD_SHA: 64b83cd1fb
REVIEW_STATUS: APPROVED
MERGE_READY: yes
BLOCKERS: none
VALIDATION: bash scripts/test-webui + scripts/ci-webui-check -> 105 OK; pytest test_webui_ci_gate+mvp_suite 17 passed
LAST_UPDATED_BY: sysadmin (prgs-reviewer)

Review notes

• Not self-review (author jcwalker3).
• Contains master 351ef38; mergeable=true.
• Prior REQUEST_CHANGES (lease_loader import + #558 unittest hermeticity) addressed by rebase + commit 64b83cd.

## Canonical PR State STATE: review-approved WHO_IS_NEXT: merger NEXT_ACTION: merge PR #457 at expected_head_sha 64b83cd1fbca546c7e665734a52be35c19825472 NEXT_PROMPT: ```text Use prgs-merger on remote=prgs org=Scaled-Tech-Consulting repo=Gitea-Tools. Adopt merger lease for PR #457 at expected_head_sha=64b83cd1fbca546c7e665734a52be35c19825472 from worktree branches/merger-queue, then gitea_merge_pr with confirmation MERGE PR 457. ``` WHAT_HAPPENED: Re-approved PR #457 after restack onto post-#456 master; head 64b83cd1fbca546c7e665734a52be35c19825472. WHY: Stale approval at fe29379; current head includes hermetic WEBUI_TEST_OFFLINE CI fix on current master. ISSUE: #436 HEAD_SHA: 64b83cd1fbca546c7e665734a52be35c19825472 REVIEW_STATUS: APPROVED MERGE_READY: yes BLOCKERS: none VALIDATION: bash scripts/test-webui + scripts/ci-webui-check -> 105 OK; pytest test_webui_ci_gate+mvp_suite 17 passed LAST_UPDATED_BY: sysadmin (prgs-reviewer) ## Review notes - Not self-review (author jcwalker3). - Contains master 351ef38; mergeable=true. - Prior REQUEST_CHANGES (lease_loader import + #558 unittest hermeticity) addressed by rebase + commit 64b83cd.

sysadmin commented 2026-07-09 11:06:11 -05:00

Owner

Copy Link

Copy Source

adopted_at: 2026-07-09T16:06:10Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 46820-dd78cdc4aacc
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 8260
adoption_reason: merger-handoff-approved-head

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #457
issue: #436
reviewer_identity: sysadmin
profile: prgs-merger
session_id: merger-queue-457-20260709
worktree: branches/merger-queue
phase: adopted
candidate_head: 64b83cd1fb
target_branch: master
target_branch_sha: 351ef3899b
last_activity: 2026-07-09T16:06:10Z
expires_at: 2026-07-09T18:06:10Z
blocker: none

<!-- mcp-review-lease-adoption:v1 --> adopted_at: 2026-07-09T16:06:10Z adopted_by_identity: sysadmin adopted_by_profile: prgs-merger adopted_from_session_id: 46820-dd78cdc4aacc adopted_from_profile: prgs-reviewer adopted_from_reviewer_identity: sysadmin adopted_from_comment_id: 8260 adoption_reason: merger-handoff-approved-head <!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #457 issue: #436 reviewer_identity: sysadmin profile: prgs-merger session_id: merger-queue-457-20260709 worktree: branches/merger-queue phase: adopted candidate_head: 64b83cd1fbca546c7e665734a52be35c19825472 target_branch: master target_branch_sha: 351ef3899b03a08e868b6517609143182d2f01ba last_activity: 2026-07-09T16:06:10Z expires_at: 2026-07-09T18:06:10Z blocker: none

sysadmin merged commit 946d6c2f81 into master 2026-07-09 11:06:55 -05:00

Sign in to join this conversation.

Reviewers

No Reviewers

sysadmin

Labels

Clear labels

allocator

Controller-owned work allocator

anti-stomp

Prevent concurrent LLM session stomping

architecture

Architecture / structural design

bug

chore

codex

OpenAI Codex client / workflow session surface

concurrency

Concurrent session safety

contamination

Workflow or session contamination incident

control-plane

MCP control-plane coordination and allocation authority

dashboard

MCP operational dashboard/queue view

database

Internal coordination storage (SQLite/Postgres)

design

Design / investigation, no implementation

documentation

Docs / runbooks

enhancement

New feature or improvement

gitea

Gitea MCP workflow

glitchtip

GlitchTip integration

important

incident

Operational or process incident requiring durable audit trail

incident-bridge

Sentry-to-Gitea incident bridging

integration

Integration testing

jenkins

Jenkins integration

labels

Label taxonomy management

leases

Lease adopt/release/expire lifecycle

mcp

MCP server / tooling

mcp-health

MCP namespace and runtime health

mcp-menu

MCP menu surface

multi-project

Work spanning multiple monitoring projects or Gitea repos

mutating

Mutating action; requires gating

nice-to-have

observability

Observability, metrics, traces, error reporting

portability

Cross-platform / portability

preflight

Shared preflight gates before mutation

protected-branch

Protected branch / stable-branch policy concern

queue

Work queue visibility and allocation

read-only

Read-only, no mutation

reconnect

MCP client reconnect/reload recovery path

recovery

Recovery paths for stale/foreign leases

refactor

Code refactor / restructure

release

Release / versioning

reliability

Reliability / failure handling

resumable-review

Persist and resume prepared review verdicts across sessions

reviewer

Reviewer workflow tooling

roadmap

Roadmap / umbrella issue

safety

Safety rails and fail-closed mutation guards

security

Security / trust boundary

self-hosted

Self-hosted infrastructure integration

sentry

Sentry error monitoring integration

stale-runtime

Stale backend daemon / runtime-vs-master parity failures

status:blocked

Issue is blocked

status:in-progress

Issue is being worked on

status:pr-open

Issue has an open pull request

status:ready

Issue is ready for work

terminal-lock

Terminal review lock (#332) path

testing

Tests / test coverage

tracker

Issue tracker hygiene / meta

type:bug

Bug or defect

type:feature

Feature or enhancement

type:feature

Feature or enhancement

type:guardrail

Safety gate or guardrail

visibility

Workflow state visibility for LLMs/operators

workflow

Cross-tool workflow

workflow-hardening

LLM workflow coordination hardening

workflow-hardening

LLM workflow coordination hardening

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

jcwalker3 sysadmin

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#457