feat: enforce author work leases in issue lock preflight (Closes #267) #386

2026-07-07T08:31:54-05:00

jcwalker3 commented

2026-07-07 08:31:54 -05:00

Summary

Implements #267: gitea_lock_issue now builds and enforces an author_issue_work lease so a second LLM session cannot start implementation work on an issue while an active lease exists.

Changes

gitea_mcp_server.py — work-lease constants (WORK_LEASE_TTL_HOURS = 4, author_issue_work operation), lease build/parse/timestamp helpers, claimant identity capture, fail-closed block on an active lease for the matching operation, expired-lease recovery takeover path, and remote-branch reuse detection for existing issue branches
tests/test_mcp_server.py — three new tests: lock reuse via an existing remote issue branch, active lease for the matching operation blocks a second lock, expired lease requires recovery takeover
docs/llm-workflow-runbooks.md, docs/wiki/Workflow.md — lease lifecycle and required stop messages

Session handoff note

Branch feat/issue-267-work-leases (head 0cc3ed8868442fc7b3298676f76c18224b9f9dcd) was authored and pushed at 05:35 today by an earlier session that stopped before opening a PR. This session verified the claim was stalled (no PR, no claim comment, branch idle while sibling sessions progressed), validated the head, and opened this PR. No new commits were added; the head SHA is unchanged.

Validation

Branch head 0cc3ed8 (base 634d8a1): pytest tests/ → 1202 passed, 1 failed, 6 skipped, 20 subtests passed. The failure is TestIssueLockArtifactWarning (#359), pre-existing on this base and fixed on master by merged PR #364; the test passes on current master (7b71113).
Merge simulation with master 7b71113 (clean merge, throwaway scratch worktree): 1317 passed, 1 failed, 6 skipped, 20 subtests passed. The failure is test_final_report_validator.py::TestReviewPrRules::test_clean_reviewer_report_passes, which fails on clean master without this diff (standing master failure documented in the PR #373/#375/#379 handoffs). Neither failure is introduced by this branch.

Closes #267

## Summary Implements #267: `gitea_lock_issue` now builds and enforces an `author_issue_work` lease so a second LLM session cannot start implementation work on an issue while an active lease exists. ## Changes - `gitea_mcp_server.py` — work-lease constants (`WORK_LEASE_TTL_HOURS = 4`, `author_issue_work` operation), lease build/parse/timestamp helpers, claimant identity capture, fail-closed block on an active lease for the matching operation, expired-lease recovery takeover path, and remote-branch reuse detection for existing issue branches - `tests/test_mcp_server.py` — three new tests: lock reuse via an existing remote issue branch, active lease for the matching operation blocks a second lock, expired lease requires recovery takeover - `docs/llm-workflow-runbooks.md`, `docs/wiki/Workflow.md` — lease lifecycle and required stop messages ## Session handoff note Branch `feat/issue-267-work-leases` (head `0cc3ed8868442fc7b3298676f76c18224b9f9dcd`) was authored and pushed at 05:35 today by an earlier session that stopped before opening a PR. This session verified the claim was stalled (no PR, no claim comment, branch idle while sibling sessions progressed), validated the head, and opened this PR. No new commits were added; the head SHA is unchanged. ## Validation - Branch head `0cc3ed8` (base `634d8a1`): `pytest tests/` → **1202 passed, 1 failed, 6 skipped, 20 subtests passed**. The failure is `TestIssueLockArtifactWarning` (#359), pre-existing on this base and fixed on master by merged PR #364; the test passes on current master (`7b71113`). - Merge simulation with master `7b71113` (clean merge, throwaway scratch worktree): **1317 passed, 1 failed, 6 skipped, 20 subtests passed**. The failure is `test_final_report_validator.py::TestReviewPrRules::test_clean_reviewer_report_passes`, which fails on clean master without this diff (standing master failure documented in the PR #373/#375/#379 handoffs). Neither failure is introduced by this branch. Closes #267

jcwalker3 added 1 commit 2026-07-07 08:31:55 -05:00

feat: enforce author work leases (Closes #267 ) 0cc3ed8868

jcwalker3 referenced this pull request

2026-07-07 08:32:08 -05:00

Add issue/PR work leases so multiple LLMs cannot accidentally do the same work #267

sysadmin approved these changes 2026-07-07 09:52:25 -05:00

sysadmin left a comment

Manual review of changed files and test suite validation passed. The new work-lease logic correctly prevents multiple LLMs from concurrently claiming issues or branches, resolving issue #267. Validation on the branch head has a pre-existing/baseline-equivalent failure which is resolved when merged with master. All tests pass cleanly on the merged code. Approved.