Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

feat: reject stale already-landed controller handoff fields (Closes #299) #371

Merged
sysadmin merged 7 commits from feat/issue-299-already-landed-handoff into master 2026-07-07 09:00:07 -05:00
Conversation 3 Commits 7 Files Changed 4
+374
jcwalker3 commented 2026-07-07 04:42:21 -05:00
Owner
Copy Link
Copy Source

Summary

Implements issue #299: when the already-landed gate fires, controller handoffs must not retain stale review/merge fields and must stay consistent with the narrative report.

Changes

  • Add reviewer_already_landed_handoff.py with assess_already_landed_handoff_report()
  • Reject Pinned reviewed head, Scratch worktree used, legacy Mutations/Workspace mutations: None when git fetch or other mutations occurred
  • Require Candidate head SHA, Reviewed head SHA: none, Review worktree used: false
  • Detect narrative vs controller handoff drift on eligibility class, reviewed SHA, and worktree usage
  • Wire verifier into build_final_report and export from review_proofs
  • Tests in tests/test_reviewer_already_landed_handoff.py

Verification

pytest tests/test_reviewer_already_landed_handoff.py tests/test_llm_workflow_split.py::test_already_landed_handoff_verifier_exported -q

12 passed

## Summary Implements issue #299: when the already-landed gate fires, controller handoffs must not retain stale review/merge fields and must stay consistent with the narrative report. ## Changes - Add `reviewer_already_landed_handoff.py` with `assess_already_landed_handoff_report()` - Reject `Pinned reviewed head`, `Scratch worktree used`, legacy `Mutations/Workspace mutations: None` when git fetch or other mutations occurred - Require `Candidate head SHA`, `Reviewed head SHA: none`, `Review worktree used: false` - Detect narrative vs controller handoff drift on eligibility class, reviewed SHA, and worktree usage - Wire verifier into `build_final_report` and export from `review_proofs` - Tests in `tests/test_reviewer_already_landed_handoff.py` ## Verification ``` pytest tests/test_reviewer_already_landed_handoff.py tests/test_llm_workflow_split.py::test_already_landed_handoff_verifier_exported -q ``` 12 passed
jcwalker3 added 1 commit 2026-07-07 04:42:21 -05:00
feat: reject stale already-landed controller handoff fields (#299) 2c65cf05ca 
Add assess_already_landed_handoff_report verifier to block Pinned reviewed
head, Scratch worktree used, legacy Mutations/Workspace mutations None when
git fetch or other mutations occurred, and narrative/handoff drift after the
already-landed gate fires. Wire into build_final_report and review_proofs.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
jcwalker3 commented 2026-07-07 04:42:26 -05:00
Author
Owner
Copy Link
Copy Source

Ready for review. Closes #299.

Verifier: reviewer_already_landed_handoff.assess_already_landed_handoff_report()
Tests: pytest tests/test_reviewer_already_landed_handoff.py -q (12 passed)

Ready for review. Closes #299. Verifier: `reviewer_already_landed_handoff.assess_already_landed_handoff_report()` Tests: `pytest tests/test_reviewer_already_landed_handoff.py -q` (12 passed)
jcwalker3 added 1 commit 2026-07-07 08:17:40 -05:00
fix: resolve conflicts for PR #371 against current master 2900add223
jcwalker3 added 1 commit 2026-07-07 08:31:49 -05:00
fix: resolve conflicts for PR #371 against latest master 3c9841760c 
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
jcwalker3 added 1 commit 2026-07-07 08:37:20 -05:00
fix: resolve conflicts for PR #371 against latest master 8b555043e3
jcwalker3 added 1 commit 2026-07-07 08:44:47 -05:00
fix: resolve conflicts for PR #371 against current master 3c2dd055fa 
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
sysadmin approved these changes 2026-07-07 08:50:13 -05:00
Dismissed
sysadmin left a comment
Owner
Copy Link
Copy Source

Review summary (PR #371 / #299)

Workflow: skills/llm-project-workflow/workflows/review-merge-pr.md (hash c20091c5a5fb)

Scope: Adds reviewer_already_landed_handoff.py verifier and wires it into build_final_report to reject stale controller-handoff fields after the already-landed gate fires. Conflict resolution with master correctly retains both this verifier and the #289 assess_infra_stop_handoff_report export.

Files reviewed:

  • reviewer_already_landed_handoff.py
  • review_proofs.py
  • tests/test_reviewer_already_landed_handoff.py
  • tests/test_llm_workflow_split.py

Validation (official PR-head, worktree branches/review-pr371-issue-299-already-landed-handoff, head 3c2dd055fa3a):

  • Targeted: 13 passed
  • Related regressions: 24 passed, 1 failed (test_clean_reviewer_report_passes)
  • Full suite: 1371 passed, 1 failed, 6 skipped
  • Baseline master e7a1e18: same single failure — pre-existing, not introduced by this PR

Checks: author-safety pass (reviewer sysadmin ≠ author jcwalker3); not already-landed; linked issue #299 open; no prior REQUEST_CHANGES; worktree clean before/after validation.

Approved.

## Review summary (PR #371 / #299) **Workflow:** `skills/llm-project-workflow/workflows/review-merge-pr.md` (hash `c20091c5a5fb`) **Scope:** Adds `reviewer_already_landed_handoff.py` verifier and wires it into `build_final_report` to reject stale controller-handoff fields after the already-landed gate fires. Conflict resolution with master correctly retains both this verifier and the #289 `assess_infra_stop_handoff_report` export. **Files reviewed:** - `reviewer_already_landed_handoff.py` - `review_proofs.py` - `tests/test_reviewer_already_landed_handoff.py` - `tests/test_llm_workflow_split.py` **Validation (official PR-head, worktree `branches/review-pr371-issue-299-already-landed-handoff`, head `3c2dd055fa3a`):** - Targeted: 13 passed - Related regressions: 24 passed, 1 failed (`test_clean_reviewer_report_passes`) - Full suite: 1371 passed, 1 failed, 6 skipped - Baseline master `e7a1e18`: same single failure — pre-existing, not introduced by this PR **Checks:** author-safety pass (reviewer `sysadmin` ≠ author `jcwalker3`); not already-landed; linked issue #299 open; no prior REQUEST_CHANGES; worktree clean before/after validation. Approved.
jcwalker3 added 1 commit 2026-07-07 08:55:42 -05:00
fix: resolve conflicts for PR #371 b53e3de7cc 
Merge prgs/master and keep both already-landed-handoff (#299) and
inventory-worktree (#293) verifiers wired in build_final_report.
jcwalker3 added 1 commit 2026-07-07 08:58:49 -05:00
Merge remote-tracking branch 'prgs/master' into feat/issue-299-already-landed-handoff fbfcc08640
sysadmin approved these changes 2026-07-07 08:59:52 -05:00
sysadmin left a comment
Owner
Copy Link
Copy Source

All tests pass successfully after merging master (1417 passed, 1 failed [pre-existing]). Reviewed the implementation of assess_already_landed_handoff_report in reviewer_already_landed_handoff.py and the test coverage in tests/test_reviewer_already_landed_handoff.py. It correctly detects and rejects stale review / merge / worktree fields in the controller handoff and prevents narrative / handoff drift when the already-landed gate fires. Verified that the remaining failure is pre-existing on master.

All tests pass successfully after merging master (1417 passed, 1 failed [pre-existing]). Reviewed the implementation of `assess_already_landed_handoff_report` in `reviewer_already_landed_handoff.py` and the test coverage in `tests/test_reviewer_already_landed_handoff.py`. It correctly detects and rejects stale review / merge / worktree fields in the controller handoff and prevents narrative / handoff drift when the already-landed gate fires. Verified that the remaining failure is pre-existing on master.
sysadmin merged commit ae566d5cd1 into master 2026-07-07 09:00:07 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
sysadmin
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#371