feat: enforce validation environment proof in reviewer reports (Closes #311) #352

2026-07-07T04:08:53-05:00

jcwalker3 commented

2026-07-07 04:08:53 -05:00

Summary

Adds assess_validation_environment_proof so reviewer final reports must include the exact validation command, working directory, result evidence, and — for bare pytest — which pytest, pytest --version, and project-venv resolution proof.

Linked issue

Closes #311

Changes

review_proofs.py: new #311 assessor; wired into build_final_report
tests/test_review_proofs.py: 7 tests covering venv pytest, bare pytest with/without proof, vague summaries, structured environment dict, and build_final_report integration

Validation

PYTHONPATH=. venv/bin/pytest tests/test_review_proofs.py -q
157 passed

Worktree

Branch: feat/issue-311-validation-environment-proof
Worktree: branches/issue-311-validation-environment-proof
Commit: da9c0ba

Risk

Low — read-only report verifier only.

## Summary Adds `assess_validation_environment_proof` so reviewer final reports must include the exact validation command, working directory, result evidence, and — for bare `pytest` — `which pytest`, `pytest --version`, and project-venv resolution proof. ## Linked issue Closes #311 ## Changes - `review_proofs.py`: new `#311` assessor; wired into `build_final_report` - `tests/test_review_proofs.py`: 7 tests covering venv pytest, bare pytest with/without proof, vague summaries, structured environment dict, and build_final_report integration ## Validation ``` PYTHONPATH=. venv/bin/pytest tests/test_review_proofs.py -q 157 passed ``` ## Worktree - Branch: `feat/issue-311-validation-environment-proof` - Worktree: `branches/issue-311-validation-environment-proof` - Commit: `da9c0ba` ## Risk Low — read-only report verifier only.

jcwalker3 added 1 commit 2026-07-07 04:08:54 -05:00

feat: enforce validation environment proof in reviewer reports (Closes #311 ) da9c0ba54c

Add assess_validation_environment_proof requiring exact validation command,
working directory, result evidence, and bare-pytest executable/version/venv
proof before reviewer reports can claim validation success.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 referenced this issue from a commit

2026-07-07 04:36:56 -05:00

fix: resolve conflicts for PR #352

jcwalker3 added 1 commit 2026-07-07 04:36:56 -05:00

fix: resolve conflicts for PR #352 37dc3a38b8

sysadmin requested changes 2026-07-07 04:38:59 -05:00

Dismissed

sysadmin left a comment

The test test_clean_reviewer_report_passes in tests/test_final_report_validator.py is failing on the PR branch. This happens because _review_handoff() uses a bare pytest command (pytest tests/test_review_proofs.py -q), which is downgraded by the new validation environment proof check (resulting in grade 'downgraded' instead of 'A'). Please update the test helper to use a non-bare command like venv/bin/pytest tests/test_review_proofs.py -q or provide the necessary version and venv proof lines to satisfy the validator.

The test `test_clean_reviewer_report_passes` in `tests/test_final_report_validator.py` is failing on the PR branch. This happens because `_review_handoff()` uses a bare pytest command (`pytest tests/test_review_proofs.py -q`), which is downgraded by the new validation environment proof check (resulting in grade 'downgraded' instead of 'A'). Please update the test helper to use a non-bare command like `venv/bin/pytest tests/test_review_proofs.py -q` or provide the necessary version and venv proof lines to satisfy the validator.

jcwalker3 referenced this issue from a commit

2026-07-07 08:14:18 -05:00

fix: resolve conflicts for PR #352 against current master

jcwalker3 added 1 commit 2026-07-07 08:14:18 -05:00

fix: resolve conflicts for PR #352 against current master 764e636c07

sysadmin approved these changes 2026-07-07 08:18:12 -05:00

sysadmin left a comment

All tests pass successfully after merging master (1270 passed, 1 failed [pre-existing]). Reviewed the implementation of assess_validation_environment_proof in review_proofs.py and the test coverage in tests/test_review_proofs.py. It correctly verifies that the reviewer reports the exact validation command, working directory, and environment details. Verified that the remaining failure is pre-existing on master.

All tests pass successfully after merging master (1270 passed, 1 failed [pre-existing]). Reviewed the implementation of `assess_validation_environment_proof` in `review_proofs.py` and the test coverage in `tests/test_review_proofs.py`. It correctly verifies that the reviewer reports the exact validation command, working directory, and environment details. Verified that the remaining failure is pre-existing on master.

sysadmin merged commit 1487ff60b4 into master

2026-07-07 08:18:30 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#352