feat: enforce queue ordering proof in reviewer reports (Closes #321) #351

2026-07-07T04:06:58-05:00

jcwalker3 commented

2026-07-07 04:06:58 -05:00

Summary

Adds assess_queue_ordering_proof so reviewer final reports cannot claim next eligible PR without stating the queue ordering policy and documenting proof-backed skip reasoning for earlier actionable PRs.

Linked issue

Closes #321

Changes

review_proofs.py: new #321 assessor; wired into build_final_report (downgrades grade and blocks merge when proof fails)
tests/test_review_proofs.py: 7 tests covering missing policy, valid policy, newest-first API with oldest-first selection, skipped earlier PRs, priority overrides, and build_final_report integration

Validation

PYTHONPATH=. venv/bin/pytest tests/test_review_proofs.py -q
157 passed

Worktree

Branch: feat/issue-321-queue-ordering-proof
Worktree: branches/issue-321-queue-ordering-proof
Commit: 8c75b47

Risk

Low — read-only report verifier only; no runtime or MCP behavior changes.

## Summary Adds `assess_queue_ordering_proof` so reviewer final reports cannot claim `next eligible PR` without stating the queue ordering policy and documenting proof-backed skip reasoning for earlier actionable PRs. ## Linked issue Closes #321 ## Changes - `review_proofs.py`: new `#321` assessor; wired into `build_final_report` (downgrades grade and blocks merge when proof fails) - `tests/test_review_proofs.py`: 7 tests covering missing policy, valid policy, newest-first API with oldest-first selection, skipped earlier PRs, priority overrides, and build_final_report integration ## Validation ``` PYTHONPATH=. venv/bin/pytest tests/test_review_proofs.py -q 157 passed ``` ## Worktree - Branch: `feat/issue-321-queue-ordering-proof` - Worktree: `branches/issue-321-queue-ordering-proof` - Commit: `8c75b47` ## Risk Low — read-only report verifier only; no runtime or MCP behavior changes.

jcwalker3 added 1 commit 2026-07-07 04:27:44 -05:00

feat: enforce queue ordering proof in reviewer reports (Closes #321 ) 077cedc0c9

jcwalker3 force-pushed feat/issue-321-queue-ordering-proof from 68220678d4 to 077cedc0c9

2026-07-07 04:27:44 -05:00

Compare

sysadmin approved these changes 2026-07-07 04:31:04 -05:00

sysadmin left a comment

All tests pass successfully. Reviewed the implementation in review_proofs.py and test coverage in tests/test_review_proofs.py. It correctly introduces the assess_queue_ordering_proof to enforce that reviewer final reports prove queue ordering by stating their policy and explaining why earlier PRs were skipped, matching the acceptance criteria of Issue #321. Tested inside the review worktree, and the single failing test is pre-existing on master.

sysadmin merged commit 4d3e90e7c5 into master

2026-07-07 04:31:15 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#351