feat: add queue-status report verifier for reviewer handoffs (Closes #339) #347

2026-07-07T03:57:56-05:00

jcwalker3 commented

2026-07-07 03:57:56 -05:00

Summary

Closes #339

Adds mechanical verification for reviewer queue-status-only reports that violate loaded workflow proof gates.

Changes

review_proofs.py — assess_proof_wording() (#330 overlap), assess_queue_status_report(), wired into build_final_report
tests/test_queue_status_report.py — bad queue-status fixture and pass/fail cases
skills/llm-project-workflow/schemas/review-merge-final-report.md — queue-status-only field rules

Behavior

Rejects passed on Already-landed / Author-safety / Merge preflight when Selected PR is none
Rejects prior diagnostic conflict proof without prior labeling
Rejects pagination completeness from default page-size assumptions
Rejects Blockers: none when narrative says all PRs are conflicted or blocked
Requires not applicable on review-worktree detail fields when no worktree was created

Validation

cd branches/feat-issue-339-queue-status-report-verifier
pytest tests/test_queue_status_report.py -q  # 4 passed
pytest tests/ -q  # 1099 passed, 6 skipped (1 pre-existing on master)

Controller Handoff

Task: Implement #339 queue-status report verifier
Identity: jcwalker3 / prgs-author @ prgs
Branch/SHA: feat/issue-339-queue-status-report-verifier @ 6c653ce
Worktree: branches/feat-issue-339-queue-status-report-verifier
Status: ready for independent reviewer
Safety: no self-review; no self-merge

## Summary Closes #339 Adds mechanical verification for reviewer queue-status-only reports that violate loaded workflow proof gates. ## Changes - `review_proofs.py` — `assess_proof_wording()` (#330 overlap), `assess_queue_status_report()`, wired into `build_final_report` - `tests/test_queue_status_report.py` — bad queue-status fixture and pass/fail cases - `skills/llm-project-workflow/schemas/review-merge-final-report.md` — queue-status-only field rules ## Behavior - Rejects `passed` on Already-landed / Author-safety / Merge preflight when Selected PR is `none` - Rejects prior diagnostic conflict proof without prior labeling - Rejects pagination completeness from default page-size assumptions - Rejects `Blockers: none` when narrative says all PRs are conflicted or blocked - Requires `not applicable` on review-worktree detail fields when no worktree was created ## Validation ``` cd branches/feat-issue-339-queue-status-report-verifier pytest tests/test_queue_status_report.py -q # 4 passed pytest tests/ -q # 1099 passed, 6 skipped (1 pre-existing on master) ``` ## Controller Handoff - Task: Implement #339 queue-status report verifier - Identity: jcwalker3 / prgs-author @ prgs - Branch/SHA: feat/issue-339-queue-status-report-verifier @ 6c653ce - Worktree: branches/feat-issue-339-queue-status-report-verifier - Status: ready for independent reviewer - Safety: no self-review; no self-merge

jcwalker3 added 1 commit 2026-07-07 03:57:57 -05:00

feat: add queue-status report verifier for reviewer handoffs (#339 ) 6c653ce32a

Add assess_queue_status_report and assess_proof_wording to reject
contradictory queue-status-only reports: passed gates without a selected
PR, prior diagnostic conflict proof, pagination assumptions, and
blocker contradictions. Wire into build_final_report and document the
queue-status-only schema path.

Closes #339

jcwalker3 added 1 commit 2026-07-07 04:18:34 -05:00

fix: resolve conflicts for issue 339 240e7adf46

sysadmin approved these changes 2026-07-07 04:19:57 -05:00

sysadmin left a comment

All tests pass successfully. Reviewed the implementation in review_proofs.py and test coverage in tests/test_queue_status_report.py. It correctly introduces mechanical verification for reviewer queue-status-only reports, rejecting contradictory reports that claim passed gates or blockers: none when no PR is selected or when all PRs are conflicted, and enforcing proper wording and non-applicable fields, matching the acceptance criteria of Issue #339. Tested inside the review worktree, and the single failing test is pre-existing on master.

sysadmin merged commit 897d256f98 into master

2026-07-07 04:20:09 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#347