Add final-report mutation ledger verifier (#331) #338

2026-07-07T03:08:37-05:00

jcwalker3 commented

2026-07-07 03:08:37 -05:00

Summary

Closes #331

Adds assess_mutation_ledger_report in review_proofs.py so reviewer final reports are mechanically checked against observed file write/edit actions.

Behavior

Performed mutations (Edited/Created/Wrote/Generated) must appear in the report ledger.
File edits by reviewer: none fails when the action log records performed mutations.
Outside-repo writes require an outside repo label with the exact path.
In-repo writes require tracked/untracked status when known.
Walkthrough artifacts fail unless explicitly requested by workflow/operator.
Post-git status artifacts require a final git status in the report.
Gated rejections are excluded from performed mutations but should be reported separately.

Files changed

review_proofs.py — verifier helper
tests/test_mutation_ledger_report.py — 6 acceptance tests

Validation

PASSED: pytest tests/test_mutation_ledger_report.py -q — 6 passed in 0.39s
PASSED: pytest tests/ -q — 1077 passed, 6 skipped (1 pre-existing failure in test_agent_temp_artifacts; not introduced by this diff)

Controller Handoff

Task: Implement #331 mutation ledger verifier
Repo/state: Scaled-Tech-Consulting/Gitea-Tools @ prgs; issue #331 in-progress; branch pushed
Issues/PRs: Closes #331; PR opening now
Changed: review_proofs.py, tests/test_mutation_ledger_report.py
Validation: targeted 6/6 pass; full suite 1077 pass
Blockers: none
Review: PR open — needs reviewer approval; no self-review/merge
Next: reviewer validates verifier + tests; merge when approved
Safety: no self-review; no self-merge; no tags; no secrets; no prod

## Summary Closes #331 Adds `assess_mutation_ledger_report` in `review_proofs.py` so reviewer final reports are mechanically checked against observed file write/edit actions. ## Behavior - Performed mutations (`Edited`/`Created`/`Wrote`/`Generated`) must appear in the report ledger. - `File edits by reviewer: none` fails when the action log records performed mutations. - Outside-repo writes require an `outside repo` label with the exact path. - In-repo writes require tracked/untracked status when known. - Walkthrough artifacts fail unless explicitly requested by workflow/operator. - Post-`git status` artifacts require a final `git status` in the report. - Gated rejections are excluded from performed mutations but should be reported separately. ## Files changed - `review_proofs.py` — verifier helper - `tests/test_mutation_ledger_report.py` — 6 acceptance tests ## Validation ``` PASSED: pytest tests/test_mutation_ledger_report.py -q — 6 passed in 0.39s PASSED: pytest tests/ -q — 1077 passed, 6 skipped (1 pre-existing failure in test_agent_temp_artifacts; not introduced by this diff) ``` ## Controller Handoff Task: Implement #331 mutation ledger verifier Repo/state: Scaled-Tech-Consulting/Gitea-Tools @ prgs; issue #331 in-progress; branch pushed Issues/PRs: Closes #331; PR opening now Changed: review_proofs.py, tests/test_mutation_ledger_report.py Validation: targeted 6/6 pass; full suite 1077 pass Blockers: none Review: PR open — needs reviewer approval; no self-review/merge Next: reviewer validates verifier + tests; merge when approved Safety: no self-review; no self-merge; no tags; no secrets; no prod

jcwalker3 added 1 commit 2026-07-07 03:08:38 -05:00

Add final-report mutation ledger verifier (#331 ) ae4dd0ff91

Introduce assess_mutation_ledger_report so reviewer final reports cannot
claim no file edits when the action log records performed mutations.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

sysadmin approved these changes 2026-07-07 03:10:17 -05:00

sysadmin left a comment

PR #338 successfully implements mechanical final-report mutation ledger verification. All targeted tests and baseline validation comparisons pass.

sysadmin merged commit fd396df334 into master

2026-07-07 03:10:31 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#338