Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

feat: extract review-merge-pr workflow from monolithic LLM skill #335

Merged
sysadmin merged 4 commits from feat/issue-334-review-merge-workflow-extract into master 2026-07-07 03:57:19 -05:00
Conversation 2 Commits 4 Files Changed 1
+19 -1
jcwalker3 commented 2026-07-07 02:33:16 -05:00
Owner
Copy Link
Copy Source

Closes #334

Part of #333.

Summary

Splits reviewer-only rules out of the monolithic skills/llm-project-workflow/SKILL.md into dedicated workflow and schema files.

Changes

  • workflows/review-merge-pr.md — self-contained PR review/merge workflow
  • schemas/review-merge-final-report.md — reviewer controller handoff + mutation ledger
  • SKILL.md — task-mode router; §F/§G replaced with links to extracted workflow
  • templates/review-pr.md, templates/merge-pr.md — reference extracted workflow
  • tests/test_llm_workflow_split.py — doc-contract tests

Validation

pytest tests/test_llm_workflow_split.py tests/test_review_proofs.py::TestControllerHandoff::test_skill_doc_declares_handoff_requirement tests/test_shell_spawn_hard_stop_docs.py::test_skill_doc_declares_shell_spawn_hard_stop_rule -q
→ 8 passed

Out of scope (follow-up)

  • workflows/create-issue.md and workflows/work-issue.md (#333 siblings)
  • gates/*.md shared rule files
Closes #334 Part of #333. ## Summary Splits reviewer-only rules out of the monolithic `skills/llm-project-workflow/SKILL.md` into dedicated workflow and schema files. ## Changes - `workflows/review-merge-pr.md` — self-contained PR review/merge workflow - `schemas/review-merge-final-report.md` — reviewer controller handoff + mutation ledger - `SKILL.md` — task-mode router; §F/§G replaced with links to extracted workflow - `templates/review-pr.md`, `templates/merge-pr.md` — reference extracted workflow - `tests/test_llm_workflow_split.py` — doc-contract tests ## Validation ``` pytest tests/test_llm_workflow_split.py tests/test_review_proofs.py::TestControllerHandoff::test_skill_doc_declares_handoff_requirement tests/test_shell_spawn_hard_stop_docs.py::test_skill_doc_declares_shell_spawn_hard_stop_rule -q → 8 passed ``` ## Out of scope (follow-up) - `workflows/create-issue.md` and `workflows/work-issue.md` (#333 siblings) - `gates/*.md` shared rule files
jcwalker3 added 1 commit 2026-07-07 02:33:16 -05:00
feat(skill): extract review-merge-pr workflow from monolithic SKILL.md 3976f886e4 
Closes #334

- Add workflows/review-merge-pr.md with reviewer-only gates and steps
- Add schemas/review-merge-final-report.md with mutation ledger fields
- Turn SKILL.md into task-mode router; replace inlined §F/§G with links
- Point review/merge templates at extracted workflow
- Add doc-contract tests for split structure

Part of #333.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
jcwalker3 added 1 commit 2026-07-07 02:37:46 -05:00
docs(skill): load canonical review-merge prompt into workflow file c05b2f4c05 
Replace summary workflow with full §0–§38 canonical PR review/merge rules.
Align review-merge-final-report schema with §37 controller handoff fields.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
jcwalker3 added 1 commit 2026-07-07 03:31:53 -05:00
merge: resolve PR #335 conflicts with master (fd396df) 25c9d20870 
Keep master router-style SKILL.md (full #333 split) and merge #334
review-merge test coverage into test_llm_workflow_split.py.

Conflicts resolved in:
- skills/llm-project-workflow/SKILL.md
- tests/test_llm_workflow_split.py
jcwalker3 added 1 commit 2026-07-07 03:38:16 -05:00
Merge remote-tracking branch 'prgs/master' into feat/issue-334-review-merge-workflow-extract 72c20ee1e1
jcwalker3 commented 2026-07-07 03:38:24 -05:00
Author
Owner
Copy Link
Copy Source

Ready for review

Pushed head 72c20ee on feat/issue-334-review-merge-workflow-extract.

What changed since last update

  1. Conflict resolution (25c9d20): merged master @ fd396df and resolved conflicts in:

    • skills/llm-project-workflow/SKILL.md — kept full router design from #333/#336
    • tests/test_llm_workflow_split.py — merged #333 suite + #334 review-merge assertions

  2. Fresh with master (72c20ee): merged latest master @ eb6f006 (includes #286) — clean merge, no conflicts.

Validation

pytest tests/test_llm_workflow_split.py \
  tests/test_review_proofs.py::TestControllerHandoff::test_skill_doc_declares_handoff_requirement \
  tests/test_shell_spawn_hard_stop_docs.py::test_skill_doc_declares_shell_spawn_hard_stop_rule -q

17 passed

PR status: mergeable: true at prior check. No prior review verdicts on this PR.

## Ready for review Pushed head `72c20ee` on `feat/issue-334-review-merge-workflow-extract`. ### What changed since last update 1. **Conflict resolution** (`25c9d20`): merged `master` @ `fd396df` and resolved conflicts in: - `skills/llm-project-workflow/SKILL.md` — kept full router design from #333/#336 - `tests/test_llm_workflow_split.py` — merged #333 suite + #334 review-merge assertions 2. **Fresh with master** (`72c20ee`): merged latest `master` @ `eb6f006` (includes #286) — clean merge, no conflicts. ### Validation ``` pytest tests/test_llm_workflow_split.py \ tests/test_review_proofs.py::TestControllerHandoff::test_skill_doc_declares_handoff_requirement \ tests/test_shell_spawn_hard_stop_docs.py::test_skill_doc_declares_shell_spawn_hard_stop_rule -q ``` **17 passed** PR status: `mergeable: true` at prior check. No prior review verdicts on this PR.
sysadmin approved these changes 2026-07-07 03:57:08 -05:00
sysadmin left a comment
Owner
Copy Link
Copy Source

All tests pass successfully. Reviewed the test updates in tests/test_llm_workflow_split.py, verifying they correctly enforce the doc-contract and schemas for the extracted review-merge-pr workflow. Tested inside the review worktree, and the single failing test is pre-existing on master.

All tests pass successfully. Reviewed the test updates in tests/test_llm_workflow_split.py, verifying they correctly enforce the doc-contract and schemas for the extracted review-merge-pr workflow. Tested inside the review worktree, and the single failing test is pre-existing on master.
sysadmin merged commit 5e145957a5 into master 2026-07-07 03:57:19 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
sysadmin
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#335