docs: add Work Selection Rule for LLM operating rules (#272) #273

Merged
sysadmin merged 3 commits from docs/issue-272-work-selection-lease-rule into master 2026-07-06 13:23:18 -05:00
Owner

Closes #272

Summary

Adds the Work Selection Rule for LLMs to portable and Gitea-specific operating rules. Sessions must acquire or verify a work lease before coding, reviewing, branching, committing, pushing, commenting, or opening a PR.

Changes

  • skills/llm-project-workflow/SKILL.md — new rule section + step 0 in start-work workflow
  • skills/llm-project-workflow/templates/start-issue.md — lease checks before claim
  • docs/llm-workflow-runbooks.md — Gitea runbook section
  • docs/wiki/Workflow.md — author path step 0
  • gitea_mcp_server.pywork_selection in operator guide rules
  • Tests: doc-contract for SKILL section; operator guide key assertion

Validation

  • git diff --check — clean
  • unittest tests.test_review_proofs.TestControllerHandoff.test_skill_doc_declares_handoff_requirement — passed

Branch rename

Reopened after renaming head branch to docs/issue-272-work-selection-lease-rule (supersedes closed PR #265).

Closes #272 ## Summary Adds the **Work Selection Rule for LLMs** to portable and Gitea-specific operating rules. Sessions must acquire or verify a work lease before coding, reviewing, branching, committing, pushing, commenting, or opening a PR. ## Changes - `skills/llm-project-workflow/SKILL.md` — new rule section + step 0 in start-work workflow - `skills/llm-project-workflow/templates/start-issue.md` — lease checks before claim - `docs/llm-workflow-runbooks.md` — Gitea runbook section - `docs/wiki/Workflow.md` — author path step 0 - `gitea_mcp_server.py` — `work_selection` in operator guide rules - Tests: doc-contract for SKILL section; operator guide key assertion ## Validation - `git diff --check` — clean - `unittest tests.test_review_proofs.TestControllerHandoff.test_skill_doc_declares_handoff_requirement` — passed ## Branch rename Reopened after renaming head branch to `docs/issue-272-work-selection-lease-rule` (supersedes closed PR #265).
jcwalker3 added 1 commit 2026-07-06 12:54:41 -05:00
Require lease verification (open PRs, branches, worktrees, leases,
merged completion) before any issue or PR work. Surface the rule in
the portable skill, Gitea runbooks, operator guide, and start-issue
template; add doc-contract tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
jcwalker3 added 2 commits 2026-07-06 13:09:48 -05:00
Match git conflict markers on whole lines only so decorative equals
borders in mcp_discoverability.py no longer false-positive. Scan
session worktrees under branches/ without skipping the entire tree
when the worktree path contains "branches".

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Require mutations only from branches/ worktrees after proving project
root, cwd, branch, stable main-checkout branch, and session worktree
path. Surface in portable skill, runbooks, wiki, operator guide, and
start-issue template.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
sysadmin approved these changes 2026-07-06 13:23:12 -05:00
sysadmin left a comment
Owner

APPROVED

Scope: Matches Closes #272 — Work Selection Rule + Global LLM Worktree Rule across SKILL, runbooks, wiki, operator guide, and MCP operator guide keys.

Code review:

  • python_bytes_have_conflict_markers — line-anchor detection fixes false positives on decorative ======= banners.
  • skip_python_scan_walk_root — correctly skips sibling branches/ worktrees from orchestration checkout while still scanning the active worktree.
  • Doc-contract tests updated for new guide keys and SKILL sections.

Validation (from branches/review-pr273 worktree):

  • 56 tests in test_health, test_operator_guide, TestControllerHandoff, test_role_session_router — all passed
  • git diff --check — clean
  • Head SHA pinned: 216fa5cf467bbd9cf1a07a86b4e243a0c4784f97
## APPROVED **Scope:** Matches `Closes #272` — Work Selection Rule + Global LLM Worktree Rule across SKILL, runbooks, wiki, operator guide, and MCP operator guide keys. **Code review:** - `python_bytes_have_conflict_markers` — line-anchor detection fixes false positives on decorative `=======` banners. - `skip_python_scan_walk_root` — correctly skips sibling `branches/` worktrees from orchestration checkout while still scanning the active worktree. - Doc-contract tests updated for new guide keys and SKILL sections. **Validation (from `branches/review-pr273` worktree):** - 56 tests in `test_health`, `test_operator_guide`, `TestControllerHandoff`, `test_role_session_router` — all passed - `git diff --check` — clean - Head SHA pinned: `216fa5cf467bbd9cf1a07a86b4e243a0c4784f97`
sysadmin merged commit eb3560d949 into master 2026-07-06 13:23:18 -05:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#273