docs: separate Jenkins trigger onto jenkins-write-mcp boundary (#152) #264

2026-07-06T12:35:26-05:00

jcwalker3 commented

2026-07-06 12:35:26 -05:00

Refs #152.

Documentation slice for Jenkins trigger safety boundary (#152). Documents that jenkins_trigger_build belongs on the gated jenkins-write-mcp server, not the read-only jenkins-mcp surface. Updates registration and safety-model cross-links and adds doc tests that fail if trigger tools reappear on the read boundary.

Scope

docs/mcp-client-registration.md
docs/safety-model.md
docs/architecture/jenkins-readonly-build-status-design.md
tests/test_external_mcp_registration_docs.py

Validation

pytest tests/test_external_mcp_registration_docs.py -q → 8 passed
git diff --check → clean

Note: This PR does not implement fail-closed trigger audit code in jenkins-mcp; it aligns docs/tests with the accepted boundary split. Follow-up implementation remains on #152.

Refs #152. Documentation slice for Jenkins trigger safety boundary (#152). Documents that `jenkins_trigger_build` belongs on the gated `jenkins-write-mcp` server, not the read-only `jenkins-mcp` surface. Updates registration and safety-model cross-links and adds doc tests that fail if trigger tools reappear on the read boundary. ## Scope - `docs/mcp-client-registration.md` - `docs/safety-model.md` - `docs/architecture/jenkins-readonly-build-status-design.md` - `tests/test_external_mcp_registration_docs.py` ## Validation - `pytest tests/test_external_mcp_registration_docs.py -q` → 8 passed - `git diff --check` → clean Note: This PR does not implement fail-closed trigger audit code in jenkins-mcp; it aligns docs/tests with the accepted boundary split. Follow-up implementation remains on #152.

jcwalker3 added 1 commit 2026-07-06 12:35:27 -05:00

docs: separate Jenkins trigger onto jenkins-write-mcp boundary (#152 ) b4e04f4dfb

Document that build triggers live on the gated jenkins-write-mcp server,
not the read-only jenkins-mcp surface. Add registration and safety-model
cross-links plus doc tests that fail if trigger tools reappear on the read
boundary.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

sysadmin requested changes 2026-07-06 12:39:58 -05:00

Dismissed

sysadmin left a comment

REQUEST_CHANGES

Doc content and tests look good at b4e04f4, but merge is blocked on issue-closure semantics.

Blocking: PR body says Refs #152 instead of a Gitea-closing keyword (Closes #152 / Fixes #152). This documentation slice is intended to close #152; non-closing refs will leave the issue open after merge.

Validation (scratch branches/review-pr264-issue-152):

pytest tests/test_external_mcp_registration_docs.py -v — 8 passed
git diff --check — clean
Scope: 4 doc/test files only ✓

Required fix: Update PR title/body to Closes #152 (or Fixes #152). No code changes needed.

## REQUEST_CHANGES Doc content and tests look good at `b4e04f4`, but merge is blocked on issue-closure semantics. **Blocking:** PR body says `Refs #152` instead of a Gitea-closing keyword (`Closes #152` / `Fixes #152`). This documentation slice is intended to close #152; non-closing refs will leave the issue open after merge. **Validation (scratch `branches/review-pr264-issue-152`):** - `pytest tests/test_external_mcp_registration_docs.py -v` — 8 passed - `git diff --check` — clean - Scope: 4 doc/test files only ✓ **Required fix:** Update PR title/body to `Closes #152` (or `Fixes #152`). No code changes needed.

sysadmin approved these changes 2026-07-06 13:26:10 -05:00

sysadmin left a comment

APPROVED

Scope: 4 files only — registration doc, safety-model, Jenkins architecture design, doc-contract tests. Matches stated docs slice for #152.

Review:

jenkins_trigger_build correctly documented as jenkins-write-mcp / jenkins_mcp.write_server, not on read-only jenkins-mcp
Cross-links between related docs preserved
New tests guard against trigger tools reappearing on read surface

Issue closure: Refs #152 is correct. Issue #152 acceptance criteria require implementation (fail-closed audit, trigger tests, profile gates). This PR explicitly states follow-up implementation remains on #152 — must not use Closes.

Validation (from branches/review-pr264 worktree):

pytest tests/test_external_mcp_registration_docs.py — 8 passed
git diff --check — clean
Head SHA: b4e04f4dfb09d7ef7a3766fa63f19fcc646b4c68

## APPROVED **Scope:** 4 files only — registration doc, safety-model, Jenkins architecture design, doc-contract tests. Matches stated docs slice for #152. **Review:** - `jenkins_trigger_build` correctly documented as `jenkins-write-mcp` / `jenkins_mcp.write_server`, not on read-only `jenkins-mcp` - Cross-links between related docs preserved - New tests guard against trigger tools reappearing on read surface **Issue closure:** `Refs #152` is correct. Issue #152 acceptance criteria require implementation (fail-closed audit, trigger tests, profile gates). This PR explicitly states follow-up implementation remains on #152 — must not use `Closes`. **Validation (from `branches/review-pr264` worktree):** - `pytest tests/test_external_mcp_registration_docs.py` — 8 passed - `git diff --check` — clean - Head SHA: `b4e04f4dfb09d7ef7a3766fa63f19fcc646b4c68`

sysadmin merged commit 183e9f08b8 into master

2026-07-06 13:26:16 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#264