fix(mcp): clear sticky reviewer denial on allowed author task route (closes #238) #242

2026-07-06T10:37:49-05:00

jcwalker3 commented

2026-07-06 10:37:49 -05:00

Fixes sticky capability denial blocking author list_prs after wrong-role reviewer attempt. Closes #238

jcwalker3 added 1 commit 2026-07-06 10:37:50 -05:00

fix(mcp): clear sticky reviewer denial on allowed author task route (#238 ) d4e89f7863

Add sync_from_capability_result() so reviewer terminal mode is
operation-scoped: a later allowed author capability resolution clears
stale denial state and unblocks read-only tools like gitea_list_prs.

Error messages now name the denied task and explain how to clear stale
state. Inline trust-gate parsing fixes broken imports in
assess_capability_stop_report on master.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 referenced this pull request

2026-07-06 10:54:44 -05:00

Pre-flight order gate counts foreign workspace edits and sticks after fresh whoami, blocking legitimate review submissions #252

sysadmin reviewed 2026-07-06 11:21:55 -05:00

sysadmin left a comment

APPROVE — PR #242

Validated against pinned head d4e89f786393d03f5d5326562cc31639d4be8525.

Scope: Clean — 3 files, matches #238. Uses Closes #238.

Changes:

sync_from_capability_result clears stale reviewer terminal denial when a later allowed author task routes (#238)
Task-scoped denial messaging for blocked queue tools
_ensure_matching_profile auto-switch hook in capability/permission gates
New response fields on gitea_resolve_task_capability (available_in_session, configured, restart_required, reason, cleared_stale_denial)
Test: test_list_prs_allowed_after_author_task_clears_stale_denial

Validation:

unittest tests.test_capability_stop_terminal -v — 10/10 passed
unittest tests.test_permission_reports tests.test_pr_queue_inventory tests.test_resolve_task_capability — 45/45 passed
Full suite: 892 tests, 16 failures + 1 error — better than master baseline (903 tests, 16+3)
Secret sweep: clean

Worktree: branches/review-feat-issue-238-sticky-denial-clear (detached, clean)

Review Metadata:

LLM-Role: reviewer
Authenticated-Gitea-User: sysadmin
MCP-Profile: prgs-reviewer
Eligibility: passed

## APPROVE — PR #242 Validated against pinned head `d4e89f786393d03f5d5326562cc31639d4be8525`. **Scope:** Clean — 3 files, matches #238. Uses `Closes #238`. **Changes:** - `sync_from_capability_result` clears stale reviewer terminal denial when a later allowed author task routes (#238) - Task-scoped denial messaging for blocked queue tools - `_ensure_matching_profile` auto-switch hook in capability/permission gates - New response fields on `gitea_resolve_task_capability` (`available_in_session`, `configured`, `restart_required`, `reason`, `cleared_stale_denial`) - Test: `test_list_prs_allowed_after_author_task_clears_stale_denial` **Validation:** - `unittest tests.test_capability_stop_terminal -v` — 10/10 passed - `unittest tests.test_permission_reports tests.test_pr_queue_inventory tests.test_resolve_task_capability` — 45/45 passed - Full suite: 892 tests, 16 failures + 1 error — **better than master baseline** (903 tests, 16+3) - Secret sweep: clean **Worktree:** `branches/review-feat-issue-238-sticky-denial-clear` (detached, clean) --- Review Metadata: - LLM-Role: reviewer - Authenticated-Gitea-User: sysadmin - MCP-Profile: prgs-reviewer - Eligibility: passed

sysadmin merged commit 6e27911733 into master

2026-07-06 11:22:00 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#242