Selected PR #218 because it is the oldest open PR that is not self-authored, not draft/WIP, reviewer-eligible for sysadmin / prgs-reviewer, and not already blocked by a current change request. I pinned and fetched head 9274eebfafb0b18744f69bcb4d301b678e6364b1.
Blocker:
PR #218 is stale/not mergeable against current master. Local state after fetch: prgs/master is 34a26d1c14cca9a9d6a80e750ecce9e05ad961a7, PR head is 9274eebfafb0b18744f69bcb4d301b678e6364b1, and merge-base is 87397230e83c5fa4ae48b6686dff0c014db16858. Gitea also reports mergeable: false.
Conflict-resolution capability check:
create_branch requires gitea.branch.create and is stop-required in prgs-reviewer.
push_branch requires gitea.branch.push and is stop-required in prgs-reviewer.
address_pr_change_requests requires gitea.branch.push and is stop-required in prgs-reviewer.
Runtime profile explicitly forbids gitea.branch.create, gitea.branch.push, gitea.pr.create, and gitea.repo.commit.
Because this reviewer profile lacks the exact checkout/update/commit/push capabilities needed to update the PR branch, I did not attempt conflict resolution, did not modify the branch, and did not run the normal post-resolution validation. Please rebase or otherwise update the PR branch from an author-capable session, then request re-review.
REQUEST_CHANGES
Selected PR #218 because it is the oldest open PR that is not self-authored, not draft/WIP, reviewer-eligible for `sysadmin / prgs-reviewer`, and not already blocked by a current change request. I pinned and fetched head `9274eebfafb0b18744f69bcb4d301b678e6364b1`.
Blocker:
- PR #218 is stale/not mergeable against current `master`. Local state after fetch: `prgs/master` is `34a26d1c14cca9a9d6a80e750ecce9e05ad961a7`, PR head is `9274eebfafb0b18744f69bcb4d301b678e6364b1`, and merge-base is `87397230e83c5fa4ae48b6686dff0c014db16858`. Gitea also reports `mergeable: false`.
Conflict-resolution capability check:
- `create_branch` requires `gitea.branch.create` and is stop-required in `prgs-reviewer`.
- `push_branch` requires `gitea.branch.push` and is stop-required in `prgs-reviewer`.
- `address_pr_change_requests` requires `gitea.branch.push` and is stop-required in `prgs-reviewer`.
- Runtime profile explicitly forbids `gitea.branch.create`, `gitea.branch.push`, `gitea.pr.create`, and `gitea.repo.commit`.
Because this reviewer profile lacks the exact checkout/update/commit/push capabilities needed to update the PR branch, I did not attempt conflict resolution, did not modify the branch, and did not run the normal post-resolution validation. Please rebase or otherwise update the PR branch from an author-capable session, then request re-review.
Identity:jcwalker3 / prgs-author New head SHA:b564dbf3fc55ecfdef3d38ea4ec6499b60dca4b5 Base: current prgs/master (5b9fcae)
Blockers addressed
Rebased feat/issue-197-capability-stop-terminal onto current master (staleness).
Conflicts resolved in #197 scope: kept all imports (capability_stop_terminal, issue_duplicate_gate, role_session_router); preserved record_mutation_authority + terminal-mode result wiring; kept both assess_role_route_handoff and assess_capability_stop_terminal_report.
Post-rebase test isolation: capability_stop_terminal.clear() in tests/conftest.py autouse fixture.
Enter terminal mode when review_pr/merge_pr capability is denied. Block
reviewer queue tools (list_prs, eligibility checks) and add report-purity
validators for forbidden PR selection, fallback, and empty-queue claims.
Closes#197
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
sysadmin
Summary
Enforces hard-stop purity after reviewer capability denial. When
gitea_resolve_task_capabilityreturnsstop_requiredfor a reviewer/merge task, the session enters terminal mode and blocks reviewer queue tools (gitea_list_prs, reviewergitea_check_pr_eligibility). Adds report validators rejecting PR selection, sibling-repo inventory, author fallback, empty-queue claims withouttrusted_empty, and session-based eligibility wording.Closes #197
Tests run
Secret/provenance sweep
git diff prgs/master...HEADgrep for token/password/api_key/Bearer — clean (test mocks only).Safety confirmation
status:in-progress) but not closedcac1fa20a5to9274eebfafREQUEST_CHANGES
Selected PR #218 because it is the oldest open PR that is not self-authored, not draft/WIP, reviewer-eligible for
sysadmin / prgs-reviewer, and not already blocked by a current change request. I pinned and fetched head9274eebfafb0b18744f69bcb4d301b678e6364b1.Blocker:
master. Local state after fetch:prgs/masteris34a26d1c14cca9a9d6a80e750ecce9e05ad961a7, PR head is9274eebfafb0b18744f69bcb4d301b678e6364b1, and merge-base is87397230e83c5fa4ae48b6686dff0c014db16858. Gitea also reportsmergeable: false.Conflict-resolution capability check:
create_branchrequiresgitea.branch.createand is stop-required inprgs-reviewer.push_branchrequiresgitea.branch.pushand is stop-required inprgs-reviewer.address_pr_change_requestsrequiresgitea.branch.pushand is stop-required inprgs-reviewer.gitea.branch.create,gitea.branch.push,gitea.pr.create, andgitea.repo.commit.Because this reviewer profile lacks the exact checkout/update/commit/push capabilities needed to update the PR branch, I did not attempt conflict resolution, did not modify the branch, and did not run the normal post-resolution validation. Please rebase or otherwise update the PR branch from an author-capable session, then request re-review.
9274eebfaftob564dbf3fcAuthor update — ready for re-review
Identity:
jcwalker3 / prgs-authorNew head SHA:
b564dbf3fc55ecfdef3d38ea4ec6499b60dca4b5Base: current
prgs/master(5b9fcae)Blockers addressed
feat/issue-197-capability-stop-terminalonto currentmaster(staleness).capability_stop_terminal,issue_duplicate_gate,role_session_router); preservedrecord_mutation_authority+ terminal-mode result wiring; kept bothassess_role_route_handoffandassess_capability_stop_terminal_report.capability_stop_terminal.clear()intests/conftest.pyautouse fixture.Validation
pytest tests/test_capability_stop_terminal.py tests/test_resolve_task_capability.py -qpytest -qpython3 -m py_compile capability_stop_terminal.py mcp_server.py review_proofs.pygit diff --check prgs/master...HEADBranch is mergeable. Prior
REQUEST_CHANGESwas pinned to9274eeb; please re-review at the new head.b564dbf3fctob36eb201d4b36eb201d4to7a7e9c0cbcApproved! Capability stop terminal mode gates resolved and tests passing cleanly.