Add repo-name disambiguation and complete-inventory proofs for blind PR review #185

2026-07-05T14:30:17-05:00

jcwalker3 commented

2026-07-05 14:30:17 -05:00

This PR implements Gitea-Tools Issue #184 by adding repository-name disambiguation and hardening complete-inventory proofs in blind PR queue reviews.

Changes

review_proofs.py:
- Added REPO_ALIASES mapping Gitea-Tools and mcp-control-plane references to their full repository names.
- Added resolve_repos_from_user_reference(reference, configured) to resolve repository names from user inputs/prompts. Ambiguous or general queue queries default to checking both configured repositories.
tests/test_review_proofs.py:
- Added TestRepoNameDisambiguation to verify alias matching, ambiguous query defaults, and that a single-repo check failure prevents the exhaustive queue check claim.
skills/llm-project-workflow/templates/review-pr.md:
- Documented repository name disambiguation instructions.
skills/llm-project-workflow/SKILL.md:
- Updated the review workflow inventory proof rules to incorporate the name disambiguation helpers.

Validation

python3 -m py_compile review_proofs.py tests/test_review_proofs.py -> Passed (OK)
./venv/bin/python -m pytest tests/test_review_proofs.py -q --tb=no -> Passed (42 passed)
./venv/bin/python -m pytest tests/test_review_proofs.py tests/test_pr_queue_inventory.py -q --tb=no -> Passed (58 passed)
git diff --check -> Passed (clean)

Secret/Provenance Sweep

Command/Method: git diff | grep -iE 'token|secret|password|key|credential|http' || true
Result: Clean; no credentials or endpoint URLs found.

Confirmation

No review, merge, or manual issue closure was performed under this author profile.

Closes #184

This PR implements Gitea-Tools Issue #184 by adding repository-name disambiguation and hardening complete-inventory proofs in blind PR queue reviews. ### Changes 1. **`review_proofs.py`**: - Added `REPO_ALIASES` mapping Gitea-Tools and mcp-control-plane references to their full repository names. - Added `resolve_repos_from_user_reference(reference, configured)` to resolve repository names from user inputs/prompts. Ambiguous or general queue queries default to checking both configured repositories. 2. **`tests/test_review_proofs.py`**: - Added `TestRepoNameDisambiguation` to verify alias matching, ambiguous query defaults, and that a single-repo check failure prevents the exhaustive queue check claim. 3. **`skills/llm-project-workflow/templates/review-pr.md`**: - Documented repository name disambiguation instructions. 4. **`skills/llm-project-workflow/SKILL.md`**: - Updated the review workflow inventory proof rules to incorporate the name disambiguation helpers. ### Validation - `python3 -m py_compile review_proofs.py tests/test_review_proofs.py` -> **Passed** (OK) - `./venv/bin/python -m pytest tests/test_review_proofs.py -q --tb=no` -> **Passed** (42 passed) - `./venv/bin/python -m pytest tests/test_review_proofs.py tests/test_pr_queue_inventory.py -q --tb=no` -> **Passed** (58 passed) - `git diff --check` -> **Passed** (clean) ### Secret/Provenance Sweep - **Command/Method**: `git diff | grep -iE 'token|secret|password|key|credential|http' || true` - **Result**: Clean; no credentials or endpoint URLs found. ### Confirmation No review, merge, or manual issue closure was performed under this author profile. Closes #184

jcwalker3 added 1 commit 2026-07-05 14:30:17 -05:00

feat(review-workflow): add repo-name disambiguation and complete-inventory proofs (#184 ) e2bccbafee

sysadmin reviewed 2026-07-05 14:32:28 -05:00

sysadmin left a comment

I have checked out head SHA e2bccbafee, verified it matches local HEAD, and reviewed the diff against master. The changes correctly add repository aliases and the resolve_repos_from_user_reference function to review_proofs.py, add appropriate tests, and update template/guideline documentation. All 682 unit tests passed successfully.

I have checked out head SHA e2bccbafeeb93124ba068bfb06058d5aa7467cae, verified it matches local HEAD, and reviewed the diff against master. The changes correctly add repository aliases and the resolve_repos_from_user_reference function to review_proofs.py, add appropriate tests, and update template/guideline documentation. All 682 unit tests passed successfully.

sysadmin merged commit 601c608c58 into master

2026-07-05 14:32:34 -05:00

sysadmin referenced this pull request

2026-07-05 14:34:42 -05:00

Disambiguate target repo names and require Gitea-Tools inventory when user references the MCP Gitea tool #184

jcwalker3 referenced this pull request

2026-07-05 14:38:22 -05:00

Require controller handoff summaries in all LLM workflow final reports #182

jcwalker3 referenced this pull request

2026-07-05 15:13:46 -05:00

Add hard queue-target resolution wall before PR inventory or empty-queue claims #202

jcwalker3 referenced this pull request