fix: close implements tracker gap and clarify closing keywords (#110) #116

2026-07-02T18:34:52-05:00

jcwalker3 commented

2026-07-02 18:34:52 -05:00

Recognize implement, implements, and implemented keywords to release status:in-progress during PR cleanup. Remove refs/ref keywords to avoid over-releasing claims on merely referenced issues. Update runbooks and templates to clarify Gitea issue-closing behavior. Closes #110.

jcwalker3 added 1 commit 2026-07-02 18:46:24 -05:00

fix: close implements tracker gap and clarify closing keywords (#110 ) 472e6850fe

jcwalker3 force-pushed fix/issue-110-implements-tracker-gap from 0bbbca4223 to 472e6850fe

2026-07-02 18:46:24 -05:00

Compare

sysadmin reviewed 2026-07-02 18:50:48 -05:00

sysadmin left a comment

Approve. Reviewed pinned head 472e685 from a detached review worktree.

Scope matches #110 exactly: extract_linked_issue_numbers regex now recognizes implement/implements/implemented #N for status:in-progress release AND drops refs?/ref so merely-referenced issues are no longer over-released — both directions of the tracker gap. Regex alternation verified correct for the "implemented" suffix case. Docs/templates clarify that Gitea only auto-closes on true closing keywords. New test covers positives, the refs-must-NOT-match negatives, and the branch-name fallback.

Validation at 472e685: py_compile ×4 OK · bash -n scripts/clear-provenance OK · pytest tests/ -q 358 passed, 6 skipped (357 base + new hygiene test) · git diff --check clean · secret sweep clean. Mergeable per Gitea (earlier conflict resolved after #114/#115 landed).

Merging next via the gated tool with pinned head + expected file set.

Review Metadata:

LLM-Agent-SHA: llm-a38fff25edeb
LLM-Role: reviewer
Authenticated-Gitea-User: sysadmin
MCP-Profile: prgs-reviewer
Eligibility: passed (PR author jcwalker3 ≠ sysadmin)

Approve. Reviewed pinned head `472e685` from a detached review worktree. Scope matches #110 exactly: `extract_linked_issue_numbers` regex now recognizes `implement/implements/implemented #N` for `status:in-progress` release AND drops `refs?/ref` so merely-referenced issues are no longer over-released — both directions of the tracker gap. Regex alternation verified correct for the "implemented" suffix case. Docs/templates clarify that Gitea only auto-closes on true closing keywords. New test covers positives, the refs-must-NOT-match negatives, and the branch-name fallback. Validation at `472e685`: `py_compile` ×4 OK · `bash -n scripts/clear-provenance` OK · `pytest tests/ -q` **358 passed, 6 skipped** (357 base + new hygiene test) · `git diff --check` clean · secret sweep clean. Mergeable per Gitea (earlier conflict resolved after #114/#115 landed). Merging next via the gated tool with pinned head + expected file set. Review Metadata: - LLM-Agent-SHA: llm-a38fff25edeb - LLM-Role: reviewer - Authenticated-Gitea-User: sysadmin - MCP-Profile: prgs-reviewer - Eligibility: passed (PR author jcwalker3 ≠ sysadmin)

sysadmin merged commit 8d2eb23237 into master

2026-07-02 18:51:06 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#116