## Description
Adds the Architecture Decision Record (ADR) for High-Availability and Rolling-Restart MCP architecture in `docs/architecture/mcp-ha-rolling-restart.md`.
Closes #668.
STATE: approved
WHO_IS_NEXT: author
NEXT_ACTION: Update PR branch to current master via gitea_update_pr_branch_by_merge (or merge master and push), then hand off to merger only if head unchanged; if head moves, route fresh review.
NEXT_PROMPT:
Act as author on prgs/Scaled-Tech-Consulting/Gitea-Tools PR #912. Pin expected_pr_head_sha=6010f4295b1fc01eb87906e09c7a6dd434723328. Run gitea_update_pr_branch_by_merge against live master base (or merge prgs/master in the docs branch worktree and push). No force-push. Report new head SHA.
WHAT_HAPPENED: Independent reviewer review of PR #912 at head 6010f42. Single-file docs ADR; scope matches Closes#668; no prior reviews; author jcwalker3 vs reviewer sysadmin; head not already on master.
WHY: ADR is coherent design-only content (status Proposed), aligned with #655/#613/#656/#659, clear non-goals and phased milestones, fail-closed split-brain mitigations. No code mutations; no secrets; no conflict markers.
ISSUE: 668
HEAD_SHA: 6010f4295b
REVIEW_STATUS: APPROVED
MERGE_READY: pending-base-sync
BLOCKERS: none for review; merge path needs author base sync because PR is behind live master
VALIDATION: docs-only PR — reviewed full ADR at branches/review-pr912-docs-668 @ 6010f4295b1fc01eb87906e09c7a6dd434723328; worktree clean; mergeable=true; not ancestor of prgs/master 7bb5ff4719
LAST_UPDATED_BY: sysadmin (prgs-reviewer)
NATIVE_REVIEW_PROOF: gitea_submit_pr_review via gitea-reviewer, profile prgs-reviewer, identity sysadmin, expected_head_sha 6010f4295b.
Scope: +167 lines, one file docs/architecture/mcp-ha-rolling-restart.md.
Verdict: APPROVE
Problem statement and principles match existing control-plane ADRs (Gitea SoT, CP-DB substrate, fail-closed).
Architecture diagram and components (resume tokens, lease fencing, drain, idempotency keys) are consistent with #655 / #659 / #613.
Non-goals correctly keep this design-only for post-#655 phases.
Split-brain table and milestones are actionable without overclaiming v1 delivery.
Nits (non-blocking): minor grammar ("a updated" → "an updated"); SQLite HA dependency correctly called out as accepted risk.
Merge note: PR is behind live master; author must update branch before merge; if head moves, re-review.
## Canonical PR State
STATE: approved
WHO_IS_NEXT: author
NEXT_ACTION: Update PR branch to current master via gitea_update_pr_branch_by_merge (or merge master and push), then hand off to merger only if head unchanged; if head moves, route fresh review.
NEXT_PROMPT:
```text
Act as author on prgs/Scaled-Tech-Consulting/Gitea-Tools PR #912. Pin expected_pr_head_sha=6010f4295b1fc01eb87906e09c7a6dd434723328. Run gitea_update_pr_branch_by_merge against live master base (or merge prgs/master in the docs branch worktree and push). No force-push. Report new head SHA.
```
WHAT_HAPPENED: Independent reviewer review of PR #912 at head 6010f42. Single-file docs ADR; scope matches Closes #668; no prior reviews; author jcwalker3 vs reviewer sysadmin; head not already on master.
WHY: ADR is coherent design-only content (status Proposed), aligned with #655/#613/#656/#659, clear non-goals and phased milestones, fail-closed split-brain mitigations. No code mutations; no secrets; no conflict markers.
ISSUE: 668
HEAD_SHA: 6010f4295b1fc01eb87906e09c7a6dd434723328
REVIEW_STATUS: APPROVED
MERGE_READY: pending-base-sync
BLOCKERS: none for review; merge path needs author base sync because PR is behind live master
VALIDATION: docs-only PR — reviewed full ADR at branches/review-pr912-docs-668 @ 6010f4295b1fc01eb87906e09c7a6dd434723328; worktree clean; mergeable=true; not ancestor of prgs/master 7bb5ff4719902276b37045df489dac3da327e494
LAST_UPDATED_BY: sysadmin (prgs-reviewer)
NATIVE_REVIEW_PROOF: gitea_submit_pr_review via gitea-reviewer, profile prgs-reviewer, identity sysadmin, expected_head_sha 6010f4295b1fc01eb87906e09c7a6dd434723328.
---
# Review — PR #912 (#668), head 6010f42
**Scope:** +167 lines, one file `docs/architecture/mcp-ha-rolling-restart.md`.
**Verdict: APPROVE**
- Problem statement and principles match existing control-plane ADRs (Gitea SoT, CP-DB substrate, fail-closed).
- Architecture diagram and components (resume tokens, lease fencing, drain, idempotency keys) are consistent with #655 / #659 / #613.
- Non-goals correctly keep this design-only for post-#655 phases.
- Split-brain table and milestones are actionable without overclaiming v1 delivery.
**Nits (non-blocking):** minor grammar ("a updated" → "an updated"); SQLite HA dependency correctly called out as accepted risk.
**Merge note:** PR is behind live master; author must update branch before merge; if head moves, re-review.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
sysadmin
Description
Adds the Architecture Decision Record (ADR) for High-Availability and Rolling-Restart MCP architecture in
docs/architecture/mcp-ha-rolling-restart.md.Closes #668.
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #912
issue: #668
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: prgs-reviewer-32049-a3c921e8
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr912-docs-668
phase: claimed
candidate_head:
6010f4295btarget_branch: master
target_branch_sha:
7bb5ff4719last_activity: 2026-07-25T22:07:55Z
expires_at: 2026-07-25T22:17:55Z
blocker: none
Canonical PR State
STATE: approved
WHO_IS_NEXT: author
NEXT_ACTION: Update PR branch to current master via gitea_update_pr_branch_by_merge (or merge master and push), then hand off to merger only if head unchanged; if head moves, route fresh review.
NEXT_PROMPT:
WHAT_HAPPENED: Independent reviewer review of PR #912 at head
6010f42. Single-file docs ADR; scope matches Closes #668; no prior reviews; author jcwalker3 vs reviewer sysadmin; head not already on master.WHY: ADR is coherent design-only content (status Proposed), aligned with #655/#613/#656/#659, clear non-goals and phased milestones, fail-closed split-brain mitigations. No code mutations; no secrets; no conflict markers.
ISSUE: 668
HEAD_SHA:
6010f4295bREVIEW_STATUS: APPROVED
MERGE_READY: pending-base-sync
BLOCKERS: none for review; merge path needs author base sync because PR is behind live master
VALIDATION: docs-only PR — reviewed full ADR at branches/review-pr912-docs-668 @ 6010f4295b1fc01eb87906e09c7a6dd434723328; worktree clean; mergeable=true; not ancestor of prgs/master
7bb5ff4719LAST_UPDATED_BY: sysadmin (prgs-reviewer)
NATIVE_REVIEW_PROOF: gitea_submit_pr_review via gitea-reviewer, profile prgs-reviewer, identity sysadmin, expected_head_sha
6010f4295b.Review — PR #912 (#668), head
6010f42Scope: +167 lines, one file
docs/architecture/mcp-ha-rolling-restart.md.Verdict: APPROVE
Nits (non-blocking): minor grammar ("a updated" → "an updated"); SQLite HA dependency correctly called out as accepted risk.
Merge note: PR is behind live master; author must update branch before merge; if head moves, re-review.
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #912
issue: none
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 6699-dcab2c971df2
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/docs-issue-668-mcp-ha-rolling-restart
phase: claimed
candidate_head:
6010f4295btarget_branch: master
target_branch_sha: none
last_activity: 2026-07-25T22:26:40Z
expires_at: 2026-07-25T22:36:40Z
blocker: none
adopted_at: 2026-07-25T22:34:24Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 6699-dcab2c971df2
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 16940
adoption_reason: merger-handoff-approved-head
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #912
issue: none
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 6365-954dfea4eb43
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/docs-issue-668-mcp-ha-rolling-restart
phase: adopted
candidate_head:
6010f4295btarget_branch: master
target_branch_sha: none
last_activity: 2026-07-25T22:34:24Z
expires_at: 2026-07-25T22:44:24Z
blocker: none