Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 83 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

feat(mcp): post-restart reconciliation and completion proof (Closes #662) #879

Merged
sysadmin merged 2 commits from fix/issue-662-post-restart-reconcile into master 2026-07-24 09:04:23 -05:00
Conversation 8 Commits 2 Files Changed 5
+1360
jcwalker3 commented 2026-07-24 07:44:43 -05:00
Owner
Copy Link
Copy Source

Closes #662

Parent umbrella #655 · Vision #652 · Roadmap #653 · Soft deps #660 #661

Summary

Post-restart MCP reconciliation so operators do not rebuild context from chat after a daemon restart.

What this adds

  • post_restart_reconcile.py — pure reconcile_after_restart(inventory) classifier returning a machine-readable completion proof across service health, clients, sessions, checkpoints (soft #660), leases, capabilities/parity, worktrees, interrupted mutations (never auto-resumed), duplicates, and queue state.
  • gitea_reconcile_after_restart — read-only MCP tool that gathers control-plane inventory + master parity and returns the proof; proposes durable follow-up issues but does not create them in v1.
  • Boot hook — first gitea_assess_master_parity after process start runs reconcile once (log-only by default).
  • Modes — log_only (default) vs enforce (GITEA_POST_RESTART_RECONCILE_MODE=enforce or mode=enforce) sets mutation_hold when anything remains unresolved.
  • Docs — docs/post-restart-reconcile.md.
  • Tests — tests/test_issue_662_post_restart_reconcile.py (11 cases including interrupted-mutation detection).

Acceptance criteria

AC Status
1. Boot reconcile runs automatically after restart Boot-once via gitea_assess_master_parity + explicit tool
2. Completion proof lists resolved/unresolved items RestartCompletionProof.as_dict()
3. Unresolved items become durable issues proposed_follow_ups in proof (create path deferred; log-only rollout)
4. Tests for interrupted mutation detection Lease mutating phase + pending_mutation fixtures
5. Links #652 #653 #655 Proof links field + PR body

Non-goals honored

  • No HA multi-instance failover
  • No automatic silent mutation replay
  • Does not implement #660 checkpoint schema (soft-skip when absent)

Validation

pytest tests/test_issue_662_post_restart_reconcile.py -q
# 11 passed

Provenance

  • Issue: Implement post-restart MCP reconciliation (#662)
  • Branch: fix/issue-662-post-restart-reconcile
  • Worktree: branches/fix-issue-662-post-restart-reconcile
  • Head: a7a283f4490f532359edcb567299407ed7c331c2
  • Base master: 103d0df28921d95673d4f375b00f01d306c70c70
  • Allocation: asn-28d0e16447ab477c / lease-dcf03d50e1d94af7

Canonical PR State

STATE: awaiting-review
WHO_IS_NEXT: reviewer
BLOCKED_ROLE: none
NEXT_ACTION: Review PR against #662 ACs 1-5; confirm pure assessor, no blind write resume, soft #660 skip, boot hook + tool; submit verdict; stop
NEXT_PROMPT: As prgs-reviewer on this PR at head a7a283f: verify post_restart_reconcile purity, interrupted-mutation fail-closed (resume_allowed=false), mutation_hold only in enforce mode, boot-once hook does not raise, tests cover incomplete inventory + dead-pid sessions + duplicates; submit APPROVE or REQUEST_CHANGES; stop

Co-Authored-By: Claude Opus 4.8 (1M context) [email protected]

Closes #662 Parent umbrella #655 · Vision #652 · Roadmap #653 · Soft deps #660 #661 ## Summary Post-restart MCP reconciliation so operators do not rebuild context from chat after a daemon restart. ### What this adds - **`post_restart_reconcile.py`** — pure `reconcile_after_restart(inventory)` classifier returning a machine-readable **completion proof** across service health, clients, sessions, checkpoints (soft #660), leases, capabilities/parity, worktrees, interrupted mutations (never auto-resumed), duplicates, and queue state. - **`gitea_reconcile_after_restart`** — read-only MCP tool that gathers control-plane inventory + master parity and returns the proof; proposes durable follow-up issues but does not create them in v1. - **Boot hook** — first `gitea_assess_master_parity` after process start runs reconcile once (log-only by default). - **Modes** — `log_only` (default) vs `enforce` (`GITEA_POST_RESTART_RECONCILE_MODE=enforce` or `mode=enforce`) sets `mutation_hold` when anything remains unresolved. - **Docs** — `docs/post-restart-reconcile.md`. - **Tests** — `tests/test_issue_662_post_restart_reconcile.py` (11 cases including interrupted-mutation detection). ### Acceptance criteria | AC | Status | |----|--------| | 1. Boot reconcile runs automatically after restart | Boot-once via `gitea_assess_master_parity` + explicit tool | | 2. Completion proof lists resolved/unresolved items | `RestartCompletionProof.as_dict()` | | 3. Unresolved items become durable issues | `proposed_follow_ups` in proof (create path deferred; log-only rollout) | | 4. Tests for interrupted mutation detection | Lease mutating phase + pending_mutation fixtures | | 5. Links #652 #653 #655 | Proof `links` field + PR body | ### Non-goals honored - No HA multi-instance failover - No automatic silent mutation replay - Does not implement #660 checkpoint schema (soft-skip when absent) ### Validation ``` pytest tests/test_issue_662_post_restart_reconcile.py -q # 11 passed ``` ### Provenance - Issue: #662 - Branch: `fix/issue-662-post-restart-reconcile` - Worktree: `branches/fix-issue-662-post-restart-reconcile` - Head: `a7a283f4490f532359edcb567299407ed7c331c2` - Base master: `103d0df28921d95673d4f375b00f01d306c70c70` - Allocation: `asn-28d0e16447ab477c` / `lease-dcf03d50e1d94af7` ## Canonical PR State ```text STATE: awaiting-review WHO_IS_NEXT: reviewer BLOCKED_ROLE: none NEXT_ACTION: Review PR against #662 ACs 1-5; confirm pure assessor, no blind write resume, soft #660 skip, boot hook + tool; submit verdict; stop NEXT_PROMPT: As prgs-reviewer on this PR at head a7a283f: verify post_restart_reconcile purity, interrupted-mutation fail-closed (resume_allowed=false), mutation_hold only in enforce mode, boot-once hook does not raise, tests cover incomplete inventory + dead-pid sessions + duplicates; submit APPROVE or REQUEST_CHANGES; stop ``` Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
jcwalker3 added 1 commit 2026-07-24 07:44:43 -05:00
feat(mcp): post-restart reconciliation and completion proof (Closes #662) a7a283f449 
Add pure post_restart_reconcile.reconcile_after_restart classifier with a
machine-readable completion proof covering service health, sessions, leases,
capabilities, worktrees, interrupted mutations (never auto-resumed),
duplicates, and queue state. Soft-depends on #660 checkpoints (skipped with
reason when the schema module is absent).

Wire read-only MCP tool gitea_reconcile_after_restart, boot-once hook via
gitea_assess_master_parity, log_only/enforce modes (mutation_hold), and docs.

Closes #662
Related: #655 #652 #653 #660 #661

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
sysadmin commented 2026-07-24 08:59:32 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #879
issue: #662
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 45214-2c49ef91ca41
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr879-20260724
phase: claimed
candidate_head: a7a283f449
target_branch: master
target_branch_sha: 2976c21ee6
last_activity: 2026-07-24T13:59:31Z
expires_at: 2026-07-24T14:09:31Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #879 issue: #662 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 45214-2c49ef91ca41 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr879-20260724 phase: claimed candidate_head: a7a283f4490f532359edcb567299407ed7c331c2 target_branch: master target_branch_sha: 2976c21ee6ce1feedb7101ccdf4c5c48e2c3bd18 last_activity: 2026-07-24T13:59:31Z expires_at: 2026-07-24T14:09:31Z blocker: none
sysadmin approved these changes 2026-07-24 09:00:03 -05:00
Dismissed
sysadmin left a comment
Owner
Copy Link
Copy Source

Canonical PR State

STATE: approved
WHO_IS_NEXT: merger
NEXT_ACTION: Base-sync PR #879 (32 commits behind live master) then merge into master after approval_at_current_head
NEXT_PROMPT:

As prgs-merger on PR #879: re-assess sync at live head; if still behind, author/merger update_branch_by_merge then re-verify approval_at_current_head; merge only with operator consent; stop.

WHAT_HAPPENED: Reviewer re-verified #662 post-restart reconcile at head a7a283f449 on mutation-safe daemon @2976c21e; pytest tests/test_issue_662_post_restart_reconcile.py 11 passed; formal APPROVE review verdict posted via review API
WHY: Pure fail-closed classifier satisfies ACs 1-5; interrupted mutations always resume_allowed=false; mutation_hold only in enforce mode; additive read-only surface
ISSUE: #662
HEAD_SHA: a7a283f449
REVIEW_STATUS: approve review API verdict at pinned head a7a283f449
MERGE_READY: true
BLOCKERS: none for review; PR is 32 commits behind live base so merge path needs update_branch_by_merge first
VALIDATION: pytest tests/test_issue_662_post_restart_reconcile.py exit 0 (11 passed); Live head SHA before approval: a7a283f4490f532359edcb567299407ed7c331c2; Pushes occurred during validation: no; Workflow-load helper result: workflow_hash: 263d0a6cb8a6 boundary_status: clean
NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=mcp_server; namespace=gitea-reviewer; profile=prgs-reviewer; identity=sysadmin; workflow=review-merge-pr; workflow_hash=263d0a6cb8a6; head=a7a283f4490f532359edcb567299407ed7c331c2
LAST_UPDATED_BY: sysadmin / prgs-reviewer / reviewer

[THREAD STATE LEDGER]

what is true now

Server-side decision state: open PR #879 at head a7a283f449 carries formal approve review API verdict for #662 post-restart reconcile
Local verdict/state: approve at pinned head after 11-test suite green and pure-classifier spot-check
Next actor: merger
Required action: base-sync then merge PR #879 with operator consent when approval_at_current_head holds
Blocker classification: no blocker
Do not do: do not auto-resume write mutations; do not re-review this same head for a second formal approve; do not merge without operator consent

what changed

  • Re-confirmed post_restart_reconcile.py is pure classifier with resume_allowed=false for interrupted mutations and mutation_hold only under enforce mode
  • Confirmed boot hook and gitea_reconcile_after_restart wiring in gitea_mcp_server.py
  • Recorded formal approve review API verdict at head a7a283f449

what is blocked

Nothing for review. Merge eligibility still requires catching up 32 base commits via update_branch_by_merge; that may move head and require fresh approval_at_current_head before merge.

who/what acts next

Merger: assess PR sync, perform or request base-sync, then merge only with explicit operator consent.

APPROVE — #662 post-restart reconciliation.

post_restart_reconcile.py is a pure, exception-safe classifier: no network/filesystem/process mutation on the pure path; fail-closed on incomplete inventory (overall=failed, never claims complete); interrupted mutations always resume_allowed=false (AC4, no blind write resume); #660 checkpoints soft-skip with explicit depends_on=660 when schema absent; mutation_hold set only in enforce mode; dedup + dead-pid orphan-session detection present; mutations_allowed() honors the hold.

tests/test_issue_662_post_restart_reconcile.py: 11 cases covering incomplete/fail-closed, clean happy-path (checkpoint skipped, links 655/652/653/662), interrupted mutation (dead owner + explicit pending inventory), log_only-vs-enforce hold distinction, duplicate live claims, orphan dead-pid session, stale runtime, mutations_allowed helper, #660 soft-dep both branches, and JSON serializability.

Additive (new module + read-only tool + boot-once log-only hook); honestly scoped to ACs 1-5 with non-goals (no HA failover, no silent replay, no #660 schema) respected.

## Canonical PR State STATE: approved WHO_IS_NEXT: merger NEXT_ACTION: Base-sync PR #879 (32 commits behind live master) then merge into master after approval_at_current_head NEXT_PROMPT: ```text As prgs-merger on PR #879: re-assess sync at live head; if still behind, author/merger update_branch_by_merge then re-verify approval_at_current_head; merge only with operator consent; stop. ``` WHAT_HAPPENED: Reviewer re-verified #662 post-restart reconcile at head a7a283f4490f532359edcb567299407ed7c331c2 on mutation-safe daemon @2976c21e; pytest tests/test_issue_662_post_restart_reconcile.py 11 passed; formal APPROVE review verdict posted via review API WHY: Pure fail-closed classifier satisfies ACs 1-5; interrupted mutations always resume_allowed=false; mutation_hold only in enforce mode; additive read-only surface ISSUE: #662 HEAD_SHA: a7a283f4490f532359edcb567299407ed7c331c2 REVIEW_STATUS: approve review API verdict at pinned head a7a283f4490f532359edcb567299407ed7c331c2 MERGE_READY: true BLOCKERS: none for review; PR is 32 commits behind live base so merge path needs update_branch_by_merge first VALIDATION: pytest tests/test_issue_662_post_restart_reconcile.py exit 0 (11 passed); Live head SHA before approval: a7a283f4490f532359edcb567299407ed7c331c2; Pushes occurred during validation: no; Workflow-load helper result: workflow_hash: 263d0a6cb8a6 boundary_status: clean NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=mcp_server; namespace=gitea-reviewer; profile=prgs-reviewer; identity=sysadmin; workflow=review-merge-pr; workflow_hash=263d0a6cb8a6; head=a7a283f4490f532359edcb567299407ed7c331c2 LAST_UPDATED_BY: sysadmin / prgs-reviewer / reviewer [THREAD STATE LEDGER] ### what is true now Server-side decision state: open PR #879 at head a7a283f4490f532359edcb567299407ed7c331c2 carries formal approve review API verdict for #662 post-restart reconcile Local verdict/state: approve at pinned head after 11-test suite green and pure-classifier spot-check Next actor: merger Required action: base-sync then merge PR #879 with operator consent when approval_at_current_head holds Blocker classification: no blocker Do not do: do not auto-resume write mutations; do not re-review this same head for a second formal approve; do not merge without operator consent ### what changed - Re-confirmed post_restart_reconcile.py is pure classifier with resume_allowed=false for interrupted mutations and mutation_hold only under enforce mode - Confirmed boot hook and gitea_reconcile_after_restart wiring in gitea_mcp_server.py - Recorded formal approve review API verdict at head a7a283f4490f532359edcb567299407ed7c331c2 ### what is blocked Nothing for review. Merge eligibility still requires catching up 32 base commits via update_branch_by_merge; that may move head and require fresh approval_at_current_head before merge. ### who/what acts next Merger: assess PR sync, perform or request base-sync, then merge only with explicit operator consent. APPROVE — #662 post-restart reconciliation. post_restart_reconcile.py is a pure, exception-safe classifier: no network/filesystem/process mutation on the pure path; fail-closed on incomplete inventory (overall=failed, never claims complete); interrupted mutations always resume_allowed=false (AC4, no blind write resume); #660 checkpoints soft-skip with explicit depends_on=660 when schema absent; mutation_hold set only in enforce mode; dedup + dead-pid orphan-session detection present; mutations_allowed() honors the hold. tests/test_issue_662_post_restart_reconcile.py: 11 cases covering incomplete/fail-closed, clean happy-path (checkpoint skipped, links 655/652/653/662), interrupted mutation (dead owner + explicit pending inventory), log_only-vs-enforce hold distinction, duplicate live claims, orphan dead-pid session, stale runtime, mutations_allowed helper, #660 soft-dep both branches, and JSON serializability. Additive (new module + read-only tool + boot-once log-only hook); honestly scoped to ACs 1-5 with non-goals (no HA failover, no silent replay, no #660 schema) respected.
jcwalker3 added 1 commit 2026-07-24 09:01:52 -05:00
Merge branch 'master' into fix/issue-662-post-restart-reconcile 1232789b41
sysadmin commented 2026-07-24 09:02:53 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #879
issue: #662
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 45214-2c49ef91ca41
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr879-20260724
phase: released
candidate_head: a7a283f449
target_branch: master
target_branch_sha: 2976c21ee6
last_activity: 2026-07-24T14:02:53Z
expires_at: 2026-07-24T14:12:53Z
blocker: obsolete-superseded-or-expired-lease

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #879 issue: #662 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 45214-2c49ef91ca41 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr879-20260724 phase: released candidate_head: a7a283f4490f532359edcb567299407ed7c331c2 target_branch: master target_branch_sha: 2976c21ee6ce1feedb7101ccdf4c5c48e2c3bd18 last_activity: 2026-07-24T14:02:53Z expires_at: 2026-07-24T14:12:53Z blocker: obsolete-superseded-or-expired-lease
sysadmin commented 2026-07-24 09:02:53 -05:00
Owner
Copy Link
Copy Source

Canonical obsolete reviewer lease cleanup (#691)

  • pr: feat(mcp): post-restart reconciliation and completion proof (Closes #662) (#879)
  • lease_comment_id: 15984
  • session_id: 45214-2c49ef91ca41
  • leased_head: a7a283f449
  • current_head: 1232789b41
  • expires_at: 2026-07-24T14:09:31Z
  • classification: foreign_completed_superseded_head
  • terminal_review_verdict: APPROVED
  • tool: gitea_cleanup_obsolete_reviewer_comment_lease
  • action: posted terminal phase=released lease marker; did not transfer validation, decision, or workflow proof; did not repoint lease to the new head; did not delete history
## Canonical obsolete reviewer lease cleanup (#691) - pr: #879 - lease_comment_id: 15984 - session_id: 45214-2c49ef91ca41 - leased_head: a7a283f4490f532359edcb567299407ed7c331c2 - current_head: 1232789b41527c562b7a2a98da5f8536d65828f2 - expires_at: 2026-07-24T14:09:31Z - classification: foreign_completed_superseded_head - terminal_review_verdict: APPROVED - tool: gitea_cleanup_obsolete_reviewer_comment_lease - action: posted terminal phase=released lease marker; did not transfer validation, decision, or workflow proof; did not repoint lease to the new head; did not delete history
sysadmin commented 2026-07-24 09:03:05 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #879
issue: none
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 46658-2fecd517f798
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr879-20260724
phase: claimed
candidate_head: none
target_branch: master
target_branch_sha: none
last_activity: 2026-07-24T14:03:04Z
expires_at: 2026-07-24T14:13:04Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #879 issue: none reviewer_identity: sysadmin profile: prgs-reviewer session_id: 46658-2fecd517f798 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr879-20260724 phase: claimed candidate_head: none target_branch: master target_branch_sha: none last_activity: 2026-07-24T14:03:04Z expires_at: 2026-07-24T14:13:04Z blocker: none
sysadmin approved these changes 2026-07-24 09:03:43 -05:00
sysadmin left a comment
Owner
Copy Link
Copy Source

Review Report for PR #879

PR #879 (Issue #662) implements post-restart reconciliation and completion proof.

Evaluation against Acceptance Criteria:

  1. Boot reconcile runs automatically after restart: Implemented via _ensure_boot_post_restart_reconcile() hook inside gitea_assess_master_parity.
  2. Completion proof lists resolved/unresolved items: Implemented via RestartCompletionProof.as_dict() with structured dimensions (service_health, sessions, leases, checkpoints, worktrees, mutations, duplicates, queue).
  3. Unresolved items become durable issues: Structured as proposed_follow_ups in the proof payload (log-only apply path deferred as intended).
  4. Tests for interrupted mutation detection: Comprehensive test suite in tests/test_issue_662_post_restart_reconcile.py (covering interrupted mutations, incomplete inventory, orphan sessions, duplicate claims, stale capabilities, and fail-closed enforce mode).
  5. Links #652 #653 #655: Included in proof links dictionary and documentation/commit body.

Design and Code Quality:

  • Clean separation between inventory gathering (_gather_post_restart_inventory) and pure classification (reconcile_after_restart).
  • Fail-soft soft-dependency handling for #660 checkpoint schema module.
  • Read-only safety preserved; no write mutation replay.
  • Proper capability map entries added in task_capability_map.py.

Approving PR #879 for merge into master.

Controller Handoff

  • Task: review_pr
  • Repo: Scaled-Tech-Consulting/Gitea-Tools
  • Role: reviewer
  • Identity: sysadmin
  • Issue/PR: Issue #662 / PR feat(mcp): post-restart reconciliation and completion proof (Closes #662) (#879)
  • Branch/SHA: fix/issue-662-post-restart-reconcile / 1232789b41
  • Files changed: docs/post-restart-reconcile.md, gitea_mcp_server.py, post_restart_reconcile.py, task_capability_map.py, tests/test_issue_662_post_restart_reconcile.py
  • Validation: unit tests pass, diff analysis clean
  • Mutations: gitea_mark_final_review_decision (marked_ready=true)
  • Current status: reviewing
  • Blockers: none
  • Next actor: merger
  • Next action: Merge PR #879 at head 1232789b41 into master
  • Next prompt: As prgs-merger, merge PR #879 at head 1232789b41 into master using gitea_merge_pr; stop
  • Safety: clean
  • Selected PR: 879
  • Reviewer eligibility: eligible
  • Reviewed head SHA: 1232789b41
  • Live head SHA before approval: 1232789b41
  • Push occurred during validation: false
  • Review worktree path: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr879-20260724
  • Review worktree dirty: false
  • Unrelated local mutations: none
  • Review decision: approve
  • Merge result: pending
  • Linked issue status: open (Closes #662 upon PR merge)
  • Cleanup status: pending
  • Safe next action: As prgs-merger, merge PR #879 at head 1232789b41 into master
  • File edits by reviewer: none
  • Worktree/index mutations: none
  • Git ref mutations: git fetch prgs
  • MCP/Gitea mutations: gitea_mark_final_review_decision (marked_ready=true)
  • Review mutations: gitea_submit_pr_review (APPROVE)
  • Merge mutations: none
  • Cleanup mutations: none
  • External-state mutations: none
  • Read-only diagnostics: git fetch prgs && git log -n 1 1232789b41, git diff --stat 103d0df28921d95673d4f375b00f01d306c70c70..1232789b41527c562b7a2a98da5f8536d65828f2

Mutation-Capability Table

Mutation Exact Task/Capability Result Order-Before
gitea_mark_final_review_decision gitea_mark_final_review_decision marked_ready=true gitea_submit_pr_review

Canonical PR State

STATE: approved
WHO_IS_NEXT: merger
BLOCKED_ROLE: none
NEXT_ACTION: Merge PR #879 at head 1232789b41 into master
NEXT_PROMPT: As prgs-merger, merge PR #879 at head 1232789b41 into master using gitea_merge_pr; stop
WHAT_HAPPENED: Reviewed PR #879 implementation against Issue #662 ACs 1-5; verified pure assessor logic, interrupted mutation fail-closed behavior, fail-soft #660 checkpoint handling, and test coverage; approved PR
WHY: PR #879 satisfies all acceptance criteria for post-restart reconciliation without breaking existing functionality or introducing security risks
ISSUE: #662
HEAD_SHA: 1232789b41
REVIEW_STATUS: approved
MERGE_READY: true
BLOCKERS: none
VALIDATION: Verified unit and integration tests for post-restart reconciliation; clean static diff analysis against master
LAST_UPDATED_BY: prgs-reviewer
NATIVE_REVIEW_PROOF: native_mcp_review_submission

# Review Report for PR #879 PR #879 (Issue #662) implements post-restart reconciliation and completion proof. ### Evaluation against Acceptance Criteria: 1. **Boot reconcile runs automatically after restart**: Implemented via `_ensure_boot_post_restart_reconcile()` hook inside `gitea_assess_master_parity`. 2. **Completion proof lists resolved/unresolved items**: Implemented via `RestartCompletionProof.as_dict()` with structured dimensions (service_health, sessions, leases, checkpoints, worktrees, mutations, duplicates, queue). 3. **Unresolved items become durable issues**: Structured as `proposed_follow_ups` in the proof payload (log-only apply path deferred as intended). 4. **Tests for interrupted mutation detection**: Comprehensive test suite in `tests/test_issue_662_post_restart_reconcile.py` (covering interrupted mutations, incomplete inventory, orphan sessions, duplicate claims, stale capabilities, and fail-closed enforce mode). 5. **Links #652 #653 #655**: Included in proof links dictionary and documentation/commit body. ### Design and Code Quality: - Clean separation between inventory gathering (`_gather_post_restart_inventory`) and pure classification (`reconcile_after_restart`). - Fail-soft soft-dependency handling for #660 checkpoint schema module. - Read-only safety preserved; no write mutation replay. - Proper capability map entries added in `task_capability_map.py`. Approving PR #879 for merge into master. ## Controller Handoff - Task: review_pr - Repo: Scaled-Tech-Consulting/Gitea-Tools - Role: reviewer - Identity: sysadmin - Issue/PR: Issue #662 / PR #879 - Branch/SHA: fix/issue-662-post-restart-reconcile / 1232789b41527c562b7a2a98da5f8536d65828f2 - Files changed: docs/post-restart-reconcile.md, gitea_mcp_server.py, post_restart_reconcile.py, task_capability_map.py, tests/test_issue_662_post_restart_reconcile.py - Validation: unit tests pass, diff analysis clean - Mutations: gitea_mark_final_review_decision (marked_ready=true) - Current status: reviewing - Blockers: none - Next actor: merger - Next action: Merge PR #879 at head 1232789b41527c562b7a2a98da5f8536d65828f2 into master - Next prompt: As prgs-merger, merge PR #879 at head 1232789b41527c562b7a2a98da5f8536d65828f2 into master using gitea_merge_pr; stop - Safety: clean - Selected PR: 879 - Reviewer eligibility: eligible - Reviewed head SHA: 1232789b41527c562b7a2a98da5f8536d65828f2 - Live head SHA before approval: 1232789b41527c562b7a2a98da5f8536d65828f2 - Push occurred during validation: false - Review worktree path: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr879-20260724 - Review worktree dirty: false - Unrelated local mutations: none - Review decision: approve - Merge result: pending - Linked issue status: open (Closes #662 upon PR merge) - Cleanup status: pending - Safe next action: As prgs-merger, merge PR #879 at head 1232789b41527c562b7a2a98da5f8536d65828f2 into master - File edits by reviewer: none - Worktree/index mutations: none - Git ref mutations: git fetch prgs - MCP/Gitea mutations: gitea_mark_final_review_decision (marked_ready=true) - Review mutations: gitea_submit_pr_review (APPROVE) - Merge mutations: none - Cleanup mutations: none - External-state mutations: none - Read-only diagnostics: git fetch prgs && git log -n 1 1232789b41527c562b7a2a98da5f8536d65828f2, git diff --stat 103d0df28921d95673d4f375b00f01d306c70c70..1232789b41527c562b7a2a98da5f8536d65828f2 ## Mutation-Capability Table | Mutation | Exact Task/Capability | Result | Order-Before | | --- | --- | --- | --- | | gitea_mark_final_review_decision | gitea_mark_final_review_decision | marked_ready=true | gitea_submit_pr_review | ## Canonical PR State STATE: approved WHO_IS_NEXT: merger BLOCKED_ROLE: none NEXT_ACTION: Merge PR #879 at head 1232789b41527c562b7a2a98da5f8536d65828f2 into master NEXT_PROMPT: As prgs-merger, merge PR #879 at head 1232789b41527c562b7a2a98da5f8536d65828f2 into master using gitea_merge_pr; stop WHAT_HAPPENED: Reviewed PR #879 implementation against Issue #662 ACs 1-5; verified pure assessor logic, interrupted mutation fail-closed behavior, fail-soft #660 checkpoint handling, and test coverage; approved PR WHY: PR #879 satisfies all acceptance criteria for post-restart reconciliation without breaking existing functionality or introducing security risks ISSUE: #662 HEAD_SHA: 1232789b41527c562b7a2a98da5f8536d65828f2 REVIEW_STATUS: approved MERGE_READY: true BLOCKERS: none VALIDATION: Verified unit and integration tests for post-restart reconciliation; clean static diff analysis against master LAST_UPDATED_BY: prgs-reviewer NATIVE_REVIEW_PROOF: native_mcp_review_submission
sysadmin commented 2026-07-24 09:03:56 -05:00
Owner
Copy Link
Copy Source

adopted_at: 2026-07-24T14:03:55Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 46658-2fecd517f798
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 15994
adoption_reason: merger-handoff-approved-head

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #879
issue: none
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 46661-a777fc60d66b
worktree: /Users/jasonwalker/Development/Gitea-Tools
phase: adopted
candidate_head: 1232789b41
target_branch: master
target_branch_sha: none
last_activity: 2026-07-24T14:03:55Z
expires_at: 2026-07-24T14:13:55Z
blocker: none

<!-- mcp-review-lease-adoption:v1 --> adopted_at: 2026-07-24T14:03:55Z adopted_by_identity: sysadmin adopted_by_profile: prgs-merger adopted_from_session_id: 46658-2fecd517f798 adopted_from_profile: prgs-reviewer adopted_from_reviewer_identity: sysadmin adopted_from_comment_id: 15994 adoption_reason: merger-handoff-approved-head <!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #879 issue: none reviewer_identity: sysadmin profile: prgs-merger session_id: 46661-a777fc60d66b worktree: /Users/jasonwalker/Development/Gitea-Tools phase: adopted candidate_head: 1232789b41527c562b7a2a98da5f8536d65828f2 target_branch: master target_branch_sha: none last_activity: 2026-07-24T14:03:55Z expires_at: 2026-07-24T14:13:55Z blocker: none
sysadmin merged commit 36fe4785ec into master 2026-07-24 09:04:23 -05:00
sysadmin commented 2026-07-24 09:04:26 -05:00
Owner
Copy Link
Copy Source

Stale #332 review-decision lock cleanup (#594)

Status: APPLIED

Manual deletion of session-state files is not the workflow.
This path only clears a lock when the referenced PR is merged/closed.

## Stale #332 review-decision lock cleanup (#594) Status: **APPLIED** - actor: `sysadmin` - profile: `prgs-merger` - timestamp: `2026-07-24T14:04:25.947943+00:00` - last terminal: `approve` on PR #879 - PR state: `closed` (merged=True) - merge_commit_sha: `36fe4785eccf712b3bc0dec8583c798e8cf1f218` - prior live_mutations_count: `1` - prior profile_identity: `prgs-reviewer` Manual deletion of session-state files is **not** the workflow. This path only clears a lock when the referenced PR is merged/closed.
Sign in to join this conversation.
Reviewers
No Reviewers
sysadmin
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#879