Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 97 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

fix: authoritative cross-role generic queue allocation (Closes #840) #841

Merged
sysadmin merged 2 commits from fix/issue-840-cross-role-queue-allocation into master 2026-07-23 00:37:55 -05:00
Conversation 10 Commits 2 Files Changed 7
+992 -56
jcwalker3 commented 2026-07-22 23:21:16 -05:00
Owner
Copy Link
Copy Source

Closes #840

Summary

Makes controller-owned queue allocation authoritative across roles so gitea_allocate_next_work under gitea-controller returns one eligible author/reviewer/merger/reconciler selection instead of binding only to role=controller and returning selected=null.

Changes

  • Controller cross-role allocation mode: inspect complete candidate inventory, apply canonical eligibility/ordering, return exactly one selection with action, required role/profile/namespace, pins, and lease/preview evidence.
  • Register generic task type process_work_queue (and hyphen alias) for controller routing.
  • Normalize controller role metadata to controller across whoami, control-plane guide, router, and allocator (stop silent reclassification as reconciler).
  • Preserve role isolation: controller routes only; does not gain author/reviewer/merger/reconciler mutation rights.
  • Dashboard remains read-only / non-authoritative for assignment.

Validation

  • 64 focused tests passed; 78 adjacent regression tests passed (author cycle evidence).

Canonical PR State

STATE: awaiting-review
WHO_IS_NEXT: reviewer
BLOCKED_ROLE: none
NEXT_ACTION: Review PR against issue #840 acceptance criteria; submit verdict; stop
NEXT_PROMPT: Review this PR as prgs-reviewer against #840 ACs (cross-role allocate, process_work_queue route, controller role metadata consistency, role isolation); stop after review
Closes #840 ## Summary Makes controller-owned queue allocation authoritative across roles so `gitea_allocate_next_work` under gitea-controller returns one eligible author/reviewer/merger/reconciler selection instead of binding only to `role=controller` and returning `selected=null`. ## Changes - Controller cross-role allocation mode: inspect complete candidate inventory, apply canonical eligibility/ordering, return exactly one selection with action, required role/profile/namespace, pins, and lease/preview evidence. - Register generic task type `process_work_queue` (and hyphen alias) for controller routing. - Normalize controller role metadata to `controller` across whoami, control-plane guide, router, and allocator (stop silent reclassification as reconciler). - Preserve role isolation: controller routes only; does not gain author/reviewer/merger/reconciler mutation rights. - Dashboard remains read-only / non-authoritative for assignment. ## Validation - 64 focused tests passed; 78 adjacent regression tests passed (author cycle evidence). ## Canonical PR State ```text STATE: awaiting-review WHO_IS_NEXT: reviewer BLOCKED_ROLE: none NEXT_ACTION: Review PR against issue #840 acceptance criteria; submit verdict; stop NEXT_PROMPT: Review this PR as prgs-reviewer against #840 ACs (cross-role allocate, process_work_queue route, controller role metadata consistency, role isolation); stop after review ```
jcwalker3 added 2 commits 2026-07-22 23:21:17 -05:00
fix: authoritative cross-role generic queue allocation (Closes #840) 648d9464ba 
Add controller-owned cross_role allocation mode that inspects the full
queue and returns one selection with required role/profile/action and
lease evidence. Document process_work_queue routing, normalize
controller role metadata, and keep the dashboard explanatory only.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
merge master into fix/issue-840-cross-role-queue-allocation 9468dd624d
jcwalker3 commented 2026-07-22 23:22:03 -05:00
Author
Owner
Copy Link
Copy Source

CTH: Author Handoff

Canonical Issue State

STATE: awaiting-review
WHO_IS_NEXT: reviewer
NEXT_ACTION: Review PR #841 against issue #840 acceptance criteria at head 9468dd624d2f193ee30d931e4760707976bf84d3; submit verdict; stop
NEXT_PROMPT:

Resume as prgs-reviewer on PR #841 for issue #840 at head 9468dd624d2f193ee30d931e4760707976bf84d3; validate ACs (cross-role allocate, process_work_queue route, controller role metadata, role isolation); submit review verdict; do not merge; stop

WHAT_HAPPENED: Published unpublished branch fix/issue-840-cross-role-queue-allocation at 9468dd624d2f193ee30d931e4760707976bf84d3; created PR #841 into master with Closes #840; issue #840 labels set to status:pr-open; recovered dead-session issue lock as jcwalker3/prgs-author
WHY: Author stage complete; implementation already committed; remaining work is publish + PR + handoff to reviewer
RELATED_PRS: #841
BLOCKERS: none
VALIDATION: 64 focused tests passed; 78 adjacent regression tests passed (author cycle evidence)
LAST_UPDATED_BY: jcwalker3 (prgs-author)

Canonical Handoff

REPOSITORY: Scaled-Tech-Consulting/Gitea-Tools
ISSUE: #840
PR: #841
WORKFLOW_STATE: needs-review
HEAD_SHA: 9468dd624d
BASE_BRANCH: master
BASE_OR_MERGE_SHA: caaae9b6ee
ACTING_ROLE: author
ACTING_IDENTITY: jcwalker3 (prgs-author)
COMPLETED_ACTIONS: published unpublished branch fix/issue-840-cross-role-queue-allocation at 9468dd624d2f193ee30d931e4760707976bf84d3; created PR #841 into master with Closes #840; issue labels status:pr-open
VALIDATION_EVIDENCE: 64 focused tests passed; 78 adjacent regression tests passed (author cycle evidence)
MUTATION_LEDGER: gitea_publish_unpublished_issue_branch performed; gitea_lock_issue dead-session recovery; gitea_create_pr #841
BLOCKERS: none
NEXT_ACTOR: reviewer
NEXT_ACTION: Review PR #841 against issue #840 acceptance criteria at head 9468dd624d2f193ee30d931e4760707976bf84d3; submit verdict; stop
PROHIBITED_ACTIONS: merge, approve-as-author, rewrite published head without expected_head pin
NEXT_PROMPT: Resume as prgs-reviewer on PR #841 for issue #840 at head 9468dd624d2f193ee30d931e4760707976bf84d3; validate ACs (cross-role allocate, process_work_queue route, controller role metadata, role isolation); submit review verdict; do not merge; stop
WORKFLOW_FAILURE_ISSUES: none
LAST_UPDATED: 2026-07-23T04:21:29Z

## CTH: Author Handoff ## Canonical Issue State STATE: awaiting-review WHO_IS_NEXT: reviewer NEXT_ACTION: Review PR #841 against issue #840 acceptance criteria at head 9468dd624d2f193ee30d931e4760707976bf84d3; submit verdict; stop NEXT_PROMPT: ```text Resume as prgs-reviewer on PR #841 for issue #840 at head 9468dd624d2f193ee30d931e4760707976bf84d3; validate ACs (cross-role allocate, process_work_queue route, controller role metadata, role isolation); submit review verdict; do not merge; stop ``` WHAT_HAPPENED: Published unpublished branch fix/issue-840-cross-role-queue-allocation at 9468dd624d2f193ee30d931e4760707976bf84d3; created PR #841 into master with Closes #840; issue #840 labels set to status:pr-open; recovered dead-session issue lock as jcwalker3/prgs-author WHY: Author stage complete; implementation already committed; remaining work is publish + PR + handoff to reviewer RELATED_PRS: #841 BLOCKERS: none VALIDATION: 64 focused tests passed; 78 adjacent regression tests passed (author cycle evidence) LAST_UPDATED_BY: jcwalker3 (prgs-author) <!-- sph:v1 --> ## Canonical Handoff REPOSITORY: Scaled-Tech-Consulting/Gitea-Tools ISSUE: #840 PR: #841 WORKFLOW_STATE: needs-review HEAD_SHA: 9468dd624d2f193ee30d931e4760707976bf84d3 BASE_BRANCH: master BASE_OR_MERGE_SHA: caaae9b6eef496c8f8ed451ac216250c62d495c6 ACTING_ROLE: author ACTING_IDENTITY: jcwalker3 (prgs-author) COMPLETED_ACTIONS: published unpublished branch fix/issue-840-cross-role-queue-allocation at 9468dd624d2f193ee30d931e4760707976bf84d3; created PR #841 into master with Closes #840; issue labels status:pr-open VALIDATION_EVIDENCE: 64 focused tests passed; 78 adjacent regression tests passed (author cycle evidence) MUTATION_LEDGER: gitea_publish_unpublished_issue_branch performed; gitea_lock_issue dead-session recovery; gitea_create_pr #841 BLOCKERS: none NEXT_ACTOR: reviewer NEXT_ACTION: Review PR #841 against issue #840 acceptance criteria at head 9468dd624d2f193ee30d931e4760707976bf84d3; submit verdict; stop PROHIBITED_ACTIONS: merge, approve-as-author, rewrite published head without expected_head pin NEXT_PROMPT: Resume as prgs-reviewer on PR #841 for issue #840 at head 9468dd624d2f193ee30d931e4760707976bf84d3; validate ACs (cross-role allocate, process_work_queue route, controller role metadata, role isolation); submit review verdict; do not merge; stop WORKFLOW_FAILURE_ISSUES: none LAST_UPDATED: 2026-07-23T04:21:29Z
sysadmin commented 2026-07-22 23:34:31 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #841
issue: none
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 99151-fbe053dbf1f0
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-840-cross-role-queue-allocation
phase: claimed
candidate_head: none
target_branch: master
target_branch_sha: none
last_activity: 2026-07-23T04:34:31Z
expires_at: 2026-07-23T04:44:31Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #841 issue: none reviewer_identity: sysadmin profile: prgs-reviewer session_id: 99151-fbe053dbf1f0 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-840-cross-role-queue-allocation phase: claimed candidate_head: none target_branch: master target_branch_sha: none last_activity: 2026-07-23T04:34:31Z expires_at: 2026-07-23T04:44:31Z blocker: none
sysadmin commented 2026-07-22 23:39:34 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #841
issue: none
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 99151-fbe053dbf1f0
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-840-cross-role-queue-allocation
phase: released
candidate_head: none
target_branch: master
target_branch_sha: none
last_activity: 2026-07-23T04:39:33Z
expires_at: 2026-07-23T04:49:33Z
blocker: manual-release

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #841 issue: none reviewer_identity: sysadmin profile: prgs-reviewer session_id: 99151-fbe053dbf1f0 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-840-cross-role-queue-allocation phase: released candidate_head: none target_branch: master target_branch_sha: none last_activity: 2026-07-23T04:39:33Z expires_at: 2026-07-23T04:49:33Z blocker: manual-release
sysadmin commented 2026-07-22 23:50:10 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #841
issue: none
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 33606-97164d686627
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-840-cross-role-queue-allocation
phase: claimed
candidate_head: none
target_branch: master
target_branch_sha: none
last_activity: 2026-07-23T04:50:10Z
expires_at: 2026-07-23T05:00:10Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #841 issue: none reviewer_identity: sysadmin profile: prgs-reviewer session_id: 33606-97164d686627 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-840-cross-role-queue-allocation phase: claimed candidate_head: none target_branch: master target_branch_sha: none last_activity: 2026-07-23T04:50:10Z expires_at: 2026-07-23T05:00:10Z blocker: none
sysadmin commented 2026-07-23 00:18:00 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #841
issue: #840
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 73969-4828a781c03b
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-840-cross-role-queue-allocation
phase: claimed
candidate_head: 9468dd624d
target_branch: master
target_branch_sha: none
last_activity: 2026-07-23T05:18:00Z
expires_at: 2026-07-23T05:28:00Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #841 issue: #840 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 73969-4828a781c03b worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-840-cross-role-queue-allocation phase: claimed candidate_head: 9468dd624d2f193ee30d931e4760707976bf84d3 target_branch: master target_branch_sha: none last_activity: 2026-07-23T05:18:00Z expires_at: 2026-07-23T05:28:00Z blocker: none
sysadmin approved these changes 2026-07-23 00:22:29 -05:00
sysadmin left a comment
Owner
Copy Link
Copy Source

Approved PR #841. Code implementation correctly makes controller queue allocation authoritative across all worker roles (Issue #840), registers process_work_queue, normalizes controller metadata, and all unit test suites (238 tests) pass.

Canonical PR State

STATE: ready-to-merge
WHO_IS_NEXT: merger
NEXT_ACTION: Merge PR #841 into master branch
NEXT_PROMPT:

Merge PR #841 for issue #840

WHAT_HAPPENED: Terminal review approved for PR #841 at head 9468dd624d by sysadmin.
WHY: Implementation satisfies all acceptance criteria of Issue #840 and passed 238 unit tests.
ISSUE: #840
HEAD_SHA: 9468dd624d
REVIEW_STATUS: approved / approval_at_current_head
MERGE_READY: true
BLOCKERS: none
VALIDATION: 238 unit tests passed across cross_role_queue_allocation, allocator, inventory, lease, capability, and dashboard suites
NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=mcp_server; token_fingerprint=4e784cbaffe67e4e
LAST_UPDATED_BY: sysadmin

Approved PR #841. Code implementation correctly makes controller queue allocation authoritative across all worker roles (Issue #840), registers process_work_queue, normalizes controller metadata, and all unit test suites (238 tests) pass. ## Canonical PR State STATE: ready-to-merge WHO_IS_NEXT: merger NEXT_ACTION: Merge PR #841 into master branch NEXT_PROMPT: ```text Merge PR #841 for issue #840 ``` WHAT_HAPPENED: Terminal review approved for PR #841 at head 9468dd624d2f193ee30d931e4760707976bf84d3 by sysadmin. WHY: Implementation satisfies all acceptance criteria of Issue #840 and passed 238 unit tests. ISSUE: #840 HEAD_SHA: 9468dd624d2f193ee30d931e4760707976bf84d3 REVIEW_STATUS: approved / approval_at_current_head MERGE_READY: true BLOCKERS: none VALIDATION: 238 unit tests passed across cross_role_queue_allocation, allocator, inventory, lease, capability, and dashboard suites NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=mcp_server; token_fingerprint=4e784cbaffe67e4e LAST_UPDATED_BY: sysadmin
sysadmin commented 2026-07-23 00:23:07 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #841
issue: #840
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 73969-4828a781c03b
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-840-cross-role-queue-allocation
phase: released
candidate_head: 9468dd624d
target_branch: master
target_branch_sha: none
last_activity: 2026-07-23T05:23:07Z
expires_at: 2026-07-23T05:33:07Z
blocker: manual-release

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #841 issue: #840 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 73969-4828a781c03b worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-840-cross-role-queue-allocation phase: released candidate_head: 9468dd624d2f193ee30d931e4760707976bf84d3 target_branch: master target_branch_sha: none last_activity: 2026-07-23T05:23:07Z expires_at: 2026-07-23T05:33:07Z blocker: manual-release
sysadmin commented 2026-07-23 00:37:08 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #841
issue: #840
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 13395-68b9ad4520a3
worktree: /Users/jasonwalker/Development/Gitea-Tools
phase: claimed
candidate_head: 9468dd624d
target_branch: master
target_branch_sha: caaae9b6ee
last_activity: 2026-07-23T05:37:08Z
expires_at: 2026-07-23T05:47:08Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #841 issue: #840 reviewer_identity: sysadmin profile: prgs-merger session_id: 13395-68b9ad4520a3 worktree: /Users/jasonwalker/Development/Gitea-Tools phase: claimed candidate_head: 9468dd624d2f193ee30d931e4760707976bf84d3 target_branch: master target_branch_sha: caaae9b6eef496c8f8ed451ac216250c62d495c6 last_activity: 2026-07-23T05:37:08Z expires_at: 2026-07-23T05:47:08Z blocker: none
sysadmin merged commit 4f3a464a90 into master 2026-07-23 00:37:55 -05:00
sysadmin commented 2026-07-23 00:37:57 -05:00
Owner
Copy Link
Copy Source

Stale #332 review-decision lock cleanup (#594)

Status: APPLIED

Manual deletion of session-state files is not the workflow.
This path only clears a lock when the referenced PR is merged/closed.

## Stale #332 review-decision lock cleanup (#594) Status: **APPLIED** - actor: `sysadmin` - profile: `prgs-merger` - timestamp: `2026-07-23T05:37:57.458038+00:00` - last terminal: `approve` on PR #841 - PR state: `closed` (merged=True) - merge_commit_sha: `4f3a464a90e14a6595cfb7339dd3d8d6ed957c93` - prior live_mutations_count: `3` - prior profile_identity: `prgs-reviewer` Manual deletion of session-state files is **not** the workflow. This path only clears a lock when the referenced PR is merged/closed.
sysadmin commented 2026-07-23 00:43:29 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #841
issue: #840
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 13395-68b9ad4520a3
worktree: /Users/jasonwalker/Development/Gitea-Tools
phase: released
candidate_head: 9468dd624d
target_branch: master
target_branch_sha: caaae9b6ee
last_activity: 2026-07-23T05:43:28Z
expires_at: 2026-07-23T05:53:28Z
blocker: post-merge-moot

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #841 issue: #840 reviewer_identity: sysadmin profile: prgs-merger session_id: 13395-68b9ad4520a3 worktree: /Users/jasonwalker/Development/Gitea-Tools phase: released candidate_head: 9468dd624d2f193ee30d931e4760707976bf84d3 target_branch: master target_branch_sha: caaae9b6eef496c8f8ed451ac216250c62d495c6 last_activity: 2026-07-23T05:43:28Z expires_at: 2026-07-23T05:53:28Z blocker: post-merge-moot
Sign in to join this conversation.
Reviewers
No Reviewers
sysadmin
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#841