fix: exclude foreign-claimed work from allocation (Closes #765) #773

2026-07-20T13:53:21-05:00

jcwalker3 commented

2026-07-20 13:53:21 -05:00

Closes #765

Summary

Recovers the preserved #765 implementation onto current prgs/master (0c2f45a) and publishes foreign-lease exclusion for the controller-owned allocator.

Before ranking, active claims owned by a different controller_instance_id are excluded with reason claimed_by_other_session. Ranking continues to the next unclaimed candidate. Own-task resume remains possible. Task-local blockers no longer blockade the entire author queue. controller_instance_id is persisted on sessions and surfaced on lease rows; the workflow dashboard applies the same exclusion.

Recovery proof

Field	Value
LLM_LOCK_ID	`author-765-recovery-d4e629909f8f45a1-1784573047`
Durable recovery comment	13206
Preserved candidate	`d06198b97d583f0b960adcb435931effbf305516`
Preserve ref	`preserve/issue-765-d06198b`
Stable patch-id	`bacafc5f96f709ea195fdce733ba98449ae4513f`
Published head	`ad13d872df3ac22630617c4805832d0875e258a3`
Base master	`0c2f45abb7c0db96c477e9a6db35a6728e654311`
Integration	lock at master tip → clean cherry-pick of preserved commit → `gitea_commit_files`

Files

allocator_service.py
control_plane_db.py
gitea_mcp_server.py
workflow_dashboard.py
tests/test_allocator_foreign_lease_exclusion.py (new)

Validation

pytest tests/test_allocator_foreign_lease_exclusion.py -q
# 22 passed

pytest tests/test_allocator_foreign_lease_exclusion.py tests/test_allocator_service.py tests/test_allocator_dependencies.py tests/test_allocator_inventory_mcp.py tests/test_control_plane_db.py tests/test_workflow_dashboard.py -q
# 101 passed

pytest -q
# 3861 passed, 6 skipped, 11 failed
# All 11 failures reproduce identically on pristine master 0c2f45a (baseline-proven):
#   test_commit_payloads (6), test_issue_702_review_findings_f1_f6 (2),
#   test_mcp_server PreflightVerification (1), test_post_merge_moot_lease (1),
#   test_reconciler_supersession_close (1)
# These are pre-existing #618/#737 master drift, outside this PR's diff.

Checklist

Identity matches author role (jcwalker3 / prgs-author)
No secrets committed
Focused #765 suite and allocator/control-plane/dashboard tests passed
Full suite compared to baseline master
Single PR for #765 only

Next role

reviewer — review at head ad13d872df3ac22630617c4805832d0875e258a3.

Closes #765 ## Summary Recovers the preserved #765 implementation onto current `prgs/master` (`0c2f45a`) and publishes foreign-lease exclusion for the controller-owned allocator. Before ranking, active claims owned by a different `controller_instance_id` are excluded with reason `claimed_by_other_session`. Ranking continues to the next unclaimed candidate. Own-task resume remains possible. Task-local blockers no longer blockade the entire author queue. `controller_instance_id` is persisted on sessions and surfaced on lease rows; the workflow dashboard applies the same exclusion. ## Recovery proof | Field | Value | |---|---| | LLM_LOCK_ID | `author-765-recovery-d4e629909f8f45a1-1784573047` | | Durable recovery comment | 13206 | | Preserved candidate | `d06198b97d583f0b960adcb435931effbf305516` | | Preserve ref | `preserve/issue-765-d06198b` | | Stable patch-id | `bacafc5f96f709ea195fdce733ba98449ae4513f` | | Published head | `ad13d872df3ac22630617c4805832d0875e258a3` | | Base master | `0c2f45abb7c0db96c477e9a6db35a6728e654311` | | Integration | lock at master tip → clean cherry-pick of preserved commit → `gitea_commit_files` | ## Files - `allocator_service.py` - `control_plane_db.py` - `gitea_mcp_server.py` - `workflow_dashboard.py` - `tests/test_allocator_foreign_lease_exclusion.py` (new) ## Validation ```text pytest tests/test_allocator_foreign_lease_exclusion.py -q # 22 passed pytest tests/test_allocator_foreign_lease_exclusion.py tests/test_allocator_service.py tests/test_allocator_dependencies.py tests/test_allocator_inventory_mcp.py tests/test_control_plane_db.py tests/test_workflow_dashboard.py -q # 101 passed pytest -q # 3861 passed, 6 skipped, 11 failed # All 11 failures reproduce identically on pristine master 0c2f45a (baseline-proven): # test_commit_payloads (6), test_issue_702_review_findings_f1_f6 (2), # test_mcp_server PreflightVerification (1), test_post_merge_moot_lease (1), # test_reconciler_supersession_close (1) # These are pre-existing #618/#737 master drift, outside this PR's diff. ``` ## Checklist - [x] Identity matches author role (`jcwalker3` / `prgs-author`) - [x] No secrets committed - [x] Focused #765 suite and allocator/control-plane/dashboard tests passed - [x] Full suite compared to baseline master - [x] Single PR for #765 only ## Next role **reviewer** — review at head `ad13d872df3ac22630617c4805832d0875e258a3`.

jcwalker3 added 1 commit 2026-07-20 13:53:22 -05:00

fix: exclude foreign-claimed work from allocation instead of blockading the queue (Closes #765 ) ad13d872df

Recovered preserved candidate d06198b onto current master 0c2f45a via clean
cherry-pick. Active foreign leases are excluded before allocator ranking;
controller_instance_id ownership is persisted; dashboard matches allocator
exclusion. Stable patch-id bacafc5f… preserved.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 commented

2026-07-20 13:54:02 -05:00

Canonical Issue State

STATE: pr-open — PR #773 published for Issue #765 at head ad13d872df
WHO_IS_NEXT: reviewer
NEXT_ACTION: review PR #773 at pinned head ad13d872df under prgs-reviewer; do not author further #765 changes unless requested changes land
NEXT_PROMPT:

Review PR #773 (Closes #765) as prgs-reviewer.

Head: ad13d872df3ac22630617c4805832d0875e258a3
Base: master 0c2f45abb7c0db96c477e9a6db35a6728e654311
Branch: fix/issue-765-allocator-foreign-lease
Worktree used by author: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-765-allocator-ownership
Stable patch-id: bacafc5f96f709ea195fdce733ba98449ae4513f (matches preserved d06198b)

Scope: foreign active leases excluded before allocator ranking; controller_instance_id ownership; next unclaimed selection; own-task resume; task-local blockers; all-claimed wait; dashboard parity; schema migration compatible.

Validation already run by author:
- focused exclusion suite: 22 passed
- allocator/control-plane/dashboard suite: 101 passed
- full suite: 3861 passed / 6 skipped / 11 baseline-proven failures on pristine master 0c2f45a

Do not merge from reviewer. Do not redesign. Do not touch #681, preserve/issue-618-cbf56cc, or #770 leftovers.

WHAT_HAPPENED: Author recovery for #765 completed. Recovered lock via gitea_lock_issue after parking branch at master tip with preserve/issue-765-d06198b holding candidate d06198b. Cherry-picked preserved commit cleanly onto 0c2f45a (local c4b504d; stable patch-id bacafc5f…), re-ran focused and full tests, published via gitea_commit_files to head ad13d872, opened PR #773 only.
WHY: Comment 13206 classified AUTHOR_RECOVERY_REQUIRED; #765 behavior was absent from master; exclusive author WIP was free (open PR inventory empty); candidate was complete and clean.
RELATED_PRS: #773 (this PR, open, closes #765)
BLOCKERS: none
VALIDATION: Gate Zero parity at 0c2f45a restart_required=false stop_required=false; identity jcwalker3/prgs-author match; no competing live author lease for #765; open PR inventory empty before create; focused 22 passed; broader 101 passed; full suite 3861 passed with 11 baseline-proven failures; remote branch head ad13d872 verified via ls-remote; issue labels moved to status:pr-open
LAST_UPDATED_BY: prgs-author / jcwalker3 / LLM_LOCK_ID=author-765-recovery-d4e629909f8f45a1-1784573047

[THREAD STATE LEDGER] PR #773 / Issue #765 — author recovery published; next role reviewer

What is true now:

PR state: open #773 head ad13d872df base master
Issue state: open with status:pr-open (Closes #765)
Current head SHA: ad13d872df
Server-side decision state: server-side state changed — branch published and PR created; no review verdict posted
Local verdict/state: author recovery complete for #765 only (LLM_LOCK_ID=author-765-recovery-d4e629909f8f45a1-1784573047)
Latest known validation: focused 22 passed; broader 101 passed; full suite baseline-compared

What changed:

Recovered issue lock on fix/issue-765-allocator-foreign-lease via gitea_lock_issue (live lock, claimant jcwalker3)
Integrated preserved candidate d06198b onto master 0c2f45a by clean cherry-pick then gitea_commit_files published ad13d872
Opened exactly one PR #773 closing Allocator ignores active foreign leases and lets one claimed issue blockade the whole author queue (#765)
Labels transitioned to status:pr-open

What is blocked:

Blocker classification: no blocker

Who/what acts next:

Next actor: reviewer
Required action: review PR #773 at head ad13d872df
Do not do: re-author #765 without review feedback; self-approve; merge; allocate new work; touch #681 or preserve/issue-618-cbf56cc or #770 leftovers; force-push; redesign the preserved fix
Resume from: reviewer session at PR #773 head ad13d872

## Canonical Issue State STATE: pr-open — PR #773 published for Issue #765 at head ad13d872df3ac22630617c4805832d0875e258a3 WHO_IS_NEXT: reviewer NEXT_ACTION: review PR #773 at pinned head ad13d872df3ac22630617c4805832d0875e258a3 under prgs-reviewer; do not author further #765 changes unless requested changes land NEXT_PROMPT: ```text Review PR #773 (Closes #765) as prgs-reviewer. Head: ad13d872df3ac22630617c4805832d0875e258a3 Base: master 0c2f45abb7c0db96c477e9a6db35a6728e654311 Branch: fix/issue-765-allocator-foreign-lease Worktree used by author: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-765-allocator-ownership Stable patch-id: bacafc5f96f709ea195fdce733ba98449ae4513f (matches preserved d06198b) Scope: foreign active leases excluded before allocator ranking; controller_instance_id ownership; next unclaimed selection; own-task resume; task-local blockers; all-claimed wait; dashboard parity; schema migration compatible. Validation already run by author: - focused exclusion suite: 22 passed - allocator/control-plane/dashboard suite: 101 passed - full suite: 3861 passed / 6 skipped / 11 baseline-proven failures on pristine master 0c2f45a Do not merge from reviewer. Do not redesign. Do not touch #681, preserve/issue-618-cbf56cc, or #770 leftovers. ``` WHAT_HAPPENED: Author recovery for #765 completed. Recovered lock via gitea_lock_issue after parking branch at master tip with preserve/issue-765-d06198b holding candidate d06198b. Cherry-picked preserved commit cleanly onto 0c2f45a (local c4b504d; stable patch-id bacafc5f…), re-ran focused and full tests, published via gitea_commit_files to head ad13d872, opened PR #773 only. WHY: Comment 13206 classified AUTHOR_RECOVERY_REQUIRED; #765 behavior was absent from master; exclusive author WIP was free (open PR inventory empty); candidate was complete and clean. RELATED_PRS: #773 (this PR, open, closes #765) BLOCKERS: none VALIDATION: Gate Zero parity at 0c2f45a restart_required=false stop_required=false; identity jcwalker3/prgs-author match; no competing live author lease for #765; open PR inventory empty before create; focused 22 passed; broader 101 passed; full suite 3861 passed with 11 baseline-proven failures; remote branch head ad13d872 verified via ls-remote; issue labels moved to status:pr-open LAST_UPDATED_BY: prgs-author / jcwalker3 / LLM_LOCK_ID=author-765-recovery-d4e629909f8f45a1-1784573047 --- [THREAD STATE LEDGER] PR #773 / Issue #765 — author recovery published; next role reviewer What is true now: - PR state: open #773 head ad13d872df3ac22630617c4805832d0875e258a3 base master - Issue state: open with status:pr-open (Closes #765) - Current head SHA: ad13d872df3ac22630617c4805832d0875e258a3 - Server-side decision state: server-side state changed — branch published and PR created; no review verdict posted - Local verdict/state: author recovery complete for #765 only (LLM_LOCK_ID=author-765-recovery-d4e629909f8f45a1-1784573047) - Latest known validation: focused 22 passed; broader 101 passed; full suite baseline-compared What changed: - Recovered issue lock on fix/issue-765-allocator-foreign-lease via gitea_lock_issue (live lock, claimant jcwalker3) - Integrated preserved candidate d06198b onto master 0c2f45a by clean cherry-pick then gitea_commit_files published ad13d872 - Opened exactly one PR #773 closing #765 - Labels transitioned to status:pr-open What is blocked: - Blocker classification: no blocker Who/what acts next: - Next actor: reviewer - Required action: review PR #773 at head ad13d872df3ac22630617c4805832d0875e258a3 - Do not do: re-author #765 without review feedback; self-approve; merge; allocate new work; touch #681 or preserve/issue-618-cbf56cc or #770 leftovers; force-push; redesign the preserved fix - Resume from: reviewer session at PR #773 head ad13d872

sysadmin commented

2026-07-20 14:03:28 -05:00

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #773
issue: #765
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: reviewer-773-765-4b0b18cf4d154c9c-1784574196
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-418
phase: claimed
candidate_head: ad13d872df
target_branch: master
target_branch_sha: 0c2f45abb7
last_activity: 2026-07-20T19:03:28Z
expires_at: 2026-07-20T19:13:28Z
blocker: none

repo: Scaled-Tech-Consulting/Gitea-Tools pr: #773 issue: #765 reviewer_identity: sysadmin profile: prgs-reviewer session_id: reviewer-773-765-4b0b18cf4d154c9c-1784574196 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-418 phase: claimed candidate_head: ad13d872df3ac22630617c4805832d0875e258a3 target_branch: master target_branch_sha: 0c2f45abb7c0db96c477e9a6db35a6728e654311 last_activity: 2026-07-20T19:03:28Z expires_at: 2026-07-20T19:13:28Z blocker: none

sysadmin approved these changes 2026-07-20 14:09:52 -05:00

sysadmin left a comment

Canonical PR State

STATE: approved at current head; awaiting independent merger
WHO_IS_NEXT: merger
NEXT_ACTION: Merge PR #773 at exact reviewed head ad13d872df under prgs-merger after Gate Zero; do not re-review unless head moves; do not author changes.
NEXT_PROMPT:

Role: MERGER (prgs-merger / independent from author jcwalker3 and reviewer sysadmin)
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
PR: #773 (Closes #765)
Reviewed head: ad13d872df3ac22630617c4805832d0875e258a3
Base: master 0c2f45abb7c0db96c477e9a6db35a6728e654311

Gate Zero: control == prgs/master; restart_required=false; stop_required=false.
Adopt/acquire merger lease pinned to ad13d872…; re-read live head; merge only if still exact and approval at current head.
After merge: terminal cleanup for this PR/issue only (leases, labels, worktrees, remote branch, handoff). Preserve preserve/issue-765-d06198b until cleanup policy says otherwise. Restore/remove temporary symlink branches/mcp-author-clean-ns during terminal cleanup.
Do not re-author; do not force-push; do not touch #681 or preserve/issue-618-cbf56cc.

WHAT_HAPPENED: Independent formal review of PR #773 completed by sysadmin/prgs-reviewer (LLM_LOCK_ID=reviewer-773-765-4b0b18cf4d154c9c-1784574196). Lease acquired on worktree branches/review-418 pinned to ad13d872. Provenance, ACs, failure modes, 22-vs-23 accounting, focused/related/full tests, and baseline signature comparison completed. Formal APPROVE submitted at exact head via native MCP gitea_submit_pr_review.
WHY: Issue #765 requires foreign active leases to be excluded before allocator ranking so one claimed issue cannot blockade the author queue. The published head implements that ownership model with controller_instance_id, dashboard parity, and regression tests; independent validation confirms ACs and no regression beyond baseline master failures.
ISSUE: #765
HEAD_SHA: ad13d872df
REVIEW_STATUS: APPROVED
MERGE_READY: yes (approval at current head; mergeable; no blocking change requests from this review)
BLOCKERS: none for merge of this PR; 11 full-suite failures are baseline-proven on pristine master 0c2f45a and outside this PR's five-file diff
VALIDATION: Gate Zero pass; workflow_hash 263d0a6cb8a6 boundary clean; parent==base; patch-id bacafc5f96f709ea195fdce733ba98449ae4513f matches preserve d06198b; five-file scoped diff; focused 22 passed; related 101 passed; full 3861 passed / 6 skipped / 11 baseline-matched failures; 22 vs 23 resolved as prior accounting miscount (no lost coverage); symlink mcp-author-clean-ns is publication provenance only (restore in terminal cleanup)
NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=gitea_submit_pr_review; profile=prgs-reviewer; identity=sysadmin; session_id=reviewer-773-765-4b0b18cf4d154c9c-1784574196; head=ad13d872df3ac22630617c4805832d0875e258a3
LAST_UPDATED_BY: sysadmin / prgs-reviewer / LLM_LOCK_ID=reviewer-773-765-4b0b18cf4d154c9c-1784574196

Formal independent review — APPROVE

Provenance

Parent of head = exact base 0c2f45a…
Stable patch-id bacafc5f… matches d06198b and preserve/issue-765-d06198b
Files: allocator_service.py, control_plane_db.py, gitea_mcp_server.py, workflow_dashboard.py, tests/test_allocator_foreign_lease_exclusion.py
No unrelated repository churn in PR diff

ACs #765 (all PASS)

Foreign lease exclusion before ranking; next unclaimed selection; own-task resume; task-local blockers; all-claimed wait; controller_instance_id persist/enforce; skipped accounting; backward-compatible schema migration; dashboard parity.

Failure modes (all PASS)

Expired/released not active; missing instance fails safe; same profile different controller instance is foreign; no special-casing; no anti-stomp/role/WIP weakening.

Tests

22 focused (not 23 — prior miscount; no lost coverage)
101 related allocator/control-plane/dashboard
Full suite 3861/6/11 with exact same 11 nodeids and signatures on pristine 0c2f45a (+22 = new module)

Symlink

mcp-author-clean-ns → issue-765-allocator-ownership (under branches/, not control). Publication provenance only. Reviewer did not modify. Restore during terminal cleanup.

Verdict

APPROVE at ad13d872df. Do not merge from reviewer.

## Canonical PR State STATE: approved at current head; awaiting independent merger WHO_IS_NEXT: merger NEXT_ACTION: Merge PR #773 at exact reviewed head ad13d872df3ac22630617c4805832d0875e258a3 under prgs-merger after Gate Zero; do not re-review unless head moves; do not author changes. NEXT_PROMPT: ```text Role: MERGER (prgs-merger / independent from author jcwalker3 and reviewer sysadmin) Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools PR: #773 (Closes #765) Reviewed head: ad13d872df3ac22630617c4805832d0875e258a3 Base: master 0c2f45abb7c0db96c477e9a6db35a6728e654311 Gate Zero: control == prgs/master; restart_required=false; stop_required=false. Adopt/acquire merger lease pinned to ad13d872…; re-read live head; merge only if still exact and approval at current head. After merge: terminal cleanup for this PR/issue only (leases, labels, worktrees, remote branch, handoff). Preserve preserve/issue-765-d06198b until cleanup policy says otherwise. Restore/remove temporary symlink branches/mcp-author-clean-ns during terminal cleanup. Do not re-author; do not force-push; do not touch #681 or preserve/issue-618-cbf56cc. ``` WHAT_HAPPENED: Independent formal review of PR #773 completed by sysadmin/prgs-reviewer (LLM_LOCK_ID=reviewer-773-765-4b0b18cf4d154c9c-1784574196). Lease acquired on worktree branches/review-418 pinned to ad13d872. Provenance, ACs, failure modes, 22-vs-23 accounting, focused/related/full tests, and baseline signature comparison completed. Formal APPROVE submitted at exact head via native MCP gitea_submit_pr_review. WHY: Issue #765 requires foreign active leases to be excluded before allocator ranking so one claimed issue cannot blockade the author queue. The published head implements that ownership model with controller_instance_id, dashboard parity, and regression tests; independent validation confirms ACs and no regression beyond baseline master failures. ISSUE: #765 HEAD_SHA: ad13d872df3ac22630617c4805832d0875e258a3 REVIEW_STATUS: APPROVED MERGE_READY: yes (approval at current head; mergeable; no blocking change requests from this review) BLOCKERS: none for merge of this PR; 11 full-suite failures are baseline-proven on pristine master 0c2f45a and outside this PR's five-file diff VALIDATION: Gate Zero pass; workflow_hash 263d0a6cb8a6 boundary clean; parent==base; patch-id bacafc5f96f709ea195fdce733ba98449ae4513f matches preserve d06198b; five-file scoped diff; focused 22 passed; related 101 passed; full 3861 passed / 6 skipped / 11 baseline-matched failures; 22 vs 23 resolved as prior accounting miscount (no lost coverage); symlink mcp-author-clean-ns is publication provenance only (restore in terminal cleanup) NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=gitea_submit_pr_review; profile=prgs-reviewer; identity=sysadmin; session_id=reviewer-773-765-4b0b18cf4d154c9c-1784574196; head=ad13d872df3ac22630617c4805832d0875e258a3 LAST_UPDATED_BY: sysadmin / prgs-reviewer / LLM_LOCK_ID=reviewer-773-765-4b0b18cf4d154c9c-1784574196 --- ## Formal independent review — APPROVE ### Provenance - Parent of head = exact base 0c2f45a… - Stable patch-id bacafc5f… matches d06198b and preserve/issue-765-d06198b - Files: allocator_service.py, control_plane_db.py, gitea_mcp_server.py, workflow_dashboard.py, tests/test_allocator_foreign_lease_exclusion.py - No unrelated repository churn in PR diff ### ACs #765 (all PASS) Foreign lease exclusion before ranking; next unclaimed selection; own-task resume; task-local blockers; all-claimed wait; controller_instance_id persist/enforce; skipped accounting; backward-compatible schema migration; dashboard parity. ### Failure modes (all PASS) Expired/released not active; missing instance fails safe; same profile different controller instance is foreign; no special-casing; no anti-stomp/role/WIP weakening. ### Tests - 22 focused (not 23 — prior miscount; no lost coverage) - 101 related allocator/control-plane/dashboard - Full suite 3861/6/11 with exact same 11 nodeids and signatures on pristine 0c2f45a (+22 = new module) ### Symlink mcp-author-clean-ns → issue-765-allocator-ownership (under branches/, not control). Publication provenance only. Reviewer did not modify. Restore during terminal cleanup. ### Verdict APPROVE at ad13d872df3ac22630617c4805832d0875e258a3. Do not merge from reviewer.

sysadmin commented

2026-07-20 14:10:15 -05:00

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #773
issue: #765
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: reviewer-773-765-4b0b18cf4d154c9c-1784574196
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-418
phase: released
candidate_head: ad13d872df
target_branch: master
target_branch_sha: 0c2f45abb7
last_activity: 2026-07-20T19:10:15Z
expires_at: 2026-07-20T19:20:15Z
blocker: manual-release

repo: Scaled-Tech-Consulting/Gitea-Tools pr: #773 issue: #765 reviewer_identity: sysadmin profile: prgs-reviewer session_id: reviewer-773-765-4b0b18cf4d154c9c-1784574196 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-418 phase: released candidate_head: ad13d872df3ac22630617c4805832d0875e258a3 target_branch: master target_branch_sha: 0c2f45abb7c0db96c477e9a6db35a6728e654311 last_activity: 2026-07-20T19:10:15Z expires_at: 2026-07-20T19:20:15Z blocker: manual-release

sysadmin commented

2026-07-20 14:11:47 -05:00

Canonical Issue State

STATE: approved review posted to gitea at current head on PR #773; reviewer lease released; awaiting independent merger
WHO_IS_NEXT: merger
NEXT_ACTION: Merge PR #773 at exact reviewed head ad13d872df under prgs-merger after Gate Zero; re-verify approval_at_current_head before merge.
NEXT_PROMPT:

Role: MERGER (prgs-merger; identity must differ from author jcwalker3)
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
PR: #773 (Closes #765)
Approved head: ad13d872df3ac22630617c4805832d0875e258a3
Base: master 0c2f45abb7c0db96c477e9a6db35a6728e654311
Review id: 486 (sysadmin APPROVED; dismissed=false; stale=false; approval_at_current_head=true)

1. Gate Zero: control checkout == prgs/master; restart_required=false; stop_required=false.
2. Adopt/acquire merger lease pinned to ad13d872…; re-read live head.
3. Merge only if head still exact and approval_at_current_head remains true.
4. Terminal cleanup for this PR/issue only: leases, labels, worktrees, remote branch, handoff.
5. Restore/remove temporary symlink branches/mcp-author-clean-ns during terminal cleanup.
6. Preserve preserve/issue-765-d06198b until cleanup policy allows; do not touch #681 or preserve/issue-618-cbf56cc.
Do not re-author; do not force-push; do not redesign.

WHAT_HAPPENED: Independent formal review of PR #773 finished. Approved review posted to gitea (review_id=486) at head ad13d872. Readback: reviewed_head_sha exact, dismissed=false, stale=false, approval_at_current_head=true, has_blocking_change_requests=false. Reviewer lease released for session reviewer-773-765-4b0b18cf4d154c9c-1784574196. Merge not performed from reviewer role. No source or symlink modifications by reviewer.
WHY: Issue #765 foreign-lease exclusion is correctly implemented and independently confirmed; next actor is merger.
RELATED_PRS: #773 (open; Closes #765; head ad13d872df)
BLOCKERS: none
VALIDATION: focused suite 22 passed; related allocator/control-plane/dashboard suite 101 passed; full suite 3861 passed / 6 skipped / 11 failures baseline-proven on pristine master 0c2f45a; patch-id bacafc5f…; parent equals base 0c2f45a…; approval_at_current_head=true
NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=gitea_submit_pr_review; profile=prgs-reviewer; identity=sysadmin; session_id=reviewer-773-765-4b0b18cf4d154c9c-1784574196; head=ad13d872df3ac22630617c4805832d0875e258a3; review_id=486
LAST_UPDATED_BY: sysadmin / prgs-reviewer / LLM_LOCK_ID=reviewer-773-765-4b0b18cf4d154c9c-1784574196

[THREAD STATE LEDGER] PR #773 / Issue #765 — formal review complete; next role merger

What is true now:

PR state: open #773 head ad13d872… base master; mergeable
Issue state: open #765 with status:pr-open
Server-side decision state: approved review posted to gitea at current head (review_id=486); reviewer lease released
Local verdict/state: reviewer work for #773 only is finished; merge not performed; no source edits by reviewer
Latest known evidence: focused 22 passed; related 101 passed; full suite baseline-compared
Symlink branches/mcp-author-clean-ns still present (publication provenance); restore during terminal cleanup

What changed:

Acquired reviewer lease (comment 13365) on branches/review-418 at ad13d872
Completed independent AC/provenance/test/baseline review
Approved review posted to gitea (review_id=486) at exact head
Released reviewer lease (comment 13369)
Posted this handoff ledger

What is blocked:

Blocker classification: no blocker

Who/what acts next:

Next actor: merger
Required action: merge PR #773 at head ad13d872 after Gate Zero
Do not do: re-author without feedback; self-merge from author; merge from reviewer role; force-push; touch #681 / preserve/issue-618-cbf56cc; allocate unrelated work; remove preserve refs prematurely
Resume from: merger session at PR #773 head ad13d872

## Canonical Issue State STATE: approved review posted to gitea at current head on PR #773; reviewer lease released; awaiting independent merger WHO_IS_NEXT: merger NEXT_ACTION: Merge PR #773 at exact reviewed head ad13d872df3ac22630617c4805832d0875e258a3 under prgs-merger after Gate Zero; re-verify approval_at_current_head before merge. NEXT_PROMPT: ```text Role: MERGER (prgs-merger; identity must differ from author jcwalker3) Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools PR: #773 (Closes #765) Approved head: ad13d872df3ac22630617c4805832d0875e258a3 Base: master 0c2f45abb7c0db96c477e9a6db35a6728e654311 Review id: 486 (sysadmin APPROVED; dismissed=false; stale=false; approval_at_current_head=true) 1. Gate Zero: control checkout == prgs/master; restart_required=false; stop_required=false. 2. Adopt/acquire merger lease pinned to ad13d872…; re-read live head. 3. Merge only if head still exact and approval_at_current_head remains true. 4. Terminal cleanup for this PR/issue only: leases, labels, worktrees, remote branch, handoff. 5. Restore/remove temporary symlink branches/mcp-author-clean-ns during terminal cleanup. 6. Preserve preserve/issue-765-d06198b until cleanup policy allows; do not touch #681 or preserve/issue-618-cbf56cc. Do not re-author; do not force-push; do not redesign. ``` WHAT_HAPPENED: Independent formal review of PR #773 finished. Approved review posted to gitea (review_id=486) at head ad13d872. Readback: reviewed_head_sha exact, dismissed=false, stale=false, approval_at_current_head=true, has_blocking_change_requests=false. Reviewer lease released for session reviewer-773-765-4b0b18cf4d154c9c-1784574196. Merge not performed from reviewer role. No source or symlink modifications by reviewer. WHY: Issue #765 foreign-lease exclusion is correctly implemented and independently confirmed; next actor is merger. RELATED_PRS: #773 (open; Closes #765; head ad13d872df3ac22630617c4805832d0875e258a3) BLOCKERS: none VALIDATION: focused suite 22 passed; related allocator/control-plane/dashboard suite 101 passed; full suite 3861 passed / 6 skipped / 11 failures baseline-proven on pristine master 0c2f45a; patch-id bacafc5f…; parent equals base 0c2f45a…; approval_at_current_head=true NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=gitea_submit_pr_review; profile=prgs-reviewer; identity=sysadmin; session_id=reviewer-773-765-4b0b18cf4d154c9c-1784574196; head=ad13d872df3ac22630617c4805832d0875e258a3; review_id=486 LAST_UPDATED_BY: sysadmin / prgs-reviewer / LLM_LOCK_ID=reviewer-773-765-4b0b18cf4d154c9c-1784574196 --- [THREAD STATE LEDGER] PR #773 / Issue #765 — formal review complete; next role merger What is true now: - PR state: open #773 head ad13d872… base master; mergeable - Issue state: open #765 with status:pr-open - Server-side decision state: approved review posted to gitea at current head (review_id=486); reviewer lease released - Local verdict/state: reviewer work for #773 only is finished; merge not performed; no source edits by reviewer - Latest known evidence: focused 22 passed; related 101 passed; full suite baseline-compared - Symlink branches/mcp-author-clean-ns still present (publication provenance); restore during terminal cleanup What changed: - Acquired reviewer lease (comment 13365) on branches/review-418 at ad13d872 - Completed independent AC/provenance/test/baseline review - Approved review posted to gitea (review_id=486) at exact head - Released reviewer lease (comment 13369) - Posted this handoff ledger What is blocked: - Blocker classification: no blocker Who/what acts next: - Next actor: merger - Required action: merge PR #773 at head ad13d872 after Gate Zero - Do not do: re-author without feedback; self-merge from author; merge from reviewer role; force-push; touch #681 / preserve/issue-618-cbf56cc; allocate unrelated work; remove preserve refs prematurely - Resume from: merger session at PR #773 head ad13d872

jcwalker3 referenced this pull request

2026-07-20 14:24:06 -05:00

fix(mcp): recover clean unpublished author work after the owning session exits (Closes #772) #774

sysadmin commented

2026-07-20 14:24:38 -05:00

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #773
issue: #765
reviewer_identity: sysadmin
profile: prgs-merger
session_id: merger-pr773-5d38ffca5802435d-1784575439
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-pr-773
phase: claimed
candidate_head: ad13d872df
target_branch: master
target_branch_sha: 0c2f45abb7
last_activity: 2026-07-20T19:24:38Z
expires_at: 2026-07-20T19:34:38Z
blocker: none

repo: Scaled-Tech-Consulting/Gitea-Tools pr: #773 issue: #765 reviewer_identity: sysadmin profile: prgs-merger session_id: merger-pr773-5d38ffca5802435d-1784575439 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-pr-773 phase: claimed candidate_head: ad13d872df3ac22630617c4805832d0875e258a3 target_branch: master target_branch_sha: 0c2f45abb7c0db96c477e9a6db35a6728e654311 last_activity: 2026-07-20T19:24:38Z expires_at: 2026-07-20T19:34:38Z blocker: none

sysadmin merged commit ccfaa0ec0c into master

2026-07-20 14:24:59 -05:00

sysadmin commented

2026-07-20 14:25:01 -05:00

Stale #332 review-decision lock cleanup (#594)

Status: APPLIED

actor: sysadmin
profile: prgs-merger
timestamp: 2026-07-20T19:25:00.861282+00:00
last terminal: approve on PR fix: exclude foreign-claimed work from allocation (Closes #765) (#773)
PR state: closed (merged=True)
merge_commit_sha: ccfaa0ec0cb6c24159ae7795b51268289f04e9e5
prior live_mutations_count: 1
prior profile_identity: prgs-reviewer

Manual deletion of session-state files is not the workflow.
This path only clears a lock when the referenced PR is merged/closed.

## Stale #332 review-decision lock cleanup (#594) Status: **APPLIED** - actor: `sysadmin` - profile: `prgs-merger` - timestamp: `2026-07-20T19:25:00.861282+00:00` - last terminal: `approve` on PR #773 - PR state: `closed` (merged=True) - merge_commit_sha: `ccfaa0ec0cb6c24159ae7795b51268289f04e9e5` - prior live_mutations_count: `1` - prior profile_identity: `prgs-reviewer` Manual deletion of session-state files is **not** the workflow. This path only clears a lock when the referenced PR is merged/closed.

sysadmin commented

2026-07-20 14:34:24 -05:00

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #773
issue: #765
reviewer_identity: sysadmin
profile: prgs-merger
session_id: merger-pr773-5d38ffca5802435d-1784575439
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-pr-773
phase: released
candidate_head: ad13d872df
target_branch: master
target_branch_sha: 0c2f45abb7
last_activity: 2026-07-20T19:34:22Z
expires_at: 2026-07-20T19:44:22Z
blocker: post-merge-moot

repo: Scaled-Tech-Consulting/Gitea-Tools pr: #773 issue: #765 reviewer_identity: sysadmin profile: prgs-merger session_id: merger-pr773-5d38ffca5802435d-1784575439 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-pr-773 phase: released candidate_head: ad13d872df3ac22630617c4805832d0875e258a3 target_branch: master target_branch_sha: 0c2f45abb7c0db96c477e9a6db35a6728e654311 last_activity: 2026-07-20T19:34:22Z expires_at: 2026-07-20T19:44:22Z blocker: post-merge-moot

sysadmin commented

2026-07-20 14:37:40 -05:00

Canonical Issue State

STATE: terminal cleanup completed for merged PR #773 / closed Issue #765
WHO_IS_NEXT: controller
NEXT_ACTION: no further #773/#765 cleanup required; optional follow-up only if a sanctioned symlink/file-lock cleanup capability is added
NEXT_PROMPT:

No action required for PR #773 / Issue #765. Bundle is terminal.
Optional later: sanctioned cleanup of dangling branches/mcp-author-clean-ns symlink and dead-owner file lock for #765 if tools become available.
Do not re-merge, re-review, re-author, or touch Issue #772 / PR #774.

WHAT_HAPPENED: Supervised terminal cleanup by prgs-reconciler / sysadmin (LLM_LOCK_ID=reconciler-773-765-011d9db842544dda8f5db07a206d490b). Gate Zero held at master ccfaa0ec0c (restart_required=false, stop_required=false, clean control checkout).

Merger lease comment 13395 session merger-pr773-5d38ffca5802435d-1784575439 head ad13d872: dry-run cleanup_allowed=true then apply → released marker comment 13405 (post-merge-moot). No active PR lease remains.
No control-plane workflow lease for work #765. File issue-lock for #765 left intact (owner pid 43118 dead; not hand-edited).
Issue #765 labels: removed status:pr-open. Final: anti-stomp, mcp-health, type:bug, workflow-hardening.
Removed non-force worktrees: branches/merge-pr-773, branches/review-pr-773, branches/issue-765-allocator-ownership.
Deleted remote branch fix/issue-765-allocator-foreign-lease via gitea_cleanup_merged_pr_branch (verified absent). Local branch -d after worktree gone.
preserve/issue-765-d06198b preserved. branches/mcp-author-clean-ns preserved (no sanctioned symlink tool; now dangling after target removal).

WHY: Post-merge terminal cleanup for the #773/#765 bundle only.
RELATED_PRS: #773 (merged; this thread)
BLOCKERS: none for terminal state; residual capability gaps: no sanctioned unlock for dead-owner file issue-lock; no sanctioned symlink restore/remove (mcp-author-clean-ns preserved dangling)
VALIDATION: PR closed/merged with merge_commit ccfaa0ec0cb6… and head ad13d872…; Issue #765 closed; merger lease active_lease=null; remote branch verified_absent; local branch deleted; merge/review/author worktrees absent; control checkout clean at ccfaa0e…; #772/#774 worktrees untouched
LAST_UPDATED_BY: sysadmin / prgs-reconciler / LLM_LOCK_ID=reconciler-773-765-011d9db842544dda8f5db07a206d490b

## Canonical Issue State STATE: terminal cleanup completed for merged PR #773 / closed Issue #765 WHO_IS_NEXT: controller NEXT_ACTION: no further #773/#765 cleanup required; optional follow-up only if a sanctioned symlink/file-lock cleanup capability is added NEXT_PROMPT: ```text No action required for PR #773 / Issue #765. Bundle is terminal. Optional later: sanctioned cleanup of dangling branches/mcp-author-clean-ns symlink and dead-owner file lock for #765 if tools become available. Do not re-merge, re-review, re-author, or touch Issue #772 / PR #774. ``` WHAT_HAPPENED: Supervised terminal cleanup by prgs-reconciler / sysadmin (LLM_LOCK_ID=reconciler-773-765-011d9db842544dda8f5db07a206d490b). Gate Zero held at master ccfaa0ec0cb6c24159ae7795b51268289f04e9e5 (restart_required=false, stop_required=false, clean control checkout). 1. Merger lease comment 13395 session merger-pr773-5d38ffca5802435d-1784575439 head ad13d872: dry-run cleanup_allowed=true then apply → released marker comment 13405 (post-merge-moot). No active PR lease remains. 2. No control-plane workflow lease for work #765. File issue-lock for #765 left intact (owner pid 43118 dead; not hand-edited). 3. Issue #765 labels: removed status:pr-open. Final: anti-stomp, mcp-health, type:bug, workflow-hardening. 4. Removed non-force worktrees: branches/merge-pr-773, branches/review-pr-773, branches/issue-765-allocator-ownership. 5. Deleted remote branch fix/issue-765-allocator-foreign-lease via gitea_cleanup_merged_pr_branch (verified absent). Local branch -d after worktree gone. 6. preserve/issue-765-d06198b preserved. branches/mcp-author-clean-ns preserved (no sanctioned symlink tool; now dangling after target removal). WHY: Post-merge terminal cleanup for the #773/#765 bundle only. RELATED_PRS: #773 (merged; this thread) BLOCKERS: none for terminal state; residual capability gaps: no sanctioned unlock for dead-owner file issue-lock; no sanctioned symlink restore/remove (mcp-author-clean-ns preserved dangling) VALIDATION: PR closed/merged with merge_commit ccfaa0ec0cb6… and head ad13d872…; Issue #765 closed; merger lease active_lease=null; remote branch verified_absent; local branch deleted; merge/review/author worktrees absent; control checkout clean at ccfaa0e…; #772/#774 worktrees untouched LAST_UPDATED_BY: sysadmin / prgs-reconciler / LLM_LOCK_ID=reconciler-773-765-011d9db842544dda8f5db07a206d490b

sysadmin referenced this pull request

2026-07-20 14:40:17 -05:00

fix(mcp): recover clean unpublished author work after the owning session exits (Closes #772) #774

sysadmin referenced this pull request

2026-07-20 14:44:07 -05:00

fix(mcp): recover clean unpublished author work after the owning session exits #772

jcwalker3 referenced this pull request

2026-07-20 15:15:56 -05:00

fix(mcp): recover clean unpublished author work after the owning session exits (Closes #772) #774

jcwalker3 referenced this pull request

2026-07-20 15:39:46 -05:00

fix(mcp): recover clean unpublished author work after the owning session exits (Closes #772) #774