Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 77 Pull Requests 10 Actions Packages Projects Releases Wiki Activity

[workflow][bug] Fail closed when queued commands conflict with the latest operator instruction #712

New Issue
Open
opened 2026-07-14 19:53:06 -05:00 by jcwalker3 · 2 comments
jcwalker3 commented 2026-07-14 19:53:06 -05:00
Owner
Copy Link
Copy Source

Problem:
During an eAgenda recovery operation, an earlier proposed command block was executed after a later operator instruction explicitly rejected it.

The stale command block deleted:

  • feature/guided-source-setup
  • preservation/guided-source-setup-d72042b

The preservation pointer was successfully recreated at the original SHA:
d72042b7b553b371b9b99fdeb5eacd5ea6ebad00

No commit content was lost. However, successful manual recovery does not remove the underlying workflow defect: commands containing destructive operations were executed from superseded context despite an explicit current instruction not to execute them.

Impact:

  • A stale command can override the latest operator decision.
  • Branches preserving unique or rejected work can be deleted.
  • Recovery may be impossible if the deleted commit becomes unreachable.
  • The current branches-only guard does not prevent unsafe branch deletion.
  • Multi-LLM sessions are especially vulnerable when proposed commands remain visible after authorization changes.

Required behavior:

  • The most recent operator instruction must supersede earlier proposed commands.
  • Commands proposed under a previous approval state must become invalid after rejection, replacement, or material plan changes.
  • Before executing a command batch, re-evaluate it against the latest instructions.
  • Fail closed when a batch includes an operation currently prohibited by the operator.
  • Treat destructive or history-affecting Git operations as requiring fresh validation, including:
    • git branch -D
    • git reset --hard
    • git clean
    • forced checkout/restore
    • worktree removal
    • deletion of preservation, recovery, or unmerged branches
  • Do not execute an entire earlier code block merely because it was previously displayed.
  • Detect conflicting statements such as:
    • earlier: “proposed commands, not executed”;
    • later: “do not run these commands.”
  • Require proof that preservation exists before allowing deletion of the final reference to an unmerged commit.
  • Preserve an audit record showing which instruction authorized each destructive operation.
  • Return BLOCKED + DIAGNOSE when authorization is stale, conflicting, or absent.

Regression scenario:

  1. An agent proposes deleting two branches but does not execute it.
  2. The operator rejects that plan and explicitly says not to delete them.
  3. The agent later receives a recovery task.
  4. The stale deletion block remains in conversation context.
  5. The workflow must block execution of that stale block.
  6. The latest explicit prohibition must win.

Acceptance criteria:

  1. Superseded command batches cannot execute.
  2. Explicit current prohibitions override earlier proposals or approvals.
  3. Destructive Git commands require validation against the latest authorization state immediately before execution.
  4. Preservation/recovery branches cannot be deleted without verified alternate retention and current authorization.
  5. Mixed command batches fail before any destructive segment runs.
  6. The failure reports the conflicting current instruction.
  7. Tests reproduce this incident and prove both branches remain intact.
  8. The protection works across repositories and LLM clients.
  9. The audit log records the command, current authorization source, decision, and reason.
  10. Documentation instructs agents to execute only the current approved recovery plan.

Incident evidence:

  • Repository involved: eAgenda.
  • Rejected implementation commit: d72042b7b553b371b9b99fdeb5eacd5ea6ebad00.
  • Both branch pointers were deleted by a stale command batch.
  • The preservation branch was recreated at the original SHA.
  • The unique roadmap blob was verified and no content was lost.
  • The eAgenda control checkout was restored to clean main.
Problem: During an eAgenda recovery operation, an earlier proposed command block was executed after a later operator instruction explicitly rejected it. The stale command block deleted: - `feature/guided-source-setup` - `preservation/guided-source-setup-d72042b` The preservation pointer was successfully recreated at the original SHA: `d72042b7b553b371b9b99fdeb5eacd5ea6ebad00` No commit content was lost. However, successful manual recovery does not remove the underlying workflow defect: commands containing destructive operations were executed from superseded context despite an explicit current instruction not to execute them. Impact: - A stale command can override the latest operator decision. - Branches preserving unique or rejected work can be deleted. - Recovery may be impossible if the deleted commit becomes unreachable. - The current branches-only guard does not prevent unsafe branch deletion. - Multi-LLM sessions are especially vulnerable when proposed commands remain visible after authorization changes. Required behavior: - The most recent operator instruction must supersede earlier proposed commands. - Commands proposed under a previous approval state must become invalid after rejection, replacement, or material plan changes. - Before executing a command batch, re-evaluate it against the latest instructions. - Fail closed when a batch includes an operation currently prohibited by the operator. - Treat destructive or history-affecting Git operations as requiring fresh validation, including: - `git branch -D` - `git reset --hard` - `git clean` - forced checkout/restore - worktree removal - deletion of preservation, recovery, or unmerged branches - Do not execute an entire earlier code block merely because it was previously displayed. - Detect conflicting statements such as: - earlier: “proposed commands, not executed”; - later: “do not run these commands.” - Require proof that preservation exists before allowing deletion of the final reference to an unmerged commit. - Preserve an audit record showing which instruction authorized each destructive operation. - Return BLOCKED + DIAGNOSE when authorization is stale, conflicting, or absent. Regression scenario: 1. An agent proposes deleting two branches but does not execute it. 2. The operator rejects that plan and explicitly says not to delete them. 3. The agent later receives a recovery task. 4. The stale deletion block remains in conversation context. 5. The workflow must block execution of that stale block. 6. The latest explicit prohibition must win. Acceptance criteria: 1. Superseded command batches cannot execute. 2. Explicit current prohibitions override earlier proposals or approvals. 3. Destructive Git commands require validation against the latest authorization state immediately before execution. 4. Preservation/recovery branches cannot be deleted without verified alternate retention and current authorization. 5. Mixed command batches fail before any destructive segment runs. 6. The failure reports the conflicting current instruction. 7. Tests reproduce this incident and prove both branches remain intact. 8. The protection works across repositories and LLM clients. 9. The audit log records the command, current authorization source, decision, and reason. 10. Documentation instructs agents to execute only the current approved recovery plan. Incident evidence: - Repository involved: eAgenda. - Rejected implementation commit: `d72042b7b553b371b9b99fdeb5eacd5ea6ebad00`. - Both branch pointers were deleted by a stale command batch. - The preservation branch was recreated at the original SHA. - The unique roadmap blob was verified and no content was lost. - The eAgenda control checkout was restored to clean `main`.
jcwalker3 commented 2026-07-14 19:58:20 -05:00
Author
Owner
Copy Link
Copy Source

Cross-link: branches-only guard bypass observed while creating this issue

While creating this issue (#712), a branches-only mutation guard block was followed by:

mkdir -p /Users/jasonwalker/Development/Gitea-Tools/branches/issue-creation-dummy

and a successful gitea_create_issue retry.

Diagnosis (no code changes): the residual path is an empty, unregistered arbitrary directory under branches/. Current guard logic accepts path-prefix + existence + git walk-up membership, and does not require git worktree list registration proof.

Tracked separately as #713 (do not fold into this issue's supersession/command-queue defect).

#712 body/scope intentionally left unchanged beyond this cross-link.

## Cross-link: branches-only guard bypass observed while creating this issue While creating this issue (#712), a branches-only mutation guard block was followed by: ```text mkdir -p /Users/jasonwalker/Development/Gitea-Tools/branches/issue-creation-dummy ``` and a successful `gitea_create_issue` retry. Diagnosis (no code changes): the residual path is an **empty, unregistered arbitrary directory** under `branches/`. Current guard logic accepts path-prefix + existence + git walk-up membership, and does **not** require `git worktree list` registration proof. Tracked separately as **#713** (do not fold into this issue's supersession/command-queue defect). #712 body/scope intentionally left unchanged beyond this cross-link.
jcwalker3 commented 2026-07-15 13:41:20 -05:00
Author
Owner
Copy Link
Copy Source

Adding evidence from recent eAgenda recovery operation:

During an eAgenda recovery operation, an earlier proposed command block was executed after a later operator instruction explicitly rejected it.

The stale command block deleted:

  • feature/guided-source-setup
  • preservation/guided-source-setup-d72042b

The preservation pointer was successfully recreated at the original SHA:
d72042b7b553b371b9b99fdeb5eacd5ea6ebad00

No commit content was lost. However, successful manual recovery does not remove the underlying workflow defect. We must fail closed when queued commands conflict with the latest operator instruction.

Adding evidence from recent eAgenda recovery operation: During an eAgenda recovery operation, an earlier proposed command block was executed after a later operator instruction explicitly rejected it. The stale command block deleted: - `feature/guided-source-setup` - `preservation/guided-source-setup-d72042b` The preservation pointer was successfully recreated at the original SHA: `d72042b7b553b371b9b99fdeb5eacd5ea6ebad00` No commit content was lost. However, successful manual recovery does not remove the underlying workflow defect. We must fail closed when queued commands conflict with the latest operator instruction.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels anti-stomp incident recovery status:ready type:bug workflow-hardening
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#712