feat: validate Selected PR: none in cleanup mode when queue is empty #576

2026-07-08T22:40:14-05:00

jcwalker3 commented

2026-07-08 22:40:14 -05:00

This PR updates the pr-queue-cleanup validator to allow Selected PR: none when the PR queue is verified empty, closing issue #572 fallback logic. Stacked on #573.

jcwalker3 added 1 commit 2026-07-08 22:40:15 -05:00

feat: validate Selected PR: none in cleanup mode when queue is empty a82d35f8bd

sysadmin commented

2026-07-08 22:57:55 -05:00

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #576
issue: #572
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 14751-c81527d52e62
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr576-issue-572
phase: claimed
candidate_head: a82d35f8bd
target_branch: master
target_branch_sha: 4d865666c7
last_activity: 2026-07-09T03:57:55Z
expires_at: 2026-07-09T05:57:55Z
blocker: none

repo: Scaled-Tech-Consulting/Gitea-Tools pr: #576 issue: #572 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 14751-c81527d52e62 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr576-issue-572 phase: claimed candidate_head: a82d35f8bd87c1d42b6a64f6478ac2f2f90b227a target_branch: master target_branch_sha: 4d865666c78b0a3fbc955eed1a849c9e7932c668 last_activity: 2026-07-09T03:57:55Z expires_at: 2026-07-09T05:57:55Z blocker: none

sysadmin approved these changes 2026-07-08 22:58:30 -05:00

sysadmin left a comment

Review (PR #576)

Scope: Empty-queue cleanup fallback — allow Selected PR: none only when the report also carries a valid empty-queue claim; reject none-without-evidence and contradictory selected+# vs none.

Diff: 2 files only (pr_queue_cleanup.py, tests/test_pr_queue_cleanup.py).

Validation (worktree branches/review-pr576-issue-572 @ a82d35f8bd87c1d42b6a64f6478ac2f2f90b227a):

git diff --check prgs/master...HEAD clean
pytest tests/test_pr_queue_cleanup.py -q → 30 passed
Not already landed on prgs/master (4d865666c78b0a3fbc955eed1a849c9e7932c668)
Live mergeable=true; no prior REQUEST_CHANGES
Author jcwalker3 ≠ reviewer sysadmin (self-review N/A)

Decision: APPROVE

Merge: Blocked in this session — prgs-reviewer forbids gitea.pr.merge. Handoff to prgs-merger with confirmation MERGE PR 576 and expected_head_sha=a82d35f8bd87c1d42b6a64f6478ac2f2f90b227a.

## Review (PR #576) **Scope:** Empty-queue cleanup fallback — allow `Selected PR: none` only when the report also carries a valid empty-queue claim; reject none-without-evidence and contradictory selected+# vs none. **Diff:** 2 files only (`pr_queue_cleanup.py`, `tests/test_pr_queue_cleanup.py`). **Validation (worktree `branches/review-pr576-issue-572` @ `a82d35f8bd87c1d42b6a64f6478ac2f2f90b227a`):** - `git diff --check prgs/master...HEAD` clean - `pytest tests/test_pr_queue_cleanup.py -q` → **30 passed** - Not already landed on `prgs/master` (`4d865666c78b0a3fbc955eed1a849c9e7932c668`) - Live `mergeable=true`; no prior REQUEST_CHANGES - Author `jcwalker3` ≠ reviewer `sysadmin` (self-review N/A) **Decision:** APPROVE **Merge:** Blocked in this session — `prgs-reviewer` forbids `gitea.pr.merge`. Handoff to `prgs-merger` with confirmation `MERGE PR 576` and `expected_head_sha=a82d35f8bd87c1d42b6a64f6478ac2f2f90b227a`.

sysadmin commented

2026-07-08 23:01:03 -05:00

adopted_at: 2026-07-09T04:01:03Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 14751-c81527d52e62
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 7781
adoption_reason: merger-handoff-approved-head

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #576
issue: #572
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 14747-6ff77670f3b6
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-pr576-issue-572
phase: adopted
candidate_head: a82d35f8bd
target_branch: master
target_branch_sha: 4d865666c7
last_activity: 2026-07-09T04:01:03Z
expires_at: 2026-07-09T06:01:03Z
blocker: none

adopted_at: 2026-07-09T04:01:03Z adopted_by_identity: sysadmin adopted_by_profile: prgs-merger adopted_from_session_id: 14751-c81527d52e62 adopted_from_profile: prgs-reviewer adopted_from_reviewer_identity: sysadmin adopted_from_comment_id: 7781 adoption_reason: merger-handoff-approved-head  repo: Scaled-Tech-Consulting/Gitea-Tools pr: #576 issue: #572 reviewer_identity: sysadmin profile: prgs-merger session_id: 14747-6ff77670f3b6 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-pr576-issue-572 phase: adopted candidate_head: a82d35f8bd87c1d42b6a64f6478ac2f2f90b227a target_branch: master target_branch_sha: 4d865666c78b0a3fbc955eed1a849c9e7932c668 last_activity: 2026-07-09T04:01:03Z expires_at: 2026-07-09T06:01:03Z blocker: none

sysadmin merged commit 08957aeb2a into master

2026-07-08 23:01:12 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#576