Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Restore gitea_lock_issue MCP tool registration for author create_pr flow #521

New Issue
Closed
opened 2026-07-08 03:35:49 -05:00 by jcwalker3 · 2 comments
jcwalker3 commented 2026-07-08 03:35:49 -05:00
Owner
Copy Link
Copy Source

Problem:
The author create_pr flow is globally blocked because gitea_create_pr requires an issue lock, but gitea_lock_issue is not registered as an MCP tool in the current server/toolset.

Observed on pristine master:

  • @mcp.tool() is attached to _list_open_pulls, an internal helper.
  • gitea_lock_issue has no @mcp.tool() decorator.
  • ToolSearch finds gitea_lock_issue in no namespace.
  • _save_issue_lock is only called inside gitea_lock_issue.
  • No CLI wrapper or alternate exposed MCP tool sets the required issue lock.
  • Result: gitea_create_pr fails closed with “Issue lock is missing. Call gitea_lock_issue first.”

Impact:
Author sessions can create/claim/implement/push branches, but cannot create PRs through the gated MCP path. This blocks the normal issue-backed PR workflow globally.

Acceptance criteria:

  1. Register gitea_lock_issue as an MCP tool in the appropriate author namespace.
  2. Ensure _list_open_pulls is not accidentally exposed as a public MCP tool unless intentionally supported.
  3. Add a regression test proving gitea_lock_issue is present in the MCP tool registry.
  4. Add a regression test proving create_pr can proceed after a valid issue lock is acquired.
  5. Add a regression test proving create_pr still fails closed when the issue lock is missing.
  6. Confirm the fix does not widen lock authority across author/reviewer/merger/reconciler roles.
  7. Update any runbook guidance if the lock/create_pr sequence changed.
Problem: The author create_pr flow is globally blocked because gitea_create_pr requires an issue lock, but gitea_lock_issue is not registered as an MCP tool in the current server/toolset. Observed on pristine master: - @mcp.tool() is attached to _list_open_pulls, an internal helper. - gitea_lock_issue has no @mcp.tool() decorator. - ToolSearch finds gitea_lock_issue in no namespace. - _save_issue_lock is only called inside gitea_lock_issue. - No CLI wrapper or alternate exposed MCP tool sets the required issue lock. - Result: gitea_create_pr fails closed with “Issue lock is missing. Call gitea_lock_issue first.” Impact: Author sessions can create/claim/implement/push branches, but cannot create PRs through the gated MCP path. This blocks the normal issue-backed PR workflow globally. Acceptance criteria: 1. Register gitea_lock_issue as an MCP tool in the appropriate author namespace. 2. Ensure _list_open_pulls is not accidentally exposed as a public MCP tool unless intentionally supported. 3. Add a regression test proving gitea_lock_issue is present in the MCP tool registry. 4. Add a regression test proving create_pr can proceed after a valid issue lock is acquired. 5. Add a regression test proving create_pr still fails closed when the issue lock is missing. 6. Confirm the fix does not widen lock authority across author/reviewer/merger/reconciler roles. 7. Update any runbook guidance if the lock/create_pr sequence changed.
jcwalker3 added the status:in-progress label 2026-07-08 03:41:37 -05:00
jcwalker3 commented 2026-07-08 03:41:37 -05:00
Author
Owner
Copy Link
Copy Source

Issue claim heartbeat

<!-- gitea-issue-claim-heartbeat:v1 --> **Issue claim heartbeat** - kind: claim - issue: #521 - branch: feat/issue-521-lock-issue-registration - phase: claimed - profile: prgs-author - pr: none - blocker: none - next_action: create worktree and begin implementation
jcwalker3 commented 2026-07-08 03:42:46 -05:00
Author
Owner
Copy Link
Copy Source

Issue claim heartbeat

<!-- gitea-issue-claim-heartbeat:v1 --> **Issue claim heartbeat** - kind: progress - issue: #521 - branch: feat/issue-521-lock-issue-registration - phase: create_pr - profile: prgs-author - pr: none - blocker: none - next_action: open pull request
sysadmin removed the status:in-progress label 2026-07-08 03:50:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#521