Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Fix gitea_assess_conflict_fix_push HTTP 500 "issue does not exist" on valid conflict-fix push #519

New Issue
Closed
opened 2026-07-08 03:22:17 -05:00 by jcwalker3 · 3 comments
jcwalker3 commented 2026-07-08 03:22:17 -05:00
Owner
Copy Link
Copy Source

Problem:
During PR #508 conflict resolution, the author pushed a valid fast-forward conflict-fix commit to prgs/feat/issue-503-reviewer-active-worktree. The push succeeded, but gitea_assess_conflict_fix_push returned HTTP 500 with error text "issue does not exist".

This makes the conflict-resolution workflow unreliable because the tool fails instead of producing a clear assessment of the pushed fix.

Observed context:

Required behavior:

  • gitea_assess_conflict_fix_push should correctly resolve the PR and linked issue for a valid conflict-fix branch.
  • It should not throw HTTP 500 for ordinary missing/ambiguous issue resolution.
  • If the linked issue cannot be found, it should fail closed with a structured, actionable error explaining which identifier failed.
  • It should distinguish tool failure from invalid author behavior.
  • Add regression tests using a PR branch with a valid conflict-fix push.

Acceptance criteria:

  1. Reproduce the failing lookup path with a test.
  2. Fix issue/PR resolution inside gitea_assess_conflict_fix_push.
  3. Return structured fail-closed output instead of HTTP 500 when issue resolution fails.
  4. Confirm valid conflict-fix pushes return an assessment result.
  5. Add/update documentation or handoff guidance for conflict-fix assessment failures.
Problem: During PR #508 conflict resolution, the author pushed a valid fast-forward conflict-fix commit to prgs/feat/issue-503-reviewer-active-worktree. The push succeeded, but gitea_assess_conflict_fix_push returned HTTP 500 with error text "issue does not exist". This makes the conflict-resolution workflow unreliable because the tool fails instead of producing a clear assessment of the pushed fix. Observed context: - PR: #508 - Branch: feat/issue-503-reviewer-active-worktree - Push: dad1dc8 → 3f3d6cb - Push was fast-forward; no force-push - MCP/Gitea mutations from the assessment tool: none - Error: HTTP 500, "issue does not exist" Required behavior: - gitea_assess_conflict_fix_push should correctly resolve the PR and linked issue for a valid conflict-fix branch. - It should not throw HTTP 500 for ordinary missing/ambiguous issue resolution. - If the linked issue cannot be found, it should fail closed with a structured, actionable error explaining which identifier failed. - It should distinguish tool failure from invalid author behavior. - Add regression tests using a PR branch with a valid conflict-fix push. Acceptance criteria: 1. Reproduce the failing lookup path with a test. 2. Fix issue/PR resolution inside gitea_assess_conflict_fix_push. 3. Return structured fail-closed output instead of HTTP 500 when issue resolution fails. 4. Confirm valid conflict-fix pushes return an assessment result. 5. Add/update documentation or handoff guidance for conflict-fix assessment failures.
jcwalker3 added the status:in-progress label 2026-07-08 03:31:21 -05:00
jcwalker3 commented 2026-07-08 03:31:22 -05:00
Author
Owner
Copy Link
Copy Source

Issue claim heartbeat

<!-- gitea-issue-claim-heartbeat:v1 --> **Issue claim heartbeat** - kind: claim - issue: #519 - branch: pending - phase: claimed - profile: prgs-author - pr: none - blocker: none - next_action: create worktree and begin implementation
jcwalker3 commented 2026-07-08 03:34:16 -05:00
Author
Owner
Copy Link
Copy Source

Issue claim heartbeat

<!-- gitea-issue-claim-heartbeat:v1 --> **Issue claim heartbeat** - kind: progress - issue: #519 - branch: feat/issue-519-conflict-fix-push-assessment - phase: create_pr - profile: prgs-author - pr: none - blocker: none - next_action: open pull request
jcwalker3 commented 2026-07-08 03:34:30 -05:00
Author
Owner
Copy Link
Copy Source

Issue claim heartbeat

<!-- gitea-issue-claim-heartbeat:v1 --> **Issue claim heartbeat** - kind: progress - issue: #519 - branch: feat/issue-519-conflict-fix-push-assessment - phase: pr_open - profile: prgs-author - pr: 520 - blocker: none - next_action: await reviewer
sysadmin removed the status:in-progress label 2026-07-08 21:11:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#519