Block raw git branch-delete bypass outside authorized cleanup roles #514

New Issue

2026-07-08T03:07:35-05:00

jcwalker3 commented

2026-07-08 03:07:35 -05:00

Problem

A reviewer session performed post-merge source branch cleanup for PR #487 by running raw git commands:

git branch -d feat/issue-485-lease-comments-non-list-guard
git push prgs --delete feat/issue-485-lease-comments-non-list-guard

Even if the cleanup target was correct, raw git branch deletion bypasses MCP role/capability gates such as branch.delete and can mutate local/remote repository state from the wrong role/session. This creates a hole in the intended author/reviewer/merger/reconciler separation.

Required behavior

Branch deletion must be performed only through an explicit MCP tool or approved cleanup helper.
The operation must require an authorized role/capability, such as merger or reconciler cleanup, not reviewer by default.
Raw git push --delete should be detected or blocked in guarded workflows where possible.
Root checkout must not be used for mutating branch refs unless explicitly allowed by policy.
Reports must distinguish review mutations from cleanup mutations.

Acceptance criteria

Add a guarded branch cleanup path for merged PR source branches.
Fail closed when a reviewer profile attempts branch deletion without explicit branch.delete authority.
Add tests proving raw/git-style branch deletion is not treated as acceptable proof of authorized cleanup.
Add tests proving post-merge branch cleanup succeeds through the authorized path.
Update handoff/report guidance so reviewers do not perform branch pruning as part of PR review.

## Problem A reviewer session performed post-merge source branch cleanup for PR #487 by running raw git commands: - `git branch -d feat/issue-485-lease-comments-non-list-guard` - `git push prgs --delete feat/issue-485-lease-comments-non-list-guard` Even if the cleanup target was correct, raw git branch deletion bypasses MCP role/capability gates such as `branch.delete` and can mutate local/remote repository state from the wrong role/session. This creates a hole in the intended author/reviewer/merger/reconciler separation. ## Required behavior - Branch deletion must be performed only through an explicit MCP tool or approved cleanup helper. - The operation must require an authorized role/capability, such as merger or reconciler cleanup, not reviewer by default. - Raw `git push --delete` should be detected or blocked in guarded workflows where possible. - Root checkout must not be used for mutating branch refs unless explicitly allowed by policy. - Reports must distinguish review mutations from cleanup mutations. ## Acceptance criteria 1. Add a guarded branch cleanup path for merged PR source branches. 2. Fail closed when a reviewer profile attempts branch deletion without explicit `branch.delete` authority. 3. Add tests proving raw/git-style branch deletion is not treated as acceptable proof of authorized cleanup. 4. Add tests proving post-merge branch cleanup succeeds through the authorized path. 5. Update handoff/report guidance so reviewers do not perform branch pruning as part of PR review.

jcwalker3 added the status:in-progress label 2026-07-08 03:08:11 -05:00

jcwalker3 commented

2026-07-08 03:08:12 -05:00

Issue claim heartbeat

kind: claim
issue: Block raw git branch-delete bypass outside authorized cleanup roles (#514)
branch: feat/issue-514-branch-delete-guard
phase: claimed
profile: prgs-author
pr: none
blocker: none
next_action: create worktree and begin implementation

**Issue claim heartbeat** - kind: claim - issue: #514 - branch: feat/issue-514-branch-delete-guard - phase: claimed - profile: prgs-author - pr: none - blocker: none - next_action: create worktree and begin implementation

jcwalker3 referenced this issue from a commit

2026-07-08 03:18:22 -05:00

feat: guard merged branch cleanup path

jcwalker3 referenced a pull request that will close this issue

2026-07-08 03:18:46 -05:00

feat: guard merged branch cleanup path #516

sysadmin referenced a pull request that will close this issue

2026-07-08 13:05:00 -05:00

Detect stale MCP runtime before mutation tools execute #545

jcwalker3 referenced this issue

2026-07-08 14:30:08 -05:00

Require BLOCKED + DIAGNOSE when LLM cannot perform required workflow step #552

sysadmin closed this issue