feat: require validation cwd and HEAD proof in reviewer reports (Closes #398) #411

2026-07-07T10:28:45-05:00

jcwalker3 commented

2026-07-07 10:28:45 -05:00

Summary

Closes #398.

Reviewer reports can claim PR-head validation without proving the command ran in the review worktree. This PR adds cwd/HEAD proof enforcement.

Changes

reviewer_validation_cwd_proof.py — verifier for pwd, HEAD SHA, git status, and explicit cwd in validation commands
final_report_validator.py — reviewer.validation_cwd_proof rule
gitea_validate_review_final_report — accepts validation_session
review-merge-pr.md — §23 cwd/HEAD proof requirements + handoff field
Tests: tests/test_reviewer_validation_cwd_proof.py (9 cases)

Validation

venv/bin/python -m pytest tests/test_reviewer_validation_cwd_proof.py tests/test_final_report_validator.py -q

43 passed

Worktree

branches/issue-398-validation-cwd-proof @ 8df795e

## Summary Closes #398. Reviewer reports can claim PR-head validation without proving the command ran in the review worktree. This PR adds cwd/HEAD proof enforcement. ## Changes - `reviewer_validation_cwd_proof.py` — verifier for pwd, HEAD SHA, git status, and explicit cwd in validation commands - `final_report_validator.py` — `reviewer.validation_cwd_proof` rule - `gitea_validate_review_final_report` — accepts `validation_session` - `review-merge-pr.md` — §23 cwd/HEAD proof requirements + handoff field - Tests: `tests/test_reviewer_validation_cwd_proof.py` (9 cases) ## Validation ``` venv/bin/python -m pytest tests/test_reviewer_validation_cwd_proof.py tests/test_final_report_validator.py -q ``` **43 passed** ## Worktree `branches/issue-398-validation-cwd-proof` @ `8df795e`

jcwalker3 added 1 commit 2026-07-07 12:10:04 -05:00

feat: require validation cwd and HEAD proof in reviewer reports (Closes #398 ) 1320a55a7e

Rebased onto current prgs/master; merged with #396 validation failure
history by keeping both validator rules and workflow handoff fields.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 force-pushed feat/issue-398-validation-cwd-proof from 8df795ef80 to 1320a55a7e

2026-07-07 12:10:04 -05:00

Compare

jcwalker3 commented

2026-07-08 01:20:12 -05:00

pr: #411
branch: feat/issue-398-validation-cwd-proof
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-pr411-conflicts
profile: prgs-author
session_id: unknown
phase: claimed
head_before: 1320a55a7e
expires_at: 2026-07-08T08:20:12Z
reviewer_active: no

pr: #411 branch: feat/issue-398-validation-cwd-proof worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-pr411-conflicts profile: prgs-author session_id: unknown phase: claimed head_before: 1320a55a7ea255375889f89fb102a13e74fc2573 expires_at: 2026-07-08T08:20:12Z reviewer_active: no

jcwalker3 added 1 commit 2026-07-08 01:20:38 -05:00

fix: resolve conflicts for PR #411 28f0f84de8

jcwalker3 referenced this issue from a commit

2026-07-08 01:20:38 -05:00

fix: resolve conflicts for PR #411

sysadmin approved these changes 2026-07-08 01:58:49 -05:00

sysadmin left a comment

APPROVED: PR #411 implements the required validation cwd and HEAD proof verifications for review final reports. Integration and tests are verified clean.

sysadmin merged commit 48cf3a334b into master

2026-07-08 02:09:11 -05:00

sysadmin referenced this pull request

2026-07-08 02:24:27 -05:00

fix: exempt reconciler close_pr from branches-only worktree guard (Closes #468) #472

jcwalker3 referenced this pull request

2026-07-08 02:25:00 -05:00

Reject reviewer handoffs with contradictory mutation ledger or ambiguous final decision state #501

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#411