Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

feat: require pagination proof in reconciliation PR inventory (Closes #308) #376

Merged
sysadmin merged 9 commits from feat/issue-308-reconcile-inventory-pagination into master 2026-07-07 09:26:03 -05:00
Conversation 2 Commits 9 Files Changed 4
+297
jcwalker3 commented 2026-07-07 08:08:50 -05:00
Owner
Copy Link
Copy Source

Summary

Implements issue #308: already-landed reconciliation reports must prove PR inventory pagination completeness.

Changes

  • Add reviewer_reconcile_inventory.py with assess_reconcile_inventory_report()
  • Require requested page size, pages fetched, per-page counts, and final-page proof
  • Block complete queue scan / all-already-landed claims without pagination metadata
  • Block exactly-full first pages without finality proof
  • Wire verifier into build_final_report and export from review_proofs
  • Tests in tests/test_reviewer_reconcile_inventory.py

Verification

pytest tests/test_reviewer_reconcile_inventory.py tests/test_llm_workflow_split.py::test_reconcile_inventory_verifier_exported -q

9 passed

## Summary Implements issue #308: already-landed reconciliation reports must prove PR inventory pagination completeness. ## Changes - Add `reviewer_reconcile_inventory.py` with `assess_reconcile_inventory_report()` - Require requested page size, pages fetched, per-page counts, and final-page proof - Block complete queue scan / all-already-landed claims without pagination metadata - Block exactly-full first pages without finality proof - Wire verifier into `build_final_report` and export from `review_proofs` - Tests in `tests/test_reviewer_reconcile_inventory.py` ## Verification ``` pytest tests/test_reviewer_reconcile_inventory.py tests/test_llm_workflow_split.py::test_reconcile_inventory_verifier_exported -q ``` 9 passed
jcwalker3 added 1 commit 2026-07-07 08:08:51 -05:00
feat: require pagination proof in reconciliation PR inventory (#308) 6e774e191a 
Add assess_reconcile_inventory_report verifier to block complete queue scan
and all-already-landed claims without final-page metadata, requested page size,
pages fetched, per-page counts, and no-next-page proof. Wire into
build_final_report and export from review_proofs.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
jcwalker3 commented 2026-07-07 08:08:56 -05:00
Author
Owner
Copy Link
Copy Source

Ready for review. Closes #308.

Verifier: reviewer_reconcile_inventory.assess_reconcile_inventory_report()
Tests: pytest tests/test_reviewer_reconcile_inventory.py -q (9 passed)

Ready for review. Closes #308. Verifier: `reviewer_reconcile_inventory.assess_reconcile_inventory_report()` Tests: `pytest tests/test_reviewer_reconcile_inventory.py -q` (9 passed)
jcwalker3 added 1 commit 2026-07-07 08:17:39 -05:00
fix: resolve conflicts for PR #376 against current master d0f52cbf19
jcwalker3 added 1 commit 2026-07-07 08:31:56 -05:00
fix: resolve conflicts for PR #376 against latest master ab126da479 
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
jcwalker3 added 1 commit 2026-07-07 08:37:28 -05:00
fix: resolve conflicts for PR #376 against latest master f749312b45
jcwalker3 added 1 commit 2026-07-07 08:45:26 -05:00
fix: resolve conflicts for PR #376 against current master 72f3bc8db8 
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
jcwalker3 added 1 commit 2026-07-07 08:55:43 -05:00
fix: resolve conflicts for PR #376 6100187274 
Merge prgs/master and keep both reconcile-inventory (#308) and
inventory-worktree (#293) verifiers wired in build_final_report.
jcwalker3 added 1 commit 2026-07-07 08:58:53 -05:00
Merge remote-tracking branch 'prgs/master' into feat/issue-308-reconcile-inventory-pagination 769f387267
jcwalker3 added 1 commit 2026-07-07 09:17:29 -05:00
Merge commit 'b5ee6567aade4fdce4c57d826184bfd01ebb522e' into HEAD 23380d27fe 
# Conflicts:
#	review_proofs.py
#	tests/test_llm_workflow_split.py
jcwalker3 added 1 commit 2026-07-07 09:22:40 -05:00
fix: resolve conflicts for PR #376 f5953549aa 
Merge prgs/master; keep reconcile-inventory pagination verifier (#308)
alongside linked-issue live-proof gates from master (#300).
sysadmin approved these changes 2026-07-07 09:25:30 -05:00
sysadmin left a comment
Owner
Copy Link
Copy Source

All tests pass successfully after merging master (1506 passed). Reviewed the implementation of reviewer_reconcile_inventory.py and the test coverage in tests/test_reviewer_reconcile_inventory.py. It correctly validates that reconciliation reports claiming complete queue scan or listing open PRs include pagination finality proof (like is_final_page: true) and metadata (requested page size, page count fetched, and returned PR count per page).

All tests pass successfully after merging master (1506 passed). Reviewed the implementation of `reviewer_reconcile_inventory.py` and the test coverage in `tests/test_reviewer_reconcile_inventory.py`. It correctly validates that reconciliation reports claiming complete queue scan or listing open PRs include pagination finality proof (like is_final_page: true) and metadata (requested page size, page count fetched, and returned PR count per page).
sysadmin merged commit 7fbb1bf34a into master 2026-07-07 09:26:03 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
sysadmin
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#376