feat: enforce proof wording for pagination and live claims (Closes #330) #346

2026-07-07T03:47:17-05:00

jcwalker3 commented

2026-07-07 03:47:17 -05:00

Summary

Closes #330

Adds assess_proof_wording() to review_proofs.py so final reports cannot claim unsupported proof phrases without matching evidence.

Changes

review_proofs.py — new assess_proof_wording() verifier; wired into build_final_report
tests/test_proof_wording.py — doc-contract tests for pagination, live proof, baseline, and mutation wording

Behavior

Rejects inventory complete without pagination finality metadata or session evidence
Rejects default page-size assumptions as completeness proof
Rejects live proof unless current-session evidence or prior-proof labeling is present
Rejects baseline-equivalence and no-file-edits claims without baseline/ledger proof

Validation

cd branches/feat-issue-330-proof-wording-enforcement
pytest tests/test_proof_wording.py tests/test_review_proofs.py -q  # 157 passed
pytest tests/ -q  # 1107 passed, 6 skipped (1 pre-existing failure on master)

Controller Handoff

Task: Implement #330 proof wording enforcement
Repo: Scaled-Tech-Consulting/Gitea-Tools (prgs)
Role: author
Identity: jcwalker3 / prgs-author
Branch/SHA: feat/issue-330-proof-wording-enforcement @ 46703ea
Worktree: branches/feat-issue-330-proof-wording-enforcement
Mutations: claim #330, lock, branch push, PR opened
Status: ready for independent reviewer
Safety: no self-review; no self-merge

## Summary Closes #330 Adds `assess_proof_wording()` to `review_proofs.py` so final reports cannot claim unsupported proof phrases without matching evidence. ## Changes - `review_proofs.py` — new `assess_proof_wording()` verifier; wired into `build_final_report` - `tests/test_proof_wording.py` — doc-contract tests for pagination, live proof, baseline, and mutation wording ## Behavior - Rejects `inventory complete` without pagination finality metadata or session evidence - Rejects default page-size assumptions as completeness proof - Rejects `live proof` unless current-session evidence or prior-proof labeling is present - Rejects baseline-equivalence and no-file-edits claims without baseline/ledger proof ## Validation ``` cd branches/feat-issue-330-proof-wording-enforcement pytest tests/test_proof_wording.py tests/test_review_proofs.py -q # 157 passed pytest tests/ -q # 1107 passed, 6 skipped (1 pre-existing failure on master) ``` ## Controller Handoff - Task: Implement #330 proof wording enforcement - Repo: Scaled-Tech-Consulting/Gitea-Tools (prgs) - Role: author - Identity: jcwalker3 / prgs-author - Branch/SHA: feat/issue-330-proof-wording-enforcement @ 46703ea - Worktree: branches/feat-issue-330-proof-wording-enforcement - Mutations: claim #330, lock, branch push, PR opened - Status: ready for independent reviewer - Safety: no self-review; no self-merge

jcwalker3 added 1 commit 2026-07-07 03:47:17 -05:00

feat: enforce proof wording for pagination and live claims (#330 ) 46703eac3f

Add assess_proof_wording to reject unsupported phrases such as
inventory complete, live proof, same as master, and file edits none
unless matching evidence is present. Wire into build_final_report and
add doc-contract tests.

Closes #330

jcwalker3 commented

2026-07-07 03:56:42 -05:00

Ready for review

Branch feat/issue-330-proof-wording-enforcement is pushed at head 46703ea (current with master @ fd6f7ff).

Scope (Closes #330)

Adds assess_proof_wording() in review_proofs.py and wires it into build_final_report:

Rejects inventory complete without pagination finality or session evidence
Rejects default page-size assumptions as completeness proof
Rejects live proof without current-session evidence (requires prior-proof labeling when reusing stale blockers)
Rejects same as master / file edits none without baseline or ledger proof

Validation (worktree `branches/feat-issue-330-proof-wording-enforcement`)

pytest tests/test_proof_wording.py tests/test_review_proofs.py -q

157 passed

No prior review verdicts on this PR. mergeable: true.

## Ready for review Branch `feat/issue-330-proof-wording-enforcement` is pushed at head `46703ea` (current with `master` @ `fd6f7ff`). ### Scope (Closes #330) Adds `assess_proof_wording()` in `review_proofs.py` and wires it into `build_final_report`: - Rejects `inventory complete` without pagination finality or session evidence - Rejects default page-size assumptions as completeness proof - Rejects `live proof` without current-session evidence (requires prior-proof labeling when reusing stale blockers) - Rejects `same as master` / `file edits none` without baseline or ledger proof ### Validation (worktree `branches/feat-issue-330-proof-wording-enforcement`) ``` pytest tests/test_proof_wording.py tests/test_review_proofs.py -q ``` **157 passed** No prior review verdicts on this PR. `mergeable: true`.

jcwalker3 added 1 commit 2026-07-07 04:17:01 -05:00

fix: resolve conflicts for issue 330 94b022b24d

Merge prgs/master into feat/issue-330-proof-wording-enforcement and keep
both assess_proof_wording (#330) and git ref mutation reporting (#297).

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 added 1 commit 2026-07-07 04:21:47 -05:00

fix: resolve conflicts for issue 330 (master refresh) e9fdb356dd

sysadmin approved these changes 2026-07-07 04:26:31 -05:00

sysadmin left a comment

All tests pass successfully. Reviewed the implementation in review_proofs.py and test coverage in tests/test_proof_wording.py. It correctly enforces proof wording for pagination, live blocker claims, same as master, and file edits none, rejecting these claims unless corresponding evidence is present in the current session, matching the acceptance criteria of Issue #330. Tested inside the review worktree, and the single failing test is pre-existing on master.

sysadmin merged commit c83c18e52a into master

2026-07-07 04:26:44 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#346