Add REQUEST_CHANGES override proof helper before approval (#326) #328

2026-07-07T01:54:45-05:00

jcwalker3 commented

2026-07-07 01:54:45 -05:00

Summary

Closes #326

Adds assess_request_changes_approval_proof in review_proofs.py so reviewer workflows can fail closed when approving an unchanged head after a prior REQUEST_CHANGES unless explicit override proof is provided.

Behavior

Fetches gitea_get_pr_review_feedback shape: undismissed REQUEST_CHANGES reviews, current head SHA, author_pushed_after_request_changes.
When head changed since blocker → approval allowed without override.
When head unchanged → requires override_reason (incorrect_blocker, wrong_validation_environment, resolved_externally), override_explanation, and report text quoting blocker body + override reason.
Missing feedback or proof → approve_allowed: false (fail closed).

Files changed

review_proofs.py — helper + private blockers selection
tests/test_request_changes_approval_proof.py — 5 acceptance tests

Validation

PASSED: pytest tests/test_request_changes_approval_proof.py -q — 5 passed in 0.36s
PASSED: pytest tests/ -q — 1028 passed, 6 skipped (1 pre-existing failure in test_agent_temp_artifacts; not introduced by this diff)

Controller Handoff

Task: Implement #326 REQUEST_CHANGES override proof helper
Repo/state: Scaled-Tech-Consulting/Gitea-Tools @ prgs; issue #326 in-progress; branch pushed
Issues/PRs: Closes #326; PR opening now
Changed: review_proofs.py, tests/test_request_changes_approval_proof.py
Validation: targeted 5/5 pass; full suite 1028 pass (1 pre-existing lock-profile test failure on master)
Blockers: none
Review: PR open — needs reviewer approval; no self-review/merge
Next: reviewer validates proof helper + tests; merge when approved
Safety: no self-review; no self-merge; no tags; no secrets; no prod

## Summary Closes #326 Adds `assess_request_changes_approval_proof` in `review_proofs.py` so reviewer workflows can fail closed when approving an unchanged head after a prior `REQUEST_CHANGES` unless explicit override proof is provided. ## Behavior - Fetches `gitea_get_pr_review_feedback` shape: undismissed `REQUEST_CHANGES` reviews, current head SHA, `author_pushed_after_request_changes`. - When head changed since blocker → approval allowed without override. - When head unchanged → requires `override_reason` (`incorrect_blocker`, `wrong_validation_environment`, `resolved_externally`), `override_explanation`, and report text quoting blocker body + override reason. - Missing feedback or proof → `approve_allowed: false` (fail closed). ## Files changed - `review_proofs.py` — helper + private blockers selection - `tests/test_request_changes_approval_proof.py` — 5 acceptance tests ## Validation ``` PASSED: pytest tests/test_request_changes_approval_proof.py -q — 5 passed in 0.36s PASSED: pytest tests/ -q — 1028 passed, 6 skipped (1 pre-existing failure in test_agent_temp_artifacts; not introduced by this diff) ``` ## Controller Handoff Task: Implement #326 REQUEST_CHANGES override proof helper Repo/state: Scaled-Tech-Consulting/Gitea-Tools @ prgs; issue #326 in-progress; branch pushed Issues/PRs: Closes #326; PR opening now Changed: review_proofs.py, tests/test_request_changes_approval_proof.py Validation: targeted 5/5 pass; full suite 1028 pass (1 pre-existing lock-profile test failure on master) Blockers: none Review: PR open — needs reviewer approval; no self-review/merge Next: reviewer validates proof helper + tests; merge when approved Safety: no self-review; no self-merge; no tags; no secrets; no prod

jcwalker3 added 1 commit 2026-07-07 01:54:45 -05:00

Add REQUEST_CHANGES override proof helper before approval (#326 ) efb0a2d076

Introduce assess_request_changes_approval_proof in review_proofs.py so
review workflows can fail closed when approving an unchanged head after a
prior REQUEST_CHANGES unless explicit override proof is provided.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

sysadmin approved these changes 2026-07-07 02:59:16 -05:00

sysadmin left a comment

PR #328 successfully implements the REQUEST_CHANGES override proof helper. All targeted and full-suite test results are clean.

sysadmin merged commit a73d5b351e into master

2026-07-07 02:59:34 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#328