Fix test env isolation for credentials and create_pr gate tests #229

2026-07-06T00:27:02-05:00

jcwalker3 commented

2026-07-06 00:27:02 -05:00

Closes #227

jcwalker3 added 1 commit 2026-07-06 00:27:03 -05:00

test: isolate credentials and create_pr tests from MCP env leakage 3320a5b3e6

Fix 8 suite failures triggered when GITEA_MCP_CONFIG/GITEA_MCP_PROFILE
are set in the operator environment.

- TestGetAuthHeader: clear MCP config env and DYNAMIC_CONFIGS in setUp
- TestCreatePR/TestIssueLocking: add CREATE_PR_ENV author fixture and
  patch reviewer-stop gate so tests reach intended code paths

Closes #227

sysadmin reviewed 2026-07-06 00:28:55 -05:00

sysadmin left a comment

Review (sysadmin / prgs-reviewer)

Scope: Clean — test-only fix for #227. Two files, no production code changes.

What looks good:

TestGetAuthHeader setUp/tearDown clears GITEA_MCP_CONFIG, GITEA_MCP_PROFILE, token env vars, and DYNAMIC_CONFIGS so credential fallback paths are actually exercised
CREATE_PR_ENV mirrors existing ISSUE_WRITE_ENV / AUTHOR_ENV patterns; author profile name avoids reviewer namespace block
TestCreatePR and TestIssueLocking patch reviewer-stop gate and use patch.dict(..., clear=True) so tests reach intended lock-validation paths

Verification: Full suite on PR branch with GITEA_MCP_PROFILE/GITEA_MCP_CONFIG set: 881 passed, 6 skipped.

Approved — Closes #227.

## Review (sysadmin / prgs-reviewer) **Scope:** Clean — test-only fix for #227. Two files, no production code changes. **What looks good:** - `TestGetAuthHeader` setUp/tearDown clears `GITEA_MCP_CONFIG`, `GITEA_MCP_PROFILE`, token env vars, and `DYNAMIC_CONFIGS` so credential fallback paths are actually exercised - `CREATE_PR_ENV` mirrors existing `ISSUE_WRITE_ENV` / `AUTHOR_ENV` patterns; author profile name avoids reviewer namespace block - `TestCreatePR` and `TestIssueLocking` patch reviewer-stop gate and use `patch.dict(..., clear=True)` so tests reach intended lock-validation paths **Verification:** Full suite on PR branch with `GITEA_MCP_PROFILE`/`GITEA_MCP_CONFIG` set: **881 passed**, 6 skipped. Approved — Closes #227.

sysadmin merged commit 125f52a059 into master

2026-07-06 00:29:21 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#229