Fix test env isolation for credentials and create_pr gate tests #227

New Issue

2026-07-06T00:26:20-05:00

jcwalker3 commented

2026-07-06 00:26:20 -05:00

Problem

Full test suite on master fails 8 tests when GITEA_MCP_CONFIG / GITEA_MCP_PROFILE are set in the operator environment (common during MCP sessions):

tests/test_credentials.py::TestGetAuthHeader (2) — profile keychain token leaks before Basic-auth / None fallbacks
tests/test_mcp_server.py::TestCreatePR (2) — gitea_create_pr permission/namespace gates block before API path
tests/test_mcp_server.py::TestIssueLocking (4) — same gate ordering; tests expect lock-validation exceptions

Fix

Isolate TestGetAuthHeader from MCP config env and dynamic token configs
Add CREATE_PR_ENV author profile fixture; patch reviewer-stop gate; use patch.dict(..., clear=True) in create_pr tests

Acceptance

pytest tests/ --ignore=branches passes with and without GITEA_MCP_PROFILE / GITEA_MCP_CONFIG set

## Problem Full test suite on `master` fails 8 tests when `GITEA_MCP_CONFIG` / `GITEA_MCP_PROFILE` are set in the operator environment (common during MCP sessions): - `tests/test_credentials.py::TestGetAuthHeader` (2) — profile keychain token leaks before Basic-auth / None fallbacks - `tests/test_mcp_server.py::TestCreatePR` (2) — `gitea_create_pr` permission/namespace gates block before API path - `tests/test_mcp_server.py::TestIssueLocking` (4) — same gate ordering; tests expect lock-validation exceptions ## Fix - Isolate `TestGetAuthHeader` from MCP config env and dynamic token configs - Add `CREATE_PR_ENV` author profile fixture; patch reviewer-stop gate; use `patch.dict(..., clear=True)` in create_pr tests ## Acceptance - `pytest tests/ --ignore=branches` passes with and without `GITEA_MCP_PROFILE` / `GITEA_MCP_CONFIG` set

jcwalker3 referenced this issue from a commit

2026-07-06 00:26:39 -05:00

test: isolate credentials and create_pr tests from MCP env leakage

jcwalker3 referenced a pull request that will close this issue

2026-07-06 00:27:02 -05:00

Fix test env isolation for credentials and create_pr gate tests #229

sysadmin referenced a pull request that will close this issue

2026-07-06 00:28:55 -05:00

Fix test env isolation for credentials and create_pr gate tests #229

sysadmin closed this issue

2026-07-06 00:29:21 -05:00

jcwalker3 referenced this issue