test: add missing tests for #166 Requirement-5 conflict/staleness scenarios #172

2026-07-05T13:05:32-05:00

jcwalker3 commented

2026-07-05 13:05:32 -05:00

Add regression tests covering the five Requirement-5 conflict/staleness scenarios from issue #166.

Scenarios covered (via mocks on live list_prs/view_pr responses):

Stale prior handoff says merged but live PR says open.
Prior handoff says open but live PR says closed.
gitea_list_prs and gitea_view_pr disagree.
Merge commit missing after claimed merge.
Linked issue remains open after claimed merge.

All tests pass (15 in inventory module; full relevant suite green).
py_compile, git diff --check, provenance/secret sweep clean.
No changes to src or any gates (review/merge/permission/identity/redaction/reconciliation).
Issue claimed via status:in-progress before work.
Fresh branch from live master.

Refs: #170

Co-Authored-By: Claude Opus 4.8 (1M context) [email protected]

Add regression tests covering the five Requirement-5 conflict/staleness scenarios from issue #166. Scenarios covered (via mocks on live list_prs/view_pr responses): 1. Stale prior handoff says merged but live PR says open. 2. Prior handoff says open but live PR says closed. 3. `gitea_list_prs` and `gitea_view_pr` disagree. 4. Merge commit missing after claimed merge. 5. Linked issue remains open after claimed merge. - All tests pass (15 in inventory module; full relevant suite green). - `py_compile`, `git diff --check`, provenance/secret sweep clean. - No changes to src or any gates (review/merge/permission/identity/redaction/reconciliation). - Issue claimed via status:in-progress before work. - Fresh branch from live master. Refs: #170 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 added 1 commit 2026-07-05 13:05:33 -05:00

test(pr-queue): add missing Requirement-5 conflict/staleness scenario tests for #166 0fdc8f5820

Covers:
1. Stale prior handoff merged but live open
2. Prior open but live closed
3. list_prs and view_pr disagree
4. Merge commit missing after claimed merge
5. Linked issue remains open after claimed merge

Uses live mocks for list/view with staleness fields (#166).
Proves coverage; no src changes or gate weakening.
Refs #170

jcwalker3 referenced this pull request

2026-07-05 13:05:54 -05:00

Add missing tests for issue #166 Requirement-5 conflict/staleness scenarios #170

jcwalker3 commented

2026-07-05 13:08:46 -05:00

Independent verification at pinned head 0fdc8f582026b72a229d59a172c0a63a c0a63ac4aaeaf9:

Targeted module: tests/test_pr_queue_inventory.py — 15 passed (includes the 5 new Requirement-5 scenario tests).
Full suite (junitxml): 644 tests, 0 failures, 0 errors, 6 skipped (integration-only skips).
py_compile on the changed test file: OK.
git diff --check: clean.
Secret/provenance sweep over the diff: clean.
Diff is test-only (tests/test_pr_queue_inventory.py, +149 lines); no gates touched.

Verified under profile prgs-author (read/author capabilities only); review/approval left to a reviewer session.

Independent verification at pinned head `0fdc8f582026b72a229d59a172c0a63a c0a63ac4aaeaf9`: - Targeted module: `tests/test_pr_queue_inventory.py` — 15 passed (includes the 5 new Requirement-5 scenario tests). - Full suite (junitxml): 644 tests, 0 failures, 0 errors, 6 skipped (integration-only skips). - `py_compile` on the changed test file: OK. - `git diff --check`: clean. - Secret/provenance sweep over the diff: clean. - Diff is test-only (`tests/test_pr_queue_inventory.py`, +149 lines); no gates touched. Verified under profile `prgs-author` (read/author capabilities only); review/approval left to a reviewer session.

jcwalker3 commented

2026-07-05 13:09:00 -05:00

Correction to previous comment: the pinned head SHA verified is 0fdc8f582026b72a229d59a172c0a63ac4aaeaf9 (typo above introduced a stray space/duplicate segment). All verification results unchanged.

Correction to previous comment: the pinned head SHA verified is `0fdc8f582026b72a229d59a172c0a63ac4aaeaf9` (typo above introduced a stray space/duplicate segment). All verification results unchanged.

sysadmin reviewed 2026-07-05 13:09:49 -05:00

sysadmin left a comment

Review approved. All 31 test files passed successfully. The local checkout exactly matches the pinned PR head SHA 0fdc8f5820.

Review approved. All 31 test files passed successfully. The local checkout exactly matches the pinned PR head SHA 0fdc8f582026b72a229d59a172c0a63ac4aaeaf9.

sysadmin merged commit fde8323ad4 into master

2026-07-05 13:09:57 -05:00

jcwalker3 referenced this pull request

2026-07-05 13:14:12 -05:00

Harden blind PR queue review workflow: require checked-out pinned head, complete inventory, and evidence-backed eligibility #173

jcwalker3 referenced this pull request

2026-07-05 13:18:40 -05:00

Add missing tests for issue #166 Requirement-5 conflict/staleness scenarios #170

jcwalker3 referenced this pull request

2026-07-05 13:26:32 -05:00

Prevent implicit reviewer-to-author role pivot during blind PR queue workflows #175

jcwalker3 referenced this pull request