Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Add missing tests for issue #166 Requirement-5 conflict/staleness scenarios #170

New Issue
Closed
opened 2026-07-05 12:29:23 -05:00 by jcwalker3 · 2 comments
jcwalker3 commented 2026-07-05 12:29:23 -05:00
Owner
Copy Link
Copy Source

Merged PR #168 for issue #166 did not implement tests covering the five Requirement-5 conflict/staleness scenarios. PR #169 review confirmed #169 is scoped to issue #167 and does not address this gap.

Evidence: grep -rn "handoff|claimed merge|merge commit missing|disagree" tests/ at pinned head a4060c59cc7ac2033cf77764677c81d067e29316 returned no matches; full suite at that head 633 passed / 6 skipped (scenarios simply uncovered). Origin report: mcp-control-plane #66 comments 2817 and 2824.

Scenarios to cover:

  1. Stale prior handoff says merged but live PR says open.
  2. Prior handoff says open but live PR says closed.
  3. gitea_list_prs and gitea_view_pr disagree.
  4. Merge commit missing after claimed merge.
  5. Linked issue remains open after claimed merge.

Acceptance criteria:

  • Identify the five Requirement-5 scenarios from issue #166.
  • Add regression tests covering each scenario.
  • Ensure tests fail before the fix or prove the behavior was previously uncovered.
  • Run the full Gitea-Tools test suite.
  • Do not weaken review, merge, permission, or reconciliation gates.
Merged PR #168 for issue #166 did not implement tests covering the five Requirement-5 conflict/staleness scenarios. PR #169 review confirmed #169 is scoped to issue #167 and does not address this gap. Evidence: `grep -rn "handoff|claimed merge|merge commit missing|disagree" tests/` at pinned head `a4060c59cc7ac2033cf77764677c81d067e29316` returned no matches; full suite at that head 633 passed / 6 skipped (scenarios simply uncovered). Origin report: mcp-control-plane #66 comments 2817 and 2824. Scenarios to cover: 1. Stale prior handoff says merged but live PR says open. 2. Prior handoff says open but live PR says closed. 3. `gitea_list_prs` and `gitea_view_pr` disagree. 4. Merge commit missing after claimed merge. 5. Linked issue remains open after claimed merge. Acceptance criteria: - Identify the five Requirement-5 scenarios from issue #166. - Add regression tests covering each scenario. - Ensure tests fail before the fix or prove the behavior was previously uncovered. - Run the full Gitea-Tools test suite. - Do not weaken review, merge, permission, or reconciliation gates.
jcwalker3 added the mcpgiteatestingreliabilityworkflow labels 2026-07-05 12:29:49 -05:00
jcwalker3 added the status:in-progress label 2026-07-05 13:03:50 -05:00
jcwalker3 commented 2026-07-05 13:05:54 -05:00
Author
Owner
Copy Link
Copy Source

PR #172 opened adding the 5 missing Requirement-5 tests. Live reconfirmed before branch/PR. Full targeted + relevant suite passed. Checks (py_compile, git diff --check, provenance) clean. Claimed via mark_issue before work.

Refs #166

PR #172 opened adding the 5 missing Requirement-5 tests. Live reconfirmed before branch/PR. Full targeted + relevant suite passed. Checks (py_compile, git diff --check, provenance) clean. Claimed via mark_issue before work. Refs #166
sysadmin removed the status:in-progress label 2026-07-05 13:09:58 -05:00
jcwalker3 commented 2026-07-05 13:18:40 -05:00
Author
Owner
Copy Link
Copy Source

Closing: implemented and merged via PR #172

Bounded-triage closure record:

  • Implementation: PR #172 (feat/issue-170-add-missing-166-req5-tests → master), merged 2026-07-05T13:09:57-05:00, merge commit fde8323ad45880ddb5edec3a19a6255eeb0b245b.
  • Merge verified live: gitea_view_pr(172) → state closed, merged_at set, merge commit present; local git merge-base --is-ancestor fde8323… prgs/master → yes (merge commit reachable from live master after fresh fetch).
  • Scope verified: merge commit touches only tests/test_pr_queue_inventory.py (+148 lines). All five Requirement-5 scenarios have dedicated tests on master: test_r5_s1_stale_prior_handoff_merged_but_live_pr_open, test_r5_s2_prior_handoff_open_but_live_pr_closed, test_r5_s3_list_prs_and_view_pr_disagree, test_r5_s4_merge_commit_missing_after_claimed_merge, test_r5_s5_linked_issue_remains_open_after_claimed_merge (15 test functions total in module).
  • Validation: author run reported 15/15 passing in the module plus relevant suite green; independent blind reviewer validated before merge. No src or gate changes in the diff.
  • Closer identity/capability: jcwalker3 / prgs-author; fresh resolver checks: comment_issue allowed, close_issue allowed.
  • Note: this closure itself resolves the live instance of scenario 5 (linked issue remained open after merge).
## Closing: implemented and merged via PR #172 Bounded-triage closure record: * **Implementation:** PR #172 (`feat/issue-170-add-missing-166-req5-tests` → `master`), merged 2026-07-05T13:09:57-05:00, merge commit `fde8323ad45880ddb5edec3a19a6255eeb0b245b`. * **Merge verified live:** `gitea_view_pr(172)` → state closed, `merged_at` set, merge commit present; local `git merge-base --is-ancestor fde8323… prgs/master` → yes (merge commit reachable from live master after fresh fetch). * **Scope verified:** merge commit touches only `tests/test_pr_queue_inventory.py` (+148 lines). All five Requirement-5 scenarios have dedicated tests on `master`: `test_r5_s1_stale_prior_handoff_merged_but_live_pr_open`, `test_r5_s2_prior_handoff_open_but_live_pr_closed`, `test_r5_s3_list_prs_and_view_pr_disagree`, `test_r5_s4_merge_commit_missing_after_claimed_merge`, `test_r5_s5_linked_issue_remains_open_after_claimed_merge` (15 test functions total in module). * **Validation:** author run reported 15/15 passing in the module plus relevant suite green; independent blind reviewer validated before merge. No src or gate changes in the diff. * **Closer identity/capability:** `jcwalker3 / prgs-author`; fresh resolver checks: `comment_issue` allowed, `close_issue` allowed. * **Note:** this closure itself resolves the live instance of scenario 5 (linked issue remained open after merge).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels gitea mcp reliability testing workflow
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#170