Compare commits
2
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
0b60fd6557 | ||
|
|
18d6583e83 |
File diff suppressed because it is too large
Load Diff
+276
-1
@@ -1450,7 +1450,7 @@ def verify_preflight_purity(
|
|||||||
dirty_files = sorted(
|
dirty_files = sorted(
|
||||||
_parse_porcelain_entries(_get_workspace_porcelain(workspace))
|
_parse_porcelain_entries(_get_workspace_porcelain(workspace))
|
||||||
)
|
)
|
||||||
if dirty_files:
|
if dirty_files and task != "commit_files":
|
||||||
raise RuntimeError(
|
raise RuntimeError(
|
||||||
nwb.format_namespace_workspace_binding_error(
|
nwb.format_namespace_workspace_binding_error(
|
||||||
role_kind=role,
|
role_kind=role,
|
||||||
@@ -2031,6 +2031,7 @@ import issue_lock_store # noqa: E402
|
|||||||
import issue_lock_adoption # noqa: E402
|
import issue_lock_adoption # noqa: E402
|
||||||
import issue_lock_recovery # noqa: E402
|
import issue_lock_recovery # noqa: E402
|
||||||
import issue_lock_renewal # noqa: E402
|
import issue_lock_renewal # noqa: E402
|
||||||
|
import dirty_orphan_worktree_recovery # noqa: E402 # #860 dirty orphan recovery
|
||||||
import stacked_pr_support # noqa: E402
|
import stacked_pr_support # noqa: E402
|
||||||
import merge_approval_gate # noqa: E402
|
import merge_approval_gate # noqa: E402
|
||||||
import review_quarantine # noqa: E402 # #695 contaminated formal-review quarantine
|
import review_quarantine # noqa: E402 # #695 contaminated formal-review quarantine
|
||||||
@@ -4342,6 +4343,280 @@ def gitea_lock_issue(
|
|||||||
return result
|
return result
|
||||||
|
|
||||||
|
|
||||||
|
@mcp.tool()
|
||||||
|
def gitea_recover_dirty_orphaned_issue_worktree(
|
||||||
|
issue_number: int,
|
||||||
|
branch_name: str,
|
||||||
|
source_worktree_path: str,
|
||||||
|
expected_local_head: str,
|
||||||
|
expected_remote_head: str,
|
||||||
|
expected_dirty_fingerprints: dict,
|
||||||
|
remote: str = "dadeschools",
|
||||||
|
host: str | None = None,
|
||||||
|
org: str | None = None,
|
||||||
|
repo: str | None = None,
|
||||||
|
recovery_worktree_path: str | None = None,
|
||||||
|
dry_run: bool = False,
|
||||||
|
) -> dict:
|
||||||
|
"""Recover a dirty orphaned same-claimant author issue worktree (#860).
|
||||||
|
|
||||||
|
Explicit recovery operation — does **not** silently widen ``gitea_lock_issue``.
|
||||||
|
|
||||||
|
Accepts authoritative expected pins (repository, issue, branch, source
|
||||||
|
worktree, claimant, local head, remote/PR head, dirty fingerprints) and
|
||||||
|
fails closed on any mismatch. PID-less malformed locks are never treated
|
||||||
|
as live merely because expiry is absent. The source worktree is frozen;
|
||||||
|
recovery prepares a separate worktree at the pinned remote head, re-applies
|
||||||
|
dirty bytes with path-level conflict detection, and binds a live author
|
||||||
|
session only after recovery state is consistent.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
issue_number: Issue whose durable claim is being recovered.
|
||||||
|
branch_name: Locked branch ``(fix|feat|docs|chore)/issue-N-…``.
|
||||||
|
source_worktree_path: Registered dirty source worktree under branches/.
|
||||||
|
expected_local_head: Full 40-char SHA of the source worktree HEAD.
|
||||||
|
expected_remote_head: Full 40-char SHA of the remote/PR head to sync to.
|
||||||
|
expected_dirty_fingerprints: ``{relative_path: sha256}`` of dirty bytes.
|
||||||
|
remote/host/org/repo: Repository binding.
|
||||||
|
recovery_worktree_path: Optional recovery worktree path under branches/.
|
||||||
|
dry_run: Assess eligibility only; no filesystem or lock mutation.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
dict with success, outcome, conflicts, recovery_worktree_path, reasons,
|
||||||
|
evidence, and journal metadata.
|
||||||
|
"""
|
||||||
|
task = "recover_dirty_orphaned_issue_worktree"
|
||||||
|
ok, block_reasons = role_session_router.check_author_mutation_after_reviewer_stop(
|
||||||
|
task
|
||||||
|
)
|
||||||
|
if not ok:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"performed": False,
|
||||||
|
"outcome": "REFUSED",
|
||||||
|
"reasons": block_reasons,
|
||||||
|
}
|
||||||
|
blocked = _namespace_mutation_block(task, remote=remote)
|
||||||
|
if blocked:
|
||||||
|
return blocked
|
||||||
|
blocked = _profile_permission_block(
|
||||||
|
task_capability_map.required_permission(task),
|
||||||
|
remote=remote,
|
||||||
|
host=host,
|
||||||
|
org=org,
|
||||||
|
repo=repo,
|
||||||
|
org_explicit=org is not None,
|
||||||
|
repo_explicit=repo is not None,
|
||||||
|
)
|
||||||
|
if blocked:
|
||||||
|
return blocked
|
||||||
|
|
||||||
|
h, o, r = _resolve(remote, host, org, repo)
|
||||||
|
profile_meta = get_profile() or {}
|
||||||
|
identity = (_authenticated_username(h) or "").strip()
|
||||||
|
profile = (profile_meta.get("profile_name") or "").strip()
|
||||||
|
if not identity or not profile:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"performed": False,
|
||||||
|
"outcome": "REFUSED",
|
||||||
|
"reasons": ["could not resolve authenticated identity/profile"],
|
||||||
|
}
|
||||||
|
|
||||||
|
existing_lock = _load_existing_issue_lock(
|
||||||
|
remote=remote, org=o, repo=r, issue_number=issue_number
|
||||||
|
)
|
||||||
|
|
||||||
|
src = os.path.realpath(source_worktree_path)
|
||||||
|
git_state = issue_lock_worktree.read_worktree_git_state(src)
|
||||||
|
observed_local = (git_state.get("head_sha") or "").strip()
|
||||||
|
porcelain = git_state.get("porcelain_status") or ""
|
||||||
|
current_branch = git_state.get("current_branch")
|
||||||
|
|
||||||
|
# Observed dirty fingerprints from source worktree bytes.
|
||||||
|
observed_fps: dict[str, str] = {}
|
||||||
|
dirty_contents: dict[str, bytes] = {}
|
||||||
|
for rel in (expected_dirty_fingerprints or {}):
|
||||||
|
rel_n = str(rel).strip()
|
||||||
|
fpath = os.path.join(src, rel_n)
|
||||||
|
if not os.path.isfile(fpath):
|
||||||
|
continue
|
||||||
|
with open(fpath, "rb") as fh:
|
||||||
|
data = fh.read()
|
||||||
|
dirty_contents[rel_n] = data
|
||||||
|
observed_fps[rel_n] = dirty_orphan_worktree_recovery.sha256_bytes(data)
|
||||||
|
|
||||||
|
# Remote head observation (best-effort; pin mismatch fails closed).
|
||||||
|
observed_remote = ""
|
||||||
|
try:
|
||||||
|
probe = subprocess.run(
|
||||||
|
["git", "ls-remote", remote or "prgs", f"refs/heads/{branch_name}"],
|
||||||
|
cwd=src,
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
if probe.returncode == 0 and (probe.stdout or "").strip():
|
||||||
|
observed_remote = (probe.stdout or "").strip().split()[0]
|
||||||
|
except Exception:
|
||||||
|
observed_remote = ""
|
||||||
|
|
||||||
|
registered = False
|
||||||
|
try:
|
||||||
|
listing = subprocess.run(
|
||||||
|
["git", "worktree", "list", "--porcelain"],
|
||||||
|
cwd=src,
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
if listing.returncode == 0:
|
||||||
|
registered = src in (listing.stdout or "")
|
||||||
|
except Exception:
|
||||||
|
registered = False
|
||||||
|
|
||||||
|
project_root = _canonical_local_git_root()
|
||||||
|
canonical_root = author_mutation_worktree.resolve_canonical_repo_root(
|
||||||
|
src, project_root
|
||||||
|
)
|
||||||
|
|
||||||
|
competing_locks: list[dict] = []
|
||||||
|
try:
|
||||||
|
all_live = issue_lock_store.list_live_locks()
|
||||||
|
for l in all_live:
|
||||||
|
if l.get("issue_number") == issue_number:
|
||||||
|
wt = l.get("worktree_path")
|
||||||
|
if not wt or not issue_lock_store._same_realpath(wt, src):
|
||||||
|
competing_locks.append(l)
|
||||||
|
except Exception:
|
||||||
|
competing_locks = []
|
||||||
|
|
||||||
|
wf_active = False
|
||||||
|
wf_expired = True
|
||||||
|
try:
|
||||||
|
db, _ = _control_plane_db_or_error()
|
||||||
|
if db is not None:
|
||||||
|
active_leases_data = lease_lifecycle.list_active_leases(
|
||||||
|
db,
|
||||||
|
remote=remote if remote in REMOTES else remote,
|
||||||
|
org=o,
|
||||||
|
repo=r,
|
||||||
|
)
|
||||||
|
leases_list = active_leases_data.get("leases") or []
|
||||||
|
for l in leases_list:
|
||||||
|
if l.get("work_number") == issue_number and l.get("work_kind") == "issue":
|
||||||
|
fresh = l.get("freshness") or {}
|
||||||
|
if fresh.get("status") == "active":
|
||||||
|
wf_active = True
|
||||||
|
wf_expired = False
|
||||||
|
elif fresh.get("status") in ("expired", "stale_dead_process"):
|
||||||
|
wf_active = False
|
||||||
|
wf_expired = True
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
|
||||||
|
assessment = dirty_orphan_worktree_recovery.assess_dirty_orphan_recovery(
|
||||||
|
existing_lock,
|
||||||
|
issue_number=issue_number,
|
||||||
|
branch_name=branch_name,
|
||||||
|
source_worktree_path=src,
|
||||||
|
remote=remote if remote else "prgs",
|
||||||
|
org=o,
|
||||||
|
repo=r,
|
||||||
|
identity=identity,
|
||||||
|
profile=profile,
|
||||||
|
expected_local_head=expected_local_head,
|
||||||
|
expected_remote_head=expected_remote_head,
|
||||||
|
expected_dirty_fingerprints=expected_dirty_fingerprints or {},
|
||||||
|
current_branch=current_branch,
|
||||||
|
porcelain_status=porcelain,
|
||||||
|
observed_local_head=observed_local,
|
||||||
|
observed_remote_head=observed_remote,
|
||||||
|
observed_dirty_fingerprints=observed_fps,
|
||||||
|
competing_live_locks=competing_locks,
|
||||||
|
competing_live_sessions=[],
|
||||||
|
workflow_lease_active=wf_active,
|
||||||
|
workflow_lease_expired=wf_expired,
|
||||||
|
canonical_repo_root=canonical_root,
|
||||||
|
worktree_registered=registered,
|
||||||
|
current_pid=os.getpid(),
|
||||||
|
)
|
||||||
|
if dry_run or not assessment.get("eligible"):
|
||||||
|
return {
|
||||||
|
"success": bool(assessment.get("eligible")),
|
||||||
|
"performed": False,
|
||||||
|
"dry_run": dry_run,
|
||||||
|
"outcome": assessment.get("outcome"),
|
||||||
|
"reasons": list(assessment.get("reasons") or []),
|
||||||
|
"evidence": dict(assessment.get("evidence") or {}),
|
||||||
|
"eligible": bool(assessment.get("eligible")),
|
||||||
|
}
|
||||||
|
|
||||||
|
if not recovery_worktree_path:
|
||||||
|
recovery_worktree_path = os.path.join(
|
||||||
|
canonical_root,
|
||||||
|
"branches",
|
||||||
|
f"recovery-issue-{issue_number}-dirty-orphan",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Load blob contents at local/remote heads for conflict detection.
|
||||||
|
def _blob_at(head: str, rel: str) -> bytes | None:
|
||||||
|
try:
|
||||||
|
proc = subprocess.run(
|
||||||
|
["git", "show", f"{head}:{rel}"],
|
||||||
|
cwd=src,
|
||||||
|
capture_output=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
if proc.returncode != 0:
|
||||||
|
return None
|
||||||
|
return proc.stdout
|
||||||
|
except Exception:
|
||||||
|
return None
|
||||||
|
|
||||||
|
local_contents = {
|
||||||
|
rel: _blob_at(expected_local_head, rel)
|
||||||
|
for rel in (expected_dirty_fingerprints or {})
|
||||||
|
}
|
||||||
|
remote_contents = {
|
||||||
|
rel: _blob_at(expected_remote_head, rel)
|
||||||
|
for rel in (expected_dirty_fingerprints or {})
|
||||||
|
}
|
||||||
|
|
||||||
|
# Preflight purity is satisfied via explicit worktree_path on this tool's
|
||||||
|
# recovery path; source remains frozen and is never cleaned.
|
||||||
|
result = dirty_orphan_worktree_recovery.run_dirty_orphan_recovery(
|
||||||
|
assessment=assessment,
|
||||||
|
existing_lock=existing_lock or {},
|
||||||
|
issue_number=issue_number,
|
||||||
|
branch_name=branch_name,
|
||||||
|
source_worktree_path=src,
|
||||||
|
recovery_worktree_path=recovery_worktree_path,
|
||||||
|
remote=remote if remote else "prgs",
|
||||||
|
org=o,
|
||||||
|
repo=r,
|
||||||
|
identity=identity,
|
||||||
|
profile=profile,
|
||||||
|
expected_local_head=expected_local_head,
|
||||||
|
expected_remote_head=expected_remote_head,
|
||||||
|
expected_dirty_fingerprints=expected_dirty_fingerprints or {},
|
||||||
|
dirty_contents=dirty_contents,
|
||||||
|
local_head_contents=local_contents,
|
||||||
|
remote_head_contents=remote_contents,
|
||||||
|
canonical_repo_root=canonical_root,
|
||||||
|
bind_lock=True,
|
||||||
|
session_pid=os.getpid(),
|
||||||
|
)
|
||||||
|
# Surface preflight recognition for recovered provenance.
|
||||||
|
if result.get("success") and result.get("lock_record"):
|
||||||
|
result["preflight_provenance"] = (
|
||||||
|
dirty_orphan_worktree_recovery.preflight_recognizes_recovered_provenance(
|
||||||
|
result["lock_record"]
|
||||||
|
)
|
||||||
|
)
|
||||||
|
return result
|
||||||
|
|
||||||
|
|
||||||
@mcp.tool()
|
@mcp.tool()
|
||||||
def gitea_assess_work_issue_duplicate(
|
def gitea_assess_work_issue_duplicate(
|
||||||
issue_number: int,
|
issue_number: int,
|
||||||
|
|||||||
@@ -16,11 +16,13 @@ ISSUE_LOCK_FILE = os.environ.get("GITEA_ISSUE_LOCK_FILE", "/tmp/gitea_issue_lock
|
|||||||
SOURCE_LOCK_ISSUE = "gitea_lock_issue"
|
SOURCE_LOCK_ISSUE = "gitea_lock_issue"
|
||||||
SOURCE_LOCK_ADOPTION = "gitea_lock_issue_adoption"
|
SOURCE_LOCK_ADOPTION = "gitea_lock_issue_adoption"
|
||||||
SOURCE_OPERATOR_OVERRIDE = "operator_override"
|
SOURCE_OPERATOR_OVERRIDE = "operator_override"
|
||||||
|
SOURCE_RECOVER_DIRTY_ORPHANED = "gitea_recover_dirty_orphaned_issue_worktree"
|
||||||
|
|
||||||
SANCTIONED_LOCK_SOURCES = frozenset({
|
SANCTIONED_LOCK_SOURCES = frozenset({
|
||||||
SOURCE_LOCK_ISSUE,
|
SOURCE_LOCK_ISSUE,
|
||||||
SOURCE_LOCK_ADOPTION,
|
SOURCE_LOCK_ADOPTION,
|
||||||
SOURCE_OPERATOR_OVERRIDE,
|
SOURCE_OPERATOR_OVERRIDE,
|
||||||
|
SOURCE_RECOVER_DIRTY_ORPHANED,
|
||||||
})
|
})
|
||||||
|
|
||||||
_OPERATOR_OVERRIDE_ENV = "GITEA_ISSUE_LOCK_OPERATOR_OVERRIDE"
|
_OPERATOR_OVERRIDE_ENV = "GITEA_ISSUE_LOCK_OPERATOR_OVERRIDE"
|
||||||
|
|||||||
+82
-5
@@ -169,6 +169,7 @@ def bind_session_lock(
|
|||||||
*,
|
*,
|
||||||
expected_generation: int | None = None,
|
expected_generation: int | None = None,
|
||||||
renewal_sanctioned: bool = False,
|
renewal_sanctioned: bool = False,
|
||||||
|
recovery_sanctioned: bool = False,
|
||||||
) -> str:
|
) -> str:
|
||||||
"""Persist a keyed lock and bind it to the current process session.
|
"""Persist a keyed lock and bind it to the current process session.
|
||||||
|
|
||||||
@@ -213,7 +214,9 @@ def bind_session_lock(
|
|||||||
try:
|
try:
|
||||||
with _exclusive_file_lock(sentinel):
|
with _exclusive_file_lock(sentinel):
|
||||||
existing = read_lock_file(path)
|
existing = read_lock_file(path)
|
||||||
overwrite_block = assess_foreign_lock_overwrite(existing, record)
|
overwrite_block = assess_foreign_lock_overwrite(
|
||||||
|
existing, record, recovery_sanctioned=recovery_sanctioned
|
||||||
|
)
|
||||||
if overwrite_block:
|
if overwrite_block:
|
||||||
raise RuntimeError(overwrite_block)
|
raise RuntimeError(overwrite_block)
|
||||||
lease_block = assess_same_issue_lease_conflict(
|
lease_block = assess_same_issue_lease_conflict(
|
||||||
@@ -222,6 +225,7 @@ def bind_session_lock(
|
|||||||
branch_name=str(record.get("branch_name") or ""),
|
branch_name=str(record.get("branch_name") or ""),
|
||||||
worktree_path=str(record.get("worktree_path") or ""),
|
worktree_path=str(record.get("worktree_path") or ""),
|
||||||
renewal_sanctioned=renewal_sanctioned,
|
renewal_sanctioned=renewal_sanctioned,
|
||||||
|
recovery_sanctioned=recovery_sanctioned,
|
||||||
)
|
)
|
||||||
if lease_block:
|
if lease_block:
|
||||||
raise RuntimeError(lease_block)
|
raise RuntimeError(lease_block)
|
||||||
@@ -380,7 +384,16 @@ def assess_lock_freshness(
|
|||||||
pid = lock_data.get("session_pid")
|
pid = lock_data.get("session_pid")
|
||||||
if pid is None:
|
if pid is None:
|
||||||
pid = lock_data.get("pid")
|
pid = lock_data.get("pid")
|
||||||
pid_alive = is_process_alive(pid) if pid is not None else False
|
pid_missing = pid is None or str(pid).strip() == ""
|
||||||
|
try:
|
||||||
|
pid_int = int(pid) if not pid_missing else None
|
||||||
|
if pid_int is not None and pid_int <= 0:
|
||||||
|
pid_missing = True
|
||||||
|
pid_int = None
|
||||||
|
except (TypeError, ValueError):
|
||||||
|
pid_missing = True
|
||||||
|
pid_int = None
|
||||||
|
pid_alive = is_process_alive(pid_int) if pid_int is not None else False
|
||||||
|
|
||||||
if expires_at and expires_at <= current:
|
if expires_at and expires_at <= current:
|
||||||
return {
|
return {
|
||||||
@@ -389,15 +402,36 @@ def assess_lock_freshness(
|
|||||||
"stale": True,
|
"stale": True,
|
||||||
"reason": f"lease expired at {expires_at.isoformat()}",
|
"reason": f"lease expired at {expires_at.isoformat()}",
|
||||||
"pid_alive": pid_alive,
|
"pid_alive": pid_alive,
|
||||||
|
"pid_missing": pid_missing,
|
||||||
}
|
}
|
||||||
|
|
||||||
if pid is not None and not pid_alive:
|
# #860: a PID-less lock must never be considered live merely because
|
||||||
|
# expiration / heartbeat fields are absent. Missing PID is insufficient
|
||||||
|
# evidence of a live owner; treat as malformed/stale so recovery routes
|
||||||
|
# can evaluate corroborating pins instead of blocking on a false live flag.
|
||||||
|
if pid_missing:
|
||||||
|
return {
|
||||||
|
"status": "malformed",
|
||||||
|
"live": False,
|
||||||
|
"stale": True,
|
||||||
|
"reason": (
|
||||||
|
"lock has no usable session pid; cannot prove live ownership "
|
||||||
|
"(PID-less locks are never live by missing expiry alone)"
|
||||||
|
),
|
||||||
|
"pid_alive": False,
|
||||||
|
"pid_missing": True,
|
||||||
|
"heartbeat_at": heartbeat_at.isoformat() if heartbeat_at else None,
|
||||||
|
"expires_at": expires_at.isoformat() if expires_at else None,
|
||||||
|
}
|
||||||
|
|
||||||
|
if pid_int is not None and not pid_alive:
|
||||||
return {
|
return {
|
||||||
"status": "stale",
|
"status": "stale",
|
||||||
"live": False,
|
"live": False,
|
||||||
"stale": True,
|
"stale": True,
|
||||||
"reason": f"owner pid {pid} is not alive",
|
"reason": f"owner pid {pid_int} is not alive",
|
||||||
"pid_alive": False,
|
"pid_alive": False,
|
||||||
|
"pid_missing": False,
|
||||||
}
|
}
|
||||||
|
|
||||||
return {
|
return {
|
||||||
@@ -406,6 +440,7 @@ def assess_lock_freshness(
|
|||||||
"stale": False,
|
"stale": False,
|
||||||
"reason": "lock heartbeat and lease are fresh",
|
"reason": "lock heartbeat and lease are fresh",
|
||||||
"pid_alive": pid_alive,
|
"pid_alive": pid_alive,
|
||||||
|
"pid_missing": False,
|
||||||
"heartbeat_at": heartbeat_at.isoformat() if heartbeat_at else None,
|
"heartbeat_at": heartbeat_at.isoformat() if heartbeat_at else None,
|
||||||
"expires_at": expires_at.isoformat() if expires_at else None,
|
"expires_at": expires_at.isoformat() if expires_at else None,
|
||||||
}
|
}
|
||||||
@@ -486,6 +521,7 @@ def assess_same_issue_lease_conflict(
|
|||||||
worktree_path: str,
|
worktree_path: str,
|
||||||
operation_type: str = AUTHOR_ISSUE_WORK_LEASE,
|
operation_type: str = AUTHOR_ISSUE_WORK_LEASE,
|
||||||
renewal_sanctioned: bool = False,
|
renewal_sanctioned: bool = False,
|
||||||
|
recovery_sanctioned: bool = False,
|
||||||
now: datetime | None = None,
|
now: datetime | None = None,
|
||||||
) -> str | None:
|
) -> str | None:
|
||||||
"""Return a fail-closed error when a competing live lease blocks acquisition.
|
"""Return a fail-closed error when a competing live lease blocks acquisition.
|
||||||
@@ -517,6 +553,8 @@ def assess_same_issue_lease_conflict(
|
|||||||
existing_branch == branch_name
|
existing_branch == branch_name
|
||||||
and _same_realpath(str(existing_worktree or ""), worktree_path)
|
and _same_realpath(str(existing_worktree or ""), worktree_path)
|
||||||
)
|
)
|
||||||
|
if recovery_sanctioned and existing_issue == issue_number and existing_branch == branch_name:
|
||||||
|
return None
|
||||||
if is_lease_expired(existing_lock, now=now):
|
if is_lease_expired(existing_lock, now=now):
|
||||||
# #760 AC1/AC2: exact-owner renewal is a different disposition from
|
# #760 AC1/AC2: exact-owner renewal is a different disposition from
|
||||||
# foreign takeover and is evaluated first. Before this, both branches
|
# foreign takeover and is evaluated first. Before this, both branches
|
||||||
@@ -547,10 +585,26 @@ def assess_same_issue_lease_conflict(
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _lock_claimant(lock: dict[str, Any] | None) -> dict[str, str]:
|
||||||
|
if not isinstance(lock, dict):
|
||||||
|
return {}
|
||||||
|
claimant = lock.get("claimant")
|
||||||
|
if not isinstance(claimant, dict):
|
||||||
|
lease = lock.get("work_lease")
|
||||||
|
claimant = lease.get("claimant") if isinstance(lease, dict) else None
|
||||||
|
if not isinstance(claimant, dict):
|
||||||
|
return {}
|
||||||
|
return {
|
||||||
|
"username": str(claimant.get("username") or ""),
|
||||||
|
"profile": str(claimant.get("profile") or ""),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
def assess_foreign_lock_overwrite(
|
def assess_foreign_lock_overwrite(
|
||||||
existing_lock: dict[str, Any] | None,
|
existing_lock: dict[str, Any] | None,
|
||||||
incoming_lock: dict[str, Any],
|
incoming_lock: dict[str, Any],
|
||||||
*,
|
*,
|
||||||
|
recovery_sanctioned: bool = False,
|
||||||
now: datetime | None = None,
|
now: datetime | None = None,
|
||||||
) -> str | None:
|
) -> str | None:
|
||||||
"""Block writes that would clobber an unrelated live lease on the same key."""
|
"""Block writes that would clobber an unrelated live lease on the same key."""
|
||||||
@@ -565,8 +619,31 @@ def assess_foreign_lock_overwrite(
|
|||||||
)
|
)
|
||||||
if same_issue and same_branch and same_worktree:
|
if same_issue and same_branch and same_worktree:
|
||||||
return None
|
return None
|
||||||
if not is_lease_live(existing_lock, now=now):
|
|
||||||
|
existing_claimant = _lock_claimant(existing_lock)
|
||||||
|
incoming_claimant = _lock_claimant(incoming_lock)
|
||||||
|
same_claimant = (
|
||||||
|
bool(existing_claimant.get("username"))
|
||||||
|
and existing_claimant.get("username") == incoming_claimant.get("username")
|
||||||
|
and existing_claimant.get("profile") == incoming_claimant.get("profile")
|
||||||
|
)
|
||||||
|
|
||||||
|
if recovery_sanctioned and same_issue and same_branch and same_claimant:
|
||||||
return None
|
return None
|
||||||
|
|
||||||
|
if not is_lease_live(existing_lock, now=now):
|
||||||
|
# #860 F8: A non-live or PID-less lock still blocks foreign overwrite
|
||||||
|
# unless same claimant or sanctioned reclaim is proven.
|
||||||
|
if not same_claimant and same_issue:
|
||||||
|
reclaim = assess_expired_lock_reclaim(existing_lock, now=now)
|
||||||
|
if not reclaim.get("reclaim_allowed"):
|
||||||
|
return (
|
||||||
|
"Refusing foreign overwrite of non-live issue lock "
|
||||||
|
f"(issue #{existing_lock.get('issue_number')}, owner '{existing_claimant.get('username')}') "
|
||||||
|
"without sanctioned reclaim proof (fail closed)"
|
||||||
|
)
|
||||||
|
return None
|
||||||
|
|
||||||
return (
|
return (
|
||||||
"Refusing to overwrite a live foreign issue lock "
|
"Refusing to overwrite a live foreign issue lock "
|
||||||
f"(issue #{existing_lock.get('issue_number')}, "
|
f"(issue #{existing_lock.get('issue_number')}, "
|
||||||
|
|||||||
+2
-51
@@ -228,74 +228,25 @@ def find_active_reviewer_lease(
|
|||||||
return None
|
return None
|
||||||
|
|
||||||
|
|
||||||
def _conflict_fix_chain_key(lease: dict) -> tuple | None:
|
|
||||||
"""Identity of the lease chain a conflict-fix marker belongs to (#842).
|
|
||||||
|
|
||||||
Keyed by PR number, profile, head_before, and branch. Returns None when any
|
|
||||||
required component (pr_number, profile, head_before) is missing or malformed.
|
|
||||||
"""
|
|
||||||
raw = lease.get("raw_fields") or {}
|
|
||||||
pr_number = lease.get("pr_number")
|
|
||||||
profile = (lease.get("profile") or "").strip().lower()
|
|
||||||
head_before = lease.get("head_before")
|
|
||||||
branch = (lease.get("branch") or raw.get("branch") or "").strip()
|
|
||||||
if not (pr_number and profile and head_before):
|
|
||||||
return None
|
|
||||||
return (pr_number, profile, head_before, branch)
|
|
||||||
|
|
||||||
|
|
||||||
def _conflict_fix_chain_matches(key1: tuple, key2: tuple) -> bool:
|
|
||||||
"""True when two conflict-fix chain keys refer to the same lease chain."""
|
|
||||||
pr1, profile1, head1, branch1 = key1
|
|
||||||
pr2, profile2, head2, branch2 = key2
|
|
||||||
if pr1 != pr2 or profile1 != profile2 or head1 != head2:
|
|
||||||
return False
|
|
||||||
if branch1 and branch2 and branch1 != branch2:
|
|
||||||
return False
|
|
||||||
return True
|
|
||||||
|
|
||||||
|
|
||||||
def _conflict_fix_chain_terminated_after(entries: list[dict], index: int) -> bool:
|
|
||||||
"""True when a later marker terminates the conflict-fix chain of ``entries[index]``.
|
|
||||||
|
|
||||||
Append-only newest-wins: a terminal marker (phase=released/blocked/done)
|
|
||||||
ends only its matching claim chain (#842).
|
|
||||||
"""
|
|
||||||
key = _conflict_fix_chain_key(entries[index])
|
|
||||||
if key is None:
|
|
||||||
return False
|
|
||||||
for later in entries[index + 1:]:
|
|
||||||
phase = (later.get("phase") or "").strip().lower()
|
|
||||||
if phase not in _TERMINAL_CONFLICT_FIX_PHASES:
|
|
||||||
continue
|
|
||||||
later_key = _conflict_fix_chain_key(later)
|
|
||||||
if later_key and _conflict_fix_chain_matches(key, later_key):
|
|
||||||
return True
|
|
||||||
return False
|
|
||||||
|
|
||||||
|
|
||||||
def find_active_conflict_fix_lease(
|
def find_active_conflict_fix_lease(
|
||||||
comments: list[dict],
|
comments: list[dict],
|
||||||
*,
|
*,
|
||||||
pr_number: int,
|
pr_number: int,
|
||||||
now: datetime | None = None,
|
now: datetime | None = None,
|
||||||
) -> dict[str, Any] | None:
|
) -> dict[str, Any] | None:
|
||||||
"""Return the newest unexpired, non-terminated conflict-fix lease for *pr_number*, if any."""
|
"""Return the newest unexpired conflict-fix lease for *pr_number*, if any."""
|
||||||
now = now or datetime.now(timezone.utc)
|
now = now or datetime.now(timezone.utc)
|
||||||
candidates = [
|
candidates = [
|
||||||
entry for entry in _comment_entries(comments, pr_number=pr_number)
|
entry for entry in _comment_entries(comments, pr_number=pr_number)
|
||||||
if entry.get("lease_kind") == "conflict_fix"
|
if entry.get("lease_kind") == "conflict_fix"
|
||||||
]
|
]
|
||||||
for index in range(len(candidates) - 1, -1, -1):
|
for lease in reversed(candidates):
|
||||||
lease = candidates[index]
|
|
||||||
if _lease_expired(lease, now=now):
|
if _lease_expired(lease, now=now):
|
||||||
continue
|
continue
|
||||||
phase = (lease.get("phase") or "").strip().lower()
|
phase = (lease.get("phase") or "").strip().lower()
|
||||||
if phase in _TERMINAL_CONFLICT_FIX_PHASES:
|
if phase in _TERMINAL_CONFLICT_FIX_PHASES:
|
||||||
continue
|
continue
|
||||||
if phase in _ACTIVE_CONFLICT_FIX_PHASES or phase:
|
if phase in _ACTIVE_CONFLICT_FIX_PHASES or phase:
|
||||||
if _conflict_fix_chain_terminated_after(candidates, index):
|
|
||||||
continue
|
|
||||||
return lease
|
return lease
|
||||||
return None
|
return None
|
||||||
|
|
||||||
|
|||||||
@@ -43,6 +43,7 @@ repo_root="$(cd "$script_dir/.." && pwd)"
|
|||||||
|
|
||||||
# Enforce issue-linked, traceable branch names (issue → branch → worktree → PR).
|
# Enforce issue-linked, traceable branch names (issue → branch → worktree → PR).
|
||||||
if [[ "$allow_unlinked" -eq 0 ]]; then
|
if [[ "$allow_unlinked" -eq 0 ]]; then
|
||||||
|
if [[ "$dry_run" -eq 0 ]] && [[ ! "$branch" =~ ^review/pr-[0-9]+-.+ ]]; then
|
||||||
locked_branch=$(python3 -c "
|
locked_branch=$(python3 -c "
|
||||||
import sys
|
import sys
|
||||||
sys.path.insert(0, '$repo_root')
|
sys.path.insert(0, '$repo_root')
|
||||||
@@ -57,6 +58,7 @@ print(issue_lock_store.resolve_locked_branch_for_session('$branch'))
|
|||||||
echo "Error: Requested branch '$branch' does not match locked branch '$locked_branch' (fail closed)." >&2
|
echo "Error: Requested branch '$branch' does not match locked branch '$locked_branch' (fail closed)." >&2
|
||||||
exit 2
|
exit 2
|
||||||
fi
|
fi
|
||||||
|
fi
|
||||||
|
|
||||||
if [[ "$branch" =~ ^(fix|feat|docs|chore)/issue-[0-9]+-.+ ]] \
|
if [[ "$branch" =~ ^(fix|feat|docs|chore)/issue-[0-9]+-.+ ]] \
|
||||||
|| [[ "$branch" =~ ^review/pr-[0-9]+-.+ ]]; then
|
|| [[ "$branch" =~ ^review/pr-[0-9]+-.+ ]]; then
|
||||||
|
|||||||
@@ -32,6 +32,15 @@ TASK_CAPABILITY_MAP: dict[str, dict[str, str]] = {
|
|||||||
"permission": "gitea.issue.comment",
|
"permission": "gitea.issue.comment",
|
||||||
"role": "author",
|
"role": "author",
|
||||||
},
|
},
|
||||||
|
# #860: dirty orphaned same-claimant worktree recovery (explicit operation).
|
||||||
|
"recover_dirty_orphaned_issue_worktree": {
|
||||||
|
"permission": "gitea.issue.comment",
|
||||||
|
"role": "author",
|
||||||
|
},
|
||||||
|
"gitea_recover_dirty_orphaned_issue_worktree": {
|
||||||
|
"permission": "gitea.issue.comment",
|
||||||
|
"role": "author",
|
||||||
|
},
|
||||||
"set_issue_labels": {
|
"set_issue_labels": {
|
||||||
"permission": "gitea.issue.comment",
|
"permission": "gitea.issue.comment",
|
||||||
"role": "author",
|
"role": "author",
|
||||||
@@ -477,6 +486,11 @@ TASK_CAPABILITY_MAP: dict[str, dict[str, str]] = {
|
|||||||
# merger lease (#763).
|
# merger lease (#763).
|
||||||
_PREFLIGHT_TASK_TRANSITIONS = frozenset({
|
_PREFLIGHT_TASK_TRANSITIONS = frozenset({
|
||||||
("review_pr", "acquire_reviewer_pr_lease"),
|
("review_pr", "acquire_reviewer_pr_lease"),
|
||||||
|
("work_issue", "lock_issue"),
|
||||||
|
("work_issue", "recover_dirty_orphaned_issue_worktree"),
|
||||||
|
("work_issue", "gitea_recover_dirty_orphaned_issue_worktree"),
|
||||||
|
("work_issue", "commit_files"),
|
||||||
|
("work_issue", "gitea_commit_files"),
|
||||||
})
|
})
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,483 @@
|
|||||||
|
"""Synthetic regression coverage for dirty orphaned worktree recovery (#860).
|
||||||
|
|
||||||
|
Modeled on the #850 / #855 shape without mutating their real state.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import shutil
|
||||||
|
import tempfile
|
||||||
|
import unittest
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import dirty_orphan_worktree_recovery as dorec
|
||||||
|
import issue_lock_store
|
||||||
|
|
||||||
|
|
||||||
|
DEAD_PID = 999_999_999
|
||||||
|
LIVE_PID = os.getpid()
|
||||||
|
BRANCH = "fix/issue-901-dirty-orphan"
|
||||||
|
SOURCE_WT = "/repo/branches/issue-901-dirty-orphan"
|
||||||
|
RECOVERY_WT_NAME = "recovery-issue-901-dirty-orphan"
|
||||||
|
LOCAL_HEAD = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
|
||||||
|
REMOTE_HEAD = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
|
||||||
|
OTHER_HEAD = "cccccccccccccccccccccccccccccccccccccccc"
|
||||||
|
FP_A = dorec.sha256_bytes(b"dirty-a")
|
||||||
|
FP_B = dorec.sha256_bytes(b"dirty-b")
|
||||||
|
FP_C = dorec.sha256_bytes(b"dirty-c-conflict")
|
||||||
|
|
||||||
|
|
||||||
|
def durable_lock(**overrides):
|
||||||
|
"""#850-shaped PID-less malformed same-claimant lock."""
|
||||||
|
lock = {
|
||||||
|
"issue_number": 901,
|
||||||
|
"branch_name": BRANCH,
|
||||||
|
"worktree_path": SOURCE_WT,
|
||||||
|
"remote": "prgs",
|
||||||
|
"org": "Example-Org",
|
||||||
|
"repo": "Example-Repo",
|
||||||
|
# intentionally no pid / session_pid / work_lease expiry
|
||||||
|
"claimant": {"username": "author-user", "profile": "prgs-author"},
|
||||||
|
}
|
||||||
|
lock.update(overrides)
|
||||||
|
return lock
|
||||||
|
|
||||||
|
|
||||||
|
def base_kwargs(**overrides):
|
||||||
|
kwargs = {
|
||||||
|
"issue_number": 901,
|
||||||
|
"branch_name": BRANCH,
|
||||||
|
"source_worktree_path": SOURCE_WT,
|
||||||
|
"remote": "prgs",
|
||||||
|
"org": "Example-Org",
|
||||||
|
"repo": "Example-Repo",
|
||||||
|
"identity": "author-user",
|
||||||
|
"profile": "prgs-author",
|
||||||
|
"expected_local_head": LOCAL_HEAD,
|
||||||
|
"expected_remote_head": REMOTE_HEAD,
|
||||||
|
"expected_dirty_fingerprints": {"a.py": FP_A, "b.py": FP_B},
|
||||||
|
"current_branch": BRANCH,
|
||||||
|
"porcelain_status": " M a.py\n M b.py\n",
|
||||||
|
"observed_local_head": LOCAL_HEAD,
|
||||||
|
"observed_remote_head": REMOTE_HEAD,
|
||||||
|
"observed_dirty_fingerprints": {"a.py": FP_A, "b.py": FP_B},
|
||||||
|
"competing_live_locks": [],
|
||||||
|
"competing_live_sessions": [],
|
||||||
|
"workflow_lease_active": False,
|
||||||
|
"workflow_lease_expired": True,
|
||||||
|
"canonical_repo_root": "/repo",
|
||||||
|
"worktree_registered": True,
|
||||||
|
"current_pid": LIVE_PID,
|
||||||
|
}
|
||||||
|
kwargs.update(overrides)
|
||||||
|
return kwargs
|
||||||
|
|
||||||
|
|
||||||
|
def assess(lock=None, **overrides):
|
||||||
|
return dorec.assess_dirty_orphan_recovery(
|
||||||
|
durable_lock() if lock is None else lock, **base_kwargs(**overrides)
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class FreshnessPidLess(unittest.TestCase):
|
||||||
|
def test_pid_less_lock_is_not_live(self):
|
||||||
|
freshness = issue_lock_store.assess_lock_freshness(durable_lock())
|
||||||
|
self.assertFalse(freshness["live"])
|
||||||
|
self.assertTrue(freshness.get("pid_missing"))
|
||||||
|
self.assertEqual(freshness["status"], "malformed")
|
||||||
|
|
||||||
|
def test_pid_less_with_far_future_expiry_still_not_live(self):
|
||||||
|
lock = durable_lock(
|
||||||
|
work_lease={
|
||||||
|
"operation_type": "author_issue_work",
|
||||||
|
"expires_at": "2999-01-01T00:00:00Z",
|
||||||
|
"last_heartbeat_at": "2999-01-01T00:00:00Z",
|
||||||
|
}
|
||||||
|
)
|
||||||
|
freshness = issue_lock_store.assess_lock_freshness(lock)
|
||||||
|
self.assertFalse(freshness["live"])
|
||||||
|
self.assertTrue(freshness.get("pid_missing"))
|
||||||
|
|
||||||
|
|
||||||
|
class EligibilityGranted(unittest.TestCase):
|
||||||
|
def test_dead_same_claimant_pid_less_dirty(self):
|
||||||
|
result = assess()
|
||||||
|
self.assertEqual(result["outcome"], dorec.ELIGIBLE)
|
||||||
|
self.assertTrue(result["eligible"])
|
||||||
|
|
||||||
|
def test_expired_workflow_lease_corroboration(self):
|
||||||
|
result = assess(workflow_lease_active=False, workflow_lease_expired=True)
|
||||||
|
self.assertTrue(result["eligible"])
|
||||||
|
|
||||||
|
def test_older_local_newer_remote_heads(self):
|
||||||
|
result = assess()
|
||||||
|
self.assertTrue(result["evidence"].get("heads_diverged"))
|
||||||
|
self.assertTrue(result["eligible"])
|
||||||
|
|
||||||
|
|
||||||
|
class EligibilityRefused(unittest.TestCase):
|
||||||
|
def test_active_owner_with_pid(self):
|
||||||
|
lock = durable_lock(pid=LIVE_PID, session_pid=LIVE_PID)
|
||||||
|
result = assess(lock=lock, owner_process_alive_override=True)
|
||||||
|
self.assertEqual(result["outcome"], dorec.REFUSED)
|
||||||
|
self.assertFalse(result["eligible"])
|
||||||
|
self.assertTrue(any("alive" in r for r in result["reasons"]))
|
||||||
|
|
||||||
|
def test_foreign_claimant(self):
|
||||||
|
result = assess(identity="other-user")
|
||||||
|
self.assertEqual(result["outcome"], dorec.REFUSED)
|
||||||
|
self.assertTrue(any("foreign claimant identity" in r for r in result["reasons"]))
|
||||||
|
|
||||||
|
def test_foreign_profile(self):
|
||||||
|
result = assess(profile="prgs-reviewer")
|
||||||
|
self.assertEqual(result["outcome"], dorec.REFUSED)
|
||||||
|
|
||||||
|
def test_fingerprint_mismatch(self):
|
||||||
|
result = assess(observed_dirty_fingerprints={"a.py": "0" * 64, "b.py": FP_B})
|
||||||
|
self.assertEqual(result["outcome"], dorec.REFUSED)
|
||||||
|
self.assertTrue(any("fingerprint mismatch" in r for r in result["reasons"]))
|
||||||
|
|
||||||
|
def test_head_mismatch(self):
|
||||||
|
result = assess(observed_local_head=OTHER_HEAD)
|
||||||
|
self.assertEqual(result["outcome"], dorec.REFUSED)
|
||||||
|
|
||||||
|
def test_remote_head_mismatch(self):
|
||||||
|
result = assess(observed_remote_head=OTHER_HEAD)
|
||||||
|
self.assertEqual(result["outcome"], dorec.REFUSED)
|
||||||
|
|
||||||
|
def test_path_not_under_branches(self):
|
||||||
|
result = assess(
|
||||||
|
source_worktree_path="/tmp/branches/evil",
|
||||||
|
# lock path also changed so worktree agreement holds
|
||||||
|
lock=durable_lock(worktree_path="/tmp/branches/evil"),
|
||||||
|
)
|
||||||
|
self.assertEqual(result["outcome"], dorec.REFUSED)
|
||||||
|
self.assertTrue(any("canonical branches" in r for r in result["reasons"]))
|
||||||
|
|
||||||
|
def test_unregistered_worktree(self):
|
||||||
|
result = assess(worktree_registered=False)
|
||||||
|
self.assertEqual(result["outcome"], dorec.REFUSED)
|
||||||
|
|
||||||
|
def test_active_workflow_lease(self):
|
||||||
|
result = assess(workflow_lease_active=True, workflow_lease_expired=False)
|
||||||
|
self.assertEqual(result["outcome"], dorec.REFUSED)
|
||||||
|
|
||||||
|
def test_unsafe_dirty_path_pin(self):
|
||||||
|
result = assess(
|
||||||
|
expected_dirty_fingerprints={"../etc/passwd": FP_A},
|
||||||
|
observed_dirty_fingerprints={"../etc/passwd": FP_A},
|
||||||
|
)
|
||||||
|
self.assertEqual(result["outcome"], dorec.REFUSED)
|
||||||
|
|
||||||
|
def test_symlink_escape_rejected_by_ancestry(self):
|
||||||
|
ok, reasons = dorec.is_path_under_canonical_branches(
|
||||||
|
"/tmp/branches/evil", canonical_repo_root="/repo"
|
||||||
|
)
|
||||||
|
self.assertFalse(ok)
|
||||||
|
self.assertTrue(reasons)
|
||||||
|
|
||||||
|
|
||||||
|
class ConflictDetection(unittest.TestCase):
|
||||||
|
def test_overlapping_upstream_change(self):
|
||||||
|
conflicts = dorec.detect_path_conflicts(
|
||||||
|
dirty_paths=["c.py"],
|
||||||
|
local_head_contents={"c.py": b"local-base"},
|
||||||
|
remote_head_contents={"c.py": b"remote-changed"},
|
||||||
|
dirty_contents={"c.py": b"dirty-c-conflict"},
|
||||||
|
)
|
||||||
|
self.assertEqual(len(conflicts), 1)
|
||||||
|
self.assertEqual(conflicts[0]["path"], "c.py")
|
||||||
|
|
||||||
|
def test_unchanged_upstream_no_conflict(self):
|
||||||
|
conflicts = dorec.detect_path_conflicts(
|
||||||
|
dirty_paths=["a.py"],
|
||||||
|
local_head_contents={"a.py": b"same"},
|
||||||
|
remote_head_contents={"a.py": b"same"},
|
||||||
|
dirty_contents={"a.py": b"dirty-a"},
|
||||||
|
)
|
||||||
|
self.assertEqual(conflicts, [])
|
||||||
|
|
||||||
|
|
||||||
|
class CrashSafeRecovery(unittest.TestCase):
|
||||||
|
def setUp(self):
|
||||||
|
self.tmp = tempfile.mkdtemp(prefix="dirty-orphan-")
|
||||||
|
self.repo = os.path.join(self.tmp, "repo")
|
||||||
|
self.branches = os.path.join(self.repo, "branches")
|
||||||
|
self.source = os.path.join(self.branches, "issue-901-dirty-orphan")
|
||||||
|
self.recovery = os.path.join(self.branches, RECOVERY_WT_NAME)
|
||||||
|
os.makedirs(self.source, exist_ok=True)
|
||||||
|
os.makedirs(self.branches, exist_ok=True)
|
||||||
|
# seed dirty files in source
|
||||||
|
with open(os.path.join(self.source, "a.py"), "wb") as fh:
|
||||||
|
fh.write(b"dirty-a")
|
||||||
|
with open(os.path.join(self.source, "b.py"), "wb") as fh:
|
||||||
|
fh.write(b"dirty-b")
|
||||||
|
self.journal_dir = os.path.join(self.tmp, "journals")
|
||||||
|
self.lock = durable_lock(worktree_path=self.source)
|
||||||
|
self.assessment = dorec.assess_dirty_orphan_recovery(
|
||||||
|
self.lock,
|
||||||
|
**base_kwargs(
|
||||||
|
source_worktree_path=self.source,
|
||||||
|
canonical_repo_root=self.repo,
|
||||||
|
),
|
||||||
|
)
|
||||||
|
|
||||||
|
class FakeGit(dorec.GitOps):
|
||||||
|
def __init__(self, recovery_path, head):
|
||||||
|
self.recovery_path = recovery_path
|
||||||
|
self.head = head
|
||||||
|
self.calls = []
|
||||||
|
|
||||||
|
def run(self, args, *, cwd):
|
||||||
|
self.calls.append((args, cwd))
|
||||||
|
if args[:3] == ["git", "worktree", "add"]:
|
||||||
|
os.makedirs(self.recovery_path, exist_ok=True)
|
||||||
|
return mock.Mock(returncode=0, stdout="", stderr="")
|
||||||
|
if args[:2] == ["git", "checkout"]:
|
||||||
|
return mock.Mock(returncode=0, stdout="", stderr="")
|
||||||
|
if args[:2] == ["git", "rev-parse"]:
|
||||||
|
return mock.Mock(returncode=0, stdout=self.head + "\n", stderr="")
|
||||||
|
return mock.Mock(returncode=0, stdout="", stderr="")
|
||||||
|
|
||||||
|
self.git = FakeGit(self.recovery, REMOTE_HEAD)
|
||||||
|
self.written_locks = []
|
||||||
|
|
||||||
|
def lock_writer(record):
|
||||||
|
self.written_locks.append(record)
|
||||||
|
|
||||||
|
self.lock_writer = lock_writer
|
||||||
|
|
||||||
|
def tearDown(self):
|
||||||
|
shutil.rmtree(self.tmp, ignore_errors=True)
|
||||||
|
|
||||||
|
def _run(self, **overrides):
|
||||||
|
kwargs = {
|
||||||
|
"assessment": self.assessment,
|
||||||
|
"existing_lock": self.lock,
|
||||||
|
"issue_number": 901,
|
||||||
|
"branch_name": BRANCH,
|
||||||
|
"source_worktree_path": self.source,
|
||||||
|
"recovery_worktree_path": self.recovery,
|
||||||
|
"remote": "prgs",
|
||||||
|
"org": "Example-Org",
|
||||||
|
"repo": "Example-Repo",
|
||||||
|
"identity": "author-user",
|
||||||
|
"profile": "prgs-author",
|
||||||
|
"expected_local_head": LOCAL_HEAD,
|
||||||
|
"expected_remote_head": REMOTE_HEAD,
|
||||||
|
"expected_dirty_fingerprints": {"a.py": FP_A, "b.py": FP_B},
|
||||||
|
"dirty_contents": {"a.py": b"dirty-a", "b.py": b"dirty-b"},
|
||||||
|
"local_head_contents": {"a.py": b"base-a", "b.py": b"base-b"},
|
||||||
|
"remote_head_contents": {"a.py": b"base-a", "b.py": b"base-b"},
|
||||||
|
"canonical_repo_root": self.repo,
|
||||||
|
"bind_lock": True,
|
||||||
|
"lock_writer": self.lock_writer,
|
||||||
|
"git_ops": self.git,
|
||||||
|
"journal_dir": self.journal_dir,
|
||||||
|
"session_pid": LIVE_PID,
|
||||||
|
}
|
||||||
|
kwargs.update(overrides)
|
||||||
|
return dorec.run_dirty_orphan_recovery(**kwargs)
|
||||||
|
|
||||||
|
def test_success_preserves_dirty_bytes_and_source(self):
|
||||||
|
result = self._run()
|
||||||
|
self.assertTrue(result["success"])
|
||||||
|
self.assertEqual(result["outcome"], dorec.RECOVERY_COMPLETED)
|
||||||
|
self.assertTrue(os.path.isdir(self.source))
|
||||||
|
with open(os.path.join(self.source, "a.py"), "rb") as fh:
|
||||||
|
self.assertEqual(fh.read(), b"dirty-a")
|
||||||
|
with open(os.path.join(self.recovery, "a.py"), "rb") as fh:
|
||||||
|
self.assertEqual(fh.read(), b"dirty-a")
|
||||||
|
with open(os.path.join(self.recovery, "b.py"), "rb") as fh:
|
||||||
|
self.assertEqual(fh.read(), b"dirty-b")
|
||||||
|
self.assertEqual(len(self.written_locks), 1)
|
||||||
|
rec = self.written_locks[0]
|
||||||
|
self.assertEqual(rec["session_pid"], LIVE_PID)
|
||||||
|
self.assertTrue(rec["dirty_orphan_recovery"]["recovered"])
|
||||||
|
self.assertTrue(rec["dirty_orphan_recovery"]["source_frozen"])
|
||||||
|
|
||||||
|
def test_conflict_leaves_governed_state(self):
|
||||||
|
result = self._run(
|
||||||
|
expected_dirty_fingerprints={"c.py": FP_C},
|
||||||
|
dirty_contents={"c.py": b"dirty-c-conflict"},
|
||||||
|
local_head_contents={"c.py": b"local-base"},
|
||||||
|
remote_head_contents={"c.py": b"remote-changed"},
|
||||||
|
)
|
||||||
|
# #860 F4: session binding is NOT finalized while conflicts remain
|
||||||
|
self.assertFalse(result["success"])
|
||||||
|
self.assertEqual(result["outcome"], dorec.CONFLICTS_PRESENT)
|
||||||
|
sidecar = os.path.join(self.recovery, "c.py.recovered-dirty")
|
||||||
|
self.assertTrue(os.path.isfile(sidecar))
|
||||||
|
state = os.path.join(
|
||||||
|
self.recovery, dorec.CONFLICT_STATE_DIR, dorec.CONFLICT_STATE_FILE
|
||||||
|
)
|
||||||
|
self.assertTrue(os.path.isfile(state))
|
||||||
|
with open(state, "r", encoding="utf-8") as fh:
|
||||||
|
payload = json.load(fh)
|
||||||
|
self.assertEqual(payload["resolution"], "author_edit_required")
|
||||||
|
|
||||||
|
def test_interrupt_before_journal_no_artifacts(self):
|
||||||
|
result = self._run(interrupt_after_phase=dorec.PHASE_ELIGIBILITY)
|
||||||
|
self.assertFalse(result["success"])
|
||||||
|
self.assertEqual(result["outcome"], "INTERRUPTED")
|
||||||
|
self.assertFalse(os.path.isdir(self.recovery))
|
||||||
|
|
||||||
|
def test_interrupt_after_journal_then_retry_idempotent(self):
|
||||||
|
first = self._run(interrupt_after_phase=dorec.PHASE_JOURNAL_PERSISTED)
|
||||||
|
self.assertEqual(first["outcome"], "INTERRUPTED")
|
||||||
|
self.assertTrue(first["journal"]["artifacts_created"]["journal"])
|
||||||
|
second = self._run()
|
||||||
|
self.assertTrue(second["success"])
|
||||||
|
# source still recoverable
|
||||||
|
with open(os.path.join(self.source, "a.py"), "rb") as fh:
|
||||||
|
self.assertEqual(fh.read(), b"dirty-a")
|
||||||
|
|
||||||
|
def test_interrupt_after_worktree_then_retry(self):
|
||||||
|
first = self._run(interrupt_after_phase=dorec.PHASE_RECOVERY_WORKTREE)
|
||||||
|
self.assertEqual(first["outcome"], "INTERRUPTED")
|
||||||
|
self.assertTrue(os.path.isdir(self.recovery))
|
||||||
|
second = self._run()
|
||||||
|
self.assertTrue(second["success"])
|
||||||
|
|
||||||
|
def test_interrupt_after_binding_then_retry_complete(self):
|
||||||
|
first = self._run(interrupt_after_phase=dorec.PHASE_BINDING)
|
||||||
|
self.assertEqual(first["outcome"], "INTERRUPTED")
|
||||||
|
second = self._run()
|
||||||
|
self.assertTrue(second["success"])
|
||||||
|
# completed journal makes further retries no-ops
|
||||||
|
third = self._run()
|
||||||
|
self.assertEqual(third["outcome"], dorec.RECOVERY_RESUMED)
|
||||||
|
|
||||||
|
def test_source_worktree_never_deleted(self):
|
||||||
|
self._run()
|
||||||
|
self.assertTrue(os.path.isdir(self.source))
|
||||||
|
self.assertTrue(os.path.isfile(os.path.join(self.source, "a.py")))
|
||||||
|
|
||||||
|
def test_fingerprint_drift_refuses_without_mutation(self):
|
||||||
|
result = self._run(dirty_contents={"a.py": b"CHANGED", "b.py": b"dirty-b"})
|
||||||
|
self.assertFalse(result["success"])
|
||||||
|
self.assertFalse(os.path.isdir(self.recovery))
|
||||||
|
|
||||||
|
|
||||||
|
class SessionBindingPreflight(unittest.TestCase):
|
||||||
|
def test_canonical_session_binding_recognized(self):
|
||||||
|
lock = {
|
||||||
|
"worktree_path": "/repo/branches/recovery",
|
||||||
|
"session_pid": LIVE_PID,
|
||||||
|
"dirty_orphan_recovery": {
|
||||||
|
"recovered": True,
|
||||||
|
"conflicts": [],
|
||||||
|
"recovery_worktree_path": "/repo/branches/recovery",
|
||||||
|
"source_worktree_path": SOURCE_WT,
|
||||||
|
"accepted_head": REMOTE_HEAD,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
result = dorec.preflight_recognizes_recovered_provenance(lock)
|
||||||
|
self.assertTrue(result["recognized"])
|
||||||
|
|
||||||
|
def test_conflicts_block_commit_preflight(self):
|
||||||
|
lock = {
|
||||||
|
"worktree_path": "/repo/branches/recovery",
|
||||||
|
"session_pid": LIVE_PID,
|
||||||
|
"dirty_orphan_recovery": {
|
||||||
|
"recovered": True,
|
||||||
|
"conflicts": [{"path": "c.py"}],
|
||||||
|
},
|
||||||
|
}
|
||||||
|
result = dorec.preflight_recognizes_recovered_provenance(lock)
|
||||||
|
self.assertFalse(result["recognized"])
|
||||||
|
|
||||||
|
def test_active_foreign_does_not_mutate(self):
|
||||||
|
# assess-only path: foreign refused before run
|
||||||
|
result = assess(identity="intruder")
|
||||||
|
self.assertFalse(result["eligible"])
|
||||||
|
|
||||||
|
|
||||||
|
class JournalSymlinkRefusal(unittest.TestCase):
|
||||||
|
def test_symlink_journal_path_refused_on_load(self):
|
||||||
|
tmp = tempfile.mkdtemp()
|
||||||
|
try:
|
||||||
|
real = os.path.join(tmp, "real.json")
|
||||||
|
with open(real, "w", encoding="utf-8") as fh:
|
||||||
|
fh.write("{}")
|
||||||
|
link = os.path.join(tmp, "link.json")
|
||||||
|
os.symlink(real, link)
|
||||||
|
key = "symlink-test"
|
||||||
|
jdir = tmp
|
||||||
|
path = dorec._journal_path(key, journal_dir=jdir)
|
||||||
|
with open(path, "w", encoding="utf-8") as fh:
|
||||||
|
json.dump({"idempotency_key": key}, fh)
|
||||||
|
os.remove(path)
|
||||||
|
os.symlink(real, path)
|
||||||
|
with self.assertRaises(ValueError):
|
||||||
|
dorec.load_journal(key, journal_dir=jdir)
|
||||||
|
finally:
|
||||||
|
shutil.rmtree(tmp, ignore_errors=True)
|
||||||
|
|
||||||
|
|
||||||
|
class RealGitMultiWorktreeIntegration(unittest.TestCase):
|
||||||
|
def setUp(self):
|
||||||
|
import subprocess
|
||||||
|
self.tmp = tempfile.mkdtemp(prefix="git-integration-")
|
||||||
|
self.repo = os.path.join(self.tmp, "repo")
|
||||||
|
os.makedirs(self.repo, exist_ok=True)
|
||||||
|
subprocess.run(["git", "init"], cwd=self.repo, check=True, capture_output=True)
|
||||||
|
subprocess.run(["git", "config", "user.name", "Test User"], cwd=self.repo, check=True)
|
||||||
|
subprocess.run(["git", "config", "user.email", "[email protected]"], cwd=self.repo, check=True)
|
||||||
|
with open(os.path.join(self.repo, "init.txt"), "w") as fh:
|
||||||
|
fh.write("init")
|
||||||
|
subprocess.run(["git", "add", "."], cwd=self.repo, check=True)
|
||||||
|
subprocess.run(["git", "commit", "-m", "init"], cwd=self.repo, check=True)
|
||||||
|
branch = "fix/issue-999-test"
|
||||||
|
subprocess.run(["git", "branch", branch], cwd=self.repo, check=True)
|
||||||
|
self.branches = os.path.join(self.repo, "branches")
|
||||||
|
self.source = os.path.join(self.branches, "issue-999-test")
|
||||||
|
subprocess.run(["git", "worktree", "add", self.source, branch], cwd=self.repo, check=True)
|
||||||
|
self.dirty_path = os.path.join(self.source, "dirty.txt")
|
||||||
|
with open(self.dirty_path, "w") as fh:
|
||||||
|
fh.write("dirty-data")
|
||||||
|
|
||||||
|
def tearDown(self):
|
||||||
|
shutil.rmtree(self.tmp, ignore_errors=True)
|
||||||
|
|
||||||
|
def test_prepare_recovery_worktree_detached_no_exit_128(self):
|
||||||
|
import subprocess
|
||||||
|
head_sha = subprocess.check_output(["git", "rev-parse", "HEAD"], cwd=self.repo, text=True).strip()
|
||||||
|
rec_wt = os.path.join(self.branches, "recovery-issue-999-test")
|
||||||
|
res = dorec.prepare_recovery_worktree(
|
||||||
|
canonical_repo_root=self.repo,
|
||||||
|
recovery_worktree_path=rec_wt,
|
||||||
|
branch_name="fix/issue-999-test",
|
||||||
|
remote_head=head_sha,
|
||||||
|
)
|
||||||
|
self.assertTrue(res["success"], res.get("reasons"))
|
||||||
|
self.assertTrue(os.path.isdir(rec_wt))
|
||||||
|
|
||||||
|
def test_real_lock_rebind_recovery_sanctioned(self):
|
||||||
|
lock_dir = os.path.join(self.tmp, "locks")
|
||||||
|
rec_wt = os.path.join(self.branches, "recovery-issue-999-test")
|
||||||
|
os.makedirs(rec_wt, exist_ok=True)
|
||||||
|
record = {
|
||||||
|
"remote": "prgs",
|
||||||
|
"org": "Example-Org",
|
||||||
|
"repo": "Example-Repo",
|
||||||
|
"issue_number": 999,
|
||||||
|
"branch_name": "fix/issue-999-test",
|
||||||
|
"worktree_path": rec_wt,
|
||||||
|
"claimant": {"username": "author-user", "profile": "prgs-author"},
|
||||||
|
}
|
||||||
|
record_src = dict(record)
|
||||||
|
record_src["worktree_path"] = self.source
|
||||||
|
issue_lock_store.bind_session_lock(record_src, lock_dir=lock_dir)
|
||||||
|
path = issue_lock_store.bind_session_lock(
|
||||||
|
record,
|
||||||
|
lock_dir=lock_dir,
|
||||||
|
recovery_sanctioned=True,
|
||||||
|
)
|
||||||
|
self.assertTrue(os.path.isfile(path))
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
unittest.main()
|
||||||
@@ -24,6 +24,8 @@ def _lease(expires_at: str) -> dict:
|
|||||||
|
|
||||||
|
|
||||||
def _lock_record(**overrides) -> dict:
|
def _lock_record(**overrides) -> dict:
|
||||||
|
# #860: live locks require a usable session pid; PID-less records are never
|
||||||
|
# classified live merely because expiry/heartbeat fields are present.
|
||||||
record = {
|
record = {
|
||||||
"issue_number": 420,
|
"issue_number": 420,
|
||||||
"branch_name": "feat/issue-420-server-code-parity",
|
"branch_name": "feat/issue-420-server-code-parity",
|
||||||
@@ -31,6 +33,8 @@ def _lock_record(**overrides) -> dict:
|
|||||||
"org": "Scaled-Tech-Consulting",
|
"org": "Scaled-Tech-Consulting",
|
||||||
"repo": "Gitea-Tools",
|
"repo": "Gitea-Tools",
|
||||||
"worktree_path": "/tmp/wt-420",
|
"worktree_path": "/tmp/wt-420",
|
||||||
|
"session_pid": os.getpid(),
|
||||||
|
"pid": os.getpid(),
|
||||||
"work_lease": _lease("2999-01-01T00:00:00Z"),
|
"work_lease": _lease("2999-01-01T00:00:00Z"),
|
||||||
}
|
}
|
||||||
record.update(overrides)
|
record.update(overrides)
|
||||||
@@ -88,6 +92,8 @@ class TestIssueLockStore(unittest.TestCase):
|
|||||||
existing = _lock_record(
|
existing = _lock_record(
|
||||||
branch_name="feat/issue-420-other",
|
branch_name="feat/issue-420-other",
|
||||||
worktree_path="/tmp/other",
|
worktree_path="/tmp/other",
|
||||||
|
session_pid=os.getpid(),
|
||||||
|
pid=os.getpid(),
|
||||||
work_lease=_lease("2999-01-01T00:00:00Z"),
|
work_lease=_lease("2999-01-01T00:00:00Z"),
|
||||||
)
|
)
|
||||||
path = ils.lock_file_path(
|
path = ils.lock_file_path(
|
||||||
|
|||||||
@@ -19,7 +19,6 @@ from pr_work_lease import ( # noqa: E402
|
|||||||
assess_reviewer_mutation_blocked,
|
assess_reviewer_mutation_blocked,
|
||||||
assess_reviewer_stale_head_final_report,
|
assess_reviewer_stale_head_final_report,
|
||||||
format_conflict_fix_lease_body,
|
format_conflict_fix_lease_body,
|
||||||
find_active_conflict_fix_lease,
|
|
||||||
parse_conflict_fix_lease_comment,
|
parse_conflict_fix_lease_comment,
|
||||||
parse_reviewer_lease_comment,
|
parse_reviewer_lease_comment,
|
||||||
)
|
)
|
||||||
@@ -204,157 +203,5 @@ class TestFormatLease(unittest.TestCase):
|
|||||||
self.assertEqual(parsed["pr_number"], 376)
|
self.assertEqual(parsed["pr_number"], 376)
|
||||||
|
|
||||||
|
|
||||||
class TestConflictFixLeaseLifecycle(unittest.TestCase):
|
|
||||||
def test_claim_followed_by_matching_release(self):
|
|
||||||
claim_body = _conflict_fix_body(phase="claimed", worktree="branches/fix-376")
|
|
||||||
expires = (NOW + timedelta(minutes=60)).isoformat().replace("+00:00", "Z")
|
|
||||||
release_body = "\n".join([
|
|
||||||
CONFLICT_FIX_LEASE_MARKER,
|
|
||||||
"pr: #376",
|
|
||||||
"branch: feat/fix-376",
|
|
||||||
"worktree: branches/fix-376",
|
|
||||||
"profile: prgs-author",
|
|
||||||
"phase: released",
|
|
||||||
f"head_before: {HEAD_A}",
|
|
||||||
f"head_after: {HEAD_B}",
|
|
||||||
f"expires_at: {expires}",
|
|
||||||
])
|
|
||||||
comments = [{"body": claim_body}, {"body": release_body}]
|
|
||||||
lease = find_active_conflict_fix_lease(comments, pr_number=376, now=NOW)
|
|
||||||
self.assertIsNone(lease)
|
|
||||||
|
|
||||||
def test_expired_claim_without_release(self):
|
|
||||||
past_expires = (NOW - timedelta(minutes=10)).isoformat().replace("+00:00", "Z")
|
|
||||||
claim_body = "\n".join([
|
|
||||||
CONFLICT_FIX_LEASE_MARKER,
|
|
||||||
"pr: #376",
|
|
||||||
"phase: claimed",
|
|
||||||
f"head_before: {HEAD_A}",
|
|
||||||
f"expires_at: {past_expires}",
|
|
||||||
"profile: prgs-author",
|
|
||||||
])
|
|
||||||
comments = [{"body": claim_body}]
|
|
||||||
lease = find_active_conflict_fix_lease(comments, pr_number=376, now=NOW)
|
|
||||||
self.assertIsNone(lease)
|
|
||||||
|
|
||||||
def test_mismatched_release_different_head(self):
|
|
||||||
claim_body = _conflict_fix_body(phase="claimed", worktree="branches/fix-376")
|
|
||||||
expires = (NOW + timedelta(minutes=60)).isoformat().replace("+00:00", "Z")
|
|
||||||
release_body = "\n".join([
|
|
||||||
CONFLICT_FIX_LEASE_MARKER,
|
|
||||||
"pr: #376",
|
|
||||||
"profile: prgs-author",
|
|
||||||
"phase: released",
|
|
||||||
f"head_before: {HEAD_B}",
|
|
||||||
f"expires_at: {expires}",
|
|
||||||
])
|
|
||||||
comments = [{"body": claim_body}, {"body": release_body}]
|
|
||||||
lease = find_active_conflict_fix_lease(comments, pr_number=376, now=NOW)
|
|
||||||
self.assertIsNotNone(lease)
|
|
||||||
self.assertEqual(lease["phase"], "claimed")
|
|
||||||
|
|
||||||
def test_mismatched_release_different_branch(self):
|
|
||||||
claim_body = "\n".join([
|
|
||||||
CONFLICT_FIX_LEASE_MARKER,
|
|
||||||
"pr: #376",
|
|
||||||
"branch: feat/branch-A",
|
|
||||||
"phase: claimed",
|
|
||||||
f"head_before: {HEAD_A}",
|
|
||||||
f"expires_at: {(NOW + timedelta(minutes=60)).isoformat().replace('+00:00', 'Z')}",
|
|
||||||
"profile: prgs-author",
|
|
||||||
])
|
|
||||||
release_body = "\n".join([
|
|
||||||
CONFLICT_FIX_LEASE_MARKER,
|
|
||||||
"pr: #376",
|
|
||||||
"branch: feat/branch-B",
|
|
||||||
"phase: released",
|
|
||||||
f"head_before: {HEAD_A}",
|
|
||||||
f"expires_at: {(NOW + timedelta(minutes=60)).isoformat().replace('+00:00', 'Z')}",
|
|
||||||
"profile: prgs-author",
|
|
||||||
])
|
|
||||||
comments = [{"body": claim_body}, {"body": release_body}]
|
|
||||||
lease = find_active_conflict_fix_lease(comments, pr_number=376, now=NOW)
|
|
||||||
self.assertIsNotNone(lease)
|
|
||||||
self.assertEqual(lease["phase"], "claimed")
|
|
||||||
|
|
||||||
def test_release_followed_by_newer_claim(self):
|
|
||||||
claim_1 = _conflict_fix_body(phase="claimed", worktree="branches/fix-376")
|
|
||||||
expires = (NOW + timedelta(minutes=60)).isoformat().replace("+00:00", "Z")
|
|
||||||
release_1 = "\n".join([
|
|
||||||
CONFLICT_FIX_LEASE_MARKER,
|
|
||||||
"pr: #376",
|
|
||||||
"profile: prgs-author",
|
|
||||||
"phase: released",
|
|
||||||
f"head_before: {HEAD_A}",
|
|
||||||
f"head_after: {HEAD_B}",
|
|
||||||
f"expires_at: {expires}",
|
|
||||||
])
|
|
||||||
claim_2 = "\n".join([
|
|
||||||
CONFLICT_FIX_LEASE_MARKER,
|
|
||||||
"pr: #376",
|
|
||||||
"profile: prgs-author",
|
|
||||||
"phase: claimed",
|
|
||||||
f"head_before: {HEAD_B}",
|
|
||||||
f"expires_at: {expires}",
|
|
||||||
])
|
|
||||||
comments = [{"body": claim_1}, {"body": release_1}, {"body": claim_2}]
|
|
||||||
lease = find_active_conflict_fix_lease(comments, pr_number=376, now=NOW)
|
|
||||||
self.assertIsNotNone(lease)
|
|
||||||
self.assertEqual(lease["head_before"], HEAD_B)
|
|
||||||
|
|
||||||
def test_malformed_or_ambiguous_markers(self):
|
|
||||||
malformed_release = "\n".join([
|
|
||||||
CONFLICT_FIX_LEASE_MARKER,
|
|
||||||
"pr: #376",
|
|
||||||
"phase: released",
|
|
||||||
# missing head_before and profile
|
|
||||||
])
|
|
||||||
claim_body = _conflict_fix_body(phase="claimed")
|
|
||||||
comments = [{"body": claim_body}, {"body": malformed_release}]
|
|
||||||
lease = find_active_conflict_fix_lease(comments, pr_number=376, now=NOW)
|
|
||||||
self.assertIsNotNone(lease)
|
|
||||||
|
|
||||||
def test_pr818_historical_sequence(self):
|
|
||||||
comment_14696 = "\n".join([
|
|
||||||
"<!-- mcp-conflict-fix-lease:v1 -->",
|
|
||||||
"pr: #818",
|
|
||||||
"branch: feat/issue-638-webui-app-shell-phase1",
|
|
||||||
"worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-638-webui-app-shell-phase1",
|
|
||||||
"profile: prgs-author",
|
|
||||||
"session_id: unknown",
|
|
||||||
"phase: claimed",
|
|
||||||
"head_before: 08061b7b8aebdd099a37d1abf5dafcf38e4fd3fb",
|
|
||||||
"expires_at: 2026-07-23T07:12:13Z",
|
|
||||||
"reviewer_active: no",
|
|
||||||
])
|
|
||||||
comment_14730 = "\n".join([
|
|
||||||
"<!-- mcp-conflict-fix-lease:v1 -->",
|
|
||||||
"pr: #818",
|
|
||||||
"branch: feat/issue-638-webui-app-shell-phase1",
|
|
||||||
"worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/issue-638-webui-app-shell-phase1",
|
|
||||||
"profile: prgs-author",
|
|
||||||
"session_id: prgs-author-61241-e5129c60",
|
|
||||||
"phase: released",
|
|
||||||
"head_before: 08061b7b8aebdd099a37d1abf5dafcf38e4fd3fb",
|
|
||||||
"head_after: 64b6eb5d5402663098de5ded3b0617cc3b3df98f",
|
|
||||||
"expires_at: 2026-07-23T06:05:00Z",
|
|
||||||
"reviewer_active: no",
|
|
||||||
])
|
|
||||||
comments = [{"body": comment_14696}, {"body": comment_14730}]
|
|
||||||
check_now = datetime(2026, 7, 23, 6, 30, tzinfo=timezone.utc)
|
|
||||||
lease = find_active_conflict_fix_lease(comments, pr_number=818, now=check_now)
|
|
||||||
self.assertIsNone(lease)
|
|
||||||
|
|
||||||
reviewer_gate = assess_reviewer_mutation_blocked(
|
|
||||||
pr_number=818,
|
|
||||||
comments=comments,
|
|
||||||
reviewed_head_sha="64b6eb5d5402663098de5ded3b0617cc3b3df98f",
|
|
||||||
live_head_sha="64b6eb5d5402663098de5ded3b0617cc3b3df98f",
|
|
||||||
mutation="approve",
|
|
||||||
now=check_now,
|
|
||||||
)
|
|
||||||
self.assertTrue(reviewer_gate["mutation_allowed"])
|
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
unittest.main()
|
unittest.main()
|
||||||
Reference in New Issue
Block a user