feat: gate author work on early duplicate-work detection (Closes #400)

Add author_duplicate_work_gate and enforce it at claim, lock, and PR
creation. Expose gitea_assess_author_duplicate_work for pre-commit/push
checks and extend work-issue final-report verification.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

author_duplicate_work_gate.py

@@ -0,0 +1,198 @@
+"""Early duplicate-work detection for author work-issue flows (#400)."""
+
+from __future__ import annotations
+
+import re
+from typing import Any
+
+from issue_claim_heartbeat import (
+    _linked_open_pr,
+    _matching_branch_names,
+    classify_issue_claim,
+)
+
+STAGES = (
+    "claim",
+    "lock",
+    "worktree",
+    "edit",
+    "commit",
+    "push",
+    "create_pr",
+)
+
+ELIGIBILITY_OPEN_PR_EXISTS = "OPEN_PR_EXISTS"
+ELIGIBILITY_DUPLICATE_BRANCH_EXISTS = "DUPLICATE_BRANCH_EXISTS"
+ELIGIBILITY_ACTIVE_CLAIM = "ACTIVE_CLAIM_BY_OTHER"
+ELIGIBILITY_CLEAR = "CLEAR"
+
+
+def assess_author_duplicate_work(
+    issue_number: int,
+    *,
+    stage: str,
+    open_prs: list[dict] | None = None,
+    branch_names: list[str] | None = None,
+    claim_entry: dict | None = None,
+    matching_branches: list[str] | None = None,
+    allow_stale_takeover: bool = False,
+) -> dict[str, Any]:
+    """Fail closed when duplicate work is detected before author mutations (#400)."""
+    stage_norm = (stage or "").strip().lower()
+    if stage_norm not in STAGES:
+        return {
+            "allowed": False,
+            "block": True,
+            "eligibility_class": "INVALID_STAGE",
+            "stage": stage_norm or None,
+            "reasons": [f"unknown duplicate-work stage {stage!r}"],
+            "safe_next_action": f"use one of: {', '.join(STAGES)}",
+        }
+
+    prs = list(open_prs or [])
+    linked_pr = _linked_open_pr(int(issue_number), prs)
+    branches = list(
+        matching_branches
+        if matching_branches is not None
+        else _matching_branch_names(int(issue_number), list(branch_names or []))
+    )
+
+    reasons: list[str] = []
+    eligibility = ELIGIBILITY_CLEAR
+
+    if linked_pr:
+        eligibility = ELIGIBILITY_OPEN_PR_EXISTS
+        reasons.append(
+            f"open PR #{linked_pr.get('number')} already covers issue "
+            f"#{issue_number}"
+        )
+
+    if branches and stage_norm in {"claim", "lock", "worktree", "edit"}:
+        if eligibility == ELIGIBILITY_CLEAR:
+            eligibility = ELIGIBILITY_DUPLICATE_BRANCH_EXISTS
+        reasons.append(
+            f"remote branch(es) already exist for issue #{issue_number}: "
+            f"{', '.join(branches)}"
+        )
+
+    entry = claim_entry or {}
+    claim_status = (entry.get("status") or "").strip()
+    if claim_status in {"active", "awaiting_review"} and stage_norm == "claim":
+        if entry.get("reclaimable") and allow_stale_takeover:
+            pass
+        elif claim_status == "active" and not entry.get("reclaimable"):
+            if eligibility == ELIGIBILITY_CLEAR:
+                eligibility = ELIGIBILITY_ACTIVE_CLAIM
+            reasons.append(
+                f"issue #{issue_number} has active claim "
+                f"(status={claim_status})"
+            )
+    elif claim_status == "awaiting_review" and stage_norm == "claim":
+        if not linked_pr:
+            reasons.append(
+                f"issue #{issue_number} is awaiting_review but no linked open PR "
+                "was supplied for duplicate-work proof"
+            )
+
+    allowed = not reasons
+    outcome = "duplicate_work_prevented" if not allowed else "clear"
+    if stage_norm == "create_pr" and not allowed:
+        outcome = "duplicate_pr_prevented"
+    elif stage_norm in {"commit", "push"} and not allowed:
+        outcome = "duplicate_push_prevented" if stage_norm == "push" else "duplicate_commit_prevented"
+
+    return {
+        "allowed": allowed,
+        "block": not allowed,
+        "eligibility_class": eligibility if not allowed else ELIGIBILITY_CLEAR,
+        "stage": stage_norm,
+        "linked_open_pr": linked_pr.get("number") if linked_pr else None,
+        "matching_branches": branches,
+        "claim_status": claim_status or None,
+        "outcome": outcome,
+        "reasons": reasons,
+        "safe_next_action": (
+            "stop without edits/commit/push/PR; produce reconciliation handoff "
+            "preserving local work only"
+            if not allowed
+            else "proceed"
+        ),
+    }
+
+
+def build_claim_entry_from_classification(classification: dict) -> dict:
+    """Map ``classify_issue_claim`` output to gate claim metadata."""
+    return {
+        "status": classification.get("status"),
+        "reclaimable": classification.get("reclaimable"),
+        "linked_open_pr": classification.get("linked_open_pr"),
+    }
+
+
+_DUPLICATE_OUTCOME_RE = re.compile(
+    r"(duplicate\s+(?:pr|branch|commit|push)\s+prevented|"
+    r"duplicate\s+work\s+not\s+prevented|reconciliation\s+handoff)",
+    re.IGNORECASE,
+)
+
+
+def assess_work_issue_duplicate_prevention_report(report_text: str) -> dict:
+    """#400: work-issue reports must state duplicate-work prevention outcome."""
+    text = report_text or ""
+    if "duplicate work" not in text.lower() and "duplicate pr" not in text.lower():
+        return {
+            "proven": True,
+            "block": False,
+            "reasons": [],
+            "safe_next_action": "proceed",
+        }
+    if _DUPLICATE_OUTCOME_RE.search(text):
+        return {
+            "proven": True,
+            "block": False,
+            "reasons": [],
+            "safe_next_action": "proceed",
+        }
+    return {
+        "proven": False,
+        "block": True,
+        "reasons": [
+            "duplicate-work discussion must name a prevention outcome "
+            "(duplicate PR/branch/commit/push prevented, or duplicate work "
+            "not prevented, or reconciliation handoff)"
+        ],
+        "safe_next_action": "state exact duplicate-work prevention class in final report",
+    }
+
+
+def classify_and_assess(
+    issue: dict,
+    *,
+    stage: str,
+    comments: list[dict] | None = None,
+    open_prs: list[dict] | None = None,
+    branch_names: list[str] | None = None,
+    allow_stale_takeover: bool = False,
+) -> dict[str, Any]:
+    """Combine claim classification with duplicate-work gate assessment."""
+    issue_number = int(issue.get("number") or 0)
+    claim = classify_issue_claim(
+        issue=issue,
+        comments=comments or [],
+        open_prs=open_prs or [],
+        branch_names=branch_names or [],
+    )
+    assessment = assess_author_duplicate_work(
+        issue_number,
+        stage=stage,
+        open_prs=open_prs,
+        branch_names=branch_names,
+        claim_entry=build_claim_entry_from_classification(claim),
+        matching_branches=claim.get("matching_branches"),
+        allow_stale_takeover=allow_stale_takeover,
+    )
+    return {
+        "issue_number": issue_number,
+        "claim": claim,
+        "duplicate_work": assessment,
+    }

docs/webui-local-dev.md

@@ -1,89 +0,0 @@
-# Internal web UI — local development (#426)
-
-Read-only MVP skeleton for the MCP Control Plane operator console. Gitea,
-MCP capability gates, and `skills/llm-project-workflow/` remain the source of
-truth; this UI only provides route stubs and layout.
-
-## Prerequisites
-
-- Python 3.11+ with project dependencies installed (`pip install -r requirements.txt`)
-- No secrets in repo, config, or client bundle
-
-## Start the server
-
-From the repository root (or an issue worktree):
-
-```bash
-./scripts/run-webui
-```
-
-Or directly:
-
-```bash
-python3 -m webui
-```
-
-Optional environment variables:
-
-| Variable | Default | Purpose |
-|----------|---------|---------|
-| `WEBUI_HOST` | `127.0.0.1` | Bind address (keep local for MVP) |
-| `WEBUI_PORT` | `8765` | Listen port |
-
-## Routes (MVP)
-
-| Path | Description |
-|------|-------------|
-| `/` | Home / operator overview |
-| `/health` | JSON liveness (`status`, `service`, `mode`, `timestamp`) |
-| `/queue` | Live PR and issue queue dashboard (#429) |
-| `/api/queue` | JSON queue export with pagination metadata |
-| `/projects` | Project registry list (#427) |
-| `/projects/{id}` | Project detail + onboarding checklist |
-| `/api/projects` | JSON registry export |
-| `/prompts` | Prompt library with per-prompt copy buttons (#428) |
-| `/api/prompts` | JSON prompt export with workflow hashes |
-| `/runtime` | Stub — MCP runtime health (#430) |
-| `/audit` | Stub — report audit paste (#431) |
-| `/worktrees` | Stub — hygiene dashboard (#432) |
-| `/leases` | Stub — lease visibility (#433) |
-
-All routes are GET-only. POST/PUT/PATCH/DELETE return `405` with
-`read-only-mvp`.
-
-## Project registry (#427)
-
-Versioned registry file: `webui/data/projects.registry.json` (schema version `1`).
-
-Override path with `WEBUI_PROJECT_REGISTRY` when operators keep a machine-local
-copy outside git. The registry stores repo identity, remotes, profile names,
-workflow/schema path references, and onboarding checklist steps — never tokens
-or credentials.
-
-Seed entry: **Gitea-Tools** on `https://gitea.prgs.cc` with `prgs-author`,
-`prgs-reviewer`, and `prgs-reconciler` profiles.
-
-## Prompt library (#428)
-
-Prompts are generated at load time from canonical workflow files under
-`skills/llm-project-workflow/workflows/`. SHA-256 hashes are computed from
-`WEBUI_REPO_ROOT` (defaults to the repository root). Prompt bodies are short
-copy/paste starters; canonical workflow files remain the only full policy
-source.
-
-## Live queue dashboard (#429)
-
-`/queue` loads open PRs and issues for the default registry project (seed:
-**Gitea-Tools** on `https://gitea.prgs.cc`) using existing `gitea_auth` read
-credentials. The UI surfaces pagination proof (returned count, pages fetched,
-`has_more`, `inventory_complete`) and classification badges (`claimed`,
-`blocked`, `in-review`, `duplicate`) when evidence exists.
-
-If credentials are missing or the fetch fails, the page shows an explicit error
-instead of an empty queue (fail closed).
-
-## Tests
-
-```bash
-pytest tests/test_webui_skeleton.py tests/test_webui_project_registry.py tests/test_webui_prompt_library.py tests/test_webui_queue_dashboard.py -q
-```

final_report_validator.py

@@ -456,40 +456,6 @@ def _rule_reviewer_git_fetch_readonly(
     return []
 
 
-def _rule_reviewer_validation_failure_history(
-    report_text: str,
-    *,
-    validation_session: dict | None = None,
-) -> list[dict[str, str]]:
-    from reviewer_validation_failure_history import (
-        assess_validation_failure_history_report,
-    )
-
-    session = validation_session or {}
-    observed = session.get("observed_failures") or []
-    if not observed:
-        return []
-
-    result = assess_validation_failure_history_report(
-        report_text,
-        validation_session=session,
-    )
-    if result.get("proven"):
-        return []
-    severity = "block" if result.get("violations") else "downgrade"
-    return [
-        validator_finding(
-            "reviewer.validation_failure_history",
-            severity,
-            "Validation failure history",
-            reason,
-            result.get("safe_next_action")
-            or "document every observed validation failure before claiming pass",
-        )
-        for reason in (result.get("violations") or result.get("reasons") or ["incomplete"])
-    ]
-
-
 def _rule_reviewer_validation_command(report_text: str) -> list[dict[str, str]]:
     text = report_text or ""
     if not _BARE_PYTEST_RE.search(text):
@@ -898,7 +864,6 @@ _RULES_BY_TASK: dict[str, list[Callable[..., list[dict[str, str]]]]] = {
         _rule_reviewer_mutation_categories,
         _rule_reviewer_git_fetch_readonly,
         _rule_reviewer_validation_command,
-        _rule_reviewer_validation_failure_history,
         _rule_reviewer_validation_structured,
         _rule_reviewer_linked_issue,
         _rule_reviewer_baseline_on_failure,
@@ -1005,7 +970,6 @@ def assess_final_report_validator(
     local_edits: bool = False,
     issue_filing_lock: dict | None = None,
     session_pr_opened: bool = False,
-    validation_session: dict | None = None,
 ) -> dict[str, Any]:
     """Validate final-report text against task-specific proof rules (#327).
 
@@ -1061,7 +1025,6 @@ def assess_final_report_validator(
         "mutations_observed": mutations_observed,
         "local_edits": local_edits,
         "session_pr_opened": session_pr_opened,
-        "validation_session": validation_session,
     }
 
     for rule in _RULES_BY_TASK.get(normalized_kind, ()):

gitea_mcp_server.py

@@ -440,48 +440,10 @@ def verify_preflight_purity(remote: str | None = None, worktree_path: str | None
             "Pre-flight order violation: Task capability (gitea_resolve_task_capability) has not been resolved (fail closed)"
         )
 
-    workspace = author_mutation_worktree.resolve_mutation_workspace(
-        worktree_path,
-        PROJECT_ROOT,
-        active_worktree_env=os.environ.get(ACTIVE_WORKTREE_ENV),
-        author_worktree_env=os.environ.get(AUTHOR_WORKTREE_ENV),
-    )
-    real_workspace = os.path.realpath(workspace)
-    real_root = os.path.realpath(PROJECT_ROOT)
-
-    if real_workspace != real_root:
-        if not _preflight_in_test_mode():
-            if not os.path.exists(real_workspace):
-                raise RuntimeError(
-                    f"Branches-only mutation guard (#274): worktree path '{workspace}' does not exist (fail closed)"
-                )
-            if not os.path.isdir(real_workspace):
-                raise RuntimeError(
-                    f"Branches-only mutation guard (#274): worktree path '{workspace}' is not a directory (fail closed)"
-                )
-            try:
-                res = subprocess.run(
-                    ["git", "-C", real_workspace, "rev-parse", "--git-common-dir"],
-                    capture_output=True,
-                    text=True,
-                    check=True,
-                )
-                common_dir = os.path.realpath(res.stdout.strip())
-                expected_dir = os.path.realpath(os.path.join(real_root, ".git"))
-                if common_dir != expected_dir:
-                    raise RuntimeError(
-                        f"Branches-only mutation guard (#274): worktree '{workspace}' does not belong to the target repository '{PROJECT_ROOT}' (fail closed)"
-                    )
-            except Exception as e:
-                if isinstance(e, RuntimeError):
-                    raise e
-                raise RuntimeError(
-                    f"Branches-only mutation guard (#274): worktree '{workspace}' is not a valid git repository (fail closed)"
-                )
-
-        dirty_files = sorted(_parse_porcelain_entries(_get_workspace_porcelain(workspace)))
+    if worktree_path:
+        dirty_files = sorted(_parse_porcelain_entries(_get_workspace_porcelain(worktree_path)))
         if dirty_files:
-            details = _preflight_workspace_details(workspace, dirty_files)
+            details = _preflight_workspace_details(worktree_path, dirty_files)
             raise RuntimeError(
                 "Pre-flight order violation: Active task workspace has tracked "
                 "file edits before mutation (fail closed). "
@@ -541,6 +503,7 @@ import issue_lock_worktree  # noqa: E402
 import already_landed_reconcile  # noqa: E402
 import author_mutation_worktree  # noqa: E402
 import issue_claim_heartbeat  # noqa: E402
+import author_duplicate_work_gate  # noqa: E402
 import merged_cleanup_reconcile  # noqa: E402
 import reconciler_profile  # noqa: E402
 import reconciliation_workflow  # noqa: E402
@@ -1010,7 +973,6 @@ def gitea_create_issue(
     repo: str | None = None,
     allow_duplicate_override: bool = False,
     split_from_issue: int | None = None,
-    worktree_path: str | None = None,
 ) -> dict:
     """Create a new issue on a Gitea repository.
 
@@ -1023,7 +985,6 @@ def gitea_create_issue(
         repo: Override the repository name.
         allow_duplicate_override: Operator-approved split after duplicate found.
         split_from_issue: Existing duplicate issue number when overriding.
-        worktree_path: Optional path to verify branches-only guard.
 
     Returns:
         dict with 'number' of the created issue ('url' only with the reveal opt-in).
@@ -1050,7 +1011,7 @@ def gitea_create_issue(
     )
     if blocked:
         return blocked
-    verify_preflight_purity(remote, worktree_path=worktree_path)
+    verify_preflight_purity(remote)
     base = repo_api_url(h, o, r)
     open_issues = api_get_all(f"{base}/issues?state=open&type=issues", auth)
     closed_issues = api_get_all(
@@ -1089,6 +1050,76 @@ def gitea_create_issue(
     return _with_optional_url({"number": data["number"]}, data.get("html_url"))
 
 
+def _list_repo_branch_names(h: str, o: str, r: str, auth: str, *, limit: int = 200) -> list[str]:
+    branches = api_get_all(f"{repo_api_url(h, o, r)}/branches", auth, limit=limit)
+    return [_branch_entry_name(branch) for branch in branches]
+
+
+def _gather_author_duplicate_work_context(
+    issue_number: int,
+    *,
+    h: str,
+    o: str,
+    r: str,
+    auth: str,
+    exclude_branch_name: str | None = None,
+) -> dict:
+    base = repo_api_url(h, o, r)
+    issue = api_request("GET", f"{base}/issues/{issue_number}", auth)
+    comments = api_request("GET", f"{base}/issues/{issue_number}/comments", auth) or []
+    open_prs = api_get_all(f"{base}/pulls?state=open", auth)
+    branch_names = _list_repo_branch_names(h, o, r, auth)
+    if exclude_branch_name:
+        branch_names = [
+            name for name in branch_names
+            if name != exclude_branch_name
+        ]
+    return {
+        "issue": issue,
+        "comments": comments,
+        "open_prs": open_prs,
+        "branch_names": branch_names,
+    }
+
+
+def _enforce_author_duplicate_work_gate(
+    issue_number: int,
+    stage: str,
+    *,
+    h: str,
+    o: str,
+    r: str,
+    auth: str,
+    allow_stale_takeover: bool = False,
+    exclude_branch_name: str | None = None,
+) -> dict:
+    """Fail closed when duplicate work is detected (#400)."""
+    ctx = _gather_author_duplicate_work_context(
+        issue_number,
+        h=h,
+        o=o,
+        r=r,
+        auth=auth,
+        exclude_branch_name=exclude_branch_name,
+    )
+    result = author_duplicate_work_gate.classify_and_assess(
+        ctx["issue"],
+        stage=stage,
+        comments=ctx["comments"],
+        open_prs=ctx["open_prs"],
+        branch_names=ctx["branch_names"],
+        allow_stale_takeover=allow_stale_takeover,
+    )
+    assessment = result.get("duplicate_work") or {}
+    if assessment.get("block"):
+        reasons = "; ".join(assessment.get("reasons") or ["duplicate work detected"])
+        raise RuntimeError(
+            f"Author duplicate-work gate (#400) blocked at stage '{stage}': "
+            f"{reasons} (fail closed)"
+        )
+    return result
+
+
 @mcp.tool()
 def gitea_lock_issue(
     issue_number: int,
@@ -1151,48 +1182,17 @@ def gitea_lock_issue(
             issue_lock_worktree.format_issue_lock_worktree_error(lock_assessment)
         )
 
-    # 2. Check if the issue already has an open PR (reuse protection)
     h, o, r = _resolve(remote, host, org, repo)
     auth = _auth(h)
-    url = f"{repo_api_url(h, o, r)}/pulls?state=open"
-
-    try:
-        prs = api_get_all(url, auth)
-    except Exception as e:
-        raise RuntimeError(f"Could not list open PRs to verify issue lock: {e}")
-
-    for pr in prs:
-        pr_head = pr.get("head", {}).get("ref", "")
-        pr_title = pr.get("title", "")
-        pr_body = pr.get("body", "")
-
-        if expected_pattern in pr_head:
-            raise ValueError(
-                f"Issue #{issue_number} is already tied to an open PR (PR #{pr.get('number')}, branch '{pr_head}') (fail closed)"
-            )
-
-        patterns = [
-            f"closes #{issue_number}",
-            f"fixes #{issue_number}",
-        ]
-        text_to_check = f"{pr_title} {pr_body}".lower()
-        if any(p in text_to_check for p in patterns):
-            raise ValueError(
-                f"Issue #{issue_number} is already tied to an open PR (PR #{pr.get('number')}) via Closes/Fixes reference (fail closed)"
-            )
-
-    branch_url = f"{repo_api_url(h, o, r)}/branches"
-    try:
-        branches = api_get_all(branch_url, auth)
-    except Exception as e:
-        raise RuntimeError(f"Could not list branches to verify issue lock: {e}")
-    for branch in branches:
-        name = _branch_entry_name(branch)
-        if expected_pattern in name:
-            raise ValueError(
-                f"Issue #{issue_number} already has matching branch '{name}' "
-                "(fail closed)"
-            )
+    _enforce_author_duplicate_work_gate(
+        issue_number,
+        "lock",
+        h=h,
+        o=o,
+        r=r,
+        auth=auth,
+        exclude_branch_name=branch_name,
+    )
 
     work_lease = _build_author_issue_work_lease(
         issue_number=issue_number,
@@ -1313,6 +1313,17 @@ def gitea_create_pr(
             f"PR head branch '{head}' does not match locked branch '{locked_branch}' (fail closed)"
         )
 
+    auth = _auth(h)
+    _enforce_author_duplicate_work_gate(
+        int(locked_issue),
+        "create_pr",
+        h=h,
+        o=o,
+        r=r,
+        auth=auth,
+        exclude_branch_name=locked_branch,
+    )
+
     # Check for forbidden terms anywhere in title/body
     forbidden_terms = ["equivalent", "related", "same as"]
     text_to_check = f"{title} {body}".lower()
@@ -1329,7 +1340,6 @@ def gitea_create_pr(
             f"PR title or body must contain 'Closes #{locked_issue}' or 'Fixes #{locked_issue}' exactly to ensure durable tracking (fail closed)"
         )
 
-    auth = _auth(h)
     url = f"{repo_api_url(h, o, r)}/pulls"
     payload = {"title": title, "body": body, "head": head, "base": base}
     meta = {"title": title, "head": head, "base": base}
@@ -3504,32 +3514,16 @@ def gitea_delete_branch(
         repo: Override the repository name.
 
     Returns:
-        dict with 'success' and 'message'; on a permission block,
-        'success'/'performed' False, 'reasons', and a structured
-        'permission_report' (#142) with no API call made.
+        dict with 'success' and 'message'.
     """
-    gate_reasons = _profile_operation_gate("gitea.branch.delete")
-    if gate_reasons:
-        return {
-            "success": False,
-            "performed": False,
-            "required_permission": "gitea.branch.delete",
-            "reasons": gate_reasons,
-            "permission_report": _permission_block_report("gitea.branch.delete"),
-        }
-
     verify_preflight_purity(remote)
     h, o, r = _resolve(remote, host, org, repo)
     auth = _auth(h)
     import urllib.parse
     encoded_branch = urllib.parse.quote(branch, safe="")
     url = f"{repo_api_url(h, o, r)}/branches/{encoded_branch}"
-    request_metadata = {
-        "branch": branch,
-        "required_permission": "gitea.branch.delete",
-    }
     with _audited("delete_branch", host=h, remote=remote, org=o, repo=r,
-                  target_branch=branch, request_metadata=request_metadata):
+                  target_branch=branch, request_metadata={"branch": branch}):
         api_request("DELETE", url, auth)
     return {"success": True, "message": f"Remote branch '{branch}' deleted."}
 
@@ -5566,7 +5560,6 @@ def gitea_validate_review_final_report(
     action_log: list[dict] | None = None,
     mutations_observed: bool = False,
     local_edits: bool = False,
-    validation_session: dict | None = None,
 ) -> dict:
     """Read-only: machine-validate reviewer final report schema before output (#391).
 
@@ -5584,7 +5577,6 @@ def gitea_validate_review_final_report(
         action_log=action_log,
         mutations_observed=mutations_observed,
         local_edits=local_edits,
-        validation_session=validation_session,
     )
 
 
@@ -6043,6 +6035,14 @@ def gitea_mark_issue(
         )
 
     if action == "start":
+        _enforce_author_duplicate_work_gate(
+            issue_number,
+            "claim",
+            h=h,
+            o=o,
+            r=r,
+            auth=auth,
+        )
         with _audited("label_issue", host=h, remote=remote, org=o, repo=r,
                       issue_number=issue_number,
                       request_metadata={"op": "add", "label": "status:in-progress"}):
@@ -6124,6 +6124,65 @@ def gitea_post_heartbeat(
     )
 
 
+@mcp.tool()
+def gitea_assess_author_duplicate_work(
+    issue_number: int,
+    stage: str,
+    remote: str = "dadeschools",
+    host: str | None = None,
+    org: str | None = None,
+    repo: str | None = None,
+    allow_stale_takeover: bool = False,
+    exclude_branch_name: str | None = None,
+) -> dict:
+    """Read-only: assess duplicate-work risk before author mutations (#400).
+
+    Call at claim, lock, worktree, edit, commit, push, and create_pr stages.
+    """
+    read_block = _profile_operation_gate("gitea.read")
+    if read_block:
+        return {
+            "success": False,
+            "reasons": read_block,
+            "permission_report": _permission_block_report("gitea.read"),
+        }
+    h, o, r = _resolve(remote, host, org, repo)
+    auth = _auth(h)
+    ctx = _gather_author_duplicate_work_context(
+        issue_number,
+        h=h,
+        o=o,
+        r=r,
+        auth=auth,
+        exclude_branch_name=exclude_branch_name,
+    )
+    result = author_duplicate_work_gate.classify_and_assess(
+        ctx["issue"],
+        stage=stage,
+        comments=ctx["comments"],
+        open_prs=ctx["open_prs"],
+        branch_names=ctx["branch_names"],
+        allow_stale_takeover=allow_stale_takeover,
+    )
+    assessment = result.get("duplicate_work") or {}
+    return {
+        "success": True,
+        "performed": False,
+        "issue_number": issue_number,
+        "stage": stage,
+        "allowed": assessment.get("allowed"),
+        "block": assessment.get("block"),
+        "eligibility_class": assessment.get("eligibility_class"),
+        "outcome": assessment.get("outcome"),
+        "linked_open_pr": assessment.get("linked_open_pr"),
+        "matching_branches": assessment.get("matching_branches"),
+        "claim_status": assessment.get("claim_status"),
+        "reasons": assessment.get("reasons"),
+        "safe_next_action": assessment.get("safe_next_action"),
+        "claim": result.get("claim"),
+    }
+
+
 @mcp.tool()
 def gitea_reconcile_issue_claims(
     state: str = "open",

review_final_report_schema.py

@@ -301,7 +301,6 @@ def assess_review_final_report_schema(
     action_log: list[dict] | None = None,
     mutations_observed: bool = False,
     local_edits: bool = False,
-    validation_session: dict | None = None,
 ) -> dict[str, Any]:
     """Validate reviewer final report text before session completion (#391)."""
     base = assess_final_report_validator(
@@ -313,7 +312,6 @@ def assess_review_final_report_schema(
         action_log=action_log,
         mutations_observed=mutations_observed,
         local_edits=local_edits,
-        validation_session=validation_session,
     )
     extra: list[dict[str, str]] = []
     for rule in _SCHEMA_RULES:

review_proofs.py

@@ -1735,11 +1735,6 @@ def build_final_report(checkout_proof, inventory, validation, contamination,
         if report_text
         else {"proven": True, "block": False, "reasons": []}
     )
-    proof_backed_handoff = (
-        assess_proof_backed_handoff_report(report_text)
-        if report_text and _PROOF_BACKED_HANDOFF_HINT.search(report_text)
-        else {"proven": True, "block": False, "reasons": []}
-    )
     if baseline_validation is None and report_text:
         baseline_validation = assess_reviewer_baseline_validation_proof(
             report_text=report_text,
@@ -1942,11 +1937,6 @@ def build_final_report(checkout_proof, inventory, validation, contamination,
             "reviewer baseline validation proof missing or failed (#325)"
         )
         downgrade_reasons.extend(baseline_validation.get("reasons", []))
-    if not proof_backed_handoff.get("proven"):
-        downgrade_reasons.append(
-            "proof-sensitive handoff claims lack command/tool evidence (#395)"
-        )
-        downgrade_reasons.extend(proof_backed_handoff.get("reasons", []))
     if not already_landed_classification.get("proven"):
         downgrade_reasons.append(
             "already-landed classification wording missing or invalid (#295)"
@@ -3622,18 +3612,33 @@ def assess_work_issue_mode_isolation(report_text: str) -> dict:
     }
 
 
+def assess_work_issue_duplicate_prevention_report(report_text, **kwargs):
+    """#400: work-issue reports must classify duplicate-work prevention."""
+    from author_duplicate_work_gate import (
+        assess_work_issue_duplicate_prevention_report as _assess,
+    )
+
+    return _assess(report_text, **kwargs)
+
+
 def assess_work_issue_final_report(report_text: str) -> dict:
     """#139: composite verifier for work-issue final reports."""
     checks = {
         "workflow_source": assess_work_issue_workflow_source(report_text),
         "mode_isolation": assess_work_issue_mode_isolation(report_text),
+        "duplicate_prevention": assess_work_issue_duplicate_prevention_report(
+            report_text
+        ),
     }
 
     reasons = []
     downgraded = False
     for name, result in checks.items():
         verdict = result.get("verdict")
-        if verdict in ("missing", "incomplete"):
+        if result.get("block"):
+            downgraded = True
+            reasons.extend(result.get("reasons") or [])
+        elif verdict in ("missing", "incomplete"):
             downgraded = True
             reasons.extend(result.get("reasons") or [])
         elif result.get("downgraded") or not result.get("complete", True):
@@ -3641,6 +3646,9 @@ def assess_work_issue_final_report(report_text: str) -> dict:
             reasons.extend(
                 f"{name}: {r}" for r in (result.get("reasons") or [])
             )
+        elif result.get("proven") is False:
+            downgraded = True
+            reasons.extend(result.get("reasons") or [])
 
     grade = "A" if not downgraded else "downgraded"
     return {
@@ -5098,12 +5106,6 @@ _PR_QUEUE_CLEANUP_REPORT_HINT = re.compile(
     re.I,
 )
 
-_PROOF_BACKED_HANDOFF_HINT = re.compile(
-    r"task:\s*review-merge-pr|task mode:\s*review-merge-pr|"
-    r"review-merge-pr|controller handoff",
-    re.I,
-)
-
 
 def assess_pr_queue_cleanup_report(report_text: str | None) -> dict:
     """#390: validate PR-only cleanup final reports (one PR per run)."""
@@ -5503,15 +5505,6 @@ def assess_validation_integrity_report(report_text, **kwargs):
     return _assess(report_text, **kwargs)
 
 
-def assess_validation_failure_history_report(report_text, **kwargs):
-    """#396: final reports must account for transient validation failures."""
-    from reviewer_validation_failure_history import (
-        assess_validation_failure_history_report as _assess,
-    )
-
-    return _assess(report_text, **kwargs)
-
-
 def assess_already_landed_classification_report(report_text, **kwargs):
     """#295: already-landed PRs are reconciliation-only, not review eligible."""
     from reviewer_already_landed_classification import (
@@ -5591,10 +5584,3 @@ def assess_worktree_ownership_report(report_text, **kwargs):
     from reviewer_worktree_ownership import assess_worktree_ownership_report as _assess
 
     return _assess(report_text, **kwargs)
-
-
-def assess_proof_backed_handoff_report(report_text, **kwargs):
-    """#395: proof-sensitive review handoff claims require explicit evidence."""
-    from reviewer_proof_backed_handoff import assess_proof_backed_handoff_report as _assess
-
-    return _assess(report_text, **kwargs)

reviewer_proof_backed_handoff.py

@@ -1,217 +0,0 @@
-"""Proof-backed reviewer handoff claim verifier (#395)."""
-
-from __future__ import annotations
-
-import re
-from typing import Any
-
-_PAGINATION_FINALITY = re.compile(
-    r"has_more\s*:\s*false|is_final_page\s*:\s*true|"
-    r"inventory_complete\s*:\s*true|pages_fetched|total_count\s*:",
-    re.I,
-)
-_PAGE_SIZE_ONLY = re.compile(
-    r"(?:less|fewer) than (?:the )?(?:default )?page[- ]?size|"
-    r"under (?:the )?50[- ]?(?:item )?limit|"
-    r"returned \d+ (?:open )?prs?.*less than 50",
-    re.I,
-)
-_INVENTORY_COMPLETE_CLAIM = re.compile(
-    r"\b(?:inventory (?:is )?complete|inventory exhaustive|"
-    r"complete (?:pr )?inventory)\b",
-    re.I,
-)
-_SKIP_CLAIM = re.compile(
-    r"\b(?:earlier prs? skipped|skipped (?:earlier )?pr|"
-    r"skip(?:ped)? pr #?\d+|non-mergeable|prior request.changes)\b",
-    re.I,
-)
-_CONFLICT_PROOF = re.compile(
-    r"merge simulation|git merge --no-commit|conflicting files|"
-    r"conflict proof|merge_exit|non-mergeable",
-    re.I,
-)
-_BASELINE_CLAIM = re.compile(
-    r"\b(?:baseline (?:validation|worktree|comparison)|"
-    r"same as master|pre-existing (?:on )?master|"
-    r"failure signatures match)\b",
-    re.I,
-)
-_BASELINE_PATH = re.compile(r"baseline worktree path\s*:\s*(\S+)", re.I)
-_BASELINE_SHA = re.compile(r"baseline (?:target )?sha\s*:\s*([0-9a-f]{7,40})", re.I)
-_BASELINE_DIRTY_BEFORE = re.compile(
-    r"baseline.*dirty before|dirty before.*baseline", re.I
-)
-_BASELINE_DIRTY_AFTER = re.compile(
-    r"baseline.*dirty after|dirty after.*baseline", re.I
-)
-_BASELINE_COMMAND = re.compile(
-    r"baseline.*(?:validation )?command|pytest.*baseline", re.I
-)
-_BASELINE_RESULT = re.compile(
-    r"baseline.*(?:validation )?result|baseline_exit|baseline failures", re.I
-)
-_MASTER_INTEGRATION = re.compile(
-    r"\b(?:merged master into|merge(?:d)? (?:remote[- ]tracking )?branch.*master|"
-    r"master integration|integrated master|rebase.*master)\b",
-    re.I,
-)
-_CLEANUP_CLAIM = re.compile(
-    r"\b(?:worktree(?:s)? (?:were )?cleaned|cleanup (?:result|mutations)|"
-    r"removed (?:session[- ]owned )?worktree|git worktree remove)\b",
-    re.I,
-)
-_WORKTREE_LIST = re.compile(r"git worktree list|worktree list proof", re.I)
-_PROOF_SOURCE = re.compile(
-    r"proof source\s*:\s*(command|mcp metadata|prior blocker|not checked)",
-    re.I,
-)
-_HANDOFF_SECTION = re.compile(r"^##\s*Controller Handoff\s*$", re.I | re.M)
-
-
-def _handoff_fields(report_text: str) -> dict[str, str]:
-    text = report_text or ""
-    match = _HANDOFF_SECTION.search(text)
-    if not match:
-        return {}
-    fields: dict[str, str] = {}
-    for line in text[match.end() :].splitlines():
-        stripped = line.strip().lstrip("-*").strip()
-        if ":" not in stripped:
-            continue
-        key, value = stripped.split(":", 1)
-        fields[key.strip().lower()] = value.strip()
-    return fields
-
-
-def _command_text(entry: Any) -> str:
-    if isinstance(entry, dict):
-        return str(entry.get("command") or entry.get("tool") or "").strip()
-    return str(entry or "").strip()
-
-
-def _action_log_has(action_log: list | None, pattern: re.Pattern[str]) -> bool:
-    for entry in action_log or []:
-        blob = " ".join(
-            filter(
-                None,
-                [
-                    _command_text(entry),
-                    str(entry.get("result") or "") if isinstance(entry, dict) else "",
-                    str(entry.get("reason") or "") if isinstance(entry, dict) else "",
-                ],
-            )
-        )
-        if pattern.search(blob):
-            return True
-    return False
-
-
-def assess_proof_backed_handoff_report(
-    report_text: str,
-    *,
-    action_log: list | None = None,
-    inventory_session: dict | None = None,
-    baseline_session: dict | None = None,
-    skip_session: list[dict] | None = None,
-) -> dict[str, Any]:
-    """Require explicit command/tool evidence for proof-sensitive review claims (#395)."""
-    text = report_text or ""
-    fields = _handoff_fields(text)
-    reasons: list[str] = []
-    inventory = dict(inventory_session or {})
-    baseline = dict(baseline_session or {})
-    skips = list(skip_session or [])
-
-    pagination_field = fields.get("inventory pagination proof", "")
-    if _INVENTORY_COMPLETE_CLAIM.search(text) or _PAGE_SIZE_ONLY.search(text):
-        has_meta = bool(
-            inventory.get("inventory_complete")
-            or inventory.get("pagination_complete")
-            or _PAGINATION_FINALITY.search(pagination_field)
-            or _PAGINATION_FINALITY.search(text)
-            or _action_log_has(action_log, re.compile(r"gitea_list_prs", re.I))
-        )
-        if _PAGE_SIZE_ONLY.search(text) and not has_meta:
-            reasons.append(
-                "inventory completeness claimed from page-size assumption only; "
-                "require has_more=false, is_final_page=true, or inventory_complete=true"
-            )
-        elif _INVENTORY_COMPLETE_CLAIM.search(text) and not has_meta:
-            reasons.append(
-                "inventory complete claim lacks explicit pagination metadata proof"
-            )
-
-    if _SKIP_CLAIM.search(text) or fields.get("earlier prs skipped", "").lower() not in {
-        "",
-        "none",
-        "n/a",
-    }:
-        skip_proof = bool(
-            skips
-            or _CONFLICT_PROOF.search(text)
-            or _action_log_has(
-                action_log, re.compile(r"git merge --no-commit|gitea_get_pr_review_feedback", re.I)
-            )
-        )
-        if not skip_proof:
-            reasons.append(
-                "earlier PR skip claim lacks command/tool conflict or blocker proof"
-            )
-
-    if _BASELINE_CLAIM.search(text) or fields.get("baseline worktree used", "").lower() == "true":
-        baseline_ok = bool(
-            baseline.get("complete")
-            or (
-                _BASELINE_PATH.search(text)
-                and _BASELINE_SHA.search(text)
-                and (_BASELINE_DIRTY_BEFORE.search(text) or baseline.get("clean_before"))
-                and (_BASELINE_COMMAND.search(text) or baseline.get("command"))
-                and (_BASELINE_RESULT.search(text) or baseline.get("result"))
-                and (_BASELINE_DIRTY_AFTER.search(text) or baseline.get("clean_after"))
-            )
-        )
-        if not baseline_ok:
-            reasons.append(
-                "baseline validation claim missing worktree path, target SHA, "
-                "dirty-before/after status, command, or result proof"
-            )
-
-    if _MASTER_INTEGRATION.search(text):
-        if not _action_log_has(
-            action_log,
-            re.compile(r"git merge.*master|git rebase.*master", re.I),
-        ) and not re.search(r"merge_exit\s*=\s*\d+|merge simulation", text, re.I):
-            reasons.append(
-                "master integration claim lacks exact merge/rebase command and result"
-            )
-
-    if _CLEANUP_CLAIM.search(text) or fields.get("cleanup mutations", "").lower() not in {
-        "",
-        "none",
-        "n/a",
-    }:
-        if not (_WORKTREE_LIST.search(text) or _action_log_has(action_log, _WORKTREE_LIST)):
-            reasons.append(
-                "cleanup claim lacks final git worktree list or equivalent proof"
-            )
-
-    if re.search(r"\blive proof\b", text, re.I) and not _PROOF_SOURCE.search(text):
-        if not action_log:
-            reasons.append(
-                "live proof wording requires proof source classification "
-                "(command, MCP metadata, prior blocker, or not checked)"
-            )
-
-    proven = not reasons
-    return {
-        "proven": proven,
-        "block": not proven,
-        "reasons": reasons,
-        "safe_next_action": (
-            "cite explicit command/tool evidence or structured MCP pagination metadata "
-            "for each proof-sensitive claim"
-            if not proven
-            else "proceed"
-        ),
-    }

reviewer_validation_failure_history.py

@@ -1,198 +0,0 @@
-"""Transient validation failure history verifier (#396).
-
-Reviewer sessions may observe validation failures that later pass on rerun.
-Final reports must document every failure observed during the session, not
-only the last passing result.
-"""
-
-from __future__ import annotations
-
-import re
-from typing import Any
-
-_SECTION_RE = re.compile(
-    r"validation failure history",
-    re.IGNORECASE,
-)
-_FAILURE_ENTRY_RE = re.compile(
-    r"(?:failure\s*(?:#|entry)?\s*\d+|validation failure)\s*:",
-    re.IGNORECASE,
-)
-_COMMAND_RE = re.compile(
-    r"(?:command|validation command)\s*:\s*(.+)",
-    re.IGNORECASE,
-)
-_FAILING_TEST_RE = re.compile(
-    r"(?:failing test|failure|error)\s*:\s*(.+)",
-    re.IGNORECASE,
-)
-_CAUSE_RE = re.compile(
-    r"(?:suspected cause|cause)\s*:\s*(.+)",
-    re.IGNORECASE,
-)
-_REPRODUCED_RE = re.compile(
-    r"(?:reproduced|reproduces)\s*:\s*(yes|no|unknown)",
-    re.IGNORECASE,
-)
-_BASELINE_RE = re.compile(
-    r"(?:on baseline master|baseline master|exists on baseline)\s*:\s*(yes|no|unknown|not checked)",
-    re.IGNORECASE,
-)
-_PR_CAUSED_RE = re.compile(
-    r"(?:pr[- ]caused|pr caused)\s*:\s*(yes|no|unknown|not proven)",
-    re.IGNORECASE,
-)
-_TRANSIENT_STATUS_RE = re.compile(
-    r"(?:passed after transient failure investigation|transient failure investigation)",
-    re.IGNORECASE,
-)
-_PLAIN_PASS_RE = re.compile(
-    r"validation\s*:\s*(?:pass|passed|strong|ok|green)\b",
-    re.IGNORECASE,
-)
-_ENV_CLEANUP_RE = re.compile(
-    r"(?:environmental cleanup|state cleaned|what changed between runs)\s*:",
-    re.IGNORECASE,
-)
-_UNKNOWN_CAUSE_RE = re.compile(
-    r"(?:suspected cause|cause)\s*:\s*(?:unknown|unexplained|not determined)",
-    re.IGNORECASE,
-)
-
-
-def _failure_documented_in_text(text: str, failure: dict[str, Any]) -> bool:
-    """Return True when *failure* appears documented in free-form report text."""
-    command = (failure.get("command") or "").strip()
-    failing = (failure.get("failing_test") or failure.get("error") or "").strip()
-    if command and command not in text:
-        return False
-    if failing and failing not in text:
-        return False
-    return bool(command or failing)
-
-
-def _section_has_structured_fields(text: str) -> bool:
-    if not _SECTION_RE.search(text):
-        return False
-    section_start = _SECTION_RE.search(text).start()
-    section = text[section_start:]
-    has_command = bool(_COMMAND_RE.search(section))
-    has_failure = bool(_FAILING_TEST_RE.search(section))
-    return has_command and has_failure
-
-
-def assess_validation_failure_history_report(
-    report_text: str,
-    *,
-    validation_session: dict | None = None,
-) -> dict[str, Any]:
-    """Require final reports to account for transient validation failures (#396)."""
-    text = report_text or ""
-    session = dict(validation_session or {})
-    reasons: list[str] = []
-    violations: list[str] = []
-
-    observed = list(session.get("observed_failures") or [])
-    final_status = (session.get("final_validation_status") or "").strip().lower()
-    cause_unknown = any(
-        (f.get("suspected_cause") or "").strip().lower() in {
-            "unknown", "unexplained", "not determined", ""
-        }
-        and not (f.get("pr_caused") or "").strip().lower() in {"yes", "no"}
-        for f in observed
-    ) or bool(session.get("cause_unknown"))
-
-    if not observed:
-        return {
-            "proven": True,
-            "block": False,
-            "reasons": [],
-            "violations": [],
-            "observed_failure_count": 0,
-            "safe_next_action": "proceed",
-        }
-
-    documented = _section_has_structured_fields(text)
-    if not documented:
-        for failure in observed:
-            if _failure_documented_in_text(text, failure):
-                documented = True
-                break
-
-    if not documented:
-        violations.append(
-            "session observed validation failure(s) but final report omits "
-            "Validation failure history"
-        )
-        reasons.append(
-            "every validation failure observed during the session must appear "
-            "in a Validation failure history section"
-        )
-
-    if documented and not _SECTION_RE.search(text):
-        reasons.append(
-            "failure details must appear under an explicit "
-            "'Validation failure history' heading"
-        )
-
-    for idx, failure in enumerate(observed, start=1):
-        prefix = f"failure #{idx}"
-        if not _failure_documented_in_text(text, failure) and documented:
-            reasons.append(
-                f"{prefix}: command and failing test/error not documented in report"
-            )
-        command = (failure.get("command") or "").strip()
-        failing = (failure.get("failing_test") or failure.get("error") or "").strip()
-        if not command:
-            reasons.append(f"{prefix}: missing command in session failure record")
-        if not failing:
-            reasons.append(
-                f"{prefix}: missing failing test or error in session failure record"
-            )
-
-    plain_pass = bool(_PLAIN_PASS_RE.search(text))
-    transient_wording = bool(_TRANSIENT_STATUS_RE.search(text))
-    final_passed = final_status in {
-        "passed",
-        "pass",
-        "passed_after_transient_failure_investigation",
-    }
-
-    if (final_passed or plain_pass) and observed:
-        if cause_unknown and not transient_wording:
-            violations.append(
-                "unknown transient failure cause cannot be erased as plain 'passed'"
-            )
-            reasons.append(
-                "when cause is unknown, use status "
-                "'passed after transient failure investigation'"
-            )
-        elif not transient_wording and final_status != "passed_after_transient_failure_investigation":
-            if not _ENV_CLEANUP_RE.search(text):
-                reasons.append(
-                    "later passing rerun must document what changed between runs "
-                    "or environmental cleanup performed"
-                )
-
-    if session.get("environmental_contamination") and not _ENV_CLEANUP_RE.search(text):
-        reasons.append(
-            "environmental /tmp state contamination must document cleanup or "
-            "what changed before the passing rerun"
-        )
-
-    proven = not reasons and not violations
-    return {
-        "proven": proven,
-        "block": bool(violations) or not proven,
-        "reasons": reasons,
-        "violations": violations,
-        "observed_failure_count": len(observed),
-        "documented": documented,
-        "safe_next_action": (
-            "add Validation failure history with command, failing test, cause, "
-            "reproduction, baseline comparison, and PR-caused evidence; use "
-            "'passed after transient failure investigation' when appropriate"
-            if not proven
-            else "proceed"
-        ),
-    }

scripts/run-webui

@@ -1,6 +0,0 @@
-#!/usr/bin/env bash
-set -euo pipefail
-script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-repo_root="$(cd "$script_dir/.." && pwd)"
-cd "$repo_root"
-exec python3 -m webui "$@"

skills/llm-project-workflow/schemas/review-merge-final-report.md

@@ -91,23 +91,4 @@ Verifier: `review_proofs.assess_queue_status_report()`.
 
 Narrative final report and controller handoff must agree on eligibility class,
 candidate/reviewed head SHA, mutation state, worktree usage, review decision,
-terminal review mutation, merge result, and linked issue status.
-
-### Proof-backed claims (#395)
-
-Proof-sensitive claims must cite explicit command/tool evidence in the report
-or structured MCP metadata — not narrative alone:
-
-- **Inventory complete:** `has_more=false`, `is_final_page=true`,
-  `inventory_complete=true`, and/or `total_count` from `gitea_list_prs`.
-- **Skipped earlier PRs:** merge-simulation command output, conflict file list,
-  or live `gitea_get_pr_review_feedback` / mergeability fields.
-- **Baseline validation:** baseline worktree path, baseline target SHA,
-  dirty-before/after, exact command, exact result.
-- **Master integration:** exact `git merge` / `git rebase` command and exit status.
-- **Cleanup:** final `git worktree list` (or remove commands) proving session
-  worktrees were removed.
-
-When a claim relies on prior-session blocker state or MCP metadata only, label
-the proof source explicitly (`command`, `MCP metadata`, `prior blocker`,
-`not checked`). Do not use `live proof` without that classification.
+terminal review mutation, merge result, and linked issue status.

skills/llm-project-workflow/workflows/review-merge-pr.md

@@ -538,36 +538,6 @@ Official validation integrity status must be one of:
 
 Do not invent a softer status.
 
-## 21A. Validation failure history rule
-
-Every validation failure observed during the review session must appear in the
-final report, even if a later rerun passes.
-
-Before claiming `Validation: passed`, list every failed validation command from
-the session under `Validation failure history`.
-
-For each failure, report:
-
-* command
-* failing test or error
-* suspected cause
-* whether it reproduced
-* whether it exists on baseline master
-* evidence for whether it is or is not PR-caused
-
-If a later rerun passes, also report:
-
-* what changed between runs
-* whether environmental state was cleaned (for example `/tmp` lock files)
-* why the pass is trustworthy
-
-If the cause is unknown, do not erase the earlier failure with plain
-`Validation: passed`. Use a status such as
-`passed after transient failure investigation`.
-
-`gitea_validate_review_final_report` rejects reports that omit known earlier
-validation failures when `validation_session.observed_failures` is supplied.
-
 ## 22. Baseline validation rule
 
 Do not run tests in the main checkout.
@@ -1126,7 +1096,6 @@ Controller Handoff:
 * Baseline worktree path:
 * Files reviewed:
 * Validation:
-* Validation failure history:
 * Official validation integrity status:
 * Terminal review mutation:
 * Review decision:

skills/llm-project-workflow/workflows/work-issue.md

@@ -277,6 +277,24 @@ Do not select an issue based only on memory from a previous session.
 
 Before claiming or working on an issue, check whether there is already an open PR, branch, or active claim for that issue.
 
+Run `gitea_assess_author_duplicate_work` at these stages and stop when `block` is true:
+
+* `claim` — before `gitea_mark_issue`
+* `lock` — before `gitea_lock_issue`
+* `worktree` / `edit` — before creating a worktree or editing files
+* `commit` — immediately before `git commit`
+* `push` — immediately before `git push`
+* `create_pr` — immediately before `gitea_create_pr` (also enforced server-side)
+
+`gitea_mark_issue`, `gitea_lock_issue`, and `gitea_create_pr` enforce the same gate server-side and fail closed.
+
+If a concurrent open PR appears after work begins:
+
+* before commit or push — stop and preserve local work without pushing
+* after push but before PR creation — produce a reconciliation handoff instead of opening a PR
+
+Final reports must name the duplicate-work outcome (`duplicate PR prevented`, `duplicate branch prevented`, `duplicate commit prevented`, `duplicate push prevented`, `duplicate work not prevented`, or `reconciliation handoff`).
+
 If an open PR already exists for the issue, do not implement duplicate work.
 
 Classify the issue as:

tests/test_author_duplicate_work_gate.py

@@ -0,0 +1,102 @@
+"""Tests for early author duplicate-work gate (#400)."""
+import sys
+import unittest
+from pathlib import Path
+
+sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
+
+from author_duplicate_work_gate import (  # noqa: E402
+    ELIGIBILITY_OPEN_PR_EXISTS,
+    assess_author_duplicate_work,
+    assess_work_issue_duplicate_prevention_report,
+)
+
+
+def _open_pr(number: int = 397, issue: int = 395) -> dict:
+    return {
+        "number": number,
+        "head": {"ref": f"feat/issue-{issue}-example"},
+        "title": f"feat: example (Closes #{issue})",
+        "body": f"Closes #{issue}",
+    }
+
+
+class TestAuthorDuplicateWorkGate(unittest.TestCase):
+    def test_clear_when_no_duplicates(self):
+        result = assess_author_duplicate_work(
+            400,
+            stage="claim",
+            open_prs=[],
+            branch_names=["master", "feat/issue-399-other"],
+        )
+        self.assertTrue(result["allowed"])
+        self.assertFalse(result["block"])
+
+    def test_open_pr_blocks_claim(self):
+        result = assess_author_duplicate_work(
+            395,
+            stage="claim",
+            open_prs=[_open_pr()],
+            branch_names=[],
+        )
+        self.assertFalse(result["allowed"])
+        self.assertEqual(result["eligibility_class"], ELIGIBILITY_OPEN_PR_EXISTS)
+
+    def test_matching_branch_blocks_lock_not_create_pr(self):
+        branches = ["feat/issue-400-early-duplicate-work-gate"]
+        lock = assess_author_duplicate_work(
+            400,
+            stage="lock",
+            open_prs=[],
+            branch_names=branches,
+        )
+        self.assertFalse(lock["allowed"])
+
+        create_pr = assess_author_duplicate_work(
+            400,
+            stage="create_pr",
+            open_prs=[],
+            branch_names=branches,
+            matching_branches=[],
+        )
+        self.assertTrue(create_pr["allowed"])
+
+    def test_open_pr_blocks_create_pr_stage(self):
+        result = assess_author_duplicate_work(
+            395,
+            stage="create_pr",
+            open_prs=[_open_pr()],
+            branch_names=["feat/issue-395-proof-backed-review-handoff"],
+        )
+        self.assertFalse(result["allowed"])
+        self.assertEqual(result["outcome"], "duplicate_pr_prevented")
+
+    def test_push_stage_blocks_on_concurrent_pr(self):
+        result = assess_author_duplicate_work(
+            395,
+            stage="push",
+            open_prs=[_open_pr()],
+            branch_names=[],
+        )
+        self.assertFalse(result["allowed"])
+        self.assertEqual(result["outcome"], "duplicate_push_prevented")
+
+    def test_duplicate_prevention_report_requires_outcome(self):
+        bad = assess_work_issue_duplicate_prevention_report(
+            "Duplicate work detected for issue #395."
+        )
+        self.assertFalse(bad["proven"])
+
+        good = assess_work_issue_duplicate_prevention_report(
+            "Duplicate PR prevented; reconciliation handoff produced."
+        )
+        self.assertTrue(good["proven"])
+
+    def test_exported_from_review_proofs(self):
+        from review_proofs import assess_work_issue_duplicate_prevention_report as exported
+
+        self.assertTrue(callable(exported))
+
+
+if __name__ == "__main__":
+    unittest.main()

tests/test_create_issue_workspace_guard.py

@@ -1,145 +0,0 @@
-import os
-import sys
-import unittest
-from pathlib import Path
-from unittest.mock import patch, MagicMock
-
-# Ensure we import from the repo root
-sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
-
-import gitea_mcp_server as srv
-
-FAKE_AUTH = {"Authorization": "token test-token"}
-# Stable control checkout (parent of branches/), not the MCP server worktree root.
-CONTROL_CHECKOUT_ROOT = str(Path(__file__).resolve().parents[3])
-PROJECT_ROOT = srv.PROJECT_ROOT
-
-
-class TestCreateIssueWorkspaceGuard(unittest.TestCase):
-
-    def setUp(self):
-        # Reset preflight flags
-        srv._preflight_whoami_called = True
-        srv._preflight_capability_called = True
-        srv._preflight_resolved_role = "author"
-        srv._preflight_whoami_violation = False
-        srv._preflight_capability_violation = False
-        
-        # Disable early return in verify_preflight_purity for testing
-        self._orig_in_test = srv._preflight_in_test_mode
-        srv._preflight_in_test_mode = lambda: False
-
-    def tearDown(self):
-        srv._preflight_in_test_mode = self._orig_in_test
-
-    @patch("gitea_mcp_server._auth", return_value=FAKE_AUTH)
-    @patch("gitea_mcp_server._profile_permission_block", return_value=None)
-    @patch("gitea_mcp_server._namespace_mutation_block", return_value=None)
-    @patch("gitea_mcp_server.role_session_router.check_author_mutation_after_reviewer_stop", return_value=(True, []))
-    @patch("gitea_mcp_server.api_request")
-    @patch("gitea_mcp_server.api_get_all", return_value=[])
-    @patch("gitea_mcp_server.issue_lock_worktree.read_worktree_git_state", return_value={"current_branch": "feat/issue-1"})
-    def test_create_issue_stable_checkout_rejected(self, _git, _get_all, mock_api, _role, _ns, _prof, _auth):
-        # Without worktree_path/env hints, workspace resolves to PROJECT_ROOT. When that
-        # path is the stable control checkout (not under branches/), mutation must fail.
-        with patch.object(srv, "PROJECT_ROOT", CONTROL_CHECKOUT_ROOT):
-            with self.assertRaises(RuntimeError) as ctx:
-                srv.gitea_create_issue(title="Test issue", body="body text")
-        self.assertIn("stable control checkout", str(ctx.exception))
-
-    @patch("gitea_mcp_server._auth", return_value=FAKE_AUTH)
-    @patch("gitea_mcp_server._profile_permission_block", return_value=None)
-    @patch("gitea_mcp_server._namespace_mutation_block", return_value=None)
-    @patch("gitea_mcp_server.role_session_router.check_author_mutation_after_reviewer_stop", return_value=(True, []))
-    @patch("gitea_mcp_server.api_request")
-    @patch("gitea_mcp_server.api_get_all", return_value=[])
-    @patch("gitea_mcp_server.issue_lock_worktree.read_worktree_git_state", return_value={"current_branch": "feat/issue-1"})
-    @patch("os.path.exists", return_value=True)
-    @patch("os.path.isdir", return_value=True)
-    @patch("subprocess.run")
-    def test_create_issue_valid_worktree_succeeds(self, mock_run, mock_isdir, mock_exists, _git, _get_all, mock_api, _role, _ns, _prof, _auth):
-        # Mock subprocess.run for git --git-common-dir to return PROJECT_ROOT/.git
-        mock_res = MagicMock()
-        mock_res.stdout = f"{CONTROL_CHECKOUT_ROOT}/.git\n"
-        mock_run.return_value = mock_res
-
-        mock_api.return_value = {"number": 42, "html_url": "https://gitea.example.com/issues/42"}
-
-        # Provide a valid branches path under the control checkout root
-        valid_path = os.path.join(CONTROL_CHECKOUT_ROOT, "branches", "feat-issue-1")
-        
-        with patch.object(srv, "PROJECT_ROOT", CONTROL_CHECKOUT_ROOT):
-            with patch("gitea_mcp_server._get_workspace_porcelain", return_value=""):
-                res = srv.gitea_create_issue(
-                    title="Test issue", body="body", worktree_path=valid_path
-                )
-            
-        self.assertEqual(res["number"], 42)
-        mock_api.assert_called_once()
-
-    @patch("gitea_mcp_server._auth", return_value=FAKE_AUTH)
-    @patch("gitea_mcp_server._profile_permission_block", return_value=None)
-    @patch("gitea_mcp_server._namespace_mutation_block", return_value=None)
-    @patch("gitea_mcp_server.role_session_router.check_author_mutation_after_reviewer_stop", return_value=(True, []))
-    @patch("gitea_mcp_server.api_request")
-    @patch("gitea_mcp_server.api_get_all", return_value=[])
-    @patch("gitea_mcp_server.issue_lock_worktree.read_worktree_git_state", return_value={"current_branch": "feat/issue-1"})
-    def test_create_issue_missing_worktree_fails_closed(self, _git, _get_all, mock_api, _role, _ns, _prof, _auth):
-        # Path under branches/ but doesn't exist
-        missing_path = os.path.join(
-            CONTROL_CHECKOUT_ROOT, "branches", "nonexistent-worktree-path-999"
-        )
-        
-        with patch.object(srv, "PROJECT_ROOT", CONTROL_CHECKOUT_ROOT):
-            with self.assertRaises(RuntimeError) as ctx:
-                srv.gitea_create_issue(
-                    title="Test issue", body="body", worktree_path=missing_path
-                )
-        self.assertIn("does not exist (fail closed)", str(ctx.exception))
-
-    @patch("gitea_mcp_server._auth", return_value=FAKE_AUTH)
-    @patch("gitea_mcp_server._profile_permission_block", return_value=None)
-    @patch("gitea_mcp_server._namespace_mutation_block", return_value=None)
-    @patch("gitea_mcp_server.role_session_router.check_author_mutation_after_reviewer_stop", return_value=(True, []))
-    @patch("gitea_mcp_server.api_request")
-    @patch("gitea_mcp_server.api_get_all", return_value=[])
-    @patch("gitea_mcp_server.issue_lock_worktree.read_worktree_git_state", return_value={"current_branch": "feat/issue-1"})
-    @patch("os.path.exists", return_value=True)
-    @patch("os.path.isdir", return_value=True)
-    @patch("subprocess.run")
-    def test_create_issue_wrong_repo_fails_closed(self, mock_run, mock_isdir, mock_exists, _git, _get_all, mock_api, _role, _ns, _prof, _auth):
-        # Mock subprocess.run for git --git-common-dir to return a different path
-        mock_res = MagicMock()
-        mock_res.stdout = "/Users/jasonwalker/Development/some-other-repo/.git\n"
-        mock_run.return_value = mock_res
-
-        wrong_repo_path = os.path.join(CONTROL_CHECKOUT_ROOT, "branches", "feat-issue-1")
-
-        with patch.object(srv, "PROJECT_ROOT", CONTROL_CHECKOUT_ROOT):
-            with self.assertRaises(RuntimeError) as ctx:
-                srv.gitea_create_issue(
-                    title="Test issue", body="body", worktree_path=wrong_repo_path
-                )
-        self.assertIn("does not belong to the target repository", str(ctx.exception))
-
-    @patch("gitea_mcp_server._auth", return_value=FAKE_AUTH)
-    @patch("gitea_mcp_server._profile_permission_block", return_value=None)
-    @patch("gitea_mcp_server._namespace_mutation_block", return_value=None)
-    def test_create_issue_fails_without_whoami_preflight(self, _ns, _prof, _auth):
-        srv._preflight_whoami_called = False
-        with self.assertRaises(RuntimeError) as ctx:
-            srv.gitea_create_issue(title="Test issue", body="body")
-        self.assertIn("Identity (gitea_whoami) has not been verified", str(ctx.exception))
-
-    @patch("gitea_mcp_server._auth", return_value=FAKE_AUTH)
-    @patch("gitea_mcp_server._profile_permission_block", return_value=None)
-    @patch("gitea_mcp_server._namespace_mutation_block", return_value=None)
-    def test_create_issue_fails_without_capability_preflight(self, _ns, _prof, _auth):
-        srv._preflight_capability_called = False
-        with self.assertRaises(RuntimeError) as ctx:
-            srv.gitea_create_issue(title="Test issue", body="body")
-        self.assertIn("Task capability (gitea_resolve_task_capability) has not been resolved", str(ctx.exception))
-
-
-if __name__ == "__main__":
-    unittest.main()

tests/test_delete_branch_capability.py

@@ -1,217 +0,0 @@
-"""Tests for gitea_delete_branch capability gate (Issue #408).
-
-``gitea_delete_branch`` requires the exact ``gitea.branch.delete`` operation:
-without it the delete fails closed (no preflight, no auth lookup, no API call,
-structured permission report). With it, deletion proceeds through existing
-preflight and audit unchanged.
-"""
-import json
-import os
-import sys
-import tempfile
-import unittest
-from unittest.mock import patch
-
-sys.path.insert(0, str(__import__("pathlib").Path(__file__).resolve().parent.parent))
-
-import mcp_server
-from mcp_server import gitea_delete_branch
-
-FAKE_AUTH = "token fake"
-
-AUTHOR_NO_DELETE = {
-    "profile_name": "prgs-author",
-    "allowed_operations": [
-        "gitea.read", "gitea.pr.create", "gitea.pr.comment",
-        "gitea.branch.push", "gitea.issue.comment",
-    ],
-    "forbidden_operations": ["gitea.pr.approve", "gitea.pr.merge"],
-    "audit_label": "prgs-author",
-}
-
-AUTHOR_WITH_DELETE = {
-    "profile_name": "prgs-author-deleter",
-    "allowed_operations": AUTHOR_NO_DELETE["allowed_operations"] + [
-        "gitea.branch.delete",
-    ],
-    "forbidden_operations": ["gitea.pr.approve", "gitea.pr.merge"],
-    "audit_label": "prgs-author-deleter",
-}
-
-CONFIG = {
-    "version": 2,
-    "contexts": {
-        "ctx": {
-            "enabled": True,
-            "gitea": {"enabled": True, "base_url": "https://gitea.example.com"},
-        }
-    },
-    "profiles": {
-        "author-no-delete": {
-            "enabled": True,
-            "context": "ctx",
-            "role": "author",
-            "username": "author-user",
-            "auth": {"type": "env", "name": "GITEA_TOKEN_AUTHOR"},
-            "allowed_operations": AUTHOR_NO_DELETE["allowed_operations"],
-            "forbidden_operations": [],
-            "execution_profile": "author-no-delete",
-        },
-        "author-with-delete": {
-            "enabled": True,
-            "context": "ctx",
-            "role": "author",
-            "username": "deleter-user",
-            "auth": {"type": "env", "name": "GITEA_TOKEN_AUTHOR"},
-            "allowed_operations": AUTHOR_WITH_DELETE["allowed_operations"],
-            "forbidden_operations": [],
-            "execution_profile": "author-with-delete",
-        },
-        "reviewer-profile": {
-            "enabled": True,
-            "context": "ctx",
-            "role": "reviewer",
-            "username": "reviewer-user",
-            "auth": {"type": "env", "name": "GITEA_TOKEN_REVIEWER"},
-            "allowed_operations": [
-                "gitea.read", "gitea.pr.review", "gitea.pr.merge",
-            ],
-            "forbidden_operations": [
-                "gitea.branch.delete", "gitea.branch.push", "gitea.pr.create",
-            ],
-            "execution_profile": "reviewer-profile",
-        },
-    },
-    "rules": {"allow_runtime_switching": False},
-}
-
-
-class TestDeleteBranchToolGate(unittest.TestCase):
-
-    def setUp(self):
-        self._preflight_snapshot = (
-            mcp_server._preflight_whoami_called,
-            mcp_server._preflight_capability_called,
-        )
-        mcp_server._preflight_whoami_called = False
-        mcp_server._preflight_capability_called = False
-        self._remotes = patch.dict(mcp_server.REMOTES, {
-            "prgs": {"host": "gitea.example.com", "org": "Example-Org",
-                     "repo": "Example-Repo"},
-        })
-        self._remotes.start()
-        mcp_server._IDENTITY_CACHE.clear()
-        patch("gitea_config.load_config", return_value={}).start()
-        patch(
-            "gitea_config.is_runtime_switching_enabled", return_value=False
-        ).start()
-        patch("gitea_audit.audit_enabled", return_value=False).start()
-        self.mock_api = patch("mcp_server.api_request").start()
-        self.mock_auth = patch(
-            "mcp_server.get_auth_header", return_value=FAKE_AUTH
-        ).start()
-
-    def tearDown(self):
-        patch.stopall()
-        mcp_server._IDENTITY_CACHE.clear()
-        mcp_server._preflight_whoami_called, mcp_server._preflight_capability_called = (
-            self._preflight_snapshot
-        )
-
-    def _set_profile(self, profile):
-        patch("mcp_server.get_profile", return_value=profile).start()
-
-    def test_blocked_without_delete_capability(self):
-        self._set_profile(AUTHOR_NO_DELETE)
-        res = gitea_delete_branch(branch="feat/branch", remote="prgs")
-        self.assertFalse(res["success"])
-        self.assertFalse(res["performed"])
-        self.assertEqual(res["required_permission"], "gitea.branch.delete")
-        self.assertTrue(res["reasons"])
-        self.assertEqual(
-            res["permission_report"]["missing_permission"],
-            "gitea.branch.delete",
-        )
-        self.mock_api.assert_not_called()
-        self.mock_auth.assert_not_called()
-
-    def test_allowed_delete_proceeds(self):
-        self._set_profile(AUTHOR_WITH_DELETE)
-        mcp_server.record_preflight_check("whoami")
-        mcp_server.record_preflight_check("capability", resolved_role="author")
-        res = gitea_delete_branch(branch="feat/branch", remote="prgs")
-        self.assertTrue(res["success"])
-        self.assertIn("deleted", res["message"])
-        delete_calls = [
-            c for c in self.mock_api.call_args_list if c.args[0] == "DELETE"
-        ]
-        self.assertTrue(delete_calls)
-
-    def test_allowed_delete_audited_with_capability_proof(self):
-        self._set_profile(AUTHOR_WITH_DELETE)
-        patch("gitea_audit.audit_enabled", return_value=True).start()
-        mock_write = patch("gitea_audit.write_event").start()
-        mcp_server.record_preflight_check("whoami")
-        mcp_server.record_preflight_check("capability", resolved_role="author")
-        self.mock_api.return_value = {}
-        gitea_delete_branch(branch="feat/branch", remote="prgs")
-        mock_write.assert_called()
-        event = mock_write.call_args[0][0]
-        self.assertEqual(event["action"], "delete_branch")
-        self.assertEqual(
-            event["request_metadata"]["required_permission"],
-            "gitea.branch.delete",
-        )
-
-
-class TestDeleteBranchResolverParity(unittest.TestCase):
-    def setUp(self):
-        self._remotes = patch.dict(mcp_server.REMOTES, {
-            "prgs": {"host": "gitea.example.com", "org": "Example-Org",
-                     "repo": "Example-Repo"},
-        })
-        self._remotes.start()
-        mcp_server._IDENTITY_CACHE.clear()
-        self._dir = tempfile.TemporaryDirectory()
-        self.config_path = os.path.join(self._dir.name, "profiles.json")
-        with open(self.config_path, "w", encoding="utf-8") as fh:
-            fh.write(json.dumps(CONFIG))
-        patch(
-            "gitea_config.is_runtime_switching_enabled", return_value=False
-        ).start()
-        patch("gitea_audit.audit_enabled", return_value=False).start()
-        self.mock_api = patch("mcp_server.api_request").start()
-        patch("mcp_server.get_auth_header", return_value=FAKE_AUTH).start()
-
-    def tearDown(self):
-        patch.stopall()
-        mcp_server._IDENTITY_CACHE.clear()
-        self._dir.cleanup()
-
-    def _env(self, profile: str) -> dict:
-        return {
-            "GITEA_MCP_CONFIG": self.config_path,
-            "GITEA_MCP_PROFILE": profile,
-            "GITEA_TOKEN_AUTHOR": "author-pass",
-            "GITEA_TOKEN_REVIEWER": "reviewer-pass",
-        }
-
-    def test_reviewer_resolver_denial_blocks_raw_tool(self):
-        with patch.dict(os.environ, self._env("reviewer-profile"), clear=True):
-            resolve = mcp_server.gitea_resolve_task_capability(
-                task="delete_branch", remote="prgs")
-            self.assertFalse(resolve["allowed_in_current_session"])
-            res = gitea_delete_branch(branch="feat/branch", remote="prgs")
-        self.assertFalse(res["success"])
-        self.assertEqual(
-            res["permission_report"]["missing_permission"],
-            resolve["required_operation_permission"],
-        )
-        delete_calls = [
-            c for c in self.mock_api.call_args_list if c.args[0] == "DELETE"
-        ]
-        self.assertFalse(delete_calls)
-
-
-if __name__ == "__main__":
-    unittest.main()

tests/test_llm_workflow_split.py

@@ -95,6 +95,12 @@ def test_create_issue_workflow_contract():
     assert "## 9. Duplicate search before mutation" in text
 
 
+def test_author_duplicate_work_gate_exported():
+    from review_proofs import assess_work_issue_duplicate_prevention_report
+
+    assert callable(assess_work_issue_duplicate_prevention_report)
+
+
 def test_work_issue_workflow_contract():
     text = (SKILL_DIR / "workflows" / "work-issue.md").read_text(encoding="utf-8")
     assert "canonical: true" in text
@@ -207,12 +213,6 @@ def test_validation_integrity_verifier_exported():
     assert callable(assess_validation_integrity_report)
 
 
-def test_validation_failure_history_verifier_exported():
-    from review_proofs import assess_validation_failure_history_report
-
-    assert callable(assess_validation_failure_history_report)
-
-
 def test_prior_blocker_skip_verifier_exported():
     from review_proofs import assess_prior_blocker_skip_proof
 
@@ -255,12 +255,6 @@ def test_inventory_worktree_verifier_exported():
     assert callable(assess_inventory_worktree_report)
 
 
-def test_proof_backed_handoff_verifier_exported():
-    from review_proofs import assess_proof_backed_handoff_report
-
-    assert callable(assess_proof_backed_handoff_report)
-
-
 def test_infra_stop_handoff_verifier_exported():
     from review_proofs import assess_infra_stop_handoff_report
 

tests/test_mcp_server.py

@@ -1005,19 +1005,9 @@ class TestReviewPR(unittest.TestCase):
 # ---------------------------------------------------------------------------
 class TestDeleteBranch(unittest.TestCase):
 
-    DELETE_PROFILE = {
-        "profile_name": "test-deleter",
-        "allowed_operations": ["gitea.read", "gitea.branch.delete"],
-        "forbidden_operations": [],
-        "audit_label": "test-deleter",
-    }
-
-    @patch("mcp_server.get_profile", return_value=DELETE_PROFILE)
     @patch("mcp_server.api_request")
     @patch("mcp_server.get_auth_header", return_value=FAKE_AUTH)
-    def test_delete_branch(self, _auth, mock_api, _profile):
-        mcp_server.record_preflight_check("whoami")
-        mcp_server.record_preflight_check("capability", resolved_role="author")
+    def test_delete_branch(self, _auth, mock_api):
         mock_api.return_value = {}
         result = gitea_delete_branch(branch="feat/branch")
         self.assertTrue(result["success"])

tests/test_reviewer_proof_backed_handoff.py

@@ -1,117 +0,0 @@
-"""Tests for proof-backed reviewer handoff verifier (#395)."""
-import sys
-import unittest
-from pathlib import Path
-
-sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
-
-from reviewer_proof_backed_handoff import (  # noqa: E402
-    assess_proof_backed_handoff_report,
-)
-
-
-def _good_report() -> str:
-    return "\n".join([
-        "Inventory pagination proof: is_final_page: true, has_more: false, total_count: 11",
-        "Earlier PRs skipped: #372 non-mergeable — merge simulation conflicts in review_proofs.py",
-        "Baseline worktree path: branches/baseline-master-pr383",
-        "Baseline target SHA: 4243b60ca32d79f1ee5e6b0f10d7570e9dea2937",
-        "Baseline dirty before validation: false",
-        "Baseline validation command: venv/bin/python -m pytest tests/ -q",
-        "Baseline validation result: 1 failed (test_clean_reviewer_report_passes)",
-        "Baseline dirty after validation: false",
-        "Cleanup mutations: git worktree list showed session worktrees removed",
-        "## Controller Handoff",
-        "- Inventory pagination proof: inventory_complete: true, total_count: 11",
-        "- Earlier PRs skipped: #372 conflict proof via merge simulation",
-        "- Baseline worktree used: true",
-        "- Baseline worktree path: branches/baseline-master-pr383",
-        "- Cleanup mutations: git worktree remove branches/review-pr383",
-    ])
-
-
-class TestProofBackedHandoff(unittest.TestCase):
-    def test_fully_proof_backed_report_passes(self):
-        result = assess_proof_backed_handoff_report(
-            _good_report(),
-            action_log=[{"command": "gitea_list_prs", "result": "inventory_complete=true"}],
-            baseline_session={
-                "complete": True,
-                "clean_before": True,
-                "clean_after": True,
-                "command": "pytest",
-                "result": "passed",
-            },
-        )
-        self.assertTrue(result["proven"], result["reasons"])
-
-    def test_inventory_page_size_assumption_blocks(self):
-        report = (
-            "Inventory is complete because 13 results are less than page size 50."
-        )
-        result = assess_proof_backed_handoff_report(report)
-        self.assertFalse(result["proven"])
-        self.assertTrue(any("page-size" in r.lower() for r in result["reasons"]))
-
-    def test_skip_without_conflict_proof_blocks(self):
-        report = "\n".join([
-            "Earlier PRs skipped: #372, #374",
-            "## Controller Handoff",
-            "- Earlier PRs skipped: #372, #374",
-        ])
-        result = assess_proof_backed_handoff_report(report)
-        self.assertFalse(result["proven"])
-        self.assertTrue(any("skip" in r.lower() for r in result["reasons"]))
-
-    def test_baseline_without_command_blocks(self):
-        report = "Baseline validation passed; same as master failures."
-        result = assess_proof_backed_handoff_report(report)
-        self.assertFalse(result["proven"])
-        self.assertTrue(any("baseline" in r.lower() for r in result["reasons"]))
-
-    def test_cleanup_without_worktree_list_blocks(self):
-        report = "Worktrees were cleaned after merge."
-        result = assess_proof_backed_handoff_report(report)
-        self.assertFalse(result["proven"])
-        self.assertTrue(any("cleanup" in r.lower() for r in result["reasons"]))
-
-    def test_cleanup_with_worktree_list_passes(self):
-        report = "Cleanup: git worktree list confirmed removal."
-        result = assess_proof_backed_handoff_report(
-            report,
-            action_log=[{"command": "git worktree list"}],
-        )
-        self.assertTrue(result["proven"], result["reasons"])
-
-    def test_master_integration_requires_command(self):
-        report = "Merged master into the review worktree before validation."
-        result = assess_proof_backed_handoff_report(report)
-        self.assertFalse(result["proven"])
-        self.assertTrue(any("master integration" in r.lower() for r in result["reasons"]))
-
-    def test_master_integration_with_action_log_passes(self):
-        report = "Merged master into review worktree; merge_exit=0"
-        result = assess_proof_backed_handoff_report(
-            report,
-            action_log=[{"command": "git merge --no-commit prgs/master"}],
-        )
-        self.assertTrue(result["proven"], result["reasons"])
-
-    def test_live_proof_requires_source_classification(self):
-        report = "Live proof shows inventory complete."
-        result = assess_proof_backed_handoff_report(report)
-        self.assertFalse(result["proven"])
-        self.assertTrue(any("proof source" in r.lower() for r in result["reasons"]))
-
-
-class TestExport(unittest.TestCase):
-    def test_review_proofs_reexport(self):
-        from review_proofs import assess_proof_backed_handoff_report as exported
-
-        self.assertTrue(callable(exported))
-        result = exported(_good_report(), inventory_session={"inventory_complete": True})
-        self.assertTrue(result["proven"], result["reasons"])
-
-
-if __name__ == "__main__":
-    unittest.main()

tests/test_reviewer_validation_failure_history.py

@@ -1,147 +0,0 @@
-"""Tests for transient validation failure history verifier (#396)."""
-import sys
-import unittest
-from pathlib import Path
-
-sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
-
-from final_report_validator import assess_final_report_validator  # noqa: E402
-from reviewer_validation_failure_history import (  # noqa: E402
-    assess_validation_failure_history_report,
-)
-
-
-def _full_history_report() -> str:
-    return "\n".join([
-        "Validation failure history",
-        "Failure #1:",
-        "Command: venv/bin/python -m pytest tests/test_worktrees.py -q",
-        "Failing test: tests/test_worktrees.py::TestWorktreeStart::test_rejects_untraceable_branches",
-        "Suspected cause: stale /tmp/gitea_issue_lock.json from prior session",
-        "Reproduced: no",
-        "On baseline master: no",
-        "PR-caused: no",
-        "What changed between runs: removed /tmp/gitea_issue_lock.json",
-        "Environmental cleanup: lock file removed before rerun",
-        "Validation: passed after transient failure investigation",
-        "Final validation command: venv/bin/python -m pytest tests/ -q",
-        "Final result: 1497 passed, 6 skipped",
-    ])
-
-
-class TestValidationFailureHistory(unittest.TestCase):
-    def test_no_failures_observed_passes(self):
-        result = assess_validation_failure_history_report(
-            "Validation: passed",
-            validation_session={"observed_failures": []},
-        )
-        self.assertTrue(result["proven"])
-
-    def test_omitted_failure_blocks(self):
-        result = assess_validation_failure_history_report(
-            "Validation: passed\n1497 passed, 6 skipped",
-            validation_session={
-                "observed_failures": [{
-                    "command": "pytest tests/test_worktrees.py -q",
-                    "failing_test": (
-                        "tests/test_worktrees.py::TestWorktreeStart::"
-                        "test_rejects_untraceable_branches"
-                    ),
-                }],
-                "final_validation_status": "passed",
-            },
-        )
-        self.assertFalse(result["proven"])
-        self.assertTrue(result["block"])
-
-    def test_full_history_with_transient_investigation_passes(self):
-        result = assess_validation_failure_history_report(
-            _full_history_report(),
-            validation_session={
-                "observed_failures": [{
-                    "command": (
-                        "venv/bin/python -m pytest tests/test_worktrees.py -q"
-                    ),
-                    "failing_test": (
-                        "tests/test_worktrees.py::TestWorktreeStart::"
-                        "test_rejects_untraceable_branches"
-                    ),
-                    "suspected_cause": "stale /tmp/gitea_issue_lock.json",
-                    "reproduced": "no",
-                    "on_baseline_master": "no",
-                    "pr_caused": "no",
-                }],
-                "final_validation_status": "passed_after_transient_failure_investigation",
-                "environmental_contamination": True,
-            },
-        )
-        self.assertTrue(result["proven"], result["reasons"])
-
-    def test_baseline_equivalent_failure_documented(self):
-        report = "\n".join([
-            "Validation failure history",
-            "Command: pytest tests/test_example.py -q",
-            "Failing test: tests/test_example.py::test_flaky",
-            "Suspected cause: pre-existing master failure",
-            "On baseline master: yes",
-            "PR-caused: no",
-            "What changed between runs: none; failure matches baseline",
-            "Validation: passed after transient failure investigation",
-        ])
-        result = assess_validation_failure_history_report(
-            report,
-            validation_session={
-                "observed_failures": [{
-                    "command": "pytest tests/test_example.py -q",
-                    "failing_test": "tests/test_example.py::test_flaky",
-                    "on_baseline_master": "yes",
-                    "pr_caused": "no",
-                }],
-                "final_validation_status": "passed_after_transient_failure_investigation",
-            },
-        )
-        self.assertTrue(result["proven"], result["reasons"])
-
-    def test_unknown_cause_plain_pass_blocks(self):
-        result = assess_validation_failure_history_report(
-            "Validation: passed",
-            validation_session={
-                "observed_failures": [{
-                    "command": "pytest tests/ -q",
-                    "failing_test": "tests/test_foo.py::test_bar",
-                    "suspected_cause": "unknown",
-                }],
-                "final_validation_status": "passed",
-                "cause_unknown": True,
-            },
-        )
-        self.assertFalse(result["proven"])
-        self.assertTrue(any("transient" in r.lower() for r in result["reasons"]))
-
-    def test_final_report_validator_rejects_omitted_failure(self):
-        result = assess_final_report_validator(
-            "Validation: passed",
-            "review_pr",
-            validation_session={
-                "observed_failures": [{
-                    "command": "pytest tests/ -q",
-                    "failing_test": "tests/test_foo.py::test_bar",
-                }],
-            },
-        )
-        self.assertTrue(result["blocked"] or result["downgraded"])
-        self.assertTrue(
-            any(
-                f.get("rule_id") == "reviewer.validation_failure_history"
-                for f in result.get("findings") or []
-            )
-        )
-
-    def test_exported_from_review_proofs(self):
-        from review_proofs import assess_validation_failure_history_report as exported
-
-        self.assertTrue(callable(exported))
-
-
-if __name__ == "__main__":
-    unittest.main()

tests/test_webui_project_registry.py

@@ -1,111 +0,0 @@
-"""Tests for web UI project registry (#427)."""
-import json
-import sys
-import tempfile
-import unittest
-from pathlib import Path
-
-sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
-
-from starlette.testclient import TestClient
-
-from webui.app import create_app
-from webui.project_registry import (
-    default_registry_path,
-    load_registry,
-    project_to_dict,
-)
-
-
-class TestProjectRegistryLoader(unittest.TestCase):
-    def test_default_registry_loads_gitea_tools(self):
-        registry = load_registry()
-        self.assertEqual(registry.version, 1)
-        self.assertEqual(len(registry.projects), 1)
-        project = registry.projects[0]
-        self.assertEqual(project.id, "gitea-tools")
-        self.assertEqual(project.repo_name, "Gitea-Tools")
-        self.assertEqual(project.gitea_owner, "Scaled-Tech-Consulting")
-        self.assertEqual(project.remote_host, "https://gitea.prgs.cc")
-        self.assertEqual(project.profiles["author"], "prgs-author")
-        self.assertEqual(project.profiles["reviewer"], "prgs-reviewer")
-        self.assertEqual(project.profiles["reconciler"], "prgs-reconciler")
-        self.assertIn("skill", project.workflow_paths)
-        self.assertGreaterEqual(len(project.onboarding_checklist), 4)
-
-    def test_registry_rejects_credential_keys(self):
-        payload = {
-            "version": 1,
-            "projects": [
-                {
-                    "id": "bad",
-                    "repo_name": "Bad",
-                    "gitea_owner": "Org",
-                    "remote_host": "https://gitea.example.invalid",
-                    "default_branch": "main",
-                    "local_checkout_path": ".",
-                    "profiles": {
-                        "author": "a",
-                        "reviewer": "r",
-                        "reconciler": "c",
-                    },
-                    "workflow_paths": {"skill": "skills/x.md"},
-                    "api_token": "secret",
-                }
-            ],
-        }
-        with tempfile.NamedTemporaryFile("w", suffix=".json", delete=False) as handle:
-            json.dump(payload, handle)
-            path = Path(handle.name)
-        try:
-            with self.assertRaises(ValueError):
-                load_registry(path)
-        finally:
-            path.unlink(missing_ok=True)
-
-    def test_default_registry_path_points_at_packaged_data(self):
-        path = default_registry_path()
-        self.assertTrue(path.name == "projects.registry.json")
-        self.assertTrue(path.parent.name == "data")
-
-
-class TestProjectRegistryRoutes(unittest.TestCase):
-    def setUp(self):
-        self.client = TestClient(create_app())
-
-    def test_projects_page_lists_gitea_tools(self):
-        response = self.client.get("/projects")
-        self.assertEqual(response.status_code, 200)
-        self.assertIn("Gitea-Tools", response.text)
-        self.assertIn("Scaled-Tech-Consulting", response.text)
-        self.assertIn("prgs-author", response.text)
-        self.assertNotIn("child issue", response.text.lower())
-
-    def test_project_detail_renders_checklist(self):
-        response = self.client.get("/projects/gitea-tools")
-        self.assertEqual(response.status_code, 200)
-        self.assertIn("Onboarding checklist", response.text)
-        self.assertIn("Configure execution profiles", response.text)
-        self.assertIn("branches/", response.text)
-
-    def test_project_detail_404(self):
-        response = self.client.get("/projects/unknown-repo")
-        self.assertEqual(response.status_code, 404)
-
-    def test_api_projects_json(self):
-        response = self.client.get("/api/projects")
-        self.assertEqual(response.status_code, 200)
-        data = response.json()
-        self.assertEqual(data["version"], 1)
-        self.assertEqual(len(data["projects"]), 1)
-        self.assertEqual(data["projects"][0]["id"], "gitea-tools")
-        self.assertIn("onboarding_checklist", data["projects"][0])
-
-    def test_project_to_dict_is_json_safe(self):
-        registry = load_registry()
-        encoded = json.dumps(project_to_dict(registry.projects[0]))
-        self.assertIn("gitea-tools", encoded)
-
-
-if __name__ == "__main__":
-    unittest.main()

tests/test_webui_prompt_library.py

@@ -1,90 +0,0 @@
-"""Tests for web UI prompt library (#428)."""
-import json
-import sys
-import unittest
-from pathlib import Path
-
-sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
-
-from starlette.testclient import TestClient
-
-from webui.app import create_app
-from webui.prompt_library import find_prompt, library_to_dict, load_prompt_library, prompt_to_dict
-
-REQUIRED_PROMPT_SLUGS = frozenset({
-    "review-pr",
-    "work-issue",
-    "create-issue",
-    "comment-issue",
-    "cleanup",
-    "audit",
-    "onboarding",
-})
-
-
-class TestPromptLibraryLoader(unittest.TestCase):
-    def test_library_loads_required_prompts(self):
-        entries = load_prompt_library()
-        slugs = {entry.slug for entry in entries}
-        self.assertEqual(slugs, REQUIRED_PROMPT_SLUGS)
-
-    def test_workflow_hashes_present(self):
-        review = find_prompt("review-pr")
-        self.assertIsNotNone(review)
-        assert review is not None
-        self.assertTrue(review.workflow_hash)
-        self.assertEqual(len(review.workflow_hash), 64)
-
-    def test_prompt_text_is_short(self):
-        for entry in load_prompt_library():
-            self.assertLess(len(entry.prompt_text), 400)
-            self.assertNotIn("Do not improvise around the gates", entry.prompt_text)
-
-
-class TestPromptLibraryRoutes(unittest.TestCase):
-    def setUp(self):
-        self.client = TestClient(create_app())
-
-    def test_prompts_page_lists_all_entries(self):
-        response = self.client.get("/prompts")
-        self.assertEqual(response.status_code, 200)
-        for label in (
-            "Review PR",
-            "Work issue",
-            "Create issue",
-            "Comment on issue",
-            "Post-merge cleanup",
-            "Reconciliation audit",
-            "Project onboarding",
-        ):
-            self.assertIn(label, response.text)
-        self.assertIn("Copy prompt", response.text)
-        self.assertIn("sha256:", response.text)
-        self.assertNotIn("child issue", response.text.lower())
-
-    def test_prompt_detail_route(self):
-        response = self.client.get("/prompts/work-issue")
-        self.assertEqual(response.status_code, 200)
-        self.assertIn("work-issue.md", response.text)
-        self.assertIn("Copy prompt", response.text)
-
-    def test_prompt_detail_404(self):
-        self.assertEqual(self.client.get("/prompts/missing").status_code, 404)
-
-    def test_api_prompts_json(self):
-        response = self.client.get("/api/prompts")
-        self.assertEqual(response.status_code, 200)
-        data = response.json()
-        self.assertEqual(data["count"], 7)
-        review = next(item for item in data["prompts"] if item["slug"] == "review-pr")
-        self.assertIn("workflow_hash", review)
-        self.assertIn("review-merge-pr.md", review["workflow_path"])
-
-    def test_prompt_to_dict_roundtrip(self):
-        entry = load_prompt_library()[0]
-        encoded = json.dumps(prompt_to_dict(entry))
-        self.assertIn("workflow_path", encoded)
-
-
-if __name__ == "__main__":
-    unittest.main()

tests/test_webui_queue_dashboard.py

@@ -1,245 +0,0 @@
-"""Tests for web UI live queue dashboard (#429)."""
-import sys
-import unittest
-from datetime import datetime, timedelta, timezone
-from pathlib import Path
-from unittest import mock
-
-sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
-
-from starlette.testclient import TestClient
-
-from webui.app import create_app
-from webui.queue_loader import (
-    PaginationMeta,
-    _classify_issue,
-    _classify_pr,
-    _extract_linked_issue,
-    load_queue_snapshot,
-    snapshot_to_dict,
-)
-
-_RECENT = datetime.now(timezone.utc).isoformat()
-_STALE = (datetime.now(timezone.utc) - timedelta(days=30)).isoformat()
-
-_SAMPLE_PRS = [
-    {
-        "number": 100,
-        "title": "feat: queue dashboard (Closes #429)",
-        "body": "",
-        "mergeable": True,
-        "updated_at": _RECENT,
-        "head": {"ref": "feat/issue-429", "sha": "abc123def456"},
-        "base": {"ref": "master"},
-    },
-    {
-        "number": 99,
-        "title": "fix: conflict",
-        "body": "Closes #50",
-        "mergeable": False,
-        "updated_at": _STALE,
-        "head": {"ref": "fix/issue-50", "sha": "deadbeef0001"},
-        "base": {"ref": "master"},
-    },
-    {
-        "number": 98,
-        "title": "feat: duplicate A (Closes #60)",
-        "body": "",
-        "mergeable": True,
-        "updated_at": _RECENT,
-        "head": {"ref": "feat/issue-60-a", "sha": "111111111111"},
-        "base": {"ref": "master"},
-    },
-    {
-        "number": 97,
-        "title": "feat: duplicate B (Closes #60)",
-        "body": "",
-        "mergeable": True,
-        "updated_at": _RECENT,
-        "head": {"ref": "feat/issue-60-b", "sha": "222222222222"},
-        "base": {"ref": "master"},
-    },
-]
-
-_SAMPLE_ISSUES = [
-    {
-        "number": 429,
-        "title": "Web UI queue dashboard",
-        "state": "open",
-        "labels": [{"name": "status:in-progress"}],
-        "assignee": None,
-        "updated_at": _RECENT,
-    },
-    {
-        "number": 60,
-        "title": "Duplicate PR target",
-        "state": "open",
-        "labels": [],
-        "assignee": None,
-        "updated_at": _RECENT,
-    },
-    {
-        "number": 50,
-        "title": "Blocked PR target",
-        "state": "open",
-        "labels": [],
-        "assignee": None,
-        "updated_at": _STALE,
-    },
-]
-
-
-def _mock_pagination(count: int) -> PaginationMeta:
-    return PaginationMeta(
-        page=1,
-        per_page=50,
-        returned_count=count,
-        has_more=False,
-        is_final_page=True,
-        inventory_complete=True,
-        pages_fetched=1,
-    )
-
-
-def _mock_fetch_prs(*_args, **_kwargs):
-    return list(_SAMPLE_PRS), _mock_pagination(len(_SAMPLE_PRS))
-
-
-def _mock_fetch_issues(*_args, **_kwargs):
-    return list(_SAMPLE_ISSUES), _mock_pagination(len(_SAMPLE_ISSUES))
-
-
-class TestQueueClassification(unittest.TestCase):
-    def test_extract_linked_issue_from_title(self):
-        self.assertEqual(
-            _extract_linked_issue("feat: X (Closes #429)", ""),
-            429,
-        )
-
-    def test_classify_pr_blocked_and_stale(self):
-        pr = _SAMPLE_PRS[1]
-        badges = _classify_pr(
-            pr,
-            issue_claimed=set(),
-            issue_to_prs={50: [99]},
-        )
-        self.assertIn("blocked", badges)
-        self.assertIn("stale", badges)
-
-    def test_classify_pr_duplicate(self):
-        badges = _classify_pr(
-            _SAMPLE_PRS[2],
-            issue_claimed=set(),
-            issue_to_prs={60: [98, 97]},
-        )
-        self.assertIn("duplicate", badges)
-        self.assertIn("in-review", badges)
-
-    def test_classify_issue_claimed_and_duplicate(self):
-        claimed = _classify_issue(_SAMPLE_ISSUES[0], linked_prs=[])
-        self.assertIn("claimed", claimed)
-        duplicate = _classify_issue(_SAMPLE_ISSUES[1], linked_prs=[98, 97])
-        self.assertIn("duplicate", duplicate)
-
-
-class TestQueueLoader(unittest.TestCase):
-    def test_snapshot_with_mock_fetch(self):
-        snapshot = load_queue_snapshot(
-            fetch_prs=_mock_fetch_prs,
-            fetch_issues=_mock_fetch_issues,
-        )
-        self.assertEqual(snapshot.project_id, "gitea-tools")
-        self.assertIsNone(snapshot.fetch_error)
-        self.assertEqual(len(snapshot.prs), 4)
-        self.assertEqual(len(snapshot.issues), 3)
-        self.assertTrue(snapshot.pr_pagination.inventory_complete)
-        self.assertTrue(snapshot.issue_pagination.inventory_complete)
-
-        pr100 = next(p for p in snapshot.prs if p.number == 100)
-        self.assertEqual(pr100.extra["linked_issue"], "429")
-        self.assertIn("claimed", pr100.badges)
-
-    def test_snapshot_dict_export(self):
-        snapshot = load_queue_snapshot(
-            fetch_prs=_mock_fetch_prs,
-            fetch_issues=_mock_fetch_issues,
-        )
-        data = snapshot_to_dict(snapshot)
-        self.assertEqual(data["project_id"], "gitea-tools")
-        self.assertIsNone(data["fetch_error"])
-        self.assertEqual(len(data["prs"]), 4)
-        self.assertTrue(data["pagination"]["prs"]["inventory_complete"])
-
-
-class TestQueueRoutes(unittest.TestCase):
-    def setUp(self):
-        self.client = TestClient(create_app())
-        self._patch = mock.patch(
-            "webui.app.load_queue_snapshot",
-            return_value=load_queue_snapshot(
-                fetch_prs=_mock_fetch_prs,
-                fetch_issues=_mock_fetch_issues,
-            ),
-        )
-        self._patch.start()
-
-    def tearDown(self):
-        self._patch.stop()
-
-    def test_queue_page_renders_tables_and_pagination(self):
-        response = self.client.get("/queue")
-        self.assertEqual(response.status_code, 200)
-        self.assertIn("Live queue", response.text)
-        self.assertIn("Open pull requests", response.text)
-        self.assertIn("Open issues", response.text)
-        self.assertIn("pages_fetched", response.text)
-        self.assertIn("Gitea-Tools", response.text)
-        self.assertNotIn("child issue", response.text.lower())
-
-    def test_api_queue_json(self):
-        response = self.client.get("/api/queue")
-        self.assertEqual(response.status_code, 200)
-        data = response.json()
-        self.assertEqual(data["repo"], "Scaled-Tech-Consulting/Gitea-Tools")
-        self.assertEqual(data["pagination"]["issues"]["returned_count"], 3)
-
-    def test_queue_fail_closed_without_credentials(self):
-        with mock.patch("webui.queue_loader.get_auth_header", return_value=None):
-            snapshot = load_queue_snapshot()
-        self.assertIsNotNone(snapshot.fetch_error)
-        self.assertEqual(len(snapshot.prs), 0)
-
-    def test_queue_fail_closed_hides_empty_state_copy(self):
-        with mock.patch("webui.queue_loader.get_auth_header", return_value=None):
-            snapshot = load_queue_snapshot()
-        with mock.patch("webui.app.load_queue_snapshot", return_value=snapshot):
-            response = self.client.get("/queue")
-        self.assertEqual(response.status_code, 200)
-        self.assertIn("Queue unavailable", response.text)
-        self.assertIn("not fetched", response.text.lower())
-        self.assertNotIn("No open items.", response.text)
-        self.assertNotIn("Open pull requests", response.text)
-        self.assertNotIn("pages_fetched", response.text)
-
-    def test_queue_successful_empty_inventory_shows_empty_state(self):
-        def _empty_prs(*_args, **_kwargs):
-            return [], _mock_pagination(0)
-
-        def _empty_issues(*_args, **_kwargs):
-            return [], _mock_pagination(0)
-
-        snapshot = load_queue_snapshot(
-            fetch_prs=_empty_prs,
-            fetch_issues=_empty_issues,
-        )
-        with mock.patch("webui.app.load_queue_snapshot", return_value=snapshot):
-            response = self.client.get("/queue")
-        self.assertEqual(response.status_code, 200)
-        self.assertIsNone(snapshot.fetch_error)
-        self.assertEqual(response.text.count("No open items."), 2)
-        self.assertIn("pages_fetched", response.text)
-        self.assertIn("pagination (complete)", response.text)
-
-
-if __name__ == "__main__":
-    unittest.main()

tests/test_webui_skeleton.py

@@ -1,73 +0,0 @@
-"""Tests for internal web UI skeleton (#426)."""
-import sys
-import unittest
-from pathlib import Path
-
-sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
-
-from starlette.testclient import TestClient
-
-from webui.app import create_app
-
-
-class TestWebuiSkeleton(unittest.TestCase):
-    def setUp(self):
-        self.client = TestClient(create_app())
-
-    def test_health_returns_json(self):
-        response = self.client.get("/health")
-        self.assertEqual(response.status_code, 200)
-        data = response.json()
-        self.assertEqual(data["status"], "ok")
-        self.assertEqual(data["service"], "mcp-control-plane-webui")
-        self.assertEqual(data["mode"], "read-only-mvp")
-        self.assertIn("timestamp", data)
-
-    def test_home_renders(self):
-        response = self.client.get("/")
-        self.assertEqual(response.status_code, 200)
-        self.assertIn("Operator console", response.text)
-        self.assertIn("Read-only MVP", response.text)
-
-    def test_route_stubs_render(self):
-        for path in ("/runtime", "/audit"):
-            with self.subTest(path=path):
-                response = self.client.get(path)
-                self.assertEqual(response.status_code, 200)
-                self.assertIn("child issue", response.text.lower())
-
-    def test_prompts_is_implemented(self):
-        response = self.client.get("/prompts")
-        self.assertEqual(response.status_code, 200)
-        self.assertIn("Prompt library", response.text)
-
-    def test_projects_is_implemented(self):
-        response = self.client.get("/projects")
-        self.assertEqual(response.status_code, 200)
-        self.assertIn("Gitea-Tools", response.text)
-
-    def test_extra_stub_routes(self):
-        for path in ("/worktrees", "/leases"):
-            with self.subTest(path=path):
-                self.assertEqual(self.client.get(path).status_code, 200)
-
-    def test_post_is_rejected(self):
-        response = self.client.post("/health")
-        self.assertEqual(response.status_code, 405)
-        self.assertEqual(response.json()["error"], "read-only-mvp")
-
-    def test_queue_route_renders(self):
-        response = self.client.get("/queue")
-        self.assertEqual(response.status_code, 200)
-        self.assertIn("Live queue", response.text)
-
-    def test_nav_links_on_all_pages(self):
-        for path in ("/", "/queue", "/projects", "/prompts", "/runtime", "/audit"):
-            with self.subTest(path=path):
-                text = self.client.get(path).text
-                for href in ("/queue", "/projects", "/prompts", "/runtime", "/audit"):
-                    self.assertIn(f'href="{href}"', text)
-
-
-if __name__ == "__main__":
-    unittest.main()

webui/__init__.py

@@ -1,5 +0,0 @@
-"""Internal MCP Control Plane web UI (read-only MVP skeleton, #426)."""
-
-from webui.app import create_app
-
-__all__ = ["create_app"]

webui/__main__.py

@@ -1,19 +0,0 @@
-"""Run the internal web UI: ``python -m webui``."""
-
-from __future__ import annotations
-
-import os
-
-import uvicorn
-
-from webui.app import create_app
-
-
-def main() -> None:
-    host = os.environ.get("WEBUI_HOST", "127.0.0.1")
-    port = int(os.environ.get("WEBUI_PORT", "8765"))
-    uvicorn.run(create_app(), host=host, port=port, log_level="info")
-
-
-if __name__ == "__main__":
-    main()

webui/app.py

@@ -1,180 +0,0 @@
-"""Starlette application for the internal read-only web UI (#426)."""
-
-from __future__ import annotations
-
-from datetime import datetime, timezone
-
-from starlette.applications import Starlette
-from starlette.requests import Request
-from starlette.responses import HTMLResponse, JSONResponse, Response
-from starlette.routing import Route
-
-from webui.layout import render_page
-from webui.project_registry import find_project, load_registry, registry_to_dict
-from webui.project_views import render_project_detail, render_projects_list
-from webui.prompt_library import find_prompt, library_to_dict
-from webui.prompt_views import render_prompt_detail, render_prompts_page
-from webui.queue_loader import load_queue_snapshot, snapshot_to_dict
-from webui.queue_views import render_queue_page
-
-_READ_ONLY_METHODS = frozenset({"GET", "HEAD", "OPTIONS"})
-
-
-def _stub_page(title: str, description: str) -> HTMLResponse:
-    body = (
-        f"<h2>{title}</h2>"
-        f'<div class="stub"><p>{description}</p>'
-        "<p>Implementation tracked in a child issue of #425.</p></div>"
-    )
-    return HTMLResponse(render_page(title=title, body_html=body))
-
-
-async def home(_request: Request) -> HTMLResponse:
-    body = (
-        "<h2>Operator console</h2>"
-        "<p>Local entry point for MCP Control Plane operational views.</p>"
-        "<ul>"
-        "<li><strong>Queue</strong> — live PR and issue dashboard (#429)</li>"
-        "<li><strong>Projects</strong> — registry and onboarding (#427)</li>"
-        "<li><strong>Prompts</strong> — canonical workflow prompt library (#428)</li>"
-        "<li><strong>Runtime</strong> — MCP health and stale-runtime detection (#430)</li>"
-        "<li><strong>Audit</strong> — final-report paste and validator preview (#431)</li>"
-        "<li><strong>Worktrees</strong> — branch hygiene dashboard (#432)</li>"
-        "<li><strong>Leases</strong> — collision and lease visibility (#433)</li>"
-        "</ul>"
-    )
-    return HTMLResponse(render_page(title="Home", body_html=body))
-
-
-async def health(_request: Request) -> JSONResponse:
-    return JSONResponse({
-        "status": "ok",
-        "service": "mcp-control-plane-webui",
-        "mode": "read-only-mvp",
-        "timestamp": datetime.now(timezone.utc).isoformat(),
-    })
-
-
-async def queue(_request: Request) -> HTMLResponse:
-    snapshot = load_queue_snapshot()
-    return HTMLResponse(render_page(title="Queue", body_html=render_queue_page(snapshot)))
-
-
-async def api_queue(_request: Request) -> JSONResponse:
-    return JSONResponse(snapshot_to_dict(load_queue_snapshot()))
-
-
-async def projects(_request: Request) -> HTMLResponse:
-    registry = load_registry()
-    return HTMLResponse(render_projects_list(registry))
-
-
-async def project_detail(request: Request) -> HTMLResponse:
-    project_id = request.path_params["project_id"]
-    registry = load_registry()
-    project = find_project(registry, project_id)
-    if project is None:
-        return HTMLResponse(
-            render_page(
-                title="Project not found",
-                body_html=(
-                    "<h2>Project not found</h2>"
-                    f"<p>No registry entry for <code>{project_id}</code>.</p>"
-                    '<p><a href="/projects">← All projects</a></p>'
-                ),
-            ),
-            status_code=404,
-        )
-    return HTMLResponse(render_project_detail(project))
-
-
-async def api_projects(_request: Request) -> JSONResponse:
-    registry = load_registry()
-    return JSONResponse(registry_to_dict(registry))
-
-
-async def prompts(_request: Request) -> HTMLResponse:
-    return HTMLResponse(render_prompts_page())
-
-
-async def prompt_detail(request: Request) -> HTMLResponse:
-    prompt_id = request.path_params["prompt_id"]
-    prompt = find_prompt(prompt_id)
-    if prompt is None:
-        return HTMLResponse(
-            render_page(
-                title="Prompt not found",
-                body_html=(
-                    "<h2>Prompt not found</h2>"
-                    f"<p>No library entry for <code>{prompt_id}</code>.</p>"
-                    '<p><a href="/prompts">← All prompts</a></p>'
-                ),
-            ),
-            status_code=404,
-        )
-    return HTMLResponse(render_prompt_detail(prompt))
-
-
-async def api_prompts(_request: Request) -> JSONResponse:
-    return JSONResponse(library_to_dict())
-
-
-async def runtime(_request: Request) -> HTMLResponse:
-    return _stub_page(
-        "Runtime",
-        "Runtime health will report MCP profile, preflight, and stale-server signals.",
-    )
-
-
-async def audit(_request: Request) -> HTMLResponse:
-    return _stub_page(
-        "Audit",
-        "Report audit will accept pasted final reports and run validator previews.",
-    )
-
-
-async def worktrees(_request: Request) -> HTMLResponse:
-    return _stub_page(
-        "Worktrees",
-        "Worktree hygiene will summarize branches/ session folders and cleanup risk.",
-    )
-
-
-async def leases(_request: Request) -> HTMLResponse:
-    return _stub_page(
-        "Leases",
-        "Lease visibility will show active issue and reviewer PR leases.",
-    )
-
-
-async def method_not_allowed(request: Request, _exc: Exception) -> Response:
-    if request.method not in _READ_ONLY_METHODS:
-        return JSONResponse(
-            {"error": "read-only-mvp", "detail": f"{request.method} not permitted"},
-            status_code=405,
-        )
-    return JSONResponse({"error": "not_found"}, status_code=404)
-
-
-def create_app() -> Starlette:
-    """Build the read-only MVP Starlette app."""
-    return Starlette(
-        debug=False,
-        routes=[
-            Route("/", home, methods=["GET"]),
-            Route("/health", health, methods=["GET"]),
-            Route("/queue", queue, methods=["GET"]),
-            Route("/api/queue", api_queue, methods=["GET"]),
-            Route("/projects", projects, methods=["GET"]),
-            Route("/projects/{project_id}", project_detail, methods=["GET"]),
-            Route("/api/projects", api_projects, methods=["GET"]),
-            Route("/prompts", prompts, methods=["GET"]),
-            Route("/prompts/{prompt_id}", prompt_detail, methods=["GET"]),
-            Route("/api/prompts", api_prompts, methods=["GET"]),
-            Route("/runtime", runtime, methods=["GET"]),
-            Route("/audit", audit, methods=["GET"]),
-            Route("/worktrees", worktrees, methods=["GET"]),
-            Route("/leases", leases, methods=["GET"]),
-        ],
-        exception_handlers={405: method_not_allowed},
-    )

webui/data/projects.registry.json

@@ -1,49 +0,0 @@
-{
-  "version": 1,
-  "projects": [
-    {
-      "id": "gitea-tools",
-      "repo_name": "Gitea-Tools",
-      "gitea_owner": "Scaled-Tech-Consulting",
-      "remote_host": "https://gitea.prgs.cc",
-      "default_branch": "master",
-      "local_checkout_path": ".",
-      "profiles": {
-        "author": "prgs-author",
-        "reviewer": "prgs-reviewer",
-        "reconciler": "prgs-reconciler"
-      },
-      "workflow_paths": {
-        "skill": "skills/llm-project-workflow/SKILL.md",
-        "work_issue": "skills/llm-project-workflow/workflows/work-issue.md",
-        "review_merge": "skills/llm-project-workflow/workflows/review-merge-pr.md"
-      },
-      "schema_paths": {
-        "mcp_config_v2": "gitea-mcp.v2-contexts.example.json",
-        "mcp_config_v1": "gitea-mcp.example.json"
-      },
-      "onboarding_checklist": [
-        {
-          "id": "profiles",
-          "title": "Configure execution profiles",
-          "description": "Install author, reviewer, and reconciler MCP profiles (prgs-author, prgs-reviewer, prgs-reconciler) in separate namespaces. Tokens stay in keychain — never in this registry."
-        },
-        {
-          "id": "mcp_config",
-          "title": "Wire MCP v2 contexts",
-          "description": "Copy and customize gitea-mcp.v2-contexts.example.json for your machine. Map this repo path under projects with default_owner Scaled-Tech-Consulting and default_repo Gitea-Tools."
-        },
-        {
-          "id": "wiki_gate",
-          "title": "Wiki publication readiness",
-          "description": "For wiki-tracked work, satisfy the live Gitea Wiki proof gate (#224) before closing issues. See docs/wiki/Safety-and-Gates.md."
-        },
-        {
-          "id": "branches_layout",
-          "title": "Isolate work under branches/",
-          "description": "All LLM task edits happen in worktrees under branches/. Main checkout stays clean; use skills/llm-project-workflow templates for start-issue and review flows."
-        }
-      ]
-    }
-  ]
-}

webui/layout.py

@@ -1,176 +0,0 @@
-"""Shared HTML layout for the internal web UI."""
-
-from __future__ import annotations
-
-NAV_ITEMS = (
-    ("/", "Home"),
-    ("/queue", "Queue"),
-    ("/projects", "Projects"),
-    ("/prompts", "Prompts"),
-    ("/runtime", "Runtime"),
-    ("/audit", "Audit"),
-    ("/worktrees", "Worktrees"),
-    ("/leases", "Leases"),
-)
-
-MVP_NOTICE = (
-    "Read-only MVP — Gitea, MCP tools, and canonical workflows remain the "
-    "source of truth. No mutation endpoints."
-)
-
-
-def render_page(*, title: str, body_html: str, extra_head: str = "") -> str:
-    nav_links = "".join(
-        f'<a href="{href}">{label}</a>' for href, label in NAV_ITEMS
-    )
-    return f"""<!DOCTYPE html>
-<html lang="en">
-<head>
-  <meta charset="utf-8">
-  <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title>{title} · MCP Control Plane</title>
-  <style>
-    :root {{
-      --bg: #0f1419;
-      --surface: #1a2332;
-      --text: #e7ecf3;
-      --muted: #8b9cb3;
-      --accent: #5b9fd4;
-      --border: #2a3648;
-    }}
-    * {{ box-sizing: border-box; }}
-    body {{
-      margin: 0;
-      font-family: system-ui, -apple-system, sans-serif;
-      background: var(--bg);
-      color: var(--text);
-      line-height: 1.5;
-    }}
-    header {{
-      background: var(--surface);
-      border-bottom: 1px solid var(--border);
-      padding: 0.75rem 1.25rem;
-    }}
-    header h1 {{
-      margin: 0 0 0.5rem;
-      font-size: 1.1rem;
-      font-weight: 600;
-    }}
-    nav {{
-      display: flex;
-      flex-wrap: wrap;
-      gap: 0.75rem 1rem;
-    }}
-    nav a {{
-      color: var(--accent);
-      text-decoration: none;
-      font-size: 0.9rem;
-    }}
-    nav a:hover {{ text-decoration: underline; }}
-    main {{
-      max-width: 52rem;
-      margin: 0 auto;
-      padding: 1.5rem 1.25rem 2.5rem;
-    }}
-    .notice {{
-      color: var(--muted);
-      font-size: 0.85rem;
-      margin-bottom: 1.25rem;
-      padding: 0.65rem 0.85rem;
-      border: 1px solid var(--border);
-      border-radius: 6px;
-      background: var(--surface);
-    }}
-    h2 {{ margin-top: 0; font-size: 1.35rem; }}
-    p {{ color: var(--muted); }}
-    .stub {{
-      border-left: 3px solid var(--accent);
-      padding-left: 0.85rem;
-      margin: 1rem 0;
-    }}
-    .meta {{ font-size: 0.85rem; }}
-    table.registry, table.detail {{
-      width: 100%;
-      border-collapse: collapse;
-      margin: 1rem 0;
-      font-size: 0.9rem;
-    }}
-    table.registry th, table.registry td,
-    table.detail th, table.detail td {{
-      text-align: left;
-      padding: 0.45rem 0.6rem;
-      border-bottom: 1px solid var(--border);
-    }}
-    table.registry th, table.detail th {{
-      color: var(--muted);
-      font-weight: 500;
-    }}
-    code {{
-      font-family: ui-monospace, monospace;
-      font-size: 0.85em;
-      color: var(--text);
-    }}
-    ol.checklist {{
-      padding-left: 1.25rem;
-      margin: 0.5rem 0 1.5rem;
-    }}
-    ol.checklist li {{ margin-bottom: 0.85rem; }}
-    ol.checklist p {{ margin: 0.25rem 0 0; font-size: 0.9rem; }}
-    .prompt-card {{
-      margin: 1.25rem 0 1.75rem;
-      padding: 1rem 1.1rem;
-      border: 1px solid var(--border);
-      border-radius: 8px;
-      background: var(--surface);
-    }}
-    .prompt-card h3 {{ margin: 0 0 0.5rem; font-size: 1.05rem; }}
-    pre.prompt-text {{
-      white-space: pre-wrap;
-      word-break: break-word;
-      margin: 0.75rem 0;
-      padding: 0.75rem 0.85rem;
-      border-radius: 6px;
-      background: var(--bg);
-      border: 1px solid var(--border);
-      font-size: 0.9rem;
-      color: var(--text);
-    }}
-    .copy-btn {{
-      background: var(--accent);
-      color: #0b1219;
-      border: none;
-      border-radius: 6px;
-      padding: 0.4rem 0.85rem;
-      font-size: 0.85rem;
-      cursor: pointer;
-    }}
-    .copy-btn:hover {{ filter: brightness(1.08); }}
-    .muted {{ color: var(--muted); }}
-    .badges {{ display: inline-flex; flex-wrap: wrap; gap: 0.35rem; margin-left: 0.5rem; }}
-    .badge {{
-      font-size: 0.72rem;
-      padding: 0.1rem 0.45rem;
-      border-radius: 999px;
-      border: 1px solid var(--border);
-      color: var(--muted);
-      text-transform: lowercase;
-    }}
-    .badge-claimed {{ color: #8fd19e; border-color: #3d6b4a; }}
-    .badge-blocked {{ color: #f0a8a8; border-color: #7a3b3b; }}
-    .badge-in-review {{ color: #9ec8f0; border-color: #3d5f7a; }}
-    .badge-duplicate {{ color: #e0c27a; border-color: #6b5730; }}
-    .badge-stale {{ color: #c9b8e8; border-color: #5a4a78; }}
-  </style>
-  {extra_head}
-</head>
-<body>
-  <header>
-    <h1>MCP Control Plane</h1>
-    <nav>{nav_links}</nav>
-  </header>
-  <main>
-    <p class="notice">{MVP_NOTICE}</p>
-    {body_html}
-  </main>
-</body>
-</html>"""

webui/project_registry.py

@@ -1,196 +0,0 @@
-"""Load and validate the web UI project registry (#427)."""
-
-from __future__ import annotations
-
-import json
-import os
-from dataclasses import dataclass
-from pathlib import Path
-from typing import Any
-
-_FORBIDDEN_EXACT_KEYS = frozenset({
-    "token",
-    "password",
-    "secret",
-    "credential",
-    "auth",
-    "api_key",
-    "api-key",
-})
-_FORBIDDEN_KEY_PREFIXES = ("auth_", "api_key_", "api-key_")
-_FORBIDDEN_KEY_SUFFIXES = ("_token", "_secret", "_password", "_credential", "_auth")
-
-
-def _is_forbidden_key(key: str) -> bool:
-    lowered = key.lower()
-    if lowered in _FORBIDDEN_EXACT_KEYS:
-        return True
-    return (
-        lowered.startswith(_FORBIDDEN_KEY_PREFIXES)
-        or lowered.endswith(_FORBIDDEN_KEY_SUFFIXES)
-    )
-
-_REQUIRED_PROJECT_FIELDS = (
-    "id",
-    "repo_name",
-    "gitea_owner",
-    "remote_host",
-    "default_branch",
-    "local_checkout_path",
-    "profiles",
-    "workflow_paths",
-)
-
-_REQUIRED_PROFILE_ROLES = ("author", "reviewer", "reconciler")
-
-
-@dataclass(frozen=True)
-class OnboardingStep:
-    id: str
-    title: str
-    description: str
-
-
-@dataclass(frozen=True)
-class ProjectRecord:
-    id: str
-    repo_name: str
-    gitea_owner: str
-    remote_host: str
-    default_branch: str
-    local_checkout_path: str
-    profiles: dict[str, str]
-    workflow_paths: dict[str, str]
-    schema_paths: dict[str, str]
-    onboarding_checklist: tuple[OnboardingStep, ...]
-
-
-@dataclass(frozen=True)
-class ProjectRegistry:
-    version: int
-    projects: tuple[ProjectRecord, ...]
-    source_path: Path
-
-
-def default_registry_path() -> Path:
-    override = os.environ.get("WEBUI_PROJECT_REGISTRY", "").strip()
-    if override:
-        return Path(override).expanduser().resolve()
-    return (Path(__file__).resolve().parent / "data" / "projects.registry.json").resolve()
-
-
-def _reject_credential_keys(obj: Any, *, path: str = "") -> None:
-    if isinstance(obj, dict):
-        for key, value in obj.items():
-            key_path = f"{path}.{key}" if path else key
-            if _is_forbidden_key(key):
-                raise ValueError(f"registry must not store credentials ({key_path})")
-            _reject_credential_keys(value, path=key_path)
-    elif isinstance(obj, list):
-        for index, item in enumerate(obj):
-            _reject_credential_keys(item, path=f"{path}[{index}]")
-
-
-def _parse_onboarding(raw: list[dict[str, Any]] | None) -> tuple[OnboardingStep, ...]:
-    if not raw:
-        return ()
-    steps: list[OnboardingStep] = []
-    for item in raw:
-        steps.append(
-            OnboardingStep(
-                id=str(item["id"]),
-                title=str(item["title"]),
-                description=str(item["description"]),
-            )
-        )
-    return tuple(steps)
-
-
-def _parse_project(raw: dict[str, Any]) -> ProjectRecord:
-    missing = [field for field in _REQUIRED_PROJECT_FIELDS if field not in raw]
-    if missing:
-        raise ValueError(f"project missing required fields: {', '.join(missing)}")
-
-    profiles = raw["profiles"]
-    if not isinstance(profiles, dict):
-        raise ValueError("profiles must be an object")
-    for role in _REQUIRED_PROFILE_ROLES:
-        if role not in profiles or not profiles[role]:
-            raise ValueError(f"profiles.{role} is required")
-
-    workflow_paths = raw["workflow_paths"]
-    if not isinstance(workflow_paths, dict) or not workflow_paths:
-        raise ValueError("workflow_paths must be a non-empty object")
-
-    schema_paths = raw.get("schema_paths") or {}
-    if not isinstance(schema_paths, dict):
-        raise ValueError("schema_paths must be an object when present")
-
-    return ProjectRecord(
-        id=str(raw["id"]),
-        repo_name=str(raw["repo_name"]),
-        gitea_owner=str(raw["gitea_owner"]),
-        remote_host=str(raw["remote_host"]),
-        default_branch=str(raw["default_branch"]),
-        local_checkout_path=str(raw["local_checkout_path"]),
-        profiles={role: str(profiles[role]) for role in _REQUIRED_PROFILE_ROLES},
-        workflow_paths={key: str(value) for key, value in workflow_paths.items()},
-        schema_paths={key: str(value) for key, value in schema_paths.items()},
-        onboarding_checklist=_parse_onboarding(raw.get("onboarding_checklist")),
-    )
-
-
-def load_registry(path: Path | None = None) -> ProjectRegistry:
-    """Load the versioned project registry from disk."""
-    source = (path or default_registry_path()).resolve()
-    raw_text = source.read_text(encoding="utf-8")
-    payload = json.loads(raw_text)
-    if not isinstance(payload, dict):
-        raise ValueError("registry root must be an object")
-
-    version = payload.get("version")
-    if version != 1:
-        raise ValueError(f"unsupported registry version: {version!r}")
-
-    _reject_credential_keys(payload)
-
-    projects_raw = payload.get("projects")
-    if not isinstance(projects_raw, list) or not projects_raw:
-        raise ValueError("projects must be a non-empty array")
-
-    projects = tuple(_parse_project(item) for item in projects_raw)
-    return ProjectRegistry(version=version, projects=projects, source_path=source)
-
-
-def project_to_dict(project: ProjectRecord) -> dict[str, Any]:
-    """Serialize a project for JSON API responses."""
-    return {
-        "id": project.id,
-        "repo_name": project.repo_name,
-        "gitea_owner": project.gitea_owner,
-        "remote_host": project.remote_host,
-        "default_branch": project.default_branch,
-        "local_checkout_path": project.local_checkout_path,
-        "profiles": dict(project.profiles),
-        "workflow_paths": dict(project.workflow_paths),
-        "schema_paths": dict(project.schema_paths),
-        "onboarding_checklist": [
-            {"id": step.id, "title": step.title, "description": step.description}
-            for step in project.onboarding_checklist
-        ],
-    }
-
-
-def registry_to_dict(registry: ProjectRegistry) -> dict[str, Any]:
-    return {
-        "version": registry.version,
-        "source_path": str(registry.source_path),
-        "projects": [project_to_dict(project) for project in registry.projects],
-    }
-
-
-def find_project(registry: ProjectRegistry, project_id: str) -> ProjectRecord | None:
-    for project in registry.projects:
-        if project.id == project_id:
-            return project
-    return None

webui/project_views.py

@@ -1,93 +0,0 @@
-"""HTML views for project registry pages (#427)."""
-
-from __future__ import annotations
-
-import html
-
-from webui.layout import render_page
-from webui.project_registry import ProjectRecord, ProjectRegistry
-
-
-def _escape(text: str) -> str:
-    return html.escape(text, quote=True)
-
-
-def render_projects_list(registry: ProjectRegistry) -> str:
-    rows = []
-    for project in registry.projects:
-        rows.append(
-            "<tr>"
-            f"<td><a href=\"/projects/{_escape(project.id)}\">{_escape(project.repo_name)}</a></td>"
-            f"<td>{_escape(project.gitea_owner)}</td>"
-            f"<td>{_escape(project.remote_host)}</td>"
-            f"<td>{_escape(project.default_branch)}</td>"
-            f"<td><code>{_escape(project.profiles['author'])}</code></td>"
-            "</tr>"
-        )
-    table = (
-        "<table class=\"registry\">"
-        "<thead><tr>"
-        "<th>Repository</th><th>Owner</th><th>Remote</th>"
-        "<th>Branch</th><th>Author profile</th>"
-        "</tr></thead>"
-        f"<tbody>{''.join(rows)}</tbody></table>"
-    )
-    body = (
-        "<h2>Projects</h2>"
-        "<p>Configured repositories managed by the MCP Control Plane.</p>"
-        f"<p class=\"meta\">Registry: <code>{_escape(str(registry.source_path))}</code> "
-        f"(version {registry.version})</p>"
-        f"{table}"
-        "<p><a href=\"/api/projects\">JSON API</a></p>"
-    )
-    return render_page(title="Projects", body_html=body)
-
-
-def render_project_detail(project: ProjectRecord) -> str:
-    profile_rows = "".join(
-        f"<tr><th>{_escape(role)}</th><td><code>{_escape(name)}</code></td></tr>"
-        for role, name in project.profiles.items()
-    )
-    workflow_rows = "".join(
-        f"<tr><th>{_escape(key)}</th><td><code>{_escape(path)}</code></td></tr>"
-        for key, path in project.workflow_paths.items()
-    )
-    schema_rows = "".join(
-        f"<tr><th>{_escape(key)}</th><td><code>{_escape(path)}</code></td></tr>"
-        for key, path in project.schema_paths.items()
-    )
-    checklist_items = []
-    for index, step in enumerate(project.onboarding_checklist, start=1):
-        checklist_items.append(
-            "<li>"
-            f"<strong>{index}. {_escape(step.title)}</strong>"
-            f"<p>{_escape(step.description)}</p>"
-            "</li>"
-        )
-    checklist_html = (
-        "<ol class=\"checklist\">" + "".join(checklist_items) + "</ol>"
-        if checklist_items
-        else "<p>No onboarding steps defined.</p>"
-    )
-    body = (
-        f"<h2>{_escape(project.repo_name)}</h2>"
-        "<p><a href=\"/projects\">← All projects</a></p>"
-        "<h3>Identity</h3>"
-        "<table class=\"detail\">"
-        f"<tr><th>Registry id</th><td><code>{_escape(project.id)}</code></td></tr>"
-        f"<tr><th>Gitea owner</th><td>{_escape(project.gitea_owner)}</td></tr>"
-        f"<tr><th>Remote host</th><td>{_escape(project.remote_host)}</td></tr>"
-        f"<tr><th>Default branch</th><td><code>{_escape(project.default_branch)}</code></td></tr>"
-        f"<tr><th>Local checkout</th><td><code>{_escape(project.local_checkout_path)}</code></td></tr>"
-        "</table>"
-        "<h3>Profiles</h3>"
-        f"<table class=\"detail\">{profile_rows}</table>"
-        "<h3>Workflow paths</h3>"
-        f"<table class=\"detail\">{workflow_rows}</table>"
-        "<h3>Schema paths</h3>"
-        f"<table class=\"detail\">{schema_rows}</table>"
-        "<h3>Onboarding checklist</h3>"
-        "<p class=\"meta\">Read-only MVP — complete these steps outside the UI.</p>"
-        f"{checklist_html}"
-    )
-    return render_page(title=project.repo_name, body_html=body)

webui/prompt_library.py

@@ -1,197 +0,0 @@
-"""Canonical workflow prompt library for the internal web UI (#428)."""
-
-from __future__ import annotations
-
-import hashlib
-import os
-import re
-from dataclasses import dataclass
-from pathlib import Path
-from typing import Any
-
-_WORKFLOW_ROOT = Path("skills/llm-project-workflow/workflows")
-
-_DEFAULT_PROMPT_RE = re.compile(
-    r"\*\*Default task prompt:\*\*\s*\n+>\s*(.+?)(?=\n\n|\nDo not improvise)",
-    re.DOTALL,
-)
-_FRONTMATTER_TASK_MODE_RE = re.compile(r"^task_mode:\s*(\S+)", re.MULTILINE)
-
-
-@dataclass(frozen=True)
-class PromptEntry:
-    slug: str
-    label: str
-    prompt_text: str
-    workflow_path: str
-    task_mode: str | None
-    workflow_hash: str | None
-    source_note: str
-
-
-def _repo_root() -> Path:
-    override = (os.environ.get("WEBUI_REPO_ROOT") or "").strip()
-    if override:
-        return Path(override).resolve()
-    return Path(__file__).resolve().parent.parent
-
-
-def _workflow_file(path: str) -> Path:
-    return _repo_root() / path
-
-
-def _sha256_hex(content: str) -> str:
-    return hashlib.sha256(content.encode("utf-8")).hexdigest()
-
-
-def _read_workflow(path: str) -> tuple[str, str]:
-    file_path = _workflow_file(path)
-    text = file_path.read_text(encoding="utf-8")
-    return text, _sha256_hex(text)
-
-
-def _extract_default_prompt(markdown: str) -> str | None:
-    match = _DEFAULT_PROMPT_RE.search(markdown)
-    if not match:
-        return None
-    lines = [line.strip() for line in match.group(1).splitlines()]
-    return " ".join(line for line in lines if line)
-
-
-def _extract_task_mode(markdown: str) -> str | None:
-    match = _FRONTMATTER_TASK_MODE_RE.search(markdown)
-    return match.group(1) if match else None
-
-
-def _entry_from_workflow(
-    *,
-    slug: str,
-    label: str,
-    workflow_path: str,
-    prompt_override: str | None = None,
-    source_note: str = "",
-) -> PromptEntry:
-    markdown, digest = _read_workflow(workflow_path)
-    prompt_text = prompt_override or _extract_default_prompt(markdown)
-    if not prompt_text:
-        raise ValueError(f"No default task prompt found in {workflow_path}")
-    return PromptEntry(
-        slug=slug,
-        label=label,
-        prompt_text=prompt_text,
-        workflow_path=workflow_path,
-        task_mode=_extract_task_mode(markdown),
-        workflow_hash=digest,
-        source_note=source_note,
-    )
-
-
-def _static_entry(
-    *,
-    slug: str,
-    label: str,
-    prompt_text: str,
-    workflow_path: str,
-    source_note: str,
-) -> PromptEntry:
-    path = _workflow_file(workflow_path)
-    digest = _sha256_hex(path.read_text(encoding="utf-8")) if path.is_file() else None
-    markdown = path.read_text(encoding="utf-8") if path.is_file() else ""
-    return PromptEntry(
-        slug=slug,
-        label=label,
-        prompt_text=prompt_text,
-        workflow_path=workflow_path,
-        task_mode=_extract_task_mode(markdown) if markdown else None,
-        workflow_hash=digest,
-        source_note=source_note,
-    )
-
-
-def load_prompt_library() -> tuple[PromptEntry, ...]:
-    """Load operator prompts derived from canonical workflows."""
-    entries = (
-        _entry_from_workflow(
-            slug="review-pr",
-            label="Review PR",
-            workflow_path=str(_WORKFLOW_ROOT / "review-merge-pr.md"),
-        ),
-        _entry_from_workflow(
-            slug="work-issue",
-            label="Work issue",
-            workflow_path=str(_WORKFLOW_ROOT / "work-issue.md"),
-        ),
-        _entry_from_workflow(
-            slug="create-issue",
-            label="Create issue",
-            workflow_path=str(_WORKFLOW_ROOT / "create-issue.md"),
-        ),
-        _static_entry(
-            slug="comment-issue",
-            label="Comment on issue",
-            workflow_path=str(_WORKFLOW_ROOT / "create-issue.md"),
-            prompt_text=(
-                "Comment on the target Gitea issue only if exact comment_issue "
-                "capability is proven. Load the canonical create-issue workflow "
-                "first and follow §16 (comment-on-existing issue rule). Include "
-                "specific evidence; do not duplicate existing comments."
-            ),
-            source_note="Derived from create-issue.md §16; full policy remains in the workflow file.",
-        ),
-        _static_entry(
-            slug="cleanup",
-            label="Post-merge cleanup",
-            workflow_path="skills/llm-project-workflow/templates/worktree-cleanup.md",
-            prompt_text=(
-                "Task: clean up branch/worktree for PR #<pr> / issue #<n> after merge. "
-                "Confirm the merge on remote master before any deletion; never "
-                "force-remove a dirty worktree."
-            ),
-            source_note="Full cleanup steps live in templates/worktree-cleanup.md.",
-        ),
-        _entry_from_workflow(
-            slug="audit",
-            label="Reconciliation audit",
-            workflow_path=str(_WORKFLOW_ROOT / "reconcile-landed-pr.md"),
-        ),
-        _static_entry(
-            slug="onboarding",
-            label="Project onboarding",
-            workflow_path="skills/llm-project-workflow/SKILL.md",
-            prompt_text=(
-                "Onboard this repository into the MCP Control Plane: prove identity "
-                "and task capability, configure author/reviewer/reconciler profiles "
-                "in separate namespaces, then complete the checklist at /projects. "
-                "Canonical router: skills/llm-project-workflow/SKILL.md."
-            ),
-            source_note="Checklist details live in webui/data/projects.registry.json and /projects.",
-        ),
-    )
-    return entries
-
-
-def find_prompt(slug: str) -> PromptEntry | None:
-    for entry in load_prompt_library():
-        if entry.slug == slug:
-            return entry
-    return None
-
-
-def prompt_to_dict(entry: PromptEntry) -> dict[str, Any]:
-    return {
-        "slug": entry.slug,
-        "label": entry.label,
-        "prompt_text": entry.prompt_text,
-        "workflow_path": entry.workflow_path,
-        "task_mode": entry.task_mode,
-        "workflow_hash": entry.workflow_hash,
-        "source_note": entry.source_note,
-    }
-
-
-def library_to_dict() -> dict[str, Any]:
-    entries = load_prompt_library()
-    return {
-        "count": len(entries),
-        "prompts": [prompt_to_dict(entry) for entry in entries],
-    }

webui/prompt_views.py

@@ -1,87 +0,0 @@
-"""HTML views for the prompt library (#428)."""
-
-from __future__ import annotations
-
-import html
-
-from webui.layout import render_page
-from webui.prompt_library import PromptEntry, load_prompt_library
-
-
-def _escape(text: str) -> str:
-    return html.escape(text, quote=True)
-
-
-def _render_prompt_card(entry: PromptEntry) -> str:
-    hash_short = (
-        f"<code>{_escape(entry.workflow_hash[:12])}</code>"
-        if entry.workflow_hash
-        else "<span class=\"muted\">n/a</span>"
-    )
-    task_mode = (
-        f"<code>{_escape(entry.task_mode)}</code>"
-        if entry.task_mode
-        else "<span class=\"muted\">n/a</span>"
-    )
-    note = (
-        f'<p class="meta">{_escape(entry.source_note)}</p>'
-        if entry.source_note
-        else ""
-    )
-    prompt_id = f"prompt-{entry.slug}"
-    return (
-        f'<section class="prompt-card" id="{_escape(entry.slug)}">'
-        f"<h3>{_escape(entry.label)}</h3>"
-        f'<p class="meta">Workflow: <code>{_escape(entry.workflow_path)}</code> · '
-        f"task_mode: {task_mode} · sha256: {hash_short}</p>"
-        f'<pre class="prompt-text" id="{prompt_id}">{_escape(entry.prompt_text)}</pre>'
-        f'<button type="button" class="copy-btn" data-copy-target="{prompt_id}">'
-        "Copy prompt</button>"
-        f"{note}"
-        "</section>"
-    )
-
-
-PROMPT_PAGE_SCRIPT = """
-<script>
-document.querySelectorAll('.copy-btn').forEach((btn) => {
-  btn.addEventListener('click', async () => {
-    const targetId = btn.getAttribute('data-copy-target');
-    const node = document.getElementById(targetId);
-    if (!node) return;
-    const text = node.textContent || '';
-    try {
-      await navigator.clipboard.writeText(text);
-      const prior = btn.textContent;
-      btn.textContent = 'Copied';
-      setTimeout(() => { btn.textContent = prior; }, 1200);
-    } catch (_err) {
-      btn.textContent = 'Copy failed';
-    }
-  });
-});
-</script>
-"""
-
-
-def render_prompts_page() -> str:
-    entries = load_prompt_library()
-    cards = "".join(_render_prompt_card(entry) for entry in entries)
-    body = (
-        "<h2>Prompt library</h2>"
-        "<p>Short copy/paste task prompts derived from canonical workflows. "
-        "Full policy remains in the cited workflow files — not duplicated here.</p>"
-        f"{cards}"
-        "<p><a href=\"/api/prompts\">JSON API</a></p>"
-        f"{PROMPT_PAGE_SCRIPT}"
-    )
-    return render_page(title="Prompts", body_html=body)
-
-
-def render_prompt_detail(entry: PromptEntry) -> str:
-    body = (
-        f"<p><a href=\"/prompts\">← All prompts</a></p>"
-        f"{_render_prompt_card(entry)}"
-        f"{PROMPT_PAGE_SCRIPT}"
-    )
-    return render_page(title=entry.label, body_html=body)

webui/queue_loader.py

@@ -1,385 +0,0 @@
-"""Load live Gitea PR/issue queue state for the web UI dashboard (#429)."""
-
-from __future__ import annotations
-
-import re
-from dataclasses import dataclass
-from datetime import datetime, timezone
-from typing import Any, Callable
-from urllib.parse import urlparse
-
-from gitea_auth import api_fetch_page, get_auth_header, repo_api_url
-
-from webui.project_registry import ProjectRecord, load_registry
-
-_CLOSES_RE = re.compile(r"(?:closes|fixes|resolves)\s+#(\d+)", re.I)
-_ISSUE_REF_RE = re.compile(r"#(\d+)")
-_STALE_DAYS = 14
-
-
-@dataclass(frozen=True)
-class PaginationMeta:
-    page: int
-    per_page: int
-    returned_count: int
-    has_more: bool
-    is_final_page: bool
-    inventory_complete: bool
-    pages_fetched: int
-
-
-@dataclass(frozen=True)
-class QueueItem:
-    number: int
-    title: str
-    badges: tuple[str, ...]
-    extra: dict[str, str]
-
-
-@dataclass(frozen=True)
-class QueueSnapshot:
-    project_id: str
-    repo_label: str
-    prs: tuple[QueueItem, ...]
-    issues: tuple[QueueItem, ...]
-    pr_pagination: PaginationMeta | None
-    issue_pagination: PaginationMeta | None
-    fetch_error: str | None = None
-
-
-def _host_from_url(remote_host: str) -> str:
-    parsed = urlparse(remote_host.strip())
-    return parsed.netloc or remote_host.strip().rstrip("/")
-
-
-def _extract_linked_issue(title: str | None, body: str | None = None) -> int | None:
-    for text in (title, body):
-        if not text:
-            continue
-        match = _CLOSES_RE.search(text)
-        if match:
-            return int(match.group(1))
-    if body:
-        refs = _ISSUE_REF_RE.findall(body)
-        if refs:
-            return int(refs[0])
-    return None
-
-
-def _is_stale(updated_at: str | None) -> bool:
-    if not updated_at:
-        return False
-    try:
-        normalized = updated_at.replace("Z", "+00:00")
-        parsed = datetime.fromisoformat(normalized)
-        if parsed.tzinfo is None:
-            parsed = parsed.replace(tzinfo=timezone.utc)
-        age = datetime.now(timezone.utc) - parsed.astimezone(timezone.utc)
-        return age.days >= _STALE_DAYS
-    except ValueError:
-        return False
-
-
-def _classify_pr(
-    pr: dict,
-    *,
-    issue_claimed: set[int],
-    issue_to_prs: dict[int, list[int]],
-) -> tuple[str, ...]:
-    badges: list[str] = []
-    mergeable = pr.get("mergeable")
-    if mergeable is False:
-        badges.append("blocked")
-    linked = _extract_linked_issue(pr.get("title"), pr.get("body"))
-    if linked is not None:
-        if linked in issue_claimed:
-            badges.append("claimed")
-        if len(issue_to_prs.get(linked, [])) > 1:
-            badges.append("duplicate")
-    if _is_stale(pr.get("updated_at")):
-        badges.append("stale")
-    if mergeable is True and "blocked" not in badges:
-        badges.append("in-review")
-    if not badges:
-        badges.append("open")
-    return tuple(dict.fromkeys(badges))
-
-
-def _classify_issue(
-    issue: dict,
-    *,
-    linked_prs: list[int],
-) -> tuple[str, ...]:
-    badges: list[str] = []
-    labels = [lb.get("name", "") for lb in issue.get("labels", [])]
-    if "status:in-progress" in labels:
-        badges.append("claimed")
-    if len(linked_prs) > 1:
-        badges.append("duplicate")
-    elif linked_prs and "claimed" not in badges:
-        badges.append("in-review")
-    if _is_stale(issue.get("updated_at")):
-        badges.append("stale")
-    if not badges:
-        badges.append("open")
-    return tuple(dict.fromkeys(badges))
-
-
-def _format_pr_item(pr: dict, badges: tuple[str, ...]) -> QueueItem:
-    head = pr.get("head") or {}
-    base = pr.get("base") or {}
-    mergeable = pr.get("mergeable")
-    merge_label = (
-        "mergeable" if mergeable is True else "conflicted" if mergeable is False else "unknown"
-    )
-    linked = _extract_linked_issue(pr.get("title"), pr.get("body"))
-    return QueueItem(
-        number=int(pr["number"]),
-        title=str(pr.get("title") or ""),
-        badges=badges,
-        extra={
-            "branch": f"{head.get('ref', '?')} → {base.get('ref', '?')}",
-            "head_sha": str(head.get("sha") or "")[:12],
-            "mergeable": merge_label,
-            "linked_issue": str(linked) if linked is not None else "",
-        },
-    )
-
-
-def _format_issue_item(issue: dict, badges: tuple[str, ...]) -> QueueItem:
-    labels = ", ".join(lb.get("name", "") for lb in issue.get("labels", []))
-    assignee = (issue.get("assignee") or {}).get("login", "")
-    return QueueItem(
-        number=int(issue["number"]),
-        title=str(issue.get("title") or ""),
-        badges=badges,
-        extra={
-            "labels": labels or "—",
-            "assignee": assignee or "unassigned",
-            "state": str(issue.get("state") or ""),
-        },
-    )
-
-
-def _pagination_from_pages(
-    *,
-    per_page: int,
-    pages_fetched: int,
-    returned_count: int,
-    is_final_page: bool,
-) -> PaginationMeta:
-    return PaginationMeta(
-        page=1,
-        per_page=per_page,
-        returned_count=returned_count,
-        has_more=not is_final_page,
-        is_final_page=is_final_page,
-        inventory_complete=is_final_page,
-        pages_fetched=pages_fetched,
-    )
-
-
-def _fetch_prs(
-    host: str,
-    org: str,
-    repo: str,
-    auth: str,
-    *,
-    per_page: int = 50,
-) -> tuple[list[dict], PaginationMeta]:
-    url = f"{repo_api_url(host, org, repo)}/pulls?state=open"
-    all_raw: list[dict] = []
-    pages_fetched = 0
-    is_final = False
-    page = 1
-    while pages_fetched < 20:
-        raw_page, meta = api_fetch_page(url, auth, page=page, limit=per_page)
-        pages_fetched += 1
-        all_raw.extend(raw_page)
-        is_final = bool(meta["is_final_page"])
-        if is_final:
-            break
-        page += 1
-    pagination = _pagination_from_pages(
-        per_page=per_page,
-        pages_fetched=pages_fetched,
-        returned_count=len(all_raw),
-        is_final_page=is_final,
-    )
-    return all_raw, pagination
-
-
-def _fetch_issues(
-    host: str,
-    org: str,
-    repo: str,
-    auth: str,
-    *,
-    per_page: int = 50,
-) -> tuple[list[dict], PaginationMeta]:
-    url = f"{repo_api_url(host, org, repo)}/issues?state=open&type=issues"
-    all_raw: list[dict] = []
-    page = 1
-    pages_fetched = 0
-    is_final = False
-    while pages_fetched < 20:
-        raw_page, meta = api_fetch_page(url, auth, page=page, limit=per_page)
-        pages_fetched += 1
-        all_raw.extend(raw_page)
-        is_final = bool(meta["is_final_page"])
-        if is_final:
-            break
-        page += 1
-    pagination = _pagination_from_pages(
-        per_page=per_page,
-        pages_fetched=pages_fetched,
-        returned_count=len(all_raw),
-        is_final_page=is_final,
-    )
-    return all_raw, pagination
-
-
-def load_queue_snapshot(
-    project_id: str | None = None,
-    *,
-    fetch_prs: Callable[..., tuple[list[dict], PaginationMeta]] | None = None,
-    fetch_issues: Callable[..., tuple[list[dict], PaginationMeta]] | None = None,
-) -> QueueSnapshot:
-    """Load open PR and issue queues for a registry project (default: first entry)."""
-    registry = load_registry()
-    project: ProjectRecord | None = None
-    if project_id:
-        for entry in registry.projects:
-            if entry.id == project_id:
-                project = entry
-                break
-    else:
-        project = registry.projects[0] if registry.projects else None
-
-    if project is None:
-        return QueueSnapshot(
-            project_id=project_id or "",
-            repo_label="",
-            prs=(),
-            issues=(),
-            pr_pagination=None,
-            issue_pagination=None,
-            fetch_error="project not found in registry",
-        )
-
-    host = _host_from_url(project.remote_host)
-    pr_fetch = fetch_prs or _fetch_prs
-    issue_fetch = fetch_issues or _fetch_issues
-    using_live_fetch = fetch_prs is None or fetch_issues is None
-    auth = get_auth_header(host) if using_live_fetch else "test-auth"
-    if using_live_fetch and not auth:
-        return QueueSnapshot(
-            project_id=project.id,
-            repo_label=f"{project.gitea_owner}/{project.repo_name}",
-            prs=(),
-            issues=(),
-            pr_pagination=None,
-            issue_pagination=None,
-            fetch_error=(
-                f"Gitea credentials unavailable for {host}; "
-                "queue cannot be loaded (fail closed — not showing empty queue)"
-            ),
-        )
-
-    try:
-        raw_prs, pr_pagination = pr_fetch(
-            host, project.gitea_owner, project.repo_name, auth
-        )
-        raw_issues, issue_pagination = issue_fetch(
-            host, project.gitea_owner, project.repo_name, auth
-        )
-    except Exception as exc:  # noqa: BLE001 — surface operator-visible fetch errors
-        return QueueSnapshot(
-            project_id=project.id,
-            repo_label=f"{project.gitea_owner}/{project.repo_name}",
-            prs=(),
-            issues=(),
-            pr_pagination=None,
-            issue_pagination=None,
-            fetch_error=f"Gitea fetch failed: {exc}",
-        )
-
-    issue_to_prs: dict[int, list[int]] = {}
-    for pr in raw_prs:
-        linked = _extract_linked_issue(pr.get("title"), pr.get("body"))
-        if linked is not None:
-            issue_to_prs.setdefault(linked, []).append(int(pr["number"]))
-
-    issue_claimed = {
-        int(i["number"])
-        for i in raw_issues
-        if any(lb.get("name") == "status:in-progress" for lb in i.get("labels", []))
-    }
-
-    pr_items = tuple(
-        _format_pr_item(
-            pr,
-            _classify_pr(
-                pr,
-                issue_claimed=issue_claimed,
-                issue_to_prs=issue_to_prs,
-            ),
-        )
-        for pr in sorted(raw_prs, key=lambda p: int(p["number"]), reverse=True)
-    )
-    issue_items = tuple(
-        _format_issue_item(
-            issue,
-            _classify_issue(
-                issue,
-                linked_prs=issue_to_prs.get(int(issue["number"]), []),
-            ),
-        )
-        for issue in sorted(raw_issues, key=lambda i: int(i["number"]), reverse=True)
-    )
-
-    return QueueSnapshot(
-        project_id=project.id,
-        repo_label=f"{project.gitea_owner}/{project.repo_name}",
-        prs=pr_items,
-        issues=issue_items,
-        pr_pagination=pr_pagination,
-        issue_pagination=issue_pagination,
-    )
-
-
-def snapshot_to_dict(snapshot: QueueSnapshot) -> dict[str, Any]:
-    """JSON-serializable export for /api/queue."""
-
-    def _page(meta: PaginationMeta | None) -> dict[str, Any] | None:
-        if meta is None:
-            return None
-        return {
-            "page": meta.page,
-            "per_page": meta.per_page,
-            "returned_count": meta.returned_count,
-            "has_more": meta.has_more,
-            "is_final_page": meta.is_final_page,
-            "inventory_complete": meta.inventory_complete,
-            "pages_fetched": meta.pages_fetched,
-        }
-
-    def _item(item: QueueItem) -> dict[str, Any]:
-        return {
-            "number": item.number,
-            "title": item.title,
-            "badges": list(item.badges),
-            **item.extra,
-        }
-
-    return {
-        "project_id": snapshot.project_id,
-        "repo": snapshot.repo_label,
-        "fetch_error": snapshot.fetch_error,
-        "prs": [_item(p) for p in snapshot.prs],
-        "issues": [_item(i) for i in snapshot.issues],
-        "pagination": {
-            "prs": _page(snapshot.pr_pagination),
-            "issues": _page(snapshot.issue_pagination),
-        },
-    }

webui/queue_views.py

@@ -1,121 +0,0 @@
-"""HTML views for the live Gitea queue dashboard (#429)."""
-
-from __future__ import annotations
-
-import html
-
-from webui.queue_loader import PaginationMeta, QueueItem, QueueSnapshot
-
-
-def _badge_html(badges: tuple[str, ...]) -> str:
-    if not badges:
-        return ""
-    chips = "".join(
-        f'<span class="badge badge-{html.escape(b)}">{html.escape(b)}</span>'
-        for b in badges
-    )
-    return f'<span class="badges">{chips}</span>'
-
-
-def _pagination_html(label: str, meta: PaginationMeta | None) -> str:
-    if meta is None:
-        return (
-            f"<p class='muted'><strong>{html.escape(label)} pagination:</strong> "
-            "unavailable</p>"
-        )
-    status = "complete" if meta.inventory_complete else "partial"
-    more = "yes" if meta.has_more else "no"
-    return (
-        f"<p class='meta'><strong>{html.escape(label)} pagination ({status}):</strong> "
-        f"returned {meta.returned_count} · per_page {meta.per_page} · "
-        f"pages_fetched {meta.pages_fetched} · has_more {more} · "
-        f"final_page {'yes' if meta.is_final_page else 'no'}</p>"
-    )
-
-
-def _queue_table(
-    *,
-    title: str,
-    items: tuple[QueueItem, ...],
-    columns: tuple[tuple[str, str], ...],
-) -> str:
-    if not items:
-        return f"<h3>{html.escape(title)}</h3><p class='muted'>No open items.</p>"
-
-    headers = "".join(f"<th>{html.escape(label)}</th>" for _, label in columns)
-    rows = []
-    for item in items:
-        cells = []
-        for key, _ in columns:
-            if key == "number":
-                cells.append(f"<td>#{item.number}</td>")
-            elif key == "title":
-                cells.append(
-                    f"<td>{html.escape(item.title)}{_badge_html(item.badges)}</td>"
-                )
-            else:
-                cells.append(f"<td>{html.escape(item.extra.get(key, ''))}</td>")
-        rows.append("<tr>" + "".join(cells) + "</tr>")
-
-    body = (
-        f"<h3>{html.escape(title)}</h3>"
-        f"<table class='registry'><thead><tr>{headers}</tr></thead>"
-        f"<tbody>{''.join(rows)}</tbody></table>"
-    )
-    return body
-
-
-def render_queue_page(snapshot: QueueSnapshot) -> str:
-    error_block = ""
-    if snapshot.fetch_error:
-        error_block = (
-            f'<div class="stub"><p><strong>Queue unavailable:</strong> '
-            f"{html.escape(snapshot.fetch_error)}</p></div>"
-        )
-        inventory_block = (
-            "<p class='muted'><strong>Inventory:</strong> not fetched "
-            "(fail closed — queue tables omitted).</p>"
-        )
-        return (
-            "<h2>Live queue</h2>"
-            f"<p class='meta'>Repository: <code>{html.escape(snapshot.repo_label)}</code> "
-            f"· project <code>{html.escape(snapshot.project_id)}</code></p>"
-            f"{error_block}"
-            f"{inventory_block}"
-            "<p class='muted'>Read-only MVP — claims, reviews, and merges stay in Gitea/MCP tools.</p>"
-        )
-
-    pr_section = _queue_table(
-        title="Open pull requests",
-        items=snapshot.prs,
-        columns=(
-            ("number", "#"),
-            ("title", "Title"),
-            ("branch", "Branch"),
-            ("head_sha", "Head"),
-            ("mergeable", "Mergeable"),
-            ("linked_issue", "Linked issue"),
-        ),
-    )
-    issue_section = _queue_table(
-        title="Open issues",
-        items=snapshot.issues,
-        columns=(
-            ("number", "#"),
-            ("title", "Title"),
-            ("labels", "Labels"),
-            ("assignee", "Assignee"),
-            ("state", "State"),
-        ),
-    )
-
-    return (
-        "<h2>Live queue</h2>"
-        f"<p class='meta'>Repository: <code>{html.escape(snapshot.repo_label)}</code> "
-        f"· project <code>{html.escape(snapshot.project_id)}</code></p>"
-        f"{_pagination_html('PR', snapshot.pr_pagination)}"
-        f"{pr_section}"
-        f"{_pagination_html('Issue', snapshot.issue_pagination)}"
-        f"{issue_section}"
-        "<p class='muted'>Read-only MVP — claims, reviews, and merges stay in Gitea/MCP tools.</p>"
-    )