feat(review-workflow): enforce single terminal review decision per review run (#211)
This commit is contained in:
@@ -167,6 +167,15 @@ def _good_live_state(**overrides):
|
||||
return assess_live_state_recheck(recheck)
|
||||
|
||||
|
||||
def _good_review_mutation():
|
||||
return {
|
||||
"complete": True,
|
||||
"downgraded": False,
|
||||
"missing_fields": [],
|
||||
"reasons": [],
|
||||
}
|
||||
|
||||
|
||||
def _good_role_boundary_179(**overrides):
|
||||
kwargs = {
|
||||
"task_role": "reviewer",
|
||||
@@ -531,6 +540,7 @@ class TestFinalReport(unittest.TestCase):
|
||||
"sweep": _good_sweep(),
|
||||
"live_state": _good_live_state(),
|
||||
"role_boundary": _good_role_boundary(),
|
||||
"review_mutation": _good_review_mutation(),
|
||||
}
|
||||
kwargs.update(overrides)
|
||||
return build_final_report(**kwargs)
|
||||
@@ -625,6 +635,7 @@ class TestFinalReport(unittest.TestCase):
|
||||
"identity_eligible": True,
|
||||
"merge_performed": False,
|
||||
"issue_status_verified": True,
|
||||
"review_mutation": _good_review_mutation(),
|
||||
}
|
||||
report = build_final_report(**kwargs)
|
||||
self.assertNotEqual(report["grade"], "A")
|
||||
@@ -1131,6 +1142,7 @@ class TestFinalReport179Bar(unittest.TestCase):
|
||||
"sweep": _good_sweep(),
|
||||
"live_state": _good_live_state(),
|
||||
"role_boundary": _good_role_boundary(),
|
||||
"review_mutation": _good_review_mutation(),
|
||||
}
|
||||
kwargs.update(overrides)
|
||||
return build_final_report(**kwargs)
|
||||
@@ -1195,6 +1207,16 @@ class TestFinalReport179Bar(unittest.TestCase):
|
||||
self.assertTrue(report["inventory_complete"])
|
||||
self.assertTrue(report["validated_on_pinned_head"])
|
||||
|
||||
def test_missing_review_mutation_downgrades(self):
|
||||
report = self._report(review_mutation=None)
|
||||
self.assertNotEqual(report["grade"], "A")
|
||||
self.assertFalse(report["review_mutation_complete"])
|
||||
|
||||
def test_incomplete_review_mutation_downgrades(self):
|
||||
report = self._report(review_mutation={"complete": False, "downgraded": True, "reasons": []})
|
||||
self.assertNotEqual(report["grade"], "A")
|
||||
self.assertFalse(report["review_mutation_complete"])
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
|
||||
Reference in New Issue
Block a user