f09791e049
- SKILL.md: new §K Controller Handoff Summary (required every task type) with the exact format and a worked blocked-handoff example; issue-first rule extended (discussion/RFC issues, unclear-tracker-home stop rule, no new repo/tracker without owner approval); merge workflow now names identity+author verification, profile gates, independent validation, and pinned head SHA / expected changed-file merges; tagging rules extended (no tag ops unless instructed, tag only the verified final master merge commit, always report tag target). - llm-workflow-runbooks.md: Controller Handoff Summary section pointing at SKILL §K, incl. discussion/RFC rule (e.g. #100 stays a discussion issue). - templates/start-issue.md + review-pr.md: handoff lines now reference the required summary format and the exact-gate reporting rule. Docs only; no code behavior changed. No tags touched; #100 not modified. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1.7 KiB
1.7 KiB
Template: review a PR
Copy, fill the <...> fields, and paste as the task prompt.
Task: review PR #<pr> for issue #<n>.
Rules (llm-project-workflow):
- Review in a SEPARATE detached review worktree, never the author's folder.
- You must NOT be the PR author. If the authenticated user == PR author, stop.
A different LLM-Agent-SHA does NOT make you a different actor — only a
different authenticated Gitea user does (docs/llm-agent-sha.md).
- Do not merge if any check fails.
Steps:
1. Verify your authenticated identity (whoami) and the active profile.
2. Fetch the PR facts: PR author, head SHA, state (must be open), base branch.
3. If authenticated user == PR author → STOP (no self-review).
4. scripts/worktree-review <pr-head-branch> # detached, branches/review-*
cd branches/review-<pr-head-branch-slug>
5. Confirm the worktree is clean. Inspect the FULL diff; confirm scope matches
issue #<n>; flag any unrelated files, secrets, or formatting churn.
6. Run the test suite; note results.
7. Post the review verdict: approve only if scope is clean and checks pass;
otherwise request changes with specifics. Never merge from this review step.
Include a "Review Metadata" block (attribution only — docs/llm-agent-sha.md):
Review Metadata:
- LLM-Agent-SHA: llm-<12 lowercase hex, e.g. llm-41d0e7aa9f2c>
- LLM-Role: reviewer
- Authenticated-Gitea-User: <whoami result>
- MCP-Profile: <profile name>
- Eligibility: passed/failed
Handoff: reviewer identity, PR author, scope verdict, checks + results, decision —
formatted as the Controller Handoff Summary (SKILL.md §K); if you could not
merge, name the exact gate that blocked it.