sysadmin
6c653ce32a
Add assess_queue_status_report and assess_proof_wording to reject contradictory queue-status-only reports: passed gates without a selected PR, prior diagnostic conflict proof, pagination assumptions, and blocker contradictions. Wire into build_final_report and document the queue-status-only schema path. Closes #339
2.7 KiB
Review-merge controller handoff schema
Task mode: review-merge-pr
End every review/merge run with a section titled exactly Controller Handoff.
Use this canonical field set. Do not omit fields — use none or
not verified in this session where appropriate.
Do not use legacy fields: Pinned reviewed head, Scratch worktree used,
Workspace mutations, Mutations: None (when mutations occurred).
## Controller Handoff
- Task:
- Repo:
- Role:
- Identity:
- Active profile:
- Runtime context:
- Selected PR:
- Linked issue:
- Eligibility class:
- Queue ordering policy:
- Inventory pagination proof:
- Earlier PRs skipped:
- Candidate head SHA:
- Reviewed head SHA:
- Target branch:
- Target branch SHA:
- Already-landed gate:
- Author-safety result:
- Prior request-changes state:
- Review worktree used:
- Review worktree path:
- Review worktree inside branches:
- Review worktree HEAD state:
- Review worktree dirty before validation:
- Review worktree dirty after validation:
- Baseline worktree used:
- Baseline worktree path:
- Files reviewed:
- Validation:
- Official validation integrity status:
- Terminal review mutation:
- Review decision:
- Merge preflight:
- Merge result:
- Linked issue status:
- Main checkout branch:
- Main checkout dirty state:
- Main checkout updated:
- File edits by reviewer:
- Worktree/index mutations:
- Git ref mutations:
- MCP/Gitea mutations:
- Review mutations:
- Merge mutations:
- Cleanup mutations:
- External-state mutations:
- Read-only diagnostics:
- Blockers:
- Current status:
- Safe next action:
- Safety statement:
Already-landed handoff overrides
When eligibility class is ALREADY_LANDED_RECONCILE_REQUIRED:
- Reviewed head SHA:
none - Review worktree used:
false - Review worktree path:
none - Review decision:
none - Merge result:
none
Identity format: username / profile (not personal email unless required — #305).
Queue-status-only runs (no selected PR)
When the run inventories the queue but selects no PR for review:
- Selected PR:
none - Already-landed gate, Author-safety result, Merge preflight:
not applicableornot run— neverpassed - Review worktree detail fields:
not applicableornonewhen Review worktree used isfalse - Blockers must not be
noneif the narrative says all open PRs are conflicted, blocked, or unverified - Inventory pagination proof must cite final-page metadata, not default page-size assumptions
Verifier: review_proofs.assess_queue_status_report().
Narrative final report and controller handoff must agree on eligibility class, candidate/reviewed head SHA, mutation state, worktree usage, review decision, terminal review mutation, merge result, and linked issue status.