sysadminandClaude Opus 4.8
6e774e191a
Add assess_reconcile_inventory_report verifier to block complete queue scan and all-already-landed claims without final-page metadata, requested page size, pages fetched, per-page counts, and no-next-page proof. Wire into build_final_report and export from review_proofs. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
102 lines
3.9 KiB
Python
102 lines
3.9 KiB
Python
"""Tests for reconciliation inventory pagination verifier (#308)."""
|
|
import sys
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
|
|
|
from reviewer_reconcile_inventory import assess_reconcile_inventory_report # noqa: E402
|
|
|
|
|
|
def _good_report() -> str:
|
|
return "\n".join([
|
|
"## Already-landed reconciliation",
|
|
"Open PR inventory:",
|
|
"- Requested page size: 50",
|
|
"- Pages fetched: 2",
|
|
"- Returned PR count per page: page1=50, page2=6",
|
|
"- Inventory pagination proof: is_final_page: true, has_more: false",
|
|
"All already-landed PRs in the scanned open queue were found.",
|
|
"",
|
|
"## Controller Handoff",
|
|
"- Selected PR: #278",
|
|
"- Eligibility class: ALREADY_LANDED_RECONCILE_REQUIRED",
|
|
])
|
|
|
|
|
|
class TestReconcileInventoryPagination(unittest.TestCase):
|
|
def test_complete_metadata_passes(self):
|
|
result = assess_reconcile_inventory_report(_good_report())
|
|
self.assertTrue(result["proven"], result["reasons"])
|
|
self.assertTrue(result["pagination_proven"])
|
|
|
|
def test_no_inventory_claim_skips_checks(self):
|
|
report = "## Controller Handoff\n- Selected PR: #278"
|
|
result = assess_reconcile_inventory_report(report)
|
|
self.assertTrue(result["proven"])
|
|
self.assertFalse(result["inventory_claimed"])
|
|
|
|
def test_first_page_below_limit_with_finality_passes(self):
|
|
report = "\n".join([
|
|
"Open PRs listed for reconciliation.",
|
|
"- Requested page size: 50",
|
|
"- Pages fetched: 1",
|
|
"- Returned PR count per page: page1=6",
|
|
"- Inventory pagination proof: is_final_page: true",
|
|
])
|
|
result = assess_reconcile_inventory_report(report)
|
|
self.assertTrue(result["proven"], result["reasons"])
|
|
|
|
def test_exactly_full_first_page_without_finality_blocks(self):
|
|
report = "\n".join([
|
|
"Complete queue scan of open PRs.",
|
|
"- Requested page size: 50",
|
|
"- Pages fetched: 1",
|
|
"- Returned PR count per page: page1=50",
|
|
"Listed 50 open PRs on the first page.",
|
|
])
|
|
result = assess_reconcile_inventory_report(
|
|
report,
|
|
inventory_session={"requested_page_size": 50, "returned_page_size": 50},
|
|
)
|
|
self.assertFalse(result["proven"])
|
|
self.assertTrue(any("full first" in r.lower() for r in result["reasons"]))
|
|
|
|
def test_missing_pagination_metadata_blocks(self):
|
|
report = "All open PRs were inventoried. Inventory is complete."
|
|
result = assess_reconcile_inventory_report(report)
|
|
self.assertFalse(result["proven"])
|
|
self.assertTrue(any("metadata" in r.lower() for r in result["reasons"]))
|
|
|
|
def test_default_page_size_assumption_blocks(self):
|
|
report = (
|
|
"Exhaustive PR inventory: fewer than the default Gitea page size returned."
|
|
)
|
|
result = assess_reconcile_inventory_report(report)
|
|
self.assertFalse(result["proven"])
|
|
self.assertTrue(any("page-size" in r.lower() or "page size" in r.lower()
|
|
for r in result["reasons"]))
|
|
|
|
def test_session_pagination_complete_passes(self):
|
|
report = "All already-landed PRs were found after scanning open PRs."
|
|
result = assess_reconcile_inventory_report(
|
|
report,
|
|
inventory_session={
|
|
"pagination_complete": True,
|
|
"requested_page_size": 50,
|
|
"pages_fetched": 2,
|
|
"returned_per_page": [50, 3],
|
|
},
|
|
)
|
|
self.assertTrue(result["proven"], result["reasons"])
|
|
|
|
|
|
class TestExport(unittest.TestCase):
|
|
def test_review_proofs_reexport(self):
|
|
from review_proofs import assess_reconcile_inventory_report as exported
|
|
|
|
self.assertTrue(callable(exported))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main() |