test(#628 child): unit regression coverage for CTH, ownership classify_skip, and dependency edges #878

Closed
opened 2026-07-24 06:34:46 -05:00 by jcwalker3 · 0 comments
Owner

Parent

Child of umbrella #628. Does not close the umbrella.

Problem

PR #795 originally claimed to close #628 with a single new unit/integration test file. Review correctly REQUEST_CHANGES: one test module exercising existing APIs is not end-to-end umbrella delivery.

Scope (this issue only)

Add honest regression coverage for pre-existing building blocks used by #628 orchestration:

  1. CTH serialization / parse / assess (format_cth_body, parse_cth_comment, assess_cth_comment)
  2. Exclusive-ownership skip classification (classify_skip with OWNERSHIP_FOREIGN vs OWNERSHIP_OWN)
  3. Dependency graph edge create + blocking candidate filtering
  4. Edge state transition UNMET -> MET

Non-goals

  • Do not implement automatic handoff store/retrieve end-to-end
  • Do not implement multi-worker lease coordination product surface
  • Do not close umbrella #628 or claim all 21 acceptance criteria
  • No production wiring beyond tests of existing modules

Acceptance criteria

  1. tests/test_issue_628_orchestration.py exists with accurate module/doc scope (no claim of all 21 ACs).
  2. Tests cover the four building-block behaviors listed above.
  3. PR body references this child issue (Closes this issue), Related: #628 only.
  4. Umbrella #628 remains open after merge.

Related

## Parent Child of umbrella #628. Does **not** close the umbrella. ## Problem PR #795 originally claimed to close #628 with a single new unit/integration test file. Review correctly REQUEST_CHANGES: one test module exercising existing APIs is not end-to-end umbrella delivery. ## Scope (this issue only) Add honest regression coverage for **pre-existing** building blocks used by #628 orchestration: 1. CTH serialization / parse / assess (`format_cth_body`, `parse_cth_comment`, `assess_cth_comment`) 2. Exclusive-ownership skip classification (`classify_skip` with `OWNERSHIP_FOREIGN` vs `OWNERSHIP_OWN`) 3. Dependency graph edge create + blocking candidate filtering 4. Edge state transition UNMET -> MET ## Non-goals * Do not implement automatic handoff store/retrieve end-to-end * Do not implement multi-worker lease coordination product surface * Do not close umbrella #628 or claim all 21 acceptance criteria * No production wiring beyond tests of existing modules ## Acceptance criteria 1. `tests/test_issue_628_orchestration.py` exists with accurate module/doc scope (no claim of all 21 ACs). 2. Tests cover the four building-block behaviors listed above. 3. PR body references this child issue (Closes this issue), Related: #628 only. 4. Umbrella #628 remains open after merge. ## Related * Parent: #628 * Remediation PR: #795
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#878