feat: add reviewer final-report schema MCP validator (Closes #391) #394

2026-07-07T09:04:36-05:00

jcwalker3 commented

2026-07-07 09:04:36 -05:00

Summary

Closes #391.

Reviewer final reports must be machine-validated before a session completes. This PR adds gitea_validate_review_final_report, composing the existing composable final-report validator (#327) with review-specific schema gates.

Changes

review_final_report_schema.py — assess_review_final_report_schema() with rules for:
- legacy/stale handoff fields (Pinned reviewed head, Scratch worktree used, Workspace mutations)
- reviewed head SHA without validation pass proof
- merged claims without merge result + ancestry proof
- issue-closed claims without live fetch proof
- full-suite pass with ignored/skipped tests undisclosed
- blocked handoffs with approve/merge replay commands
- narrative vs controller handoff drift
- PENDING vs APPROVED / dry-run vs submitted ambiguity
gitea_mcp_server.py — new read-only MCP tool gitea_validate_review_final_report
review_proofs.py — export wrapper
Tests: tests/test_review_final_report_schema.py (11 cases) + workflow split export test

Validation

Working directory: branches/issue-391-review-final-report-schema

venv/bin/python -m pytest tests/test_review_final_report_schema.py tests/test_llm_workflow_split.py::test_review_final_report_schema_verifier_exported -q

Result: 12 passed (targeted)

Worktree

Path: branches/issue-391-review-final-report-schema
Branch: feat/issue-391-review-final-report-schema
Commit: a164700

## Summary Closes #391. Reviewer final reports must be machine-validated before a session completes. This PR adds `gitea_validate_review_final_report`, composing the existing composable final-report validator (#327) with review-specific schema gates. ## Changes - `review_final_report_schema.py` — `assess_review_final_report_schema()` with rules for: - legacy/stale handoff fields (`Pinned reviewed head`, `Scratch worktree used`, `Workspace mutations`) - reviewed head SHA without validation pass proof - merged claims without merge result + ancestry proof - issue-closed claims without live fetch proof - full-suite pass with ignored/skipped tests undisclosed - blocked handoffs with approve/merge replay commands - narrative vs controller handoff drift - PENDING vs APPROVED / dry-run vs submitted ambiguity - `gitea_mcp_server.py` — new read-only MCP tool `gitea_validate_review_final_report` - `review_proofs.py` — export wrapper - Tests: `tests/test_review_final_report_schema.py` (11 cases) + workflow split export test ## Validation Working directory: `branches/issue-391-review-final-report-schema` ``` venv/bin/python -m pytest tests/test_review_final_report_schema.py tests/test_llm_workflow_split.py::test_review_final_report_schema_verifier_exported -q ``` Result: **12 passed** (targeted) ## Worktree - Path: `branches/issue-391-review-final-report-schema` - Branch: `feat/issue-391-review-final-report-schema` - Commit: `a164700`

jcwalker3 added 1 commit 2026-07-07 09:04:37 -05:00

feat: add reviewer final-report schema MCP validator (Closes #391 ) a164700ab9

Expose gitea_validate_review_final_report composing the composable
final-report validator with review-specific schema gates for legacy
fields, merge/issue claims, blocked handoff replay, and narrative drift.

jcwalker3 referenced this pull request

2026-07-07 09:41:10 -05:00

Workflow-load gate must establish reviewer session mode boundaries and classify pre-review commands #403

sysadmin approved these changes 2026-07-07 10:15:32 -05:00

sysadmin left a comment

Manual review of changed files and test suite validation passed. The new review-specific final-report schema validator correctly validates reviewer reports, resolving issue #391. The unit test failure on the branch head is pre-existing and resolved when merged with master. All tests pass cleanly on the merged code. Approved.

sysadmin merged commit fcb9944378 into master

2026-07-07 10:15:42 -05:00

jcwalker3 referenced this pull request

2026-07-07 10:22:34 -05:00

gitea_delete_branch must enforce exact gitea.branch.delete capability at tool entry #408

jcwalker3 referenced this pull request

2026-07-07 10:30:36 -05:00

Add precise validation-status vocabulary for raw PR-head failures resolved by merge simulation #406

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#394