Enforce already-landed review report state gates #383

Merged
sysadmin merged 1 commits from feat/issue-294-already-landed-review-gate into master 2026-07-07 09:15:20 -05:00
Owner

Closes #294

Summary

  • Add final-report validation that blocks APPROVED, MERGED, and READY_TO_MERGE outcomes when the already-landed gate has fired.
  • Require target-branch up-to-date claims to include both fetch proof and the exact target branch SHA.
  • Refresh the final-report validator test fixture to match the current mutation-category handoff schema and add targeted regression coverage.

Validation

  • /opt/homebrew/bin/pytest tests/test_final_report_validator.py tests/test_queue_status_report.py -q (25 passed, 3 subtests passed)
Closes #294 ## Summary - Add final-report validation that blocks APPROVED, MERGED, and READY_TO_MERGE outcomes when the already-landed gate has fired. - Require target-branch up-to-date claims to include both fetch proof and the exact target branch SHA. - Refresh the final-report validator test fixture to match the current mutation-category handoff schema and add targeted regression coverage. ## Validation - `/opt/homebrew/bin/pytest tests/test_final_report_validator.py tests/test_queue_status_report.py -q` (25 passed, 3 subtests passed)
jcwalker3 added 1 commit 2026-07-07 08:25:06 -05:00
sysadmin approved these changes 2026-07-07 09:15:07 -05:00
sysadmin left a comment
Owner

All tests pass successfully after merging master (1293 passed). Reviewed the implementation of final_report_validator.py and the test coverage in tests/test_final_report_validator.py. It correctly adds _rule_reviewer_already_landed_state and _rule_reviewer_target_branch_freshness to enforce already-landed review report states, preventing positive review/merge claims when the already-landed gate fires and validating freshness of target branch up-to-date claims.

All tests pass successfully after merging master (1293 passed). Reviewed the implementation of `final_report_validator.py` and the test coverage in `tests/test_final_report_validator.py`. It correctly adds `_rule_reviewer_already_landed_state` and `_rule_reviewer_target_branch_freshness` to enforce already-landed review report states, preventing positive review/merge claims when the already-landed gate fires and validating freshness of target branch up-to-date claims.
sysadmin merged commit bb525a8f94 into master 2026-07-07 09:15:20 -05:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#383