feat: add create-issue final-report verifier (Closes #337) #341

2026-07-07T03:24:03-05:00

jcwalker3 commented

2026-07-07 03:24:03 -05:00

Summary

Completes the remaining acceptance criteria for #337 after the workflow files landed via #333/#336.

Adds assess_create_issue_final_report and supporting checks in review_proofs.py:

Requires workflows/create-issue.md workflow-source proof and create-issue task mode
Enforces create-issue controller handoff schema fields
Rejects work-issue and review-merge cross-mode handoff fields
Rejects legacy Workspace mutations without precise mutation categories

Tests

TestCreateIssueFinalReport in tests/test_review_proofs.py (5 cases)
test_create_issue_final_report_verifier_exported in tests/test_llm_workflow_split.py
pytest tests/test_review_proofs.py tests/test_llm_workflow_split.py → 164 passed

Closes #337

## Summary Completes the remaining acceptance criteria for #337 after the workflow files landed via #333/#336. Adds `assess_create_issue_final_report` and supporting checks in `review_proofs.py`: - Requires `workflows/create-issue.md` workflow-source proof and `create-issue` task mode - Enforces create-issue controller handoff schema fields - Rejects work-issue and review-merge cross-mode handoff fields - Rejects legacy `Workspace mutations` without precise mutation categories ## Tests - `TestCreateIssueFinalReport` in `tests/test_review_proofs.py` (5 cases) - `test_create_issue_final_report_verifier_exported` in `tests/test_llm_workflow_split.py` - `pytest tests/test_review_proofs.py tests/test_llm_workflow_split.py` → 164 passed Closes #337

jcwalker3 added 1 commit 2026-07-07 03:24:03 -05:00

feat: add create-issue final-report verifier (#337 ) 14f5c865b3

Extend review_proofs with assess_create_issue_final_report to enforce
workflow-source proof, create-issue handoff schema fields, and rejection
of work-issue/review-merge cross-mode handoff fields.

Closes #337

jcwalker3 commented

2026-07-07 03:44:16 -05:00

Ready for review

Pushed head after merging latest master (fd6f7ff).

Scope (#337)

Adds assess_create_issue_final_report and supporting checks in review_proofs.py:

Requires workflows/create-issue.md workflow-source proof and create-issue task mode
Enforces create-issue controller handoff schema fields
Rejects work-issue / review-merge cross-mode handoff fields
Rejects legacy Workspace mutations without precise mutation categories

Validation (worktree `branches/feat-issue-337-create-issue-verifier`)

pytest tests/test_review_proofs.py tests/test_llm_workflow_split.py -q

164 passed (includes TestCreateIssueFinalReport + test_create_issue_final_report_verifier_exported)

Merge note

Clean merge of master @ fd6f7ff (#286, #282, #284, etc.) — no conflict resolution required.

No prior review verdicts on this PR.

## Ready for review Pushed head after merging latest `master` (`fd6f7ff`). ### Scope (#337) Adds `assess_create_issue_final_report` and supporting checks in `review_proofs.py`: - Requires `workflows/create-issue.md` workflow-source proof and `create-issue` task mode - Enforces create-issue controller handoff schema fields - Rejects work-issue / review-merge cross-mode handoff fields - Rejects legacy `Workspace mutations` without precise mutation categories ### Validation (worktree `branches/feat-issue-337-create-issue-verifier`) ``` pytest tests/test_review_proofs.py tests/test_llm_workflow_split.py -q ``` **164 passed** (includes `TestCreateIssueFinalReport` + `test_create_issue_final_report_verifier_exported`) ### Merge note Clean merge of `master` @ `fd6f7ff` (#286, #282, #284, etc.) — no conflict resolution required. No prior review verdicts on this PR.

jcwalker3 added 1 commit 2026-07-07 03:44:19 -05:00

Merge remote-tracking branch 'prgs/master' into feat/issue-337-create-issue-verifier 6e024db9eb

sysadmin approved these changes 2026-07-07 03:58:44 -05:00

sysadmin left a comment

All tests pass successfully. Reviewed the implementation of the create-issue final-report verifier in review_proofs.py. It properly implements verification for create-issue task mode, verifying workflow source, mode isolation, precise mutation categories, and duplicate summaries, with thorough test coverage in tests/test_review_proofs.py. Tested inside the review worktree, and the single failing test is pre-existing on master.

sysadmin merged commit 0ae39c231d into master

2026-07-07 03:59:01 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#341