Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Reviewer controller handoffs must remove legacy Workspace mutations field #320

New Issue
Closed
opened 2026-07-07 01:30:07 -05:00 by jcwalker3 · 1 comment
jcwalker3 commented 2026-07-07 01:30:07 -05:00
Owner
Copy Link
Copy Source

Reviewer reports now include precise mutation categories, but controller handoffs still include legacy wording such as:

Workspace mutations: none (no local file changes outside temporary worktree)

Problem

This field is ambiguous and conflicts with precise mutation categories when the workflow creates/removes worktrees, fetches refs, submits reviews, or merges PRs.

Required behavior

Remove Workspace mutations from reviewer controller handoffs and replace it with:

  • File edits by reviewer:
  • Worktree/index mutations:
  • Git ref mutations:
  • MCP/Gitea mutations:
  • Review mutations:
  • Merge mutations:
  • Cleanup mutations:
  • External-state mutations:
  • Read-only diagnostics:

Acceptance criteria

  • Reviewer handoffs do not include Workspace mutations.
  • Final-report validator rejects Workspace mutations: none.
  • Reports distinguish no file edits from worktree/index mutations.
  • Tests cover request-changes, approval, merge, worktree cleanup, fetch-only, and blocked handoffs.
Reviewer reports now include precise mutation categories, but controller handoffs still include legacy wording such as: `Workspace mutations: none (no local file changes outside temporary worktree)` ## Problem This field is ambiguous and conflicts with precise mutation categories when the workflow creates/removes worktrees, fetches refs, submits reviews, or merges PRs. ## Required behavior Remove `Workspace mutations` from reviewer controller handoffs and replace it with: - File edits by reviewer: - Worktree/index mutations: - Git ref mutations: - MCP/Gitea mutations: - Review mutations: - Merge mutations: - Cleanup mutations: - External-state mutations: - Read-only diagnostics: ## Acceptance criteria - [ ] Reviewer handoffs do not include `Workspace mutations`. - [ ] Final-report validator rejects `Workspace mutations: none`. - [ ] Reports distinguish no file edits from worktree/index mutations. - [ ] Tests cover request-changes, approval, merge, worktree cleanup, fetch-only, and blocked handoffs.
jcwalker3 added the status:in-progress label 2026-07-07 04:04:17 -05:00
jcwalker3 commented 2026-07-07 04:15:08 -05:00
Author
Owner
Copy Link
Copy Source

Implementation PR opened: #357 (branch feat/issue-320-remove-workspace-mutations, head c2bba27).

assess_controller_handoff(role="review") now rejects any legacy Workspace mutations: line fail-closed and requires the nine precise mutation categories from schemas/review-merge-final-report.md. Tests cover approval, request-changes, merge, worktree-cleanup, fetch-only, and blocked handoffs. Awaiting reviewer.

Implementation PR opened: #357 (branch `feat/issue-320-remove-workspace-mutations`, head c2bba27). `assess_controller_handoff(role="review")` now rejects any legacy `Workspace mutations:` line fail-closed and requires the nine precise mutation categories from `schemas/review-merge-final-report.md`. Tests cover approval, request-changes, merge, worktree-cleanup, fetch-only, and blocked handoffs. Awaiting reviewer.
sysadmin removed the status:in-progress label 2026-07-07 04:33:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#320