Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Sibling-worktree skip test fails outside branches/ worktree layout (location-dependent) #283

New Issue
Closed
opened 2026-07-06 23:17:15 -05:00 by jcwalker3 · 0 comments
jcwalker3 commented 2026-07-06 23:17:15 -05:00
Owner
Copy Link
Copy Source

Problem

tests/test_role_session_router.py::TestCheckMidMerge::test_skip_scan_walk_root_skips_sibling_worktrees_only fails on a clean master checkout:

AssertionError: False is not true

Root cause

The test derives its fixture paths from its own file location:

worktree_root = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
main_root = os.path.dirname(os.path.dirname(worktree_root))

and then asserts skip_python_scan_walk_root(main_root, main_root/branches/fix-issue-1) is True. But skip_python_scan_walk_root only skips a branches/ walk root when <project_root>/branches exists on disk (os.path.isdir(nested)).

So the assertion holds only when the repo checkout itself sits at <main>/branches/<slug> (the branch-worktree layout, where main_root resolves to the orchestration checkout that really has a branches/ dir). Run the suite from the main checkout or any plain clone and main_root resolves two directories above the repo, branches/ does not exist there, and the test fails.

Reproduced on clean master (d6f4f93) in a plain clone; also fails from the primary checkout.

Fix

Make the test hermetic: build the <main>/branches/<worktree> layout in a tempfile.TemporaryDirectory() and assert against those paths instead of deriving from __file__. Preserves all four behavioural assertions (orchestration root scanned, sibling worktrees skipped, worktree-as-project-root scanned including subdirs).

Acceptance

  • Test passes from a plain clone, the main checkout, and a branches/ worktree alike.
  • All four original assertions preserved.
  • No production code change to skip_python_scan_walk_root.
## Problem `tests/test_role_session_router.py::TestCheckMidMerge::test_skip_scan_walk_root_skips_sibling_worktrees_only` fails on a clean `master` checkout: ```text AssertionError: False is not true ``` ## Root cause The test derives its fixture paths from its own file location: ```python worktree_root = os.path.dirname(os.path.dirname(os.path.abspath(__file__))) main_root = os.path.dirname(os.path.dirname(worktree_root)) ``` and then asserts `skip_python_scan_walk_root(main_root, main_root/branches/fix-issue-1)` is `True`. But `skip_python_scan_walk_root` only skips a `branches/` walk root when `<project_root>/branches` **exists on disk** (`os.path.isdir(nested)`). So the assertion holds only when the repo checkout itself sits at `<main>/branches/<slug>` (the branch-worktree layout, where `main_root` resolves to the orchestration checkout that really has a `branches/` dir). Run the suite from the main checkout or any plain clone and `main_root` resolves two directories above the repo, `branches/` does not exist there, and the test fails. Reproduced on clean `master` (d6f4f93) in a plain clone; also fails from the primary checkout. ## Fix Make the test hermetic: build the `<main>/branches/<worktree>` layout in a `tempfile.TemporaryDirectory()` and assert against those paths instead of deriving from `__file__`. Preserves all four behavioural assertions (orchestration root scanned, sibling worktrees skipped, worktree-as-project-root scanned including subdirs). ## Acceptance - Test passes from a plain clone, the main checkout, and a `branches/` worktree alike. - All four original assertions preserved. - No production code change to `skip_python_scan_walk_root`.
jcwalker3 added the status:in-progress label 2026-07-06 23:17:31 -05:00
sysadmin removed the status:in-progress label 2026-07-07 02:08:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#283