Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Block workspace edits before identity, capability, and role verification #210

New Issue
Closed
opened 2026-07-05 15:29:52 -05:00 by sysadmin · 1 comment
sysadmin commented 2026-07-05 15:29:52 -05:00
Owner
Copy Link
Copy Source

Problem:
Agents can edit repository files before proving authenticated identity, active profile, and allowed task capability. This violates the required pre-flight ordering and can allow reviewer sessions to drift into author-side work.

Required wall:
No repository file edits, test modifications, branch operations, commits, pushes, PR creation, issue creation, reviews, or merges may occur before identity and capability are verified for the requested task.

Required behavior:
Before any workspace mutation, the workflow must prove:

  • authenticated username;
  • active profile;
  • task type;
  • allowed/forbidden operations;
  • role compatibility;
  • repo/queue target;
  • clean worktree state.

If the active role is reviewer, local file edits must be blocked entirely unless the operator explicitly changes the task to author implementation.

Acceptance criteria:

  • Add a test where a file edit occurs before gitea_whoami; expected result: blocked.
  • Add a test where a file edit occurs before gitea_resolve_task_capability; expected result: blocked.
  • Add a test where a reviewer profile edits tracked files; expected result: blocked.
  • Add a test where the final report says “no mutations” after local file edits; expected result: invalid report.
  • Add a required report field: workspace_mutations.
  • Mutation confirmation must distinguish Gitea mutations from local workspace mutations.
Problem: Agents can edit repository files before proving authenticated identity, active profile, and allowed task capability. This violates the required pre-flight ordering and can allow reviewer sessions to drift into author-side work. Required wall: No repository file edits, test modifications, branch operations, commits, pushes, PR creation, issue creation, reviews, or merges may occur before identity and capability are verified for the requested task. Required behavior: Before any workspace mutation, the workflow must prove: * authenticated username; * active profile; * task type; * allowed/forbidden operations; * role compatibility; * repo/queue target; * clean worktree state. If the active role is reviewer, local file edits must be blocked entirely unless the operator explicitly changes the task to author implementation. Acceptance criteria: - Add a test where a file edit occurs before gitea_whoami; expected result: blocked. - Add a test where a file edit occurs before gitea_resolve_task_capability; expected result: blocked. - Add a test where a reviewer profile edits tracked files; expected result: blocked. - Add a test where the final report says “no mutations” after local file edits; expected result: invalid report. - Add a required report field: workspace_mutations. - Mutation confirmation must distinguish Gitea mutations from local workspace mutations.
jcwalker3 commented 2026-07-05 16:34:28 -05:00
Owner
Copy Link
Copy Source

Additional acceptance evidence: prior run incorrectly claimed “zero mutations” after deleting a local worktree and local branch during a read-only task. Correct rule: read-only tasks must not perform local housekeeping unless explicitly requested. Final reports must split mutation ledger into Gitea mutations, local workspace mutations, and memory/index writes. The phrase “no mutations” is forbidden if any worktree, branch, file, memory, or index state changed.

Additional acceptance evidence: prior run incorrectly claimed “zero mutations” after deleting a local worktree and local branch during a read-only task. Correct rule: read-only tasks must not perform local housekeeping unless explicitly requested. Final reports must split mutation ledger into Gitea mutations, local workspace mutations, and memory/index writes. The phrase “no mutations” is forbidden if any worktree, branch, file, memory, or index state changed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#210