Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
29ad93d145 |
@@ -47,18 +47,33 @@ Do the steps in order. Stop as soon as a live **client-namespace** call succeeds
|
|||||||
- Only the Gitea namespace fails → single-namespace transport close. Continue.
|
- Only the Gitea namespace fails → single-namespace transport close. Continue.
|
||||||
- Every server fails → restart the whole MCP client, not just one namespace.
|
- Every server fails → restart the whole MCP client, not just one namespace.
|
||||||
|
|
||||||
2. **Reconnect the namespace through the client, not the shell.** Use the IDE /
|
2. **Request the sanctioned reconnect surface (#678), then reconnect through
|
||||||
client MCP-reconnect action for that server entry (in Claude Code:
|
the client — not the shell.** From a still-reachable Gitea MCP namespace
|
||||||
`/mcp` → reconnect the affected `gitea-*` server). Reconnecting forces the
|
(or after host auto-reconnect), call:
|
||||||
client to spawn a fresh subprocess and re-open the pipe. This clears the
|
|
||||||
closed-client state that a bare `kill`/respawn from a terminal does **not**.
|
```text
|
||||||
|
gitea_request_mcp_reconnect(
|
||||||
|
namespace="gitea-author", # or gitea-reviewer / gitea-merger / …
|
||||||
|
reason="transport_eof",
|
||||||
|
client="codex", # or claude_code / generic
|
||||||
|
)
|
||||||
|
```
|
||||||
|
|
||||||
|
The tool is **report-only**: it never restarts a process. It returns
|
||||||
|
namespace, profile, pid/session, startup SHA, current master SHA, boundary
|
||||||
|
status, and a **typed blocker** with exact operator UI steps for Codex
|
||||||
|
(Reload Developer Tools / per-server reconnect) or Claude Code (`/mcp`).
|
||||||
|
Then perform the host reconnect those steps describe so the client spawns a
|
||||||
|
fresh subprocess and re-opens the pipe. That clears the closed-client state
|
||||||
|
that a bare `kill`/respawn from a terminal does **not**.
|
||||||
|
|
||||||
3. **Do not "fix" it by importing the server or poking the process.** Reaching
|
3. **Do not "fix" it by importing the server or poking the process.** Reaching
|
||||||
for `python -c 'import gitea_mcp_server ...'`, raw JSON-RPC from a shell,
|
for `python -c 'import gitea_mcp_server ...'`, raw JSON-RPC from a shell,
|
||||||
killing PIDs to force a respawn, or touching MCP config mtimes does **not**
|
killing PIDs to force a respawn, or touching MCP config mtimes does **not**
|
||||||
restore the *client's* view of the namespace and violates the daemon-import
|
restore the *client's* view of the namespace and violates the daemon-import
|
||||||
guard (#558, `docs/mcp-daemon-import-guard.md`). The only sanctioned repair
|
guard (#558, `docs/mcp-daemon-import-guard.md`). The only sanctioned repair
|
||||||
is a **client reconnect / relaunch**.
|
is a **client reconnect / relaunch** (or the typed operator path returned by
|
||||||
|
`gitea_request_mcp_reconnect`).
|
||||||
|
|
||||||
4. **Verify through the same path the workflow will use.** After reconnect, call
|
4. **Verify through the same path the workflow will use.** After reconnect, call
|
||||||
the specific tool the blocked workflow needs — not just any tool — through
|
the specific tool the blocked workflow needs — not just any tool — through
|
||||||
@@ -153,19 +168,7 @@ not a tool argument: a session must never be able to authorize itself.
|
|||||||
## Related
|
## Related
|
||||||
|
|
||||||
- #630 — manual daemon killing as contaminated recovery (this contrast, enforced).
|
- #630 — manual daemon killing as contaminated recovery (this contrast, enforced).
|
||||||
- #657 — restart-path inventory and daemon classification.
|
|
||||||
- #686 — manual server launch detection & fail-closed provenance gate.
|
|
||||||
- #531 / #544 — stale-runtime detection (`ps`-based); sibling failure mode.
|
- #531 / #544 — stale-runtime detection (`ps`-based); sibling failure mode.
|
||||||
- #558 / `docs/mcp-daemon-import-guard.md` — why shell imports are not a repair.
|
- #558 / `docs/mcp-daemon-import-guard.md` — why shell imports are not a repair.
|
||||||
- `docs/mcp-client-registration.md` — per-server registration contract.
|
- `docs/mcp-client-registration.md` — per-server registration contract.
|
||||||
- `docs/mcp-namespace-health.md` — probe sources and mutation enforcement.
|
- `docs/mcp-namespace-health.md` — probe sources and mutation enforcement.
|
||||||
|
|
||||||
## Sanctioned reconnect vs forbidden manual launch (#686)
|
|
||||||
|
|
||||||
In addition to manual process killing (#630), manually launching a duplicate role server from an ad hoc shell (`python3 mcp_server.py`) is forbidden and fail-closed:
|
|
||||||
|
|
||||||
- **Why manual launches are unsupported:** A terminal-launched `mcp_server.py` holds its own stdio transport; it can never bind to the IDE client's stdio pipes. It cannot restore a dropped IDE namespace, and a manual duplicate process masks stale client-managed runtimes for that profile, defeating stale-runtime gates.
|
|
||||||
- **Sanctioned path:** Supported recovery is IDE/client-managed reconnect only (`/mcp reconnect`, IDE restart, or sanctioned reconnect exposure).
|
|
||||||
- **Fail-closed enforcement (#686):** Mutating tools on a server lacking client-managed launch provenance (`GITEA_CLIENT_MANAGED=1`) refuse execution fail-closed with typed blocker `unsupported_manual_launch` and an exact next action. Unsupported `GITEA_*` env overrides (e.g. `GITEA_DUMMY`) are surfaced in diagnostics rather than silently ignored.
|
|
||||||
- **Inventory & staleness:** Staleness diagnostics ignore non-client-managed duplicates when evaluating runtime freshness and inventory duplicate processes per profile (#657, #686).
|
|
||||||
|
|
||||||
|
|||||||
@@ -45,10 +45,11 @@ and *fails closed*.
|
|||||||
| `legacy_auto_restart_helper` | removed | A helper (`_trigger_mcp_auto_restart`) that actively restarted the server from the read-only resolver path. | Removed in #685; kept absent by `assert_auto_restart_helper_absent()`. | #685, #657 |
|
| `legacy_auto_restart_helper` | removed | A helper (`_trigger_mcp_auto_restart`) that actively restarted the server from the read-only resolver path. | Removed in #685; kept absent by `assert_auto_restart_helper_absent()`. | #685, #657 |
|
||||||
| `config_touch_reload` | removed | Touching (utime) the MCP client config to make the host reload the server. | Removed from the resolver in #685: stale detection is report-only, never mutating config, spawning threads, or calling `os._exit`. | #685, #657 |
|
| `config_touch_reload` | removed | Touching (utime) the MCP client config to make the host reload the server. | Removed from the resolver in #685: stale detection is report-only, never mutating config, spawning threads, or calling `os._exit`. | #685, #657 |
|
||||||
| `master_advance_auto_restart` | guarded_fail_closed | On-disk master advancing past the running code. | `master_parity_gate` captures startup parity and blocks mutations while stale, emitting restart guidance; the process never self-restarts. | #420, #591, #657 |
|
| `master_advance_auto_restart` | guarded_fail_closed | On-disk master advancing past the running code. | `master_parity_gate` captures startup parity and blocks mutations while stale, emitting restart guidance; the process never self-restarts. | #420, #591, #657 |
|
||||||
| `stale_runtime_resolver_reconnect` | guarded_fail_closed | The capability resolver detecting a stale serving process. | Report-only (#685): returns `restart_required`/`stop_required` and an exact reconnect action; no restart, thread, config touch, or `os._exit`. | #685, #657 |
|
| `stale_runtime_resolver_reconnect` | guarded_fail_closed | The capability resolver detecting a stale serving process. | Report-only (#685): returns `restart_required`/`stop_required` and an exact reconnect action; no restart, thread, config touch, or `os._exit`. | #685, #657, #678 |
|
||||||
|
| `codex_client_reconnect_request` | guarded_fail_closed | `gitea_request_mcp_reconnect` report-only tool for Codex/LLM sessions. | Report-only (#678): returns namespace/profile/pid/startup SHA/master SHA/boundary status and a typed operator blocker with exact client UI steps; never restarts or kills. | #678, #630, #685, #657 |
|
||||||
| `manual_daemon_kill` | forbidden | Shell kills of the daemon: `pkill -f mcp_server.py`, `killall`, broad `pkill -f python` sweeps, or `kill <pid>` of a daemon pid. | Forbidden (#630): `runtime_recovery_guard` classifies these as contamination and `gitea_record_daemon_process_kill_attempt` writes a durable marker that fails later mutations closed. Operator maintenance authorization is read only from the environment. | #630, #657 |
|
| `manual_daemon_kill` | forbidden | Shell kills of the daemon: `pkill -f mcp_server.py`, `killall`, broad `pkill -f python` sweeps, or `kill <pid>` of a daemon pid. | Forbidden (#630): `runtime_recovery_guard` classifies these as contamination and `gitea_record_daemon_process_kill_attempt` writes a durable marker that fails later mutations closed. Operator maintenance authorization is read only from the environment. | #630, #657 |
|
||||||
| `conflict_marker_infra_stop` | guarded_fail_closed | The daemon entrypoint scans for unresolved merge-conflict markers at startup and stops (`sys.exit(1)`). | Fail-closed startup stop, not a restart: the process exits and waits for the operator to resolve conflicts and relaunch; never loops. | #657 |
|
| `conflict_marker_infra_stop` | guarded_fail_closed | The daemon entrypoint scans for unresolved merge-conflict markers at startup and stops (`sys.exit(1)`). | Fail-closed startup stop, not a restart: the process exits and waits for the operator to resolve conflicts and relaunch; never loops. | #657 |
|
||||||
| `ide_client_reconnect` | host_residual | A manual `/mcp reconnect` (or equivalent host action) that recreates the MCP client connection. | Outside this process's control; the sanctioned recovery the gates point operators toward. No in-process code initiates it. | #584, #656, #657 |
|
| `ide_client_reconnect` | host_residual | A manual `/mcp reconnect` (or equivalent host action) that recreates the MCP client connection. Agents obtain exact UI steps via `gitea_request_mcp_reconnect` (#678). | Outside this process's control; the sanctioned recovery the gates point operators toward. No in-process code initiates it. | #584, #656, #657, #678 |
|
||||||
| `profile_switch_runtime` | sanctioned_narrow_recovery | Switching the active execution profile at runtime (dynamic-profile mode). | In-process and restart-free: `runtime_switching_supported` is true, so a switch rebinds capability without recreating the process. | #656, #657 |
|
| `profile_switch_runtime` | sanctioned_narrow_recovery | Switching the active execution profile at runtime (dynamic-profile mode). | In-process and restart-free: `runtime_switching_supported` is true, so a switch rebinds capability without recreating the process. | #656, #657 |
|
||||||
|
|
||||||
## Guards enforced in CI
|
## Guards enforced in CI
|
||||||
|
|||||||
@@ -137,6 +137,7 @@ that gates each call, not which tools exist.
|
|||||||
- `gitea_release_merger_pr_lease`
|
- `gitea_release_merger_pr_lease`
|
||||||
- `gitea_release_reviewer_pr_lease`
|
- `gitea_release_reviewer_pr_lease`
|
||||||
- `gitea_release_workflow_lease`
|
- `gitea_release_workflow_lease`
|
||||||
|
- `gitea_request_mcp_reconnect`
|
||||||
- `gitea_request_mcp_restart`
|
- `gitea_request_mcp_restart`
|
||||||
- `gitea_resolve_task_capability`
|
- `gitea_resolve_task_capability`
|
||||||
- `gitea_resume_review_draft`
|
- `gitea_resume_review_draft`
|
||||||
|
|||||||
+1
-50
@@ -1169,57 +1169,10 @@ def server_command():
|
|||||||
return python, [os.path.join(root, "mcp_server.py")]
|
return python, [os.path.join(root, "mcp_server.py")]
|
||||||
|
|
||||||
|
|
||||||
RECOGNIZED_GITEA_ENV_KEYS = frozenset({
|
|
||||||
"GITEA_MCP_CONFIG",
|
|
||||||
"GITEA_MCP_PROFILE",
|
|
||||||
"GITEA_PROFILE_NAME",
|
|
||||||
"GITEA_SERVICE",
|
|
||||||
"GITEA_EXECUTION_ROLE",
|
|
||||||
"GITEA_CLIENT_MANAGED",
|
|
||||||
"GITEA_MCP_CLIENT_MANAGED",
|
|
||||||
"GITEA_SERVER_PROVENANCE",
|
|
||||||
"GITEA_AUTHOR_WORKTREE",
|
|
||||||
"GITEA_ACTIVE_WORKTREE",
|
|
||||||
"GITEA_DISABLE_KEYCHAIN",
|
|
||||||
"GITEA_CONTROL_PLANE_DB",
|
|
||||||
"GITEA_DB_PATH",
|
|
||||||
"GITEA_LOG_LEVEL",
|
|
||||||
"GITEA_DEBUG",
|
|
||||||
"GITEA_HMAC_SECRET",
|
|
||||||
"GITEA_IRRECOVERABLE_HMAC_SECRET",
|
|
||||||
"GITEA_FORCE_MCP_RUNTIME_CHECK",
|
|
||||||
"GITEA_FORCE_CLIENT_MANAGED",
|
|
||||||
})
|
|
||||||
|
|
||||||
RECOGNIZED_GITEA_ENV_PREFIXES = (
|
|
||||||
"GITEA_TOKEN_",
|
|
||||||
"GITEA_PASS_",
|
|
||||||
"GITEA_USER_",
|
|
||||||
"GITEA_URL_",
|
|
||||||
"GITEA_HOST_",
|
|
||||||
"GITEA_REMOTE_",
|
|
||||||
"GITEA_HTTP_HEADER_",
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def get_unconsumed_gitea_env_overrides(env=None) -> dict[str, str]:
|
|
||||||
"""Find unsupported GITEA_* env vars present in *env* (defaults to os.environ)."""
|
|
||||||
target = os.environ if env is None else env
|
|
||||||
unconsumed = {}
|
|
||||||
for key, value in target.items():
|
|
||||||
if key.startswith("GITEA_"):
|
|
||||||
if key in RECOGNIZED_GITEA_ENV_KEYS:
|
|
||||||
continue
|
|
||||||
if any(key.startswith(p) for p in RECOGNIZED_GITEA_ENV_PREFIXES):
|
|
||||||
continue
|
|
||||||
unconsumed[key] = str(value)
|
|
||||||
return unconsumed
|
|
||||||
|
|
||||||
|
|
||||||
def launcher_entry(profile_name, config_path=None):
|
def launcher_entry(profile_name, config_path=None):
|
||||||
"""Return a thin MCP launcher entry for *profile_name*.
|
"""Return a thin MCP launcher entry for *profile_name*.
|
||||||
|
|
||||||
Contains command/args and the GITEA_MCP_* / GITEA_CLIENT_MANAGED env vars — never a token
|
Contains only command/args and the two GITEA_MCP_* env vars — never a token
|
||||||
or password. Suitable for Claude / Gemini / Codex ``mcpServers`` blocks.
|
or password. Suitable for Claude / Gemini / Codex ``mcpServers`` blocks.
|
||||||
"""
|
"""
|
||||||
command, args = server_command()
|
command, args = server_command()
|
||||||
@@ -1230,13 +1183,11 @@ def launcher_entry(profile_name, config_path=None):
|
|||||||
"env": {
|
"env": {
|
||||||
"GITEA_MCP_CONFIG": config_path or DEFAULT_CONFIG_PATH,
|
"GITEA_MCP_CONFIG": config_path or DEFAULT_CONFIG_PATH,
|
||||||
"GITEA_MCP_PROFILE": profile_name,
|
"GITEA_MCP_PROFILE": profile_name,
|
||||||
"GITEA_CLIENT_MANAGED": "1",
|
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
def keychain_set(item_id, token, account=None, runner=subprocess.run):
|
def keychain_set(item_id, token, account=None, runner=subprocess.run):
|
||||||
"""Store *token* in the macOS keychain under service *item_id*.
|
"""Store *token* in the macOS keychain under service *item_id*.
|
||||||
|
|
||||||
|
|||||||
+146
-125
@@ -2092,6 +2092,7 @@ import root_checkout_guard # noqa: E402
|
|||||||
import workflow_scope_guard # noqa: E402 # #683 production scope / force-on guards
|
import workflow_scope_guard # noqa: E402 # #683 production scope / force-on guards
|
||||||
import stable_branch_push_guard # noqa: E402
|
import stable_branch_push_guard # noqa: E402
|
||||||
import runtime_recovery_guard # noqa: E402 # #630 manual daemon-kill contamination
|
import runtime_recovery_guard # noqa: E402 # #630 manual daemon-kill contamination
|
||||||
|
import mcp_client_reconnect # noqa: E402 # #678 sanctioned Codex reconnect request
|
||||||
import remote_repo_guard # noqa: E402
|
import remote_repo_guard # noqa: E402
|
||||||
import anti_stomp_preflight # noqa: E402
|
import anti_stomp_preflight # noqa: E402
|
||||||
import issue_claim_heartbeat # noqa: E402
|
import issue_claim_heartbeat # noqa: E402
|
||||||
@@ -14024,11 +14025,16 @@ def _classify_operation_gate_reasons(reasons: list[str]) -> dict:
|
|||||||
|
|
||||||
|
|
||||||
def _stale_runtime_reconnect_action() -> str:
|
def _stale_runtime_reconnect_action() -> str:
|
||||||
"""Sanctioned recovery for a stale daemon — reconnect only (#685/#897)."""
|
"""Sanctioned recovery for a stale daemon — reconnect only (#685/#897/#678)."""
|
||||||
return (
|
return (
|
||||||
"Reconnect the IDE/client MCP session so the server reloads at the "
|
"blocker_kind=runtime_reconnect_required: call "
|
||||||
"current master head. Do not call gitea_activate_profile or switch "
|
"gitea_request_mcp_reconnect(namespace=<active gitea-* namespace>, "
|
||||||
"MCP role sessions — profile switching does not clear a stale daemon."
|
"reason='stale-runtime', client='codex') for a typed operator "
|
||||||
|
"reconnect blocker with exact UI steps, then reconnect the IDE/client "
|
||||||
|
"MCP session so the server reloads at the current master head. Do not "
|
||||||
|
"call gitea_activate_profile, pkill, touch configs, or switch MCP role "
|
||||||
|
"sessions — profile switching does not clear a stale daemon. After "
|
||||||
|
"reconnect restart from gitea_whoami → gitea_resolve_task_capability."
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
@@ -14585,56 +14591,6 @@ def _session_context_mutation_block(
|
|||||||
return blocked
|
return blocked
|
||||||
|
|
||||||
|
|
||||||
def _is_client_managed_process() -> bool:
|
|
||||||
"""Check whether the current MCP server process has client-managed launch provenance (#686)."""
|
|
||||||
val = (
|
|
||||||
os.environ.get("GITEA_CLIENT_MANAGED")
|
|
||||||
or os.environ.get("GITEA_MCP_CLIENT_MANAGED")
|
|
||||||
or os.environ.get("GITEA_SERVER_PROVENANCE")
|
|
||||||
or os.environ.get("GITEA_FORCE_CLIENT_MANAGED")
|
|
||||||
or ""
|
|
||||||
).strip().lower()
|
|
||||||
|
|
||||||
if val in ("0", "false", "no", "manual", "manual_launch"):
|
|
||||||
return False
|
|
||||||
|
|
||||||
if val in ("1", "true", "yes", "client_managed"):
|
|
||||||
return True
|
|
||||||
|
|
||||||
# A terminal launch has an active TTY on stdin
|
|
||||||
try:
|
|
||||||
if sys.stdin and sys.stdin.isatty():
|
|
||||||
return False
|
|
||||||
except Exception:
|
|
||||||
pass
|
|
||||||
|
|
||||||
# Standard client launch or test runner with stdio pipe and profile env
|
|
||||||
if "GITEA_MCP_CONFIG" in os.environ or "GITEA_MCP_PROFILE" in os.environ or "GITEA_PROFILE_NAME" in os.environ:
|
|
||||||
return True
|
|
||||||
|
|
||||||
return False
|
|
||||||
|
|
||||||
|
|
||||||
def _provenance_mutation_block(**extra_fields) -> dict | None:
|
|
||||||
"""Refuse mutating tool calls on processes lacking client-managed launch provenance (#686)."""
|
|
||||||
if _is_client_managed_process():
|
|
||||||
return None
|
|
||||||
unconsumed = gitea_config.get_unconsumed_gitea_env_overrides()
|
|
||||||
blocked = {
|
|
||||||
"success": False,
|
|
||||||
"performed": False,
|
|
||||||
"blocker_kind": "unsupported_manual_launch",
|
|
||||||
"reasons": [
|
|
||||||
"mutation denied: server process was launched manually from a terminal without client-managed provenance (fail closed). Manually launched mcp_server.py processes cannot receive IDE stdio or serve workflow mutations."
|
|
||||||
],
|
|
||||||
"exact_next_action": "BLOCKED + RECONNECT: Reconnect the IDE/client-managed MCP server namespace instead of an ad hoc terminal launch. Hand-launched processes and mcp_config.json hand-edits are classified as workflow contamination.",
|
|
||||||
"provenance": "manual_launch",
|
|
||||||
"unconsumed_gitea_env": unconsumed,
|
|
||||||
}
|
|
||||||
blocked.update(extra_fields)
|
|
||||||
return blocked
|
|
||||||
|
|
||||||
|
|
||||||
def _profile_permission_block(required_operation: str, **extra_fields) -> dict | None:
|
def _profile_permission_block(required_operation: str, **extra_fields) -> dict | None:
|
||||||
"""Structured operation-gate denial for gated tools (#69, #142, #897).
|
"""Structured operation-gate denial for gated tools (#69, #142, #897).
|
||||||
|
|
||||||
@@ -14651,10 +14607,6 @@ def _profile_permission_block(required_operation: str, **extra_fields) -> dict |
|
|||||||
# #714: evaluate active profile only — never auto-switch.
|
# #714: evaluate active profile only — never auto-switch.
|
||||||
_ensure_matching_profile(required_operation, req_role, extra_fields.get("remote"))
|
_ensure_matching_profile(required_operation, req_role, extra_fields.get("remote"))
|
||||||
|
|
||||||
prov_block = _provenance_mutation_block(**extra_fields)
|
|
||||||
if prov_block is not None:
|
|
||||||
return prov_block
|
|
||||||
|
|
||||||
reasons = _profile_operation_gate(required_operation)
|
reasons = _profile_operation_gate(required_operation)
|
||||||
if reasons:
|
if reasons:
|
||||||
return _build_operation_gate_refusal(
|
return _build_operation_gate_refusal(
|
||||||
@@ -14688,10 +14640,6 @@ def _namespace_mutation_block(mutation_task: str, **extra_fields) -> dict | None
|
|||||||
# #714: evaluate active profile only — never auto-switch.
|
# #714: evaluate active profile only — never auto-switch.
|
||||||
_ensure_matching_profile(required_permission, required_role, extra_fields.get("remote"))
|
_ensure_matching_profile(required_permission, required_role, extra_fields.get("remote"))
|
||||||
|
|
||||||
prov_block = _provenance_mutation_block(**extra_fields)
|
|
||||||
if prov_block is not None:
|
|
||||||
return prov_block
|
|
||||||
|
|
||||||
try:
|
try:
|
||||||
profile = get_profile()
|
profile = get_profile()
|
||||||
except Exception as exc:
|
except Exception as exc:
|
||||||
@@ -18139,9 +18087,6 @@ def gitea_get_runtime_context(
|
|||||||
source="gitea_get_runtime_context",
|
source="gitea_get_runtime_context",
|
||||||
)
|
)
|
||||||
|
|
||||||
is_client_managed = _is_client_managed_process()
|
|
||||||
unconsumed_env = gitea_config.get_unconsumed_gitea_env_overrides()
|
|
||||||
|
|
||||||
result = {
|
result = {
|
||||||
"active_profile": profile["profile_name"],
|
"active_profile": profile["profile_name"],
|
||||||
"authenticated_username": username,
|
"authenticated_username": username,
|
||||||
@@ -18158,9 +18103,6 @@ def gitea_get_runtime_context(
|
|||||||
"review_merge_blocked_reasons": blocked_reasons,
|
"review_merge_blocked_reasons": blocked_reasons,
|
||||||
"suggested_fix": suggested_fix,
|
"suggested_fix": suggested_fix,
|
||||||
"safe_next_action": safe_next_action,
|
"safe_next_action": safe_next_action,
|
||||||
"server_provenance": "client_managed" if is_client_managed else "manual_launch",
|
|
||||||
"is_client_managed": is_client_managed,
|
|
||||||
"unconsumed_gitea_env": unconsumed_env,
|
|
||||||
"preflight_ready": preflight["preflight_ready"],
|
"preflight_ready": preflight["preflight_ready"],
|
||||||
"preflight_block_reasons": preflight["preflight_block_reasons"],
|
"preflight_block_reasons": preflight["preflight_block_reasons"],
|
||||||
"preflight_workspace": preflight.get("preflight_workspace"),
|
"preflight_workspace": preflight.get("preflight_workspace"),
|
||||||
@@ -18174,13 +18116,6 @@ def gitea_get_runtime_context(
|
|||||||
PROJECT_ROOT),
|
PROJECT_ROOT),
|
||||||
}
|
}
|
||||||
|
|
||||||
if not is_client_managed:
|
|
||||||
result["safe_next_action"] = (
|
|
||||||
"BLOCKED + RECONNECT: Serving process lacks client-managed launch provenance (manual launch). "
|
|
||||||
"Reconnect the IDE/client-managed MCP server namespace instead of an ad hoc terminal launch."
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
# #702: read-only visibility into the inherited GITEA_ACTIVE_WORKTREE
|
# #702: read-only visibility into the inherited GITEA_ACTIVE_WORKTREE
|
||||||
# binding; recovery itself runs during capability resolution.
|
# binding; recovery itself runs during capability resolution.
|
||||||
try:
|
try:
|
||||||
@@ -20638,9 +20573,7 @@ def _check_mcp_runtimes_diagnostics(task: str, matching_profiles: list[str]) ->
|
|||||||
self_pid = os.getpid()
|
self_pid = os.getpid()
|
||||||
self_stale = False
|
self_stale = False
|
||||||
|
|
||||||
all_profile_procs: dict[str, list[dict]] = {}
|
running_profiles = {}
|
||||||
unsupported_env_found = set()
|
|
||||||
|
|
||||||
for line in proc.stdout.splitlines()[1:]:
|
for line in proc.stdout.splitlines()[1:]:
|
||||||
line = line.strip()
|
line = line.strip()
|
||||||
if not line or "mcp_server.py" not in line:
|
if not line or "mcp_server.py" not in line:
|
||||||
@@ -20672,55 +20605,16 @@ def _check_mcp_runtimes_diagnostics(task: str, matching_profiles: list[str]) ->
|
|||||||
if match:
|
if match:
|
||||||
profile = match.group(1)
|
profile = match.group(1)
|
||||||
|
|
||||||
is_client_managed = bool(
|
|
||||||
re.search(r'\bGITEA_CLIENT_MANAGED=(1|true|yes|client_managed)\b', env_out, re.IGNORECASE)
|
|
||||||
or re.search(r'\bGITEA_MCP_CLIENT_MANAGED=(1|true|yes|client_managed)\b', env_out, re.IGNORECASE)
|
|
||||||
or re.search(r'\bGITEA_SERVER_PROVENANCE=client_managed\b', env_out, re.IGNORECASE)
|
|
||||||
)
|
|
||||||
|
|
||||||
for env_match in re.finditer(r'\b(GITEA_[A-Z0-9_]+)=([^\s]+)', env_out):
|
|
||||||
k, v = env_match.group(1), env_match.group(2)
|
|
||||||
if k not in gitea_config.RECOGNIZED_GITEA_ENV_KEYS and not any(k.startswith(p) for p in gitea_config.RECOGNIZED_GITEA_ENV_PREFIXES):
|
|
||||||
unsupported_env_found.add(f"{k}={v}")
|
|
||||||
|
|
||||||
is_stale = (start_time < code_mtime) or git_stale
|
is_stale = (start_time < code_mtime) or git_stale
|
||||||
if pid == self_pid and is_stale:
|
if pid == self_pid and is_stale:
|
||||||
self_stale = True
|
self_stale = True
|
||||||
|
|
||||||
proc_info = {
|
if profile not in running_profiles or start_time > running_profiles[profile]["start_time"]:
|
||||||
|
running_profiles[profile] = {
|
||||||
"pid": pid,
|
"pid": pid,
|
||||||
"start_time": start_time,
|
"start_time": start_time,
|
||||||
"is_stale": is_stale,
|
"is_stale": is_stale
|
||||||
"is_client_managed": is_client_managed,
|
|
||||||
}
|
}
|
||||||
if profile not in all_profile_procs:
|
|
||||||
all_profile_procs[profile] = []
|
|
||||||
all_profile_procs[profile].append(proc_info)
|
|
||||||
|
|
||||||
running_profiles = {}
|
|
||||||
for profile, procs in all_profile_procs.items():
|
|
||||||
if len(procs) > 1:
|
|
||||||
pids_str = ", ".join(str(p["pid"]) for p in procs)
|
|
||||||
reasons.append(
|
|
||||||
f"stale-runtime: Duplicate MCP server process(es) detected for profile '{profile}' (PIDs: {pids_str}). "
|
|
||||||
"Manual or duplicate launches defeat staleness detection and cannot receive client stdio."
|
|
||||||
)
|
|
||||||
client_procs = [p for p in procs if p["is_client_managed"]]
|
|
||||||
if client_procs:
|
|
||||||
client_procs.sort(key=lambda p: p["start_time"], reverse=True)
|
|
||||||
running_profiles[profile] = client_procs[0]
|
|
||||||
else:
|
|
||||||
pids_str = ", ".join(str(p["pid"]) for p in procs)
|
|
||||||
reasons.append(
|
|
||||||
f"stale-runtime: Manually launched MCP process(es) detected without client-managed provenance for profile '{profile}' (PIDs: {pids_str}). "
|
|
||||||
"Manual launches cannot serve client stdio and are ignored for runtime freshness."
|
|
||||||
)
|
|
||||||
|
|
||||||
if unsupported_env_found:
|
|
||||||
reasons.append(
|
|
||||||
f"unsupported-env: Unsupported GITEA_* environment variable override(s) detected: {', '.join(sorted(unsupported_env_found))}. "
|
|
||||||
"Unknown env overrides are unsupported."
|
|
||||||
)
|
|
||||||
|
|
||||||
if self_stale:
|
if self_stale:
|
||||||
# #685: report-only — no config utime, no thread, no os._exit.
|
# #685: report-only — no config utime, no thread, no os._exit.
|
||||||
@@ -20755,7 +20649,6 @@ def _check_mcp_runtimes_diagnostics(task: str, matching_profiles: list[str]) ->
|
|||||||
return reasons
|
return reasons
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
@mcp.tool()
|
@mcp.tool()
|
||||||
def gitea_resolve_task_capability(
|
def gitea_resolve_task_capability(
|
||||||
task: str,
|
task: str,
|
||||||
@@ -21111,10 +21004,15 @@ def gitea_resolve_task_capability(
|
|||||||
# serving process/profile inventory is stale — even if permission is OK.
|
# serving process/profile inventory is stale — even if permission is OK.
|
||||||
if runtime_stale_blocker:
|
if runtime_stale_blocker:
|
||||||
next_safe_action = (
|
next_safe_action = (
|
||||||
"blocker_kind=runtime_reconnect_required: reconnect/restart the "
|
"blocker_kind=runtime_reconnect_required: call "
|
||||||
"IDE-managed Gitea MCP server for this profile so it reloads current "
|
"gitea_request_mcp_reconnect(namespace=<active gitea-* namespace>, "
|
||||||
"master. Do not edit mcp_config.json by hand; the resolver does not "
|
"reason='stale-runtime', client='codex') for a typed operator "
|
||||||
"touch config, spawn recovery threads, or terminate the process."
|
"blocker with exact UI steps, then reconnect/reload the IDE-managed "
|
||||||
|
"Gitea MCP server for this profile so it reloads current master. "
|
||||||
|
"Do not edit mcp_config.json by hand, pkill, or touch configs; the "
|
||||||
|
"resolver does not touch config, spawn recovery threads, or "
|
||||||
|
"terminate the process. After reconnect restart from gitea_whoami → "
|
||||||
|
"gitea_resolve_task_capability."
|
||||||
)
|
)
|
||||||
|
|
||||||
# Task/role alignment guards (#167): the requested task, not the
|
# Task/role alignment guards (#167): the requested task, not the
|
||||||
@@ -22672,6 +22570,129 @@ def gitea_workflow_dashboard(
|
|||||||
return payload
|
return payload
|
||||||
|
|
||||||
|
|
||||||
|
@mcp.tool()
|
||||||
|
def gitea_request_mcp_reconnect(
|
||||||
|
namespace: str | None = None,
|
||||||
|
reason: str | None = None,
|
||||||
|
client: str = "codex",
|
||||||
|
remote: str = "dadeschools",
|
||||||
|
host: str | None = None,
|
||||||
|
session_id: str | None = None,
|
||||||
|
) -> dict:
|
||||||
|
"""Request a sanctioned host/IDE MCP reconnect for a named namespace (#678).
|
||||||
|
|
||||||
|
Codex and other agent hosts can detect stale or closed Gitea MCP runtimes
|
||||||
|
(``stop_required`` / ``restart_required`` from capability resolution, transport
|
||||||
|
EOF, missing namespace attachment). The **host owns the transport** — this
|
||||||
|
process cannot reopen the client's stdio pipe. This tool is the callable
|
||||||
|
surface agents use to:
|
||||||
|
|
||||||
|
1. Report reconnect status fields (namespace, profile, pid/session,
|
||||||
|
startup SHA, current master SHA, boundary status).
|
||||||
|
2. Return a **typed blocker** with exact operator UI steps for Codex (or
|
||||||
|
another client) when reconnect is required.
|
||||||
|
|
||||||
|
This tool **never** restarts, kills, reloads, or reconfigures an MCP
|
||||||
|
process. Forbidden recovery paths (pkill, touch/mtime hacks, config/.env
|
||||||
|
edits, session-state edits, raw API) are never recommended.
|
||||||
|
|
||||||
|
After the operator reconnects, workflows must restart from preflight:
|
||||||
|
``gitea_whoami`` → ``gitea_resolve_task_capability`` → task.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
namespace: MCP namespace to reconnect (e.g. ``gitea-author``). Defaults
|
||||||
|
to the active profile's inferred namespace.
|
||||||
|
reason: Why reconnect is requested: ``stale-runtime``, ``transport_eof``,
|
||||||
|
``missing_namespace``, ``not_required``, or free-form (normalized).
|
||||||
|
client: Operator UI surface — ``codex`` (default), ``claude_code``, or
|
||||||
|
``generic``.
|
||||||
|
remote: Known instance — ``dadeschools`` or ``prgs`` (parity context).
|
||||||
|
host: Optional host override for parity context.
|
||||||
|
session_id: Optional session id to echo in the report.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
dict with reconnect report fields, ``reconnect_performed=False``,
|
||||||
|
``typed_blocker`` when reconnect is required, and
|
||||||
|
``forbidden_recovery_paths``.
|
||||||
|
"""
|
||||||
|
# Read-only: gitea.read is sufficient. Never a mutation.
|
||||||
|
read_block = _profile_operation_gate("gitea.read")
|
||||||
|
if read_block:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"read_only": True,
|
||||||
|
"reconnect_performed": False,
|
||||||
|
"mutation_performed": False,
|
||||||
|
"reasons": read_block,
|
||||||
|
"permission_report": _permission_block_report("gitea.read"),
|
||||||
|
"forbidden_recovery_paths": list(
|
||||||
|
mcp_client_reconnect.FORBIDDEN_RECOVERY_PATHS
|
||||||
|
),
|
||||||
|
}
|
||||||
|
|
||||||
|
profile = get_profile()
|
||||||
|
profile_name = (profile.get("profile_name") or "").strip() or None
|
||||||
|
inferred_ns = role_namespace_gate.infer_mcp_namespace(profile_name)
|
||||||
|
ns = (namespace or "").strip() or inferred_ns or "gitea-tools"
|
||||||
|
|
||||||
|
parity = _current_master_parity()
|
||||||
|
startup_sha = (
|
||||||
|
parity.get("daemon_start_head")
|
||||||
|
or parity.get("startup_head")
|
||||||
|
or _process_boot_head_sha
|
||||||
|
)
|
||||||
|
current_sha = parity.get("local_head") or parity.get("current_head")
|
||||||
|
if not current_sha:
|
||||||
|
try:
|
||||||
|
current_sha = master_parity_gate.read_git_head(PROJECT_ROOT)
|
||||||
|
except Exception: # noqa: BLE001
|
||||||
|
current_sha = None
|
||||||
|
|
||||||
|
boundary = mcp_client_reconnect.classify_boundary_status(
|
||||||
|
startup_sha=startup_sha if isinstance(startup_sha, str) else None,
|
||||||
|
current_master_sha=current_sha if isinstance(current_sha, str) else None,
|
||||||
|
live_stale=bool(parity.get("live_stale")) if parity.get("live_known") else None,
|
||||||
|
in_parity=parity.get("in_parity") if parity.get("determinable") else None,
|
||||||
|
)
|
||||||
|
|
||||||
|
# Infer reason from parity when caller left it unspecified.
|
||||||
|
effective_reason = reason
|
||||||
|
if not (effective_reason or "").strip():
|
||||||
|
if parity.get("restart_required") or parity.get("live_stale"):
|
||||||
|
effective_reason = mcp_client_reconnect.REASON_STALE_RUNTIME
|
||||||
|
elif boundary == mcp_client_reconnect.BOUNDARY_CLEAN:
|
||||||
|
effective_reason = mcp_client_reconnect.REASON_NOT_REQUIRED
|
||||||
|
else:
|
||||||
|
effective_reason = mcp_client_reconnect.REASON_UNSPECIFIED
|
||||||
|
|
||||||
|
payload = mcp_client_reconnect.build_reconnect_request(
|
||||||
|
namespace=ns,
|
||||||
|
profile=profile_name,
|
||||||
|
pid=os.getpid(),
|
||||||
|
session_id=session_id
|
||||||
|
or f"{(profile_name or 'session')}-{os.getpid()}",
|
||||||
|
startup_sha=startup_sha if isinstance(startup_sha, str) else None,
|
||||||
|
current_master_sha=current_sha if isinstance(current_sha, str) else None,
|
||||||
|
boundary_status=boundary,
|
||||||
|
reason=effective_reason,
|
||||||
|
client=client,
|
||||||
|
live_stale=bool(parity.get("live_stale")) if parity.get("live_known") else None,
|
||||||
|
in_parity=parity.get("in_parity") if parity.get("determinable") else None,
|
||||||
|
restart_required=bool(parity.get("restart_required")),
|
||||||
|
stop_required=bool(parity.get("restart_required")),
|
||||||
|
extra={
|
||||||
|
"remote": remote if remote in REMOTES else remote,
|
||||||
|
"host": host,
|
||||||
|
"session_context_audit": session_ctx.mutation_context_audit_fields(),
|
||||||
|
"parity_summary": master_parity_gate.format_parity(parity),
|
||||||
|
"live_stale": parity.get("live_stale"),
|
||||||
|
"live_known": parity.get("live_known"),
|
||||||
|
"in_parity": parity.get("in_parity"),
|
||||||
|
},
|
||||||
|
)
|
||||||
|
return payload
|
||||||
|
|
||||||
|
|
||||||
@mcp.tool()
|
@mcp.tool()
|
||||||
def gitea_request_mcp_restart(
|
def gitea_request_mcp_restart(
|
||||||
remote: str = "dadeschools",
|
remote: str = "dadeschools",
|
||||||
|
|||||||
@@ -0,0 +1,328 @@
|
|||||||
|
"""Sanctioned MCP client reconnect request surface for Codex/LLM sessions (#678).
|
||||||
|
|
||||||
|
Codex and other agent hosts can detect stale or closed Gitea MCP runtimes, but
|
||||||
|
the host owns the transport. This module never restarts, kills, or reloads a
|
||||||
|
daemon. It builds:
|
||||||
|
|
||||||
|
1. A **callable reconnect request** result agents can invoke via
|
||||||
|
``gitea_request_mcp_reconnect`` (report-only, side-effect free).
|
||||||
|
2. A **typed blocker** with exact operator UI steps when recovery must be
|
||||||
|
performed by the host/operator.
|
||||||
|
|
||||||
|
Forbidden recovery paths (must never be recommended):
|
||||||
|
|
||||||
|
* ``pkill`` / ``kill`` / ``killall`` of MCP daemons
|
||||||
|
* ``touch`` / mtime config reload hacks
|
||||||
|
* ``.env`` or MCP config edits as recovery
|
||||||
|
* session-state file edits
|
||||||
|
* raw Gitea API / direct server-import fallbacks
|
||||||
|
|
||||||
|
After the operator reconnects, workflows restart from identity / runtime /
|
||||||
|
capability preflight (``gitea_whoami`` → ``gitea_resolve_task_capability`` →
|
||||||
|
task).
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
from typing import Any, Mapping
|
||||||
|
|
||||||
|
# --- Reason vocabulary -------------------------------------------------------
|
||||||
|
|
||||||
|
REASON_STALE_RUNTIME = "stale-runtime"
|
||||||
|
REASON_TRANSPORT_EOF = "transport_eof"
|
||||||
|
REASON_MISSING_NAMESPACE = "missing_namespace"
|
||||||
|
REASON_NOT_REQUIRED = "not_required"
|
||||||
|
REASON_UNSPECIFIED = "unspecified"
|
||||||
|
|
||||||
|
VALID_REASONS = frozenset(
|
||||||
|
{
|
||||||
|
REASON_STALE_RUNTIME,
|
||||||
|
REASON_TRANSPORT_EOF,
|
||||||
|
REASON_MISSING_NAMESPACE,
|
||||||
|
REASON_NOT_REQUIRED,
|
||||||
|
REASON_UNSPECIFIED,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
|
||||||
|
# Boundary statuses reported to callers (match review_workflow_boundary style).
|
||||||
|
BOUNDARY_CLEAN = "clean"
|
||||||
|
BOUNDARY_MISMATCH = "mismatch"
|
||||||
|
BOUNDARY_STALE = "stale"
|
||||||
|
BOUNDARY_UNKNOWN = "unknown"
|
||||||
|
|
||||||
|
# Typed blocker kinds
|
||||||
|
BLOCKER_OPERATOR_RECONNECT = "operator_mcp_reconnect_required"
|
||||||
|
BLOCKER_NONE = "none"
|
||||||
|
|
||||||
|
FORBIDDEN_RECOVERY_PATHS: tuple[str, ...] = (
|
||||||
|
"pkill / kill / killall of mcp_server.py, gitea_mcp_server, or broad python sweeps",
|
||||||
|
"touch / mtime-based MCP config reload hacks",
|
||||||
|
".env edits as recovery",
|
||||||
|
"MCP config file edits as recovery",
|
||||||
|
"session-state file edits as recovery",
|
||||||
|
"raw Gitea API or direct MCP server-import fallbacks",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Client-specific operator UI steps. Keep Codex first (issue title surface).
|
||||||
|
OPERATOR_UI_STEPS: dict[str, tuple[str, ...]] = {
|
||||||
|
"codex": (
|
||||||
|
"In Codex, open the MCP / Developer tools panel for this workspace.",
|
||||||
|
"Locate the named Gitea MCP server entry (namespace) that needs reconnect "
|
||||||
|
"(e.g. gitea-author, gitea-reviewer, gitea-merger, gitea-tools, "
|
||||||
|
"gitea-controller, gitea-reconciler).",
|
||||||
|
"Click 'Reload Developer Tools' or the server reconnect/reload control "
|
||||||
|
"for that entry so the client spawns a fresh MCP subprocess.",
|
||||||
|
"If per-server reconnect is unavailable, fully restart the Codex client "
|
||||||
|
"(quit and relaunch) so all MCP namespaces reattach.",
|
||||||
|
"After reconnect, rerun the blocked workflow from preflight: "
|
||||||
|
"gitea_whoami → gitea_resolve_task_capability → the original task. "
|
||||||
|
"Do not resume mid-mutation.",
|
||||||
|
),
|
||||||
|
"claude_code": (
|
||||||
|
"Run `/mcp` (or open the MCP servers UI) in Claude Code.",
|
||||||
|
"Reconnect the affected gitea-* server entry so the client reopens stdio.",
|
||||||
|
"If reconnect fails, relaunch the Claude Code session entirely.",
|
||||||
|
"After reconnect, restart the workflow from gitea_whoami → "
|
||||||
|
"gitea_resolve_task_capability → task.",
|
||||||
|
),
|
||||||
|
"generic": (
|
||||||
|
"Use the host/IDE MCP reconnect or reload control for the named namespace.",
|
||||||
|
"If no per-namespace control exists, restart the MCP client/editor.",
|
||||||
|
"After reconnect, restart the workflow from identity/capability preflight.",
|
||||||
|
),
|
||||||
|
}
|
||||||
|
|
||||||
|
DEFAULT_CLIENT = "codex"
|
||||||
|
|
||||||
|
|
||||||
|
def normalize_reason(reason: str | None) -> str:
|
||||||
|
"""Map free-form reason strings onto the closed vocabulary."""
|
||||||
|
raw = (reason or "").strip().lower()
|
||||||
|
if not raw:
|
||||||
|
return REASON_UNSPECIFIED
|
||||||
|
if raw in VALID_REASONS:
|
||||||
|
return raw
|
||||||
|
text = raw.replace(" ", "_").replace("-", "_")
|
||||||
|
aliases = {
|
||||||
|
"stale_runtime": REASON_STALE_RUNTIME,
|
||||||
|
"staleruntime": REASON_STALE_RUNTIME,
|
||||||
|
"runtime_stale": REASON_STALE_RUNTIME,
|
||||||
|
"stale": REASON_STALE_RUNTIME,
|
||||||
|
"transport_eof": REASON_TRANSPORT_EOF,
|
||||||
|
"transport_closed": REASON_TRANSPORT_EOF,
|
||||||
|
"eof": REASON_TRANSPORT_EOF,
|
||||||
|
"client_is_closing": REASON_TRANSPORT_EOF,
|
||||||
|
"missing_namespace": REASON_MISSING_NAMESPACE,
|
||||||
|
"namespace_missing": REASON_MISSING_NAMESPACE,
|
||||||
|
"not_required": REASON_NOT_REQUIRED,
|
||||||
|
"healthy": REASON_NOT_REQUIRED,
|
||||||
|
"ok": REASON_NOT_REQUIRED,
|
||||||
|
"unspecified": REASON_UNSPECIFIED,
|
||||||
|
}
|
||||||
|
if text in aliases:
|
||||||
|
return aliases[text]
|
||||||
|
hyphenated = text.replace("_", "-")
|
||||||
|
if hyphenated in VALID_REASONS:
|
||||||
|
return hyphenated
|
||||||
|
return REASON_UNSPECIFIED
|
||||||
|
|
||||||
|
|
||||||
|
def normalize_client(client: str | None) -> str:
|
||||||
|
"""Return a known client key for operator UI steps."""
|
||||||
|
text = (client or "").strip().lower().replace(" ", "_").replace("-", "_")
|
||||||
|
if text in ("codex", "openai_codex", "openai"):
|
||||||
|
return "codex"
|
||||||
|
if text in ("claude", "claude_code", "claude_desktop", "anthropic"):
|
||||||
|
return "claude_code"
|
||||||
|
if text in OPERATOR_UI_STEPS:
|
||||||
|
return text
|
||||||
|
return DEFAULT_CLIENT
|
||||||
|
|
||||||
|
|
||||||
|
def classify_boundary_status(
|
||||||
|
*,
|
||||||
|
startup_sha: str | None,
|
||||||
|
current_master_sha: str | None,
|
||||||
|
live_stale: bool | None = None,
|
||||||
|
in_parity: bool | None = None,
|
||||||
|
) -> str:
|
||||||
|
"""Derive boundary_status from parity evidence."""
|
||||||
|
if live_stale is True or in_parity is False:
|
||||||
|
return BOUNDARY_STALE
|
||||||
|
start = (startup_sha or "").strip().lower()
|
||||||
|
current = (current_master_sha or "").strip().lower()
|
||||||
|
if start and current and start != current:
|
||||||
|
return BOUNDARY_MISMATCH
|
||||||
|
if start and current and start == current:
|
||||||
|
return BOUNDARY_CLEAN
|
||||||
|
if in_parity is True:
|
||||||
|
return BOUNDARY_CLEAN
|
||||||
|
return BOUNDARY_UNKNOWN
|
||||||
|
|
||||||
|
|
||||||
|
def operator_ui_steps(client: str | None, *, namespace: str | None = None) -> list[str]:
|
||||||
|
"""Exact operator UI steps for the named client."""
|
||||||
|
key = normalize_client(client)
|
||||||
|
steps = list(OPERATOR_UI_STEPS.get(key) or OPERATOR_UI_STEPS[DEFAULT_CLIENT])
|
||||||
|
ns = (namespace or "").strip()
|
||||||
|
if ns:
|
||||||
|
steps = [
|
||||||
|
s.replace("named Gitea MCP server entry (namespace)", f"namespace '{ns}'")
|
||||||
|
.replace("affected gitea-* server entry", f"server entry '{ns}'")
|
||||||
|
.replace("named namespace", f"namespace '{ns}'")
|
||||||
|
for s in steps
|
||||||
|
]
|
||||||
|
return steps
|
||||||
|
|
||||||
|
|
||||||
|
def build_reconnect_request(
|
||||||
|
*,
|
||||||
|
namespace: str,
|
||||||
|
profile: str | None = None,
|
||||||
|
pid: int | str | None = None,
|
||||||
|
session_id: str | None = None,
|
||||||
|
startup_sha: str | None = None,
|
||||||
|
current_master_sha: str | None = None,
|
||||||
|
boundary_status: str | None = None,
|
||||||
|
reason: str | None = None,
|
||||||
|
client: str | None = DEFAULT_CLIENT,
|
||||||
|
live_stale: bool | None = None,
|
||||||
|
in_parity: bool | None = None,
|
||||||
|
restart_required: bool | None = None,
|
||||||
|
stop_required: bool | None = None,
|
||||||
|
extra: Mapping[str, Any] | None = None,
|
||||||
|
) -> dict[str, Any]:
|
||||||
|
"""Build the structured reconnect-request / typed-blocker payload (#678).
|
||||||
|
|
||||||
|
Never mutates process, config, or session state. Always side-effect free.
|
||||||
|
"""
|
||||||
|
ns = (namespace or "").strip() or "unknown"
|
||||||
|
normalized_reason = normalize_reason(reason)
|
||||||
|
boundary = (boundary_status or "").strip() or classify_boundary_status(
|
||||||
|
startup_sha=startup_sha,
|
||||||
|
current_master_sha=current_master_sha,
|
||||||
|
live_stale=live_stale,
|
||||||
|
in_parity=in_parity,
|
||||||
|
)
|
||||||
|
|
||||||
|
reconnect_needed = True
|
||||||
|
if normalized_reason == REASON_NOT_REQUIRED and boundary == BOUNDARY_CLEAN:
|
||||||
|
reconnect_needed = False
|
||||||
|
if restart_required is False and stop_required is False and boundary == BOUNDARY_CLEAN:
|
||||||
|
# Explicit healthy probe
|
||||||
|
if normalized_reason in (REASON_NOT_REQUIRED, REASON_UNSPECIFIED):
|
||||||
|
reconnect_needed = False
|
||||||
|
normalized_reason = REASON_NOT_REQUIRED
|
||||||
|
|
||||||
|
if restart_required is True or stop_required is True:
|
||||||
|
reconnect_needed = True
|
||||||
|
if normalized_reason in (REASON_NOT_REQUIRED, REASON_UNSPECIFIED):
|
||||||
|
normalized_reason = REASON_STALE_RUNTIME
|
||||||
|
|
||||||
|
client_key = normalize_client(client)
|
||||||
|
steps = operator_ui_steps(client_key, namespace=ns)
|
||||||
|
|
||||||
|
result: dict[str, Any] = {
|
||||||
|
"success": True,
|
||||||
|
"read_only": True,
|
||||||
|
"reconnect_performed": False,
|
||||||
|
"mutation_performed": False,
|
||||||
|
"reconnect_needed": reconnect_needed,
|
||||||
|
"namespace": ns,
|
||||||
|
"profile": (profile or "").strip() or None,
|
||||||
|
"pid": pid,
|
||||||
|
"session_id": (session_id or "").strip() or None,
|
||||||
|
"startup_sha": (startup_sha or "").strip() or None,
|
||||||
|
"current_master_sha": (current_master_sha or "").strip() or None,
|
||||||
|
"boundary_status": boundary,
|
||||||
|
"reason": normalized_reason,
|
||||||
|
"client": client_key,
|
||||||
|
"forbidden_recovery_paths": list(FORBIDDEN_RECOVERY_PATHS),
|
||||||
|
"post_reconnect_preflight": [
|
||||||
|
"gitea_whoami",
|
||||||
|
"gitea_resolve_task_capability",
|
||||||
|
"original_task",
|
||||||
|
],
|
||||||
|
"exact_safe_next_action": None,
|
||||||
|
"blocker_kind": BLOCKER_NONE,
|
||||||
|
"operator_ui_steps": steps,
|
||||||
|
"typed_blocker": None,
|
||||||
|
}
|
||||||
|
|
||||||
|
if reconnect_needed:
|
||||||
|
result["blocker_kind"] = BLOCKER_OPERATOR_RECONNECT
|
||||||
|
result["stop_required"] = True
|
||||||
|
result["restart_required"] = True
|
||||||
|
result["exact_safe_next_action"] = (
|
||||||
|
f"blocker_kind={BLOCKER_OPERATOR_RECONNECT}: operator must reconnect "
|
||||||
|
f"MCP namespace '{ns}' via the host UI (client={client_key}). "
|
||||||
|
"Do not pkill, touch configs, edit session state, or use raw API. "
|
||||||
|
"After reconnect, restart from gitea_whoami → "
|
||||||
|
"gitea_resolve_task_capability → task."
|
||||||
|
)
|
||||||
|
result["typed_blocker"] = {
|
||||||
|
"blocker_kind": BLOCKER_OPERATOR_RECONNECT,
|
||||||
|
"namespaces": [ns],
|
||||||
|
"why_reconnect_required": normalized_reason,
|
||||||
|
"operator_ui_steps": steps,
|
||||||
|
"client": client_key,
|
||||||
|
"forbidden_recovery_paths": list(FORBIDDEN_RECOVERY_PATHS),
|
||||||
|
"instruction_after_reconnect": (
|
||||||
|
"Rerun the blocked workflow from preflight "
|
||||||
|
"(gitea_whoami → gitea_resolve_task_capability → task). "
|
||||||
|
"Do not continue mid-mutation from pre-reconnect state."
|
||||||
|
),
|
||||||
|
}
|
||||||
|
else:
|
||||||
|
result["stop_required"] = False
|
||||||
|
result["restart_required"] = False
|
||||||
|
result["exact_safe_next_action"] = (
|
||||||
|
f"Reconnect not required for namespace '{ns}' "
|
||||||
|
f"(boundary_status={boundary}). Proceed with the original task."
|
||||||
|
)
|
||||||
|
|
||||||
|
if extra:
|
||||||
|
for key, value in extra.items():
|
||||||
|
if key not in result:
|
||||||
|
result[key] = value
|
||||||
|
|
||||||
|
return result
|
||||||
|
|
||||||
|
|
||||||
|
def reasons_never_suggest_forbidden(text: str) -> bool:
|
||||||
|
"""Return True when *text* does not recommend a forbidden recovery path.
|
||||||
|
|
||||||
|
Mentions that *ban* a path (e.g. ``Do not pkill`` / ``never edit session
|
||||||
|
state``) are allowed. Positive recommendations such as ``use pkill`` or
|
||||||
|
``run killall`` fail.
|
||||||
|
"""
|
||||||
|
import re
|
||||||
|
|
||||||
|
lowered = (text or "").lower()
|
||||||
|
# Strip common ban prefixes so "do not pkill" does not trip positive checks.
|
||||||
|
scrubbed = re.sub(
|
||||||
|
r"\b(?:do not|don't|never|must not|forbid(?:den)?|ban(?:ned)?)\b"
|
||||||
|
r"[^.!;\n]{0,80}",
|
||||||
|
" ",
|
||||||
|
lowered,
|
||||||
|
)
|
||||||
|
# Positive imperative / advisory forms that would tell an agent to do harm.
|
||||||
|
positive_suggestions = (
|
||||||
|
"use pkill",
|
||||||
|
"run pkill",
|
||||||
|
"try pkill",
|
||||||
|
"pkill -f",
|
||||||
|
"use killall",
|
||||||
|
"run killall",
|
||||||
|
"killall mcp",
|
||||||
|
"use kill ",
|
||||||
|
"run kill ",
|
||||||
|
"touch the mcp",
|
||||||
|
"touch mcp config",
|
||||||
|
"utime(",
|
||||||
|
"edit the mcp config to recover",
|
||||||
|
"edit .env to recover",
|
||||||
|
"import gitea_mcp_server",
|
||||||
|
"python -c 'import gitea_mcp",
|
||||||
|
)
|
||||||
|
return not any(frag in scrubbed for frag in positive_suggestions)
|
||||||
@@ -225,16 +225,6 @@ def classify_namespace_probe(
|
|||||||
# on bad data without treating success as IDE proof).
|
# on bad data without treating success as IDE proof).
|
||||||
blocks = namespace_health_blocks_task("merge_pr", healthy)
|
blocks = namespace_health_blocks_task("merge_pr", healthy)
|
||||||
|
|
||||||
import gitea_config
|
|
||||||
raw_env = process.get("env") if isinstance(process, dict) else None
|
|
||||||
unconsumed_env = gitea_config.get_unconsumed_gitea_env_overrides(raw_env)
|
|
||||||
is_client_managed = bool(
|
|
||||||
env_summary.get("GITEA_CLIENT_MANAGED") in ("1", "true", "yes", "client_managed")
|
|
||||||
or env_summary.get("GITEA_MCP_CLIENT_MANAGED") in ("1", "true", "yes", "client_managed")
|
|
||||||
or env_summary.get("GITEA_SERVER_PROVENANCE") == "client_managed"
|
|
||||||
)
|
|
||||||
provenance = "client_managed" if is_client_managed else "manual_launch"
|
|
||||||
|
|
||||||
return {
|
return {
|
||||||
"success": healthy,
|
"success": healthy,
|
||||||
"healthy": healthy,
|
"healthy": healthy,
|
||||||
@@ -250,9 +240,6 @@ def classify_namespace_probe(
|
|||||||
"error_message": error_message or None,
|
"error_message": error_message or None,
|
||||||
"reasons": reasons,
|
"reasons": reasons,
|
||||||
"remediation": remediation,
|
"remediation": remediation,
|
||||||
"provenance": provenance,
|
|
||||||
"is_client_managed": is_client_managed,
|
|
||||||
"unconsumed_gitea_env": unconsumed_env,
|
|
||||||
"diagnostics": {
|
"diagnostics": {
|
||||||
"namespace": ns,
|
"namespace": ns,
|
||||||
"required_tool": tool,
|
"required_tool": tool,
|
||||||
@@ -261,9 +248,6 @@ def classify_namespace_probe(
|
|||||||
"env": env_summary,
|
"env": env_summary,
|
||||||
"config_path": config_path,
|
"config_path": config_path,
|
||||||
"probe_source": source,
|
"probe_source": source,
|
||||||
"provenance": provenance,
|
|
||||||
"is_client_managed": is_client_managed,
|
|
||||||
"unconsumed_gitea_env": unconsumed_env,
|
|
||||||
},
|
},
|
||||||
"blocks_merge_workflow": blocks,
|
"blocks_merge_workflow": blocks,
|
||||||
}
|
}
|
||||||
|
|||||||
+35
-5
@@ -225,8 +225,33 @@ _RESTART_PATHS: tuple[RestartPath, ...] = (
|
|||||||
"exact_safe_next_action pointing at IDE/client reconnect; performs "
|
"exact_safe_next_action pointing at IDE/client reconnect; performs "
|
||||||
"no restart, thread spawn, config touch, or os._exit."
|
"no restart, thread spawn, config touch, or os._exit."
|
||||||
),
|
),
|
||||||
locations=("gitea_mcp_server.py (gitea_resolve_task_capability)",),
|
locations=(
|
||||||
references=("#685", "#657"),
|
"gitea_mcp_server.py (gitea_resolve_task_capability)",
|
||||||
|
"gitea_mcp_server.py (gitea_request_mcp_reconnect)",
|
||||||
|
"mcp_client_reconnect.py",
|
||||||
|
),
|
||||||
|
references=("#685", "#657", "#678"),
|
||||||
|
),
|
||||||
|
RestartPath(
|
||||||
|
path_id="codex_client_reconnect_request",
|
||||||
|
title="Sanctioned Codex/LLM reconnect request tool",
|
||||||
|
mechanism=(
|
||||||
|
"gitea_request_mcp_reconnect: agents invoke a report-only tool that "
|
||||||
|
"returns namespace/profile/pid/startup SHA/master SHA/boundary "
|
||||||
|
"status plus a typed operator blocker with exact client UI steps."
|
||||||
|
),
|
||||||
|
classification=CLASS_GUARDED_FAIL_CLOSED,
|
||||||
|
guard=(
|
||||||
|
"Report-only (#678): never restarts, kills, reloads, or edits "
|
||||||
|
"config; recovery is always host/operator reconnect. Forbidden "
|
||||||
|
"paths (pkill, touch, .env/config/session-state hacks) are listed "
|
||||||
|
"and never recommended."
|
||||||
|
),
|
||||||
|
locations=(
|
||||||
|
"mcp_client_reconnect.py",
|
||||||
|
"gitea_mcp_server.py (gitea_request_mcp_reconnect)",
|
||||||
|
),
|
||||||
|
references=("#678", "#630", "#685", "#657"),
|
||||||
),
|
),
|
||||||
RestartPath(
|
RestartPath(
|
||||||
path_id="manual_daemon_kill",
|
path_id="manual_daemon_kill",
|
||||||
@@ -271,7 +296,8 @@ _RESTART_PATHS: tuple[RestartPath, ...] = (
|
|||||||
title="Host/IDE MCP reconnect",
|
title="Host/IDE MCP reconnect",
|
||||||
mechanism=(
|
mechanism=(
|
||||||
"A manual `/mcp reconnect` (or equivalent host action) that the "
|
"A manual `/mcp reconnect` (or equivalent host action) that the "
|
||||||
"IDE performs to recreate the MCP client connection."
|
"IDE performs to recreate the MCP client connection. Agents obtain "
|
||||||
|
"exact UI steps via gitea_request_mcp_reconnect (#678)."
|
||||||
),
|
),
|
||||||
classification=CLASS_HOST_RESIDUAL,
|
classification=CLASS_HOST_RESIDUAL,
|
||||||
guard=(
|
guard=(
|
||||||
@@ -279,8 +305,12 @@ _RESTART_PATHS: tuple[RestartPath, ...] = (
|
|||||||
"gates point operators toward; documented as residual host "
|
"gates point operators toward; documented as residual host "
|
||||||
"behavior. No in-process code initiates it."
|
"behavior. No in-process code initiates it."
|
||||||
),
|
),
|
||||||
locations=("host/IDE",),
|
locations=(
|
||||||
references=("#584", "#656", "#657"),
|
"host/IDE",
|
||||||
|
"mcp_client_reconnect.py",
|
||||||
|
"gitea_mcp_server.py (gitea_request_mcp_reconnect)",
|
||||||
|
),
|
||||||
|
references=("#584", "#656", "#657", "#678"),
|
||||||
residual_host=True,
|
residual_host=True,
|
||||||
),
|
),
|
||||||
RestartPath(
|
RestartPath(
|
||||||
|
|||||||
@@ -1,3 +0,0 @@
|
|||||||
[pytest]
|
|
||||||
testpaths = tests
|
|
||||||
norecursedirs = branches .git venv __pycache__ graphify-out
|
|
||||||
@@ -44,8 +44,6 @@ def _reset_mutation_authority(monkeypatch):
|
|||||||
]:
|
]:
|
||||||
monkeypatch.delenv(env_key, raising=False)
|
monkeypatch.delenv(env_key, raising=False)
|
||||||
|
|
||||||
monkeypatch.setenv("GITEA_CLIENT_MANAGED", "1")
|
|
||||||
|
|
||||||
# Isolate durable session-state files so tests never share host cache (#559).
|
# Isolate durable session-state files so tests never share host cache (#559).
|
||||||
import tempfile
|
import tempfile
|
||||||
|
|
||||||
|
|||||||
@@ -35,7 +35,7 @@ CONFIG = {
|
|||||||
],
|
],
|
||||||
"forbidden_operations": [],
|
"forbidden_operations": [],
|
||||||
"execution_profile": "full-author",
|
"execution_profile": "full-author",
|
||||||
"allowed_repositories": ["Scaled-Tech-Consulting/Gitea-Tools", "Example-Org/Example-Repo"],
|
"allowed_repositories": ["Example-Org/Example-Repo"],
|
||||||
},
|
},
|
||||||
"reviewer-no-commit": {
|
"reviewer-no-commit": {
|
||||||
"enabled": True,
|
"enabled": True,
|
||||||
@@ -50,7 +50,7 @@ CONFIG = {
|
|||||||
"gitea.repo.commit", "gitea.pr.create", "gitea.branch.push"
|
"gitea.repo.commit", "gitea.pr.create", "gitea.branch.push"
|
||||||
],
|
],
|
||||||
"execution_profile": "reviewer-no-commit",
|
"execution_profile": "reviewer-no-commit",
|
||||||
"allowed_repositories": ["Scaled-Tech-Consulting/Gitea-Tools", "Example-Org/Example-Repo"],
|
"allowed_repositories": ["Example-Org/Example-Repo"],
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
"rules": {"allow_runtime_switching": False},
|
"rules": {"allow_runtime_switching": False},
|
||||||
|
|||||||
@@ -175,7 +175,7 @@ class TestLauncherSnippets(unittest.TestCase):
|
|||||||
def test_only_safe_keys_no_secrets(self):
|
def test_only_safe_keys_no_secrets(self):
|
||||||
entry = gitea_config.launcher_entry("prgs", "/cfg/profiles.json")["gitea-tools"]
|
entry = gitea_config.launcher_entry("prgs", "/cfg/profiles.json")["gitea-tools"]
|
||||||
self.assertEqual(set(entry), {"command", "args", "env"})
|
self.assertEqual(set(entry), {"command", "args", "env"})
|
||||||
self.assertEqual(set(entry["env"]), {"GITEA_MCP_CONFIG", "GITEA_MCP_PROFILE", "GITEA_CLIENT_MANAGED"})
|
self.assertEqual(set(entry["env"]), {"GITEA_MCP_CONFIG", "GITEA_MCP_PROFILE"})
|
||||||
self.assertEqual(entry["env"]["GITEA_MCP_PROFILE"], "prgs")
|
self.assertEqual(entry["env"]["GITEA_MCP_PROFILE"], "prgs")
|
||||||
blob = json.dumps(entry).lower()
|
blob = json.dumps(entry).lower()
|
||||||
for word in ("token", "password", "secret"):
|
for word in ("token", "password", "secret"):
|
||||||
|
|||||||
@@ -0,0 +1,323 @@
|
|||||||
|
"""Tests for sanctioned Codex MCP reconnect request surface (#678)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import os
|
||||||
|
import unittest
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import mcp_client_reconnect as mcr
|
||||||
|
|
||||||
|
|
||||||
|
class NormalizeReasonTests(unittest.TestCase):
|
||||||
|
def test_stale_runtime_aliases(self):
|
||||||
|
self.assertEqual(mcr.normalize_reason("stale-runtime"), mcr.REASON_STALE_RUNTIME)
|
||||||
|
self.assertEqual(mcr.normalize_reason("stale_runtime"), mcr.REASON_STALE_RUNTIME)
|
||||||
|
self.assertEqual(mcr.normalize_reason("STALE"), mcr.REASON_STALE_RUNTIME)
|
||||||
|
|
||||||
|
def test_transport_eof_aliases(self):
|
||||||
|
self.assertEqual(mcr.normalize_reason("transport_eof"), mcr.REASON_TRANSPORT_EOF)
|
||||||
|
self.assertEqual(mcr.normalize_reason("EOF"), mcr.REASON_TRANSPORT_EOF)
|
||||||
|
self.assertEqual(
|
||||||
|
mcr.normalize_reason("client_is_closing"), mcr.REASON_TRANSPORT_EOF
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_missing_namespace(self):
|
||||||
|
self.assertEqual(
|
||||||
|
mcr.normalize_reason("missing_namespace"), mcr.REASON_MISSING_NAMESPACE
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_empty_is_unspecified(self):
|
||||||
|
self.assertEqual(mcr.normalize_reason(None), mcr.REASON_UNSPECIFIED)
|
||||||
|
self.assertEqual(mcr.normalize_reason(""), mcr.REASON_UNSPECIFIED)
|
||||||
|
|
||||||
|
|
||||||
|
class BoundaryClassificationTests(unittest.TestCase):
|
||||||
|
def test_clean_when_shas_match(self):
|
||||||
|
self.assertEqual(
|
||||||
|
mcr.classify_boundary_status(
|
||||||
|
startup_sha="abc", current_master_sha="abc"
|
||||||
|
),
|
||||||
|
mcr.BOUNDARY_CLEAN,
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_mismatch_when_shas_differ(self):
|
||||||
|
self.assertEqual(
|
||||||
|
mcr.classify_boundary_status(
|
||||||
|
startup_sha="aaa", current_master_sha="bbb"
|
||||||
|
),
|
||||||
|
mcr.BOUNDARY_MISMATCH,
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_stale_when_live_stale(self):
|
||||||
|
self.assertEqual(
|
||||||
|
mcr.classify_boundary_status(
|
||||||
|
startup_sha="aaa",
|
||||||
|
current_master_sha="aaa",
|
||||||
|
live_stale=True,
|
||||||
|
),
|
||||||
|
mcr.BOUNDARY_STALE,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class BuildReconnectRequestTests(unittest.TestCase):
|
||||||
|
def test_stale_runtime_returns_typed_blocker_with_codex_steps(self):
|
||||||
|
result = mcr.build_reconnect_request(
|
||||||
|
namespace="gitea-author",
|
||||||
|
profile="prgs-author",
|
||||||
|
pid=1234,
|
||||||
|
session_id="sess-1",
|
||||||
|
startup_sha="aaa111",
|
||||||
|
current_master_sha="bbb222",
|
||||||
|
reason="stale-runtime",
|
||||||
|
client="codex",
|
||||||
|
restart_required=True,
|
||||||
|
stop_required=True,
|
||||||
|
)
|
||||||
|
self.assertTrue(result["success"])
|
||||||
|
self.assertTrue(result["read_only"])
|
||||||
|
self.assertFalse(result["reconnect_performed"])
|
||||||
|
self.assertFalse(result["mutation_performed"])
|
||||||
|
self.assertTrue(result["reconnect_needed"])
|
||||||
|
self.assertEqual(result["namespace"], "gitea-author")
|
||||||
|
self.assertEqual(result["profile"], "prgs-author")
|
||||||
|
self.assertEqual(result["pid"], 1234)
|
||||||
|
self.assertEqual(result["session_id"], "sess-1")
|
||||||
|
self.assertEqual(result["startup_sha"], "aaa111")
|
||||||
|
self.assertEqual(result["current_master_sha"], "bbb222")
|
||||||
|
self.assertEqual(result["boundary_status"], mcr.BOUNDARY_MISMATCH)
|
||||||
|
self.assertEqual(result["blocker_kind"], mcr.BLOCKER_OPERATOR_RECONNECT)
|
||||||
|
self.assertIsNotNone(result["typed_blocker"])
|
||||||
|
blocker = result["typed_blocker"]
|
||||||
|
self.assertEqual(blocker["namespaces"], ["gitea-author"])
|
||||||
|
self.assertEqual(blocker["why_reconnect_required"], mcr.REASON_STALE_RUNTIME)
|
||||||
|
self.assertTrue(any("Codex" in s or "Reload" in s for s in blocker["operator_ui_steps"]))
|
||||||
|
self.assertIn("pkill", " ".join(result["forbidden_recovery_paths"]).lower())
|
||||||
|
self.assertTrue(
|
||||||
|
mcr.reasons_never_suggest_forbidden(result["exact_safe_next_action"] or "")
|
||||||
|
)
|
||||||
|
# Must not recommend forbidden recovery.
|
||||||
|
for step in blocker["operator_ui_steps"]:
|
||||||
|
self.assertTrue(mcr.reasons_never_suggest_forbidden(step), step)
|
||||||
|
|
||||||
|
def test_transport_eof_typed_blocker(self):
|
||||||
|
result = mcr.build_reconnect_request(
|
||||||
|
namespace="gitea-reviewer",
|
||||||
|
reason="transport_eof",
|
||||||
|
client="claude_code",
|
||||||
|
)
|
||||||
|
self.assertTrue(result["reconnect_needed"])
|
||||||
|
self.assertEqual(result["reason"], mcr.REASON_TRANSPORT_EOF)
|
||||||
|
self.assertEqual(result["client"], "claude_code")
|
||||||
|
steps = " ".join(result["operator_ui_steps"]).lower()
|
||||||
|
self.assertIn("/mcp", steps)
|
||||||
|
|
||||||
|
def test_missing_namespace_typed_blocker(self):
|
||||||
|
result = mcr.build_reconnect_request(
|
||||||
|
namespace="gitea-merger",
|
||||||
|
reason="missing_namespace",
|
||||||
|
client="codex",
|
||||||
|
)
|
||||||
|
self.assertTrue(result["reconnect_needed"])
|
||||||
|
self.assertEqual(result["reason"], mcr.REASON_MISSING_NAMESPACE)
|
||||||
|
self.assertEqual(
|
||||||
|
result["typed_blocker"]["blocker_kind"], mcr.BLOCKER_OPERATOR_RECONNECT
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_healthy_not_required(self):
|
||||||
|
result = mcr.build_reconnect_request(
|
||||||
|
namespace="gitea-tools",
|
||||||
|
startup_sha="deadbeef",
|
||||||
|
current_master_sha="deadbeef",
|
||||||
|
reason="not_required",
|
||||||
|
client="codex",
|
||||||
|
in_parity=True,
|
||||||
|
restart_required=False,
|
||||||
|
stop_required=False,
|
||||||
|
)
|
||||||
|
self.assertFalse(result["reconnect_needed"])
|
||||||
|
self.assertEqual(result["blocker_kind"], mcr.BLOCKER_NONE)
|
||||||
|
self.assertIsNone(result["typed_blocker"])
|
||||||
|
self.assertFalse(result["stop_required"])
|
||||||
|
self.assertFalse(result["restart_required"])
|
||||||
|
self.assertIn("not required", (result["exact_safe_next_action"] or "").lower())
|
||||||
|
|
||||||
|
def test_successful_reconnect_report_fields_present(self):
|
||||||
|
"""AC2: reconnect result reports required fields (even when needed)."""
|
||||||
|
result = mcr.build_reconnect_request(
|
||||||
|
namespace="gitea-controller",
|
||||||
|
profile="prgs-controller",
|
||||||
|
pid=99,
|
||||||
|
session_id="sid",
|
||||||
|
startup_sha="s" * 40,
|
||||||
|
current_master_sha="c" * 40,
|
||||||
|
reason="stale-runtime",
|
||||||
|
)
|
||||||
|
for key in (
|
||||||
|
"namespace",
|
||||||
|
"profile",
|
||||||
|
"pid",
|
||||||
|
"session_id",
|
||||||
|
"startup_sha",
|
||||||
|
"current_master_sha",
|
||||||
|
"boundary_status",
|
||||||
|
):
|
||||||
|
self.assertIn(key, result)
|
||||||
|
self.assertIsNotNone(result[key], key)
|
||||||
|
|
||||||
|
|
||||||
|
class ToolSurfaceTests(unittest.TestCase):
|
||||||
|
"""Exercise gitea_request_mcp_reconnect with a stubbed server context."""
|
||||||
|
|
||||||
|
def test_tool_is_registered_and_side_effect_free(self):
|
||||||
|
import gitea_mcp_server as srv
|
||||||
|
|
||||||
|
self.assertTrue(hasattr(srv, "gitea_request_mcp_reconnect"))
|
||||||
|
with mock.patch.object(srv, "_profile_operation_gate", return_value=None):
|
||||||
|
with mock.patch.object(
|
||||||
|
srv,
|
||||||
|
"get_profile",
|
||||||
|
return_value={
|
||||||
|
"profile_name": "prgs-author",
|
||||||
|
"role_kind": "author",
|
||||||
|
"role": "author",
|
||||||
|
},
|
||||||
|
):
|
||||||
|
with mock.patch.object(
|
||||||
|
srv,
|
||||||
|
"_current_master_parity",
|
||||||
|
return_value={
|
||||||
|
"startup_head": "a" * 40,
|
||||||
|
"current_head": "a" * 40,
|
||||||
|
"daemon_start_head": "a" * 40,
|
||||||
|
"local_head": "a" * 40,
|
||||||
|
"in_parity": True,
|
||||||
|
"stale": False,
|
||||||
|
"restart_required": False,
|
||||||
|
"determinable": True,
|
||||||
|
"live_stale": False,
|
||||||
|
"live_known": True,
|
||||||
|
"reasons": [],
|
||||||
|
},
|
||||||
|
):
|
||||||
|
with mock.patch.object(
|
||||||
|
srv.master_parity_gate,
|
||||||
|
"format_parity",
|
||||||
|
return_value="in parity",
|
||||||
|
):
|
||||||
|
with mock.patch.object(
|
||||||
|
srv.role_namespace_gate,
|
||||||
|
"infer_mcp_namespace",
|
||||||
|
return_value="gitea-author",
|
||||||
|
):
|
||||||
|
with mock.patch.object(
|
||||||
|
srv.session_ctx,
|
||||||
|
"mutation_context_audit_fields",
|
||||||
|
return_value={"session_profile": "prgs-author"},
|
||||||
|
):
|
||||||
|
result = srv.gitea_request_mcp_reconnect(
|
||||||
|
namespace="gitea-author",
|
||||||
|
reason="not_required",
|
||||||
|
client="codex",
|
||||||
|
remote="prgs",
|
||||||
|
)
|
||||||
|
self.assertTrue(result.get("success"))
|
||||||
|
self.assertFalse(result.get("reconnect_performed"))
|
||||||
|
self.assertFalse(result.get("mutation_performed"))
|
||||||
|
self.assertEqual(result.get("namespace"), "gitea-author")
|
||||||
|
self.assertEqual(result.get("profile"), "prgs-author")
|
||||||
|
self.assertEqual(result.get("pid"), os.getpid())
|
||||||
|
self.assertIn("startup_sha", result)
|
||||||
|
self.assertIn("current_master_sha", result)
|
||||||
|
self.assertIn("boundary_status", result)
|
||||||
|
self.assertTrue(
|
||||||
|
mcr.reasons_never_suggest_forbidden(
|
||||||
|
result.get("exact_safe_next_action") or ""
|
||||||
|
)
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_tool_stale_returns_typed_blocker(self):
|
||||||
|
import gitea_mcp_server as srv
|
||||||
|
|
||||||
|
with mock.patch.object(srv, "_profile_operation_gate", return_value=None):
|
||||||
|
with mock.patch.object(
|
||||||
|
srv,
|
||||||
|
"get_profile",
|
||||||
|
return_value={
|
||||||
|
"profile_name": "prgs-reconciler",
|
||||||
|
"role_kind": "reconciler",
|
||||||
|
"role": "reconciler",
|
||||||
|
},
|
||||||
|
):
|
||||||
|
with mock.patch.object(
|
||||||
|
srv,
|
||||||
|
"_current_master_parity",
|
||||||
|
return_value={
|
||||||
|
"startup_head": "a" * 40,
|
||||||
|
"current_head": "b" * 40,
|
||||||
|
"daemon_start_head": "a" * 40,
|
||||||
|
"local_head": "b" * 40,
|
||||||
|
"in_parity": False,
|
||||||
|
"stale": True,
|
||||||
|
"restart_required": True,
|
||||||
|
"determinable": True,
|
||||||
|
"live_stale": True,
|
||||||
|
"live_known": True,
|
||||||
|
"reasons": ["stale"],
|
||||||
|
},
|
||||||
|
):
|
||||||
|
with mock.patch.object(
|
||||||
|
srv.master_parity_gate,
|
||||||
|
"format_parity",
|
||||||
|
return_value="stale",
|
||||||
|
):
|
||||||
|
with mock.patch.object(
|
||||||
|
srv.role_namespace_gate,
|
||||||
|
"infer_mcp_namespace",
|
||||||
|
return_value="gitea-reconciler",
|
||||||
|
):
|
||||||
|
with mock.patch.object(
|
||||||
|
srv.session_ctx,
|
||||||
|
"mutation_context_audit_fields",
|
||||||
|
return_value={},
|
||||||
|
):
|
||||||
|
result = srv.gitea_request_mcp_reconnect(
|
||||||
|
reason="stale-runtime",
|
||||||
|
client="codex",
|
||||||
|
)
|
||||||
|
self.assertTrue(result["reconnect_needed"])
|
||||||
|
self.assertEqual(
|
||||||
|
result["blocker_kind"], mcr.BLOCKER_OPERATOR_RECONNECT
|
||||||
|
)
|
||||||
|
self.assertIsNotNone(result["typed_blocker"])
|
||||||
|
self.assertIn("gitea-reconciler", result["typed_blocker"]["namespaces"])
|
||||||
|
self.assertTrue(result["stop_required"])
|
||||||
|
self.assertTrue(result["restart_required"])
|
||||||
|
self.assertTrue(
|
||||||
|
mcr.reasons_never_suggest_forbidden(
|
||||||
|
result.get("exact_safe_next_action") or ""
|
||||||
|
)
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class InventoryRegistrationTests(unittest.TestCase):
|
||||||
|
def test_reconnect_path_in_restart_inventory(self):
|
||||||
|
import mcp_restart_paths as mrp
|
||||||
|
|
||||||
|
ids = {p.path_id for p in mrp.iter_restart_paths()}
|
||||||
|
self.assertIn("codex_client_reconnect_request", ids)
|
||||||
|
self.assertIn("ide_client_reconnect", ids)
|
||||||
|
|
||||||
|
def test_tool_name_in_documented_inventory(self):
|
||||||
|
import mcp_tool_inventory as inv
|
||||||
|
|
||||||
|
doc_path = os.path.join(
|
||||||
|
os.path.dirname(os.path.dirname(__file__)), inv.INVENTORY_DOC_PATH
|
||||||
|
)
|
||||||
|
with open(doc_path, encoding="utf-8") as handle:
|
||||||
|
documented = inv.parse_documented_inventory(handle.read())
|
||||||
|
self.assertIn("gitea_request_mcp_reconnect", documented)
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
unittest.main()
|
||||||
@@ -1,139 +0,0 @@
|
|||||||
"""Tests for Issue #686: Detect and reject manually launched duplicate MCP role servers."""
|
|
||||||
import os
|
|
||||||
import unittest
|
|
||||||
from unittest.mock import patch, MagicMock
|
|
||||||
from datetime import datetime
|
|
||||||
|
|
||||||
import gitea_config
|
|
||||||
import gitea_mcp_server
|
|
||||||
import mcp_namespace_health
|
|
||||||
|
|
||||||
|
|
||||||
class TestIssue686ManualMcpProvenance(unittest.TestCase):
|
|
||||||
|
|
||||||
def test_client_managed_process_detection(self):
|
|
||||||
"""Test _is_client_managed_process correctly detects provenance markers."""
|
|
||||||
with patch.dict(os.environ, {"GITEA_CLIENT_MANAGED": "1"}, clear=True):
|
|
||||||
self.assertTrue(gitea_mcp_server._is_client_managed_process())
|
|
||||||
|
|
||||||
with patch.dict(os.environ, {"GITEA_MCP_CLIENT_MANAGED": "true"}, clear=True):
|
|
||||||
self.assertTrue(gitea_mcp_server._is_client_managed_process())
|
|
||||||
|
|
||||||
with patch.dict(os.environ, {"GITEA_SERVER_PROVENANCE": "client_managed"}, clear=True):
|
|
||||||
self.assertTrue(gitea_mcp_server._is_client_managed_process())
|
|
||||||
|
|
||||||
with patch.dict(os.environ, {"GITEA_CLIENT_MANAGED": "0"}, clear=True):
|
|
||||||
self.assertFalse(gitea_mcp_server._is_client_managed_process())
|
|
||||||
|
|
||||||
def test_unconsumed_gitea_env_overrides(self):
|
|
||||||
"""Test surfacing of unsupported GITEA_* env overrides (e.g. GITEA_DUMMY)."""
|
|
||||||
env = {
|
|
||||||
"GITEA_MCP_PROFILE": "prgs-author",
|
|
||||||
"GITEA_CLIENT_MANAGED": "1",
|
|
||||||
"GITEA_DUMMY": "2",
|
|
||||||
"GITEA_UNKNOWN_FLAG": "abc",
|
|
||||||
}
|
|
||||||
unconsumed = gitea_config.get_unconsumed_gitea_env_overrides(env)
|
|
||||||
self.assertIn("GITEA_DUMMY", unconsumed)
|
|
||||||
self.assertEqual(unconsumed["GITEA_DUMMY"], "2")
|
|
||||||
self.assertIn("GITEA_UNKNOWN_FLAG", unconsumed)
|
|
||||||
self.assertNotIn("GITEA_MCP_PROFILE", unconsumed)
|
|
||||||
self.assertNotIn("GITEA_CLIENT_MANAGED", unconsumed)
|
|
||||||
|
|
||||||
def test_manual_server_mutation_fail_closed(self):
|
|
||||||
"""AC 2: Mutating tools on a server without client-managed provenance fail closed with a typed blocker."""
|
|
||||||
with patch.dict(os.environ, {"GITEA_CLIENT_MANAGED": "0"}, clear=True):
|
|
||||||
block = gitea_mcp_server._provenance_mutation_block(task="create_issue")
|
|
||||||
self.assertIsNotNone(block)
|
|
||||||
self.assertFalse(block["success"])
|
|
||||||
self.assertFalse(block["performed"])
|
|
||||||
self.assertEqual(block["blocker_kind"], "unsupported_manual_launch")
|
|
||||||
self.assertEqual(block["provenance"], "manual_launch")
|
|
||||||
self.assertTrue(any("mutation denied: server process was launched manually" in r for r in block["reasons"]))
|
|
||||||
self.assertIn("BLOCKED + RECONNECT", block["exact_next_action"])
|
|
||||||
|
|
||||||
def test_client_managed_server_mutation_passes_provenance_gate(self):
|
|
||||||
"""AC 3: Clean client-managed baseline passes the provenance gate."""
|
|
||||||
with patch.dict(os.environ, {"GITEA_CLIENT_MANAGED": "1"}, clear=True):
|
|
||||||
block = gitea_mcp_server._provenance_mutation_block(task="create_issue")
|
|
||||||
self.assertIsNone(block)
|
|
||||||
|
|
||||||
@patch("subprocess.run")
|
|
||||||
@patch("os.path.getmtime")
|
|
||||||
@patch("os.path.exists")
|
|
||||||
@patch("os.getpid")
|
|
||||||
def test_manual_duplicate_does_not_mask_stale_runtime(
|
|
||||||
self, mock_getpid, mock_exists, mock_getmtime, mock_run
|
|
||||||
):
|
|
||||||
"""AC 1 & AC 3: Staleness detection ignores manual duplicates and reports stale supported runtimes."""
|
|
||||||
mock_getpid.return_value = 12345
|
|
||||||
mock_exists.return_value = True
|
|
||||||
|
|
||||||
code_time = datetime(2026, 7, 8, 14, 0, 0)
|
|
||||||
mock_getmtime.return_value = code_time.timestamp()
|
|
||||||
|
|
||||||
# PID 12345: stale client-managed process (started at 13:00)
|
|
||||||
# PID 99999: fresh manual duplicate process (started at 15:00, no GITEA_CLIENT_MANAGED)
|
|
||||||
ps_output = (
|
|
||||||
" PID LSTART COMMAND\n"
|
|
||||||
"12345 Wed Jul 8 13:00:00 2026 /path/to/python mcp_server.py\n"
|
|
||||||
"99999 Wed Jul 8 15:00:00 2026 /path/to/python mcp_server.py\n"
|
|
||||||
)
|
|
||||||
|
|
||||||
mock_run_ps = MagicMock()
|
|
||||||
mock_run_ps.stdout = ps_output
|
|
||||||
|
|
||||||
mock_env_12345 = MagicMock()
|
|
||||||
mock_env_12345.stdout = "GITEA_MCP_PROFILE=prgs-author GITEA_CLIENT_MANAGED=1"
|
|
||||||
|
|
||||||
mock_env_99999 = MagicMock()
|
|
||||||
mock_env_99999.stdout = "GITEA_MCP_PROFILE=prgs-author GITEA_DUMMY=2"
|
|
||||||
|
|
||||||
def side_effect(args, **kwargs):
|
|
||||||
if args[0] == "ps" and "eww" in args:
|
|
||||||
pid = args[2]
|
|
||||||
if pid == "12345":
|
|
||||||
return mock_env_12345
|
|
||||||
elif pid == "99999":
|
|
||||||
return mock_env_99999
|
|
||||||
elif args[0] == "ps":
|
|
||||||
return mock_run_ps
|
|
||||||
raise ValueError(f"Unexpected args: {args}")
|
|
||||||
|
|
||||||
mock_run.side_effect = side_effect
|
|
||||||
|
|
||||||
reasons = gitea_mcp_server._check_mcp_runtimes_diagnostics("create_issue", ["prgs-author"])
|
|
||||||
|
|
||||||
# Manual duplicate process must be flagged
|
|
||||||
self.assertTrue(any("Duplicate MCP server process(es) detected" in r for r in reasons))
|
|
||||||
# Unsupported env override (GITEA_DUMMY=2) must be flagged
|
|
||||||
self.assertTrue(any("unsupported-env: Unsupported GITEA_* environment variable override(s) detected: GITEA_DUMMY=2" in r for r in reasons))
|
|
||||||
# Stale runtime must NOT be masked by fresh manual process 99999!
|
|
||||||
self.assertTrue(any("All matching profiles for task 'create_issue' (['prgs-author']) are running but stale" in r for r in reasons))
|
|
||||||
|
|
||||||
def test_namespace_health_classification_includes_provenance(self):
|
|
||||||
"""AC 1 & 4: mcp_namespace_health diagnostics include provenance and unconsumed_gitea_env."""
|
|
||||||
process = {
|
|
||||||
"pid": 5555,
|
|
||||||
"profile": "prgs-author",
|
|
||||||
"env": {
|
|
||||||
"GITEA_MCP_PROFILE": "prgs-author",
|
|
||||||
"GITEA_DUMMY": "99",
|
|
||||||
},
|
|
||||||
}
|
|
||||||
res = mcp_namespace_health.classify_namespace_probe(
|
|
||||||
"gitea-author",
|
|
||||||
configured=True,
|
|
||||||
registered_tools=["gitea_whoami"],
|
|
||||||
probe_result={"success": True},
|
|
||||||
process=process,
|
|
||||||
probe_source="client_namespace",
|
|
||||||
)
|
|
||||||
self.assertEqual(res["provenance"], "manual_launch")
|
|
||||||
self.assertFalse(res["is_client_managed"])
|
|
||||||
self.assertEqual(res["unconsumed_gitea_env"], {"GITEA_DUMMY": "99"})
|
|
||||||
self.assertEqual(res["diagnostics"]["provenance"], "manual_launch")
|
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
|
||||||
unittest.main()
|
|
||||||
@@ -35,10 +35,10 @@ class TestMcpStaleRuntime(unittest.TestCase):
|
|||||||
|
|
||||||
# Mock env output for ps eww
|
# Mock env output for ps eww
|
||||||
mock_run_env12345 = MagicMock()
|
mock_run_env12345 = MagicMock()
|
||||||
mock_run_env12345.stdout = "GITEA_MCP_PROFILE=prgs-reconciler GITEA_CLIENT_MANAGED=1"
|
mock_run_env12345.stdout = "GITEA_MCP_PROFILE=prgs-reconciler"
|
||||||
|
|
||||||
mock_run_env54321 = MagicMock()
|
mock_run_env54321 = MagicMock()
|
||||||
mock_run_env54321.stdout = "GITEA_MCP_PROFILE=prgs-author GITEA_CLIENT_MANAGED=1"
|
mock_run_env54321.stdout = "GITEA_MCP_PROFILE=prgs-author"
|
||||||
|
|
||||||
def side_effect(args, **kwargs):
|
def side_effect(args, **kwargs):
|
||||||
if args[0] == "ps" and "eww" in args:
|
if args[0] == "ps" and "eww" in args:
|
||||||
@@ -91,7 +91,7 @@ class TestMcpStaleRuntime(unittest.TestCase):
|
|||||||
mock_run_ps.stdout = ps_output
|
mock_run_ps.stdout = ps_output
|
||||||
|
|
||||||
mock_run_env = MagicMock()
|
mock_run_env = MagicMock()
|
||||||
mock_run_env.stdout = "GITEA_MCP_PROFILE=prgs-author GITEA_CLIENT_MANAGED=1"
|
mock_run_env.stdout = "GITEA_MCP_PROFILE=prgs-author"
|
||||||
|
|
||||||
mock_run_git = MagicMock()
|
mock_run_git = MagicMock()
|
||||||
mock_run_git.stdout = "FAKE2" # different SHA
|
mock_run_git.stdout = "FAKE2" # different SHA
|
||||||
|
|||||||
@@ -243,10 +243,9 @@ class TestRuntimeClarity(unittest.TestCase):
|
|||||||
self.assertIn("switching is disabled", res["message"].lower())
|
self.assertIn("switching is disabled", res["message"].lower())
|
||||||
self.assertIsNone(gitea_config._active_profile_override)
|
self.assertIsNone(gitea_config._active_profile_override)
|
||||||
|
|
||||||
@patch("mcp_server._trusted_session_repository", return_value={"repository": "Example-Org/Example-Repo", "org": "Example-Org", "repo": "Example-Repo", "reasons": []})
|
|
||||||
@patch("mcp_server.api_request")
|
@patch("mcp_server.api_request")
|
||||||
@patch("mcp_server.get_auth_header")
|
@patch("mcp_server.get_auth_header")
|
||||||
def test_activate_profile_succeeds_when_enabled(self, mock_auth, mock_api, mock_trusted):
|
def test_activate_profile_succeeds_when_enabled(self, mock_auth, mock_api):
|
||||||
self._write_config(CONFIG_SWITCHING_ENABLED)
|
self._write_config(CONFIG_SWITCHING_ENABLED)
|
||||||
|
|
||||||
# Setup mock responses for whoami checks
|
# Setup mock responses for whoami checks
|
||||||
|
|||||||
Reference in New Issue
Block a user