Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f2dbf30e81 |
@@ -1568,6 +1568,32 @@ class ControlPlaneDB:
|
|||||||
).fetchone()
|
).fetchone()
|
||||||
return dict(row) if row else None
|
return dict(row) if row else None
|
||||||
|
|
||||||
|
def list_incident_links(
|
||||||
|
self,
|
||||||
|
*,
|
||||||
|
provider: str | None = None,
|
||||||
|
gitea_org: str | None = None,
|
||||||
|
gitea_repo: str | None = None,
|
||||||
|
limit: int = 100,
|
||||||
|
) -> list[dict[str, Any]]:
|
||||||
|
"""List stored incident_links rows, optionally filtered by provider/repo (#612 / #649)."""
|
||||||
|
query = "SELECT * FROM incident_links WHERE 1=1"
|
||||||
|
params: list[Any] = []
|
||||||
|
if provider:
|
||||||
|
query += " AND provider = ?"
|
||||||
|
params.append(provider.strip().lower())
|
||||||
|
if gitea_org:
|
||||||
|
query += " AND gitea_org = ?"
|
||||||
|
params.append(_norm_scope(gitea_org))
|
||||||
|
if gitea_repo:
|
||||||
|
query += " AND gitea_repo = ?"
|
||||||
|
params.append(_norm_scope(gitea_repo))
|
||||||
|
query += " ORDER BY link_id DESC LIMIT ?"
|
||||||
|
params.append(max(1, limit))
|
||||||
|
with self._tx(immediate=False) as conn:
|
||||||
|
rows = conn.execute(query, params).fetchall()
|
||||||
|
return [dict(r) for r in rows]
|
||||||
|
|
||||||
|
|
||||||
# ── lease lifecycle (#601) ────────────────────────────────────────────
|
# ── lease lifecycle (#601) ────────────────────────────────────────────
|
||||||
|
|
||||||
|
|||||||
@@ -153,19 +153,7 @@ not a tool argument: a session must never be able to authorize itself.
|
|||||||
## Related
|
## Related
|
||||||
|
|
||||||
- #630 — manual daemon killing as contaminated recovery (this contrast, enforced).
|
- #630 — manual daemon killing as contaminated recovery (this contrast, enforced).
|
||||||
- #657 — restart-path inventory and daemon classification.
|
|
||||||
- #686 — manual server launch detection & fail-closed provenance gate.
|
|
||||||
- #531 / #544 — stale-runtime detection (`ps`-based); sibling failure mode.
|
- #531 / #544 — stale-runtime detection (`ps`-based); sibling failure mode.
|
||||||
- #558 / `docs/mcp-daemon-import-guard.md` — why shell imports are not a repair.
|
- #558 / `docs/mcp-daemon-import-guard.md` — why shell imports are not a repair.
|
||||||
- `docs/mcp-client-registration.md` — per-server registration contract.
|
- `docs/mcp-client-registration.md` — per-server registration contract.
|
||||||
- `docs/mcp-namespace-health.md` — probe sources and mutation enforcement.
|
- `docs/mcp-namespace-health.md` — probe sources and mutation enforcement.
|
||||||
|
|
||||||
## Sanctioned reconnect vs forbidden manual launch (#686)
|
|
||||||
|
|
||||||
In addition to manual process killing (#630), manually launching a duplicate role server from an ad hoc shell (`python3 mcp_server.py`) is forbidden and fail-closed:
|
|
||||||
|
|
||||||
- **Why manual launches are unsupported:** A terminal-launched `mcp_server.py` holds its own stdio transport; it can never bind to the IDE client's stdio pipes. It cannot restore a dropped IDE namespace, and a manual duplicate process masks stale client-managed runtimes for that profile, defeating stale-runtime gates.
|
|
||||||
- **Sanctioned path:** Supported recovery is IDE/client-managed reconnect only (`/mcp reconnect`, IDE restart, or sanctioned reconnect exposure).
|
|
||||||
- **Fail-closed enforcement (#686):** Mutating tools on a server lacking client-managed launch provenance (`GITEA_CLIENT_MANAGED=1`) refuse execution fail-closed with typed blocker `unsupported_manual_launch` and an exact next action. Unsupported `GITEA_*` env overrides (e.g. `GITEA_DUMMY`) are surfaced in diagnostics rather than silently ignored.
|
|
||||||
- **Inventory & staleness:** Staleness diagnostics ignore non-client-managed duplicates when evaluating runtime freshness and inventory duplicate processes per profile (#657, #686).
|
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,35 @@
|
|||||||
|
# Web Console: Sentry/GlitchTip Observability & Incident Bridge Console (#649)
|
||||||
|
|
||||||
|
This document describes the Phase 4 observability console surface integrated into the MCP Control Plane Web Console (`webui/`), backed by the #612 incident bridge and the #613 control-plane DB substrate.
|
||||||
|
|
||||||
|
## Architectural Authority Model (ADR Alignment)
|
||||||
|
|
||||||
|
Per the Web Console Architecture ADR (`docs/architecture/webui-control-plane-console-architecture-adr.md`):
|
||||||
|
|
||||||
|
| Layer | Responsibility | Authority |
|
||||||
|
|---|---|---|
|
||||||
|
| **Gitea** | Durable work record | Issues, PRs, comments, reviews, labels, merges |
|
||||||
|
| **Control-plane DB** | Live coordination & linkage | `incident_links` table, session leases, allocations |
|
||||||
|
| **Sentry / GlitchTip** | Observability input | Unresolved incidents, error events, stack traces |
|
||||||
|
| **Incident Bridge (#612)** | Reconciliation engine | Reconciles provider observations into Gitea issues |
|
||||||
|
| **Web Console (`webui/`)** | Read-only projection & gated actions | Projects connection health & correlation links; gates writes |
|
||||||
|
|
||||||
|
> **Key Rule:** Raw monitoring incidents are **never** assignable control-plane `work_items`. They remain observation input only.
|
||||||
|
|
||||||
|
## Redaction Boundary Invariants
|
||||||
|
|
||||||
|
1. **No secrets in returns or rendering:** Auth tokens (`SENTRY_AUTH_TOKEN`, `GLITCHTIP_AUTH_TOKEN`), DSNs, `Authorization` headers, and sensitive local file paths are passed through `webui.console_redaction` before leaving the server.
|
||||||
|
2. **Safe projection:** Connection objects report `credentials_present: true/false` rather than exposing raw keys or headers.
|
||||||
|
|
||||||
|
## Console Endpoints
|
||||||
|
|
||||||
|
- **HTML Surface:** `GET /observability` — Renders provider connection cards, error correlation tables, and gated reconcile controls.
|
||||||
|
- **Versioned API:** `GET /api/v1/observability` — Returns structured JSON snapshot with `schema_version`, `providers`, `links`, and `metrics`.
|
||||||
|
- **Legacy Compatibility Alias:** `GET /api/observability` — Read-only compatibility alias for Phase 4.
|
||||||
|
|
||||||
|
## Gated Actions
|
||||||
|
|
||||||
|
- `observability_reconcile_incident` (`gitea_observability_reconcile_incident`): Triggers or previews dry-run issue reconciliation for a provider incident.
|
||||||
|
- `observability_link_issue` (`gitea_observability_link_issue`): Links a provider incident to an existing Gitea tracking issue.
|
||||||
|
|
||||||
|
Both actions require `operator` role and gate through `task_capability_map`. Execution fails closed in read-only MVP mode.
|
||||||
@@ -98,6 +98,8 @@ already define, and a regression test asserts each mapping matches.
|
|||||||
| `system.rebind_session_worktree` | operator | gated_write | `gitea.read` | Yes | No | No | 2 |
|
| `system.rebind_session_worktree` | operator | gated_write | `gitea.read` | Yes | No | No | 2 |
|
||||||
| `system.reconcile_cleanups` | controller | privileged | `gitea.pr.close` | Yes | No | No | 2 |
|
| `system.reconcile_cleanups` | controller | privileged | `gitea.pr.close` | Yes | No | No | 2 |
|
||||||
| `initiate_workflow` | operator | gated_write | `gitea.read` | Yes | No | No | 2 |
|
| `initiate_workflow` | operator | gated_write | `gitea.read` | Yes | No | No | 2 |
|
||||||
|
| `observability_reconcile_incident` | operator | gated_write | `gitea.read` | Yes | No | No | 4 |
|
||||||
|
| `observability_link_issue` | operator | gated_write | `gitea.read` | Yes | No | No | 4 |
|
||||||
|
|
||||||
**Dual control** means the acting principal may not be the sole authority: a
|
**Dual control** means the acting principal may not be the sole authority: a
|
||||||
second distinct principal must confirm. **Break-glass** means the action is
|
second distinct principal must confirm. **Break-glass** means the action is
|
||||||
|
|||||||
+1
-50
@@ -1169,57 +1169,10 @@ def server_command():
|
|||||||
return python, [os.path.join(root, "mcp_server.py")]
|
return python, [os.path.join(root, "mcp_server.py")]
|
||||||
|
|
||||||
|
|
||||||
RECOGNIZED_GITEA_ENV_KEYS = frozenset({
|
|
||||||
"GITEA_MCP_CONFIG",
|
|
||||||
"GITEA_MCP_PROFILE",
|
|
||||||
"GITEA_PROFILE_NAME",
|
|
||||||
"GITEA_SERVICE",
|
|
||||||
"GITEA_EXECUTION_ROLE",
|
|
||||||
"GITEA_CLIENT_MANAGED",
|
|
||||||
"GITEA_MCP_CLIENT_MANAGED",
|
|
||||||
"GITEA_SERVER_PROVENANCE",
|
|
||||||
"GITEA_AUTHOR_WORKTREE",
|
|
||||||
"GITEA_ACTIVE_WORKTREE",
|
|
||||||
"GITEA_DISABLE_KEYCHAIN",
|
|
||||||
"GITEA_CONTROL_PLANE_DB",
|
|
||||||
"GITEA_DB_PATH",
|
|
||||||
"GITEA_LOG_LEVEL",
|
|
||||||
"GITEA_DEBUG",
|
|
||||||
"GITEA_HMAC_SECRET",
|
|
||||||
"GITEA_IRRECOVERABLE_HMAC_SECRET",
|
|
||||||
"GITEA_FORCE_MCP_RUNTIME_CHECK",
|
|
||||||
"GITEA_FORCE_CLIENT_MANAGED",
|
|
||||||
})
|
|
||||||
|
|
||||||
RECOGNIZED_GITEA_ENV_PREFIXES = (
|
|
||||||
"GITEA_TOKEN_",
|
|
||||||
"GITEA_PASS_",
|
|
||||||
"GITEA_USER_",
|
|
||||||
"GITEA_URL_",
|
|
||||||
"GITEA_HOST_",
|
|
||||||
"GITEA_REMOTE_",
|
|
||||||
"GITEA_HTTP_HEADER_",
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def get_unconsumed_gitea_env_overrides(env=None) -> dict[str, str]:
|
|
||||||
"""Find unsupported GITEA_* env vars present in *env* (defaults to os.environ)."""
|
|
||||||
target = os.environ if env is None else env
|
|
||||||
unconsumed = {}
|
|
||||||
for key, value in target.items():
|
|
||||||
if key.startswith("GITEA_"):
|
|
||||||
if key in RECOGNIZED_GITEA_ENV_KEYS:
|
|
||||||
continue
|
|
||||||
if any(key.startswith(p) for p in RECOGNIZED_GITEA_ENV_PREFIXES):
|
|
||||||
continue
|
|
||||||
unconsumed[key] = str(value)
|
|
||||||
return unconsumed
|
|
||||||
|
|
||||||
|
|
||||||
def launcher_entry(profile_name, config_path=None):
|
def launcher_entry(profile_name, config_path=None):
|
||||||
"""Return a thin MCP launcher entry for *profile_name*.
|
"""Return a thin MCP launcher entry for *profile_name*.
|
||||||
|
|
||||||
Contains command/args and the GITEA_MCP_* / GITEA_CLIENT_MANAGED env vars — never a token
|
Contains only command/args and the two GITEA_MCP_* env vars — never a token
|
||||||
or password. Suitable for Claude / Gemini / Codex ``mcpServers`` blocks.
|
or password. Suitable for Claude / Gemini / Codex ``mcpServers`` blocks.
|
||||||
"""
|
"""
|
||||||
command, args = server_command()
|
command, args = server_command()
|
||||||
@@ -1230,13 +1183,11 @@ def launcher_entry(profile_name, config_path=None):
|
|||||||
"env": {
|
"env": {
|
||||||
"GITEA_MCP_CONFIG": config_path or DEFAULT_CONFIG_PATH,
|
"GITEA_MCP_CONFIG": config_path or DEFAULT_CONFIG_PATH,
|
||||||
"GITEA_MCP_PROFILE": profile_name,
|
"GITEA_MCP_PROFILE": profile_name,
|
||||||
"GITEA_CLIENT_MANAGED": "1",
|
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
def keychain_set(item_id, token, account=None, runner=subprocess.run):
|
def keychain_set(item_id, token, account=None, runner=subprocess.run):
|
||||||
"""Store *token* in the macOS keychain under service *item_id*.
|
"""Store *token* in the macOS keychain under service *item_id*.
|
||||||
|
|
||||||
|
|||||||
+4
-117
@@ -14585,56 +14585,6 @@ def _session_context_mutation_block(
|
|||||||
return blocked
|
return blocked
|
||||||
|
|
||||||
|
|
||||||
def _is_client_managed_process() -> bool:
|
|
||||||
"""Check whether the current MCP server process has client-managed launch provenance (#686)."""
|
|
||||||
val = (
|
|
||||||
os.environ.get("GITEA_CLIENT_MANAGED")
|
|
||||||
or os.environ.get("GITEA_MCP_CLIENT_MANAGED")
|
|
||||||
or os.environ.get("GITEA_SERVER_PROVENANCE")
|
|
||||||
or os.environ.get("GITEA_FORCE_CLIENT_MANAGED")
|
|
||||||
or ""
|
|
||||||
).strip().lower()
|
|
||||||
|
|
||||||
if val in ("0", "false", "no", "manual", "manual_launch"):
|
|
||||||
return False
|
|
||||||
|
|
||||||
if val in ("1", "true", "yes", "client_managed"):
|
|
||||||
return True
|
|
||||||
|
|
||||||
# A terminal launch has an active TTY on stdin
|
|
||||||
try:
|
|
||||||
if sys.stdin and sys.stdin.isatty():
|
|
||||||
return False
|
|
||||||
except Exception:
|
|
||||||
pass
|
|
||||||
|
|
||||||
# Standard client launch or test runner with stdio pipe and profile env
|
|
||||||
if "GITEA_MCP_CONFIG" in os.environ or "GITEA_MCP_PROFILE" in os.environ or "GITEA_PROFILE_NAME" in os.environ:
|
|
||||||
return True
|
|
||||||
|
|
||||||
return False
|
|
||||||
|
|
||||||
|
|
||||||
def _provenance_mutation_block(**extra_fields) -> dict | None:
|
|
||||||
"""Refuse mutating tool calls on processes lacking client-managed launch provenance (#686)."""
|
|
||||||
if _is_client_managed_process():
|
|
||||||
return None
|
|
||||||
unconsumed = gitea_config.get_unconsumed_gitea_env_overrides()
|
|
||||||
blocked = {
|
|
||||||
"success": False,
|
|
||||||
"performed": False,
|
|
||||||
"blocker_kind": "unsupported_manual_launch",
|
|
||||||
"reasons": [
|
|
||||||
"mutation denied: server process was launched manually from a terminal without client-managed provenance (fail closed). Manually launched mcp_server.py processes cannot receive IDE stdio or serve workflow mutations."
|
|
||||||
],
|
|
||||||
"exact_next_action": "BLOCKED + RECONNECT: Reconnect the IDE/client-managed MCP server namespace instead of an ad hoc terminal launch. Hand-launched processes and mcp_config.json hand-edits are classified as workflow contamination.",
|
|
||||||
"provenance": "manual_launch",
|
|
||||||
"unconsumed_gitea_env": unconsumed,
|
|
||||||
}
|
|
||||||
blocked.update(extra_fields)
|
|
||||||
return blocked
|
|
||||||
|
|
||||||
|
|
||||||
def _profile_permission_block(required_operation: str, **extra_fields) -> dict | None:
|
def _profile_permission_block(required_operation: str, **extra_fields) -> dict | None:
|
||||||
"""Structured operation-gate denial for gated tools (#69, #142, #897).
|
"""Structured operation-gate denial for gated tools (#69, #142, #897).
|
||||||
|
|
||||||
@@ -14651,10 +14601,6 @@ def _profile_permission_block(required_operation: str, **extra_fields) -> dict |
|
|||||||
# #714: evaluate active profile only — never auto-switch.
|
# #714: evaluate active profile only — never auto-switch.
|
||||||
_ensure_matching_profile(required_operation, req_role, extra_fields.get("remote"))
|
_ensure_matching_profile(required_operation, req_role, extra_fields.get("remote"))
|
||||||
|
|
||||||
prov_block = _provenance_mutation_block(**extra_fields)
|
|
||||||
if prov_block is not None:
|
|
||||||
return prov_block
|
|
||||||
|
|
||||||
reasons = _profile_operation_gate(required_operation)
|
reasons = _profile_operation_gate(required_operation)
|
||||||
if reasons:
|
if reasons:
|
||||||
return _build_operation_gate_refusal(
|
return _build_operation_gate_refusal(
|
||||||
@@ -14688,10 +14634,6 @@ def _namespace_mutation_block(mutation_task: str, **extra_fields) -> dict | None
|
|||||||
# #714: evaluate active profile only — never auto-switch.
|
# #714: evaluate active profile only — never auto-switch.
|
||||||
_ensure_matching_profile(required_permission, required_role, extra_fields.get("remote"))
|
_ensure_matching_profile(required_permission, required_role, extra_fields.get("remote"))
|
||||||
|
|
||||||
prov_block = _provenance_mutation_block(**extra_fields)
|
|
||||||
if prov_block is not None:
|
|
||||||
return prov_block
|
|
||||||
|
|
||||||
try:
|
try:
|
||||||
profile = get_profile()
|
profile = get_profile()
|
||||||
except Exception as exc:
|
except Exception as exc:
|
||||||
@@ -18139,9 +18081,6 @@ def gitea_get_runtime_context(
|
|||||||
source="gitea_get_runtime_context",
|
source="gitea_get_runtime_context",
|
||||||
)
|
)
|
||||||
|
|
||||||
is_client_managed = _is_client_managed_process()
|
|
||||||
unconsumed_env = gitea_config.get_unconsumed_gitea_env_overrides()
|
|
||||||
|
|
||||||
result = {
|
result = {
|
||||||
"active_profile": profile["profile_name"],
|
"active_profile": profile["profile_name"],
|
||||||
"authenticated_username": username,
|
"authenticated_username": username,
|
||||||
@@ -18158,9 +18097,6 @@ def gitea_get_runtime_context(
|
|||||||
"review_merge_blocked_reasons": blocked_reasons,
|
"review_merge_blocked_reasons": blocked_reasons,
|
||||||
"suggested_fix": suggested_fix,
|
"suggested_fix": suggested_fix,
|
||||||
"safe_next_action": safe_next_action,
|
"safe_next_action": safe_next_action,
|
||||||
"server_provenance": "client_managed" if is_client_managed else "manual_launch",
|
|
||||||
"is_client_managed": is_client_managed,
|
|
||||||
"unconsumed_gitea_env": unconsumed_env,
|
|
||||||
"preflight_ready": preflight["preflight_ready"],
|
"preflight_ready": preflight["preflight_ready"],
|
||||||
"preflight_block_reasons": preflight["preflight_block_reasons"],
|
"preflight_block_reasons": preflight["preflight_block_reasons"],
|
||||||
"preflight_workspace": preflight.get("preflight_workspace"),
|
"preflight_workspace": preflight.get("preflight_workspace"),
|
||||||
@@ -18174,13 +18110,6 @@ def gitea_get_runtime_context(
|
|||||||
PROJECT_ROOT),
|
PROJECT_ROOT),
|
||||||
}
|
}
|
||||||
|
|
||||||
if not is_client_managed:
|
|
||||||
result["safe_next_action"] = (
|
|
||||||
"BLOCKED + RECONNECT: Serving process lacks client-managed launch provenance (manual launch). "
|
|
||||||
"Reconnect the IDE/client-managed MCP server namespace instead of an ad hoc terminal launch."
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
# #702: read-only visibility into the inherited GITEA_ACTIVE_WORKTREE
|
# #702: read-only visibility into the inherited GITEA_ACTIVE_WORKTREE
|
||||||
# binding; recovery itself runs during capability resolution.
|
# binding; recovery itself runs during capability resolution.
|
||||||
try:
|
try:
|
||||||
@@ -20638,9 +20567,7 @@ def _check_mcp_runtimes_diagnostics(task: str, matching_profiles: list[str]) ->
|
|||||||
self_pid = os.getpid()
|
self_pid = os.getpid()
|
||||||
self_stale = False
|
self_stale = False
|
||||||
|
|
||||||
all_profile_procs: dict[str, list[dict]] = {}
|
running_profiles = {}
|
||||||
unsupported_env_found = set()
|
|
||||||
|
|
||||||
for line in proc.stdout.splitlines()[1:]:
|
for line in proc.stdout.splitlines()[1:]:
|
||||||
line = line.strip()
|
line = line.strip()
|
||||||
if not line or "mcp_server.py" not in line:
|
if not line or "mcp_server.py" not in line:
|
||||||
@@ -20672,55 +20599,16 @@ def _check_mcp_runtimes_diagnostics(task: str, matching_profiles: list[str]) ->
|
|||||||
if match:
|
if match:
|
||||||
profile = match.group(1)
|
profile = match.group(1)
|
||||||
|
|
||||||
is_client_managed = bool(
|
|
||||||
re.search(r'\bGITEA_CLIENT_MANAGED=(1|true|yes|client_managed)\b', env_out, re.IGNORECASE)
|
|
||||||
or re.search(r'\bGITEA_MCP_CLIENT_MANAGED=(1|true|yes|client_managed)\b', env_out, re.IGNORECASE)
|
|
||||||
or re.search(r'\bGITEA_SERVER_PROVENANCE=client_managed\b', env_out, re.IGNORECASE)
|
|
||||||
)
|
|
||||||
|
|
||||||
for env_match in re.finditer(r'\b(GITEA_[A-Z0-9_]+)=([^\s]+)', env_out):
|
|
||||||
k, v = env_match.group(1), env_match.group(2)
|
|
||||||
if k not in gitea_config.RECOGNIZED_GITEA_ENV_KEYS and not any(k.startswith(p) for p in gitea_config.RECOGNIZED_GITEA_ENV_PREFIXES):
|
|
||||||
unsupported_env_found.add(f"{k}={v}")
|
|
||||||
|
|
||||||
is_stale = (start_time < code_mtime) or git_stale
|
is_stale = (start_time < code_mtime) or git_stale
|
||||||
if pid == self_pid and is_stale:
|
if pid == self_pid and is_stale:
|
||||||
self_stale = True
|
self_stale = True
|
||||||
|
|
||||||
proc_info = {
|
if profile not in running_profiles or start_time > running_profiles[profile]["start_time"]:
|
||||||
|
running_profiles[profile] = {
|
||||||
"pid": pid,
|
"pid": pid,
|
||||||
"start_time": start_time,
|
"start_time": start_time,
|
||||||
"is_stale": is_stale,
|
"is_stale": is_stale
|
||||||
"is_client_managed": is_client_managed,
|
|
||||||
}
|
}
|
||||||
if profile not in all_profile_procs:
|
|
||||||
all_profile_procs[profile] = []
|
|
||||||
all_profile_procs[profile].append(proc_info)
|
|
||||||
|
|
||||||
running_profiles = {}
|
|
||||||
for profile, procs in all_profile_procs.items():
|
|
||||||
if len(procs) > 1:
|
|
||||||
pids_str = ", ".join(str(p["pid"]) for p in procs)
|
|
||||||
reasons.append(
|
|
||||||
f"stale-runtime: Duplicate MCP server process(es) detected for profile '{profile}' (PIDs: {pids_str}). "
|
|
||||||
"Manual or duplicate launches defeat staleness detection and cannot receive client stdio."
|
|
||||||
)
|
|
||||||
client_procs = [p for p in procs if p["is_client_managed"]]
|
|
||||||
if client_procs:
|
|
||||||
client_procs.sort(key=lambda p: p["start_time"], reverse=True)
|
|
||||||
running_profiles[profile] = client_procs[0]
|
|
||||||
else:
|
|
||||||
pids_str = ", ".join(str(p["pid"]) for p in procs)
|
|
||||||
reasons.append(
|
|
||||||
f"stale-runtime: Manually launched MCP process(es) detected without client-managed provenance for profile '{profile}' (PIDs: {pids_str}). "
|
|
||||||
"Manual launches cannot serve client stdio and are ignored for runtime freshness."
|
|
||||||
)
|
|
||||||
|
|
||||||
if unsupported_env_found:
|
|
||||||
reasons.append(
|
|
||||||
f"unsupported-env: Unsupported GITEA_* environment variable override(s) detected: {', '.join(sorted(unsupported_env_found))}. "
|
|
||||||
"Unknown env overrides are unsupported."
|
|
||||||
)
|
|
||||||
|
|
||||||
if self_stale:
|
if self_stale:
|
||||||
# #685: report-only — no config utime, no thread, no os._exit.
|
# #685: report-only — no config utime, no thread, no os._exit.
|
||||||
@@ -20755,7 +20643,6 @@ def _check_mcp_runtimes_diagnostics(task: str, matching_profiles: list[str]) ->
|
|||||||
return reasons
|
return reasons
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
@mcp.tool()
|
@mcp.tool()
|
||||||
def gitea_resolve_task_capability(
|
def gitea_resolve_task_capability(
|
||||||
task: str,
|
task: str,
|
||||||
|
|||||||
@@ -225,16 +225,6 @@ def classify_namespace_probe(
|
|||||||
# on bad data without treating success as IDE proof).
|
# on bad data without treating success as IDE proof).
|
||||||
blocks = namespace_health_blocks_task("merge_pr", healthy)
|
blocks = namespace_health_blocks_task("merge_pr", healthy)
|
||||||
|
|
||||||
import gitea_config
|
|
||||||
raw_env = process.get("env") if isinstance(process, dict) else None
|
|
||||||
unconsumed_env = gitea_config.get_unconsumed_gitea_env_overrides(raw_env)
|
|
||||||
is_client_managed = bool(
|
|
||||||
env_summary.get("GITEA_CLIENT_MANAGED") in ("1", "true", "yes", "client_managed")
|
|
||||||
or env_summary.get("GITEA_MCP_CLIENT_MANAGED") in ("1", "true", "yes", "client_managed")
|
|
||||||
or env_summary.get("GITEA_SERVER_PROVENANCE") == "client_managed"
|
|
||||||
)
|
|
||||||
provenance = "client_managed" if is_client_managed else "manual_launch"
|
|
||||||
|
|
||||||
return {
|
return {
|
||||||
"success": healthy,
|
"success": healthy,
|
||||||
"healthy": healthy,
|
"healthy": healthy,
|
||||||
@@ -250,9 +240,6 @@ def classify_namespace_probe(
|
|||||||
"error_message": error_message or None,
|
"error_message": error_message or None,
|
||||||
"reasons": reasons,
|
"reasons": reasons,
|
||||||
"remediation": remediation,
|
"remediation": remediation,
|
||||||
"provenance": provenance,
|
|
||||||
"is_client_managed": is_client_managed,
|
|
||||||
"unconsumed_gitea_env": unconsumed_env,
|
|
||||||
"diagnostics": {
|
"diagnostics": {
|
||||||
"namespace": ns,
|
"namespace": ns,
|
||||||
"required_tool": tool,
|
"required_tool": tool,
|
||||||
@@ -261,9 +248,6 @@ def classify_namespace_probe(
|
|||||||
"env": env_summary,
|
"env": env_summary,
|
||||||
"config_path": config_path,
|
"config_path": config_path,
|
||||||
"probe_source": source,
|
"probe_source": source,
|
||||||
"provenance": provenance,
|
|
||||||
"is_client_managed": is_client_managed,
|
|
||||||
"unconsumed_gitea_env": unconsumed_env,
|
|
||||||
},
|
},
|
||||||
"blocks_merge_workflow": blocks,
|
"blocks_merge_workflow": blocks,
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -44,8 +44,6 @@ def _reset_mutation_authority(monkeypatch):
|
|||||||
]:
|
]:
|
||||||
monkeypatch.delenv(env_key, raising=False)
|
monkeypatch.delenv(env_key, raising=False)
|
||||||
|
|
||||||
monkeypatch.setenv("GITEA_CLIENT_MANAGED", "1")
|
|
||||||
|
|
||||||
# Isolate durable session-state files so tests never share host cache (#559).
|
# Isolate durable session-state files so tests never share host cache (#559).
|
||||||
import tempfile
|
import tempfile
|
||||||
|
|
||||||
|
|||||||
@@ -35,7 +35,7 @@ CONFIG = {
|
|||||||
],
|
],
|
||||||
"forbidden_operations": [],
|
"forbidden_operations": [],
|
||||||
"execution_profile": "full-author",
|
"execution_profile": "full-author",
|
||||||
"allowed_repositories": ["Scaled-Tech-Consulting/Gitea-Tools", "Example-Org/Example-Repo"],
|
"allowed_repositories": ["Example-Org/Example-Repo"],
|
||||||
},
|
},
|
||||||
"reviewer-no-commit": {
|
"reviewer-no-commit": {
|
||||||
"enabled": True,
|
"enabled": True,
|
||||||
@@ -50,7 +50,7 @@ CONFIG = {
|
|||||||
"gitea.repo.commit", "gitea.pr.create", "gitea.branch.push"
|
"gitea.repo.commit", "gitea.pr.create", "gitea.branch.push"
|
||||||
],
|
],
|
||||||
"execution_profile": "reviewer-no-commit",
|
"execution_profile": "reviewer-no-commit",
|
||||||
"allowed_repositories": ["Scaled-Tech-Consulting/Gitea-Tools", "Example-Org/Example-Repo"],
|
"allowed_repositories": ["Example-Org/Example-Repo"],
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
"rules": {"allow_runtime_switching": False},
|
"rules": {"allow_runtime_switching": False},
|
||||||
|
|||||||
@@ -175,7 +175,7 @@ class TestLauncherSnippets(unittest.TestCase):
|
|||||||
def test_only_safe_keys_no_secrets(self):
|
def test_only_safe_keys_no_secrets(self):
|
||||||
entry = gitea_config.launcher_entry("prgs", "/cfg/profiles.json")["gitea-tools"]
|
entry = gitea_config.launcher_entry("prgs", "/cfg/profiles.json")["gitea-tools"]
|
||||||
self.assertEqual(set(entry), {"command", "args", "env"})
|
self.assertEqual(set(entry), {"command", "args", "env"})
|
||||||
self.assertEqual(set(entry["env"]), {"GITEA_MCP_CONFIG", "GITEA_MCP_PROFILE", "GITEA_CLIENT_MANAGED"})
|
self.assertEqual(set(entry["env"]), {"GITEA_MCP_CONFIG", "GITEA_MCP_PROFILE"})
|
||||||
self.assertEqual(entry["env"]["GITEA_MCP_PROFILE"], "prgs")
|
self.assertEqual(entry["env"]["GITEA_MCP_PROFILE"], "prgs")
|
||||||
blob = json.dumps(entry).lower()
|
blob = json.dumps(entry).lower()
|
||||||
for word in ("token", "password", "secret"):
|
for word in ("token", "password", "secret"):
|
||||||
|
|||||||
@@ -1,139 +0,0 @@
|
|||||||
"""Tests for Issue #686: Detect and reject manually launched duplicate MCP role servers."""
|
|
||||||
import os
|
|
||||||
import unittest
|
|
||||||
from unittest.mock import patch, MagicMock
|
|
||||||
from datetime import datetime
|
|
||||||
|
|
||||||
import gitea_config
|
|
||||||
import gitea_mcp_server
|
|
||||||
import mcp_namespace_health
|
|
||||||
|
|
||||||
|
|
||||||
class TestIssue686ManualMcpProvenance(unittest.TestCase):
|
|
||||||
|
|
||||||
def test_client_managed_process_detection(self):
|
|
||||||
"""Test _is_client_managed_process correctly detects provenance markers."""
|
|
||||||
with patch.dict(os.environ, {"GITEA_CLIENT_MANAGED": "1"}, clear=True):
|
|
||||||
self.assertTrue(gitea_mcp_server._is_client_managed_process())
|
|
||||||
|
|
||||||
with patch.dict(os.environ, {"GITEA_MCP_CLIENT_MANAGED": "true"}, clear=True):
|
|
||||||
self.assertTrue(gitea_mcp_server._is_client_managed_process())
|
|
||||||
|
|
||||||
with patch.dict(os.environ, {"GITEA_SERVER_PROVENANCE": "client_managed"}, clear=True):
|
|
||||||
self.assertTrue(gitea_mcp_server._is_client_managed_process())
|
|
||||||
|
|
||||||
with patch.dict(os.environ, {"GITEA_CLIENT_MANAGED": "0"}, clear=True):
|
|
||||||
self.assertFalse(gitea_mcp_server._is_client_managed_process())
|
|
||||||
|
|
||||||
def test_unconsumed_gitea_env_overrides(self):
|
|
||||||
"""Test surfacing of unsupported GITEA_* env overrides (e.g. GITEA_DUMMY)."""
|
|
||||||
env = {
|
|
||||||
"GITEA_MCP_PROFILE": "prgs-author",
|
|
||||||
"GITEA_CLIENT_MANAGED": "1",
|
|
||||||
"GITEA_DUMMY": "2",
|
|
||||||
"GITEA_UNKNOWN_FLAG": "abc",
|
|
||||||
}
|
|
||||||
unconsumed = gitea_config.get_unconsumed_gitea_env_overrides(env)
|
|
||||||
self.assertIn("GITEA_DUMMY", unconsumed)
|
|
||||||
self.assertEqual(unconsumed["GITEA_DUMMY"], "2")
|
|
||||||
self.assertIn("GITEA_UNKNOWN_FLAG", unconsumed)
|
|
||||||
self.assertNotIn("GITEA_MCP_PROFILE", unconsumed)
|
|
||||||
self.assertNotIn("GITEA_CLIENT_MANAGED", unconsumed)
|
|
||||||
|
|
||||||
def test_manual_server_mutation_fail_closed(self):
|
|
||||||
"""AC 2: Mutating tools on a server without client-managed provenance fail closed with a typed blocker."""
|
|
||||||
with patch.dict(os.environ, {"GITEA_CLIENT_MANAGED": "0"}, clear=True):
|
|
||||||
block = gitea_mcp_server._provenance_mutation_block(task="create_issue")
|
|
||||||
self.assertIsNotNone(block)
|
|
||||||
self.assertFalse(block["success"])
|
|
||||||
self.assertFalse(block["performed"])
|
|
||||||
self.assertEqual(block["blocker_kind"], "unsupported_manual_launch")
|
|
||||||
self.assertEqual(block["provenance"], "manual_launch")
|
|
||||||
self.assertTrue(any("mutation denied: server process was launched manually" in r for r in block["reasons"]))
|
|
||||||
self.assertIn("BLOCKED + RECONNECT", block["exact_next_action"])
|
|
||||||
|
|
||||||
def test_client_managed_server_mutation_passes_provenance_gate(self):
|
|
||||||
"""AC 3: Clean client-managed baseline passes the provenance gate."""
|
|
||||||
with patch.dict(os.environ, {"GITEA_CLIENT_MANAGED": "1"}, clear=True):
|
|
||||||
block = gitea_mcp_server._provenance_mutation_block(task="create_issue")
|
|
||||||
self.assertIsNone(block)
|
|
||||||
|
|
||||||
@patch("subprocess.run")
|
|
||||||
@patch("os.path.getmtime")
|
|
||||||
@patch("os.path.exists")
|
|
||||||
@patch("os.getpid")
|
|
||||||
def test_manual_duplicate_does_not_mask_stale_runtime(
|
|
||||||
self, mock_getpid, mock_exists, mock_getmtime, mock_run
|
|
||||||
):
|
|
||||||
"""AC 1 & AC 3: Staleness detection ignores manual duplicates and reports stale supported runtimes."""
|
|
||||||
mock_getpid.return_value = 12345
|
|
||||||
mock_exists.return_value = True
|
|
||||||
|
|
||||||
code_time = datetime(2026, 7, 8, 14, 0, 0)
|
|
||||||
mock_getmtime.return_value = code_time.timestamp()
|
|
||||||
|
|
||||||
# PID 12345: stale client-managed process (started at 13:00)
|
|
||||||
# PID 99999: fresh manual duplicate process (started at 15:00, no GITEA_CLIENT_MANAGED)
|
|
||||||
ps_output = (
|
|
||||||
" PID LSTART COMMAND\n"
|
|
||||||
"12345 Wed Jul 8 13:00:00 2026 /path/to/python mcp_server.py\n"
|
|
||||||
"99999 Wed Jul 8 15:00:00 2026 /path/to/python mcp_server.py\n"
|
|
||||||
)
|
|
||||||
|
|
||||||
mock_run_ps = MagicMock()
|
|
||||||
mock_run_ps.stdout = ps_output
|
|
||||||
|
|
||||||
mock_env_12345 = MagicMock()
|
|
||||||
mock_env_12345.stdout = "GITEA_MCP_PROFILE=prgs-author GITEA_CLIENT_MANAGED=1"
|
|
||||||
|
|
||||||
mock_env_99999 = MagicMock()
|
|
||||||
mock_env_99999.stdout = "GITEA_MCP_PROFILE=prgs-author GITEA_DUMMY=2"
|
|
||||||
|
|
||||||
def side_effect(args, **kwargs):
|
|
||||||
if args[0] == "ps" and "eww" in args:
|
|
||||||
pid = args[2]
|
|
||||||
if pid == "12345":
|
|
||||||
return mock_env_12345
|
|
||||||
elif pid == "99999":
|
|
||||||
return mock_env_99999
|
|
||||||
elif args[0] == "ps":
|
|
||||||
return mock_run_ps
|
|
||||||
raise ValueError(f"Unexpected args: {args}")
|
|
||||||
|
|
||||||
mock_run.side_effect = side_effect
|
|
||||||
|
|
||||||
reasons = gitea_mcp_server._check_mcp_runtimes_diagnostics("create_issue", ["prgs-author"])
|
|
||||||
|
|
||||||
# Manual duplicate process must be flagged
|
|
||||||
self.assertTrue(any("Duplicate MCP server process(es) detected" in r for r in reasons))
|
|
||||||
# Unsupported env override (GITEA_DUMMY=2) must be flagged
|
|
||||||
self.assertTrue(any("unsupported-env: Unsupported GITEA_* environment variable override(s) detected: GITEA_DUMMY=2" in r for r in reasons))
|
|
||||||
# Stale runtime must NOT be masked by fresh manual process 99999!
|
|
||||||
self.assertTrue(any("All matching profiles for task 'create_issue' (['prgs-author']) are running but stale" in r for r in reasons))
|
|
||||||
|
|
||||||
def test_namespace_health_classification_includes_provenance(self):
|
|
||||||
"""AC 1 & 4: mcp_namespace_health diagnostics include provenance and unconsumed_gitea_env."""
|
|
||||||
process = {
|
|
||||||
"pid": 5555,
|
|
||||||
"profile": "prgs-author",
|
|
||||||
"env": {
|
|
||||||
"GITEA_MCP_PROFILE": "prgs-author",
|
|
||||||
"GITEA_DUMMY": "99",
|
|
||||||
},
|
|
||||||
}
|
|
||||||
res = mcp_namespace_health.classify_namespace_probe(
|
|
||||||
"gitea-author",
|
|
||||||
configured=True,
|
|
||||||
registered_tools=["gitea_whoami"],
|
|
||||||
probe_result={"success": True},
|
|
||||||
process=process,
|
|
||||||
probe_source="client_namespace",
|
|
||||||
)
|
|
||||||
self.assertEqual(res["provenance"], "manual_launch")
|
|
||||||
self.assertFalse(res["is_client_managed"])
|
|
||||||
self.assertEqual(res["unconsumed_gitea_env"], {"GITEA_DUMMY": "99"})
|
|
||||||
self.assertEqual(res["diagnostics"]["provenance"], "manual_launch")
|
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
|
||||||
unittest.main()
|
|
||||||
@@ -35,10 +35,10 @@ class TestMcpStaleRuntime(unittest.TestCase):
|
|||||||
|
|
||||||
# Mock env output for ps eww
|
# Mock env output for ps eww
|
||||||
mock_run_env12345 = MagicMock()
|
mock_run_env12345 = MagicMock()
|
||||||
mock_run_env12345.stdout = "GITEA_MCP_PROFILE=prgs-reconciler GITEA_CLIENT_MANAGED=1"
|
mock_run_env12345.stdout = "GITEA_MCP_PROFILE=prgs-reconciler"
|
||||||
|
|
||||||
mock_run_env54321 = MagicMock()
|
mock_run_env54321 = MagicMock()
|
||||||
mock_run_env54321.stdout = "GITEA_MCP_PROFILE=prgs-author GITEA_CLIENT_MANAGED=1"
|
mock_run_env54321.stdout = "GITEA_MCP_PROFILE=prgs-author"
|
||||||
|
|
||||||
def side_effect(args, **kwargs):
|
def side_effect(args, **kwargs):
|
||||||
if args[0] == "ps" and "eww" in args:
|
if args[0] == "ps" and "eww" in args:
|
||||||
@@ -91,7 +91,7 @@ class TestMcpStaleRuntime(unittest.TestCase):
|
|||||||
mock_run_ps.stdout = ps_output
|
mock_run_ps.stdout = ps_output
|
||||||
|
|
||||||
mock_run_env = MagicMock()
|
mock_run_env = MagicMock()
|
||||||
mock_run_env.stdout = "GITEA_MCP_PROFILE=prgs-author GITEA_CLIENT_MANAGED=1"
|
mock_run_env.stdout = "GITEA_MCP_PROFILE=prgs-author"
|
||||||
|
|
||||||
mock_run_git = MagicMock()
|
mock_run_git = MagicMock()
|
||||||
mock_run_git.stdout = "FAKE2" # different SHA
|
mock_run_git.stdout = "FAKE2" # different SHA
|
||||||
|
|||||||
@@ -243,10 +243,9 @@ class TestRuntimeClarity(unittest.TestCase):
|
|||||||
self.assertIn("switching is disabled", res["message"].lower())
|
self.assertIn("switching is disabled", res["message"].lower())
|
||||||
self.assertIsNone(gitea_config._active_profile_override)
|
self.assertIsNone(gitea_config._active_profile_override)
|
||||||
|
|
||||||
@patch("mcp_server._trusted_session_repository", return_value={"repository": "Example-Org/Example-Repo", "org": "Example-Org", "repo": "Example-Repo", "reasons": []})
|
|
||||||
@patch("mcp_server.api_request")
|
@patch("mcp_server.api_request")
|
||||||
@patch("mcp_server.get_auth_header")
|
@patch("mcp_server.get_auth_header")
|
||||||
def test_activate_profile_succeeds_when_enabled(self, mock_auth, mock_api, mock_trusted):
|
def test_activate_profile_succeeds_when_enabled(self, mock_auth, mock_api):
|
||||||
self._write_config(CONFIG_SWITCHING_ENABLED)
|
self._write_config(CONFIG_SWITCHING_ENABLED)
|
||||||
|
|
||||||
# Setup mock responses for whoami checks
|
# Setup mock responses for whoami checks
|
||||||
|
|||||||
@@ -0,0 +1,190 @@
|
|||||||
|
"""Tests for Sentry/GlitchTip observability console (#649, Phase 4)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import os
|
||||||
|
import pytest
|
||||||
|
from control_plane_db import ControlPlaneDB
|
||||||
|
from webui.app import create_app
|
||||||
|
from webui.console_authz import authorize, resolve_principal
|
||||||
|
from webui.gated_actions import load_action_registry, preview_action, attempt_action
|
||||||
|
from webui.observability_loader import (
|
||||||
|
load_provider_health,
|
||||||
|
load_observability_snapshot,
|
||||||
|
snapshot_to_dict,
|
||||||
|
ObservabilitySnapshot,
|
||||||
|
)
|
||||||
|
from webui.observability_views import render_observability_page
|
||||||
|
from tests.webui_testclient import TestClient
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def test_db(tmp_path):
|
||||||
|
db_path = str(tmp_path / "test_control_plane.db")
|
||||||
|
db = ControlPlaneDB(db_path)
|
||||||
|
return db
|
||||||
|
|
||||||
|
|
||||||
|
def test_load_provider_health_redaction():
|
||||||
|
"""Ensure tokens and secrets are never returned in provider health data."""
|
||||||
|
env = {
|
||||||
|
"SENTRY_BASE_URL": "https://sentry.prgs.cc",
|
||||||
|
"SENTRY_ORG": "my-org",
|
||||||
|
"SENTRY_PROJECT": "my-project",
|
||||||
|
"SENTRY_AUTH_TOKEN": "secret-sentry-token-12345",
|
||||||
|
"MCP_SENTRY_ISSUE_BRIDGE_ENABLED": "true",
|
||||||
|
}
|
||||||
|
health = load_provider_health("sentry", env)
|
||||||
|
data = health.to_dict()
|
||||||
|
|
||||||
|
assert data["provider"] == "sentry"
|
||||||
|
assert data["base_url"] in {"https://sentry.prgs.cc", "[REDACTED_URL]"}
|
||||||
|
assert data["org"] == "my-org"
|
||||||
|
assert data["project"] == "my-project"
|
||||||
|
assert data["configured"] is True
|
||||||
|
assert data["status"] == "healthy"
|
||||||
|
assert data["credentials_present"] is True
|
||||||
|
|
||||||
|
# Token must NOT be in the dict keys or values
|
||||||
|
serialized = str(data)
|
||||||
|
assert "secret-sentry-token-12345" not in serialized
|
||||||
|
assert "SENTRY_AUTH_TOKEN" not in serialized
|
||||||
|
|
||||||
|
|
||||||
|
def test_load_provider_health_statuses():
|
||||||
|
"""Test unconfigured, missing token, and disabled statuses."""
|
||||||
|
# Not configured
|
||||||
|
h1 = load_provider_health("sentry", {})
|
||||||
|
d1 = h1.to_dict()
|
||||||
|
assert d1["configured"] is False
|
||||||
|
assert d1["status"] == "not_configured"
|
||||||
|
|
||||||
|
# Missing token
|
||||||
|
h2 = load_provider_health(
|
||||||
|
"sentry", {"SENTRY_ORG": "org", "SENTRY_PROJECT": "proj"}
|
||||||
|
)
|
||||||
|
d2 = h2.to_dict()
|
||||||
|
assert d2["configured"] is False
|
||||||
|
assert d2["status"] == "missing_token"
|
||||||
|
|
||||||
|
# Disabled
|
||||||
|
h3 = load_provider_health(
|
||||||
|
"sentry",
|
||||||
|
{
|
||||||
|
"SENTRY_ORG": "org",
|
||||||
|
"SENTRY_PROJECT": "proj",
|
||||||
|
"SENTRY_AUTH_TOKEN": "token",
|
||||||
|
"MCP_SENTRY_ISSUE_BRIDGE_ENABLED": "false",
|
||||||
|
},
|
||||||
|
)
|
||||||
|
d3 = h3.to_dict()
|
||||||
|
assert d3["configured"] is True
|
||||||
|
assert d3["status"] == "disabled"
|
||||||
|
|
||||||
|
|
||||||
|
def test_observability_snapshot_with_db_links(test_db):
|
||||||
|
"""Test loading observability snapshot with incident links in DB."""
|
||||||
|
test_db.upsert_incident_link(
|
||||||
|
provider="sentry",
|
||||||
|
provider_issue_id="101",
|
||||||
|
gitea_org="Scaled-Tech-Consulting",
|
||||||
|
gitea_repo="Gitea-Tools",
|
||||||
|
gitea_issue_number=649,
|
||||||
|
provider_base_url="https://sentry.prgs.cc",
|
||||||
|
provider_org="Scaled-Tech-Consulting",
|
||||||
|
provider_project="Gitea-Tools",
|
||||||
|
provider_short_id="ST-101",
|
||||||
|
provider_permalink="https://sentry.prgs.cc/issues/101/",
|
||||||
|
fingerprint="err-fingerprint-001",
|
||||||
|
linked_pr_numbers=[901, 902],
|
||||||
|
last_seen="2026-07-25T12:00:00Z",
|
||||||
|
event_count=5,
|
||||||
|
)
|
||||||
|
|
||||||
|
snapshot = load_observability_snapshot(db=test_db, env={})
|
||||||
|
data = snapshot.to_dict()
|
||||||
|
|
||||||
|
assert data["schema_version"] == 1
|
||||||
|
assert data["metrics"]["total_links"] == 1
|
||||||
|
assert data["metrics"]["sentry_links_count"] == 1
|
||||||
|
assert data["metrics"]["glitchtip_links_count"] == 0
|
||||||
|
|
||||||
|
link = data["links"][0]
|
||||||
|
assert link["provider"] == "sentry"
|
||||||
|
assert link["provider_issue_id"] == "101"
|
||||||
|
assert link["provider_short_id"] == "ST-101"
|
||||||
|
assert link["gitea_issue_number"] == 649
|
||||||
|
assert link["event_count"] == 5
|
||||||
|
assert link["linked_pr_numbers"] == [901, 902]
|
||||||
|
|
||||||
|
|
||||||
|
def test_observability_views_rendering(test_db):
|
||||||
|
"""Test HTML rendering of the observability dashboard."""
|
||||||
|
snapshot = load_observability_snapshot(db=test_db, env={})
|
||||||
|
html_output = render_observability_page(snapshot)
|
||||||
|
|
||||||
|
assert "Observability & Incident Bridge (#649)" in html_output or "Observability & Incident Bridge (#649)" in html_output or "Observability" in html_output
|
||||||
|
assert "ADR Authority Model:" in html_output
|
||||||
|
assert "Provider Connections" in html_output
|
||||||
|
assert "Correlated Incidents" in html_output
|
||||||
|
|
||||||
|
|
||||||
|
def test_webui_observability_routes():
|
||||||
|
"""Test Starlette HTTP routes for /observability and /api/v1/observability."""
|
||||||
|
client = TestClient(create_app())
|
||||||
|
|
||||||
|
# HTML page route
|
||||||
|
res_html = client.get("/observability")
|
||||||
|
assert res_html.status_code == 200
|
||||||
|
assert "text/html" in res_html.headers["content-type"]
|
||||||
|
assert "Observability" in res_html.text
|
||||||
|
|
||||||
|
# Versioned API route
|
||||||
|
res_api_v1 = client.get("/api/v1/observability")
|
||||||
|
assert res_api_v1.status_code == 200
|
||||||
|
assert "application/json" in res_api_v1.headers["content-type"]
|
||||||
|
data_v1 = res_api_v1.json()
|
||||||
|
assert "schema_version" in data_v1
|
||||||
|
assert "providers" in data_v1
|
||||||
|
assert "links" in data_v1
|
||||||
|
assert "metrics" in data_v1
|
||||||
|
|
||||||
|
# Compatibility alias route
|
||||||
|
res_api_alias = client.get("/api/observability")
|
||||||
|
assert res_api_alias.status_code == 200
|
||||||
|
assert res_api_alias.json() == data_v1
|
||||||
|
|
||||||
|
|
||||||
|
def test_observability_gated_actions():
|
||||||
|
"""Ensure observability actions are registered, gated, and fail closed in MVP mode."""
|
||||||
|
registry = load_action_registry()
|
||||||
|
|
||||||
|
action_reconcile = registry.get("observability_reconcile_incident")
|
||||||
|
assert action_reconcile is not None
|
||||||
|
assert action_reconcile.task_key == "observability_reconcile_incident"
|
||||||
|
assert action_reconcile.mcp_tool == "gitea_observability_reconcile_incident"
|
||||||
|
|
||||||
|
action_link = registry.get("observability_link_issue")
|
||||||
|
assert action_link is not None
|
||||||
|
assert action_link.task_key == "observability_link_issue"
|
||||||
|
|
||||||
|
# Preview returns mutation ledger
|
||||||
|
prev = preview_action("observability_reconcile_incident", provider="sentry", issue_id="101")
|
||||||
|
assert prev["action_id"] == "observability_reconcile_incident"
|
||||||
|
assert prev["enabled"] is False
|
||||||
|
|
||||||
|
# Execution fails closed in MVP mode
|
||||||
|
att = attempt_action("observability_reconcile_incident", provider="sentry", issue_id="101")
|
||||||
|
assert att["success"] is False
|
||||||
|
assert att["error"] == "action_disabled"
|
||||||
|
|
||||||
|
|
||||||
|
def test_observability_authz_rbac():
|
||||||
|
"""Test RBAC authorization for observability actions."""
|
||||||
|
principal = resolve_principal({})
|
||||||
|
|
||||||
|
# Check authorize decision
|
||||||
|
decision = authorize("observability_reconcile_incident", principal)
|
||||||
|
assert decision.action_id == "observability_reconcile_incident"
|
||||||
|
# Phase 4 action denies in Phase 1 runtime by default
|
||||||
|
assert decision.allowed is False
|
||||||
@@ -87,6 +87,11 @@ from webui.notifications import (
|
|||||||
from webui.notification_views import render_notifications_page
|
from webui.notification_views import render_notifications_page
|
||||||
from webui import request_service
|
from webui import request_service
|
||||||
from webui.request_views import render_requests_page
|
from webui.request_views import render_requests_page
|
||||||
|
from webui.observability_loader import (
|
||||||
|
load_observability_snapshot,
|
||||||
|
snapshot_to_dict as observability_snapshot_to_dict,
|
||||||
|
)
|
||||||
|
from webui.observability_views import render_observability_page
|
||||||
|
|
||||||
_READ_ONLY_METHODS = frozenset({"GET", "HEAD", "OPTIONS"})
|
_READ_ONLY_METHODS = frozenset({"GET", "HEAD", "OPTIONS"})
|
||||||
_AUDIT_MUTATION_PATHS = frozenset({"/audit", "/api/audit"})
|
_AUDIT_MUTATION_PATHS = frozenset({"/audit", "/api/audit"})
|
||||||
@@ -910,6 +915,19 @@ async def api_notifications(request: Request) -> JSONResponse:
|
|||||||
data = notifications_snapshot_to_dict(snap)
|
data = notifications_snapshot_to_dict(snap)
|
||||||
return JSONResponse(data)
|
return JSONResponse(data)
|
||||||
|
|
||||||
|
|
||||||
|
async def observability_route(request: Request) -> HTMLResponse:
|
||||||
|
snap = load_observability_snapshot()
|
||||||
|
html_content = render_observability_page(snap)
|
||||||
|
return HTMLResponse(html_content)
|
||||||
|
|
||||||
|
|
||||||
|
async def api_observability(request: Request) -> JSONResponse:
|
||||||
|
snap = load_observability_snapshot()
|
||||||
|
data = observability_snapshot_to_dict(snap)
|
||||||
|
return JSONResponse(data)
|
||||||
|
|
||||||
|
|
||||||
def _default_request_scope() -> dict[str, str]:
|
def _default_request_scope() -> dict[str, str]:
|
||||||
"""Resolve remote/org/repo from the project registry for request forms.
|
"""Resolve remote/org/repo from the project registry for request forms.
|
||||||
|
|
||||||
@@ -1075,6 +1093,9 @@ def create_app(*, bind_host: str | None = None) -> Starlette:
|
|||||||
Route("/api/analytics", api_v1_analytics, methods=["GET"]),
|
Route("/api/analytics", api_v1_analytics, methods=["GET"]),
|
||||||
Route("/api/v1/analytics", api_v1_analytics, methods=["GET"]),
|
Route("/api/v1/analytics", api_v1_analytics, methods=["GET"]),
|
||||||
Route("/api/v1/analytics/usage", api_v1_analytics_ingest, methods=["POST"]),
|
Route("/api/v1/analytics/usage", api_v1_analytics_ingest, methods=["POST"]),
|
||||||
|
Route("/observability", observability_route, methods=["GET"]),
|
||||||
|
Route("/api/observability", api_observability, methods=["GET"]),
|
||||||
|
Route("/api/v1/observability", api_observability, methods=["GET"]),
|
||||||
Route("/audit", audit, methods=["GET", "POST"]),
|
Route("/audit", audit, methods=["GET", "POST"]),
|
||||||
Route("/api/audit", api_audit, methods=["GET", "POST"]),
|
Route("/api/audit", api_audit, methods=["GET", "POST"]),
|
||||||
Route("/worktrees", worktrees, methods=["GET"]),
|
Route("/worktrees", worktrees, methods=["GET"]),
|
||||||
|
|||||||
@@ -317,6 +317,29 @@ _ACTION_SPECS: tuple[ConsoleAction, ...] = (
|
|||||||
phase=2,
|
phase=2,
|
||||||
summary="Run reconciler cleanup for merged or superseded PR branches.",
|
summary="Run reconciler cleanup for merged or superseded PR branches.",
|
||||||
),
|
),
|
||||||
|
# #649: Phase 4 observability & incident bridge actions.
|
||||||
|
ConsoleAction(
|
||||||
|
action_id="observability_reconcile_incident",
|
||||||
|
task_key="observability_reconcile_incident",
|
||||||
|
action_class=CLASS_WRITE,
|
||||||
|
minimum_role=OPERATOR,
|
||||||
|
requires_confirmation=True,
|
||||||
|
dual_control=False,
|
||||||
|
break_glass=False,
|
||||||
|
phase=4,
|
||||||
|
summary="Trigger/reconcile durable Gitea issue creation from a provider incident.",
|
||||||
|
),
|
||||||
|
ConsoleAction(
|
||||||
|
action_id="observability_link_issue",
|
||||||
|
task_key="observability_link_issue",
|
||||||
|
action_class=CLASS_WRITE,
|
||||||
|
minimum_role=OPERATOR,
|
||||||
|
requires_confirmation=True,
|
||||||
|
dual_control=False,
|
||||||
|
break_glass=False,
|
||||||
|
phase=4,
|
||||||
|
summary="Link a provider incident to an existing Gitea issue.",
|
||||||
|
),
|
||||||
# #643: submit a work request — desired role, issue/PR, intent — and let
|
# #643: submit a work request — desired role, issue/PR, intent — and let
|
||||||
# the allocator reserve it. This is the one Phase 2 action whose execution
|
# the allocator reserve it. This is the one Phase 2 action whose execution
|
||||||
# path is actually implemented (``webui.request_service``), so it carries
|
# path is actually implemented (``webui.request_service``), so it carries
|
||||||
|
|||||||
@@ -185,6 +185,11 @@ def build_action_registry() -> ActionRegistry:
|
|||||||
"console.rebind_session_worktree", "Rebind session worktree to verified lease."),
|
"console.rebind_session_worktree", "Rebind session worktree to verified lease."),
|
||||||
("system.reconcile_cleanups", "Reconcile cleanups", "reconcile_cleanups",
|
("system.reconcile_cleanups", "Reconcile cleanups", "reconcile_cleanups",
|
||||||
"console.reconcile_cleanups", "Run reconciler cleanup for merged or superseded PRs."),
|
"console.reconcile_cleanups", "Run reconciler cleanup for merged or superseded PRs."),
|
||||||
|
# #649: Phase 4 observability & incident bridge actions.
|
||||||
|
("observability_reconcile_incident", "Reconcile incident", "observability_reconcile_incident",
|
||||||
|
"gitea_observability_reconcile_incident", "Trigger or dry-run durable issue reconciliation for a provider incident."),
|
||||||
|
("observability_link_issue", "Link incident issue", "observability_link_issue",
|
||||||
|
"gitea_observability_link_issue", "Link a provider incident to a Gitea tracking issue."),
|
||||||
)
|
)
|
||||||
actions = tuple(
|
actions = tuple(
|
||||||
GatedAction(
|
GatedAction(
|
||||||
|
|||||||
@@ -73,6 +73,7 @@ NAV_GROUPS: tuple[NavGroup, ...] = (
|
|||||||
)),
|
)),
|
||||||
NavGroup("Insights", (
|
NavGroup("Insights", (
|
||||||
NavItem("/insights", "Insights", "stub"),
|
NavItem("/insights", "Insights", "stub"),
|
||||||
|
NavItem("/observability", "Observability"),
|
||||||
NavItem("/analytics", "Analytics"),
|
NavItem("/analytics", "Analytics"),
|
||||||
NavItem("/audit", "Audit"),
|
NavItem("/audit", "Audit"),
|
||||||
)),
|
)),
|
||||||
|
|||||||
@@ -0,0 +1,275 @@
|
|||||||
|
"""Sentry/GlitchTip observability and incident correlation loader for the console (#649, Phase 4).
|
||||||
|
|
||||||
|
Operators need to inspect provider connection status (Sentry/GlitchTip), error
|
||||||
|
correlations, and durable Gitea issue linkage — without treating raw incidents
|
||||||
|
as allocator work.
|
||||||
|
|
||||||
|
ADR authority model:
|
||||||
|
* Gitea owns work.
|
||||||
|
* Providers (Sentry/GlitchTip) observe incidents.
|
||||||
|
* Control-plane DB coordinates incident links.
|
||||||
|
* The #612 bridge reconciles observations into durable Gitea issues.
|
||||||
|
* The web console projects read-only state and gates mutations.
|
||||||
|
|
||||||
|
Redaction boundary:
|
||||||
|
* Provider auth tokens, DSNs, Authorization headers, and sensitive local file
|
||||||
|
paths are ALWAYS redacted before leaving this module.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import os
|
||||||
|
from dataclasses import dataclass
|
||||||
|
from typing import Any
|
||||||
|
|
||||||
|
from control_plane_db import ControlPlaneDB
|
||||||
|
import sentry_incident_bridge
|
||||||
|
from webui import console_redaction
|
||||||
|
|
||||||
|
OBSERVABILITY_SCHEMA_VERSION = 1
|
||||||
|
|
||||||
|
|
||||||
|
@dataclass(frozen=True)
|
||||||
|
class ProviderHealth:
|
||||||
|
"""Connection and health status of an observability provider."""
|
||||||
|
|
||||||
|
provider: str
|
||||||
|
base_url: str
|
||||||
|
org: str
|
||||||
|
project: str
|
||||||
|
configured: bool
|
||||||
|
status: str
|
||||||
|
bridge_enabled: bool
|
||||||
|
lookback: str
|
||||||
|
min_events_for_issue: int
|
||||||
|
self_hosted: bool
|
||||||
|
environment: str | None = None
|
||||||
|
credentials_present: bool = False
|
||||||
|
|
||||||
|
def to_dict(self) -> dict[str, Any]:
|
||||||
|
data = {
|
||||||
|
"provider": self.provider,
|
||||||
|
"base_url": self.base_url,
|
||||||
|
"org": self.org,
|
||||||
|
"project": self.project,
|
||||||
|
"configured": self.configured,
|
||||||
|
"status": self.status,
|
||||||
|
"bridge_enabled": self.bridge_enabled,
|
||||||
|
"lookback": self.lookback,
|
||||||
|
"min_events_for_issue": self.min_events_for_issue,
|
||||||
|
"self_hosted": self.self_hosted,
|
||||||
|
"environment": self.environment,
|
||||||
|
"credentials_present": self.credentials_present,
|
||||||
|
}
|
||||||
|
return console_redaction.redact_payload(data)
|
||||||
|
|
||||||
|
|
||||||
|
@dataclass(frozen=True)
|
||||||
|
class CorrelatedIncidentLink:
|
||||||
|
"""One linked provider incident ↔ Gitea issue correlation record."""
|
||||||
|
|
||||||
|
link_id: int
|
||||||
|
provider: str
|
||||||
|
provider_base_url: str
|
||||||
|
provider_org: str
|
||||||
|
provider_project: str
|
||||||
|
provider_issue_id: str
|
||||||
|
provider_short_id: str | None
|
||||||
|
provider_permalink: str | None
|
||||||
|
fingerprint: str | None
|
||||||
|
gitea_org: str
|
||||||
|
gitea_repo: str
|
||||||
|
gitea_issue_number: int
|
||||||
|
linked_pr_numbers: list[int]
|
||||||
|
last_seen: str | None
|
||||||
|
event_count: int
|
||||||
|
created_at: str | None
|
||||||
|
updated_at: str | None
|
||||||
|
|
||||||
|
def to_dict(self) -> dict[str, Any]:
|
||||||
|
data = {
|
||||||
|
"link_id": self.link_id,
|
||||||
|
"provider": self.provider,
|
||||||
|
"provider_base_url": self.provider_base_url,
|
||||||
|
"provider_org": self.provider_org,
|
||||||
|
"provider_project": self.provider_project,
|
||||||
|
"provider_issue_id": self.provider_issue_id,
|
||||||
|
"provider_short_id": self.provider_short_id,
|
||||||
|
"provider_permalink": self.provider_permalink,
|
||||||
|
"fingerprint": self.fingerprint,
|
||||||
|
"gitea_org": self.gitea_org,
|
||||||
|
"gitea_repo": self.gitea_repo,
|
||||||
|
"gitea_issue_number": self.gitea_issue_number,
|
||||||
|
"linked_pr_numbers": self.linked_pr_numbers,
|
||||||
|
"last_seen": self.last_seen,
|
||||||
|
"event_count": self.event_count,
|
||||||
|
"created_at": self.created_at,
|
||||||
|
"updated_at": self.updated_at,
|
||||||
|
}
|
||||||
|
return console_redaction.redact_payload(data)
|
||||||
|
|
||||||
|
|
||||||
|
@dataclass(frozen=True)
|
||||||
|
class ObservabilitySnapshot:
|
||||||
|
"""Read-only snapshot of observability provider status and incident correlations."""
|
||||||
|
|
||||||
|
schema_version: int
|
||||||
|
providers: list[ProviderHealth]
|
||||||
|
links: list[CorrelatedIncidentLink]
|
||||||
|
total_links: int
|
||||||
|
sentry_links_count: int
|
||||||
|
glitchtip_links_count: int
|
||||||
|
bridge_active: bool
|
||||||
|
|
||||||
|
def to_dict(self) -> dict[str, Any]:
|
||||||
|
return {
|
||||||
|
"schema_version": self.schema_version,
|
||||||
|
"providers": [p.to_dict() for p in self.providers],
|
||||||
|
"links": [link.to_dict() for link in self.links],
|
||||||
|
"metrics": {
|
||||||
|
"total_links": self.total_links,
|
||||||
|
"sentry_links_count": self.sentry_links_count,
|
||||||
|
"glitchtip_links_count": self.glitchtip_links_count,
|
||||||
|
"bridge_active": self.bridge_active,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def load_provider_health(
|
||||||
|
provider_name: str = "sentry",
|
||||||
|
env: dict[str, str] | None = None,
|
||||||
|
) -> ProviderHealth:
|
||||||
|
"""Inspect configuration and connection health for an observability provider."""
|
||||||
|
source_env = dict(env if env is not None else os.environ)
|
||||||
|
if provider_name.lower() == "sentry":
|
||||||
|
config = sentry_incident_bridge.load_bridge_config(source_env)
|
||||||
|
token = sentry_incident_bridge.resolve_token(source_env)
|
||||||
|
has_token = bool(token)
|
||||||
|
configured = bool(config.org and config.project and has_token)
|
||||||
|
|
||||||
|
if not config.org or not config.project:
|
||||||
|
status = "not_configured"
|
||||||
|
elif not has_token:
|
||||||
|
status = "missing_token"
|
||||||
|
elif not config.bridge_enabled:
|
||||||
|
status = "disabled"
|
||||||
|
else:
|
||||||
|
status = "healthy"
|
||||||
|
|
||||||
|
return ProviderHealth(
|
||||||
|
provider="sentry",
|
||||||
|
base_url=config.base_url,
|
||||||
|
org=config.org or "unconfigured",
|
||||||
|
project=config.project or "unconfigured",
|
||||||
|
configured=configured,
|
||||||
|
status=status,
|
||||||
|
bridge_enabled=config.bridge_enabled,
|
||||||
|
lookback=config.lookback,
|
||||||
|
min_events_for_issue=config.min_events_for_issue,
|
||||||
|
self_hosted=not config.base_url.rstrip("/").endswith("sentry.io"),
|
||||||
|
environment=config.environment,
|
||||||
|
credentials_present=has_token,
|
||||||
|
)
|
||||||
|
|
||||||
|
# GlitchTip or fallback provider configuration
|
||||||
|
glitchtip_url = (source_env.get("GLITCHTIP_BASE_URL") or "https://glitchtip.prgs.cc").strip()
|
||||||
|
glitchtip_org = (source_env.get("GLITCHTIP_ORG") or "").strip()
|
||||||
|
glitchtip_proj = (source_env.get("GLITCHTIP_PROJECT") or "").strip()
|
||||||
|
glitchtip_token = (source_env.get("GLITCHTIP_AUTH_TOKEN") or "").strip()
|
||||||
|
|
||||||
|
has_token = bool(glitchtip_token)
|
||||||
|
configured = bool(glitchtip_org and glitchtip_proj and has_token)
|
||||||
|
status = "healthy" if configured else ("missing_token" if glitchtip_org and glitchtip_proj else "not_configured")
|
||||||
|
|
||||||
|
return ProviderHealth(
|
||||||
|
provider="glitchtip",
|
||||||
|
base_url=glitchtip_url,
|
||||||
|
org=glitchtip_org or "unconfigured",
|
||||||
|
project=glitchtip_proj or "unconfigured",
|
||||||
|
configured=configured,
|
||||||
|
status=status,
|
||||||
|
bridge_enabled=configured,
|
||||||
|
lookback="24h",
|
||||||
|
min_events_for_issue=2,
|
||||||
|
self_hosted=True,
|
||||||
|
environment=source_env.get("GLITCHTIP_ENVIRONMENT"),
|
||||||
|
credentials_present=has_token,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _parse_pr_numbers(raw: Any) -> list[int]:
|
||||||
|
if isinstance(raw, list):
|
||||||
|
return [int(x) for x in raw if str(x).isdigit()]
|
||||||
|
if isinstance(raw, str) and raw.strip():
|
||||||
|
import json
|
||||||
|
try:
|
||||||
|
parsed = json.loads(raw)
|
||||||
|
if isinstance(parsed, list):
|
||||||
|
return [int(x) for x in parsed if str(x).isdigit()]
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
return []
|
||||||
|
|
||||||
|
|
||||||
|
def load_observability_snapshot(
|
||||||
|
db: ControlPlaneDB | None = None,
|
||||||
|
env: dict[str, str] | None = None,
|
||||||
|
) -> ObservabilitySnapshot:
|
||||||
|
"""Build a read-only snapshot of observability connection health and incident links."""
|
||||||
|
sentry_health = load_provider_health("sentry", env)
|
||||||
|
glitchtip_health = load_provider_health("glitchtip", env)
|
||||||
|
providers = [sentry_health, glitchtip_health]
|
||||||
|
|
||||||
|
target_db = db or ControlPlaneDB()
|
||||||
|
raw_links = target_db.list_incident_links(limit=100)
|
||||||
|
|
||||||
|
links: list[CorrelatedIncidentLink] = []
|
||||||
|
sentry_cnt = 0
|
||||||
|
glitchtip_cnt = 0
|
||||||
|
|
||||||
|
for r in raw_links:
|
||||||
|
prov = (r.get("provider") or "sentry").lower()
|
||||||
|
if prov == "sentry":
|
||||||
|
sentry_cnt += 1
|
||||||
|
elif prov == "glitchtip":
|
||||||
|
glitchtip_cnt += 1
|
||||||
|
|
||||||
|
pr_nums = _parse_pr_numbers(r.get("linked_pr_numbers"))
|
||||||
|
|
||||||
|
links.append(
|
||||||
|
CorrelatedIncidentLink(
|
||||||
|
link_id=int(r.get("link_id", 0)),
|
||||||
|
provider=prov,
|
||||||
|
provider_base_url=r.get("provider_base_url") or "",
|
||||||
|
provider_org=r.get("provider_org") or "",
|
||||||
|
provider_project=r.get("provider_project") or "",
|
||||||
|
provider_issue_id=str(r.get("provider_issue_id") or ""),
|
||||||
|
provider_short_id=r.get("provider_short_id"),
|
||||||
|
provider_permalink=r.get("provider_permalink"),
|
||||||
|
fingerprint=r.get("fingerprint"),
|
||||||
|
gitea_org=r.get("gitea_org") or "Scaled-Tech-Consulting",
|
||||||
|
gitea_repo=r.get("gitea_repo") or "Gitea-Tools",
|
||||||
|
gitea_issue_number=int(r.get("gitea_issue_number", 0)),
|
||||||
|
linked_pr_numbers=pr_nums,
|
||||||
|
last_seen=r.get("last_seen"),
|
||||||
|
event_count=int(r.get("event_count", 1)),
|
||||||
|
created_at=r.get("created_at"),
|
||||||
|
updated_at=r.get("updated_at"),
|
||||||
|
)
|
||||||
|
)
|
||||||
|
|
||||||
|
bridge_active = any(p.bridge_enabled for p in providers)
|
||||||
|
|
||||||
|
return ObservabilitySnapshot(
|
||||||
|
schema_version=OBSERVABILITY_SCHEMA_VERSION,
|
||||||
|
providers=providers,
|
||||||
|
links=links,
|
||||||
|
total_links=len(links),
|
||||||
|
sentry_links_count=sentry_cnt,
|
||||||
|
glitchtip_links_count=glitchtip_cnt,
|
||||||
|
bridge_active=bridge_active,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def snapshot_to_dict(snapshot: ObservabilitySnapshot) -> dict[str, Any]:
|
||||||
|
return snapshot.to_dict()
|
||||||
@@ -0,0 +1,143 @@
|
|||||||
|
"""HTML view renderer for the Sentry/GlitchTip observability console (#649, Phase 4).
|
||||||
|
|
||||||
|
Renders connection status widgets, error correlation links, and gated issue creation
|
||||||
|
affordances over the read-only observability snapshot.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import html
|
||||||
|
from typing import Any
|
||||||
|
|
||||||
|
from webui.layout import render_page
|
||||||
|
from webui.observability_loader import ObservabilitySnapshot, snapshot_to_dict
|
||||||
|
|
||||||
|
|
||||||
|
def _badge(status: str) -> str:
|
||||||
|
st = (status or "").lower()
|
||||||
|
if st == "healthy":
|
||||||
|
return '<span class="badge badge-success">healthy</span>'
|
||||||
|
if st == "disabled":
|
||||||
|
return '<span class="badge badge-warning">disabled (dry-run)</span>'
|
||||||
|
if st in {"missing_token", "not_configured"}:
|
||||||
|
return f'<span class="badge badge-muted">{html.escape(st)}</span>'
|
||||||
|
return f'<span class="badge">{html.escape(st)}</span>'
|
||||||
|
|
||||||
|
|
||||||
|
def _provider_card(p: dict[str, Any]) -> str:
|
||||||
|
name = html.escape(str(p.get("provider", "provider")).upper())
|
||||||
|
base_url = html.escape(str(p.get("base_url", "")))
|
||||||
|
org = html.escape(str(p.get("org", "")))
|
||||||
|
proj = html.escape(str(p.get("project", "")))
|
||||||
|
status_badge = _badge(str(p.get("status", "")))
|
||||||
|
min_events = p.get("min_events_for_issue", 2)
|
||||||
|
lookback = html.escape(str(p.get("lookback", "24h")))
|
||||||
|
bridge_enabled = "yes" if p.get("bridge_enabled") else "no"
|
||||||
|
|
||||||
|
return f"""
|
||||||
|
<div class="card" style="margin-bottom: 1rem; padding: 1rem; border: 1px solid #ccc; border-radius: 6px;">
|
||||||
|
<div style="display: flex; justify-content: space-between; align-items: center;">
|
||||||
|
<h3 style="margin: 0;">{name} Connection</h3>
|
||||||
|
<div>{status_badge}</div>
|
||||||
|
</div>
|
||||||
|
<table style="width: 100%; margin-top: 0.5rem; border-collapse: collapse;">
|
||||||
|
<tr><td><strong>Base URL:</strong></td><td><code>{base_url}</code></td></tr>
|
||||||
|
<tr><td><strong>Scope:</strong></td><td><code>{org} / {proj}</code></td></tr>
|
||||||
|
<tr><td><strong>Bridge Enabled:</strong></td><td><code>{bridge_enabled}</code></td></tr>
|
||||||
|
<tr><td><strong>Min Events for Issue:</strong></td><td><code>{min_events}</code></td></tr>
|
||||||
|
<tr><td><strong>Lookback Window:</strong></td><td><code>{lookback}</code></td></tr>
|
||||||
|
</table>
|
||||||
|
</div>
|
||||||
|
"""
|
||||||
|
|
||||||
|
|
||||||
|
def render_observability_page(snapshot: ObservabilitySnapshot | dict[str, Any]) -> str:
|
||||||
|
"""Render the observability dashboard HTML page."""
|
||||||
|
data = snapshot.to_dict() if isinstance(snapshot, ObservabilitySnapshot) else dict(snapshot)
|
||||||
|
|
||||||
|
providers_raw = data.get("providers", [])
|
||||||
|
provider_cards = "".join(_provider_card(p) for p in providers_raw) if providers_raw else "<p>No providers configured.</p>"
|
||||||
|
|
||||||
|
links = data.get("links", [])
|
||||||
|
link_rows = []
|
||||||
|
|
||||||
|
for l in links:
|
||||||
|
prov = html.escape(str(l.get("provider", "")))
|
||||||
|
p_issue_id = html.escape(str(l.get("provider_issue_id", "")))
|
||||||
|
fingerprint = html.escape(str(l.get("fingerprint") or "—"))
|
||||||
|
g_issue_num = int(l.get("gitea_issue_number", 0))
|
||||||
|
g_org = html.escape(str(l.get("gitea_org", "")))
|
||||||
|
g_repo = html.escape(str(l.get("gitea_repo", "")))
|
||||||
|
g_issue_link = f'<strong>#{g_issue_num}</strong> ({g_org}/{g_repo})'
|
||||||
|
event_cnt = int(l.get("event_count", 1))
|
||||||
|
last_seen = html.escape(str(l.get("last_seen") or "—"))
|
||||||
|
short_id = html.escape(str(l.get("provider_short_id") or p_issue_id))
|
||||||
|
|
||||||
|
link_rows.append(f"""
|
||||||
|
<tr>
|
||||||
|
<td><code>{prov}</code></td>
|
||||||
|
<td><strong>{short_id}</strong><br><small style="color: #666;">id: {p_issue_id}</small></td>
|
||||||
|
<td><code>{fingerprint}</code></td>
|
||||||
|
<td>{g_issue_link}</td>
|
||||||
|
<td>{event_cnt}</td>
|
||||||
|
<td><small>{last_seen}</small></td>
|
||||||
|
</tr>
|
||||||
|
""")
|
||||||
|
|
||||||
|
table_body = "".join(link_rows) if link_rows else '<tr><td colspan="6" style="text-align: center; padding: 1.5rem; color: #666;">No correlated incident links stored. Bridge operates under dry-run default.</td></tr>'
|
||||||
|
|
||||||
|
metrics = data.get("metrics", {})
|
||||||
|
total_links = metrics.get("total_links", 0)
|
||||||
|
sentry_cnt = metrics.get("sentry_links_count", 0)
|
||||||
|
glitchtip_cnt = metrics.get("glitchtip_links_count", 0)
|
||||||
|
|
||||||
|
body_html = f"""
|
||||||
|
<h2>Observability & Incident Bridge (#649)</h2>
|
||||||
|
<p>Read-only console surface for Sentry/GlitchTip provider connections, error correlation,
|
||||||
|
and durable Gitea issue linkage.</p>
|
||||||
|
|
||||||
|
<div class="alert alert-info" style="background: #f0f4f8; padding: 1rem; border-left: 4px solid #0052cc; margin-bottom: 1.5rem;">
|
||||||
|
<strong>ADR Authority Model:</strong> Gitea records durable issue history. Control-plane DB coordinates incident links.
|
||||||
|
Sentry/GlitchTip observe errors. Raw monitoring incidents are <em>never</em> assignable control-plane work items.
|
||||||
|
Durable issue creation is gated and dry-runable via the <code>#612</code> bridge APIs.
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<h3>Provider Connections</h3>
|
||||||
|
<div style="display: grid; grid-template-columns: repeat(auto-fit, minmax(300px, 1fr)); gap: 1rem; margin-bottom: 2rem;">
|
||||||
|
{provider_cards}
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div style="display: flex; justify-content: space-between; align-items: center; margin-bottom: 1rem;">
|
||||||
|
<h3 style="margin: 0;">Correlated Incidents ({total_links})</h3>
|
||||||
|
<div>
|
||||||
|
<span class="badge" style="margin-right: 0.5rem;">Sentry: {sentry_cnt}</span>
|
||||||
|
<span class="badge">GlitchTip: {glitchtip_cnt}</span>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<table class="table" style="width: 100%; border-collapse: collapse; border: 1px solid #ddd;">
|
||||||
|
<thead>
|
||||||
|
<tr style="background: #f9f9f9; text-align: left;">
|
||||||
|
<th style="padding: 0.5rem; border-bottom: 2px solid #ddd;">Provider</th>
|
||||||
|
<th style="padding: 0.5rem; border-bottom: 2px solid #ddd;">Incident ID</th>
|
||||||
|
<th style="padding: 0.5rem; border-bottom: 2px solid #ddd;">Fingerprint</th>
|
||||||
|
<th style="padding: 0.5rem; border-bottom: 2px solid #ddd;">Gitea Issue Link</th>
|
||||||
|
<th style="padding: 0.5rem; border-bottom: 2px solid #ddd;">Events</th>
|
||||||
|
<th style="padding: 0.5rem; border-bottom: 2px solid #ddd;">Last Seen</th>
|
||||||
|
</tr>
|
||||||
|
</thead>
|
||||||
|
<tbody>
|
||||||
|
{table_body}
|
||||||
|
</tbody>
|
||||||
|
</table>
|
||||||
|
|
||||||
|
<div style="margin-top: 2rem; padding: 1rem; background: #fafafa; border: 1px solid #eee; border-radius: 4px;">
|
||||||
|
<h4 style="margin-top: 0;">Reconcile & Link Controls (Gated)</h4>
|
||||||
|
<p style="margin-bottom: 0.5rem; color: #555;">
|
||||||
|
Create or reconcile durable Gitea issues from provider observations using the <code>#612</code> incident bridge:
|
||||||
|
</p>
|
||||||
|
<code>mcp call gitea_observability_reconcile_incident --provider sentry --apply false</code>
|
||||||
|
</div>
|
||||||
|
"""
|
||||||
|
|
||||||
|
return render_page(title="Observability", body_html=body_html)
|
||||||
Reference in New Issue
Block a user