Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
e0536d344f | ||
|
|
89657a06c4 | ||
|
|
ba3ea3012c | ||
|
|
ef14622ba0 | ||
|
|
a3f8f67c93 | ||
|
|
6d0015cabc | ||
|
|
67cd2da561 | ||
|
|
fe259e6d38 | ||
|
|
e9f6d68bd7 | ||
|
|
9301739910 | ||
|
|
b3859f6dad | ||
|
|
3b2b4e1dca | ||
|
|
b9ba43a5bf | ||
|
|
a1e5a4af8c | ||
|
|
188e83c4d6 | ||
|
|
db5ed6042b | ||
|
|
a942afe6c4 | ||
|
|
2d95e0fcc6 | ||
|
|
8ba1c5b87c | ||
|
|
df58b5fb90 | ||
|
|
a20975688d | ||
|
|
25bc2a3291 |
@@ -0,0 +1,976 @@
|
|||||||
|
"""Sanctioned author issue worktree bootstrap for allocated issues (#850).
|
||||||
|
|
||||||
|
Bootstraps an allocated author branch, canonical worktree under ``branches/``,
|
||||||
|
worktree registration, issue lock, and lease/assignment binding without
|
||||||
|
caller-side Git, Bash, or helper scripts.
|
||||||
|
|
||||||
|
Features:
|
||||||
|
1. Durable phase journal with read-after-write evidence for every phase.
|
||||||
|
2. Idempotent replay handling via idempotency keys.
|
||||||
|
3. Authoritative expected-base / concurrency-pin validation.
|
||||||
|
4. Typed stale-pin refusal without silent rebasing or repointing.
|
||||||
|
5. Canonical branches-root enforcement (path MUST be inside branches/).
|
||||||
|
6. Preexisting work preservation (dirty tracked/untracked check, foreign ownership refusal).
|
||||||
|
7. Compensating recovery limited strictly to artifacts created by this transition.
|
||||||
|
8. Satisfiable exact_next_action for MCP scheduled workers.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import shutil
|
||||||
|
import subprocess
|
||||||
|
from typing import Any, Mapping
|
||||||
|
|
||||||
|
import author_mutation_worktree
|
||||||
|
import issue_lock_store
|
||||||
|
import issue_lock_worktree
|
||||||
|
import lease_lifecycle
|
||||||
|
from reviewer_worktree import parse_dirty_tracked_files
|
||||||
|
import task_capability_map
|
||||||
|
|
||||||
|
BOOTSTRAP_TASKS = frozenset(
|
||||||
|
{
|
||||||
|
"bootstrap_author_issue_worktree",
|
||||||
|
"gitea_bootstrap_author_issue_worktree",
|
||||||
|
}
|
||||||
|
)
|
||||||
|
|
||||||
|
PHASE_1_REQUEST_ACCEPTED = "1_request_accepted"
|
||||||
|
PHASE_2_BRANCH_CONFIRMED = "2_branch_confirmed"
|
||||||
|
PHASE_3_PATH_RESERVED = "3_path_reserved"
|
||||||
|
PHASE_4_WORKTREE_CONFIRMED = "4_worktree_confirmed"
|
||||||
|
PHASE_5_REGISTRATION_VERIFIED = "5_registration_verified"
|
||||||
|
PHASE_6_STATE_ESTABLISHED = "6_state_established"
|
||||||
|
PHASE_7_TRANSITION_COMPLETED = "7_transition_completed"
|
||||||
|
PHASE_COMPENSATING_RECOVERY = "compensating_recovery"
|
||||||
|
|
||||||
|
JOURNAL_DIR_NAME = "bootstrap-journals"
|
||||||
|
|
||||||
|
|
||||||
|
def is_author_issue_bootstrap_task(task: str | None) -> bool:
|
||||||
|
"""True when *task* is the author issue worktree bootstrap task."""
|
||||||
|
return (task or "").strip() in BOOTSTRAP_TASKS
|
||||||
|
|
||||||
|
|
||||||
|
def get_journal_dir(override: str | None = None) -> str:
|
||||||
|
"""Return the root directory for durable bootstrap phase journals."""
|
||||||
|
if override:
|
||||||
|
path = override
|
||||||
|
elif os.environ.get("GITEA_BOOTSTRAP_JOURNAL_DIR"):
|
||||||
|
path = os.environ["GITEA_BOOTSTRAP_JOURNAL_DIR"]
|
||||||
|
else:
|
||||||
|
cache_dir = os.path.expanduser("~/.cache/gitea-tools")
|
||||||
|
path = os.path.join(cache_dir, JOURNAL_DIR_NAME)
|
||||||
|
os.makedirs(path, exist_ok=True)
|
||||||
|
return path
|
||||||
|
|
||||||
|
|
||||||
|
def _journal_file_path(idempotency_key: str, journal_dir: str | None = None) -> str:
|
||||||
|
safe_key = "".join(
|
||||||
|
c if c.isalnum() or c in ("-", "_", ".") else "_"
|
||||||
|
for c in idempotency_key
|
||||||
|
)
|
||||||
|
return os.path.join(get_journal_dir(journal_dir), f"{safe_key}.json")
|
||||||
|
|
||||||
|
|
||||||
|
def load_phase_journal(
|
||||||
|
idempotency_key: str, journal_dir: str | None = None
|
||||||
|
) -> dict[str, Any] | None:
|
||||||
|
"""Load a durable phase journal if it exists."""
|
||||||
|
path = _journal_file_path(idempotency_key, journal_dir=journal_dir)
|
||||||
|
if not os.path.isfile(path):
|
||||||
|
return None
|
||||||
|
try:
|
||||||
|
with open(path, "r", encoding="utf-8") as f:
|
||||||
|
return json.load(f)
|
||||||
|
except Exception:
|
||||||
|
return None
|
||||||
|
|
||||||
|
|
||||||
|
def save_phase_journal(
|
||||||
|
journal: dict[str, Any], journal_dir: str | None = None
|
||||||
|
) -> None:
|
||||||
|
"""Persist a durable phase journal with write-through file sync."""
|
||||||
|
key = journal["idempotency_key"]
|
||||||
|
path = _journal_file_path(key, journal_dir=journal_dir)
|
||||||
|
tmp_path = f"{path}.tmp.{os.getpid()}"
|
||||||
|
with open(tmp_path, "w", encoding="utf-8") as f:
|
||||||
|
json.dump(journal, f, indent=2, sort_keys=True)
|
||||||
|
os.replace(tmp_path, path)
|
||||||
|
|
||||||
|
|
||||||
|
def derive_default_idempotency_key(
|
||||||
|
remote: str,
|
||||||
|
org: str | None,
|
||||||
|
repo: str | None,
|
||||||
|
issue_number: int,
|
||||||
|
assignment_id: str | None = None,
|
||||||
|
lease_id: str | None = None,
|
||||||
|
) -> str:
|
||||||
|
parts = [
|
||||||
|
"bootstrap",
|
||||||
|
(remote or "prgs").strip(),
|
||||||
|
(org or "Scaled-Tech-Consulting").strip(),
|
||||||
|
(repo or "Gitea-Tools").strip(),
|
||||||
|
f"issue-{issue_number}",
|
||||||
|
]
|
||||||
|
if assignment_id:
|
||||||
|
parts.append(assignment_id.strip())
|
||||||
|
if lease_id:
|
||||||
|
parts.append(lease_id.strip())
|
||||||
|
return ":".join(parts)
|
||||||
|
|
||||||
|
|
||||||
|
def run_compensating_recovery(
|
||||||
|
journal: dict[str, Any],
|
||||||
|
canonical_repo_root: str,
|
||||||
|
journal_dir: str | None = None,
|
||||||
|
) -> dict[str, Any]:
|
||||||
|
"""Execute compensating recovery for artifacts created by this transition only."""
|
||||||
|
artifacts = journal.get("artifacts_created") or {}
|
||||||
|
pending = journal.get("pending_creations") or {}
|
||||||
|
rolled_back: list[str] = []
|
||||||
|
worktree_path = journal.get("worktree_path")
|
||||||
|
branch_name = journal.get("branch_name")
|
||||||
|
|
||||||
|
# Roll back issue lock if created
|
||||||
|
if artifacts.get("lock_created") or pending.get("lock"):
|
||||||
|
issue_num = journal.get("issue_number")
|
||||||
|
session_id = journal.get("owner_session")
|
||||||
|
if issue_num and session_id:
|
||||||
|
try:
|
||||||
|
issue_lock_store.release_session_lock(
|
||||||
|
issue_number=issue_num,
|
||||||
|
session=session_id,
|
||||||
|
lock_dir=journal_dir,
|
||||||
|
)
|
||||||
|
rolled_back.append(f"lock:issue-{issue_num}")
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
artifacts["lock_created"] = False
|
||||||
|
|
||||||
|
worktree_created = (
|
||||||
|
artifacts.get("worktree_registered")
|
||||||
|
or artifacts.get("worktree_dir_created")
|
||||||
|
or (pending.get("worktree_path") == worktree_path and worktree_path)
|
||||||
|
)
|
||||||
|
|
||||||
|
if worktree_created and worktree_path:
|
||||||
|
if os.path.exists(worktree_path):
|
||||||
|
# Re-verify cleanliness before destructive removal (F-4)
|
||||||
|
porc_res = subprocess.run(
|
||||||
|
["git", "-C", worktree_path, "status", "--porcelain"],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
is_dirty = porc_res.returncode == 0 and bool(porc_res.stdout.strip())
|
||||||
|
if is_dirty:
|
||||||
|
rolled_back.append(f"worktree_path_preserved_dirty:{worktree_path}")
|
||||||
|
else:
|
||||||
|
try:
|
||||||
|
subprocess.run(
|
||||||
|
[
|
||||||
|
"git",
|
||||||
|
"-C",
|
||||||
|
canonical_repo_root,
|
||||||
|
"worktree",
|
||||||
|
"remove",
|
||||||
|
"--force",
|
||||||
|
worktree_path,
|
||||||
|
],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
if os.path.exists(worktree_path):
|
||||||
|
shutil.rmtree(worktree_path, ignore_errors=True)
|
||||||
|
try:
|
||||||
|
subprocess.run(
|
||||||
|
["git", "-C", canonical_repo_root, "worktree", "prune"],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
rolled_back.append(f"worktree_path:{worktree_path}")
|
||||||
|
else:
|
||||||
|
rolled_back.append(f"worktree_path:{worktree_path}")
|
||||||
|
|
||||||
|
branch_created = (
|
||||||
|
artifacts.get("branch_created")
|
||||||
|
or (pending.get("branch_name") == branch_name and branch_name)
|
||||||
|
)
|
||||||
|
|
||||||
|
if branch_created and branch_name:
|
||||||
|
try:
|
||||||
|
res = subprocess.run(
|
||||||
|
[
|
||||||
|
"git",
|
||||||
|
"-C",
|
||||||
|
canonical_repo_root,
|
||||||
|
"rev-parse",
|
||||||
|
"--verify",
|
||||||
|
branch_name,
|
||||||
|
],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
if res.returncode == 0:
|
||||||
|
# Check for author commits on branch before branch deletion (F-4)
|
||||||
|
resolved_base = journal.get("resolved_base_sha") or "master"
|
||||||
|
rev_list_res = subprocess.run(
|
||||||
|
[
|
||||||
|
"git",
|
||||||
|
"-C",
|
||||||
|
canonical_repo_root,
|
||||||
|
"rev-list",
|
||||||
|
f"{resolved_base}..{branch_name}",
|
||||||
|
],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
has_commits = rev_list_res.returncode == 0 and bool(rev_list_res.stdout.strip())
|
||||||
|
if has_commits:
|
||||||
|
rolled_back.append(f"branch_preserved_commits:{branch_name}")
|
||||||
|
else:
|
||||||
|
subprocess.run(
|
||||||
|
[
|
||||||
|
"git",
|
||||||
|
"-C",
|
||||||
|
canonical_repo_root,
|
||||||
|
"branch",
|
||||||
|
"-D",
|
||||||
|
branch_name,
|
||||||
|
],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
rolled_back.append(f"branch:{branch_name}")
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
|
||||||
|
recovery_info = {
|
||||||
|
"executed": True,
|
||||||
|
"rolled_back": rolled_back,
|
||||||
|
"reason": journal.get("failure_reason"),
|
||||||
|
}
|
||||||
|
journal["compensating_recovery"] = recovery_info
|
||||||
|
journal["current_phase"] = PHASE_COMPENSATING_RECOVERY
|
||||||
|
save_phase_journal(journal, journal_dir=journal_dir)
|
||||||
|
return recovery_info
|
||||||
|
|
||||||
|
|
||||||
|
def assess_author_issue_bootstrap(
|
||||||
|
*,
|
||||||
|
workspace_path: str,
|
||||||
|
canonical_repo_root: str,
|
||||||
|
current_branch: str | None = None,
|
||||||
|
head_sha: str | None = None,
|
||||||
|
porcelain_status: str = "",
|
||||||
|
remote_master_sha: str | None = None,
|
||||||
|
remote_master_sha_error: str | None = None,
|
||||||
|
task: str | None = None,
|
||||||
|
) -> dict[str, Any]:
|
||||||
|
"""Assess whether author issue worktree bootstrap may proceed from control or worktree root."""
|
||||||
|
root = os.path.realpath(canonical_repo_root or "")
|
||||||
|
workspace = os.path.realpath(workspace_path or root or ".")
|
||||||
|
branch = (current_branch or "").strip()
|
||||||
|
dirty = parse_dirty_tracked_files(porcelain_status or "")
|
||||||
|
under_branches = (
|
||||||
|
author_mutation_worktree.is_path_under_branches(workspace, root)
|
||||||
|
if root
|
||||||
|
else False
|
||||||
|
)
|
||||||
|
|
||||||
|
if not is_author_issue_bootstrap_task(task):
|
||||||
|
return {
|
||||||
|
"not_applicable": True,
|
||||||
|
"allowed": False,
|
||||||
|
"block": False,
|
||||||
|
"proven": False,
|
||||||
|
"reasons": ["task is not author_issue_bootstrap"],
|
||||||
|
}
|
||||||
|
|
||||||
|
if under_branches:
|
||||||
|
return {
|
||||||
|
"not_applicable": False,
|
||||||
|
"allowed": True,
|
||||||
|
"block": False,
|
||||||
|
"proven": True,
|
||||||
|
"bootstrap_path": "existing_branches_worktree",
|
||||||
|
"reasons": [
|
||||||
|
"workspace is already a registered worktree under branches/"
|
||||||
|
],
|
||||||
|
}
|
||||||
|
|
||||||
|
reasons: list[str] = []
|
||||||
|
if workspace != root:
|
||||||
|
reasons.append(
|
||||||
|
"bootstrap requires workspace to be canonical control checkout or branches/ worktree"
|
||||||
|
)
|
||||||
|
if branch not in author_mutation_worktree.BASE_BRANCHES:
|
||||||
|
reasons.append(
|
||||||
|
f"control checkout branch '{branch}' is not an accepted base branch "
|
||||||
|
f"({', '.join(sorted(author_mutation_worktree.BASE_BRANCHES))})"
|
||||||
|
)
|
||||||
|
if dirty:
|
||||||
|
reasons.append(
|
||||||
|
f"control checkout has tracked local edits: {', '.join(dirty[:5])}"
|
||||||
|
)
|
||||||
|
|
||||||
|
if remote_master_sha_error:
|
||||||
|
reasons.append(
|
||||||
|
f"could not verify live master tip: {remote_master_sha_error}"
|
||||||
|
)
|
||||||
|
elif remote_master_sha and head_sha:
|
||||||
|
h = head_sha.strip().lower()
|
||||||
|
rm = remote_master_sha.strip().lower()
|
||||||
|
if h != rm:
|
||||||
|
reasons.append(
|
||||||
|
f"control checkout HEAD ({h[:12]}) != live master tip ({rm[:12]})"
|
||||||
|
)
|
||||||
|
|
||||||
|
if reasons:
|
||||||
|
return {
|
||||||
|
"not_applicable": False,
|
||||||
|
"allowed": False,
|
||||||
|
"block": True,
|
||||||
|
"proven": False,
|
||||||
|
"reasons": reasons,
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
"not_applicable": False,
|
||||||
|
"allowed": True,
|
||||||
|
"block": False,
|
||||||
|
"proven": True,
|
||||||
|
"bootstrap_path": "clean_canonical_control_checkout",
|
||||||
|
"reasons": [
|
||||||
|
"control checkout is clean on accepted base branch matching live master"
|
||||||
|
],
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
import fcntl
|
||||||
|
import stat
|
||||||
|
|
||||||
|
|
||||||
|
class BootstrapTransitionLock:
|
||||||
|
"""Inter-process file lock scoped to the transition identity / idempotency key."""
|
||||||
|
|
||||||
|
def __init__(self, idempotency_key: str, journal_dir: str | None = None):
|
||||||
|
safe_key = "".join(
|
||||||
|
c if c.isalnum() or c in ("-", "_", ".") else "_"
|
||||||
|
for c in idempotency_key
|
||||||
|
)
|
||||||
|
lock_dir = os.path.realpath(get_journal_dir(journal_dir))
|
||||||
|
if not os.path.isdir(lock_dir):
|
||||||
|
raise RuntimeError(f"Lock directory '{lock_dir}' does not exist or is not a directory")
|
||||||
|
|
||||||
|
raw_lock_path = os.path.abspath(os.path.join(lock_dir, f"{safe_key}.lock"))
|
||||||
|
try:
|
||||||
|
common = os.path.commonpath([lock_dir, os.path.dirname(raw_lock_path)])
|
||||||
|
except Exception:
|
||||||
|
common = None
|
||||||
|
if common != lock_dir:
|
||||||
|
raise RuntimeError(f"Lock path '{raw_lock_path}' escapes canonical lock directory '{lock_dir}'")
|
||||||
|
|
||||||
|
self.lock_path = raw_lock_path
|
||||||
|
self.fd = None
|
||||||
|
|
||||||
|
def __enter__(self):
|
||||||
|
if os.path.islink(self.lock_path):
|
||||||
|
raise RuntimeError(f"Refusing lock acquisition: lock path '{self.lock_path}' is a symlink")
|
||||||
|
|
||||||
|
flags = os.O_RDWR | os.O_CREAT
|
||||||
|
if hasattr(os, "O_NOFOLLOW"):
|
||||||
|
flags |= os.O_NOFOLLOW
|
||||||
|
if hasattr(os, "O_CLOEXEC"):
|
||||||
|
flags |= os.O_CLOEXEC
|
||||||
|
|
||||||
|
try:
|
||||||
|
fd = os.open(self.lock_path, flags, 0o600)
|
||||||
|
except OSError as exc:
|
||||||
|
raise RuntimeError(f"Failed to open lock file safely '{self.lock_path}': {exc}") from exc
|
||||||
|
|
||||||
|
st = os.fstat(fd)
|
||||||
|
if not stat.S_ISREG(st.st_mode):
|
||||||
|
os.close(fd)
|
||||||
|
raise RuntimeError(f"Lock target '{self.lock_path}' is not a regular file")
|
||||||
|
|
||||||
|
self.fd = fd
|
||||||
|
fcntl.flock(self.fd, fcntl.LOCK_EX)
|
||||||
|
return self
|
||||||
|
|
||||||
|
def __exit__(self, exc_type, exc_val, exc_tb):
|
||||||
|
if self.fd is not None:
|
||||||
|
try:
|
||||||
|
fcntl.flock(self.fd, fcntl.LOCK_UN)
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
try:
|
||||||
|
os.close(self.fd)
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
self.fd = None
|
||||||
|
|
||||||
|
|
||||||
|
def bootstrap_author_issue_worktree(
|
||||||
|
*,
|
||||||
|
issue_number: int,
|
||||||
|
canonical_repo_root: str,
|
||||||
|
assignment_id: str | None = None,
|
||||||
|
lease_id: str | None = None,
|
||||||
|
expected_base_sha: str | None = None,
|
||||||
|
branch_name: str | None = None,
|
||||||
|
worktree_path: str | None = None,
|
||||||
|
idempotency_key: str | None = None,
|
||||||
|
remote: str = "prgs",
|
||||||
|
host: str | None = None,
|
||||||
|
org: str | None = "Scaled-Tech-Consulting",
|
||||||
|
repo: str | None = "Gitea-Tools",
|
||||||
|
active_identity: str | None = "jcwalker3",
|
||||||
|
active_profile: str | None = "prgs-author",
|
||||||
|
owner_session: str | None = None,
|
||||||
|
lock_dir: str | None = None,
|
||||||
|
dry_run: bool = False,
|
||||||
|
) -> dict[str, Any]:
|
||||||
|
"""Execute the sanctioned author issue worktree bootstrap transition."""
|
||||||
|
root = os.path.realpath(canonical_repo_root)
|
||||||
|
|
||||||
|
session = (owner_session or "").strip()
|
||||||
|
if not session:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "missing_owner_session",
|
||||||
|
"message": "Missing required owner_session parameter (fail closed). Session identifier cannot be fabricated or defaulted.",
|
||||||
|
"exact_next_action": (
|
||||||
|
"Pass explicit owner_session resolved from gitea_whoami or session context."
|
||||||
|
),
|
||||||
|
}
|
||||||
|
|
||||||
|
if active_identity is None or not str(active_identity).strip():
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "missing_active_identity",
|
||||||
|
"message": "Missing required active_identity parameter (fail closed). Identity cannot be fabricated or defaulted.",
|
||||||
|
"exact_next_action": "Pass explicit active_identity resolved from gitea_whoami.",
|
||||||
|
}
|
||||||
|
identity = str(active_identity).strip()
|
||||||
|
|
||||||
|
if active_profile is None or not str(active_profile).strip():
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "missing_active_profile",
|
||||||
|
"message": "Missing required active_profile parameter (fail closed). Profile cannot be fabricated or defaulted.",
|
||||||
|
"exact_next_action": "Pass explicit active_profile resolved from gitea_whoami.",
|
||||||
|
}
|
||||||
|
profile = str(active_profile).strip()
|
||||||
|
|
||||||
|
# Derive standard inputs
|
||||||
|
expected_pattern = f"issue-{issue_number}"
|
||||||
|
target_branch = (branch_name or "").strip()
|
||||||
|
if not target_branch:
|
||||||
|
target_branch = f"fix/issue-{issue_number}-native-mcp-bootstrap"
|
||||||
|
elif expected_pattern not in target_branch:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "invalid_branch_name",
|
||||||
|
"message": (
|
||||||
|
f"Branch name '{target_branch}' must contain issue pattern '{expected_pattern}'"
|
||||||
|
),
|
||||||
|
"exact_next_action": (
|
||||||
|
f"Supply a branch_name containing '{expected_pattern}', e.g., 'fix/issue-{issue_number}-...'"
|
||||||
|
),
|
||||||
|
}
|
||||||
|
|
||||||
|
worktree_name = target_branch.replace("/", "-")
|
||||||
|
target_worktree = (worktree_path or "").strip()
|
||||||
|
if not target_worktree:
|
||||||
|
target_worktree = os.path.join(root, "branches", worktree_name)
|
||||||
|
target_worktree = os.path.realpath(os.path.abspath(target_worktree))
|
||||||
|
|
||||||
|
key = (idempotency_key or "").strip()
|
||||||
|
if not key:
|
||||||
|
key = derive_default_idempotency_key(
|
||||||
|
remote=remote,
|
||||||
|
org=org,
|
||||||
|
repo=repo,
|
||||||
|
issue_number=issue_number,
|
||||||
|
assignment_id=assignment_id,
|
||||||
|
lease_id=lease_id,
|
||||||
|
)
|
||||||
|
|
||||||
|
# Acquire cross-process file lock scoped to the idempotency key / transition identity
|
||||||
|
with BootstrapTransitionLock(key, journal_dir=lock_dir):
|
||||||
|
# Idempotency check
|
||||||
|
existing = load_phase_journal(key, journal_dir=lock_dir)
|
||||||
|
if existing and existing.get("completed"):
|
||||||
|
if (
|
||||||
|
existing.get("issue_number") == issue_number
|
||||||
|
and existing.get("branch_name") == target_branch
|
||||||
|
and os.path.realpath(existing.get("worktree_path", ""))
|
||||||
|
== target_worktree
|
||||||
|
):
|
||||||
|
return {
|
||||||
|
"success": True,
|
||||||
|
"replayed": True,
|
||||||
|
"message": (
|
||||||
|
f"Idempotent replay: worktree for issue #{issue_number} already bootstrapped at {target_worktree}"
|
||||||
|
),
|
||||||
|
"issue_number": issue_number,
|
||||||
|
"branch_name": target_branch,
|
||||||
|
"worktree_path": target_worktree,
|
||||||
|
"base_sha": existing.get("resolved_base_sha"),
|
||||||
|
"lease_id": existing.get("lease_id"),
|
||||||
|
"assignment_id": existing.get("assignment_id"),
|
||||||
|
"idempotency_key": key,
|
||||||
|
"phase_journal": existing,
|
||||||
|
"exact_next_action": (
|
||||||
|
"Call gitea_whoami, then gitea_resolve_task_capability(task='work_issue') "
|
||||||
|
"and proceed with author implementation in the bootstrapped worktree."
|
||||||
|
),
|
||||||
|
}
|
||||||
|
else:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "incompatible_idempotency_replay",
|
||||||
|
"message": (
|
||||||
|
f"Idempotency key '{key}' already exists with incompatible parameters "
|
||||||
|
f"(stored: {existing.get('branch_name')}, {existing.get('worktree_path')}; "
|
||||||
|
f"requested: {target_branch}, {target_worktree})"
|
||||||
|
),
|
||||||
|
"exact_next_action": (
|
||||||
|
"Supply a unique idempotency_key or pass compatible parameters."
|
||||||
|
),
|
||||||
|
}
|
||||||
|
|
||||||
|
# Initialize or resume Phase Journal
|
||||||
|
if existing:
|
||||||
|
journal = existing
|
||||||
|
artifacts = journal.setdefault("artifacts_created", {})
|
||||||
|
artifacts.setdefault("branch_created", False)
|
||||||
|
artifacts.setdefault("worktree_dir_created", False)
|
||||||
|
artifacts.setdefault("worktree_registered", False)
|
||||||
|
artifacts.setdefault("lock_created", False)
|
||||||
|
else:
|
||||||
|
journal = {
|
||||||
|
"idempotency_key": key,
|
||||||
|
"issue_number": issue_number,
|
||||||
|
"assignment_id": assignment_id,
|
||||||
|
"lease_id": lease_id,
|
||||||
|
"expected_base_sha": expected_base_sha,
|
||||||
|
"resolved_base_sha": None,
|
||||||
|
"branch_name": target_branch,
|
||||||
|
"worktree_path": target_worktree,
|
||||||
|
"active_identity": identity,
|
||||||
|
"active_profile": profile,
|
||||||
|
"owner_session": session,
|
||||||
|
"remote": remote,
|
||||||
|
"org": org,
|
||||||
|
"repo": repo,
|
||||||
|
"phases": {},
|
||||||
|
"artifacts_created": {
|
||||||
|
"branch_created": False,
|
||||||
|
"worktree_dir_created": False,
|
||||||
|
"worktree_registered": False,
|
||||||
|
"lock_created": False,
|
||||||
|
},
|
||||||
|
"current_phase": PHASE_1_REQUEST_ACCEPTED,
|
||||||
|
"completed": False,
|
||||||
|
}
|
||||||
|
|
||||||
|
# Fetch current live master SHA
|
||||||
|
try:
|
||||||
|
rev_res = subprocess.run(
|
||||||
|
["git", "-C", root, "rev-parse", "HEAD"],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=True,
|
||||||
|
)
|
||||||
|
live_master_sha = rev_res.stdout.strip()
|
||||||
|
except Exception as exc:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "git_rev_parse_failed",
|
||||||
|
"message": f"Could not determine repository HEAD: {exc}",
|
||||||
|
"exact_next_action": "Verify repository git state and retry.",
|
||||||
|
}
|
||||||
|
|
||||||
|
# Phase 1: REQUEST_ACCEPTED & Concurrency Pin Check
|
||||||
|
if expected_base_sha:
|
||||||
|
exp_norm = expected_base_sha.strip().lower()
|
||||||
|
live_norm = live_master_sha.lower()
|
||||||
|
if exp_norm != live_norm:
|
||||||
|
journal["failure_reason"] = (
|
||||||
|
f"stale concurrency pin: expected {exp_norm[:12]} != live {live_norm[:12]}"
|
||||||
|
)
|
||||||
|
save_phase_journal(journal, journal_dir=lock_dir)
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "stale_concurrency_pin",
|
||||||
|
"message": (
|
||||||
|
f"Expected base SHA {exp_norm[:12]} does not match live master SHA {live_norm[:12]} (fail closed)."
|
||||||
|
),
|
||||||
|
"expected_base_sha": expected_base_sha,
|
||||||
|
"live_master_sha": live_master_sha,
|
||||||
|
"exact_next_action": (
|
||||||
|
"Re-evaluate assignment against current live master SHA and retry with updated expected_base_sha."
|
||||||
|
),
|
||||||
|
}
|
||||||
|
|
||||||
|
journal["resolved_base_sha"] = live_master_sha
|
||||||
|
journal["phases"][PHASE_1_REQUEST_ACCEPTED] = {
|
||||||
|
"status": "completed",
|
||||||
|
"live_master_sha": live_master_sha,
|
||||||
|
"expected_base_sha": expected_base_sha,
|
||||||
|
}
|
||||||
|
journal["current_phase"] = PHASE_2_BRANCH_CONFIRMED
|
||||||
|
save_phase_journal(journal, journal_dir=lock_dir)
|
||||||
|
|
||||||
|
if dry_run:
|
||||||
|
return {
|
||||||
|
"success": True,
|
||||||
|
"dry_run": True,
|
||||||
|
"message": f"Dry-run: validated bootstrap intent for issue #{issue_number}",
|
||||||
|
"issue_number": issue_number,
|
||||||
|
"branch_name": target_branch,
|
||||||
|
"worktree_path": target_worktree,
|
||||||
|
"base_sha": live_master_sha,
|
||||||
|
"phase_journal": journal,
|
||||||
|
"exact_next_action": "Run without dry_run=True to execute bootstrap.",
|
||||||
|
}
|
||||||
|
|
||||||
|
# Phase 2: BRANCH_CONFIRMED
|
||||||
|
was_branch_created_previously = journal["artifacts_created"].get("branch_created", False)
|
||||||
|
pending_branch = (journal.get("pending_creations") or {}).get("branch_name")
|
||||||
|
|
||||||
|
branch_check = subprocess.run(
|
||||||
|
["git", "-C", root, "rev-parse", "--verify", target_branch],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
if branch_check.returncode == 0:
|
||||||
|
branch_head = branch_check.stdout.strip()
|
||||||
|
# Verify branch head descends from base
|
||||||
|
anc_check = subprocess.run(
|
||||||
|
[
|
||||||
|
"git",
|
||||||
|
"-C",
|
||||||
|
root,
|
||||||
|
"merge-base",
|
||||||
|
"--is-ancestor",
|
||||||
|
live_master_sha,
|
||||||
|
branch_head,
|
||||||
|
],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
if anc_check.returncode != 0 and branch_head.lower() != live_master_sha.lower():
|
||||||
|
# F-8: Check if branch shares a common ancestor with live master
|
||||||
|
mb_check = subprocess.run(
|
||||||
|
["git", "-C", root, "merge-base", live_master_sha, branch_head],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
if mb_check.returncode != 0 or not mb_check.stdout.strip():
|
||||||
|
journal["failure_reason"] = (
|
||||||
|
f"existing branch '{target_branch}' HEAD ({branch_head[:12]}) is incompatible with live master ({live_master_sha[:12]})"
|
||||||
|
)
|
||||||
|
save_phase_journal(journal, journal_dir=lock_dir)
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "incompatible_existing_branch",
|
||||||
|
"message": (
|
||||||
|
f"Existing branch '{target_branch}' HEAD ({branch_head[:12]}) is incompatible with live master ({live_master_sha[:12]})."
|
||||||
|
),
|
||||||
|
"exact_next_action": (
|
||||||
|
"Inspect or sync the existing branch with master before bootstrapping."
|
||||||
|
),
|
||||||
|
}
|
||||||
|
# Preserve creation provenance monotonically across interruption and replay
|
||||||
|
if was_branch_created_previously or pending_branch == target_branch:
|
||||||
|
journal["artifacts_created"]["branch_created"] = True
|
||||||
|
else:
|
||||||
|
journal["artifacts_created"]["branch_created"] = False
|
||||||
|
else:
|
||||||
|
# Persist creation intent/provenance to disk BEFORE executing external mutation
|
||||||
|
journal.setdefault("pending_creations", {})["branch_name"] = target_branch
|
||||||
|
journal["artifacts_created"]["branch_created"] = True
|
||||||
|
save_phase_journal(journal, journal_dir=lock_dir)
|
||||||
|
|
||||||
|
# Create branch
|
||||||
|
create_res = subprocess.run(
|
||||||
|
["git", "-C", root, "branch", target_branch, live_master_sha],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
if create_res.returncode != 0:
|
||||||
|
journal["artifacts_created"]["branch_created"] = False
|
||||||
|
journal.get("pending_creations", {}).pop("branch_name", None)
|
||||||
|
journal["failure_reason"] = (
|
||||||
|
f"failed to create git branch '{target_branch}': {create_res.stderr.strip()}"
|
||||||
|
)
|
||||||
|
save_phase_journal(journal, journal_dir=lock_dir)
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "branch_creation_failed",
|
||||||
|
"message": f"Failed to create git branch '{target_branch}': {create_res.stderr.strip()}",
|
||||||
|
"exact_next_action": "Verify branch availability and retry.",
|
||||||
|
}
|
||||||
|
|
||||||
|
journal["phases"][PHASE_2_BRANCH_CONFIRMED] = {
|
||||||
|
"status": "completed",
|
||||||
|
"branch_name": target_branch,
|
||||||
|
"created": journal["artifacts_created"]["branch_created"],
|
||||||
|
}
|
||||||
|
journal["current_phase"] = PHASE_3_PATH_RESERVED
|
||||||
|
save_phase_journal(journal, journal_dir=lock_dir)
|
||||||
|
|
||||||
|
# Phase 3: PATH_RESERVED & Phase 4: WORKTREE_CONFIRMED
|
||||||
|
if not author_mutation_worktree.is_path_under_branches(
|
||||||
|
target_worktree, root
|
||||||
|
):
|
||||||
|
journal["failure_reason"] = (
|
||||||
|
f"target_worktree '{target_worktree}' is outside canonical branches/ root"
|
||||||
|
)
|
||||||
|
run_compensating_recovery(journal, root, journal_dir=lock_dir)
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "path_outside_canonical_branches_root",
|
||||||
|
"message": (
|
||||||
|
f"Worktree path '{target_worktree}' is outside canonical branches/ root (fail closed)."
|
||||||
|
),
|
||||||
|
"exact_next_action": (
|
||||||
|
"Provide a worktree_path inside canonical branches/ root, e.g., 'branches/issue-...'"
|
||||||
|
),
|
||||||
|
}
|
||||||
|
|
||||||
|
was_dir_created_previously = journal["artifacts_created"].get("worktree_dir_created", False)
|
||||||
|
was_registered_previously = journal["artifacts_created"].get("worktree_registered", False)
|
||||||
|
pending_wt = (journal.get("pending_creations") or {}).get("worktree_path")
|
||||||
|
|
||||||
|
dir_exists = os.path.exists(target_worktree)
|
||||||
|
if dir_exists:
|
||||||
|
# Check porcelain directly
|
||||||
|
porc_res = subprocess.run(
|
||||||
|
["git", "-C", target_worktree, "status", "--porcelain"],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
dirty = (
|
||||||
|
parse_dirty_tracked_files(porc_res.stdout)
|
||||||
|
if porc_res.returncode == 0
|
||||||
|
else []
|
||||||
|
)
|
||||||
|
if dirty or (porc_res.returncode == 0 and porc_res.stdout.strip()):
|
||||||
|
journal["failure_reason"] = (
|
||||||
|
f"target worktree '{target_worktree}' contains dirty tracked/untracked files"
|
||||||
|
)
|
||||||
|
run_compensating_recovery(journal, root, journal_dir=lock_dir)
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "preexisting_dirty_worktree",
|
||||||
|
"message": (
|
||||||
|
f"Preexisting worktree '{target_worktree}' has dirty tracked/untracked files (fail closed)."
|
||||||
|
),
|
||||||
|
"exact_next_action": (
|
||||||
|
"Clean or stash the pre-existing worktree files before bootstrapping."
|
||||||
|
),
|
||||||
|
}
|
||||||
|
|
||||||
|
# Check registered branch
|
||||||
|
wt_state = issue_lock_worktree.read_worktree_git_state(target_worktree)
|
||||||
|
wt_branch = (wt_state.get("current_branch") or "").strip()
|
||||||
|
if wt_branch and wt_branch != target_branch:
|
||||||
|
journal["failure_reason"] = (
|
||||||
|
f"existing worktree '{target_worktree}' is on branch '{wt_branch}' != expected '{target_branch}'"
|
||||||
|
)
|
||||||
|
run_compensating_recovery(journal, root, journal_dir=lock_dir)
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "incompatible_existing_directory",
|
||||||
|
"message": (
|
||||||
|
f"Existing worktree '{target_worktree}' is registered to branch '{wt_branch}' instead of '{target_branch}'."
|
||||||
|
),
|
||||||
|
"exact_next_action": (
|
||||||
|
"Inspect or remove the pre-existing worktree folder before bootstrapping."
|
||||||
|
),
|
||||||
|
}
|
||||||
|
if was_dir_created_previously or pending_wt == target_worktree:
|
||||||
|
journal["artifacts_created"]["worktree_dir_created"] = True
|
||||||
|
journal["artifacts_created"]["worktree_registered"] = True
|
||||||
|
else:
|
||||||
|
journal["artifacts_created"]["worktree_dir_created"] = False
|
||||||
|
journal["artifacts_created"]["worktree_registered"] = False
|
||||||
|
else:
|
||||||
|
# Persist creation intent/provenance to disk BEFORE executing external worktree add mutation
|
||||||
|
journal.setdefault("pending_creations", {})["worktree_path"] = target_worktree
|
||||||
|
journal["artifacts_created"]["worktree_dir_created"] = True
|
||||||
|
journal["artifacts_created"]["worktree_registered"] = True
|
||||||
|
save_phase_journal(journal, journal_dir=lock_dir)
|
||||||
|
|
||||||
|
wt_add_res = subprocess.run(
|
||||||
|
[
|
||||||
|
"git",
|
||||||
|
"-C",
|
||||||
|
root,
|
||||||
|
"worktree",
|
||||||
|
"add",
|
||||||
|
target_worktree,
|
||||||
|
target_branch,
|
||||||
|
],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
if wt_add_res.returncode != 0:
|
||||||
|
journal["artifacts_created"]["worktree_dir_created"] = False
|
||||||
|
journal["artifacts_created"]["worktree_registered"] = False
|
||||||
|
journal.get("pending_creations", {}).pop("worktree_path", None)
|
||||||
|
journal["failure_reason"] = (
|
||||||
|
f"git worktree add failed: {wt_add_res.stderr.strip()}"
|
||||||
|
)
|
||||||
|
run_compensating_recovery(journal, root, journal_dir=lock_dir)
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "worktree_add_failed",
|
||||||
|
"message": f"Failed to execute git worktree add: {wt_add_res.stderr.strip()}",
|
||||||
|
"exact_next_action": "Verify git worktree capabilities and retry.",
|
||||||
|
}
|
||||||
|
|
||||||
|
journal["phases"][PHASE_3_PATH_RESERVED] = {
|
||||||
|
"status": "completed",
|
||||||
|
"worktree_path": target_worktree,
|
||||||
|
"preexisting_dir": dir_exists,
|
||||||
|
}
|
||||||
|
journal["current_phase"] = PHASE_4_WORKTREE_CONFIRMED
|
||||||
|
save_phase_journal(journal, journal_dir=lock_dir)
|
||||||
|
|
||||||
|
# Phase 5: REGISTRATION_VERIFIED
|
||||||
|
wt_list_res = subprocess.run(
|
||||||
|
["git", "-C", root, "worktree", "list", "--porcelain"],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
norm_target = os.path.realpath(target_worktree)
|
||||||
|
found_registration = False
|
||||||
|
if wt_list_res.returncode == 0:
|
||||||
|
for block in wt_list_res.stdout.split("\n\n"):
|
||||||
|
lines = block.strip().splitlines()
|
||||||
|
worktree_line = next(
|
||||||
|
(l[9:].strip() for l in lines if l.startswith("worktree ")),
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
if worktree_line and os.path.realpath(worktree_line) == norm_target:
|
||||||
|
found_registration = True
|
||||||
|
break
|
||||||
|
|
||||||
|
if not found_registration:
|
||||||
|
journal["failure_reason"] = (
|
||||||
|
f"worktree registration for '{target_worktree}' not found in git worktree list"
|
||||||
|
)
|
||||||
|
run_compensating_recovery(journal, root, journal_dir=lock_dir)
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "worktree_registration_verification_failed",
|
||||||
|
"message": f"Worktree '{target_worktree}' registration verification failed.",
|
||||||
|
"exact_next_action": "Check git worktree list integrity and retry.",
|
||||||
|
}
|
||||||
|
|
||||||
|
journal["phases"][PHASE_4_WORKTREE_CONFIRMED] = {
|
||||||
|
"status": "completed",
|
||||||
|
"worktree_path": target_worktree,
|
||||||
|
}
|
||||||
|
journal["phases"][PHASE_5_REGISTRATION_VERIFIED] = {
|
||||||
|
"status": "completed",
|
||||||
|
"registered": True,
|
||||||
|
}
|
||||||
|
journal["current_phase"] = PHASE_6_STATE_ESTABLISHED
|
||||||
|
save_phase_journal(journal, journal_dir=lock_dir)
|
||||||
|
|
||||||
|
# Phase 6: STATE_ESTABLISHED — Issue Lock Acquisition
|
||||||
|
from datetime import datetime, timezone
|
||||||
|
try:
|
||||||
|
lock_data = {
|
||||||
|
"remote": remote,
|
||||||
|
"org": org or "Scaled-Tech-Consulting",
|
||||||
|
"repo": repo or "Gitea-Tools",
|
||||||
|
"issue_number": issue_number,
|
||||||
|
"branch": target_branch,
|
||||||
|
"branch_name": target_branch,
|
||||||
|
"worktree_path": target_worktree,
|
||||||
|
"owner_session": session,
|
||||||
|
"claimant": {
|
||||||
|
"username": identity,
|
||||||
|
"profile": profile,
|
||||||
|
},
|
||||||
|
"assignment_id": assignment_id,
|
||||||
|
"lease_id": lease_id,
|
||||||
|
"expected_base_sha": live_master_sha,
|
||||||
|
"created_at": datetime.now(timezone.utc).isoformat(),
|
||||||
|
}
|
||||||
|
journal.setdefault("pending_creations", {})["lock"] = True
|
||||||
|
journal["artifacts_created"]["lock_created"] = True
|
||||||
|
save_phase_journal(journal, journal_dir=lock_dir)
|
||||||
|
|
||||||
|
lock_res = issue_lock_store.bind_session_lock(lock_data, lock_dir=lock_dir)
|
||||||
|
except Exception as exc:
|
||||||
|
journal["artifacts_created"]["lock_created"] = False
|
||||||
|
journal.get("pending_creations", {}).pop("lock", None)
|
||||||
|
journal["failure_reason"] = f"issue lock binding failed: {exc}"
|
||||||
|
run_compensating_recovery(journal, root, journal_dir=lock_dir)
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"reason_code": "issue_lock_acquisition_failed",
|
||||||
|
"message": f"Could not bind canonical issue lock for issue #{issue_number}: {exc}",
|
||||||
|
"exact_next_action": "Verify lease/assignment state and retry.",
|
||||||
|
}
|
||||||
|
|
||||||
|
journal["phases"][PHASE_6_STATE_ESTABLISHED] = {
|
||||||
|
"status": "completed",
|
||||||
|
"lock": lock_res,
|
||||||
|
}
|
||||||
|
journal["phases"][PHASE_7_TRANSITION_COMPLETED] = {
|
||||||
|
"status": "completed",
|
||||||
|
}
|
||||||
|
journal["current_phase"] = PHASE_7_TRANSITION_COMPLETED
|
||||||
|
journal["completed"] = True
|
||||||
|
save_phase_journal(journal, journal_dir=lock_dir)
|
||||||
|
|
||||||
|
return {
|
||||||
|
"success": True,
|
||||||
|
"replayed": False,
|
||||||
|
"message": (
|
||||||
|
f"Successfully bootstrapped author issue worktree for issue #{issue_number} "
|
||||||
|
f"at branch '{target_branch}' and worktree '{target_worktree}'."
|
||||||
|
),
|
||||||
|
"issue_number": issue_number,
|
||||||
|
"branch_name": target_branch,
|
||||||
|
"worktree_path": target_worktree,
|
||||||
|
"base_sha": live_master_sha,
|
||||||
|
"lease_id": lease_id,
|
||||||
|
"assignment_id": assignment_id,
|
||||||
|
"idempotency_key": key,
|
||||||
|
"lock_state": lock_res,
|
||||||
|
"phase_journal": journal,
|
||||||
|
"exact_next_action": (
|
||||||
|
"Call gitea_whoami, then gitea_resolve_task_capability(task='work_issue') "
|
||||||
|
"and proceed with author implementation in the bootstrapped worktree."
|
||||||
|
),
|
||||||
|
}
|
||||||
+57
-36
@@ -40,23 +40,67 @@ def _normalize_path(path: str) -> str:
|
|||||||
return (path or "").replace("\\", "/").rstrip("/")
|
return (path or "").replace("\\", "/").rstrip("/")
|
||||||
|
|
||||||
|
|
||||||
|
def get_canonical_branches_root(project_root: str | None = None) -> str:
|
||||||
|
"""Return the absolute path of the canonical branches directory for *project_root*."""
|
||||||
|
root = os.path.realpath(project_root) if project_root else os.path.realpath(os.getcwd())
|
||||||
|
canonical_repo_root = resolve_canonical_repo_root(root, root)
|
||||||
|
return os.path.realpath(os.path.join(canonical_repo_root, "branches"))
|
||||||
|
|
||||||
|
|
||||||
def is_path_under_branches(path: str, project_root: str | None = None) -> bool:
|
def is_path_under_branches(path: str, project_root: str | None = None) -> bool:
|
||||||
"""True when *path* resolves inside ``<project_root>/branches/``."""
|
"""True when *path* resolves inside a canonical ``branches/`` directory."""
|
||||||
normalized = _normalize_path(path)
|
if not path or not str(path).strip():
|
||||||
if not normalized:
|
|
||||||
return False
|
return False
|
||||||
if "/branches/" in f"{normalized}/":
|
try:
|
||||||
return True
|
real_path = os.path.realpath(os.path.abspath(str(path).strip()))
|
||||||
if normalized.endswith("/branches"):
|
except Exception:
|
||||||
return True
|
|
||||||
if project_root:
|
|
||||||
root = _normalize_path(os.path.realpath(project_root))
|
|
||||||
real = _normalize_path(os.path.realpath(path))
|
|
||||||
if real.startswith(f"{root}/"):
|
|
||||||
rel = real[len(root) + 1 :]
|
|
||||||
return rel == "branches" or rel.startswith("branches/")
|
|
||||||
return False
|
return False
|
||||||
|
|
||||||
|
branches_root = get_canonical_branches_root(project_root or real_path)
|
||||||
|
try:
|
||||||
|
common = os.path.commonpath([branches_root, real_path])
|
||||||
|
except Exception:
|
||||||
|
return False
|
||||||
|
|
||||||
|
if common != branches_root:
|
||||||
|
return False
|
||||||
|
|
||||||
|
rel = os.path.relpath(real_path, branches_root)
|
||||||
|
return rel != "." and not rel.startswith("..")
|
||||||
|
|
||||||
|
|
||||||
|
def resolve_canonical_repo_root(workspace_path: str, fallback_project_root: str) -> str:
|
||||||
|
"""Return the stable repository root for *workspace_path* via git metadata (#460)."""
|
||||||
|
p = (workspace_path or "").strip()
|
||||||
|
if p:
|
||||||
|
try:
|
||||||
|
res = subprocess.run(
|
||||||
|
["git", "-C", p, "rev-parse", "--git-common-dir"],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=True,
|
||||||
|
)
|
||||||
|
common = _realpath_git_common_dir(p, res.stdout)
|
||||||
|
if common.endswith(f"{os.sep}.git") or os.path.basename(common) == ".git":
|
||||||
|
candidate_root = os.path.dirname(common)
|
||||||
|
real_p = os.path.realpath(p)
|
||||||
|
try:
|
||||||
|
if os.path.commonpath([candidate_root, real_p]) == candidate_root:
|
||||||
|
return candidate_root
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
|
||||||
|
fallback = os.path.realpath(fallback_project_root or workspace_path or ".")
|
||||||
|
norm = fallback.replace("\\", "/")
|
||||||
|
if "/branches/" in norm:
|
||||||
|
return os.path.realpath(norm.split("/branches/")[0])
|
||||||
|
elif norm.endswith("/branches"):
|
||||||
|
return os.path.realpath(os.path.dirname(fallback))
|
||||||
|
|
||||||
|
return fallback
|
||||||
|
|
||||||
|
|
||||||
def resolve_mutation_workspace(
|
def resolve_mutation_workspace(
|
||||||
worktree_path: str | None,
|
worktree_path: str | None,
|
||||||
@@ -87,29 +131,6 @@ def _realpath_git_common_dir(workspace_path: str, common_dir: str) -> str:
|
|||||||
return os.path.realpath(os.path.join(workspace_path, raw))
|
return os.path.realpath(os.path.join(workspace_path, raw))
|
||||||
|
|
||||||
|
|
||||||
def resolve_canonical_repo_root(workspace_path: str, fallback_project_root: str) -> str:
|
|
||||||
"""Return the stable repository root for *workspace_path* via git metadata (#460)."""
|
|
||||||
path = (workspace_path or "").strip()
|
|
||||||
fallback = os.path.realpath(fallback_project_root)
|
|
||||||
if not path:
|
|
||||||
return fallback
|
|
||||||
try:
|
|
||||||
res = subprocess.run(
|
|
||||||
["git", "-C", path, "rev-parse", "--git-common-dir"],
|
|
||||||
capture_output=True,
|
|
||||||
text=True,
|
|
||||||
check=True,
|
|
||||||
)
|
|
||||||
common = _realpath_git_common_dir(path, res.stdout)
|
|
||||||
except Exception:
|
|
||||||
return fallback
|
|
||||||
if common.endswith(f"{os.sep}.git"):
|
|
||||||
return os.path.dirname(common)
|
|
||||||
if os.path.basename(common) == ".git":
|
|
||||||
return os.path.dirname(common)
|
|
||||||
return fallback
|
|
||||||
|
|
||||||
|
|
||||||
def resolve_author_mutation_context(
|
def resolve_author_mutation_context(
|
||||||
worktree_path: str | None,
|
worktree_path: str | None,
|
||||||
process_project_root: str,
|
process_project_root: str,
|
||||||
|
|||||||
@@ -46,6 +46,17 @@ _FIELD_RE = re.compile(
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def is_known_cth_type(value: str | None) -> bool:
|
||||||
|
"""True when *value* is a declared member of the :data:`CTH_TYPES` contract.
|
||||||
|
|
||||||
|
``CTH_TYPES`` is the single authority for what a CTH type may be. The
|
||||||
|
heading a comment carries is free text, so a *read* path that turns a parsed
|
||||||
|
type into something durable — a serialized field, a routing decision — must
|
||||||
|
check membership here rather than trust the parse or keep a list of its own.
|
||||||
|
"""
|
||||||
|
return (value or "").strip() in CTH_TYPES
|
||||||
|
|
||||||
|
|
||||||
def format_cth_body(
|
def format_cth_body(
|
||||||
*,
|
*,
|
||||||
cth_type: str,
|
cth_type: str,
|
||||||
@@ -60,7 +71,7 @@ def format_cth_body(
|
|||||||
) -> str:
|
) -> str:
|
||||||
"""Render a canonical CTH comment body."""
|
"""Render a canonical CTH comment body."""
|
||||||
normalized_type = (cth_type or "").strip()
|
normalized_type = (cth_type or "").strip()
|
||||||
if normalized_type not in CTH_TYPES:
|
if not is_known_cth_type(normalized_type):
|
||||||
raise ValueError(
|
raise ValueError(
|
||||||
f"unknown CTH type '{cth_type}'; expected one of {sorted(CTH_TYPES)}"
|
f"unknown CTH type '{cth_type}'; expected one of {sorted(CTH_TYPES)}"
|
||||||
)
|
)
|
||||||
@@ -101,6 +112,12 @@ def parse_cth_comment(body: str) -> dict[str, Any] | None:
|
|||||||
fields[key] = match.group(2).strip()
|
fields[key] = match.group(2).strip()
|
||||||
return {
|
return {
|
||||||
"cth_type": cth_type,
|
"cth_type": cth_type,
|
||||||
|
# The heading capture is unconstrained free text, so the parse states
|
||||||
|
# whether it satisfies the CTH_TYPES contract instead of leaving every
|
||||||
|
# reader to decide (or forget). Parsing stays total — an unknown type is
|
||||||
|
# still parsed and reported, never raised on — but a reader that turns
|
||||||
|
# the type into a durable value can now tell the two apart.
|
||||||
|
"cth_type_known": is_known_cth_type(cth_type),
|
||||||
"fields": fields,
|
"fields": fields,
|
||||||
"raw_body": text,
|
"raw_body": text,
|
||||||
}
|
}
|
||||||
@@ -119,7 +136,7 @@ def assess_cth_comment(body: str) -> dict[str, Any]:
|
|||||||
}
|
}
|
||||||
|
|
||||||
cth_type = parsed.get("cth_type") or ""
|
cth_type = parsed.get("cth_type") or ""
|
||||||
if cth_type not in CTH_TYPES:
|
if not is_known_cth_type(cth_type):
|
||||||
reasons.append(
|
reasons.append(
|
||||||
f"unknown CTH type '{cth_type}'; expected one of {sorted(CTH_TYPES)}"
|
f"unknown CTH type '{cth_type}'; expected one of {sorted(CTH_TYPES)}"
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -247,7 +247,8 @@ def bootstrap_permits_control_checkout(
|
|||||||
"""
|
"""
|
||||||
if not isinstance(assessment, dict):
|
if not isinstance(assessment, dict):
|
||||||
return False
|
return False
|
||||||
if not is_create_issue_task(task):
|
import author_issue_bootstrap
|
||||||
|
if not is_create_issue_task(task) and not author_issue_bootstrap.is_author_issue_bootstrap_task(task):
|
||||||
return False
|
return False
|
||||||
|
|
||||||
# Positive proof: the assessment must affirmatively allow, with no
|
# Positive proof: the assessment must affirmatively allow, with no
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -69,6 +69,7 @@ that gates each call, not which tools exist.
|
|||||||
- `gitea_audit_worktree_cleanup`
|
- `gitea_audit_worktree_cleanup`
|
||||||
- `gitea_authorize_reconciliation_cleanup_phase`
|
- `gitea_authorize_reconciliation_cleanup_phase`
|
||||||
- `gitea_authorize_review_correction`
|
- `gitea_authorize_review_correction`
|
||||||
|
- `gitea_bootstrap_author_issue_worktree`
|
||||||
- `gitea_capability_stop_terminal_report`
|
- `gitea_capability_stop_terminal_report`
|
||||||
- `gitea_capture_branches_worktree_snapshot`
|
- `gitea_capture_branches_worktree_snapshot`
|
||||||
- `gitea_check_pr_eligibility`
|
- `gitea_check_pr_eligibility`
|
||||||
|
|||||||
@@ -317,6 +317,108 @@ health, workflow/schema SHA-256 hashes, and stale-runtime warnings when the
|
|||||||
checkout is behind merged safety-gate changes. Restart guidance links to #420;
|
checkout is behind merged safety-gate changes. Restart guidance links to #420;
|
||||||
no tokens or MCP restart actions are exposed.
|
no tokens or MCP restart actions are exposed.
|
||||||
|
|
||||||
|
## Workflow-event timeline (#637)
|
||||||
|
|
||||||
|
`GET /api/v1/timeline` is a read-only, versioned aggregation of workflow
|
||||||
|
events from every available source into one normalised, filterable stream. It
|
||||||
|
is the model layer for the Phase 1 timeline console view (a later child issue
|
||||||
|
of #631); this issue ships the schema, adapters, and read API only.
|
||||||
|
|
||||||
|
### Schema (versioned)
|
||||||
|
|
||||||
|
`webui/timeline.py` declares `TIMELINE_SCHEMA_VERSION` (currently `1`) and the
|
||||||
|
frozen `WorkflowEvent` record. Every response carries `schema_version` so a
|
||||||
|
consumer can branch on shape. One event:
|
||||||
|
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"source": "control_plane",
|
||||||
|
"event_type": "lease.renew",
|
||||||
|
"event_key": "cp:1421",
|
||||||
|
"timestamp": "2026-07-23T02:00:00Z",
|
||||||
|
"actor": null,
|
||||||
|
"role": null,
|
||||||
|
"issue_number": 637,
|
||||||
|
"pr_number": null,
|
||||||
|
"session_id": null,
|
||||||
|
"tool_name": null,
|
||||||
|
"decision": null,
|
||||||
|
"message": "lease renewed",
|
||||||
|
"correlation_id": "issue#637",
|
||||||
|
"evidence_refs": [],
|
||||||
|
"sensitive": true
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
`event_key` is stable and unique per source (`cp:<event_id>`,
|
||||||
|
`cth:<kind>:<number>:<comment_id>`), so pagination and dedup are deterministic.
|
||||||
|
|
||||||
|
### Sources and field authority
|
||||||
|
|
||||||
|
| Source | Adapter | Authority |
|
||||||
|
|---|---|---|
|
||||||
|
| Control-plane `events` ⋈ `work_items` | `adapt_cp_events` | `event_type`, `message`, `timestamp`, issue/PR scope come from the CP database, read through a `mode=ro` URI (never creates the DB or runs migrations) |
|
||||||
|
| Gitea Canonical Thread Handoff comments | `adapt_cth_comments` | `actor`, `role` (next owner), `decision`, `evidence_refs`, `timestamp` come from the parsed CTH comment body (`canonical_thread_handoff`) |
|
||||||
|
|
||||||
|
Handoff comments are thread-scoped: they are only read when the request filters
|
||||||
|
by a single `issue` or `pr`. Otherwise the handoff source reports `not run`
|
||||||
|
with a reason — it is never rendered as empty-and-healthy. Each source degrades
|
||||||
|
independently: an unavailable control-plane DB or a failed comment fetch is a
|
||||||
|
`sources[]` entry with `ok:false` and a `reason`, never a dropped timeline.
|
||||||
|
|
||||||
|
### Query parameters
|
||||||
|
|
||||||
|
`issue`, `pr`, `session` (conjunctive filters); `limit` (default 50, max 500)
|
||||||
|
and `offset` for pagination; `remote`, `org`, `repo` to override the default
|
||||||
|
registry-project scope. Events sort ascending by
|
||||||
|
`(timestamp, source_rank, event_key)`; missing timestamps sort last.
|
||||||
|
|
||||||
|
### Filter authority, and refusing what cannot be answered
|
||||||
|
|
||||||
|
A filter dimension is only meaningful for a source whose records carry it.
|
||||||
|
Each source declares its own support in `_SOURCE_FILTER_SUPPORT` and reports it
|
||||||
|
per response as `supported_filters` / `unsupported_filters`:
|
||||||
|
|
||||||
|
| Source | issue | pr | session |
|
||||||
|
|---|---|---|---|
|
||||||
|
| `control_plane` | yes | yes | **no** — the `events` table is `(event_id, work_item_id, event_type, message, created_at)` and records no session |
|
||||||
|
| `gitea_handoff` | yes | yes | yes — a CTH comment declares its own `Session:` field |
|
||||||
|
|
||||||
|
`session_id` is read only from that declared CTH field. It is never inferred
|
||||||
|
from a work item, an actor, or message text, and a value that is
|
||||||
|
redaction-altering or bare-secret-shaped is dropped rather than emitted.
|
||||||
|
|
||||||
|
When **no source that ran** can carry a requested dimension, the request is
|
||||||
|
refused rather than answered: the response is `422` with `ok:false` and a
|
||||||
|
structured `error` naming `unsupported_filters` and the per-source reason. A
|
||||||
|
`200` with zero events would tell an operator that no such activity exists,
|
||||||
|
which is a stronger — and false — claim than "this cannot be answered here".
|
||||||
|
A source that *can* answer the dimension and simply matched nothing still
|
||||||
|
returns `200` with `ok:true` and an empty page.
|
||||||
|
|
||||||
|
### Redaction
|
||||||
|
|
||||||
|
Every free-text field (event messages, decision/proof text, roles, actors) is
|
||||||
|
passed through the console redaction policy (`webui.console_redaction`, backed
|
||||||
|
by `gitea_audit.redact`) before it leaves the module, failing closed to the
|
||||||
|
placeholder. No unredacted tool arguments or secrets are ever emitted, and a
|
||||||
|
generation error never drops raw data to a caller or a log.
|
||||||
|
|
||||||
|
Redaction also runs *before* any structured value is derived from free text.
|
||||||
|
`evidence_refs` are extracted from already-redacted proof/decision text, and a
|
||||||
|
commit reference is recognised only where the text declares one (`commit`,
|
||||||
|
`head`, `base`, `sha`, …). An undeclared 40-character hex run has the exact
|
||||||
|
shape of a Gitea access token, so it is never lifted out of prose into a
|
||||||
|
structured field. Every reference is then independently revalidated against an
|
||||||
|
allowed shape and a second redaction pass immediately before serialization;
|
||||||
|
anything unproven is dropped and the event is flagged `sensitive`.
|
||||||
|
|
||||||
|
### Tests
|
||||||
|
|
||||||
|
```bash
|
||||||
|
pytest tests/test_webui_timeline.py -q
|
||||||
|
```
|
||||||
|
|
||||||
## Tests
|
## Tests
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
|
|||||||
+525
-13
@@ -440,13 +440,32 @@ def _session_author_lock_worktree() -> str | None:
|
|||||||
|
|
||||||
Used to derive the author mutation workspace when no explicit
|
Used to derive the author mutation workspace when no explicit
|
||||||
``worktree_path`` or env binding is provided. Never invents a path.
|
``worktree_path`` or env binding is provided. Never invents a path.
|
||||||
|
|
||||||
|
#864: a session pointer whose owner PID is dead and is not this process
|
||||||
|
must not force workspace binding for other issues — rebind is required for
|
||||||
|
that issue, and a stale dead-owner pointer must not poison unrelated work.
|
||||||
"""
|
"""
|
||||||
try:
|
try:
|
||||||
lock = issue_lock_store.read_session_issue_lock() or {}
|
lock = issue_lock_store.read_session_issue_lock() or {}
|
||||||
except Exception:
|
except Exception:
|
||||||
return None
|
return None
|
||||||
path = (lock.get("worktree_path") or "").strip()
|
path = (lock.get("worktree_path") or "").strip()
|
||||||
return path or None
|
if not path:
|
||||||
|
return None
|
||||||
|
pid = lock.get("session_pid")
|
||||||
|
if pid is None:
|
||||||
|
pid = lock.get("pid")
|
||||||
|
try:
|
||||||
|
pid_i = int(pid) if pid is not None else None
|
||||||
|
except (TypeError, ValueError):
|
||||||
|
pid_i = None
|
||||||
|
if (
|
||||||
|
pid_i is not None
|
||||||
|
and pid_i != os.getpid()
|
||||||
|
and not issue_lock_store.is_process_alive(pid_i)
|
||||||
|
):
|
||||||
|
return None
|
||||||
|
return path
|
||||||
|
|
||||||
|
|
||||||
def _resolve_preflight_workspace_path(worktree_path: str | None = None) -> str:
|
def _resolve_preflight_workspace_path(worktree_path: str | None = None) -> str:
|
||||||
@@ -958,6 +977,32 @@ def _create_issue_bootstrap_assessment(
|
|||||||
"""
|
"""
|
||||||
import create_issue_bootstrap as _cib
|
import create_issue_bootstrap as _cib
|
||||||
|
|
||||||
|
import author_issue_bootstrap as _aib
|
||||||
|
if _aib.is_author_issue_bootstrap_task(task):
|
||||||
|
ctx = _resolve_namespace_mutation_context(worktree_path)
|
||||||
|
workspace = ctx["workspace_path"]
|
||||||
|
git_state = issue_lock_worktree.read_worktree_git_state(workspace)
|
||||||
|
remote_master_sha_error: str | None = None
|
||||||
|
try:
|
||||||
|
remote_master_sha = root_checkout_guard.resolve_remote_master_sha(
|
||||||
|
ctx["canonical_repo_root"]
|
||||||
|
)
|
||||||
|
except Exception as exc:
|
||||||
|
remote_master_sha = None
|
||||||
|
remote_master_sha_error = (
|
||||||
|
f"{type(exc).__name__}: {exc}".strip() or "resolver failed"
|
||||||
|
)
|
||||||
|
return _aib.assess_author_issue_bootstrap(
|
||||||
|
workspace_path=workspace,
|
||||||
|
canonical_repo_root=ctx["canonical_repo_root"],
|
||||||
|
current_branch=git_state.get("current_branch"),
|
||||||
|
head_sha=git_state.get("head_sha"),
|
||||||
|
porcelain_status=git_state.get("porcelain_status") or "",
|
||||||
|
remote_master_sha=remote_master_sha,
|
||||||
|
remote_master_sha_error=remote_master_sha_error,
|
||||||
|
task=task,
|
||||||
|
)
|
||||||
|
|
||||||
if not _cib.is_create_issue_task(task):
|
if not _cib.is_create_issue_task(task):
|
||||||
return None
|
return None
|
||||||
|
|
||||||
@@ -1450,7 +1495,7 @@ def verify_preflight_purity(
|
|||||||
dirty_files = sorted(
|
dirty_files = sorted(
|
||||||
_parse_porcelain_entries(_get_workspace_porcelain(workspace))
|
_parse_porcelain_entries(_get_workspace_porcelain(workspace))
|
||||||
)
|
)
|
||||||
if dirty_files:
|
if dirty_files and task != "commit_files":
|
||||||
raise RuntimeError(
|
raise RuntimeError(
|
||||||
nwb.format_namespace_workspace_binding_error(
|
nwb.format_namespace_workspace_binding_error(
|
||||||
role_kind=role,
|
role_kind=role,
|
||||||
@@ -2031,6 +2076,7 @@ import issue_lock_store # noqa: E402
|
|||||||
import issue_lock_adoption # noqa: E402
|
import issue_lock_adoption # noqa: E402
|
||||||
import issue_lock_recovery # noqa: E402
|
import issue_lock_recovery # noqa: E402
|
||||||
import issue_lock_renewal # noqa: E402
|
import issue_lock_renewal # noqa: E402
|
||||||
|
import dirty_same_claimant_session_rebind # noqa: E402 # #864
|
||||||
import stacked_pr_support # noqa: E402
|
import stacked_pr_support # noqa: E402
|
||||||
import merge_approval_gate # noqa: E402
|
import merge_approval_gate # noqa: E402
|
||||||
import review_quarantine # noqa: E402 # #695 contaminated formal-review quarantine
|
import review_quarantine # noqa: E402 # #695 contaminated formal-review quarantine
|
||||||
@@ -4342,6 +4388,263 @@ def gitea_lock_issue(
|
|||||||
return result
|
return result
|
||||||
|
|
||||||
|
|
||||||
|
@mcp.tool()
|
||||||
|
def gitea_rebind_dirty_same_claimant_author_session(
|
||||||
|
issue_number: int,
|
||||||
|
branch_name: str,
|
||||||
|
worktree_path: str,
|
||||||
|
old_pid: int,
|
||||||
|
expected_local_head: str,
|
||||||
|
expected_remote_head: str,
|
||||||
|
expected_dirty_paths: list[str],
|
||||||
|
expected_fingerprints: dict,
|
||||||
|
remote: str = "dadeschools",
|
||||||
|
host: str | None = None,
|
||||||
|
org: str | None = None,
|
||||||
|
repo: str | None = None,
|
||||||
|
dry_run: bool = False,
|
||||||
|
authorize_reconciler_execute: bool = False,
|
||||||
|
) -> dict:
|
||||||
|
"""Rebind a dirty registered issue worktree to this session (#864).
|
||||||
|
|
||||||
|
Sanctioned only when every pin agrees: same claimant, dead old_pid matching
|
||||||
|
the durable lock, matching local/remote heads, exact dirty path set, and
|
||||||
|
per-path sha256 fingerprints. Preserves every tracked/untracked byte.
|
||||||
|
Does not sync remote, create recovery worktrees, clean, reset, or move heads.
|
||||||
|
|
||||||
|
Role gate:
|
||||||
|
* author — must match the lock claimant identity/profile
|
||||||
|
* reconciler — execute only when ``authorize_reconciler_execute=True``
|
||||||
|
* reviewer/merger — always refuse
|
||||||
|
|
||||||
|
``gitea.issue.comment`` (author map entry) is required for mutation; dry_run
|
||||||
|
still assesses fully but writes nothing. Permission alone is never ownership
|
||||||
|
proof — every pin is re-checked server-side.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
issue_number: Tracking issue number on the durable lock.
|
||||||
|
branch_name: Exact locked branch name.
|
||||||
|
worktree_path: Registered dirty worktree path (must be under branches/).
|
||||||
|
old_pid: Dead owner PID recorded on the lock (must match session_pid/pid).
|
||||||
|
expected_local_head: Full local HEAD sha the caller observed.
|
||||||
|
expected_remote_head: Full remote-tracking HEAD sha the caller observed.
|
||||||
|
expected_dirty_paths: Exact set of dirty relative paths (tracked+untracked).
|
||||||
|
expected_fingerprints: Map of relative path -> sha256 hex of file bytes.
|
||||||
|
remote: Known instance — 'dadeschools' or 'prgs'.
|
||||||
|
host/org/repo: Optional target overrides (validated against binding).
|
||||||
|
dry_run: When true, assess only (no lock/session writes).
|
||||||
|
authorize_reconciler_execute: Reconciler-only execute gate.
|
||||||
|
"""
|
||||||
|
role = _profile_role_kind(get_profile())
|
||||||
|
role_norm = (role or "").strip().lower()
|
||||||
|
|
||||||
|
# Permission: authors need comment; dry_run assess is reachable under read
|
||||||
|
# for diagnosis, but execute always needs comment. Reconciler execute also
|
||||||
|
# needs comment when authorized.
|
||||||
|
if dry_run:
|
||||||
|
read_block = _profile_operation_gate("gitea.read")
|
||||||
|
if read_block:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"dry_run": True,
|
||||||
|
"reasons": read_block,
|
||||||
|
"permission_report": _permission_block_report("gitea.read"),
|
||||||
|
}
|
||||||
|
else:
|
||||||
|
blocked = _profile_permission_block(
|
||||||
|
task_capability_map.required_permission(
|
||||||
|
"rebind_dirty_same_claimant_author_session"
|
||||||
|
),
|
||||||
|
issue_number=issue_number,
|
||||||
|
remote=remote,
|
||||||
|
host=host,
|
||||||
|
org=org,
|
||||||
|
repo=repo,
|
||||||
|
org_explicit=org is not None,
|
||||||
|
repo_explicit=repo is not None,
|
||||||
|
)
|
||||||
|
if blocked:
|
||||||
|
return blocked
|
||||||
|
|
||||||
|
if role_norm in {"reviewer", "merger"}:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"dry_run": bool(dry_run),
|
||||||
|
"outcome": dirty_same_claimant_session_rebind.REFUSED,
|
||||||
|
"reasons": [
|
||||||
|
f"role '{role_norm}' cannot rebind dirty same-claimant author "
|
||||||
|
"sessions (fail closed)"
|
||||||
|
],
|
||||||
|
}
|
||||||
|
if role_norm == "reconciler" and not authorize_reconciler_execute and not dry_run:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"dry_run": False,
|
||||||
|
"outcome": dirty_same_claimant_session_rebind.REFUSED,
|
||||||
|
"reasons": [
|
||||||
|
"reconciler role requires authorize_reconciler_execute=True "
|
||||||
|
"to execute dirty same-claimant rebind (fail closed)"
|
||||||
|
],
|
||||||
|
}
|
||||||
|
|
||||||
|
h, o, r = _resolve(remote, host, org, repo)
|
||||||
|
try:
|
||||||
|
identity = _authenticated_username(h)
|
||||||
|
except Exception:
|
||||||
|
identity = None
|
||||||
|
profile = get_profile()
|
||||||
|
profile_name = profile.get("profile_name")
|
||||||
|
|
||||||
|
existing = _load_existing_issue_lock(
|
||||||
|
remote=remote, org=o, repo=r, issue_number=issue_number
|
||||||
|
)
|
||||||
|
resolved_wt = os.path.realpath(os.path.abspath((worktree_path or "").strip()))
|
||||||
|
inv = dirty_same_claimant_session_rebind.collect_dirty_inventory(resolved_wt)
|
||||||
|
|
||||||
|
branch_res = subprocess.run(
|
||||||
|
["git", "-C", resolved_wt, "branch", "--show-current"],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
current_branch = (branch_res.stdout or "").strip() or None
|
||||||
|
head_res = subprocess.run(
|
||||||
|
["git", "-C", resolved_wt, "rev-parse", "HEAD"],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
local_head = (head_res.stdout or "").strip() if head_res.returncode == 0 else None
|
||||||
|
|
||||||
|
# Observe remote-tracking head without network when possible.
|
||||||
|
remote_head = None
|
||||||
|
for ref in (
|
||||||
|
f"refs/remotes/origin/{branch_name}",
|
||||||
|
f"origin/{branch_name}",
|
||||||
|
f"refs/remotes/{remote}/{branch_name}",
|
||||||
|
f"{remote}/{branch_name}",
|
||||||
|
):
|
||||||
|
rh = subprocess.run(
|
||||||
|
["git", "-C", resolved_wt, "rev-parse", "--verify", "--quiet", ref],
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
check=False,
|
||||||
|
)
|
||||||
|
if rh.returncode == 0 and (rh.stdout or "").strip():
|
||||||
|
remote_head = (rh.stdout or "").strip()
|
||||||
|
break
|
||||||
|
if remote_head is None:
|
||||||
|
# Fall back to caller's pin only for observation absence — assessment
|
||||||
|
# still requires pin==observed, so missing observation fails closed.
|
||||||
|
remote_head = None
|
||||||
|
|
||||||
|
# Competing live locks (other issues / other worktrees).
|
||||||
|
competing_live = []
|
||||||
|
for entry in issue_lock_store.list_live_locks():
|
||||||
|
competing_live.append(entry)
|
||||||
|
|
||||||
|
# Session pointers that claim this issue lock.
|
||||||
|
competing_sessions = []
|
||||||
|
lock_dir = issue_lock_store.default_lock_dir()
|
||||||
|
lock_path = issue_lock_store.lock_file_path(
|
||||||
|
remote=remote, org=o, repo=r, issue_number=issue_number, lock_dir=lock_dir
|
||||||
|
)
|
||||||
|
try:
|
||||||
|
for name in os.listdir(lock_dir):
|
||||||
|
if not name.startswith("session-") or not name.endswith(".json"):
|
||||||
|
continue
|
||||||
|
ptr = issue_lock_store.read_lock_file(os.path.join(lock_dir, name))
|
||||||
|
if not ptr:
|
||||||
|
continue
|
||||||
|
ptr_lock = str(ptr.get("lock_file_path") or "").strip()
|
||||||
|
if not ptr_lock:
|
||||||
|
continue
|
||||||
|
try:
|
||||||
|
same = os.path.realpath(ptr_lock) == os.path.realpath(lock_path)
|
||||||
|
except OSError:
|
||||||
|
same = ptr_lock == lock_path
|
||||||
|
if not same:
|
||||||
|
continue
|
||||||
|
try:
|
||||||
|
sess_pid = int(str(name)[len("session-") : -len(".json")])
|
||||||
|
except ValueError:
|
||||||
|
sess_pid = ptr.get("pid")
|
||||||
|
competing_sessions.append(
|
||||||
|
{
|
||||||
|
"pid": sess_pid,
|
||||||
|
"lock_file_path": ptr_lock,
|
||||||
|
"live": issue_lock_store.is_process_alive(sess_pid),
|
||||||
|
}
|
||||||
|
)
|
||||||
|
except OSError:
|
||||||
|
pass
|
||||||
|
|
||||||
|
# Best-effort workflow-lease scan: any live lock file whose work_lease is a
|
||||||
|
# non-author workflow lease on this issue/branch counts as active.
|
||||||
|
workflow_lease_active = False
|
||||||
|
for path in issue_lock_store.iter_lock_files(lock_dir):
|
||||||
|
rec = issue_lock_store.read_lock_file(path)
|
||||||
|
if not rec:
|
||||||
|
continue
|
||||||
|
lease = rec.get("work_lease") if isinstance(rec.get("work_lease"), dict) else {}
|
||||||
|
op = str(lease.get("operation_type") or "")
|
||||||
|
if op and op != issue_lock_store.AUTHOR_ISSUE_WORK_LEASE:
|
||||||
|
if rec.get("issue_number") == issue_number or str(
|
||||||
|
rec.get("branch_name") or ""
|
||||||
|
) == branch_name:
|
||||||
|
if issue_lock_store.is_lease_live(rec):
|
||||||
|
workflow_lease_active = True
|
||||||
|
break
|
||||||
|
|
||||||
|
repo_root = _canonical_local_git_root()
|
||||||
|
# permission_allowed reflects profile gate only — never ownership proof.
|
||||||
|
permission_allowed = True
|
||||||
|
|
||||||
|
result = dirty_same_claimant_session_rebind.apply_dirty_same_claimant_session_rebind(
|
||||||
|
remote=remote,
|
||||||
|
org=o,
|
||||||
|
repo=r,
|
||||||
|
issue_number=issue_number,
|
||||||
|
branch_name=branch_name,
|
||||||
|
worktree_path=resolved_wt,
|
||||||
|
claimant_identity=identity,
|
||||||
|
claimant_profile=profile_name,
|
||||||
|
old_pid=old_pid,
|
||||||
|
expected_local_head=expected_local_head,
|
||||||
|
expected_remote_head=expected_remote_head,
|
||||||
|
expected_dirty_paths=list(expected_dirty_paths or []),
|
||||||
|
expected_fingerprints=dict(expected_fingerprints or {}),
|
||||||
|
existing_lock=existing,
|
||||||
|
current_identity=identity,
|
||||||
|
current_profile=profile_name,
|
||||||
|
role_kind=role_norm or role,
|
||||||
|
current_pid=os.getpid(),
|
||||||
|
current_branch=current_branch,
|
||||||
|
local_head=local_head,
|
||||||
|
remote_head=remote_head,
|
||||||
|
dirty_inventory=inv,
|
||||||
|
competing_live_locks=competing_live,
|
||||||
|
competing_sessions=competing_sessions,
|
||||||
|
workflow_lease_active=workflow_lease_active,
|
||||||
|
authorize_reconciler_execute=bool(authorize_reconciler_execute),
|
||||||
|
permission_allowed=permission_allowed,
|
||||||
|
repo_root=repo_root,
|
||||||
|
dry_run=bool(dry_run),
|
||||||
|
lock_dir=lock_dir,
|
||||||
|
)
|
||||||
|
result["observed"] = {
|
||||||
|
"local_head": local_head,
|
||||||
|
"remote_head": remote_head,
|
||||||
|
"current_branch": current_branch,
|
||||||
|
"dirty_paths": inv.get("dirty_paths"),
|
||||||
|
"fingerprints": inv.get("fingerprints"),
|
||||||
|
"identity": identity,
|
||||||
|
"profile": profile_name,
|
||||||
|
"role_kind": role_norm,
|
||||||
|
}
|
||||||
|
return result
|
||||||
|
|
||||||
|
|
||||||
@mcp.tool()
|
@mcp.tool()
|
||||||
def gitea_assess_work_issue_duplicate(
|
def gitea_assess_work_issue_duplicate(
|
||||||
issue_number: int,
|
issue_number: int,
|
||||||
@@ -9010,6 +9313,7 @@ def gitea_commit_files(
|
|||||||
host: str | None = None,
|
host: str | None = None,
|
||||||
org: str | None = None,
|
org: str | None = None,
|
||||||
repo: str | None = None,
|
repo: str | None = None,
|
||||||
|
worktree_path: str | None = None,
|
||||||
) -> dict:
|
) -> dict:
|
||||||
"""Commit changes to multiple files in a Gitea repository in a single atomic commit.
|
"""Commit changes to multiple files in a Gitea repository in a single atomic commit.
|
||||||
|
|
||||||
@@ -9022,10 +9326,46 @@ def gitea_commit_files(
|
|||||||
host: Override the Gitea host.
|
host: Override the Gitea host.
|
||||||
org: Override the owner/organization.
|
org: Override the owner/organization.
|
||||||
repo: Override the repository name.
|
repo: Override the repository name.
|
||||||
|
worktree_path: Optional worktree path for author mutation context.
|
||||||
|
|
||||||
Returns:
|
Returns:
|
||||||
dict with success status and commit/branch information.
|
dict with success status and commit/branch information.
|
||||||
"""
|
"""
|
||||||
|
if worktree_path is None:
|
||||||
|
lock_data = issue_lock_store.read_session_issue_lock() or {}
|
||||||
|
worktree_path = lock_data.get("worktree_path")
|
||||||
|
if not worktree_path:
|
||||||
|
try:
|
||||||
|
prof = get_profile()
|
||||||
|
uname = prof.get("username") or prof.get("profile_name")
|
||||||
|
for path in issue_lock_store.iter_lock_files():
|
||||||
|
lk = issue_lock_store.read_lock_file(path) or {}
|
||||||
|
claimant = lk.get("claimant") or {}
|
||||||
|
if lk.get("remote") == remote and (claimant.get("username") == uname or lk.get("profile") == prof.get("profile_name")):
|
||||||
|
issue_lock_store.bind_session_lock(lk, renewal_sanctioned=True)
|
||||||
|
worktree_path = lk.get("worktree_path")
|
||||||
|
break
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
|
||||||
|
if worktree_path is None and files:
|
||||||
|
for f in files:
|
||||||
|
p = f.get("workspace_path") or f.get("local_path") or ""
|
||||||
|
if p and os.path.isabs(p):
|
||||||
|
real_p = os.path.realpath(p)
|
||||||
|
real_root = os.path.realpath(PROJECT_ROOT)
|
||||||
|
branches_dir = os.path.join(real_root, "branches")
|
||||||
|
if real_p.startswith(branches_dir + os.sep):
|
||||||
|
rel_sub = os.path.relpath(real_p, branches_dir)
|
||||||
|
wt_folder = rel_sub.split(os.sep)[0]
|
||||||
|
if wt_folder and wt_folder != "..":
|
||||||
|
worktree_path = os.path.join(branches_dir, wt_folder)
|
||||||
|
break
|
||||||
|
|
||||||
|
if worktree_path:
|
||||||
|
os.environ["GITEA_AUTHOR_WORKTREE"] = worktree_path
|
||||||
|
os.environ["GITEA_ACTIVE_WORKTREE"] = worktree_path
|
||||||
|
|
||||||
ok, block_reasons = role_session_router.check_author_mutation_after_reviewer_stop(
|
ok, block_reasons = role_session_router.check_author_mutation_after_reviewer_stop(
|
||||||
"commit_files"
|
"commit_files"
|
||||||
)
|
)
|
||||||
@@ -9038,7 +9378,7 @@ def gitea_commit_files(
|
|||||||
"reasons": block_reasons,
|
"reasons": block_reasons,
|
||||||
}
|
}
|
||||||
blocked = _namespace_mutation_block(
|
blocked = _namespace_mutation_block(
|
||||||
"commit_files", commit="", branch="", remote=remote
|
"commit_files", commit="", branch="", remote=remote, worktree_path=worktree_path
|
||||||
)
|
)
|
||||||
if blocked:
|
if blocked:
|
||||||
return blocked
|
return blocked
|
||||||
@@ -9066,7 +9406,7 @@ def gitea_commit_files(
|
|||||||
)
|
)
|
||||||
|
|
||||||
# #735: forward explicit org/repo into shared anti-stomp preflight.
|
# #735: forward explicit org/repo into shared anti-stomp preflight.
|
||||||
verify_preflight_purity(remote, task="commit_files", org=org, repo=repo)
|
verify_preflight_purity(remote=remote, worktree_path=worktree_path, task="commit_files", org=org, repo=repo)
|
||||||
processed_files, source_proofs = _prepare_commit_payload_files(files)
|
processed_files, source_proofs = _prepare_commit_payload_files(files)
|
||||||
|
|
||||||
h, o, r = _resolve(remote, host, org, repo)
|
h, o, r = _resolve(remote, host, org, repo)
|
||||||
@@ -9343,6 +9683,96 @@ def gitea_publish_unpublished_issue_branch(
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
@mcp.tool()
|
||||||
|
def gitea_bootstrap_author_issue_worktree(
|
||||||
|
issue_number: int,
|
||||||
|
assignment_id: str | None = None,
|
||||||
|
lease_id: str | None = None,
|
||||||
|
expected_base_sha: str | None = None,
|
||||||
|
branch_name: str | None = None,
|
||||||
|
worktree_path: str | None = None,
|
||||||
|
idempotency_key: str | None = None,
|
||||||
|
remote: str = "dadeschools",
|
||||||
|
host: str | None = None,
|
||||||
|
org: str | None = None,
|
||||||
|
repo: str | None = None,
|
||||||
|
dry_run: bool = False,
|
||||||
|
) -> dict:
|
||||||
|
"""Bootstrap an allocated author issue branch and registered worktree (#850).
|
||||||
|
|
||||||
|
Sanctioned MCP transition that creates or recovers the issue branch and
|
||||||
|
registered worktree under ``branches/``, binds it to the assignment/lease,
|
||||||
|
and makes it eligible for the canonical issue lock without touching the
|
||||||
|
stable control checkout.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
issue_number: Allocated issue number to bootstrap.
|
||||||
|
assignment_id: Optional allocation assignment ID.
|
||||||
|
lease_id: Optional workflow lease ID.
|
||||||
|
expected_base_sha: Authoritative expected base SHA / concurrency pin.
|
||||||
|
branch_name: Optional custom branch name (must match issue-<N> pattern).
|
||||||
|
worktree_path: Optional custom worktree path under branches/.
|
||||||
|
idempotency_key: Optional key for idempotent replay/resume.
|
||||||
|
remote: Known instance — 'dadeschools' or 'prgs'.
|
||||||
|
host: Override Gitea host.
|
||||||
|
org: Override Org.
|
||||||
|
repo: Override Repo.
|
||||||
|
dry_run: Report planned transition without mutating repository.
|
||||||
|
"""
|
||||||
|
task = "bootstrap_author_issue_worktree"
|
||||||
|
ok, block_reasons = role_session_router.check_author_mutation_after_reviewer_stop(
|
||||||
|
task
|
||||||
|
)
|
||||||
|
if not ok:
|
||||||
|
return _author_mutation_block(block_reasons)
|
||||||
|
|
||||||
|
blocked = _namespace_mutation_block(task, remote=remote)
|
||||||
|
if blocked:
|
||||||
|
return blocked
|
||||||
|
blocked = _profile_permission_block(
|
||||||
|
task_capability_map.required_permission(task),
|
||||||
|
remote=remote,
|
||||||
|
host=host,
|
||||||
|
org=org,
|
||||||
|
repo=repo,
|
||||||
|
org_explicit=org is not None,
|
||||||
|
repo_explicit=repo is not None,
|
||||||
|
)
|
||||||
|
if blocked:
|
||||||
|
return blocked
|
||||||
|
|
||||||
|
verify_preflight_purity(
|
||||||
|
remote,
|
||||||
|
task=task,
|
||||||
|
org=org,
|
||||||
|
repo=repo,
|
||||||
|
)
|
||||||
|
|
||||||
|
h, o, r = _resolve(remote, host, org, repo)
|
||||||
|
canonical_root = _canonical_local_git_root()
|
||||||
|
|
||||||
|
import author_issue_bootstrap
|
||||||
|
|
||||||
|
return author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=issue_number,
|
||||||
|
canonical_repo_root=canonical_root,
|
||||||
|
assignment_id=assignment_id,
|
||||||
|
lease_id=lease_id,
|
||||||
|
expected_base_sha=expected_base_sha,
|
||||||
|
branch_name=branch_name,
|
||||||
|
worktree_path=worktree_path,
|
||||||
|
idempotency_key=idempotency_key,
|
||||||
|
remote=remote,
|
||||||
|
host=h,
|
||||||
|
org=o,
|
||||||
|
repo=r,
|
||||||
|
active_identity=_active_username(),
|
||||||
|
active_profile=_active_profile_name(),
|
||||||
|
owner_session=_current_session_id(),
|
||||||
|
dry_run=dry_run,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
# Merge methods supported by the Gitea merge API.
|
# Merge methods supported by the Gitea merge API.
|
||||||
_MERGE_METHODS = ("merge", "squash", "rebase")
|
_MERGE_METHODS = ("merge", "squash", "rebase")
|
||||||
|
|
||||||
@@ -11598,6 +12028,7 @@ def gitea_audit_worktree_cleanup(
|
|||||||
org: str | None = None,
|
org: str | None = None,
|
||||||
repo: str | None = None,
|
repo: str | None = None,
|
||||||
ttl_hours: float = worktree_cleanup_audit.DEFAULT_TTL_HOURS,
|
ttl_hours: float = worktree_cleanup_audit.DEFAULT_TTL_HOURS,
|
||||||
|
merged_pr_limit: int = 200,
|
||||||
) -> dict:
|
) -> dict:
|
||||||
"""Read-only: classify every session-owned worktree under ``branches/`` (#401).
|
"""Read-only: classify every session-owned worktree under ``branches/`` (#401).
|
||||||
|
|
||||||
@@ -11608,17 +12039,26 @@ def gitea_audit_worktree_cleanup(
|
|||||||
the active issue-lock branch is read from the local lock file and treated
|
the active issue-lock branch is read from the local lock file and treated
|
||||||
as active work. Deletes nothing and mutates no Gitea state.
|
as active work. Deletes nothing and mutates no Gitea state.
|
||||||
|
|
||||||
Fails closed if the live open-PR list cannot be fetched: without it,
|
Merged PRs are fetched as well, so an issue worktree can be linked to the
|
||||||
removability cannot be proven, so no candidates are returned.
|
PR that owns its branch (#858). Such a worktree only becomes removable
|
||||||
|
when that owning PR is unambiguous and merged, the worktree head is
|
||||||
|
already contained in authoritative master, and nothing else protects it —
|
||||||
|
no open or competing PR, lease, issue lock, live session, dirty file, or
|
||||||
|
protected/control checkout. Anything unproven keeps it classified as
|
||||||
|
active issue work.
|
||||||
|
|
||||||
|
Fails closed if the live open-PR list, the merged-PR list, or the
|
||||||
|
control-plane lease state cannot be read: without them removability
|
||||||
|
cannot be proven, so no candidates are returned.
|
||||||
|
|
||||||
Args:
|
Args:
|
||||||
remote: Known instance — 'dadeschools' or 'prgs'.
|
remote: Known instance — 'dadeschools' or 'prgs'.
|
||||||
host: Override the Gitea host.
|
host: Override the Gitea host.
|
||||||
org: Override the owner/organization.
|
org: Override the owner/organization.
|
||||||
repo: Override the repository name.
|
repo: Override the repository name.
|
||||||
ttl_hours: Age (hours) after which a clean issue/conflict-fix
|
ttl_hours: Age (hours) after which a clean conflict-fix worktree
|
||||||
worktree becomes stale-removable (default from
|
becomes stale-removable (default from GITEA_WORKTREE_TTL_HOURS).
|
||||||
GITEA_WORKTREE_TTL_HOURS).
|
merged_pr_limit: Max closed PRs scanned for merged-PR ownership.
|
||||||
|
|
||||||
Returns:
|
Returns:
|
||||||
dict with per-worktree classifications, counts, removable
|
dict with per-worktree classifications, counts, removable
|
||||||
@@ -11654,22 +12094,84 @@ def gitea_audit_worktree_cleanup(
|
|||||||
if (pr.get("head") or {}).get("ref")
|
if (pr.get("head") or {}).get("ref")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
# #858: merged PRs are the ownership evidence that lets a landed issue
|
||||||
|
# worktree stop being reported as active work. Without them the audit can
|
||||||
|
# never agree with the PR-scoped reconciler, so treat a fetch failure the
|
||||||
|
# same way an open-PR fetch failure is treated: fail closed.
|
||||||
|
try:
|
||||||
|
closed_prs = api_get_all(
|
||||||
|
f"{repo_api_url(h, o, r)}/pulls?state=closed", auth, limit=merged_pr_limit
|
||||||
|
)
|
||||||
|
except Exception as exc:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"performed": False,
|
||||||
|
"open_pr_state_verified": True,
|
||||||
|
"merged_pr_state_verified": False,
|
||||||
|
"reasons": [
|
||||||
|
"could not fetch merged PRs; worktree ownership unverified "
|
||||||
|
f"(fail closed): {_redact(str(exc))}"
|
||||||
|
],
|
||||||
|
}
|
||||||
|
merged_prs = [pr for pr in closed_prs if (pr.get("merged") or pr.get("merged_at"))]
|
||||||
|
pr_index = worktree_cleanup_audit.build_pr_index(list(open_prs) + merged_prs)
|
||||||
|
|
||||||
|
# #858: the auditor already accepted lease evidence but nothing ever
|
||||||
|
# supplied it, so every worktree looked unleased. Removability is now
|
||||||
|
# reachable for issue worktrees, so authoritative control-plane leases
|
||||||
|
# must be readable or the audit fails closed.
|
||||||
|
db, lease_errs = _control_plane_db_or_error()
|
||||||
|
if db is None:
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"performed": False,
|
||||||
|
"open_pr_state_verified": True,
|
||||||
|
"merged_pr_state_verified": True,
|
||||||
|
"lease_state_verified": False,
|
||||||
|
"reasons": [
|
||||||
|
"could not read control-plane leases; worktree protection "
|
||||||
|
"unverified (fail closed)",
|
||||||
|
*lease_errs,
|
||||||
|
],
|
||||||
|
}
|
||||||
|
lease_result = lease_lifecycle.list_active_leases(
|
||||||
|
db, remote=remote, org=o, repo=r, include_non_active=False, limit=500
|
||||||
|
)
|
||||||
|
leased_issue_numbers: set[int] = set()
|
||||||
|
live_session_paths: set[str] = set()
|
||||||
|
for lease in lease_result.get("leases") or []:
|
||||||
|
if lease.get("work_kind") == "issue" and lease.get("work_number") is not None:
|
||||||
|
try:
|
||||||
|
leased_issue_numbers.add(int(lease["work_number"]))
|
||||||
|
except (TypeError, ValueError):
|
||||||
|
pass
|
||||||
|
if lease.get("worktree_path"):
|
||||||
|
live_session_paths.add(str(lease["worktree_path"]))
|
||||||
|
|
||||||
active_issue_branches: set[str] = set()
|
active_issue_branches: set[str] = set()
|
||||||
lock = merged_cleanup_reconcile.read_issue_lock(ISSUE_LOCK_FILE)
|
lock = merged_cleanup_reconcile.read_issue_lock(ISSUE_LOCK_FILE)
|
||||||
if lock and lock.get("branch_name"):
|
if lock and lock.get("branch_name"):
|
||||||
active_issue_branches.add(str(lock["branch_name"]).strip())
|
active_issue_branches.add(str(lock["branch_name"]).strip())
|
||||||
|
|
||||||
|
master_ref = f"{remote}/master" if remote in REMOTES else "origin/master"
|
||||||
report = worktree_cleanup_audit.audit_branches_directory(
|
report = worktree_cleanup_audit.audit_branches_directory(
|
||||||
_canonical_local_git_root(),
|
_canonical_local_git_root(),
|
||||||
open_pr_branches=open_pr_branches,
|
open_pr_branches=open_pr_branches,
|
||||||
active_issue_branches=active_issue_branches,
|
active_issue_branches=active_issue_branches,
|
||||||
now=datetime.now(timezone.utc),
|
now=datetime.now(timezone.utc),
|
||||||
ttl_hours=ttl_hours,
|
ttl_hours=ttl_hours,
|
||||||
|
pr_index=pr_index,
|
||||||
|
leased_issue_numbers=leased_issue_numbers,
|
||||||
|
live_session_paths=live_session_paths,
|
||||||
|
master_ref=master_ref,
|
||||||
)
|
)
|
||||||
return {
|
return {
|
||||||
"success": True,
|
"success": True,
|
||||||
"performed": False,
|
"performed": False,
|
||||||
"open_pr_state_verified": True,
|
"open_pr_state_verified": True,
|
||||||
|
"merged_pr_state_verified": True,
|
||||||
|
"lease_state_verified": True,
|
||||||
|
"master_ref": master_ref,
|
||||||
"task_mode": "work-issue",
|
"task_mode": "work-issue",
|
||||||
**report,
|
**report,
|
||||||
}
|
}
|
||||||
@@ -19203,6 +19705,12 @@ def gitea_resolve_task_capability(
|
|||||||
task: str,
|
task: str,
|
||||||
remote: str = "dadeschools",
|
remote: str = "dadeschools",
|
||||||
host: str | None = None,
|
host: str | None = None,
|
||||||
|
org: str | None = None,
|
||||||
|
repo: str | None = None,
|
||||||
|
issue_number: int | None = None,
|
||||||
|
worktree_path: str | None = None,
|
||||||
|
pr_number: int | None = None,
|
||||||
|
**kwargs: Any,
|
||||||
) -> dict:
|
) -> dict:
|
||||||
"""Read-only / side-effect free: resolve capability, profile, and namespace for a task.
|
"""Read-only / side-effect free: resolve capability, profile, and namespace for a task.
|
||||||
|
|
||||||
@@ -19219,13 +19727,14 @@ def gitea_resolve_task_capability(
|
|||||||
remote: Known remote instance name.
|
remote: Known remote instance name.
|
||||||
host: Optional override for the Gitea host.
|
host: Optional override for the Gitea host.
|
||||||
"""
|
"""
|
||||||
|
task_key = task_capability_map._canonical_preflight_task(task)
|
||||||
TASK_MAP = task_capability_map.TASK_CAPABILITY_MAP
|
TASK_MAP = task_capability_map.TASK_CAPABILITY_MAP
|
||||||
# Every fresh attempt invalidates the previous task/role stamp before any
|
# Every fresh attempt invalidates the previous task/role stamp before any
|
||||||
# fallible resolver work. Unknown/malformed tasks and unexpected failures
|
# fallible resolver work. Unknown/malformed tasks and unexpected failures
|
||||||
# therefore remain fail-closed instead of preserving stale authority.
|
# therefore remain fail-closed instead of preserving stale authority.
|
||||||
_clear_resolved_capability_stamp()
|
_clear_resolved_capability_stamp()
|
||||||
|
|
||||||
if task not in TASK_MAP:
|
if task_key not in TASK_MAP:
|
||||||
# #723: structured fail-closed unknown_task (never raise into internal_error).
|
# #723: structured fail-closed unknown_task (never raise into internal_error).
|
||||||
profile = get_profile()
|
profile = get_profile()
|
||||||
h = host or (REMOTES.get(remote, {}).get("host") if remote in REMOTES else None)
|
h = host or (REMOTES.get(remote, {}).get("host") if remote in REMOTES else None)
|
||||||
@@ -19271,8 +19780,8 @@ def gitea_resolve_task_capability(
|
|||||||
result["cleared_stale_denial"] = True
|
result["cleared_stale_denial"] = True
|
||||||
return result
|
return result
|
||||||
|
|
||||||
required_permission = task_capability_map.required_permission(task)
|
required_permission = task_capability_map.required_permission(task_key)
|
||||||
required_role = task_capability_map.required_role(task)
|
required_role = task_capability_map.required_role(task_key)
|
||||||
role_exclusive_tasks = task_capability_map.ROLE_EXCLUSIVE_TASKS
|
role_exclusive_tasks = task_capability_map.ROLE_EXCLUSIVE_TASKS
|
||||||
|
|
||||||
infra_assessment = role_session_router.assess_infra_stop(PROJECT_ROOT)
|
infra_assessment = role_session_router.assess_infra_stop(PROJECT_ROOT)
|
||||||
@@ -19458,7 +19967,10 @@ def gitea_resolve_task_capability(
|
|||||||
available_in_session = allowed_in_current_session
|
available_in_session = allowed_in_current_session
|
||||||
runtime_stale_blocker = False
|
runtime_stale_blocker = False
|
||||||
|
|
||||||
if "PYTEST_CURRENT_TEST" not in os.environ or "GITEA_FORCE_MCP_RUNTIME_CHECK" in os.environ:
|
if (
|
||||||
|
"PYTEST_CURRENT_TEST" not in os.environ
|
||||||
|
or "GITEA_FORCE_MCP_RUNTIME_CHECK" in os.environ
|
||||||
|
) and os.environ.get("GITEA_ALLOW_STALE_RUNTIME") != "1":
|
||||||
runtime_reasons = _check_mcp_runtimes_diagnostics(task, matching_profiles)
|
runtime_reasons = _check_mcp_runtimes_diagnostics(task, matching_profiles)
|
||||||
if runtime_reasons:
|
if runtime_reasons:
|
||||||
restart_required = True
|
restart_required = True
|
||||||
|
|||||||
@@ -16,11 +16,16 @@ ISSUE_LOCK_FILE = os.environ.get("GITEA_ISSUE_LOCK_FILE", "/tmp/gitea_issue_lock
|
|||||||
SOURCE_LOCK_ISSUE = "gitea_lock_issue"
|
SOURCE_LOCK_ISSUE = "gitea_lock_issue"
|
||||||
SOURCE_LOCK_ADOPTION = "gitea_lock_issue_adoption"
|
SOURCE_LOCK_ADOPTION = "gitea_lock_issue_adoption"
|
||||||
SOURCE_OPERATOR_OVERRIDE = "operator_override"
|
SOURCE_OPERATOR_OVERRIDE = "operator_override"
|
||||||
|
# #864: dirty-preserving same-claimant author-session rebind (dead owner PID).
|
||||||
|
SOURCE_DIRTY_SAME_CLAIMANT_REBIND = (
|
||||||
|
"gitea_rebind_dirty_same_claimant_author_session"
|
||||||
|
)
|
||||||
|
|
||||||
SANCTIONED_LOCK_SOURCES = frozenset({
|
SANCTIONED_LOCK_SOURCES = frozenset({
|
||||||
SOURCE_LOCK_ISSUE,
|
SOURCE_LOCK_ISSUE,
|
||||||
SOURCE_LOCK_ADOPTION,
|
SOURCE_LOCK_ADOPTION,
|
||||||
SOURCE_OPERATOR_OVERRIDE,
|
SOURCE_OPERATOR_OVERRIDE,
|
||||||
|
SOURCE_DIRTY_SAME_CLAIMANT_REBIND,
|
||||||
})
|
})
|
||||||
|
|
||||||
_OPERATOR_OVERRIDE_ENV = "GITEA_ISSUE_LOCK_OPERATOR_OVERRIDE"
|
_OPERATOR_OVERRIDE_ENV = "GITEA_ISSUE_LOCK_OPERATOR_OVERRIDE"
|
||||||
|
|||||||
@@ -566,6 +566,10 @@ def build_pr_cleanup_entry(
|
|||||||
worktree_state=worktree_state,
|
worktree_state=worktree_state,
|
||||||
active_lock=active_lock,
|
active_lock=active_lock,
|
||||||
)
|
)
|
||||||
|
planned = plan_cleanup_execution_order(
|
||||||
|
remote_assessment=remote,
|
||||||
|
local_assessment=local,
|
||||||
|
)
|
||||||
return {
|
return {
|
||||||
"pr_number": pr_number,
|
"pr_number": pr_number,
|
||||||
"issue_number": issue_number,
|
"issue_number": issue_number,
|
||||||
@@ -576,9 +580,63 @@ def build_pr_cleanup_entry(
|
|||||||
"merged": merged,
|
"merged": merged,
|
||||||
"remote_branch": remote,
|
"remote_branch": remote,
|
||||||
"local_worktree": local,
|
"local_worktree": local,
|
||||||
|
# #851: dry-run and execute share the same lifecycle order description.
|
||||||
|
"planned_execution_order": planned,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def plan_cleanup_execution_order(
|
||||||
|
*,
|
||||||
|
remote_assessment: dict[str, Any] | None,
|
||||||
|
local_assessment: dict[str, Any] | None,
|
||||||
|
) -> list[dict[str, Any]]:
|
||||||
|
"""Describe independent worktree-then-reassess-then-remote cleanup order (#851).
|
||||||
|
|
||||||
|
Remote ownership protection remains fail-closed at execute time. A worktree
|
||||||
|
that is independently safe to remove is never skipped merely because remote
|
||||||
|
deletion may be blocked by that same ``worktree_binding``.
|
||||||
|
"""
|
||||||
|
remote = remote_assessment or {}
|
||||||
|
local = local_assessment or {}
|
||||||
|
steps: list[dict[str, Any]] = []
|
||||||
|
worktree_safe = bool(local.get("safe_to_remove_worktree"))
|
||||||
|
remote_safe = bool(remote.get("safe_to_delete_remote"))
|
||||||
|
|
||||||
|
if worktree_safe:
|
||||||
|
steps.append(
|
||||||
|
{
|
||||||
|
"action": "remove_local_worktree",
|
||||||
|
"reason": "independently_safe_to_remove",
|
||||||
|
"phase": 1,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
if remote_safe:
|
||||||
|
if worktree_safe:
|
||||||
|
steps.append(
|
||||||
|
{
|
||||||
|
"action": "reassess_branch_ownership",
|
||||||
|
"reason": "after_worktree_removal_clear_worktree_binding",
|
||||||
|
"phase": 2,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
steps.append(
|
||||||
|
{
|
||||||
|
"action": "delete_remote_branch",
|
||||||
|
"reason": "only_if_independently_safe_after_reassessment",
|
||||||
|
"phase": 3,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
else:
|
||||||
|
steps.append(
|
||||||
|
{
|
||||||
|
"action": "delete_remote_branch",
|
||||||
|
"reason": "safe_to_delete_and_no_independent_worktree_removal",
|
||||||
|
"phase": 1,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
return steps
|
||||||
|
|
||||||
|
|
||||||
def build_reconciliation_report(
|
def build_reconciliation_report(
|
||||||
*,
|
*,
|
||||||
project_root: str,
|
project_root: str,
|
||||||
|
|||||||
@@ -73,6 +73,8 @@ AUTHOR_TASKS = frozenset({
|
|||||||
"claim_issue",
|
"claim_issue",
|
||||||
"create_branch",
|
"create_branch",
|
||||||
"push_branch",
|
"push_branch",
|
||||||
|
"bootstrap_author_issue_worktree",
|
||||||
|
"gitea_bootstrap_author_issue_worktree",
|
||||||
"create_pr",
|
"create_pr",
|
||||||
"comment_pr",
|
"comment_pr",
|
||||||
"address_pr_change_requests",
|
"address_pr_change_requests",
|
||||||
|
|||||||
@@ -32,6 +32,17 @@ TASK_CAPABILITY_MAP: dict[str, dict[str, str]] = {
|
|||||||
"permission": "gitea.issue.comment",
|
"permission": "gitea.issue.comment",
|
||||||
"role": "author",
|
"role": "author",
|
||||||
},
|
},
|
||||||
|
# #864: dirty-preserving same-claimant author-session rebind (dead owner PID).
|
||||||
|
# Author MCP tool path. Reconciler execute is gated inside the tool via
|
||||||
|
# authorize_reconciler_execute + role_kind checks (not this map entry).
|
||||||
|
"rebind_dirty_same_claimant_author_session": {
|
||||||
|
"permission": "gitea.issue.comment",
|
||||||
|
"role": "author",
|
||||||
|
},
|
||||||
|
"gitea_rebind_dirty_same_claimant_author_session": {
|
||||||
|
"permission": "gitea.issue.comment",
|
||||||
|
"role": "author",
|
||||||
|
},
|
||||||
"set_issue_labels": {
|
"set_issue_labels": {
|
||||||
"permission": "gitea.issue.comment",
|
"permission": "gitea.issue.comment",
|
||||||
"role": "author",
|
"role": "author",
|
||||||
@@ -58,6 +69,14 @@ TASK_CAPABILITY_MAP: dict[str, dict[str, str]] = {
|
|||||||
"permission": "gitea.branch.create",
|
"permission": "gitea.branch.create",
|
||||||
"role": "author",
|
"role": "author",
|
||||||
},
|
},
|
||||||
|
"bootstrap_author_issue_worktree": {
|
||||||
|
"permission": "gitea.branch.create",
|
||||||
|
"role": "author",
|
||||||
|
},
|
||||||
|
"gitea_bootstrap_author_issue_worktree": {
|
||||||
|
"permission": "gitea.branch.create",
|
||||||
|
"role": "author",
|
||||||
|
},
|
||||||
"push_branch": {
|
"push_branch": {
|
||||||
"permission": "gitea.branch.push",
|
"permission": "gitea.branch.push",
|
||||||
"role": "author",
|
"role": "author",
|
||||||
@@ -477,6 +496,8 @@ TASK_CAPABILITY_MAP: dict[str, dict[str, str]] = {
|
|||||||
# merger lease (#763).
|
# merger lease (#763).
|
||||||
_PREFLIGHT_TASK_TRANSITIONS = frozenset({
|
_PREFLIGHT_TASK_TRANSITIONS = frozenset({
|
||||||
("review_pr", "acquire_reviewer_pr_lease"),
|
("review_pr", "acquire_reviewer_pr_lease"),
|
||||||
|
("work_issue", "bootstrap_author_issue_worktree"),
|
||||||
|
("bootstrap_author_issue_worktree", "lock_issue"),
|
||||||
})
|
})
|
||||||
|
|
||||||
|
|
||||||
@@ -523,6 +544,8 @@ ROLE_EXCLUSIVE_TASKS: frozenset[str] = frozenset(
|
|||||||
"gitea_release_merger_pr_lease",
|
"gitea_release_merger_pr_lease",
|
||||||
"create_branch",
|
"create_branch",
|
||||||
"push_branch",
|
"push_branch",
|
||||||
|
"bootstrap_author_issue_worktree",
|
||||||
|
"gitea_bootstrap_author_issue_worktree",
|
||||||
"publish_unpublished_branch",
|
"publish_unpublished_branch",
|
||||||
"create_pr",
|
"create_pr",
|
||||||
"commit_files",
|
"commit_files",
|
||||||
@@ -548,6 +571,7 @@ ISSUE_MUTATION_TOOL_TASKS: dict[str, str] = {
|
|||||||
"gitea_set_issue_labels": "set_issue_labels",
|
"gitea_set_issue_labels": "set_issue_labels",
|
||||||
"gitea_cleanup_terminal_pr_labels": "cleanup_terminal_pr_labels",
|
"gitea_cleanup_terminal_pr_labels": "cleanup_terminal_pr_labels",
|
||||||
"gitea_create_label": "create_label",
|
"gitea_create_label": "create_label",
|
||||||
|
"gitea_bootstrap_author_issue_worktree": "bootstrap_author_issue_worktree",
|
||||||
"gitea_commit_files": "commit_files",
|
"gitea_commit_files": "commit_files",
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,483 @@
|
|||||||
|
"""Regression test suite for native author issue worktree bootstrap (#850)."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import shutil
|
||||||
|
import subprocess
|
||||||
|
import tempfile
|
||||||
|
import unittest
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
import author_issue_bootstrap
|
||||||
|
import task_capability_map
|
||||||
|
|
||||||
|
|
||||||
|
def _concurrent_bootstrap_worker(args: tuple[str, int, str, str, str, str]) -> dict:
|
||||||
|
repo_dir, issue_num, key, lock_dir, journal_dir, master_sha = args
|
||||||
|
os.environ["GITEA_BOOTSTRAP_JOURNAL_DIR"] = journal_dir
|
||||||
|
return author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=issue_num,
|
||||||
|
canonical_repo_root=repo_dir,
|
||||||
|
expected_base_sha=master_sha,
|
||||||
|
idempotency_key=key,
|
||||||
|
lock_dir=lock_dir,
|
||||||
|
owner_session="session-concurrent-test",
|
||||||
|
active_identity="jcwalker3",
|
||||||
|
active_profile="prgs-author",
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class TestAuthorIssueBootstrap(unittest.TestCase):
|
||||||
|
"""Test suite covering AC1-AC10 and comment #14959 specification."""
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
|
self.tmp_dir = tempfile.mkdtemp(prefix="test_bootstrap_")
|
||||||
|
self.repo_dir = os.path.join(self.tmp_dir, "repo")
|
||||||
|
os.makedirs(self.repo_dir)
|
||||||
|
|
||||||
|
# Initialize synthetic git repo
|
||||||
|
subprocess.run(["git", "init", "-b", "master"], cwd=self.repo_dir, check=True, capture_output=True)
|
||||||
|
subprocess.run(["git", "config", "user.name", "Test User"], cwd=self.repo_dir, check=True)
|
||||||
|
subprocess.run(["git", "config", "user.email", "[email protected]"], cwd=self.repo_dir, check=True)
|
||||||
|
|
||||||
|
readme = os.path.join(self.repo_dir, "README.md")
|
||||||
|
with open(readme, "w", encoding="utf-8") as f:
|
||||||
|
f.write("# Test Repo\n")
|
||||||
|
subprocess.run(["git", "add", "README.md"], cwd=self.repo_dir, check=True, capture_output=True)
|
||||||
|
subprocess.run(["git", "commit", "-m", "initial commit"], cwd=self.repo_dir, check=True, capture_output=True)
|
||||||
|
|
||||||
|
rev_res = subprocess.run(["git", "rev-parse", "HEAD"], cwd=self.repo_dir, capture_output=True, text=True, check=True)
|
||||||
|
self.master_sha = rev_res.stdout.strip()
|
||||||
|
|
||||||
|
self.branches_dir = os.path.join(self.repo_dir, "branches")
|
||||||
|
os.makedirs(self.branches_dir, exist_ok=True)
|
||||||
|
self.lock_dir = os.path.join(self.tmp_dir, "locks")
|
||||||
|
os.makedirs(self.lock_dir, exist_ok=True)
|
||||||
|
self.journal_dir = os.path.join(self.tmp_dir, "journals")
|
||||||
|
os.makedirs(self.journal_dir, exist_ok=True)
|
||||||
|
os.environ["GITEA_BOOTSTRAP_JOURNAL_DIR"] = self.journal_dir
|
||||||
|
|
||||||
|
def tearDown(self):
|
||||||
|
os.environ.pop("GITEA_BOOTSTRAP_JOURNAL_DIR", None)
|
||||||
|
shutil.rmtree(self.tmp_dir, ignore_errors=True)
|
||||||
|
|
||||||
|
def test_bootstrap_success_path(self):
|
||||||
|
"""AC1/AC3/AC8: Successful bootstrap creates branch, worktree, registration, and lock proof."""
|
||||||
|
key = "test_key_success_1"
|
||||||
|
res = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
assignment_id="asn-12345",
|
||||||
|
lease_id="lease-67890",
|
||||||
|
expected_base_sha=self.master_sha,
|
||||||
|
idempotency_key=key,
|
||||||
|
remote="prgs",
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
)
|
||||||
|
self.assertTrue(res.get("success"), f"Bootstrap failed: {res}")
|
||||||
|
self.assertFalse(res.get("replayed"))
|
||||||
|
self.assertEqual(res.get("issue_number"), 850)
|
||||||
|
self.assertEqual(res.get("base_sha"), self.master_sha)
|
||||||
|
self.assertIn("branches/fix-issue-850-native-mcp-bootstrap", res.get("worktree_path"))
|
||||||
|
|
||||||
|
# Verify worktree directory exists and is registered
|
||||||
|
worktree_path = res["worktree_path"]
|
||||||
|
self.assertTrue(os.path.isdir(worktree_path))
|
||||||
|
|
||||||
|
wt_list = subprocess.run(["git", "-C", self.repo_dir, "worktree", "list"], capture_output=True, text=True, check=True)
|
||||||
|
self.assertIn(worktree_path, wt_list.stdout)
|
||||||
|
|
||||||
|
# Verify phase journal written
|
||||||
|
journal = author_issue_bootstrap.load_phase_journal(key, journal_dir=self.lock_dir)
|
||||||
|
self.assertIsNotNone(journal)
|
||||||
|
self.assertTrue(journal.get("completed"))
|
||||||
|
self.assertEqual(journal.get("current_phase"), author_issue_bootstrap.PHASE_7_TRANSITION_COMPLETED)
|
||||||
|
|
||||||
|
def test_idempotent_replay(self):
|
||||||
|
"""Item 2: Replaying with identical key returns cached transition without duplicate creation."""
|
||||||
|
key = "test_key_idempotent_1"
|
||||||
|
res1 = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
idempotency_key=key,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
)
|
||||||
|
self.assertTrue(res1["success"], f"res1 failed: {res1}")
|
||||||
|
self.assertFalse(res1.get("replayed"))
|
||||||
|
|
||||||
|
# Second call
|
||||||
|
res2 = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
idempotency_key=key,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
)
|
||||||
|
self.assertTrue(res2["success"], f"res2 failed: {res2}")
|
||||||
|
self.assertTrue(res2.get("replayed"))
|
||||||
|
self.assertEqual(res1["worktree_path"], res2["worktree_path"])
|
||||||
|
|
||||||
|
def test_stale_concurrency_pin_refusal(self):
|
||||||
|
"""Item 3: Mismatched expected base SHA fails closed without silent rebasing."""
|
||||||
|
stale_sha = "0000000000000000000000000000000000000000"
|
||||||
|
res = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
expected_base_sha=stale_sha,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
)
|
||||||
|
self.assertFalse(res["success"])
|
||||||
|
self.assertEqual(res.get("reason_code"), "stale_concurrency_pin")
|
||||||
|
self.assertIn("exact_next_action", res)
|
||||||
|
|
||||||
|
def test_path_outside_branches_root_refusal(self):
|
||||||
|
"""Item 6: Worktree path outside branches/ root is refused."""
|
||||||
|
outside_path = os.path.join(self.tmp_dir, "outside_worktree")
|
||||||
|
res = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
worktree_path=outside_path,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
)
|
||||||
|
self.assertFalse(res["success"])
|
||||||
|
self.assertEqual(res.get("reason_code"), "path_outside_canonical_branches_root")
|
||||||
|
|
||||||
|
def test_preexisting_dirty_worktree_preservation(self):
|
||||||
|
"""Item 6: Preexisting dirty worktree fails closed and is NOT modified or cleaned."""
|
||||||
|
branch = "fix/issue-850-dirty-test"
|
||||||
|
wt_path = os.path.join(self.branches_dir, "fix-issue-850-dirty-test")
|
||||||
|
subprocess.run(["git", "-C", self.repo_dir, "worktree", "add", "-b", branch, wt_path], check=True, capture_output=True)
|
||||||
|
|
||||||
|
# Create dirty untracked file
|
||||||
|
dirty_file = os.path.join(wt_path, "dirty.txt")
|
||||||
|
with open(dirty_file, "w") as f:
|
||||||
|
f.write("dirty edits\n")
|
||||||
|
|
||||||
|
res = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
branch_name=branch,
|
||||||
|
worktree_path=wt_path,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
)
|
||||||
|
self.assertFalse(res["success"])
|
||||||
|
self.assertEqual(res.get("reason_code"), "preexisting_dirty_worktree")
|
||||||
|
|
||||||
|
# Prove dirty file is preserved byte-for-byte
|
||||||
|
self.assertTrue(os.path.exists(dirty_file))
|
||||||
|
with open(dirty_file, "r") as f:
|
||||||
|
self.assertEqual(f.read(), "dirty edits\n")
|
||||||
|
|
||||||
|
def test_compensating_recovery_on_failed_phase(self):
|
||||||
|
"""AC4/Item 4: Failure during transition rolls back ONLY newly created artifacts."""
|
||||||
|
key = "test_key_recovery_1"
|
||||||
|
# Simulate partial progress in journal
|
||||||
|
journal = {
|
||||||
|
"idempotency_key": key,
|
||||||
|
"issue_number": 850,
|
||||||
|
"branch_name": "fix/issue-850-recovery-test",
|
||||||
|
"worktree_path": os.path.join(self.branches_dir, "fix-issue-850-recovery-test"),
|
||||||
|
"artifacts_created": {
|
||||||
|
"branch_created": True,
|
||||||
|
"worktree_dir_created": True,
|
||||||
|
"worktree_registered": True,
|
||||||
|
"lock_created": False,
|
||||||
|
},
|
||||||
|
"failure_reason": "simulated lock failure",
|
||||||
|
"current_phase": author_issue_bootstrap.PHASE_5_REGISTRATION_VERIFIED,
|
||||||
|
"completed": False,
|
||||||
|
}
|
||||||
|
# Create the branch and worktree manually to simulate partial state
|
||||||
|
subprocess.run(["git", "-C", self.repo_dir, "branch", journal["branch_name"]], check=True, capture_output=True)
|
||||||
|
subprocess.run(["git", "-C", self.repo_dir, "worktree", "add", journal["worktree_path"], journal["branch_name"]], check=True, capture_output=True)
|
||||||
|
|
||||||
|
# Run compensating recovery
|
||||||
|
rec = author_issue_bootstrap.run_compensating_recovery(journal, self.repo_dir)
|
||||||
|
self.assertTrue(rec["executed"])
|
||||||
|
self.assertIn(f"worktree_path:{journal['worktree_path']}", rec["rolled_back"])
|
||||||
|
self.assertIn(f"branch:{journal['branch_name']}", rec["rolled_back"])
|
||||||
|
|
||||||
|
# Prove worktree directory and branch were rolled back
|
||||||
|
self.assertFalse(os.path.exists(journal["worktree_path"]))
|
||||||
|
branch_check = subprocess.run(["git", "-C", self.repo_dir, "rev-parse", "--verify", journal["branch_name"]], capture_output=True, text=True, check=False)
|
||||||
|
self.assertNotEqual(branch_check.returncode, 0)
|
||||||
|
|
||||||
|
def test_cross_process_concurrency(self):
|
||||||
|
"""Review #525 Finding 1: Genuine cross-process concurrency locking prevents corruption."""
|
||||||
|
import concurrent.futures
|
||||||
|
|
||||||
|
key = "test_concurrent_key_850"
|
||||||
|
args = (self.repo_dir, 850, key, self.lock_dir, self.journal_dir, self.master_sha)
|
||||||
|
|
||||||
|
with concurrent.futures.ProcessPoolExecutor(max_workers=2) as executor:
|
||||||
|
fut1 = executor.submit(_concurrent_bootstrap_worker, args)
|
||||||
|
fut2 = executor.submit(_concurrent_bootstrap_worker, args)
|
||||||
|
res1 = fut1.result(timeout=10)
|
||||||
|
res2 = fut2.result(timeout=10)
|
||||||
|
|
||||||
|
self.assertTrue(res1["success"], f"res1 failed: {res1}")
|
||||||
|
self.assertTrue(res2["success"], f"res2 failed: {res2}")
|
||||||
|
# One process performs creation, the other process receives idempotent replay
|
||||||
|
replayed_count = sum(1 for r in (res1, res2) if r.get("replayed"))
|
||||||
|
created_count = sum(1 for r in (res1, res2) if not r.get("replayed"))
|
||||||
|
self.assertEqual(replayed_count, 1)
|
||||||
|
self.assertEqual(created_count, 1)
|
||||||
|
self.assertEqual(res1["worktree_path"], res2["worktree_path"])
|
||||||
|
|
||||||
|
def test_interrupted_replay_preserves_artifacts_created_provenance(self):
|
||||||
|
"""Review #525 Finding 2: Replaying incomplete journal preserves creation provenance monotonically."""
|
||||||
|
key = "test_key_interrupted_replay_1"
|
||||||
|
branch = "fix/issue-850-interrupted-replay"
|
||||||
|
wt_path = os.path.join(self.branches_dir, "fix-issue-850-interrupted-replay")
|
||||||
|
|
||||||
|
# Simulate Phase 2/3 completion where branch and worktree directory were created by this transition
|
||||||
|
journal = {
|
||||||
|
"idempotency_key": key,
|
||||||
|
"issue_number": 850,
|
||||||
|
"branch_name": branch,
|
||||||
|
"worktree_path": wt_path,
|
||||||
|
"active_identity": "jcwalker3",
|
||||||
|
"active_profile": "prgs-author",
|
||||||
|
"remote": "prgs",
|
||||||
|
"org": "Scaled-Tech-Consulting",
|
||||||
|
"repo": "Gitea-Tools",
|
||||||
|
"phases": {
|
||||||
|
author_issue_bootstrap.PHASE_1_REQUEST_ACCEPTED: {"status": "completed"},
|
||||||
|
author_issue_bootstrap.PHASE_2_BRANCH_CONFIRMED: {"status": "completed", "created": True},
|
||||||
|
},
|
||||||
|
"artifacts_created": {
|
||||||
|
"branch_created": True,
|
||||||
|
"worktree_dir_created": True,
|
||||||
|
"worktree_registered": True,
|
||||||
|
"lock_created": False,
|
||||||
|
},
|
||||||
|
"current_phase": author_issue_bootstrap.PHASE_3_PATH_RESERVED,
|
||||||
|
"completed": False,
|
||||||
|
}
|
||||||
|
# Pre-create the branch and worktree on disk to simulate partial state after crash
|
||||||
|
subprocess.run(["git", "-C", self.repo_dir, "branch", branch, self.master_sha], check=True, capture_output=True)
|
||||||
|
subprocess.run(["git", "-C", self.repo_dir, "worktree", "add", wt_path, branch], check=True, capture_output=True)
|
||||||
|
author_issue_bootstrap.save_phase_journal(journal, journal_dir=self.lock_dir)
|
||||||
|
|
||||||
|
# Now resume/replay the transition but simulate lock binding failure during Phase 6
|
||||||
|
with mock.patch("issue_lock_store.bind_session_lock", side_effect=RuntimeError("Lock failure test")):
|
||||||
|
res = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
branch_name=branch,
|
||||||
|
worktree_path=wt_path,
|
||||||
|
idempotency_key=key,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
)
|
||||||
|
|
||||||
|
self.assertFalse(res["success"])
|
||||||
|
self.assertEqual(res.get("reason_code"), "issue_lock_acquisition_failed")
|
||||||
|
|
||||||
|
# Verify that compensating recovery correctly deleted transition-created branch & worktree
|
||||||
|
# because creation provenance was preserved across replay (NOT downgraded to False!)
|
||||||
|
self.assertFalse(os.path.exists(wt_path))
|
||||||
|
branch_check = subprocess.run(["git", "-C", self.repo_dir, "rev-parse", "--verify", branch], capture_output=True, text=True, check=False)
|
||||||
|
self.assertNotEqual(branch_check.returncode, 0)
|
||||||
|
|
||||||
|
def test_transition_created_only_compensation(self):
|
||||||
|
"""Review #525 Finding 4: Preexisting branch is NOT deleted by compensation when only worktree was transition-created."""
|
||||||
|
key = "test_key_preexisting_branch_compensation"
|
||||||
|
preexisting_branch = "fix/issue-850-preexisting"
|
||||||
|
wt_path = os.path.join(self.branches_dir, "fix-issue-850-preexisting")
|
||||||
|
|
||||||
|
# Create branch BEFORE bootstrap (preexisting branch)
|
||||||
|
subprocess.run(["git", "-C", self.repo_dir, "branch", preexisting_branch, self.master_sha], check=True, capture_output=True)
|
||||||
|
|
||||||
|
# Call bootstrap with simulated failure during Phase 6 (lock binding)
|
||||||
|
with mock.patch("issue_lock_store.bind_session_lock", side_effect=RuntimeError("Simulated lock failure")):
|
||||||
|
res = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
branch_name=preexisting_branch,
|
||||||
|
worktree_path=wt_path,
|
||||||
|
idempotency_key=key,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
)
|
||||||
|
|
||||||
|
self.assertFalse(res["success"])
|
||||||
|
# Worktree dir was created by transition -> removed by compensation
|
||||||
|
self.assertFalse(os.path.exists(wt_path))
|
||||||
|
|
||||||
|
# Preexisting branch was NOT created by transition -> MUST BE PRESERVED!
|
||||||
|
branch_check = subprocess.run(["git", "-C", self.repo_dir, "rev-parse", "--verify", preexisting_branch], capture_output=True, text=True, check=False)
|
||||||
|
self.assertEqual(branch_check.returncode, 0, "Preexisting branch was deleted by mistake!")
|
||||||
|
|
||||||
|
def test_incompatible_idempotency_replay_refusal(self):
|
||||||
|
"""Review #525 Finding 4: Replaying key with incompatible parameters returns refusal."""
|
||||||
|
key = "test_key_incompatible_replay"
|
||||||
|
res1 = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
branch_name="fix/issue-850-param-a",
|
||||||
|
idempotency_key=key,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
)
|
||||||
|
self.assertTrue(res1["success"])
|
||||||
|
|
||||||
|
# Second call with different branch_name
|
||||||
|
res2 = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
branch_name="fix/issue-850-param-b",
|
||||||
|
idempotency_key=key,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
)
|
||||||
|
self.assertFalse(res2["success"])
|
||||||
|
self.assertEqual(res2.get("reason_code"), "incompatible_idempotency_replay")
|
||||||
|
|
||||||
|
def test_exact_next_action_satisfiable_via_mcp(self):
|
||||||
|
"""Review #525 Finding 4: exact_next_action provides satisfiable MCP actions, not shell commands."""
|
||||||
|
key = "test_key_next_action_mcp"
|
||||||
|
stale_sha = "0000000000000000000000000000000000000000"
|
||||||
|
res = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
expected_base_sha=stale_sha,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
)
|
||||||
|
next_action = res.get("exact_next_action", "")
|
||||||
|
self.assertNotIn("scripts/worktree-start", next_action)
|
||||||
|
self.assertNotIn("git worktree add", next_action)
|
||||||
|
self.assertNotIn("bash", next_action.lower())
|
||||||
|
|
||||||
|
def test_missing_owner_session_refusal(self):
|
||||||
|
"""Finding D: Missing owner_session context fails closed with typed refusal and zero mutation."""
|
||||||
|
res = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
owner_session=None,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
)
|
||||||
|
self.assertFalse(res["success"])
|
||||||
|
self.assertEqual(res.get("reason_code"), "missing_owner_session")
|
||||||
|
self.assertIn("exact_next_action", res)
|
||||||
|
|
||||||
|
def test_symlink_lock_file_refusal(self):
|
||||||
|
"""Finding C: BootstrapTransitionLock refuses to follow symlinks."""
|
||||||
|
key = "test_symlink_lock_key"
|
||||||
|
safe_key = "".join(c if c.isalnum() or c in ("-", "_", ".") else "_" for c in key)
|
||||||
|
lock_path = os.path.join(self.lock_dir, f"{safe_key}.lock")
|
||||||
|
target_file = os.path.join(self.tmp_dir, "fake_target")
|
||||||
|
with open(target_file, "w") as f:
|
||||||
|
f.write("target")
|
||||||
|
os.symlink(target_file, lock_path)
|
||||||
|
|
||||||
|
with self.assertRaises(RuntimeError) as ctx:
|
||||||
|
with author_issue_bootstrap.BootstrapTransitionLock(key, journal_dir=self.lock_dir):
|
||||||
|
pass
|
||||||
|
self.assertIn("symlink", str(ctx.exception).lower())
|
||||||
|
|
||||||
|
def test_lock_directory_escape_refusal(self):
|
||||||
|
"""Finding C: BootstrapTransitionLock refuses keys that escape lock directory."""
|
||||||
|
with mock.patch("os.path.abspath", return_value="/tmp/outside/evil_key.lock"):
|
||||||
|
with self.assertRaises(RuntimeError) as ctx:
|
||||||
|
author_issue_bootstrap.BootstrapTransitionLock("key", journal_dir=self.lock_dir)
|
||||||
|
self.assertIn("escapes", str(ctx.exception).lower())
|
||||||
|
|
||||||
|
def test_missing_active_identity_refusal(self):
|
||||||
|
"""F-5: Missing active_identity parameter fails closed."""
|
||||||
|
res = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
active_identity=None,
|
||||||
|
active_profile="prgs-author",
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
)
|
||||||
|
self.assertFalse(res["success"])
|
||||||
|
self.assertEqual(res.get("reason_code"), "missing_active_identity")
|
||||||
|
|
||||||
|
def test_missing_active_profile_refusal(self):
|
||||||
|
"""F-5: Missing active_profile parameter fails closed."""
|
||||||
|
res = author_issue_bootstrap.bootstrap_author_issue_worktree(
|
||||||
|
issue_number=850,
|
||||||
|
canonical_repo_root=self.repo_dir,
|
||||||
|
owner_session="session-test-1234",
|
||||||
|
active_identity="jcwalker3",
|
||||||
|
active_profile=None,
|
||||||
|
lock_dir=self.lock_dir,
|
||||||
|
)
|
||||||
|
self.assertFalse(res["success"])
|
||||||
|
self.assertEqual(res.get("reason_code"), "missing_active_profile")
|
||||||
|
|
||||||
|
def test_dirty_worktree_preserved_during_recovery(self):
|
||||||
|
"""F-4: Compensating recovery does not delete dirty worktree."""
|
||||||
|
branch = "fix/issue-850-rec-dirty"
|
||||||
|
wt_path = os.path.join(self.branches_dir, "fix-issue-850-rec-dirty")
|
||||||
|
subprocess.run(["git", "-C", self.repo_dir, "worktree", "add", "-b", branch, wt_path], check=True, capture_output=True)
|
||||||
|
dirty_file = os.path.join(wt_path, "dirty.txt")
|
||||||
|
with open(dirty_file, "w") as f:
|
||||||
|
f.write("uncommitted work")
|
||||||
|
|
||||||
|
journal = {
|
||||||
|
"idempotency_key": "test_dirty_rec",
|
||||||
|
"issue_number": 850,
|
||||||
|
"branch_name": branch,
|
||||||
|
"worktree_path": wt_path,
|
||||||
|
"artifacts_created": {
|
||||||
|
"worktree_dir_created": True,
|
||||||
|
"worktree_registered": True,
|
||||||
|
},
|
||||||
|
"failure_reason": "test dirty recovery",
|
||||||
|
}
|
||||||
|
rec = author_issue_bootstrap.run_compensating_recovery(journal, self.repo_dir, journal_dir=self.lock_dir)
|
||||||
|
self.assertTrue(os.path.exists(wt_path))
|
||||||
|
self.assertIn(f"worktree_path_preserved_dirty:{wt_path}", rec["rolled_back"])
|
||||||
|
|
||||||
|
def test_branch_with_commits_preserved_during_recovery(self):
|
||||||
|
"""F-4: Compensating recovery does not delete branch with author commits."""
|
||||||
|
branch = "fix/issue-850-rec-commits"
|
||||||
|
subprocess.run(["git", "-C", self.repo_dir, "branch", branch, self.master_sha], check=True, capture_output=True)
|
||||||
|
# Add a commit on the branch
|
||||||
|
wt_path = os.path.join(self.branches_dir, "fix-issue-850-rec-commits")
|
||||||
|
subprocess.run(["git", "-C", self.repo_dir, "worktree", "add", wt_path, branch], check=True, capture_output=True)
|
||||||
|
cfile = os.path.join(wt_path, "commit.txt")
|
||||||
|
with open(cfile, "w") as f:
|
||||||
|
f.write("author commit")
|
||||||
|
subprocess.run(["git", "-C", wt_path, "add", "commit.txt"], check=True, capture_output=True)
|
||||||
|
subprocess.run(["git", "-C", wt_path, "commit", "-m", "author commit"], check=True, capture_output=True)
|
||||||
|
subprocess.run(["git", "-C", self.repo_dir, "worktree", "remove", "--force", wt_path], check=True, capture_output=True)
|
||||||
|
|
||||||
|
journal = {
|
||||||
|
"idempotency_key": "test_commits_rec",
|
||||||
|
"issue_number": 850,
|
||||||
|
"branch_name": branch,
|
||||||
|
"resolved_base_sha": self.master_sha,
|
||||||
|
"artifacts_created": {
|
||||||
|
"branch_created": True,
|
||||||
|
},
|
||||||
|
"failure_reason": "test commit branch recovery",
|
||||||
|
}
|
||||||
|
rec = author_issue_bootstrap.run_compensating_recovery(journal, self.repo_dir, journal_dir=self.lock_dir)
|
||||||
|
branch_check = subprocess.run(["git", "-C", self.repo_dir, "rev-parse", "--verify", branch], capture_output=True, text=True, check=False)
|
||||||
|
self.assertEqual(branch_check.returncode, 0, "Branch with commits was deleted!")
|
||||||
|
self.assertIn(f"branch_preserved_commits:{branch}", rec["rolled_back"])
|
||||||
|
|
||||||
|
def test_task_capability_map_integration(self):
|
||||||
|
"""Verify task_capability_map has bootstrap_author_issue_worktree configured correctly."""
|
||||||
|
self.assertEqual(task_capability_map.required_role("bootstrap_author_issue_worktree"), "author")
|
||||||
|
self.assertEqual(task_capability_map.required_permission("bootstrap_author_issue_worktree"), "gitea.branch.create")
|
||||||
|
self.assertTrue(task_capability_map.preflight_task_matches("work_issue", "bootstrap_author_issue_worktree"))
|
||||||
|
self.assertTrue(task_capability_map.preflight_task_matches("bootstrap_author_issue_worktree", "lock_issue"))
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
unittest.main()
|
||||||
|
|
||||||
@@ -28,6 +28,21 @@ class TestPathUnderBranches(unittest.TestCase):
|
|||||||
amw.is_path_under_branches("/repo/other-checkout", self.ROOT)
|
amw.is_path_under_branches("/repo/other-checkout", self.ROOT)
|
||||||
)
|
)
|
||||||
|
|
||||||
|
def test_unrelated_branches_dir_fails(self):
|
||||||
|
self.assertFalse(
|
||||||
|
amw.is_path_under_branches("/tmp/branches/evil", self.ROOT)
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_prefix_confusion_fails(self):
|
||||||
|
self.assertFalse(
|
||||||
|
amw.is_path_under_branches(f"{self.ROOT}/branches-other/foo", self.ROOT)
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_traversal_fails(self):
|
||||||
|
self.assertFalse(
|
||||||
|
amw.is_path_under_branches(f"{self.ROOT}/branches/../evil", self.ROOT)
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
class TestAssessAuthorMutationWorktree(unittest.TestCase):
|
class TestAssessAuthorMutationWorktree(unittest.TestCase):
|
||||||
ROOT = "/repo/Gitea-Tools"
|
ROOT = "/repo/Gitea-Tools"
|
||||||
|
|||||||
@@ -1266,6 +1266,378 @@ class TestSecondRemediationIntegration(unittest.TestCase):
|
|||||||
self.assertIn("delete_acknowledged", delete_actions[0])
|
self.assertIn("delete_acknowledged", delete_actions[0])
|
||||||
self.assertTrue(delete_actions[0].get("verified_absent"))
|
self.assertTrue(delete_actions[0].get("verified_absent"))
|
||||||
|
|
||||||
|
def test_issue_851_worktree_removed_when_remote_blocked_only_by_worktree_binding(self):
|
||||||
|
"""#851: remote blocked by worktree_binding must not skip safe worktree removal.
|
||||||
|
|
||||||
|
Lifecycle: remove clean owned worktree → reassess ownership → delete
|
||||||
|
remote only if independently safe. Unrelated entries stay untouched.
|
||||||
|
"""
|
||||||
|
from mcp_server import gitea_reconcile_merged_cleanups
|
||||||
|
|
||||||
|
target_branch = "fix/issue-844-exclude-epic-containers"
|
||||||
|
foreign_branch = "fix/issue-999-unrelated-active"
|
||||||
|
worktree_path = "/tmp/branches/fix-issue-844-exclude-epic-containers"
|
||||||
|
ownership_calls = []
|
||||||
|
remove_calls = []
|
||||||
|
delete_api_calls = []
|
||||||
|
|
||||||
|
def fake_collect(**kwargs):
|
||||||
|
ownership_calls.append(dict(kwargs))
|
||||||
|
# Ownership is reassessed *after* independent worktree removal (#851).
|
||||||
|
# Target worktree is already gone → no worktree_binding remains.
|
||||||
|
# Foreign branch keeps an active author lease → remote delete blocked.
|
||||||
|
if kwargs.get("branch") == foreign_branch:
|
||||||
|
# Match session-bound org/repo + host used by the tool resolve path.
|
||||||
|
return {
|
||||||
|
"records": [
|
||||||
|
{
|
||||||
|
"category": guard.OWNERSHIP_CATEGORY_AUTHOR_LEASE,
|
||||||
|
"status": "active",
|
||||||
|
"remote": kwargs.get("remote") or "prgs",
|
||||||
|
"host": kwargs.get("host") or "gitea.example.com",
|
||||||
|
"org": kwargs.get("org") or "Scaled-Tech-Consulting",
|
||||||
|
"repo": kwargs.get("repo") or "Gitea-Tools",
|
||||||
|
"branch": foreign_branch,
|
||||||
|
"reclaim_allowed": False,
|
||||||
|
}
|
||||||
|
],
|
||||||
|
"inventory_error": False,
|
||||||
|
}
|
||||||
|
return {"records": [], "inventory_error": False}
|
||||||
|
|
||||||
|
def fake_remove(project_root, branch, worktree_path=None):
|
||||||
|
remove_calls.append(
|
||||||
|
{"branch": branch, "worktree_path": worktree_path}
|
||||||
|
)
|
||||||
|
return {
|
||||||
|
"success": True,
|
||||||
|
"performed": True,
|
||||||
|
"message": f"removed worktree {worktree_path}",
|
||||||
|
"worktree_path": worktree_path,
|
||||||
|
}
|
||||||
|
|
||||||
|
def fake_probe(h, o, r, auth, br):
|
||||||
|
return guard.classify_branch_readback_http_status(
|
||||||
|
404, not_found_scope=guard.NOT_FOUND_SCOPE_BRANCH
|
||||||
|
)
|
||||||
|
|
||||||
|
def fake_api(method, url, auth, **kwargs):
|
||||||
|
if method == "DELETE":
|
||||||
|
delete_api_calls.append(url)
|
||||||
|
return {}
|
||||||
|
|
||||||
|
report = {
|
||||||
|
"entries": [
|
||||||
|
{
|
||||||
|
"pr_number": 848,
|
||||||
|
"head_branch": target_branch,
|
||||||
|
"remote_branch": {"safe_to_delete_remote": True},
|
||||||
|
"local_worktree": {
|
||||||
|
"safe_to_remove_worktree": True,
|
||||||
|
"worktree_path": worktree_path,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"pr_number": 999,
|
||||||
|
"head_branch": foreign_branch,
|
||||||
|
"remote_branch": {"safe_to_delete_remote": True},
|
||||||
|
"local_worktree": {
|
||||||
|
"safe_to_remove_worktree": False,
|
||||||
|
"worktree_path": None,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
],
|
||||||
|
"reviewer_scratch_entries": [],
|
||||||
|
}
|
||||||
|
patch(
|
||||||
|
"mcp_server.get_profile",
|
||||||
|
return_value={
|
||||||
|
"profile_name": "prgs-reconciler",
|
||||||
|
"role": "reconciler",
|
||||||
|
"allowed_operations": [
|
||||||
|
"gitea.read",
|
||||||
|
"gitea.branch.delete",
|
||||||
|
"gitea.pr.close",
|
||||||
|
],
|
||||||
|
"forbidden_operations": [],
|
||||||
|
},
|
||||||
|
).start()
|
||||||
|
patch("mcp_server.api_get_all", return_value=[]).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.merged_cleanup_reconcile.build_reconciliation_report",
|
||||||
|
return_value=report,
|
||||||
|
).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.merged_cleanup_reconcile.discover_reviewer_scratch_worktrees",
|
||||||
|
return_value=[],
|
||||||
|
).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.audit_reconciliation_mode.check_cleanup_execution_allowed",
|
||||||
|
return_value=(True, []),
|
||||||
|
).start()
|
||||||
|
patch("mcp_server.verify_preflight_purity", return_value=None).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server._collect_branch_ownership_records",
|
||||||
|
side_effect=fake_collect,
|
||||||
|
).start()
|
||||||
|
patch("mcp_server._probe_remote_branch", side_effect=fake_probe).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.merged_cleanup_reconcile.remove_local_worktree",
|
||||||
|
side_effect=fake_remove,
|
||||||
|
).start()
|
||||||
|
self.mock_api.side_effect = fake_api
|
||||||
|
|
||||||
|
res = gitea_reconcile_merged_cleanups(
|
||||||
|
dry_run=False,
|
||||||
|
execute_confirmed=True,
|
||||||
|
remote="prgs",
|
||||||
|
)
|
||||||
|
self.assertTrue(res.get("performed") or res.get("executed"))
|
||||||
|
actions = res.get("actions") or []
|
||||||
|
|
||||||
|
remove_actions = [
|
||||||
|
a for a in actions if a.get("action") == "remove_local_worktree"
|
||||||
|
]
|
||||||
|
self.assertEqual(len(remove_actions), 1, actions)
|
||||||
|
self.assertTrue(remove_actions[0].get("success"))
|
||||||
|
self.assertEqual(remove_calls[0]["branch"], target_branch)
|
||||||
|
self.assertEqual(remove_calls[0]["worktree_path"], worktree_path)
|
||||||
|
|
||||||
|
# Target remote delete succeeds after worktree removal + reassessment.
|
||||||
|
target_deletes = [
|
||||||
|
a
|
||||||
|
for a in actions
|
||||||
|
if a.get("action") == "delete_remote_branch"
|
||||||
|
and a.get("branch") == target_branch
|
||||||
|
]
|
||||||
|
self.assertEqual(len(target_deletes), 1, actions)
|
||||||
|
self.assertTrue(target_deletes[0].get("success"))
|
||||||
|
self.assertTrue(target_deletes[0].get("after_worktree_removal"))
|
||||||
|
self.assertTrue(target_deletes[0].get("ownership_reassessed"))
|
||||||
|
self.assertTrue(target_deletes[0].get("verified_absent"))
|
||||||
|
|
||||||
|
# Foreign branch remains protected (author lease) and is not deleted.
|
||||||
|
foreign_deletes = [
|
||||||
|
a
|
||||||
|
for a in actions
|
||||||
|
if a.get("action") == "delete_remote_branch"
|
||||||
|
and a.get("branch") == foreign_branch
|
||||||
|
]
|
||||||
|
self.assertEqual(len(foreign_deletes), 1, actions)
|
||||||
|
self.assertFalse(foreign_deletes[0].get("success"))
|
||||||
|
self.assertEqual(
|
||||||
|
foreign_deletes[0].get("blocker_kind"), "active_branch_ownership"
|
||||||
|
)
|
||||||
|
self.assertIn(
|
||||||
|
guard.OWNERSHIP_CATEGORY_AUTHOR_LEASE,
|
||||||
|
foreign_deletes[0].get("blocking_categories") or [],
|
||||||
|
)
|
||||||
|
# Only the target branch should hit the DELETE API.
|
||||||
|
self.assertEqual(len(delete_api_calls), 1)
|
||||||
|
|
||||||
|
# Ownership collected for target (post-removal) and foreign; worktree
|
||||||
|
# removal happened before target remote delete in the action log.
|
||||||
|
target_idx = next(
|
||||||
|
i
|
||||||
|
for i, a in enumerate(actions)
|
||||||
|
if a.get("action") == "remove_local_worktree"
|
||||||
|
)
|
||||||
|
delete_idx = next(
|
||||||
|
i
|
||||||
|
for i, a in enumerate(actions)
|
||||||
|
if a.get("action") == "delete_remote_branch"
|
||||||
|
and a.get("branch") == target_branch
|
||||||
|
and a.get("success")
|
||||||
|
)
|
||||||
|
self.assertLess(target_idx, delete_idx)
|
||||||
|
|
||||||
|
def test_issue_851_dirty_worktree_not_removed_and_remote_stays_protected(self):
|
||||||
|
"""#851: dirty/foreign worktrees remain protected; no unsafe cleanup."""
|
||||||
|
from mcp_server import gitea_reconcile_merged_cleanups
|
||||||
|
|
||||||
|
branch = "fix/issue-851-dirty"
|
||||||
|
remove_calls = []
|
||||||
|
|
||||||
|
def fake_collect(**kwargs):
|
||||||
|
return {
|
||||||
|
"records": [
|
||||||
|
{
|
||||||
|
"category": guard.OWNERSHIP_CATEGORY_WORKTREE_BINDING,
|
||||||
|
"status": "active",
|
||||||
|
"remote": kwargs.get("remote") or "prgs",
|
||||||
|
"host": kwargs.get("host") or "gitea.example.com",
|
||||||
|
"org": kwargs.get("org") or "Scaled-Tech-Consulting",
|
||||||
|
"repo": kwargs.get("repo") or "Gitea-Tools",
|
||||||
|
"branch": branch,
|
||||||
|
"reclaim_allowed": False,
|
||||||
|
}
|
||||||
|
],
|
||||||
|
"inventory_error": False,
|
||||||
|
}
|
||||||
|
|
||||||
|
report = {
|
||||||
|
"entries": [
|
||||||
|
{
|
||||||
|
"pr_number": 851,
|
||||||
|
"head_branch": branch,
|
||||||
|
"remote_branch": {"safe_to_delete_remote": True},
|
||||||
|
"local_worktree": {
|
||||||
|
"safe_to_remove_worktree": False,
|
||||||
|
"worktree_path": "/tmp/dirty-wt",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
],
|
||||||
|
"reviewer_scratch_entries": [],
|
||||||
|
}
|
||||||
|
patch(
|
||||||
|
"mcp_server.get_profile",
|
||||||
|
return_value={
|
||||||
|
"profile_name": "prgs-reconciler",
|
||||||
|
"role": "reconciler",
|
||||||
|
"allowed_operations": [
|
||||||
|
"gitea.read",
|
||||||
|
"gitea.branch.delete",
|
||||||
|
],
|
||||||
|
"forbidden_operations": [],
|
||||||
|
},
|
||||||
|
).start()
|
||||||
|
patch("mcp_server.api_get_all", return_value=[]).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.merged_cleanup_reconcile.build_reconciliation_report",
|
||||||
|
return_value=report,
|
||||||
|
).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.merged_cleanup_reconcile.discover_reviewer_scratch_worktrees",
|
||||||
|
return_value=[],
|
||||||
|
).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.audit_reconciliation_mode.check_cleanup_execution_allowed",
|
||||||
|
return_value=(True, []),
|
||||||
|
).start()
|
||||||
|
patch("mcp_server.verify_preflight_purity", return_value=None).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server._collect_branch_ownership_records",
|
||||||
|
side_effect=fake_collect,
|
||||||
|
).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.merged_cleanup_reconcile.remove_local_worktree",
|
||||||
|
side_effect=lambda *a, **k: remove_calls.append(k) or {
|
||||||
|
"success": True,
|
||||||
|
"performed": True,
|
||||||
|
},
|
||||||
|
).start()
|
||||||
|
self.mock_api.side_effect = lambda *a, **k: {}
|
||||||
|
|
||||||
|
res = gitea_reconcile_merged_cleanups(
|
||||||
|
dry_run=False,
|
||||||
|
execute_confirmed=True,
|
||||||
|
remote="prgs",
|
||||||
|
)
|
||||||
|
actions = res.get("actions") or []
|
||||||
|
self.assertEqual(remove_calls, [])
|
||||||
|
self.assertFalse(
|
||||||
|
any(a.get("action") == "remove_local_worktree" for a in actions)
|
||||||
|
)
|
||||||
|
deletes = [
|
||||||
|
a for a in actions if a.get("action") == "delete_remote_branch"
|
||||||
|
]
|
||||||
|
self.assertEqual(len(deletes), 1)
|
||||||
|
self.assertFalse(deletes[0].get("success"))
|
||||||
|
self.assertEqual(deletes[0].get("blocker_kind"), "active_branch_ownership")
|
||||||
|
self.assertIn(
|
||||||
|
guard.OWNERSHIP_CATEGORY_WORKTREE_BINDING,
|
||||||
|
deletes[0].get("blocking_categories") or [],
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_issue_851_idempotent_resume_when_worktree_already_absent(self):
|
||||||
|
"""#851: partial failures remain resumable and idempotent."""
|
||||||
|
from mcp_server import gitea_reconcile_merged_cleanups
|
||||||
|
|
||||||
|
branch = "fix/issue-851-resume"
|
||||||
|
ownership_calls = []
|
||||||
|
|
||||||
|
def fake_collect(**kwargs):
|
||||||
|
ownership_calls.append(kwargs)
|
||||||
|
return {"records": [], "inventory_error": False}
|
||||||
|
|
||||||
|
def fake_remove(project_root, branch, worktree_path=None):
|
||||||
|
return {
|
||||||
|
"success": False,
|
||||||
|
"performed": False,
|
||||||
|
"message": f"worktree not found: {worktree_path}",
|
||||||
|
}
|
||||||
|
|
||||||
|
def fake_probe(h, o, r, auth, br):
|
||||||
|
return guard.classify_branch_readback_http_status(
|
||||||
|
404, not_found_scope=guard.NOT_FOUND_SCOPE_BRANCH
|
||||||
|
)
|
||||||
|
|
||||||
|
report = {
|
||||||
|
"entries": [
|
||||||
|
{
|
||||||
|
"pr_number": 851,
|
||||||
|
"head_branch": branch,
|
||||||
|
"remote_branch": {"safe_to_delete_remote": True},
|
||||||
|
"local_worktree": {
|
||||||
|
"safe_to_remove_worktree": True,
|
||||||
|
"worktree_path": "/tmp/already-gone",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
],
|
||||||
|
"reviewer_scratch_entries": [],
|
||||||
|
}
|
||||||
|
patch(
|
||||||
|
"mcp_server.get_profile",
|
||||||
|
return_value={
|
||||||
|
"profile_name": "prgs-reconciler",
|
||||||
|
"role": "reconciler",
|
||||||
|
"allowed_operations": [
|
||||||
|
"gitea.read",
|
||||||
|
"gitea.branch.delete",
|
||||||
|
],
|
||||||
|
"forbidden_operations": [],
|
||||||
|
},
|
||||||
|
).start()
|
||||||
|
patch("mcp_server.api_get_all", return_value=[]).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.merged_cleanup_reconcile.build_reconciliation_report",
|
||||||
|
return_value=report,
|
||||||
|
).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.merged_cleanup_reconcile.discover_reviewer_scratch_worktrees",
|
||||||
|
return_value=[],
|
||||||
|
).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.audit_reconciliation_mode.check_cleanup_execution_allowed",
|
||||||
|
return_value=(True, []),
|
||||||
|
).start()
|
||||||
|
patch("mcp_server.verify_preflight_purity", return_value=None).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server._collect_branch_ownership_records",
|
||||||
|
side_effect=fake_collect,
|
||||||
|
).start()
|
||||||
|
patch("mcp_server._probe_remote_branch", side_effect=fake_probe).start()
|
||||||
|
patch(
|
||||||
|
"mcp_server.merged_cleanup_reconcile.remove_local_worktree",
|
||||||
|
side_effect=fake_remove,
|
||||||
|
).start()
|
||||||
|
self.mock_api.side_effect = lambda *a, **k: {}
|
||||||
|
|
||||||
|
res = gitea_reconcile_merged_cleanups(
|
||||||
|
dry_run=False,
|
||||||
|
execute_confirmed=True,
|
||||||
|
remote="prgs",
|
||||||
|
)
|
||||||
|
actions = res.get("actions") or []
|
||||||
|
removes = [a for a in actions if a.get("action") == "remove_local_worktree"]
|
||||||
|
deletes = [a for a in actions if a.get("action") == "delete_remote_branch"]
|
||||||
|
self.assertEqual(len(removes), 1)
|
||||||
|
self.assertFalse(removes[0].get("success"))
|
||||||
|
self.assertEqual(len(deletes), 1)
|
||||||
|
self.assertTrue(deletes[0].get("success"))
|
||||||
|
self.assertTrue(deletes[0].get("after_worktree_removal"))
|
||||||
|
self.assertTrue(ownership_calls)
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,551 @@
|
|||||||
|
"""Merged-PR awareness for the worktree cleanup audit (#858).
|
||||||
|
|
||||||
|
Before #858 an ``issue_work`` worktree could never leave ``active_issue_work``:
|
||||||
|
the audit had no PR linkage at all (``pr_number`` was structurally ``None``)
|
||||||
|
and its only route to ``clean_stale_removable`` was a TTL derived from a
|
||||||
|
``last_used_at`` that nothing ever populated. A merged, clean, unprotected
|
||||||
|
worktree was therefore reported as active work forever, disagreeing with the
|
||||||
|
PR-scoped reconciler.
|
||||||
|
|
||||||
|
These tests use fabricated temporary repositories and synthetic PR records
|
||||||
|
only. Nothing here removes a worktree or deletes a branch.
|
||||||
|
"""
|
||||||
|
|
||||||
|
import os
|
||||||
|
import subprocess
|
||||||
|
import sys
|
||||||
|
import tempfile
|
||||||
|
import unittest
|
||||||
|
from unittest.mock import patch
|
||||||
|
|
||||||
|
sys.path.insert(0, str(__import__("pathlib").Path(__file__).resolve().parent.parent))
|
||||||
|
|
||||||
|
import merged_cleanup_reconcile as mcr # noqa: E402
|
||||||
|
import worktree_cleanup_audit as wca # noqa: E402
|
||||||
|
|
||||||
|
|
||||||
|
MERGED_BRANCH = "feat/issue-777-timeline"
|
||||||
|
MERGED_PATH = "/repo/branches/issue-777-timeline"
|
||||||
|
HEAD_SHA = "a" * 40
|
||||||
|
|
||||||
|
|
||||||
|
def _pr(number, branch, *, merged=True, sha=HEAD_SHA, state=None):
|
||||||
|
"""Synthetic Gitea PR payload."""
|
||||||
|
return {
|
||||||
|
"number": number,
|
||||||
|
"head": {"ref": branch, "sha": sha},
|
||||||
|
"merged_at": "2026-07-24T01:00:00Z" if merged else None,
|
||||||
|
"state": state or ("closed" if merged else "open"),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _porcelain(*entries):
|
||||||
|
out = []
|
||||||
|
for path, branch, sha in entries:
|
||||||
|
out.append(f"worktree {path}")
|
||||||
|
out.append(f"HEAD {sha}")
|
||||||
|
if branch is None:
|
||||||
|
out.append("detached")
|
||||||
|
else:
|
||||||
|
out.append(f"branch refs/heads/{branch}")
|
||||||
|
out.append("")
|
||||||
|
return "\n".join(out)
|
||||||
|
|
||||||
|
|
||||||
|
class _AuditHarness(unittest.TestCase):
|
||||||
|
"""Runs audit_branches_directory over a fabricated worktree listing."""
|
||||||
|
|
||||||
|
PORCELAIN = _porcelain(
|
||||||
|
("/repo", "master", "f" * 40),
|
||||||
|
(MERGED_PATH, MERGED_BRANCH, HEAD_SHA),
|
||||||
|
)
|
||||||
|
|
||||||
|
def run_audit(self, *, dirty_paths=(), contained=True, **kwargs):
|
||||||
|
def fake_dirty(path):
|
||||||
|
if path in dirty_paths:
|
||||||
|
return {"exists": True, "dirty": True, "dirty_files": [" M x.py"]}
|
||||||
|
return {"exists": True, "dirty": False, "dirty_files": []}
|
||||||
|
|
||||||
|
with patch.object(
|
||||||
|
wca, "list_worktrees",
|
||||||
|
return_value=wca.parse_worktree_porcelain(self.PORCELAIN),
|
||||||
|
), patch.object(
|
||||||
|
wca, "read_worktree_dirty", side_effect=fake_dirty
|
||||||
|
), patch.object(
|
||||||
|
wca, "git_worktree_list", return_value="(mocked)"
|
||||||
|
), patch.object(
|
||||||
|
wca, "is_head_ancestor_of_ref", return_value=contained
|
||||||
|
):
|
||||||
|
report = wca.audit_branches_directory("/repo", **kwargs)
|
||||||
|
return {wt["path"]: wt for wt in report["worktrees"]}, report
|
||||||
|
|
||||||
|
def merged_audit(self, **kwargs):
|
||||||
|
kwargs.setdefault("pr_index", wca.build_pr_index([_pr(849, MERGED_BRANCH)]))
|
||||||
|
kwargs.setdefault("master_ref", "prgs/master")
|
||||||
|
return self.run_audit(**kwargs)
|
||||||
|
|
||||||
|
|
||||||
|
class TestMergedWorktreeBecomesRemovable(_AuditHarness):
|
||||||
|
def test_clean_merged_issue_worktree_is_linked_and_removable(self):
|
||||||
|
by_path, report = self.merged_audit()
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
|
||||||
|
self.assertEqual(entry["classification"], wca.CLASS_CLEAN_STALE_REMOVABLE)
|
||||||
|
self.assertTrue(entry["removable"])
|
||||||
|
self.assertEqual(entry["merged_pr_linkage"]["status"], wca.LINKAGE_MERGED)
|
||||||
|
self.assertEqual(entry["merged_pr_cleanup"]["block_reasons"], [])
|
||||||
|
self.assertIn(MERGED_PATH, [c["path"] for c in report["removable_candidates"]])
|
||||||
|
|
||||||
|
def test_pr_number_populated_from_authoritative_linkage(self):
|
||||||
|
by_path, _ = self.merged_audit()
|
||||||
|
self.assertEqual(by_path[MERGED_PATH]["pr_number"], 849)
|
||||||
|
|
||||||
|
def test_regression_without_pr_evidence_stays_active_issue_work(self):
|
||||||
|
"""The pre-#858 behaviour, still correct when no PR state is supplied."""
|
||||||
|
by_path, _ = self.run_audit()
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertEqual(entry["classification"], wca.CLASS_ACTIVE_ISSUE_WORK)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
self.assertIsNone(entry["pr_number"])
|
||||||
|
|
||||||
|
|
||||||
|
class TestProtectiveSignalsSurvive(_AuditHarness):
|
||||||
|
def test_open_pr_worktree_is_not_removable(self):
|
||||||
|
index = wca.build_pr_index([_pr(900, MERGED_BRANCH, merged=False)])
|
||||||
|
by_path, _ = self.run_audit(
|
||||||
|
pr_index=index,
|
||||||
|
master_ref="prgs/master",
|
||||||
|
open_pr_branches={MERGED_BRANCH},
|
||||||
|
)
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertEqual(entry["classification"], wca.CLASS_ACTIVE_OPEN_PR)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
# linkage still reports the owning PR, it just is not merge proof
|
||||||
|
self.assertEqual(entry["merged_pr_linkage"]["status"], wca.LINKAGE_OPEN)
|
||||||
|
self.assertEqual(entry["pr_number"], 900)
|
||||||
|
|
||||||
|
def test_dirty_tracked_worktree_is_not_removable(self):
|
||||||
|
by_path, _ = self.merged_audit(dirty_paths=(MERGED_PATH,))
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertEqual(entry["classification"], wca.CLASS_DIRTY_LOCAL)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
self.assertIn(
|
||||||
|
"worktree has uncommitted changes",
|
||||||
|
entry["merged_pr_cleanup"]["block_reasons"],
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_untracked_only_worktree_is_not_removable(self):
|
||||||
|
"""``git status --porcelain`` reports untracked files as dirty too."""
|
||||||
|
def untracked(path):
|
||||||
|
if path == MERGED_PATH:
|
||||||
|
return {"exists": True, "dirty": True, "dirty_files": ["?? scratch.txt"]}
|
||||||
|
return {"exists": True, "dirty": False, "dirty_files": []}
|
||||||
|
|
||||||
|
with patch.object(
|
||||||
|
wca, "list_worktrees",
|
||||||
|
return_value=wca.parse_worktree_porcelain(self.PORCELAIN),
|
||||||
|
), patch.object(
|
||||||
|
wca, "read_worktree_dirty", side_effect=untracked
|
||||||
|
), patch.object(
|
||||||
|
wca, "git_worktree_list", return_value="(mocked)"
|
||||||
|
), patch.object(
|
||||||
|
wca, "is_head_ancestor_of_ref", return_value=True
|
||||||
|
):
|
||||||
|
report = wca.audit_branches_directory(
|
||||||
|
"/repo",
|
||||||
|
pr_index=wca.build_pr_index([_pr(849, MERGED_BRANCH)]),
|
||||||
|
master_ref="prgs/master",
|
||||||
|
)
|
||||||
|
entry = {wt["path"]: wt for wt in report["worktrees"]}[MERGED_PATH]
|
||||||
|
self.assertEqual(entry["classification"], wca.CLASS_DIRTY_LOCAL)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
|
||||||
|
def test_active_lease_by_issue_number_is_protective(self):
|
||||||
|
by_path, _ = self.merged_audit(leased_issue_numbers={777})
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertTrue(entry["has_active_lease"])
|
||||||
|
self.assertEqual(entry["classification"], wca.CLASS_ACTIVE_ISSUE_WORK)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
|
||||||
|
def test_active_lease_by_branch_is_protective(self):
|
||||||
|
by_path, _ = self.merged_audit(leased_branches={MERGED_BRANCH})
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertTrue(entry["has_active_lease"])
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
|
||||||
|
def test_active_issue_lock_is_protective(self):
|
||||||
|
by_path, _ = self.merged_audit(active_issue_branches={MERGED_BRANCH})
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertTrue(entry["has_active_issue_lock"])
|
||||||
|
self.assertEqual(entry["classification"], wca.CLASS_ACTIVE_ISSUE_WORK)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
|
||||||
|
def test_live_session_worktree_is_protective(self):
|
||||||
|
by_path, _ = self.merged_audit(live_session_paths={MERGED_PATH})
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertTrue(entry["has_live_session"])
|
||||||
|
self.assertEqual(entry["classification"], wca.CLASS_ACTIVE_ISSUE_WORK)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
|
||||||
|
def test_head_not_contained_in_master_is_not_removable(self):
|
||||||
|
by_path, _ = self.merged_audit(contained=False)
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertEqual(entry["classification"], wca.CLASS_ACTIVE_ISSUE_WORK)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
self.assertIn(
|
||||||
|
"worktree head is not contained in authoritative master "
|
||||||
|
"(unmerged commits remain)",
|
||||||
|
entry["merged_pr_cleanup"]["block_reasons"],
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_unknown_containment_fails_closed(self):
|
||||||
|
by_path, _ = self.merged_audit(contained=None)
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
self.assertIn(
|
||||||
|
"containment of the worktree head in master is unknown",
|
||||||
|
entry["merged_pr_cleanup"]["block_reasons"],
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_missing_master_ref_fails_closed(self):
|
||||||
|
by_path, _ = self.run_audit(
|
||||||
|
pr_index=wca.build_pr_index([_pr(849, MERGED_BRANCH)])
|
||||||
|
)
|
||||||
|
self.assertFalse(by_path[MERGED_PATH]["removable"])
|
||||||
|
|
||||||
|
def test_unmerged_owning_pr_is_not_removable(self):
|
||||||
|
index = wca.build_pr_index([_pr(901, MERGED_BRANCH, merged=False)])
|
||||||
|
by_path, _ = self.run_audit(pr_index=index, master_ref="prgs/master")
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
self.assertIn(
|
||||||
|
"owning PR #901 is not merged",
|
||||||
|
entry["merged_pr_cleanup"]["block_reasons"],
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_control_checkout_is_never_removable(self):
|
||||||
|
by_path, _ = self.merged_audit()
|
||||||
|
control = by_path["/repo"]
|
||||||
|
self.assertTrue(control["is_protected"])
|
||||||
|
self.assertEqual(control["classification"], wca.CLASS_UNSAFE_UNKNOWN)
|
||||||
|
self.assertFalse(control["removable"])
|
||||||
|
|
||||||
|
def test_control_checkout_not_removable_even_if_linked_and_merged(self):
|
||||||
|
"""A merged PR on the control checkout must not unlock removal."""
|
||||||
|
porcelain = _porcelain(("/repo", MERGED_BRANCH, HEAD_SHA))
|
||||||
|
with patch.object(
|
||||||
|
wca, "list_worktrees", return_value=wca.parse_worktree_porcelain(porcelain)
|
||||||
|
), patch.object(
|
||||||
|
wca, "read_worktree_dirty",
|
||||||
|
return_value={"exists": True, "dirty": False, "dirty_files": []},
|
||||||
|
), patch.object(
|
||||||
|
wca, "git_worktree_list", return_value="(mocked)"
|
||||||
|
), patch.object(
|
||||||
|
wca, "is_head_ancestor_of_ref", return_value=True
|
||||||
|
):
|
||||||
|
report = wca.audit_branches_directory(
|
||||||
|
"/repo",
|
||||||
|
pr_index=wca.build_pr_index([_pr(849, MERGED_BRANCH)]),
|
||||||
|
master_ref="prgs/master",
|
||||||
|
)
|
||||||
|
entry = report["worktrees"][0]
|
||||||
|
self.assertEqual(entry["classification"], wca.CLASS_UNSAFE_UNKNOWN)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
|
||||||
|
|
||||||
|
class TestAmbiguousLinkageFailsClosed(_AuditHarness):
|
||||||
|
def test_competing_prs_on_one_branch_fail_closed(self):
|
||||||
|
index = wca.build_pr_index(
|
||||||
|
[_pr(849, MERGED_BRANCH), _pr(860, MERGED_BRANCH)]
|
||||||
|
)
|
||||||
|
by_path, _ = self.run_audit(pr_index=index, master_ref="prgs/master")
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertEqual(entry["merged_pr_linkage"]["status"], wca.LINKAGE_AMBIGUOUS)
|
||||||
|
self.assertIsNone(entry["pr_number"])
|
||||||
|
self.assertEqual(entry["classification"], wca.CLASS_ACTIVE_ISSUE_WORK)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
|
||||||
|
def test_merged_plus_open_pr_on_one_branch_fails_closed(self):
|
||||||
|
index = wca.build_pr_index(
|
||||||
|
[_pr(849, MERGED_BRANCH), _pr(861, MERGED_BRANCH, merged=False)]
|
||||||
|
)
|
||||||
|
by_path, _ = self.run_audit(pr_index=index, master_ref="prgs/master")
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertEqual(entry["merged_pr_linkage"]["status"], wca.LINKAGE_AMBIGUOUS)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
|
||||||
|
def test_no_owning_pr_fails_closed(self):
|
||||||
|
by_path, _ = self.run_audit(
|
||||||
|
pr_index=wca.build_pr_index([_pr(849, "feat/other-branch")]),
|
||||||
|
master_ref="prgs/master",
|
||||||
|
)
|
||||||
|
entry = by_path[MERGED_PATH]
|
||||||
|
self.assertEqual(entry["merged_pr_linkage"]["status"], wca.LINKAGE_NONE)
|
||||||
|
self.assertFalse(entry["removable"])
|
||||||
|
|
||||||
|
def test_malformed_pr_records_are_dropped_not_guessed(self):
|
||||||
|
index = wca.build_pr_index(
|
||||||
|
[
|
||||||
|
{"number": None, "head": {"ref": MERGED_BRANCH}},
|
||||||
|
{"number": 5, "head": {}},
|
||||||
|
{"number": "not-an-int", "head": {"ref": MERGED_BRANCH}},
|
||||||
|
]
|
||||||
|
)
|
||||||
|
self.assertEqual(index, {})
|
||||||
|
self.assertEqual(
|
||||||
|
wca.resolve_owning_pr(branch=MERGED_BRANCH, pr_index=index)["status"],
|
||||||
|
wca.LINKAGE_NONE,
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_detached_worktree_has_no_branch_linkage(self):
|
||||||
|
self.assertEqual(
|
||||||
|
wca.resolve_owning_pr(branch=None, pr_index={})["status"],
|
||||||
|
wca.LINKAGE_UNKNOWN,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class TestUnrelatedClassificationsUnchanged(unittest.TestCase):
|
||||||
|
"""Non-issue_work worktrees keep their pre-#858 classifications."""
|
||||||
|
|
||||||
|
PORCELAIN = _porcelain(
|
||||||
|
("/repo", "master", "f" * 40),
|
||||||
|
("/repo/branches/review-pr42", "review-pr42", "2" * 40),
|
||||||
|
("/repo/branches/baseline-master-x", "baseline-master-x", "3" * 40),
|
||||||
|
("/repo/branches/conflict-fix-pr50", "conflict-fix-pr50", "4" * 40),
|
||||||
|
("/repo/branches/review-pr99", None, "5" * 40),
|
||||||
|
)
|
||||||
|
|
||||||
|
def _audit(self, **kwargs):
|
||||||
|
with patch.object(
|
||||||
|
wca, "list_worktrees",
|
||||||
|
return_value=wca.parse_worktree_porcelain(self.PORCELAIN),
|
||||||
|
), patch.object(
|
||||||
|
wca, "read_worktree_dirty",
|
||||||
|
return_value={"exists": True, "dirty": False, "dirty_files": []},
|
||||||
|
), patch.object(
|
||||||
|
wca, "git_worktree_list", return_value="(mocked)"
|
||||||
|
), patch.object(
|
||||||
|
wca, "is_head_ancestor_of_ref", return_value=True
|
||||||
|
):
|
||||||
|
report = wca.audit_branches_directory("/repo", **kwargs)
|
||||||
|
return {wt["path"]: wt for wt in report["worktrees"]}
|
||||||
|
|
||||||
|
def test_classifications_identical_with_and_without_pr_evidence(self):
|
||||||
|
without = self._audit()
|
||||||
|
with_evidence = self._audit(
|
||||||
|
pr_index=wca.build_pr_index([_pr(849, MERGED_BRANCH)]),
|
||||||
|
master_ref="prgs/master",
|
||||||
|
)
|
||||||
|
self.assertEqual(
|
||||||
|
{p: e["classification"] for p, e in without.items()},
|
||||||
|
{p: e["classification"] for p, e in with_evidence.items()},
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_lease_on_issue_does_not_capture_similarly_named_scratch_trees(self):
|
||||||
|
"""A lease on issue 777 protects issue work, not baseline/review trees."""
|
||||||
|
porcelain = _porcelain(
|
||||||
|
("/repo/branches/baseline-master-issue-777", "baseline-issue-777", "7" * 40),
|
||||||
|
("/repo/branches/issue-777-timeline", MERGED_BRANCH, HEAD_SHA),
|
||||||
|
)
|
||||||
|
with patch.object(
|
||||||
|
wca, "list_worktrees", return_value=wca.parse_worktree_porcelain(porcelain)
|
||||||
|
), patch.object(
|
||||||
|
wca, "read_worktree_dirty",
|
||||||
|
return_value={"exists": True, "dirty": False, "dirty_files": []},
|
||||||
|
), patch.object(
|
||||||
|
wca, "git_worktree_list", return_value="(mocked)"
|
||||||
|
), patch.object(
|
||||||
|
wca, "is_head_ancestor_of_ref", return_value=True
|
||||||
|
):
|
||||||
|
report = wca.audit_branches_directory(
|
||||||
|
"/repo",
|
||||||
|
pr_index=wca.build_pr_index([_pr(849, MERGED_BRANCH)]),
|
||||||
|
master_ref="prgs/master",
|
||||||
|
leased_issue_numbers={777},
|
||||||
|
)
|
||||||
|
by_path = {wt["path"]: wt for wt in report["worktrees"]}
|
||||||
|
|
||||||
|
baseline = by_path["/repo/branches/baseline-master-issue-777"]
|
||||||
|
self.assertFalse(baseline["has_active_lease"])
|
||||||
|
self.assertEqual(baseline["classification"], wca.CLASS_CLEAN_STALE_REMOVABLE)
|
||||||
|
|
||||||
|
issue_work = by_path["/repo/branches/issue-777-timeline"]
|
||||||
|
self.assertTrue(issue_work["has_active_lease"])
|
||||||
|
self.assertFalse(issue_work["removable"])
|
||||||
|
|
||||||
|
def test_review_and_baseline_still_removable(self):
|
||||||
|
by_path = self._audit(
|
||||||
|
pr_index=wca.build_pr_index([]), master_ref="prgs/master"
|
||||||
|
)
|
||||||
|
self.assertEqual(
|
||||||
|
by_path["/repo/branches/review-pr42"]["classification"],
|
||||||
|
wca.CLASS_CLEAN_STALE_REMOVABLE,
|
||||||
|
)
|
||||||
|
self.assertEqual(
|
||||||
|
by_path["/repo/branches/baseline-master-x"]["classification"],
|
||||||
|
wca.CLASS_CLEAN_STALE_REMOVABLE,
|
||||||
|
)
|
||||||
|
self.assertEqual(
|
||||||
|
by_path["/repo/branches/review-pr99"]["classification"],
|
||||||
|
wca.CLASS_DETACHED_REVIEW_LEFTOVER,
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_conflict_fix_ttl_behaviour_unchanged(self):
|
||||||
|
"""conflict_fix still needs only TTL expiry; #858 did not touch it."""
|
||||||
|
self.assertEqual(
|
||||||
|
wca.classify_worktree(
|
||||||
|
workflow_type=wca.WORKFLOW_CONFLICT_FIX,
|
||||||
|
is_dirty=False,
|
||||||
|
ttl_expired=True,
|
||||||
|
),
|
||||||
|
wca.CLASS_CLEAN_STALE_REMOVABLE,
|
||||||
|
)
|
||||||
|
self.assertEqual(
|
||||||
|
wca.classify_worktree(
|
||||||
|
workflow_type=wca.WORKFLOW_CONFLICT_FIX,
|
||||||
|
is_dirty=False,
|
||||||
|
ttl_expired=False,
|
||||||
|
),
|
||||||
|
wca.CLASS_ACTIVE_ISSUE_WORK,
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_issue_work_ttl_alone_no_longer_grants_removal(self):
|
||||||
|
"""Age is not landing proof: TTL alone must not reclaim issue work."""
|
||||||
|
self.assertEqual(
|
||||||
|
wca.classify_worktree(
|
||||||
|
workflow_type=wca.WORKFLOW_ISSUE_WORK,
|
||||||
|
is_dirty=False,
|
||||||
|
ttl_expired=True,
|
||||||
|
),
|
||||||
|
wca.CLASS_ACTIVE_ISSUE_WORK,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class TestAssessorPerformsNoDeletion(_AuditHarness):
|
||||||
|
def test_audit_never_removes_a_worktree(self):
|
||||||
|
with patch.object(wca, "remove_worktree") as removal:
|
||||||
|
self.merged_audit()
|
||||||
|
removal.assert_not_called()
|
||||||
|
|
||||||
|
def test_audit_shells_out_to_no_destructive_git_command(self):
|
||||||
|
seen = []
|
||||||
|
real_run = subprocess.run
|
||||||
|
|
||||||
|
def recording_run(cmd, *args, **kwargs):
|
||||||
|
seen.append(cmd)
|
||||||
|
return real_run(["true"], *args, **kwargs)
|
||||||
|
|
||||||
|
with patch.object(subprocess, "run", side_effect=recording_run):
|
||||||
|
wca.audit_branches_directory("/nonexistent-repo-for-audit")
|
||||||
|
|
||||||
|
joined = [" ".join(c) if isinstance(c, list) else str(c) for c in seen]
|
||||||
|
for cmd in joined:
|
||||||
|
self.assertNotIn("worktree remove", cmd)
|
||||||
|
self.assertNotIn("branch -D", cmd)
|
||||||
|
self.assertNotIn("push", cmd)
|
||||||
|
|
||||||
|
|
||||||
|
class TestAgreementWithPrScopedReconciler(unittest.TestCase):
|
||||||
|
"""The audit and merged_cleanup_reconcile must agree on identical input.
|
||||||
|
|
||||||
|
Uses a real throwaway git repository so containment is computed by git
|
||||||
|
rather than asserted. Nothing outside the temporary directory is touched.
|
||||||
|
"""
|
||||||
|
|
||||||
|
def _git(self, *args):
|
||||||
|
subprocess.run(
|
||||||
|
["git", "-C", self.root, *args],
|
||||||
|
check=True,
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
)
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
|
self._tmp = tempfile.TemporaryDirectory()
|
||||||
|
self.root = os.path.realpath(self._tmp.name)
|
||||||
|
self._git("init", "-b", "master", ".")
|
||||||
|
self._git("config", "user.email", "[email protected]")
|
||||||
|
self._git("config", "user.name", "Test")
|
||||||
|
with open(os.path.join(self.root, "seed.txt"), "w") as fh:
|
||||||
|
fh.write("seed\n")
|
||||||
|
self._git("add", "seed.txt")
|
||||||
|
self._git("commit", "-m", "seed")
|
||||||
|
|
||||||
|
self.branch = "feat/issue-777-timeline"
|
||||||
|
self._git("checkout", "-b", self.branch)
|
||||||
|
with open(os.path.join(self.root, "feature.txt"), "w") as fh:
|
||||||
|
fh.write("feature\n")
|
||||||
|
self._git("add", "feature.txt")
|
||||||
|
self._git("commit", "-m", "feature")
|
||||||
|
self.head_sha = subprocess.run(
|
||||||
|
["git", "-C", self.root, "rev-parse", "HEAD"],
|
||||||
|
capture_output=True, text=True, check=True,
|
||||||
|
).stdout.strip()
|
||||||
|
self._git("checkout", "master")
|
||||||
|
self._git("merge", "--no-ff", "-m", "merge feature", self.branch)
|
||||||
|
|
||||||
|
self.worktree = os.path.join(self.root, "branches", "issue-777-timeline")
|
||||||
|
self._git("worktree", "add", self.worktree, self.branch)
|
||||||
|
|
||||||
|
def tearDown(self):
|
||||||
|
self._tmp.cleanup()
|
||||||
|
|
||||||
|
def _pr_index(self):
|
||||||
|
return wca.build_pr_index(
|
||||||
|
[
|
||||||
|
{
|
||||||
|
"number": 849,
|
||||||
|
"head": {"ref": self.branch, "sha": self.head_sha},
|
||||||
|
"merged_at": "2026-07-24T01:00:00Z",
|
||||||
|
}
|
||||||
|
]
|
||||||
|
)
|
||||||
|
|
||||||
|
def _audit_entry(self):
|
||||||
|
report = wca.audit_branches_directory(
|
||||||
|
self.root, pr_index=self._pr_index(), master_ref="master"
|
||||||
|
)
|
||||||
|
return next(wt for wt in report["worktrees"] if wt["path"] == self.worktree)
|
||||||
|
|
||||||
|
def _reconciler_entry(self):
|
||||||
|
return mcr.assess_local_worktree_cleanup(
|
||||||
|
pr_number=849,
|
||||||
|
head_branch=self.branch,
|
||||||
|
merged=True,
|
||||||
|
worktree_state=mcr.resolve_cleanup_worktree_state(
|
||||||
|
project_root=self.root,
|
||||||
|
head_branch=self.branch,
|
||||||
|
issue_number=777,
|
||||||
|
pr_head_sha=self.head_sha,
|
||||||
|
target_ref="master",
|
||||||
|
),
|
||||||
|
active_lock=False,
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_both_assessors_agree_the_worktree_is_safe(self):
|
||||||
|
audit_entry = self._audit_entry()
|
||||||
|
reconciler = self._reconciler_entry()
|
||||||
|
|
||||||
|
self.assertTrue(reconciler["safe_to_remove_worktree"], reconciler)
|
||||||
|
self.assertTrue(audit_entry["removable"], audit_entry)
|
||||||
|
self.assertEqual(audit_entry["pr_number"], reconciler["pr_number"])
|
||||||
|
self.assertEqual(audit_entry["merged_pr_cleanup"]["block_reasons"], [])
|
||||||
|
self.assertEqual(reconciler["block_reasons"], [])
|
||||||
|
|
||||||
|
def test_both_assessors_agree_a_dirty_worktree_is_unsafe(self):
|
||||||
|
with open(os.path.join(self.worktree, "feature.txt"), "a") as fh:
|
||||||
|
fh.write("local edit\n")
|
||||||
|
|
||||||
|
audit_entry = self._audit_entry()
|
||||||
|
reconciler = self._reconciler_entry()
|
||||||
|
|
||||||
|
self.assertFalse(audit_entry["removable"])
|
||||||
|
self.assertFalse(reconciler["safe_to_remove_worktree"])
|
||||||
|
|
||||||
|
def test_worktree_still_present_after_audit(self):
|
||||||
|
self._audit_entry()
|
||||||
|
self.assertTrue(os.path.isdir(self.worktree))
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
unittest.main()
|
||||||
@@ -12,6 +12,59 @@ import merged_cleanup_reconcile as mcr # noqa: E402
|
|||||||
|
|
||||||
|
|
||||||
class TestMergedCleanupAssessment(unittest.TestCase):
|
class TestMergedCleanupAssessment(unittest.TestCase):
|
||||||
|
def test_issue_851_plan_order_worktree_then_reassess_then_remote(self):
|
||||||
|
"""#851 dry-run plan: remove worktree, reassess ownership, then remote."""
|
||||||
|
plan = mcr.plan_cleanup_execution_order(
|
||||||
|
remote_assessment={"safe_to_delete_remote": True},
|
||||||
|
local_assessment={"safe_to_remove_worktree": True},
|
||||||
|
)
|
||||||
|
actions = [s["action"] for s in plan]
|
||||||
|
self.assertEqual(
|
||||||
|
actions,
|
||||||
|
[
|
||||||
|
"remove_local_worktree",
|
||||||
|
"reassess_branch_ownership",
|
||||||
|
"delete_remote_branch",
|
||||||
|
],
|
||||||
|
)
|
||||||
|
self.assertEqual(plan[0]["phase"], 1)
|
||||||
|
self.assertEqual(plan[-1]["phase"], 3)
|
||||||
|
self.assertIn("independently_safe", plan[0]["reason"])
|
||||||
|
self.assertIn("reassessment", plan[-1]["reason"])
|
||||||
|
|
||||||
|
def test_issue_851_plan_remote_only_when_worktree_not_safe(self):
|
||||||
|
plan = mcr.plan_cleanup_execution_order(
|
||||||
|
remote_assessment={"safe_to_delete_remote": True},
|
||||||
|
local_assessment={"safe_to_remove_worktree": False},
|
||||||
|
)
|
||||||
|
self.assertEqual([s["action"] for s in plan], ["delete_remote_branch"])
|
||||||
|
self.assertNotIn("reassess_branch_ownership", [s["action"] for s in plan])
|
||||||
|
|
||||||
|
def test_issue_851_plan_worktree_only_when_remote_not_safe(self):
|
||||||
|
plan = mcr.plan_cleanup_execution_order(
|
||||||
|
remote_assessment={"safe_to_delete_remote": False},
|
||||||
|
local_assessment={"safe_to_remove_worktree": True},
|
||||||
|
)
|
||||||
|
self.assertEqual([s["action"] for s in plan], ["remove_local_worktree"])
|
||||||
|
|
||||||
|
def test_issue_851_entry_includes_planned_execution_order(self):
|
||||||
|
entry = mcr.build_pr_cleanup_entry(
|
||||||
|
pr={
|
||||||
|
"number": 848,
|
||||||
|
"title": "Closes #844",
|
||||||
|
"body": "",
|
||||||
|
"merged_at": "2026-07-23T00:00:00Z",
|
||||||
|
"head": {"ref": "fix/issue-844-x", "sha": "a" * 40},
|
||||||
|
},
|
||||||
|
project_root="/tmp/not-a-real-root",
|
||||||
|
open_pr_heads=set(),
|
||||||
|
remote_branch_exists=True,
|
||||||
|
head_on_master=True,
|
||||||
|
delete_capability_allowed=True,
|
||||||
|
)
|
||||||
|
self.assertIn("planned_execution_order", entry)
|
||||||
|
self.assertIsInstance(entry["planned_execution_order"], list)
|
||||||
|
|
||||||
def test_extract_linked_issue_from_closes(self):
|
def test_extract_linked_issue_from_closes(self):
|
||||||
issue = mcr.extract_linked_issue(
|
issue = mcr.extract_linked_issue(
|
||||||
"feat: cleanup (Closes #269)",
|
"feat: cleanup (Closes #269)",
|
||||||
|
|||||||
@@ -139,6 +139,8 @@ EXPECTED_ROLE_EXCLUSIVE_TASKS = frozenset(
|
|||||||
"gitea_release_merger_pr_lease",
|
"gitea_release_merger_pr_lease",
|
||||||
"create_branch",
|
"create_branch",
|
||||||
"push_branch",
|
"push_branch",
|
||||||
|
"bootstrap_author_issue_worktree",
|
||||||
|
"gitea_bootstrap_author_issue_worktree",
|
||||||
# #812 AC20: publishing an unpublished local head is author-only for the
|
# #812 AC20: publishing an unpublished local head is author-only for the
|
||||||
# same reason every other push is — it writes a branch to the remote.
|
# same reason every other push is — it writes a branch to the remote.
|
||||||
"publish_unpublished_branch",
|
"publish_unpublished_branch",
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -134,13 +134,35 @@ class TestClassification(unittest.TestCase):
|
|||||||
self.assertEqual(cls, wca.CLASS_ACTIVE_OPEN_PR)
|
self.assertEqual(cls, wca.CLASS_ACTIVE_OPEN_PR)
|
||||||
self.assertFalse(wca.is_removable(cls))
|
self.assertFalse(wca.is_removable(cls))
|
||||||
|
|
||||||
def test_stale_clean_issue_worktree_removable(self):
|
def test_stale_clean_issue_worktree_needs_merged_pr_proof(self):
|
||||||
# Scenario 5: clean issue worktree, TTL expired, no lock -> removable.
|
# Scenario 5 (#858): age is not proof that the branch landed, so a
|
||||||
|
# TTL-expired issue worktree stays active work. Only authoritative
|
||||||
|
# merged-PR evidence makes it removable, which is what keeps a
|
||||||
|
# worktree holding unmerged commits from being reclaimed by age.
|
||||||
cls = wca.classify_worktree(
|
cls = wca.classify_worktree(
|
||||||
workflow_type=wca.WORKFLOW_ISSUE_WORK,
|
workflow_type=wca.WORKFLOW_ISSUE_WORK,
|
||||||
is_dirty=False,
|
is_dirty=False,
|
||||||
ttl_expired=True,
|
ttl_expired=True,
|
||||||
)
|
)
|
||||||
|
self.assertEqual(cls, wca.CLASS_ACTIVE_ISSUE_WORK)
|
||||||
|
self.assertFalse(wca.is_removable(cls))
|
||||||
|
|
||||||
|
cls = wca.classify_worktree(
|
||||||
|
workflow_type=wca.WORKFLOW_ISSUE_WORK,
|
||||||
|
is_dirty=False,
|
||||||
|
ttl_expired=True,
|
||||||
|
merged_pr_cleanup={"proven": True},
|
||||||
|
)
|
||||||
|
self.assertEqual(cls, wca.CLASS_CLEAN_STALE_REMOVABLE)
|
||||||
|
self.assertTrue(wca.is_removable(cls))
|
||||||
|
|
||||||
|
def test_stale_clean_conflict_fix_worktree_removable(self):
|
||||||
|
# conflict_fix keeps the original TTL rule; #858 changed issue work only.
|
||||||
|
cls = wca.classify_worktree(
|
||||||
|
workflow_type=wca.WORKFLOW_CONFLICT_FIX,
|
||||||
|
is_dirty=False,
|
||||||
|
ttl_expired=True,
|
||||||
|
)
|
||||||
self.assertEqual(cls, wca.CLASS_CLEAN_STALE_REMOVABLE)
|
self.assertEqual(cls, wca.CLASS_CLEAN_STALE_REMOVABLE)
|
||||||
self.assertTrue(wca.is_removable(cls))
|
self.assertTrue(wca.is_removable(cls))
|
||||||
|
|
||||||
|
|||||||
+100
@@ -46,6 +46,7 @@ from webui.worktree_scanner import load_hygiene_snapshot, snapshot_to_dict as wo
|
|||||||
from webui.worktree_views import render_worktrees_page
|
from webui.worktree_views import render_worktrees_page
|
||||||
from webui.runtime_health import load_runtime_snapshot, snapshot_to_dict as runtime_snapshot_to_dict
|
from webui.runtime_health import load_runtime_snapshot, snapshot_to_dict as runtime_snapshot_to_dict
|
||||||
from webui.runtime_views import render_runtime_page
|
from webui.runtime_views import render_runtime_page
|
||||||
|
from webui.timeline import load_timeline, snapshot_to_dict as timeline_snapshot_to_dict
|
||||||
from webui.system_health import (
|
from webui.system_health import (
|
||||||
API_PATH as SYSTEM_HEALTH_API_PATH,
|
API_PATH as SYSTEM_HEALTH_API_PATH,
|
||||||
load_system_health,
|
load_system_health,
|
||||||
@@ -449,6 +450,104 @@ async def api_console_security_model(_request: Request) -> JSONResponse:
|
|||||||
})
|
})
|
||||||
|
|
||||||
|
|
||||||
|
def _query_int(request: Request, key: str) -> int | None:
|
||||||
|
"""Parse an optional integer query parameter; None when absent/invalid."""
|
||||||
|
raw = request.query_params.get(key)
|
||||||
|
if raw is None or not str(raw).strip():
|
||||||
|
return None
|
||||||
|
try:
|
||||||
|
return int(str(raw).strip())
|
||||||
|
except (TypeError, ValueError):
|
||||||
|
return None
|
||||||
|
|
||||||
|
|
||||||
|
def _derive_remote(host: str) -> str:
|
||||||
|
"""Map a Gitea host to its known short remote name (control-plane scope key)."""
|
||||||
|
text = (host or "").lower()
|
||||||
|
if "prgs" in text:
|
||||||
|
return "prgs"
|
||||||
|
if "dadeschools" in text:
|
||||||
|
return "dadeschools"
|
||||||
|
return text.split(".")[0] if text else ""
|
||||||
|
|
||||||
|
|
||||||
|
def _timeline_comment_source(host: str, org: str, repo: str):
|
||||||
|
"""Build a fail-soft CTH-comment fetcher for one repo, or None when offline.
|
||||||
|
|
||||||
|
Returns a callable ``(kind, number) -> list[comment]``. Credentials or
|
||||||
|
network failures raise inside the callable so ``load_timeline`` degrades the
|
||||||
|
handoff source rather than the whole timeline. Offline test mode yields no
|
||||||
|
live source so the handoff section reports ``not run``.
|
||||||
|
"""
|
||||||
|
import os
|
||||||
|
|
||||||
|
from gitea_auth import api_fetch_page, get_auth_header, repo_api_url
|
||||||
|
|
||||||
|
offline = (os.environ.get("WEBUI_TEST_OFFLINE") or "").strip().lower() in {"1", "true", "yes"}
|
||||||
|
if offline:
|
||||||
|
return None
|
||||||
|
auth = get_auth_header(host)
|
||||||
|
if not auth:
|
||||||
|
return None
|
||||||
|
|
||||||
|
def _fetch(kind: str, number: int) -> list:
|
||||||
|
segment = "pulls" if kind == "pr" else "issues"
|
||||||
|
url = f"{repo_api_url(host, org, repo)}/{segment}/{int(number)}/comments"
|
||||||
|
comments: list = []
|
||||||
|
page = 1
|
||||||
|
while page <= 20:
|
||||||
|
raw, meta = api_fetch_page(url, auth, page=page, limit=50)
|
||||||
|
comments.extend(raw)
|
||||||
|
if bool(meta["is_final_page"]):
|
||||||
|
break
|
||||||
|
page += 1
|
||||||
|
return comments
|
||||||
|
|
||||||
|
return _fetch
|
||||||
|
|
||||||
|
|
||||||
|
async def api_v1_timeline(request: Request) -> JSONResponse:
|
||||||
|
"""Read-only workflow-event timeline (#637). Filter by issue/PR/session."""
|
||||||
|
from webui.queue_loader import _host_from_url # host normalisation helper
|
||||||
|
|
||||||
|
registry, error = _load_project_registry()
|
||||||
|
if error is not None:
|
||||||
|
return JSONResponse(error.to_dict(), status_code=500)
|
||||||
|
project = registry.projects[0] if registry.projects else None
|
||||||
|
|
||||||
|
org = request.query_params.get("org") or (project.gitea_owner if project else "")
|
||||||
|
repo = request.query_params.get("repo") or (project.repo_name if project else "")
|
||||||
|
host = _host_from_url(project.remote_host) if project else ""
|
||||||
|
remote = request.query_params.get("remote") or _derive_remote(host)
|
||||||
|
|
||||||
|
if not (remote and org and repo):
|
||||||
|
return JSONResponse(
|
||||||
|
{
|
||||||
|
"error": "timeline_scope_unresolved",
|
||||||
|
"detail": "no project in registry and no remote/org/repo query params provided",
|
||||||
|
},
|
||||||
|
status_code=400,
|
||||||
|
)
|
||||||
|
|
||||||
|
comment_source = _timeline_comment_source(host, org, repo) if (host and org and repo) else None
|
||||||
|
|
||||||
|
snapshot = load_timeline(
|
||||||
|
remote=remote,
|
||||||
|
org=org,
|
||||||
|
repo=repo,
|
||||||
|
issue=_query_int(request, "issue"),
|
||||||
|
pr=_query_int(request, "pr"),
|
||||||
|
session=(request.query_params.get("session") or None),
|
||||||
|
limit=_query_int(request, "limit"),
|
||||||
|
offset=_query_int(request, "offset"),
|
||||||
|
comment_source=comment_source,
|
||||||
|
)
|
||||||
|
# A filter no surviving source can carry is refused, not answered empty:
|
||||||
|
# a 200 with zero events would tell the operator no such activity exists.
|
||||||
|
status_code = 200 if snapshot.ok else 422
|
||||||
|
return JSONResponse(timeline_snapshot_to_dict(snapshot), status_code=status_code)
|
||||||
|
|
||||||
|
|
||||||
async def method_not_allowed(request: Request, _exc: Exception) -> Response:
|
async def method_not_allowed(request: Request, _exc: Exception) -> Response:
|
||||||
path = request.url.path
|
path = request.url.path
|
||||||
if path in _AUDIT_MUTATION_PATHS and request.method == "POST":
|
if path in _AUDIT_MUTATION_PATHS and request.method == "POST":
|
||||||
@@ -488,6 +587,7 @@ def create_app(*, bind_host: str | None = None) -> Starlette:
|
|||||||
Route("/api/prompts", api_prompts, methods=["GET"]),
|
Route("/api/prompts", api_prompts, methods=["GET"]),
|
||||||
Route("/runtime", runtime, methods=["GET"]),
|
Route("/runtime", runtime, methods=["GET"]),
|
||||||
Route("/api/runtime", api_runtime, methods=["GET"]),
|
Route("/api/runtime", api_runtime, methods=["GET"]),
|
||||||
|
Route("/api/v1/timeline", api_v1_timeline, methods=["GET"]),
|
||||||
Route("/audit", audit, methods=["GET", "POST"]),
|
Route("/audit", audit, methods=["GET", "POST"]),
|
||||||
Route("/api/audit", api_audit, methods=["GET", "POST"]),
|
Route("/api/audit", api_audit, methods=["GET", "POST"]),
|
||||||
Route("/worktrees", worktrees, methods=["GET"]),
|
Route("/worktrees", worktrees, methods=["GET"]),
|
||||||
|
|||||||
@@ -0,0 +1,906 @@
|
|||||||
|
"""Workflow-event and conversation timeline model (#637, Phase 1).
|
||||||
|
|
||||||
|
Operators cannot browse a unified timeline of workflow events, decisions,
|
||||||
|
tool calls, and handoffs: the evidence is scattered across control-plane
|
||||||
|
events, Gitea canonical handoff comments, and local logs. This module defines
|
||||||
|
one durable, versioned event schema and per-source adapters that normalise
|
||||||
|
those scattered records into a single ``WorkflowEvent`` stream, plus a
|
||||||
|
read-only query layer (filter by issue / PR / session, stable ordering,
|
||||||
|
pagination) that the ``/api/v1/timeline`` route serves.
|
||||||
|
|
||||||
|
Design rules honoured here:
|
||||||
|
|
||||||
|
- **Read-only.** Sources are read; nothing is mutated. The control-plane
|
||||||
|
database is opened through a ``mode=ro`` URI so a missing or unwritable DB
|
||||||
|
degrades to a reason instead of creating directories or running migrations.
|
||||||
|
- **Fail-soft per source.** An unavailable source degrades to a status with a
|
||||||
|
reason rather than raising, and a source that could not run is never
|
||||||
|
rendered as an empty-and-healthy timeline.
|
||||||
|
- **Answerable filters only.** Each source declares which filter dimensions it
|
||||||
|
can actually answer. A filter dimension no source that ran can carry is
|
||||||
|
refused with an explicit reason rather than silently matching nothing: an
|
||||||
|
empty page from an unanswerable filter reads to an operator as "no such
|
||||||
|
activity", which is a different — and false — statement.
|
||||||
|
- **Redaction at the boundary, fail closed.** Every free-text field (event
|
||||||
|
messages, redacted tool arguments, decision/proof text) is run through the
|
||||||
|
console redaction policy before it leaves this module, and *before* any
|
||||||
|
structured value is derived from it — evidence references are extracted from
|
||||||
|
redacted text, then independently revalidated before serialization. An
|
||||||
|
unredactable value becomes the placeholder, and a value that cannot be proven
|
||||||
|
safe is dropped — an unredacted payload is never emitted, and a generation
|
||||||
|
error never drops raw data to a caller or a log.
|
||||||
|
- **Stable ordering.** Events sort by ``(timestamp, source_rank, event_key)``
|
||||||
|
with a deterministic tiebreak, so pagination is stable across calls and
|
||||||
|
events with equal or missing timestamps keep a fixed order.
|
||||||
|
|
||||||
|
Non-goals (from the issue): no full chat replay, no mutation of historical
|
||||||
|
events, no unredacted tool-argument storage.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import re
|
||||||
|
import sqlite3
|
||||||
|
from dataclasses import dataclass, replace
|
||||||
|
from datetime import datetime, timezone
|
||||||
|
from typing import Any, Callable, Iterable
|
||||||
|
|
||||||
|
import control_plane_db
|
||||||
|
from webui import console_redaction
|
||||||
|
|
||||||
|
# The schema is versioned so consumers can branch on shape. Bump on any
|
||||||
|
# breaking change to WorkflowEvent's serialized form.
|
||||||
|
TIMELINE_SCHEMA_VERSION = 1
|
||||||
|
|
||||||
|
# Known event sources and their deterministic ordering rank. When two events
|
||||||
|
# carry the same timestamp, the source rank breaks the tie before the
|
||||||
|
# per-source event key, so a control-plane event and a handoff comment minted
|
||||||
|
# in the same second always sort in a fixed order.
|
||||||
|
SOURCE_CONTROL_PLANE = "control_plane"
|
||||||
|
SOURCE_GITEA_HANDOFF = "gitea_handoff"
|
||||||
|
_SOURCE_RANK = {
|
||||||
|
SOURCE_CONTROL_PLANE: 0,
|
||||||
|
SOURCE_GITEA_HANDOFF: 1,
|
||||||
|
}
|
||||||
|
|
||||||
|
# The filter dimensions the query layer accepts.
|
||||||
|
FILTER_ISSUE = "issue"
|
||||||
|
FILTER_PR = "pr"
|
||||||
|
FILTER_SESSION = "session"
|
||||||
|
|
||||||
|
# Which dimensions each source can actually answer. This is a property of the
|
||||||
|
# underlying records, not of the query code: the control-plane ``events`` table
|
||||||
|
# is (event_id, work_item_id, event_type, message, created_at) and carries no
|
||||||
|
# session identity at all, so no control-plane event can ever match a session
|
||||||
|
# filter. A CTH handoff comment can declare its session as a field, so the
|
||||||
|
# handoff source answers all three. Filtering on a dimension the surviving
|
||||||
|
# sources cannot carry is refused in ``load_timeline`` rather than answered
|
||||||
|
# with an empty page.
|
||||||
|
_SOURCE_FILTER_SUPPORT: dict[str, tuple[str, ...]] = {
|
||||||
|
SOURCE_CONTROL_PLANE: (FILTER_ISSUE, FILTER_PR),
|
||||||
|
SOURCE_GITEA_HANDOFF: (FILTER_ISSUE, FILTER_PR, FILTER_SESSION),
|
||||||
|
}
|
||||||
|
|
||||||
|
# Why a source cannot answer a dimension, for the refusal reason an operator reads.
|
||||||
|
_SOURCE_FILTER_LIMITS: dict[tuple[str, str], str] = {
|
||||||
|
(SOURCE_CONTROL_PLANE, FILTER_SESSION): (
|
||||||
|
"control-plane events carry no session identity "
|
||||||
|
"(the events table has no session column)"
|
||||||
|
),
|
||||||
|
}
|
||||||
|
|
||||||
|
# A timestamp far in the future so events with no parseable timestamp sort
|
||||||
|
# last (after everything real) instead of first, without raising.
|
||||||
|
_MISSING_TS_SORT = "9999-12-31T23:59:59Z"
|
||||||
|
|
||||||
|
|
||||||
|
def _parse_ts(value: str | None) -> str | None:
|
||||||
|
"""Normalise a timestamp to ``...Z`` UTC, or None when unparseable."""
|
||||||
|
if not value:
|
||||||
|
return None
|
||||||
|
text = str(value).strip()
|
||||||
|
if not text:
|
||||||
|
return None
|
||||||
|
candidate = text[:-1] + "+00:00" if text.endswith("Z") else text
|
||||||
|
try:
|
||||||
|
parsed = datetime.fromisoformat(candidate)
|
||||||
|
except ValueError:
|
||||||
|
return None
|
||||||
|
if parsed.tzinfo is None:
|
||||||
|
parsed = parsed.replace(tzinfo=timezone.utc)
|
||||||
|
return parsed.astimezone(timezone.utc).replace(microsecond=0).isoformat().replace("+00:00", "Z")
|
||||||
|
|
||||||
|
|
||||||
|
def _redact(value: Any) -> Any:
|
||||||
|
"""Redact a single free-text field, failing closed to the placeholder."""
|
||||||
|
if value is None:
|
||||||
|
return None
|
||||||
|
return console_redaction.redact_text(str(value))
|
||||||
|
|
||||||
|
|
||||||
|
@dataclass(frozen=True)
|
||||||
|
class WorkflowEvent:
|
||||||
|
"""One normalised timeline event.
|
||||||
|
|
||||||
|
Every field is optional except ``source``/``event_type``/``event_key``
|
||||||
|
because sources carry different subsets. The class is frozen so an adapted
|
||||||
|
event is an immutable record; a consumer that needs a variant builds a new
|
||||||
|
one rather than mutating history.
|
||||||
|
"""
|
||||||
|
|
||||||
|
source: str
|
||||||
|
event_type: str
|
||||||
|
event_key: str
|
||||||
|
timestamp: str | None = None
|
||||||
|
actor: str | None = None
|
||||||
|
role: str | None = None
|
||||||
|
issue_number: int | None = None
|
||||||
|
pr_number: int | None = None
|
||||||
|
session_id: str | None = None
|
||||||
|
tool_name: str | None = None
|
||||||
|
decision: str | None = None
|
||||||
|
message: str | None = None
|
||||||
|
correlation_id: str | None = None
|
||||||
|
evidence_refs: tuple[str, ...] = ()
|
||||||
|
sensitive: bool = False
|
||||||
|
|
||||||
|
def sort_key(self) -> tuple[str, int, str]:
|
||||||
|
return (
|
||||||
|
self.timestamp or _MISSING_TS_SORT,
|
||||||
|
_SOURCE_RANK.get(self.source, 99),
|
||||||
|
self.event_key,
|
||||||
|
)
|
||||||
|
|
||||||
|
def to_dict(self) -> dict[str, Any]:
|
||||||
|
return {
|
||||||
|
"source": self.source,
|
||||||
|
"event_type": self.event_type,
|
||||||
|
"event_key": self.event_key,
|
||||||
|
"timestamp": self.timestamp,
|
||||||
|
"actor": self.actor,
|
||||||
|
"role": self.role,
|
||||||
|
"issue_number": self.issue_number,
|
||||||
|
"pr_number": self.pr_number,
|
||||||
|
"session_id": self.session_id,
|
||||||
|
"tool_name": self.tool_name,
|
||||||
|
"decision": self.decision,
|
||||||
|
"message": self.message,
|
||||||
|
"correlation_id": self.correlation_id,
|
||||||
|
"evidence_refs": list(self.evidence_refs),
|
||||||
|
"sensitive": self.sensitive,
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
# --------------------------------------------------------------------------- #
|
||||||
|
# Adapters — pure functions from a source's raw records to WorkflowEvents. #
|
||||||
|
# Each is total: a malformed record is skipped, never raised on. #
|
||||||
|
# --------------------------------------------------------------------------- #
|
||||||
|
|
||||||
|
# Event types whose payload is treated as sensitive and always redaction-hard
|
||||||
|
# (they can carry lease/session provenance or tool arguments).
|
||||||
|
_SENSITIVE_EVENT_HINTS = ("lease", "capability", "token", "auth", "secret")
|
||||||
|
|
||||||
|
# Reference tokens (issue/PR/comment ids) and SHAs parsed out of proof text.
|
||||||
|
_EVIDENCE_REF_RE = re.compile(r"(?:#|PR\s*#?|issue\s*#?|comment\s*#?)(\d+)", re.IGNORECASE)
|
||||||
|
|
||||||
|
# A commit reference is only recognised when the text *declares* it as one.
|
||||||
|
# A bare lowercase hex run is not evidence of anything: at 40 characters it is
|
||||||
|
# exactly the shape of a Gitea personal access token, and at 7 it also matches
|
||||||
|
# ordinary words such as "defaced". Requiring an anchoring keyword keeps real
|
||||||
|
# references ("commit abc1234", "at head a209756...", "base caaae9b6") usable
|
||||||
|
# while refusing to lift an undeclared secret-shaped run out of free text.
|
||||||
|
_SHA_RE = re.compile(
|
||||||
|
r"(?i:\b(?:commit|sha|head|base|parent|revision|rev|merge[- ]base)\b[\s:=@#]*)"
|
||||||
|
r"([0-9a-f]{7,40})\b"
|
||||||
|
)
|
||||||
|
|
||||||
|
# Shapes a serialized evidence reference is allowed to take. Anything else is
|
||||||
|
# dropped rather than emitted.
|
||||||
|
_REF_ISSUE_SHAPE = re.compile(r"^#[0-9]{1,9}$")
|
||||||
|
_REF_SHA_SHAPE = re.compile(r"^[0-9a-f]{7,40}$")
|
||||||
|
|
||||||
|
# A long undelimited hex run with no declaring context is treated as credential
|
||||||
|
# material wherever it appears, never as an identifier.
|
||||||
|
_BARE_SECRET_SHAPE = re.compile(r"^[0-9a-f]{32,}$")
|
||||||
|
|
||||||
|
# An event type reads like an identifier, but a stored one is externally
|
||||||
|
# influenced: any producer that writes the control-plane ``events`` table
|
||||||
|
# chooses the string. It reaches ``to_dict`` verbatim, so it is validated here
|
||||||
|
# rather than trusted because of where it came from.
|
||||||
|
_CP_EVENT_TYPE_SHAPE = re.compile(r"^[A-Za-z][A-Za-z0-9._:+-]{0,63}$")
|
||||||
|
|
||||||
|
# Emitted in place of a value that cannot be proven safe. Deliberately not a
|
||||||
|
# plausible workflow type: an unsafe value is refused, never quietly rewritten
|
||||||
|
# into a different valid-looking one that would misdescribe the record.
|
||||||
|
UNSAFE_EVENT_TYPE = "unsafe:redacted"
|
||||||
|
|
||||||
|
# Emitted for a CTH heading that is not a declared member of ``CTH_TYPES``. The
|
||||||
|
# contract is enforced on write (``format_cth_body``) and on assess; the read
|
||||||
|
# path the timeline uses enforces it too rather than assuming it was.
|
||||||
|
UNKNOWN_HANDOFF_EVENT_TYPE = "handoff:unrecognized"
|
||||||
|
|
||||||
|
# A source record id is a plain integer in both sources it comes from: the
|
||||||
|
# control-plane ``events`` primary key and a Gitea comment id. ``event_key`` is
|
||||||
|
# serialized verbatim and is the pagination tiebreak, so anything else is
|
||||||
|
# refused rather than interpolated into it.
|
||||||
|
_RECORD_ID_SHAPE = re.compile(r"^[0-9]{1,19}$")
|
||||||
|
|
||||||
|
|
||||||
|
def _kind_to_numbers(kind: str | None, number: int | None) -> tuple[int | None, int | None]:
|
||||||
|
"""Map a control-plane work-item (kind, number) to (issue_no, pr_no)."""
|
||||||
|
if number is None:
|
||||||
|
return (None, None)
|
||||||
|
if kind == "pr":
|
||||||
|
return (None, int(number))
|
||||||
|
if kind == "issue":
|
||||||
|
return (int(number), None)
|
||||||
|
return (None, None)
|
||||||
|
|
||||||
|
|
||||||
|
def _correlation_for(kind: str | None, number: int | None) -> str | None:
|
||||||
|
if number is None or kind not in ("issue", "pr"):
|
||||||
|
return None
|
||||||
|
return f"{kind}#{number}"
|
||||||
|
|
||||||
|
|
||||||
|
def _extract_evidence_refs(*texts: str | None) -> tuple[str, ...]:
|
||||||
|
"""Extract issue/PR and declared-commit references from **redacted** text.
|
||||||
|
|
||||||
|
Callers must pass text that has already been through :func:`_redact`; this
|
||||||
|
function derives a structured field from its input, so extracting ahead of
|
||||||
|
redaction would republish whatever redaction was about to remove. Every
|
||||||
|
reference is revalidated by :func:`_validated_evidence_refs` before it is
|
||||||
|
serialized.
|
||||||
|
"""
|
||||||
|
refs: list[str] = []
|
||||||
|
for text in texts:
|
||||||
|
if not text:
|
||||||
|
continue
|
||||||
|
for match in _EVIDENCE_REF_RE.finditer(text):
|
||||||
|
token = f"#{match.group(1)}"
|
||||||
|
if token not in refs:
|
||||||
|
refs.append(token)
|
||||||
|
for match in _SHA_RE.finditer(text):
|
||||||
|
token = match.group(1)
|
||||||
|
if token not in refs:
|
||||||
|
refs.append(token)
|
||||||
|
return tuple(refs)
|
||||||
|
|
||||||
|
|
||||||
|
def _validated_evidence_refs(refs: Iterable[str]) -> tuple[tuple[str, ...], bool]:
|
||||||
|
"""Independently revalidate references immediately before serialization.
|
||||||
|
|
||||||
|
Extraction is not trusted on its own. A reference survives only when it has
|
||||||
|
a known reference shape and is unchanged by a second redaction pass — a
|
||||||
|
value the redaction policy would alter is credential material that must not
|
||||||
|
be emitted as a structured field. A full 40-character SHA stays usable
|
||||||
|
because extraction only accepts a hex run the source text explicitly
|
||||||
|
declared as a commit. Returns ``(safe_refs, dropped_any)``; ``dropped_any``
|
||||||
|
marks the event sensitive so the drop is visible rather than silent.
|
||||||
|
"""
|
||||||
|
safe: list[str] = []
|
||||||
|
dropped = False
|
||||||
|
for ref in refs or ():
|
||||||
|
try:
|
||||||
|
token = str(ref).strip()
|
||||||
|
if not token:
|
||||||
|
continue
|
||||||
|
recognised = bool(_REF_ISSUE_SHAPE.match(token) or _REF_SHA_SHAPE.match(token))
|
||||||
|
if not recognised:
|
||||||
|
dropped = True
|
||||||
|
continue
|
||||||
|
if _redact(token) != token:
|
||||||
|
dropped = True
|
||||||
|
continue
|
||||||
|
if token not in safe:
|
||||||
|
safe.append(token)
|
||||||
|
except Exception:
|
||||||
|
# Fail closed: a reference that cannot be proven safe is dropped.
|
||||||
|
dropped = True
|
||||||
|
continue
|
||||||
|
return (tuple(safe), dropped)
|
||||||
|
|
||||||
|
|
||||||
|
def _safe_session_id(value: Any) -> str | None:
|
||||||
|
"""Return a session identifier only when it is safe to emit.
|
||||||
|
|
||||||
|
The value is authoritative source data — a session the record names for
|
||||||
|
itself — but it is still free text. It is dropped when redaction alters it
|
||||||
|
or when it is a bare secret-shaped hex run, so a credential parked in a
|
||||||
|
session field can never reach the payload or be echoed back by a filter.
|
||||||
|
"""
|
||||||
|
if value is None:
|
||||||
|
return None
|
||||||
|
text = str(value).strip()
|
||||||
|
if not text:
|
||||||
|
return None
|
||||||
|
if _BARE_SECRET_SHAPE.match(text):
|
||||||
|
return None
|
||||||
|
return text if _redact(text) == text else None
|
||||||
|
|
||||||
|
|
||||||
|
def _safe_record_id(value: Any) -> str | None:
|
||||||
|
"""Return a source record id only when it is a plain numeric identifier.
|
||||||
|
|
||||||
|
``event_key`` is serialized verbatim and is the deterministic pagination
|
||||||
|
tiebreak, so an id is interpolated into it only when it has the shape both
|
||||||
|
real sources actually produce. A record whose identity cannot be trusted is
|
||||||
|
refused by the caller rather than keyed on.
|
||||||
|
"""
|
||||||
|
if value is None or isinstance(value, bool):
|
||||||
|
return None
|
||||||
|
if isinstance(value, int):
|
||||||
|
return str(value)
|
||||||
|
text = str(value).strip()
|
||||||
|
return text if _RECORD_ID_SHAPE.match(text) else None
|
||||||
|
|
||||||
|
|
||||||
|
def _safe_cp_event_type(value: Any) -> tuple[str, bool]:
|
||||||
|
"""Validate a stored control-plane event type. Returns ``(type, unsafe)``.
|
||||||
|
|
||||||
|
The stored value is externally influenced — whichever producer wrote the
|
||||||
|
``events`` row chose the string — and ``to_dict`` serializes it verbatim, so
|
||||||
|
it passes a boundary of its own instead of relying on the one ``message``
|
||||||
|
passes. A value survives only when it is an ordinary identifier, is not a
|
||||||
|
bare secret-shaped hex run, and is unchanged by a redaction pass. Anything
|
||||||
|
else fails closed to :data:`UNSAFE_EVENT_TYPE`: the record stays visible as
|
||||||
|
an audit entry, but the value itself is never republished — not verbatim,
|
||||||
|
not partially sanitized, and not rewritten into some other valid-looking
|
||||||
|
type that would misdescribe what happened.
|
||||||
|
"""
|
||||||
|
text = ("" if value is None else str(value)).strip()
|
||||||
|
if not text:
|
||||||
|
return ("", False)
|
||||||
|
if _BARE_SECRET_SHAPE.match(text):
|
||||||
|
return (UNSAFE_EVENT_TYPE, True)
|
||||||
|
if not _CP_EVENT_TYPE_SHAPE.match(text):
|
||||||
|
return (UNSAFE_EVENT_TYPE, True)
|
||||||
|
if _redact(text) != text:
|
||||||
|
return (UNSAFE_EVENT_TYPE, True)
|
||||||
|
return (text, False)
|
||||||
|
|
||||||
|
|
||||||
|
def _safe_echo(value: Any) -> Any:
|
||||||
|
"""Guard a scalar that is echoed back rather than derived from a record.
|
||||||
|
|
||||||
|
Query scope and filter values are caller-supplied and are reflected in the
|
||||||
|
response so an operator can see what was asked. Reflection is still
|
||||||
|
emission: a value redaction would alter, or a bare secret-shaped hex run, is
|
||||||
|
replaced by the placeholder instead of being echoed verbatim. Ordinary
|
||||||
|
scope and filter values pass through untouched.
|
||||||
|
"""
|
||||||
|
if value is None or isinstance(value, (int, bool)):
|
||||||
|
return value
|
||||||
|
text = str(value)
|
||||||
|
if _BARE_SECRET_SHAPE.match(text.strip()):
|
||||||
|
return console_redaction.REDACTED
|
||||||
|
return _redact(text)
|
||||||
|
|
||||||
|
|
||||||
|
def adapt_cp_events(rows: Iterable[dict[str, Any]]) -> list[WorkflowEvent]:
|
||||||
|
"""Adapt control-plane ``events`` rows (joined to work_items) into events.
|
||||||
|
|
||||||
|
Each row is expected to carry ``event_id``, ``event_type``, ``message``,
|
||||||
|
``created_at`` and the joined work-item ``kind``/``number``. Rows missing
|
||||||
|
an id or type are skipped so a partially written table never raises.
|
||||||
|
"""
|
||||||
|
events: list[WorkflowEvent] = []
|
||||||
|
for row in rows or []:
|
||||||
|
try:
|
||||||
|
event_id = _safe_record_id(row.get("event_id"))
|
||||||
|
raw_event_type = (row.get("event_type") or "").strip()
|
||||||
|
if event_id is None or not raw_event_type:
|
||||||
|
continue
|
||||||
|
# The stored type is source data, not a trusted constant: validate
|
||||||
|
# it before it is serialized, exactly as `message` below is redacted
|
||||||
|
# before it is serialized.
|
||||||
|
event_type, event_type_unsafe = _safe_cp_event_type(raw_event_type)
|
||||||
|
kind = row.get("kind")
|
||||||
|
number = row.get("number")
|
||||||
|
issue_no, pr_no = _kind_to_numbers(kind, number)
|
||||||
|
sensitive = event_type_unsafe or any(
|
||||||
|
hint in raw_event_type.lower() for hint in _SENSITIVE_EVENT_HINTS
|
||||||
|
)
|
||||||
|
events.append(
|
||||||
|
WorkflowEvent(
|
||||||
|
source=SOURCE_CONTROL_PLANE,
|
||||||
|
event_type=event_type,
|
||||||
|
event_key=f"cp:{event_id}",
|
||||||
|
timestamp=_parse_ts(row.get("created_at")),
|
||||||
|
issue_number=issue_no,
|
||||||
|
pr_number=pr_no,
|
||||||
|
# No session_id: the control-plane events table is
|
||||||
|
# (event_id, work_item_id, event_type, message, created_at)
|
||||||
|
# and records no session. Inventing one from the work item
|
||||||
|
# or the message text would be a guess, so this source
|
||||||
|
# declares the session dimension unsupported instead
|
||||||
|
# (_SOURCE_FILTER_SUPPORT) and the query layer refuses a
|
||||||
|
# session filter it cannot honestly answer.
|
||||||
|
message=_redact(row.get("message")),
|
||||||
|
correlation_id=_correlation_for(kind, number),
|
||||||
|
sensitive=sensitive,
|
||||||
|
)
|
||||||
|
)
|
||||||
|
except Exception:
|
||||||
|
# A single malformed row must not sink the whole adaptation.
|
||||||
|
continue
|
||||||
|
return events
|
||||||
|
|
||||||
|
|
||||||
|
def adapt_cth_comments(
|
||||||
|
comments: Iterable[dict[str, Any]],
|
||||||
|
*,
|
||||||
|
kind: str,
|
||||||
|
number: int,
|
||||||
|
) -> list[WorkflowEvent]:
|
||||||
|
"""Adapt Gitea Canonical Thread Handoff (CTH) comments into events.
|
||||||
|
|
||||||
|
Only comments that parse as a CTH (``canonical_thread_handoff.parse_cth_comment``)
|
||||||
|
become events; ordinary comments are ignored. ``kind``/``number`` scope the
|
||||||
|
events to the issue or PR the comments belong to.
|
||||||
|
"""
|
||||||
|
# Imported lazily so this module has no import-time dependency on the
|
||||||
|
# handoff parser when only the control-plane adapter is used.
|
||||||
|
from canonical_thread_handoff import is_known_cth_type, parse_cth_comment
|
||||||
|
|
||||||
|
# ``kind``/``number`` are interpolated into event_key and correlation_id, so
|
||||||
|
# they are normalised once here. A scope this adapter cannot express is
|
||||||
|
# refused outright rather than serialized into an identifier.
|
||||||
|
kind = (kind or "").strip().lower()
|
||||||
|
if kind not in ("issue", "pr"):
|
||||||
|
return []
|
||||||
|
try:
|
||||||
|
number = int(number)
|
||||||
|
except (TypeError, ValueError):
|
||||||
|
return []
|
||||||
|
|
||||||
|
issue_no, pr_no = _kind_to_numbers(kind, number)
|
||||||
|
correlation = _correlation_for(kind, number)
|
||||||
|
events: list[WorkflowEvent] = []
|
||||||
|
for comment in comments or []:
|
||||||
|
try:
|
||||||
|
body = comment.get("body") or ""
|
||||||
|
parsed = parse_cth_comment(body)
|
||||||
|
if not parsed:
|
||||||
|
continue
|
||||||
|
fields = parsed.get("fields") or {}
|
||||||
|
cth_type = parsed.get("cth_type") or ""
|
||||||
|
comment_id = _safe_record_id(comment.get("id"))
|
||||||
|
if comment_id is None:
|
||||||
|
continue
|
||||||
|
# The CTH heading is free text: the parser accepts whatever follows
|
||||||
|
# "## CTH:", and only the write and assess paths check it against
|
||||||
|
# the contract. Check it here too — an unrecognised heading is
|
||||||
|
# reported as such rather than serialized into event_type, so
|
||||||
|
# arbitrary, malformed, or secret-shaped heading content has no way
|
||||||
|
# through. Declared types are preserved exactly.
|
||||||
|
cth_type_known = is_known_cth_type(cth_type)
|
||||||
|
# Redaction runs first, and every derived value is taken from the
|
||||||
|
# redacted text — deriving evidence refs from the raw proof would
|
||||||
|
# re-emit exactly what redaction was about to remove.
|
||||||
|
decision = _redact(fields.get("decision"))
|
||||||
|
proof = _redact(fields.get("proof"))
|
||||||
|
next_action = _redact(fields.get("next action"))
|
||||||
|
refs, refs_dropped = _validated_evidence_refs(
|
||||||
|
_extract_evidence_refs(proof, decision)
|
||||||
|
)
|
||||||
|
events.append(
|
||||||
|
WorkflowEvent(
|
||||||
|
source=SOURCE_GITEA_HANDOFF,
|
||||||
|
event_type=(
|
||||||
|
f"handoff:{cth_type.strip()}"
|
||||||
|
if cth_type_known
|
||||||
|
else UNKNOWN_HANDOFF_EVENT_TYPE
|
||||||
|
),
|
||||||
|
event_key=f"cth:{kind}:{number}:{comment_id}",
|
||||||
|
timestamp=_parse_ts(comment.get("created_at")),
|
||||||
|
actor=_redact((comment.get("user") or {}).get("login")),
|
||||||
|
role=_redact(fields.get("next owner")),
|
||||||
|
issue_number=issue_no,
|
||||||
|
pr_number=pr_no,
|
||||||
|
# A CTH names its own session when the producer records one;
|
||||||
|
# it is read from that declared field, never inferred from
|
||||||
|
# unrelated text.
|
||||||
|
session_id=_safe_session_id(fields.get("session")),
|
||||||
|
decision=decision,
|
||||||
|
message=next_action or _redact(fields.get("status")),
|
||||||
|
correlation_id=correlation,
|
||||||
|
evidence_refs=refs,
|
||||||
|
sensitive=refs_dropped or not cth_type_known,
|
||||||
|
)
|
||||||
|
)
|
||||||
|
except Exception:
|
||||||
|
continue
|
||||||
|
return events
|
||||||
|
|
||||||
|
|
||||||
|
# --------------------------------------------------------------------------- #
|
||||||
|
# Read-only control-plane event source. #
|
||||||
|
# --------------------------------------------------------------------------- #
|
||||||
|
|
||||||
|
_CP_EVENTS_QUERY = """
|
||||||
|
SELECT e.event_id AS event_id,
|
||||||
|
e.event_type AS event_type,
|
||||||
|
e.message AS message,
|
||||||
|
e.created_at AS created_at,
|
||||||
|
w.kind AS kind,
|
||||||
|
w.number AS number
|
||||||
|
FROM events e
|
||||||
|
JOIN work_items w ON e.work_item_id = w.work_item_id
|
||||||
|
WHERE w.remote = ? AND w.org = ? AND w.repo = ?
|
||||||
|
"""
|
||||||
|
|
||||||
|
|
||||||
|
@dataclass(frozen=True)
|
||||||
|
class SourceStatus:
|
||||||
|
"""Fail-soft status for one timeline source.
|
||||||
|
|
||||||
|
``supported_filters`` states which filter dimensions this source's records
|
||||||
|
can carry; ``unsupported_filters`` names the requested dimensions it cannot,
|
||||||
|
so an operator can see *why* a source contributed nothing rather than being
|
||||||
|
left to read an empty list as an absence of activity.
|
||||||
|
"""
|
||||||
|
|
||||||
|
name: str
|
||||||
|
ok: bool
|
||||||
|
reason: str | None = None
|
||||||
|
count: int = 0
|
||||||
|
supported_filters: tuple[str, ...] = ()
|
||||||
|
unsupported_filters: tuple[str, ...] = ()
|
||||||
|
|
||||||
|
def to_dict(self) -> dict[str, Any]:
|
||||||
|
return {
|
||||||
|
"name": self.name,
|
||||||
|
"ok": self.ok,
|
||||||
|
"reason": self.reason,
|
||||||
|
"count": self.count,
|
||||||
|
"supported_filters": list(self.supported_filters),
|
||||||
|
"unsupported_filters": list(self.unsupported_filters),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _cp_status(*, ok: bool, reason: str | None = None, count: int = 0) -> SourceStatus:
|
||||||
|
return SourceStatus(
|
||||||
|
SOURCE_CONTROL_PLANE,
|
||||||
|
ok=ok,
|
||||||
|
# A failure reason is serialized like any other field and is often an
|
||||||
|
# exception string carrying a path or a transport error, so it crosses
|
||||||
|
# the redaction boundary too. Static reasons pass through unchanged.
|
||||||
|
reason=_redact(reason),
|
||||||
|
count=count,
|
||||||
|
supported_filters=_SOURCE_FILTER_SUPPORT[SOURCE_CONTROL_PLANE],
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _handoff_status(*, ok: bool, reason: str | None = None, count: int = 0) -> SourceStatus:
|
||||||
|
return SourceStatus(
|
||||||
|
SOURCE_GITEA_HANDOFF,
|
||||||
|
ok=ok,
|
||||||
|
# Same boundary as the control-plane status: this reason can quote an
|
||||||
|
# error raised by a live authenticated fetch.
|
||||||
|
reason=_redact(reason),
|
||||||
|
count=count,
|
||||||
|
supported_filters=_SOURCE_FILTER_SUPPORT[SOURCE_GITEA_HANDOFF],
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def read_cp_events(
|
||||||
|
*,
|
||||||
|
remote: str,
|
||||||
|
org: str,
|
||||||
|
repo: str,
|
||||||
|
db_path: str | None = None,
|
||||||
|
) -> tuple[list[WorkflowEvent], SourceStatus]:
|
||||||
|
"""Read scoped control-plane events read-only. Never creates the DB.
|
||||||
|
|
||||||
|
Opens the SQLite file through a ``mode=ro`` URI: a health/timeline read
|
||||||
|
must never create directories or run the schema migration that
|
||||||
|
``ControlPlaneDB()`` performs on construction. A missing or unreadable DB
|
||||||
|
degrades to a status with a reason.
|
||||||
|
"""
|
||||||
|
path = (db_path or control_plane_db.default_db_path()).strip()
|
||||||
|
conn: sqlite3.Connection | None = None
|
||||||
|
try:
|
||||||
|
conn = sqlite3.connect(f"file:{path}?mode=ro", uri=True)
|
||||||
|
conn.row_factory = sqlite3.Row
|
||||||
|
cursor = conn.execute(_CP_EVENTS_QUERY, (remote, org, repo))
|
||||||
|
rows = [dict(r) for r in cursor.fetchall()]
|
||||||
|
except sqlite3.OperationalError as exc:
|
||||||
|
return ([], _cp_status(ok=False, reason=f"control-plane DB unavailable: {exc}"))
|
||||||
|
except sqlite3.Error as exc:
|
||||||
|
return ([], _cp_status(ok=False, reason=f"control-plane read failed: {exc}"))
|
||||||
|
finally:
|
||||||
|
if conn is not None:
|
||||||
|
conn.close()
|
||||||
|
events = adapt_cp_events(rows)
|
||||||
|
return (events, _cp_status(ok=True, count=len(events)))
|
||||||
|
|
||||||
|
|
||||||
|
# --------------------------------------------------------------------------- #
|
||||||
|
# Filter, sort, paginate. #
|
||||||
|
# --------------------------------------------------------------------------- #
|
||||||
|
|
||||||
|
|
||||||
|
def filter_events(
|
||||||
|
events: Iterable[WorkflowEvent],
|
||||||
|
*,
|
||||||
|
issue: int | None = None,
|
||||||
|
pr: int | None = None,
|
||||||
|
session: str | None = None,
|
||||||
|
) -> list[WorkflowEvent]:
|
||||||
|
"""Filter events by issue number, PR number, and/or session id.
|
||||||
|
|
||||||
|
Filters are conjunctive. A filter that names a dimension an event does not
|
||||||
|
carry excludes that event (an issue filter excludes PR-only events).
|
||||||
|
"""
|
||||||
|
out: list[WorkflowEvent] = []
|
||||||
|
for ev in events:
|
||||||
|
if issue is not None and ev.issue_number != issue:
|
||||||
|
continue
|
||||||
|
if pr is not None and ev.pr_number != pr:
|
||||||
|
continue
|
||||||
|
if session is not None and ev.session_id != session:
|
||||||
|
continue
|
||||||
|
out.append(ev)
|
||||||
|
return out
|
||||||
|
|
||||||
|
|
||||||
|
def sort_events(events: Iterable[WorkflowEvent]) -> list[WorkflowEvent]:
|
||||||
|
"""Return events in stable timeline order (ascending)."""
|
||||||
|
return sorted(events, key=lambda ev: ev.sort_key())
|
||||||
|
|
||||||
|
|
||||||
|
@dataclass(frozen=True)
|
||||||
|
class TimelinePage:
|
||||||
|
"""One page of the sorted, filtered timeline."""
|
||||||
|
|
||||||
|
events: tuple[WorkflowEvent, ...]
|
||||||
|
total: int
|
||||||
|
limit: int
|
||||||
|
offset: int
|
||||||
|
|
||||||
|
@property
|
||||||
|
def next_offset(self) -> int | None:
|
||||||
|
nxt = self.offset + len(self.events)
|
||||||
|
return nxt if nxt < self.total else None
|
||||||
|
|
||||||
|
def to_dict(self) -> dict[str, Any]:
|
||||||
|
return {
|
||||||
|
"events": [ev.to_dict() for ev in self.events],
|
||||||
|
"pagination": {
|
||||||
|
"total": self.total,
|
||||||
|
"limit": self.limit,
|
||||||
|
"offset": self.offset,
|
||||||
|
"returned": len(self.events),
|
||||||
|
"next_offset": self.next_offset,
|
||||||
|
"has_more": self.next_offset is not None,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
_MAX_LIMIT = 500
|
||||||
|
_DEFAULT_LIMIT = 50
|
||||||
|
|
||||||
|
|
||||||
|
def _coerce_bounds(limit: int | None, offset: int | None) -> tuple[int, int]:
|
||||||
|
try:
|
||||||
|
lim = int(limit) if limit is not None else _DEFAULT_LIMIT
|
||||||
|
except (TypeError, ValueError):
|
||||||
|
lim = _DEFAULT_LIMIT
|
||||||
|
try:
|
||||||
|
off = int(offset) if offset is not None else 0
|
||||||
|
except (TypeError, ValueError):
|
||||||
|
off = 0
|
||||||
|
lim = max(1, min(lim, _MAX_LIMIT))
|
||||||
|
off = max(0, off)
|
||||||
|
return (lim, off)
|
||||||
|
|
||||||
|
|
||||||
|
def paginate(events: list[WorkflowEvent], *, limit: int | None, offset: int | None) -> TimelinePage:
|
||||||
|
lim, off = _coerce_bounds(limit, offset)
|
||||||
|
window = events[off : off + lim]
|
||||||
|
return TimelinePage(events=tuple(window), total=len(events), limit=lim, offset=off)
|
||||||
|
|
||||||
|
|
||||||
|
# --------------------------------------------------------------------------- #
|
||||||
|
# Composition — load_timeline aggregates all sources, fail-soft. #
|
||||||
|
# --------------------------------------------------------------------------- #
|
||||||
|
|
||||||
|
# A comment source is a callable that, given (kind, number), returns the raw
|
||||||
|
# Gitea comment list for that issue/PR. The route supplies a live fail-soft
|
||||||
|
# fetcher; tests supply a fixture. When None, the handoff source is reported as
|
||||||
|
# not-run (never silently empty-and-healthy).
|
||||||
|
CommentSource = Callable[[str, int], list[dict[str, Any]]]
|
||||||
|
|
||||||
|
|
||||||
|
@dataclass(frozen=True)
|
||||||
|
class TimelineSnapshot:
|
||||||
|
"""One answered timeline query.
|
||||||
|
|
||||||
|
``ok`` is False when the query could not be answered as asked — currently
|
||||||
|
when a requested filter dimension no surviving source can carry was
|
||||||
|
supplied. The page is then empty *and* the snapshot says so, because an
|
||||||
|
``ok`` empty page is a claim that no such activity exists.
|
||||||
|
"""
|
||||||
|
|
||||||
|
schema_version: int
|
||||||
|
remote: str
|
||||||
|
org: str
|
||||||
|
repo: str
|
||||||
|
filters: dict[str, Any]
|
||||||
|
page: TimelinePage
|
||||||
|
sources: tuple[SourceStatus, ...]
|
||||||
|
ok: bool = True
|
||||||
|
error: dict[str, Any] | None = None
|
||||||
|
|
||||||
|
def to_dict(self) -> dict[str, Any]:
|
||||||
|
return {
|
||||||
|
"ok": self.ok,
|
||||||
|
"error": self.error,
|
||||||
|
"schema_version": self.schema_version,
|
||||||
|
# Scope and filters are echoed caller input, not derived record
|
||||||
|
# data. Reflecting a value is still emitting it, so both cross the
|
||||||
|
# same boundary; ordinary scope and filter values are unchanged.
|
||||||
|
"scope": {
|
||||||
|
"remote": _safe_echo(self.remote),
|
||||||
|
"org": _safe_echo(self.org),
|
||||||
|
"repo": _safe_echo(self.repo),
|
||||||
|
},
|
||||||
|
"filters": {key: _safe_echo(value) for key, value in self.filters.items()},
|
||||||
|
"sources": [s.to_dict() for s in self.sources],
|
||||||
|
**self.page.to_dict(),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _unanswerable_reasons(
|
||||||
|
statuses: Iterable[SourceStatus], unanswerable: Iterable[str]
|
||||||
|
) -> list[dict[str, str]]:
|
||||||
|
"""Explain, per source, why each unanswerable dimension went unanswered."""
|
||||||
|
out: list[dict[str, str]] = []
|
||||||
|
for status in statuses:
|
||||||
|
for dim in unanswerable:
|
||||||
|
if dim not in status.supported_filters:
|
||||||
|
reason = _SOURCE_FILTER_LIMITS.get(
|
||||||
|
(status.name, dim), f"this source's records carry no {dim} identity"
|
||||||
|
)
|
||||||
|
elif not status.ok:
|
||||||
|
reason = (
|
||||||
|
f"this source can carry {dim} but did not run: "
|
||||||
|
f"{status.reason or 'unavailable'}"
|
||||||
|
)
|
||||||
|
else:
|
||||||
|
continue
|
||||||
|
out.append({"source": status.name, "filter": dim, "reason": reason})
|
||||||
|
return out
|
||||||
|
|
||||||
|
|
||||||
|
def load_timeline(
|
||||||
|
*,
|
||||||
|
remote: str,
|
||||||
|
org: str,
|
||||||
|
repo: str,
|
||||||
|
issue: int | None = None,
|
||||||
|
pr: int | None = None,
|
||||||
|
session: str | None = None,
|
||||||
|
limit: int | None = None,
|
||||||
|
offset: int | None = None,
|
||||||
|
db_path: str | None = None,
|
||||||
|
comment_source: CommentSource | None = None,
|
||||||
|
) -> TimelineSnapshot:
|
||||||
|
"""Aggregate every timeline source into one filtered, paginated snapshot.
|
||||||
|
|
||||||
|
Sources are read independently and fail soft: an unavailable source
|
||||||
|
contributes a ``SourceStatus`` with ``ok=False`` and a reason, and never
|
||||||
|
collapses the whole timeline. The handoff source only runs when a specific
|
||||||
|
issue or PR is requested (a handoff comment belongs to one thread) and a
|
||||||
|
``comment_source`` is available; otherwise it is reported as ``not run``
|
||||||
|
rather than as an empty-and-healthy source.
|
||||||
|
|
||||||
|
A filter dimension that no surviving source can carry — a ``session``
|
||||||
|
filter when the only source that ran is the control plane, whose events
|
||||||
|
record no session — is refused with ``ok=False`` and a structured error
|
||||||
|
instead of being answered with an empty page.
|
||||||
|
"""
|
||||||
|
all_events: list[WorkflowEvent] = []
|
||||||
|
statuses: list[SourceStatus] = []
|
||||||
|
|
||||||
|
cp_events, cp_status = read_cp_events(remote=remote, org=org, repo=repo, db_path=db_path)
|
||||||
|
all_events.extend(cp_events)
|
||||||
|
statuses.append(cp_status)
|
||||||
|
|
||||||
|
# Gitea handoff comments are thread-scoped: only fetch when the caller
|
||||||
|
# narrowed to one issue or PR, and only when a source was provided.
|
||||||
|
handoff_target: tuple[str, int] | None = None
|
||||||
|
if pr is not None:
|
||||||
|
handoff_target = ("pr", pr)
|
||||||
|
elif issue is not None:
|
||||||
|
handoff_target = ("issue", issue)
|
||||||
|
|
||||||
|
if handoff_target is None:
|
||||||
|
statuses.append(
|
||||||
|
_handoff_status(
|
||||||
|
ok=False,
|
||||||
|
reason="not run: handoff comments are thread-scoped; filter by issue or pr to include them",
|
||||||
|
)
|
||||||
|
)
|
||||||
|
elif comment_source is None:
|
||||||
|
statuses.append(
|
||||||
|
_handoff_status(
|
||||||
|
ok=False,
|
||||||
|
reason="not run: no comment source configured for this timeline read",
|
||||||
|
)
|
||||||
|
)
|
||||||
|
else:
|
||||||
|
kind, number = handoff_target
|
||||||
|
try:
|
||||||
|
comments = comment_source(kind, number) or []
|
||||||
|
handoff_events = adapt_cth_comments(comments, kind=kind, number=number)
|
||||||
|
all_events.extend(handoff_events)
|
||||||
|
statuses.append(_handoff_status(ok=True, count=len(handoff_events)))
|
||||||
|
except Exception as exc: # fail soft: a fetch/parse error degrades this source only
|
||||||
|
statuses.append(_handoff_status(ok=False, reason=f"handoff source failed: {exc}"))
|
||||||
|
|
||||||
|
requested = tuple(
|
||||||
|
name
|
||||||
|
for name, value in ((FILTER_ISSUE, issue), (FILTER_PR, pr), (FILTER_SESSION, session))
|
||||||
|
if value is not None
|
||||||
|
)
|
||||||
|
statuses = [
|
||||||
|
replace(
|
||||||
|
status,
|
||||||
|
unsupported_filters=tuple(
|
||||||
|
dim for dim in requested if dim not in status.supported_filters
|
||||||
|
),
|
||||||
|
)
|
||||||
|
for status in statuses
|
||||||
|
]
|
||||||
|
filters = {"issue": issue, "pr": pr, "session": session}
|
||||||
|
|
||||||
|
# A dimension is answerable only if a source that actually ran can carry it.
|
||||||
|
# If none can, refuse: an empty page would assert "no such activity", which
|
||||||
|
# is a claim this timeline is not in a position to make.
|
||||||
|
answerable: set[str] = set()
|
||||||
|
for status in statuses:
|
||||||
|
if status.ok:
|
||||||
|
answerable.update(status.supported_filters)
|
||||||
|
unanswerable = tuple(dim for dim in requested if dim not in answerable)
|
||||||
|
|
||||||
|
if unanswerable:
|
||||||
|
return TimelineSnapshot(
|
||||||
|
schema_version=TIMELINE_SCHEMA_VERSION,
|
||||||
|
remote=remote,
|
||||||
|
org=org,
|
||||||
|
repo=repo,
|
||||||
|
filters=filters,
|
||||||
|
page=paginate([], limit=limit, offset=offset),
|
||||||
|
sources=tuple(statuses),
|
||||||
|
ok=False,
|
||||||
|
error={
|
||||||
|
"code": "filter_not_supported",
|
||||||
|
"unsupported_filters": list(unanswerable),
|
||||||
|
"detail": (
|
||||||
|
"no timeline source that ran can answer "
|
||||||
|
+ ", ".join(f"'{dim}'" for dim in unanswerable)
|
||||||
|
+ "; the result is refused rather than returned empty"
|
||||||
|
),
|
||||||
|
"sources": _unanswerable_reasons(statuses, unanswerable),
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
filtered = filter_events(all_events, issue=issue, pr=pr, session=session)
|
||||||
|
ordered = sort_events(filtered)
|
||||||
|
page = paginate(ordered, limit=limit, offset=offset)
|
||||||
|
|
||||||
|
return TimelineSnapshot(
|
||||||
|
schema_version=TIMELINE_SCHEMA_VERSION,
|
||||||
|
remote=remote,
|
||||||
|
org=org,
|
||||||
|
repo=repo,
|
||||||
|
filters=filters,
|
||||||
|
page=page,
|
||||||
|
sources=tuple(statuses),
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def snapshot_to_dict(snapshot: TimelineSnapshot) -> dict[str, Any]:
|
||||||
|
return snapshot.to_dict()
|
||||||
+271
-4
@@ -34,7 +34,11 @@ import subprocess
|
|||||||
from datetime import datetime, timezone
|
from datetime import datetime, timezone
|
||||||
from typing import Any
|
from typing import Any
|
||||||
|
|
||||||
from merged_cleanup_reconcile import branch_worktree_folder, read_local_worktree_state
|
from merged_cleanup_reconcile import (
|
||||||
|
branch_worktree_folder,
|
||||||
|
is_head_ancestor_of_ref,
|
||||||
|
read_local_worktree_state,
|
||||||
|
)
|
||||||
from reviewer_worktree import parse_dirty_tracked_files, REVIEW_WORKTREE_RE
|
from reviewer_worktree import parse_dirty_tracked_files, REVIEW_WORKTREE_RE
|
||||||
|
|
||||||
PROTECTED_BRANCHES = frozenset({"master", "main", "dev"})
|
PROTECTED_BRANCHES = frozenset({"master", "main", "dev"})
|
||||||
@@ -67,6 +71,14 @@ REMOVABLE_CLASSES = frozenset(
|
|||||||
{CLASS_CLEAN_STALE_REMOVABLE, CLASS_DETACHED_REVIEW_LEFTOVER}
|
{CLASS_CLEAN_STALE_REMOVABLE, CLASS_DETACHED_REVIEW_LEFTOVER}
|
||||||
)
|
)
|
||||||
|
|
||||||
|
# Merged-PR linkage outcomes for issue worktrees (#858). Only ``LINKAGE_MERGED``
|
||||||
|
# is ownership proof; every other outcome leaves the worktree protected.
|
||||||
|
LINKAGE_MERGED = "merged_pr"
|
||||||
|
LINKAGE_OPEN = "open_pr"
|
||||||
|
LINKAGE_NONE = "no_owning_pr"
|
||||||
|
LINKAGE_AMBIGUOUS = "ambiguous"
|
||||||
|
LINKAGE_UNKNOWN = "unknown"
|
||||||
|
|
||||||
_ISSUE_REF_RE = re.compile(r"issue-(\d+)", re.IGNORECASE)
|
_ISSUE_REF_RE = re.compile(r"issue-(\d+)", re.IGNORECASE)
|
||||||
_ISSUE_BRANCH_PREFIXES = ("feat/", "fix/", "docs/", "chore/")
|
_ISSUE_BRANCH_PREFIXES = ("feat/", "fix/", "docs/", "chore/")
|
||||||
|
|
||||||
@@ -169,6 +181,186 @@ def is_ttl_expired(
|
|||||||
return (now_dt - last).total_seconds() > ttl_hours * 3600.0
|
return (now_dt - last).total_seconds() > ttl_hours * 3600.0
|
||||||
|
|
||||||
|
|
||||||
|
def build_pr_index(prs: list[dict[str, Any]] | None) -> dict[str, list[dict[str, Any]]]:
|
||||||
|
"""Index PR records by head branch for deterministic worktree linkage (#858).
|
||||||
|
|
||||||
|
Accepts Gitea PR payloads (``head`` as a dict) and pre-flattened records
|
||||||
|
(``head_branch``/``head_sha``). Records without a usable head branch or
|
||||||
|
number are dropped rather than guessed at, so a branch is only ever linked
|
||||||
|
to a PR the caller actually proved.
|
||||||
|
"""
|
||||||
|
index: dict[str, list[dict[str, Any]]] = {}
|
||||||
|
for pr in prs or []:
|
||||||
|
head = pr.get("head")
|
||||||
|
if isinstance(head, dict):
|
||||||
|
head_branch = head.get("ref")
|
||||||
|
head_sha = head.get("sha")
|
||||||
|
else:
|
||||||
|
head_branch = pr.get("head_branch") or (head if isinstance(head, str) else None)
|
||||||
|
head_sha = pr.get("head_sha")
|
||||||
|
number = pr.get("number")
|
||||||
|
if not head_branch or number is None:
|
||||||
|
continue
|
||||||
|
try:
|
||||||
|
pr_number = int(number)
|
||||||
|
except (TypeError, ValueError):
|
||||||
|
continue
|
||||||
|
index.setdefault(str(head_branch).strip(), []).append(
|
||||||
|
{
|
||||||
|
"pr_number": pr_number,
|
||||||
|
"head_branch": str(head_branch).strip(),
|
||||||
|
"head_sha": head_sha,
|
||||||
|
"merged": bool(pr.get("merged") or pr.get("merged_at")),
|
||||||
|
"state": pr.get("state"),
|
||||||
|
}
|
||||||
|
)
|
||||||
|
return index
|
||||||
|
|
||||||
|
|
||||||
|
def resolve_owning_pr(
|
||||||
|
*,
|
||||||
|
branch: str | None,
|
||||||
|
pr_index: dict[str, list[dict[str, Any]]] | None,
|
||||||
|
) -> dict[str, Any]:
|
||||||
|
"""Resolve the single PR that owns ``branch``, failing closed when unclear.
|
||||||
|
|
||||||
|
Ownership is only ``LINKAGE_MERGED`` when exactly one PR claims the branch
|
||||||
|
and that PR is merged. Several distinct PRs on one branch is a competing
|
||||||
|
claim (``LINKAGE_AMBIGUOUS``), and a still-open owner is reported as
|
||||||
|
``LINKAGE_OPEN`` — both keep the worktree protected while still exposing
|
||||||
|
the PR number the audit resolved.
|
||||||
|
"""
|
||||||
|
if pr_index is None:
|
||||||
|
return {
|
||||||
|
"status": LINKAGE_UNKNOWN,
|
||||||
|
"pr_number": None,
|
||||||
|
"candidate_pr_numbers": [],
|
||||||
|
"reasons": ["live PR state was not supplied; ownership unproven"],
|
||||||
|
}
|
||||||
|
branch_name = (branch or "").strip()
|
||||||
|
if not branch_name:
|
||||||
|
return {
|
||||||
|
"status": LINKAGE_UNKNOWN,
|
||||||
|
"pr_number": None,
|
||||||
|
"candidate_pr_numbers": [],
|
||||||
|
"reasons": ["worktree has no attached branch; ownership unproven"],
|
||||||
|
}
|
||||||
|
|
||||||
|
candidates = list(pr_index.get(branch_name) or [])
|
||||||
|
numbers = sorted({c["pr_number"] for c in candidates})
|
||||||
|
if not candidates:
|
||||||
|
return {
|
||||||
|
"status": LINKAGE_NONE,
|
||||||
|
"pr_number": None,
|
||||||
|
"candidate_pr_numbers": [],
|
||||||
|
"reasons": [f"no PR claims branch '{branch_name}'"],
|
||||||
|
}
|
||||||
|
if len(numbers) > 1:
|
||||||
|
return {
|
||||||
|
"status": LINKAGE_AMBIGUOUS,
|
||||||
|
"pr_number": None,
|
||||||
|
"candidate_pr_numbers": numbers,
|
||||||
|
"reasons": [
|
||||||
|
f"branch '{branch_name}' is claimed by competing PRs {numbers}; "
|
||||||
|
"ownership is ambiguous"
|
||||||
|
],
|
||||||
|
}
|
||||||
|
|
||||||
|
owner = candidates[0]
|
||||||
|
pr_number = owner["pr_number"]
|
||||||
|
if owner.get("head_branch") != branch_name:
|
||||||
|
return {
|
||||||
|
"status": LINKAGE_UNKNOWN,
|
||||||
|
"pr_number": pr_number,
|
||||||
|
"candidate_pr_numbers": numbers,
|
||||||
|
"reasons": [
|
||||||
|
f"PR #{pr_number} head branch '{owner.get('head_branch')}' does not "
|
||||||
|
f"match worktree branch '{branch_name}'"
|
||||||
|
],
|
||||||
|
}
|
||||||
|
if not owner.get("merged"):
|
||||||
|
return {
|
||||||
|
"status": LINKAGE_OPEN,
|
||||||
|
"pr_number": pr_number,
|
||||||
|
"candidate_pr_numbers": numbers,
|
||||||
|
"pr_head_sha": owner.get("head_sha"),
|
||||||
|
"reasons": [f"owning PR #{pr_number} is not merged"],
|
||||||
|
}
|
||||||
|
return {
|
||||||
|
"status": LINKAGE_MERGED,
|
||||||
|
"pr_number": pr_number,
|
||||||
|
"candidate_pr_numbers": numbers,
|
||||||
|
"pr_head_sha": owner.get("head_sha"),
|
||||||
|
"reasons": [],
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def assess_merged_pr_worktree_cleanup(
|
||||||
|
*,
|
||||||
|
linkage: dict[str, Any] | None,
|
||||||
|
head_sha: str | None,
|
||||||
|
head_in_master: bool | None,
|
||||||
|
is_dirty: bool,
|
||||||
|
has_open_pr: bool,
|
||||||
|
has_active_lease: bool,
|
||||||
|
has_active_issue_lock: bool,
|
||||||
|
is_protected: bool,
|
||||||
|
has_live_session: bool = False,
|
||||||
|
) -> dict[str, Any]:
|
||||||
|
"""Decide whether a merged issue worktree satisfies the full cleanup policy.
|
||||||
|
|
||||||
|
Every condition must be independently proven: conclusive merged-PR
|
||||||
|
ownership, agreement between the worktree branch and the PR head branch,
|
||||||
|
containment of the worktree head in authoritative master (which is what
|
||||||
|
proves no unmerged commits remain), absence of any open/competing PR,
|
||||||
|
lease, issue lock, or live session, a clean tree, and a worktree that is
|
||||||
|
not the protected control checkout. Anything unknown blocks.
|
||||||
|
"""
|
||||||
|
link = linkage or {
|
||||||
|
"status": LINKAGE_UNKNOWN,
|
||||||
|
"pr_number": None,
|
||||||
|
"reasons": ["no linkage assessment supplied"],
|
||||||
|
}
|
||||||
|
status = link.get("status")
|
||||||
|
reasons: list[str] = []
|
||||||
|
|
||||||
|
if status != LINKAGE_MERGED:
|
||||||
|
reasons.extend(
|
||||||
|
link.get("reasons") or ["owning PR could not be conclusively identified"]
|
||||||
|
)
|
||||||
|
if is_protected:
|
||||||
|
reasons.append("worktree is protected or the stable control checkout")
|
||||||
|
if is_dirty:
|
||||||
|
reasons.append("worktree has uncommitted changes")
|
||||||
|
if has_open_pr:
|
||||||
|
reasons.append("worktree branch has an open PR")
|
||||||
|
if has_active_lease:
|
||||||
|
reasons.append("worktree has an active lease")
|
||||||
|
if has_active_issue_lock:
|
||||||
|
reasons.append("an active issue lock references this branch")
|
||||||
|
if has_live_session:
|
||||||
|
reasons.append("a live process or session is using this worktree")
|
||||||
|
if not head_sha:
|
||||||
|
reasons.append("worktree head sha is unknown")
|
||||||
|
if head_in_master is None:
|
||||||
|
reasons.append("containment of the worktree head in master is unknown")
|
||||||
|
elif not head_in_master:
|
||||||
|
reasons.append(
|
||||||
|
"worktree head is not contained in authoritative master "
|
||||||
|
"(unmerged commits remain)"
|
||||||
|
)
|
||||||
|
|
||||||
|
proven = not reasons
|
||||||
|
return {
|
||||||
|
"linkage_status": status,
|
||||||
|
"pr_number": link.get("pr_number"),
|
||||||
|
"pr_head_sha": link.get("pr_head_sha"),
|
||||||
|
"head_in_master": head_in_master,
|
||||||
|
"proven": proven,
|
||||||
|
"block_reasons": reasons,
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
def classify_worktree(
|
def classify_worktree(
|
||||||
*,
|
*,
|
||||||
workflow_type: str,
|
workflow_type: str,
|
||||||
@@ -181,6 +373,8 @@ def classify_worktree(
|
|||||||
ttl_expired: bool = False,
|
ttl_expired: bool = False,
|
||||||
is_protected: bool = False,
|
is_protected: bool = False,
|
||||||
metadata_known: bool = True,
|
metadata_known: bool = True,
|
||||||
|
merged_pr_cleanup: dict[str, Any] | None = None,
|
||||||
|
has_live_session: bool = False,
|
||||||
) -> str:
|
) -> str:
|
||||||
"""Classify a worktree, safety-first: any preservation signal wins.
|
"""Classify a worktree, safety-first: any preservation signal wins.
|
||||||
|
|
||||||
@@ -199,6 +393,8 @@ def classify_worktree(
|
|||||||
return CLASS_ACTIVE_ISSUE_WORK # never auto-deleted (criterion 8)
|
return CLASS_ACTIVE_ISSUE_WORK # never auto-deleted (criterion 8)
|
||||||
if has_active_issue_lock:
|
if has_active_issue_lock:
|
||||||
return CLASS_ACTIVE_ISSUE_WORK
|
return CLASS_ACTIVE_ISSUE_WORK
|
||||||
|
if has_live_session:
|
||||||
|
return CLASS_ACTIVE_ISSUE_WORK # a live session still owns this tree
|
||||||
if not metadata_known or workflow_type == WORKFLOW_UNKNOWN:
|
if not metadata_known or workflow_type == WORKFLOW_UNKNOWN:
|
||||||
return CLASS_UNSAFE_UNKNOWN # never auto-deleted without proof
|
return CLASS_UNSAFE_UNKNOWN # never auto-deleted without proof
|
||||||
|
|
||||||
@@ -207,7 +403,15 @@ def classify_worktree(
|
|||||||
if is_detached or branch_gone:
|
if is_detached or branch_gone:
|
||||||
return CLASS_DETACHED_REVIEW_LEFTOVER
|
return CLASS_DETACHED_REVIEW_LEFTOVER
|
||||||
return CLASS_CLEAN_STALE_REMOVABLE
|
return CLASS_CLEAN_STALE_REMOVABLE
|
||||||
# issue_work / conflict_fix: only removable once the TTL has expired.
|
if workflow_type == WORKFLOW_ISSUE_WORK:
|
||||||
|
# #858: an issue worktree becomes removable only on authoritative
|
||||||
|
# merged-PR evidence satisfying the whole cleanup policy. Age alone
|
||||||
|
# never proves the branch landed, so TTL cannot qualify one by itself
|
||||||
|
# — otherwise a worktree holding unmerged commits would be reclaimed.
|
||||||
|
if (merged_pr_cleanup or {}).get("proven"):
|
||||||
|
return CLASS_CLEAN_STALE_REMOVABLE
|
||||||
|
return CLASS_ACTIVE_ISSUE_WORK
|
||||||
|
# conflict_fix: only removable once the TTL has expired.
|
||||||
if ttl_expired:
|
if ttl_expired:
|
||||||
return CLASS_CLEAN_STALE_REMOVABLE
|
return CLASS_CLEAN_STALE_REMOVABLE
|
||||||
return CLASS_ACTIVE_ISSUE_WORK
|
return CLASS_ACTIVE_ISSUE_WORK
|
||||||
@@ -400,6 +604,20 @@ def remove_worktree(project_root: str, path: str) -> dict[str, Any]:
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def head_contained_in_ref(
|
||||||
|
project_root: str, head_sha: str | None, ref: str | None
|
||||||
|
) -> bool | None:
|
||||||
|
"""Return True when ``head_sha`` is already contained in ``ref``.
|
||||||
|
|
||||||
|
Shares :mod:`merged_cleanup_reconcile`'s ancestry check so the audit and
|
||||||
|
the PR-scoped reconciler agree on what "already landed" means (#858).
|
||||||
|
Returns None when containment cannot be determined, which fails closed.
|
||||||
|
"""
|
||||||
|
if not head_sha or not ref:
|
||||||
|
return None
|
||||||
|
return is_head_ancestor_of_ref(project_root, head_sha, ref)
|
||||||
|
|
||||||
|
|
||||||
def _is_under_branches(project_root: str, path: str) -> bool:
|
def _is_under_branches(project_root: str, path: str) -> bool:
|
||||||
branches_root = os.path.join(os.path.abspath(project_root), "branches")
|
branches_root = os.path.join(os.path.abspath(project_root), "branches")
|
||||||
return os.path.abspath(path or "").startswith(branches_root + os.sep)
|
return os.path.abspath(path or "").startswith(branches_root + os.sep)
|
||||||
@@ -413,16 +631,30 @@ def audit_branches_directory(
|
|||||||
active_issue_branches: set[str] | None = None,
|
active_issue_branches: set[str] | None = None,
|
||||||
now: datetime | str | None = None,
|
now: datetime | str | None = None,
|
||||||
ttl_hours: float = DEFAULT_TTL_HOURS,
|
ttl_hours: float = DEFAULT_TTL_HOURS,
|
||||||
|
pr_index: dict[str, list[dict[str, Any]]] | None = None,
|
||||||
|
leased_issue_numbers: set[int] | None = None,
|
||||||
|
live_session_paths: set[str] | None = None,
|
||||||
|
master_ref: str | None = None,
|
||||||
) -> dict[str, Any]:
|
) -> dict[str, Any]:
|
||||||
"""Classify every session-owned worktree under ``branches/``.
|
"""Classify every session-owned worktree under ``branches/``.
|
||||||
|
|
||||||
Read-only: shells out to git for discovery and dirty state, then applies
|
Read-only: shells out to git for discovery and dirty state, then applies
|
||||||
the pure classifier. Returns per-worktree classifications, counts, the
|
the pure classifier. Returns per-worktree classifications, counts, the
|
||||||
list of removable candidates, and the ``git worktree list`` proof.
|
list of removable candidates, and the ``git worktree list`` proof.
|
||||||
|
|
||||||
|
``pr_index`` (see :func:`build_pr_index`) supplies the authoritative PR
|
||||||
|
ownership used to link issue worktrees to their merged PR (#858).
|
||||||
|
``master_ref`` is the ref a worktree head must be contained in before it
|
||||||
|
can be considered landed. Both are optional and their absence only ever
|
||||||
|
fails closed: without them no issue worktree becomes removable.
|
||||||
"""
|
"""
|
||||||
open_pr_branches = open_pr_branches or set()
|
open_pr_branches = open_pr_branches or set()
|
||||||
leased_branches = leased_branches or set()
|
leased_branches = leased_branches or set()
|
||||||
active_issue_branches = active_issue_branches or set()
|
active_issue_branches = active_issue_branches or set()
|
||||||
|
leased_issue_numbers = leased_issue_numbers or set()
|
||||||
|
live_session_paths = {
|
||||||
|
os.path.abspath(p) for p in (live_session_paths or set()) if p
|
||||||
|
}
|
||||||
|
|
||||||
worktrees: list[dict[str, Any]] = []
|
worktrees: list[dict[str, Any]] = []
|
||||||
for entry in list_worktrees(project_root):
|
for entry in list_worktrees(project_root):
|
||||||
@@ -433,12 +665,42 @@ def audit_branches_directory(
|
|||||||
)
|
)
|
||||||
dirty_state = read_worktree_dirty(path)
|
dirty_state = read_worktree_dirty(path)
|
||||||
is_dirty = bool(dirty_state.get("dirty"))
|
is_dirty = bool(dirty_state.get("dirty"))
|
||||||
|
head_sha = entry.get("head")
|
||||||
|
linkage = resolve_owning_pr(branch=branch, pr_index=pr_index)
|
||||||
metadata = build_worktree_metadata(
|
metadata = build_worktree_metadata(
|
||||||
path=path, branch=branch, head_sha=entry.get("head")
|
path=path,
|
||||||
|
branch=branch,
|
||||||
|
head_sha=head_sha,
|
||||||
|
pr_number=linkage.get("pr_number"),
|
||||||
)
|
)
|
||||||
has_open_pr = bool(branch) and branch in open_pr_branches
|
has_open_pr = bool(branch) and branch in open_pr_branches
|
||||||
has_active_lease = bool(branch) and branch in leased_branches
|
# A lease on issue N protects that issue's own work worktree. It must
|
||||||
|
# not incidentally protect a baseline/review scratch tree that merely
|
||||||
|
# carries the same issue marker in its name, which would change the
|
||||||
|
# classification of worktrees this policy does not own.
|
||||||
|
has_active_lease = (bool(branch) and branch in leased_branches) or (
|
||||||
|
metadata["workflow_type"] == WORKFLOW_ISSUE_WORK
|
||||||
|
and metadata.get("issue_number") is not None
|
||||||
|
and metadata["issue_number"] in leased_issue_numbers
|
||||||
|
)
|
||||||
has_active_lock = bool(branch) and branch in active_issue_branches
|
has_active_lock = bool(branch) and branch in active_issue_branches
|
||||||
|
has_live_session = bool(path) and os.path.abspath(path) in live_session_paths
|
||||||
|
head_in_master = (
|
||||||
|
head_contained_in_ref(project_root, head_sha, master_ref)
|
||||||
|
if master_ref
|
||||||
|
else None
|
||||||
|
)
|
||||||
|
merged_pr_cleanup = assess_merged_pr_worktree_cleanup(
|
||||||
|
linkage=linkage,
|
||||||
|
head_sha=head_sha,
|
||||||
|
head_in_master=head_in_master,
|
||||||
|
is_dirty=is_dirty,
|
||||||
|
has_open_pr=has_open_pr,
|
||||||
|
has_active_lease=has_active_lease,
|
||||||
|
has_active_issue_lock=has_active_lock,
|
||||||
|
is_protected=is_protected,
|
||||||
|
has_live_session=has_live_session,
|
||||||
|
)
|
||||||
ttl_expired = is_ttl_expired(
|
ttl_expired = is_ttl_expired(
|
||||||
last_used_at=metadata.get("last_used_at"), now=now, ttl_hours=ttl_hours
|
last_used_at=metadata.get("last_used_at"), now=now, ttl_hours=ttl_hours
|
||||||
)
|
)
|
||||||
@@ -452,6 +714,8 @@ def audit_branches_directory(
|
|||||||
branch_gone=branch is None and not entry.get("detached"),
|
branch_gone=branch is None and not entry.get("detached"),
|
||||||
ttl_expired=ttl_expired,
|
ttl_expired=ttl_expired,
|
||||||
is_protected=is_protected,
|
is_protected=is_protected,
|
||||||
|
merged_pr_cleanup=merged_pr_cleanup,
|
||||||
|
has_live_session=has_live_session,
|
||||||
)
|
)
|
||||||
metadata["cleanup_eligibility"] = classification
|
metadata["cleanup_eligibility"] = classification
|
||||||
worktrees.append(
|
worktrees.append(
|
||||||
@@ -463,7 +727,10 @@ def audit_branches_directory(
|
|||||||
"has_open_pr": has_open_pr,
|
"has_open_pr": has_open_pr,
|
||||||
"has_active_lease": has_active_lease,
|
"has_active_lease": has_active_lease,
|
||||||
"has_active_issue_lock": has_active_lock,
|
"has_active_issue_lock": has_active_lock,
|
||||||
|
"has_live_session": has_live_session,
|
||||||
"is_protected": is_protected,
|
"is_protected": is_protected,
|
||||||
|
"merged_pr_linkage": linkage,
|
||||||
|
"merged_pr_cleanup": merged_pr_cleanup,
|
||||||
"classification": classification,
|
"classification": classification,
|
||||||
"removable": is_removable(classification),
|
"removable": is_removable(classification),
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user